IntExponential::getNextValue() - Code Metrics - Inspection of "in progress" - Smoren/sequence-php - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 8dfa4a...e4531b )

by Smoren

created 2022-12-29 09:37 UTC

IntExponential::getNextValue() A

↳ Parent: IntExponential

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes

Metric	Value
eloc	1
c	0
b	0
f	0
dl	0
loc	3
ccs	2
cts	2
cp	1
rs	10
cc	1
nc	1
nop	1
crap	1

<?php

declare(strict_types=1);

namespace Smoren\Sequence\Structs;

/**
 * {@inheritDoc}
 */
class IntExponential extends IntSequence
{
    /**
     * @param int $index
     * @return int
     */
    public function getValueByIndex(int $index): int
    {
        return (int)($this->start * ($this->step ** $index));
    }

    /**
     * @return int
     */
    public function getStartValue(): int
    {
        return $this->getValueByIndex(0);
interface HasName {
    /** @return string */
    public function getName();
}

class Name {
    public $name;
}

class User implements HasName {
    /** @return string|Name */
    public function getName() {
        return new Name('foo'); // This is a violation of the ``HasName`` interface
                                // which only allows a string value to be returned.
    }
}
    }

    /**
     * @param int $previousValue
     * @return int
     */
    public function getNextValue($previousValue): int
    {
        return $previousValue * $this->step;
interface HasName {
    /** @return string */
    public function getName();
}

class Name {
    public $name;
}

class User implements HasName {
    /** @return string|Name */
    public function getName() {
        return new Name('foo'); // This is a violation of the ``HasName`` interface
                                // which only allows a string value to be returned.
    }
}
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Smoren\Sequence\Structs;
6
7		/**
8		* {@inheritDoc}
9		*/
10		class IntExponential extends IntSequence
11		{
12		/**
13		* @param int $index
14		* @return int
15		*/
16	3	public function getValueByIndex(int $index): int
17		{
18	3	return (int)($this->start * ($this->step ** $index));
19		}
20
21		/**
22		* @return int
23		*/
24	3	public function getStartValue(): int
25		{
26	3	return $this->getValueByIndex(0);
		0 ignored issues – show Bug Best Practice introduced 2022-12-29 08:51 UTC by Report Bug Copy Issue Report The expression `return $this->getValueByIndex(0)` returns the type `integer` which is incompatible with the return type mandated by `Smoren\Sequence\Interfac...erface::getStartValue()` of `Smoren\Sequence\Interfaces\T`. In the issue above, the returned value is violating the contract defined by the mentioned interface. Let's take a look at an example: interface HasName { /** @return string / public function getName(); } class Name { public $name; } class User implements HasName { /* @return string\|Name */ public function getName() { return new Name('foo'); // This is a violation of the ``HasName`` interface // which only allows a string value to be returned. } } Loading history...
27		}
28
29		/**
30		* @param int $previousValue
31		* @return int
32		*/
33	3	public function getNextValue($previousValue): int
34		{
35	3	return $previousValue * $this->step;
		0 ignored issues – show Bug Best Practice introduced 2022-12-29 09:39 UTC by Report Bug Copy Issue Report The expression `return $previousValue * $this->step` returns the type `integer` which is incompatible with the return type mandated by `Smoren\Sequence\Interfac...terface::getNextValue()` of `Smoren\Sequence\Interfaces\T`. In the issue above, the returned value is violating the contract defined by the mentioned interface. Let's take a look at an example: interface HasName { /** @return string / public function getName(); } class Name { public $name; } class User implements HasName { /* @return string\|Name */ public function getName() { return new Name('foo'); // This is a violation of the ``HasName`` interface // which only allows a string value to be returned. } } Loading history...
36		}
37		}
38

Smoren / sequence-php

Push — master ( 8dfa4a...e4531b )

IntExponential::getNextValue() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like