Smoren\Containers\Structs\LinkedListIterator

Complexity

Total Complexity

6

Size/Duplication

Total Lines	59
Duplicated Lines	0 %

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	key()	0	3	1
A	next()	0	3	1
A	valid()	0	3	1
A	__construct()	0	3	1
A	rewind()	0	3	1
A	current()	0	3	1

<?php

namespace Smoren\Containers\Structs;

use Iterator;

/**
 * Class LinkedListIterator
 */
class LinkedListIterator implements Iterator
{
    /**
     * @var LinkedList iterator owner
     */
    protected LinkedList $owner;
    /**
     * @var LinkedListItem|null current position
     */
    protected ?LinkedListItem $position = null;

    /**
     * LinkedListIterator constructor.
     * @param LinkedList $owner iterator owner
     */
    public function __construct(LinkedList $owner)
    {
        $this->owner = $owner;
    }

    /**
     * @inheritDoc
     */
    public function current()
    {
        return $this->position->getData();

The method getData() does not exist on null.

    }

    /**
     * @inheritDoc
     */
    public function next(): void
    {
        $this->position = $this->position->getNext();
    }

    /**
     * @inheritDoc
     * @return LinkedListItem
     */
    public function key(): LinkedListItem
    {
        return $this->position;

The expression return $this->position could return the type null which is incompatible with the type-hinted return Smoren\Containers\Structs\LinkedListItem. Consider adding an additional type-check to rule them out.

    }

    /**
     * @inheritDoc
     */
    public function valid(): bool
    {
        return $this->position !== null;
    }

    /**
     * @inheritDoc
     */
    public function rewind(): void
    {
        $this->position = $this->owner->getFirst();
    }
}