Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
14 | trait InteractsWithFiles |
||
15 | { |
||
16 | |||
17 | /** |
||
18 | * @var Filesystem |
||
19 | */ |
||
20 | protected $disk; |
||
21 | |||
22 | /** |
||
23 | * @param string $path |
||
24 | * @param string|resource $contents |
||
25 | * @param bool $inBasePath |
||
26 | * |
||
27 | * @return bool |
||
28 | */ |
||
29 | View Code Duplication | protected function createFile(string $path, $contents, bool $inBasePath = false) : bool |
|
39 | |||
40 | /** |
||
41 | * @param string $path |
||
42 | * @param bool $inBasePath |
||
43 | * |
||
44 | * @return bool |
||
45 | */ |
||
46 | View Code Duplication | protected function createDir(string $path, bool $inBasePath = false) : bool |
|
56 | |||
57 | /** |
||
58 | * @param string $path |
||
59 | * @param bool $inBasePath |
||
60 | * |
||
61 | * @return string |
||
62 | */ |
||
63 | abstract protected function getPath(string $path, bool $inBasePath = false) : string; |
||
64 | } |
||
65 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.