SmartWeb\ModuleTesting\Console\Command\GenerateCest

Complexity

Total Complexity

3

Size/Duplication

Total Lines	62
Duplicated Lines	91.94 %

Coupling/Cohesion

Components	1
Dependencies	6

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	provideArguments()	5	8	1
B	handle()	24	24	2

<?php


namespace SmartWeb\ModuleTesting\Console\Command;

use Exception;
use SmartWeb\ModuleTesting\Codeception\SmartWeb\Setup;
use SmartWeb\ModuleTesting\Console\CommandArgument;
use SmartWeb\ModuleTesting\Console\CommandArguments;
use SmartWeb\ModuleTesting\Console\InputArgumentType;
use SmartWeb\ModuleTesting\Generator\CestGenerator;


/**
 * Command for generating a Codeception cest for a Module.
 *
 * @package SmartWeb\ModuleTesting\Console
 */
class GenerateCest extends BaseCommand

This class seems to be duplicated in your project.

{
    
    /**
     * The console command name.
     *
     * @var string
     */
    protected $name = 'make-cest';
    
    /**
     * The console command description.
     *
     * @var string
     */
    protected $description = 'Generate a Codeception Cest for the given module and suite';
    
    /**
     * Execute the console command.
     *
     * @return void
     *
     * @throws Exception
     */
    public function handle()
    {
        /**
         * @var string $moduleName
         * @var string $suite
         * @var string $name
         */
        $moduleName = $this->argument('moduleName');
        $suite = $this->argument('suite');
        $name = $this->argument('name');
        
        $this->info("Creating '{$name}' for module '{$moduleName}' in suite '{$suite}'.");
        
        $setup = new Setup($moduleName);
        
        try {
            $generator = new CestGenerator($setup, $suite, $name);

It seems like $suite defined by $this->argument('suite') on line 51 can also be of type array; however, SmartWeb\ModuleTesting\Generator\CestGenerator::__construct() does only seem to accept string, maybe add an additional type check?

It seems like $name defined by $this->argument('name') on line 52 can also be of type array; however, SmartWeb\ModuleTesting\Generator\CestGenerator::__construct() does only seem to accept string, maybe add an additional type check?

            $generator->generate();
            $this->info("Created test!");
        } catch (Exception $e) {
            $this->error("Failed to create test!");
            throw $e;
        }
    }
    
    /**
     * @return CommandArguments
     */
    protected function provideArguments() : CommandArguments
    {
        return new CommandArguments([
            new CommandArgument('moduleName', InputArgumentType::required(), 'The name of the module.'),
            new CommandArgument('suite', InputArgumentType::required(), 'The suite to generate test in.'),
            new CommandArgument('name', InputArgumentType::required(), 'The name of the test.'),
        ]);
    }
    
}