Governor\Framework\Repository\LockingRepository

Complexity

Total Complexity

11

Size/Duplication

Total Lines	79
Duplicated Lines	63.29 %

Coupling/Cohesion

Components	1
Dependencies	4

Test Coverage

Coverage

62.16%

Importance

Changes	5
Bugs	1	Features	1

7 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	add()	12	12	2
A	load()	12	12	2
A	doDelete()	13	13	3
A	doSave()	13	13	3
	doSaveWithLock()	0	1	?
	doDeleteWithLock()	0	1	?

<?php

/*
 * To change this license header, choose License Headers in Project Properties.
 * To change this template file, choose Tools | Templates
 * and open the template in the editor.
 */

namespace Governor\Framework\Repository;

use Governor\Framework\Domain\AggregateRootInterface;
use Governor\Framework\EventHandling\EventBusInterface;

/**
 * Description of LockingRepository
 *
 * @author    "David Kalosi" <david.kalosi@gmail.com>  
 * @license   <a href="http://www.opensource.org/licenses/mit-license.php">MIT License</a> 
 */
abstract class LockingRepository extends AbstractRepository
{

    private $lockManager;

    public function __construct($className, EventBusInterface $eventBus, LockManagerInterface $lockManager)
    {
        parent::__construct($className, $eventBus);
        $this->lockManager = $lockManager;
    }

    public function add(AggregateRootInterface $object)

This method seems to be duplicated in your project.

    {
        $aggregateId = $object->getIdentifier();
        $this->lockManager->obtainLock($aggregateId);

        try {
            parent::add($object);
        } catch (\Exception $ex) {
            $this->lockManager->releaseLock($aggregateId);
            throw $ex;
        }
    }

    public function load($id, $expectedVersion = null)

This method seems to be duplicated in your project.

    {
        $this->lockManager->obtainLock($id);
        try {
            $object = parent::load($id, $expectedVersion);

            return $object;
        } catch (\Exception $ex) {
            $this->lockManager->releaseLock($id);
            throw $ex;
        }
    }

    protected function doDelete(AggregateRootInterface $object)

This method seems to be duplicated in your project.

    {
        if (null !== $object->getVersion() && !$this->lockManager->validateLock($object)) {
            throw new ConcurrencyException(sprintf(
                "The aggregate of type [%s] with identifier [%s] could not be " .
                "saved, as a valid lock is not held. Either another thread has saved an aggregate, or " .
                "the current thread had released its lock earlier on.",
                get_class($object), $object->getIdentifier()
            ));
        }

        $this->doDeleteWithLock($object);
    }

    protected function doSave(AggregateRootInterface $object)

This method seems to be duplicated in your project.

    {
        if (null !== $object->getVersion() && !$this->lockManager->validateLock($object)) {
            throw new ConcurrencyException(sprintf(
                "The aggregate of type [%s] with identifier [%s] could not be "
                . "saved, as a valid lock is not held. Either another thread has saved an aggregate, or "
                . "the current thread had released its lock earlier on.",
                get_class($object), $object->getIdentifier()
            ));
        }

        $this->doSaveWithLock($object);
    }

    /**
     * Perform the actual saving of the aggregate. All necessary locks have been verified.
     *
     * @param AggregateRootInterface $aggregate the aggregate to store
     */
    protected abstract function doSaveWithLock(AggregateRootInterface $aggregate);

The abstract declaration must precede the visibility declaration

    /**
     * Perform the actual deleting of the aggregate. All necessary locks have been verifierd.
     *
     * @param AggregateRootInterface $aggregate the aggregate to delete
     */
    protected abstract function doDeleteWithLock(AggregateRootInterface $aggregate);

The abstract declaration must precede the visibility declaration

}