Governor\Framework\CommandHandling\Distributed\CommandReceiver

Complexity

Total Complexity

8

Size/Duplication

Total Lines	107
Duplicated Lines	17.76 %

Coupling/Cohesion

Components	1
Dependencies	7

Test Coverage

Coverage

0%

Importance

Changes	4
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	7	1
A	run()	0	16	3
B	processCommand()	19	40	3
A	setLogger()	0	4	1

<?php

/*
 * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
 * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
 * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
 * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
 * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
 * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 *
 * The software is based on the Axon Framework project which is
 * licensed under the Apache 2.0 license. For more information on the Axon Framework
 * see <http://www.axonframework.org/>.
 *
 * This software consists of voluntary contributions made by many individuals
 * and is licensed under the MIT license. For more information, see
 * <http://www.governor-framework.org/>.
 */

namespace Governor\Framework\CommandHandling\Distributed;

use Governor\Framework\CommandHandling\Callbacks\ClosureCommandCallback;
use Governor\Framework\CommandHandling\Callbacks\ResultCallback;
use Governor\Framework\Common\ReceiverInterface;
use Governor\Framework\CommandHandling\CommandBusInterface;
use Governor\Framework\Serializer\SerializerInterface;
use Psr\Log\LoggerAwareInterface;
use Governor\Framework\Common\Logging\NullLogger;
use Psr\Log\LoggerInterface;

/**
 * Receiver that forwards incoming distributed commands to the local command bus.
 *
 * @author    "David Kalosi" <david.kalosi@gmail.com>
 * @license   <a href="http://www.opensource.org/licenses/mit-license.php">MIT License</a>
 */
class CommandReceiver implements ReceiverInterface, LoggerAwareInterface
{
    /**
     * @var RedisTemplate
     */
    private $template;

    /**
     * @var CommandBusInterface
     */
    private $localSegment;

    /**
     * @var SerializerInterface
     */
    private $serializer;

    /**
     * @var LoggerInterface
     */
    private $logger;

    /**
     * @param RedisTemplate $template
     * @param CommandBusInterface $localSegment
     * @param SerializerInterface $serializer
     */
    function __construct(RedisTemplate $template, CommandBusInterface $localSegment, SerializerInterface $serializer)

It is generally recommended to explicitly declare the visibility for methods.

    {
        $this->template = $template;
        $this->localSegment = $localSegment;
        $this->serializer = $serializer;
        $this->logger = new NullLogger();
    }

    // TODO daemonize: interrupts, shutdown etc
    public function run()
    {
        while (true) {
            try {
                $this->processCommand();
            } catch (\Exception $ex) {
                $this->logger->error(
                    'Exception on node {node} while processing command: {message}',
                    [
                        'node' => $this->template->getNodeName(),
                        'message' => $ex->getMessage()
                    ]
                );
            }
        }
    }

    public function processCommand()
    {
        $data = $this->template->dequeueCommand();

        if (null === $data) {
            $this->logger->info('Timeout while waiting for commands, re-entering loop');
            return;
        }

        $dispatchMessage = DispatchMessage::fromBytes($this->serializer, $data[1]);
        $self = $this;

        $successCallback = function ($result) use ($dispatchMessage, $self) {

This code seems to be duplicated across your project.

            $message = new ReplyMessage(
                $dispatchMessage->getCommandIdentifier(),
                $self->serializer,
                $result
            );

            $self->template->writeCommandReply($dispatchMessage->getCommandIdentifier(), $message->toBytes());
        };

        $failureCallback = function (\Exception $cause) use ($dispatchMessage, $self) {

This code seems to be duplicated across your project.

            $message = new ReplyMessage(
                $dispatchMessage->getCommandIdentifier(),
                $self->serializer,
                $cause,
                false
            );

            $self->template->writeCommandReply($dispatchMessage->getCommandIdentifier(), $message->toBytes());
        };

        $this->localSegment->dispatch(
            $dispatchMessage->getCommandMessage(),
            $dispatchMessage->isExpectReply() ? new ClosureCommandCallback(
                $successCallback, $failureCallback
            ) : null
        );
    }

    /**
     * Sets a logger instance on the object
     *
     * @param LoggerInterface $logger
     * @return null
     */
    public function setLogger(LoggerInterface $logger)
    {
        $this->logger = $logger;
    }


}