SmartGecko / GovernorBundle

DependencyInjection/Compiler/EventHandlerPass.php

<?php

/*
 * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
 * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
 * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
 * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
 * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
 * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 *
 * The software is based on the Axon Framework project which is
 * licensed under the Apache 2.0 license. For more information on the Axon Framework
 * see <http://www.axonframework.org/>.
 *
 * This software consists of voluntary contributions made by many individuals
 * and is licensed under the MIT license. For more information, see
 * <http://www.governor-framework.org/>.
 */

namespace Governor\Bundle\GovernorBundle\Command;

namespace Governor\Bundle\GovernorBundle\DependencyInjection\Compiler;

use Symfony\Component\DependencyInjection\Reference;

USE declarations must go after the first namespace declaration

use Symfony\Component\DependencyInjection\ContainerBuilder;

USE declarations must go after the first namespace declaration

use Governor\Framework\Annotations\EventHandler;

USE declarations must go after the first namespace declaration

use Governor\Framework\EventHandling\EventListenerInterface;

USE declarations must go after the first namespace declaration

use Governor\Framework\Common\Annotation\MethodMessageHandlerInspector;

USE declarations must go after the first namespace declaration

use Governor\Framework\EventHandling\Listeners\AnnotatedEventListener;

USE declarations must go after the first namespace declaration

/**
 * Compiler pass that subscribes all services tagged with <code>governor.event_handler</code>
 * to the event bus.
 *
 * @author    "David Kalosi" <david.kalosi@gmail.com>
 * @license   <a href="http://www.opensource.org/licenses/mit-license.php">MIT License</a>
 */
class EventHandlerPass extends AbstractHandlerPass
{

    /**
     * @param ContainerBuilder $container
     */
    public function process(ContainerBuilder $container)
    {
        foreach ($container->findTaggedServiceIds('governor.event_handler') as $id => $attributes) {
            $busDefinition = $container->findDefinition(

$busDefinition is not used, you could remove the assignment.

                sprintf(
                    "governor.event_bus.%s",
                    isset($attributes['event_bus']) ? $attributes['event_bus']
                        : 'default'
                )
            );

            $registry = $container->findDefinition(
                sprintf(
                    "governor.event_bus.registry.%s",
                    isset($attributes['event_bus']) ? $attributes['event_bus']
                        : 'default'
                )
            );

            $definition = $container->findDefinition($id);
            $reflectionClass = new \ReflectionClass($definition->getClass());

            // subscribe event listener instances directly
            if ($reflectionClass->implementsInterface(EventListenerInterface::class)) {
                $registry->addMethodCall('subscribe', [new Reference($id)]);
            }

            $inspector = new MethodMessageHandlerInspector(
                $container->get('governor.annotation_reader_factory'),

$container->get('governor.annotation_reader_factory') is of type object|null, but the function expects a object<Governor\Framework\Common\Annotation\AnnotationReaderFactoryInterface>.

                $reflectionClass,
                EventHandler::class
            );

            foreach ($inspector->getHandlerDefinitions() as $handlerDefinition) {

This code seems to be duplicated across your project.

                $handlerId = $this->getHandlerIdentifier('governor.event_handler');

                $container
                    ->register($handlerId, AnnotatedEventListener::class)
                    ->addArgument($handlerDefinition->getPayloadType())
                    ->addArgument($handlerDefinition->getMethod()->name)
                    ->addArgument(new Reference($id))
                    ->setPublic(true)
                    ->setLazy(true);

                $registry->addMethodCall(
                    'subscribe',
                    [new Reference($handlerId)]
                );
            }
        }
    }

}