CommandHandlerPass::process() - Code Metrics - SmartGecko/GovernorBundle - Measure and Improve Code Quality continuously with Scrutinizer

CommandHandlerPass::process() B
last analyzed 2015-12-21 19:45 UTC

↳ Parent: CommandHandlerPass

Complexity

Conditions	4
Paths	3

Size

Total Lines	40
Code Lines	25

Duplication

Lines	18
Ratio	45 %

Code Coverage

Tests	31
CRAP Score	4.0005

Importance

Changes	3
Bugs	0	Features	0

Metric	Value
dl	18
loc	40
ccs	31
cts	32
cp	0.9688
rs	8.5806
c	3
b	0
f	0
cc	4
eloc	25
nc	3
nop	1
crap	4.0005

<?php

/*
 * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
 * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
 * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
 * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
 * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
 * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 *
 * The software is based on the Axon Framework project which is
 * licensed under the Apache 2.0 license. For more information on the Axon Framework
 * see <http://www.axonframework.org/>.
 *
 * This software consists of voluntary contributions made by many individuals
 * and is licensed under the MIT license. For more information, see
 * <http://www.governor-framework.org/>.
 */

namespace Governor\Bundle\GovernorBundle\Command;

namespace Governor\Bundle\GovernorBundle\DependencyInjection\Compiler;

use Governor\Framework\Annotations\CommandHandler;

use Governor\Framework\CommandHandling\Handlers\AnnotatedCommandHandler;

use Governor\Framework\Common\Annotation\MethodMessageHandlerInspector;

use Symfony\Component\DependencyInjection\Reference;

use Symfony\Component\DependencyInjection\ContainerBuilder;


/**
 * Finds all services tagged as command handlers and registers them in the appropriate command handler registry.
 *
 * @author    "David Kalosi" <[email protected]>
 * @license   <a href="http://www.opensource.org/licenses/mit-license.php">MIT License</a>
 */
class CommandHandlerPass extends AbstractHandlerPass
{

    /**
     * @param ContainerBuilder $container
     */
    public function process(ContainerBuilder $container)
    {
        foreach ($container->findTaggedServiceIds('governor.command_handler') as $id => $attributes) {
            $bus = $container->findDefinition(
                sprintf(
                    "governor.command_bus.%s",
                    isset($attributes[0]['command_bus']) ? $attributes[0]['command_bus']
                        : 'default'
                )
            );

            $definition = $container->findDefinition($id);
            $class = $definition->getClass();

            $inspector = new MethodMessageHandlerInspector(
                $container->get('governor.annotation_reader_factory'),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                new \ReflectionClass($class),
                CommandHandler::class
            );

            foreach ($inspector->getHandlerDefinitions() as $handlerDefinition) {

                $handlerId = $this->getHandlerIdentifier("governor.command_handler");

                $container->register($handlerId, AnnotatedCommandHandler::class)
                    ->addArgument($class)
                    ->addArgument($handlerDefinition->getMethod()->name)
                    ->addArgument(new Reference('governor.parameter_resolver_factory'))
                    ->addArgument(new Reference($id))
                    ->setPublic(true)
                    ->setLazy(true);

                $bus->addMethodCall('subscribe',
                    [
                        $handlerDefinition->getPayloadType(),
                        new Reference($handlerId)
                    ]
                );
            }
        }
    }

}


1			<?php
2
3			/*
4			* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
5			* "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
6			* LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
7			* A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
8			* OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
9			* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
10			* LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
11			* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
12			* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
13			* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
14			* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
15			*
16			* The software is based on the Axon Framework project which is
17			* licensed under the Apache 2.0 license. For more information on the Axon Framework
18			* see <http://www.axonframework.org/>.
19			*
20			* This software consists of voluntary contributions made by many individuals
21			* and is licensed under the MIT license. For more information, see
22			* <http://www.governor-framework.org/>.
23			*/
24
25			namespace Governor\Bundle\GovernorBundle\Command;
26
27			namespace Governor\Bundle\GovernorBundle\DependencyInjection\Compiler;
28
29			use Governor\Framework\Annotations\CommandHandler;
			0 ignored issues – show Coding Style introduced 2015-11-28 13:23 UTC by Report Bug Copy Issue Report USE declarations must go after the first namespace declaration Loading history...
30			use Governor\Framework\CommandHandling\Handlers\AnnotatedCommandHandler;
			0 ignored issues – show Coding Style introduced 2015-11-28 13:23 UTC by Report Bug Copy Issue Report USE declarations must go after the first namespace declaration Loading history...
31			use Governor\Framework\Common\Annotation\MethodMessageHandlerInspector;
			0 ignored issues – show Coding Style introduced 2015-11-28 13:23 UTC by Report Bug Copy Issue Report USE declarations must go after the first namespace declaration Loading history...
32			use Symfony\Component\DependencyInjection\Reference;
			0 ignored issues – show Coding Style introduced 2015-11-28 13:23 UTC by Report Bug Copy Issue Report USE declarations must go after the first namespace declaration Loading history...
33			use Symfony\Component\DependencyInjection\ContainerBuilder;
			0 ignored issues – show Coding Style introduced 2015-11-28 13:23 UTC by Report Bug Copy Issue Report USE declarations must go after the first namespace declaration Loading history...
34
35			/**
36			* Finds all services tagged as command handlers and registers them in the appropriate command handler registry.
37			*
38			* @author "David Kalosi" <[email protected]>
39			* @license <a href="http://www.opensource.org/licenses/mit-license.php">MIT License</a>
40			*/
41			class CommandHandlerPass extends AbstractHandlerPass
42			{
43
44			/**
45			* @param ContainerBuilder $container
46			*/
47	11		public function process(ContainerBuilder $container)
48			{
49	11		foreach ($container->findTaggedServiceIds('governor.command_handler') as $id => $attributes) {
50	11		$bus = $container->findDefinition(
51	11		sprintf(
52	11		"governor.command_bus.%s",
53	11		isset($attributes[0]['command_bus']) ? $attributes[0]['command_bus']
54			: 'default'
55	11		)
56	11		);
57
58	11		$definition = $container->findDefinition($id);
59	11		$class = $definition->getClass();
60
61	11		$inspector = new MethodMessageHandlerInspector(
62	11		$container->get('governor.annotation_reader_factory'),
			0 ignored issues – show Documentation introduced 2015-11-28 13:23 UTC by Report Bug Copy Issue Report `$container->get('governo...tation_reader_factory')` is of type `object\|null`, but the function expects a `object<Governor\Framewor...ReaderFactoryInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
63	11		new \ReflectionClass($class),
64			CommandHandler::class
65	11		);
66
67	11	View Code Duplication	foreach ($inspector->getHandlerDefinitions() as $handlerDefinition) {
			0 ignored issues – show Duplication introduced 2015-11-28 13:23 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
68	11		$handlerId = $this->getHandlerIdentifier("governor.command_handler");
69
70	11		$container->register($handlerId, AnnotatedCommandHandler::class)
71	11		->addArgument($class)
72	11		->addArgument($handlerDefinition->getMethod()->name)
73	11		->addArgument(new Reference('governor.parameter_resolver_factory'))
74	11		->addArgument(new Reference($id))
75	11		->setPublic(true)
76	11		->setLazy(true);
77
78	11		$bus->addMethodCall('subscribe',
79			[
80	11		$handlerDefinition->getPayloadType(),
81	11		new Reference($handlerId)
82	11		]
83	11		);
84	11		}
85	11		}
86	11		}
87
88			}
89

SmartGecko / GovernorBundle

CommandHandlerPass::process() B last analyzed 2015-12-21 19:45 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

CommandHandlerPass::process() B
last analyzed 2015-12-21 19:45 UTC