BaseOAuthProvider::doRequest() - Code Metrics - Inspection of "Merge branch 'providers' into develop" - Sleepness/UberOAuthRestBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( becfea...d327ce )

by Serhii

created 2015-12-08 22:04 UTC

BaseOAuthProvider::doRequest() A

↳ Parent: BaseOAuthProvider

Complexity

Conditions	3
Paths	3

Size

Total Lines	16
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	2

Metric	Value
dl	0
loc	16
rs	9.4286
c	2
b	0
f	2
cc	3
eloc	10
nc	3
nop	3

<?php

namespace Sleepness\UberOAuthRestBundle\Provider;

use Sleepness\UberOAuthRestBundle\Exception\BadRequestException;
use GuzzleHttp\Client;
use GuzzleHttp\Exception\ClientException;

abstract class BaseOAuthProvider implements OAuthProviderInterface
{
    const GET = 'GET';
    const POST = 'POST';

    /**
     * @var Client
     */
    protected $client;

    /**
     * @var array
     */
    protected $credentials;

    /**
     * BaseOAuthProvider constructor.
     *
     * @param $client
     */
    public function __construct($client)
    {
        $this->client = $client;
    }

    /**
     * @param array $credentials
     */
    public function setCredentials(array $credentials)
    {
        $this->credentials = $credentials;
    }

    /**
     * @param $url
     * @param null $content
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @param $headers
     * @param $method
     *
     * @return mixed|\Psr\Http\Message\ResponseInterface
     */
    protected function doRequest($url, $method, array $options = [])
    {
        try {
            $response = $this->client->request(
                strtoupper($method),
                $url,
                $options
            );
        } catch (ClientException $e) {
            if ($e->hasResponse()) {
                throw new BadRequestException('Error while sending request', $this->credentials['provider_name'], $e->getCode(), $e);
            }
        }

        return json_decode($response->getBody()->getContents());
    }

    /**
     * @param $url
     * @param array $parameters
     *
     * @return string
     */
    protected function normalizeUrl($url, array $parameters = array())
    {
        $normalizedUrl = $url;
        if (!empty($parameters)) {
            $normalizedUrl .= (false !== strpos($url, '?') ? '&' : '?').http_build_query($parameters, '', '&');
        }

        return $normalizedUrl;
    }
}


1			<?php
2
3			namespace Sleepness\UberOAuthRestBundle\Provider;
4
5			use Sleepness\UberOAuthRestBundle\Exception\BadRequestException;
6			use GuzzleHttp\Client;
7			use GuzzleHttp\Exception\ClientException;
8
9			abstract class BaseOAuthProvider implements OAuthProviderInterface
10			{
11			const GET = 'GET';
12			const POST = 'POST';
13
14			/**
15			* @var Client
16			*/
17			protected $client;
18
19			/**
20			* @var array
21			*/
22			protected $credentials;
23
24			/**
25			* BaseOAuthProvider constructor.
26			*
27			* @param $client
28			*/
29			public function __construct($client)
30			{
31			$this->client = $client;
32			}
33
34			/**
35			* @param array $credentials
36			*/
37			public function setCredentials(array $credentials)
38			{
39			$this->credentials = $credentials;
40			}
41
42			/**
43			* @param $url
44			* @param null $content
			0 ignored issues – show Bug introduced 2015-12-08 22:07 UTC by Report Bug Copy Issue Report There is no parameter named `$content`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
45			* @param $headers
46			* @param $method
47			*
48			* @return mixed\|\Psr\Http\Message\ResponseInterface
49			*/
50			protected function doRequest($url, $method, array $options = [])
51			{
52			try {
53			$response = $this->client->request(
54			strtoupper($method),
55			$url,
56			$options
57			);
58			} catch (ClientException $e) {
59			if ($e->hasResponse()) {
60			throw new BadRequestException('Error while sending request', $this->credentials['provider_name'], $e->getCode(), $e);
61			}
62			}
63
64			return json_decode($response->getBody()->getContents());
65			}
66
67			/**
68			* @param $url
69			* @param array $parameters
70			*
71			* @return string
72			*/
73			protected function normalizeUrl($url, array $parameters = array())
74			{
75			$normalizedUrl = $url;
76			if (!empty($parameters)) {
77			$normalizedUrl .= (false !== strpos($url, '?') ? '&' : '?').http_build_query($parameters, '', '&');
78			}
79
80			return $normalizedUrl;
81			}
82			}
83

Sleepness / UberOAuthRestBundle

Push — develop ( becfea...d327ce )

BaseOAuthProvider::doRequest() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like