IdRegistry::generateIntId() - Code Metrics - Inspection of "more test coverage for tests;" - SlayerBirden/df-code-generator - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 2edd34...81ce9d )

by Oleg

created 2018-03-21 13:43 UTC

IdRegistry::generateIntId() A

↳ Parent: IdRegistry

Complexity

Conditions	3
Paths	3

Size

Total Lines	9
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	3.072

Importance

Changes

Metric	Value
cc	3
eloc	5
nc	3
nop	2
dl	0
loc	9
ccs	4
cts	5
cp	0.8
crap	3.072
rs	9.6666
c	0
b	0
f	0

<?php
declare(strict_types=1);

namespace SlayerBirden\DFCodeGeneration\Generator\Tests;

use Faker\Factory;

class IdRegistry implements IdHandlerInterface
{
    private $ids = [];
    /**
     * @var \Faker\Generator
     */
    private $faker;

    public function __construct()
    {
        $this->faker = Factory::create();
    }

    public function generateStringId(string $entity): string
    {
        $this->ids[$entity] = $this->faker->unique()->word;

        return $this->ids[$entity];
    }

    public function generateIntId(string $entity, bool $increment): int
    {
        if ($increment) {
            $this->ids[$entity] = isset($this->ids[$entity]) ? ++$this->ids[$entity] : 1;
        } else {
            $this->ids[$entity] = $this->faker->unique()->numberBetween(0,100);
        }

        return $this->ids[$entity];
    }

    /**
     * @param string $entity
     * @return mixed
     */
    public function getId(string $entity)
    {
        return $this->ids[$entity] ?? null;
    }
}


1		<?php
2		declare(strict_types=1);
3
4		namespace SlayerBirden\DFCodeGeneration\Generator\Tests;
5
6		use Faker\Factory;
7
8		class IdRegistry implements IdHandlerInterface
9		{
10		private $ids = [];
11		/**
12		* @var \Faker\Generator
13		*/
14		private $faker;
15
16	9	public function __construct()
17		{
18	9	$this->faker = Factory::create();
19	9	}
20
21		public function generateStringId(string $entity): string
22		{
23		$this->ids[$entity] = $this->faker->unique()->word;
24
25		return $this->ids[$entity];
26		}
27
28	3	public function generateIntId(string $entity, bool $increment): int
29		{
30	3	if ($increment) {
31	3	$this->ids[$entity] = isset($this->ids[$entity]) ? ++$this->ids[$entity] : 1;
32		} else {
33		$this->ids[$entity] = $this->faker->unique()->numberBetween(0,100);
34		}
35
36	3	return $this->ids[$entity];
37		}
38
39		/**
40		* @param string $entity
41		* @return mixed
42		*/
43	3	public function getId(string $entity)
44		{
45	3	return $this->ids[$entity] ?? null;
46		}
47		}
48

SlayerBirden / df-code-generator

Push — master ( 2edd34...81ce9d )

IdRegistry::generateIntId() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like