ConfigTest::testExistingConfig() - Code Metrics - Inspection of "attempt to fix scrutinizer;" - SlayerBirden/df-code-generator - Measure and Improve Code Quality continuously with Scrutinizer

Passed
Push — master ( 4826f7...743cc2 )

by Oleg
created 2018-03-14 22:31 UTC
ConfigTest::testExistingConfig() B

↳ Parent: ConfigTest
Complexity

Conditions	2
Paths	2
Size

Total Lines	170
Code Lines	121
Duplication

Lines	0
Ratio	0 %
Importance

Changes
Metric	Value
cc	2
eloc	121
nc	2
nop	0
dl	0
loc	170
rs	8.2857
c	0
b	0
f	0
How to fix Long Method

<?php
declare(strict_types=1);

namespace SlayerBirden\DFCodeGeneration\Generator\Config;

use Doctrine\ORM\EntityManagerInterface;
use org\bovigo\vfs\vfsStream;
use PHPUnit\Framework\TestCase;
use Prophecy\Argument;
use Prophecy\Prophecy\ObjectProphecy;
use SlayerBirden\DFCodeGeneration\PrintFileTrait;

class ConfigTest extends TestCase
{
    use PrintFileTrait;
    /**
     * @var ObjectProphecy
     */
    private $provider;

    protected function setUp()
    {
        $this->provider = $this->prophesize(DataProviderInterface::class);
        $this->provider->getRouteFactoryName()->willReturn('Routes');
        $this->provider->getInputFilterSpec()->willReturn([
            'bar' => [
                'required' => true,
            ],
            'baz' => [
                'required' => true,
            ],
        ]);
        $this->provider->getInputFilterName()->willReturn('DummyInputFilter');
        $this->provider->getEntitiesSrc()->willReturn('src/Dummy/Entities');
        $this->provider->getCurrentConfig()->willReturn([]);
        $this->provider->getControllerName(Argument::type('string'))->will(function ($args) {
            return ucwords($args[0]) . 'DummyAction';
        });
        $this->provider->getConfigNameSpace()->willReturn('A\B');
    }

    public function testNewConfig()
    {
        $configGenerator = new Config($this->provider->reveal());
        $value = $configGenerator->generate();

        $root = vfsStream::setup();
        file_put_contents($root->url() . '/dummyProvider.php', $value);
        try {
            include $root->url() . '/dummyProvider.php';
        } catch (\ParseError $exception) {
            echo 'File', PHP_EOL, $this->getPrintableFile($value), PHP_EOL;
            throw $exception;
        }

        $class = $configGenerator->getClassName();
        $config = new $class();

        $actual = call_user_func($config);
        $actual = call_user_func(/** @scrutinizer ignore-type */ $config);

        $expected = [
            '\\Zend\\ServiceManager\\AbstractFactory\\ConfigAbstractFactory' => [
                'AddDummyAction' => [
                    EntityManagerInterface::class,
                    '\\Zend\\Hydrator\\ClassMethods',
                    'DummyInputFilter',
                    '\\Psr\\Log\\LoggerInterface',
                    '\\SlayerBirden\\DataFlowServer\\Extractor\\RecursiveEntitiesExtractor',
                ],
                'UpdateDummyAction' => [
                    EntityManagerInterface::class,
                    '\\Zend\\Hydrator\\ClassMethods',
                    'DummyInputFilter',
                    '\\Psr\\Log\\LoggerInterface',
                    '\\SlayerBirden\\DataFlowServer\\Extractor\\RecursiveEntitiesExtractor',
                ],
                'GetDummyAction' => [
                    EntityManagerInterface::class,
                    '\\Psr\\Log\\LoggerInterface',
                    '\\SlayerBirden\\DataFlowServer\\Extractor\\RecursiveEntitiesExtractor',
                ],
                'GetsDummyAction' => [
                    EntityManagerInterface::class,
                    '\\Psr\\Log\\LoggerInterface',
                    '\\SlayerBirden\\DataFlowServer\\Extractor\\RecursiveEntitiesExtractor',
                ],
                'DeleteDummyAction' => [
                    EntityManagerInterface::class,
                    '\\Psr\\Log\\LoggerInterface',
                    '\\SlayerBirden\\DataFlowServer\\Extractor\\RecursiveEntitiesExtractor',
                ],
            ],
            'dependencies' => [
                'delegators' => [
                    '\\Zend\\Expressive\\Application' => [
                        'Routes',
                    ],
                ],
            ],
            'doctrine' => [
                'paths' => [
                    'src/Dummy/Entities'
                ],
            ],
            'input_filter_specs' => [
                'DummyInputFilter' => [
                    'bar' => [
                        'required' => true,
                    ],
                    'baz' => [
                        'required' => true,
                    ],
                ],
            ],
        ];

        $this->assertEquals($expected, $actual);
    }

    public function testExistingConfig()
    {
        $this->provider->getCurrentConfig()->willReturn([
            '\\Zend\\ServiceManager\\AbstractFactory\\ConfigAbstractFactory' => [
                'AddSuperAction' => [
                    EntityManagerInterface::class,
                    '\\Zend\\Hydrator\\ClassMethods',
                    'SuperInputFilter',
                    '\\Psr\\Log\\LoggerInterface',
                    '\\SlayerBirden\\DataFlowServer\\Extractor\\RecursiveEntitiesExtractor',
                ],
                'UpdateSuperAction' => [
                    EntityManagerInterface::class,
                    '\\Zend\\Hydrator\\ClassMethods',
                    'SuperInputFilter',
                    '\\Psr\\Log\\LoggerInterface',
                    '\\SlayerBirden\\DataFlowServer\\Extractor\\RecursiveEntitiesExtractor',
                ],
                'GetSuperAction' => [
                    EntityManagerInterface::class,
                    '\\Psr\\Log\\LoggerInterface',
                    '\\SlayerBirden\\DataFlowServer\\Extractor\\RecursiveEntitiesExtractor',
                ],
                'GetsSuperAction' => [
                    EntityManagerInterface::class,
                    '\\Psr\\Log\\LoggerInterface',
                    '\\SlayerBirden\\DataFlowServer\\Extractor\\RecursiveEntitiesExtractor',
                ],
                'DeleteSuperAction' => [
                    EntityManagerInterface::class,
                    '\\Psr\\Log\\LoggerInterface',
                    '\\SlayerBirden\\DataFlowServer\\Extractor\\RecursiveEntitiesExtractor',
                ],
            ],
            'dependencies' => [
                'delegators' => [
                    '\\Zend\\Expressive\\Application' => [
                        'Routes',
                    ],
                ],
            ],
            'doctrine' => [
                'paths' => [
                    'src/Dummy/Entities'
                ],
            ],
            'input_filter_specs' => [
                'SuperInputFilter' => [
                    'bar' => [
                        'required' => true,
                    ],
                    'baz' => [
                        'required' => true,
                    ],
                ],
            ],
        ]);
        $this->provider->getConfigNameSpace()->willReturn('A\C');

        $configGenerator = new Config($this->provider->reveal());
        $value = $configGenerator->generate();

        $root = vfsStream::setup();
        file_put_contents($root->url() . '/dummyProvider.php', $value);
        try {
            include $root->url() . '/dummyProvider.php';
        } catch (\ParseError $exception) {
            echo 'File', PHP_EOL, $this->getPrintableFile($value), PHP_EOL;
            throw $exception;
        }

        $class = $configGenerator->getClassName();
        $config = new $class();

        $actual = call_user_func($config);
        $actual = call_user_func(/** @scrutinizer ignore-type */ $config);

        $expected = [
            '\\Zend\\ServiceManager\\AbstractFactory\\ConfigAbstractFactory' => [
                'AddSuperAction' => [
                    EntityManagerInterface::class,
                    '\\Zend\\Hydrator\\ClassMethods',
                    'SuperInputFilter',
                    '\\Psr\\Log\\LoggerInterface',
                    '\\SlayerBirden\\DataFlowServer\\Extractor\\RecursiveEntitiesExtractor',
                ],
                'UpdateSuperAction' => [
                    EntityManagerInterface::class,
                    '\\Zend\\Hydrator\\ClassMethods',
                    'SuperInputFilter',
                    '\\Psr\\Log\\LoggerInterface',
                    '\\SlayerBirden\\DataFlowServer\\Extractor\\RecursiveEntitiesExtractor',
                ],
                'GetSuperAction' => [
                    EntityManagerInterface::class,
                    '\\Psr\\Log\\LoggerInterface',
                    '\\SlayerBirden\\DataFlowServer\\Extractor\\RecursiveEntitiesExtractor',
                ],
                'GetsSuperAction' => [
                    EntityManagerInterface::class,
                    '\\Psr\\Log\\LoggerInterface',
                    '\\SlayerBirden\\DataFlowServer\\Extractor\\RecursiveEntitiesExtractor',
                ],
                'DeleteSuperAction' => [
                    EntityManagerInterface::class,
                    '\\Psr\\Log\\LoggerInterface',
                    '\\SlayerBirden\\DataFlowServer\\Extractor\\RecursiveEntitiesExtractor',
                ],
                'AddDummyAction' => [
                    EntityManagerInterface::class,
                    '\\Zend\\Hydrator\\ClassMethods',
                    'DummyInputFilter',
                    '\\Psr\\Log\\LoggerInterface',
                    '\\SlayerBirden\\DataFlowServer\\Extractor\\RecursiveEntitiesExtractor',
                ],
                'UpdateDummyAction' => [
                    EntityManagerInterface::class,
                    '\\Zend\\Hydrator\\ClassMethods',
                    'DummyInputFilter',
                    '\\Psr\\Log\\LoggerInterface',
                    '\\SlayerBirden\\DataFlowServer\\Extractor\\RecursiveEntitiesExtractor',
                ],
                'GetDummyAction' => [
                    EntityManagerInterface::class,
                    '\\Psr\\Log\\LoggerInterface',
                    '\\SlayerBirden\\DataFlowServer\\Extractor\\RecursiveEntitiesExtractor',
                ],
                'GetsDummyAction' => [
                    EntityManagerInterface::class,
                    '\\Psr\\Log\\LoggerInterface',
                    '\\SlayerBirden\\DataFlowServer\\Extractor\\RecursiveEntitiesExtractor',
                ],
                'DeleteDummyAction' => [
                    EntityManagerInterface::class,
                    '\\Psr\\Log\\LoggerInterface',
                    '\\SlayerBirden\\DataFlowServer\\Extractor\\RecursiveEntitiesExtractor',
                ],
            ],
            'dependencies' => [
                'delegators' => [
                    '\\Zend\\Expressive\\Application' => [
                        'Routes',
                    ],
                ],
            ],
            'doctrine' => [
                'paths' => [
                    'src/Dummy/Entities'
                ],
            ],
            'input_filter_specs' => [
                'SuperInputFilter' => [
                    'bar' => [
                        'required' => true,
                    ],
                    'baz' => [
                        'required' => true,
                    ],
                ],
                'DummyInputFilter' => [
                    'bar' => [
                        'required' => true,
                    ],
                    'baz' => [
                        'required' => true,
                    ],
                ],
            ],
        ];

        $this->assertEquals($expected, $actual);
    }

    public function testGetClassName()
    {
        $this->assertSame('A\\B\\ConfigProvider', (new Config($this->provider->reveal()))->getClassName());
    }
}

SlayerBirden / df-code-generator

Push — master ( 4826f7...743cc2 )

ConfigTest::testExistingConfig() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like
