ArrayHashmapTest::testUnset() - Code Metrics - SlayerBirden/datamigration - Measure and Improve Code Quality continuously with Scrutinizer

ArrayHashmapTest::testUnset() A
last analyzed 2018-09-06 14:12 UTC

↳ Parent: ArrayHashmapTest

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	10
c	0
b	0
f	0
rs	9.9332
cc	1
nc	1
nop	0

<?php

namespace Maketok\DataMigration\Hashmap;

class ArrayHashmapTest extends \PHPUnit_Framework_TestCase
{
    /**
     * @var ArrayHashmap
     */
    private $map;

    public function setUp()
    {
        $this->map = new ArrayHashmap('test');
    }

    public function testGet()
    {
        $this->map->somevar = 1;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $this->map->somevar = 1;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        $this->assertSame(1, $this->map->somevar);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $this->assertSame(1, $this->map['somevar']);
        $this->assertNull($this->map['someothervar']);
    }

    public function testHas()
    {
        $this->map['somevar'] = 1;

        $this->assertTrue(isset($this->map['somevar']));
        $this->assertTrue($this->map->offsetExists('somevar'));
    }

    public function testUnset()
    {
        $this->map->somevar = 1;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        unset($this->map['somevar']);

        // should not produce error
        unset($this->map->someothervar);

        $this->assertFalse(isset($this->map['somevar']));
    }

    public function testLoad()
    {
        $this->map->load([
            'somevar' => 2
        ]);

        $this->assertEquals(2, $this->map->somevar);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }
}


1			<?php
2
3			namespace Maketok\DataMigration\Hashmap;
4
5			class ArrayHashmapTest extends \PHPUnit_Framework_TestCase
6			{
7			/**
8			* @var ArrayHashmap
9			*/
10			private $map;
11
12			public function setUp()
13			{
14			$this->map = new ArrayHashmap('test');
15			}
16
17			public function testGet()
18			{
19			$this->map->somevar = 1;
			0 ignored issues – show Documentation introduced 2018-01-03 15:59 UTC by Report Bug Copy Issue Report The property `somevar` does not exist on `object<Maketok\DataMigra...n\Hashmap\ArrayHashmap>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
20			$this->map->somevar = 1;
			0 ignored issues – show Documentation introduced 2018-01-03 15:59 UTC by Report Bug Copy Issue Report The property `somevar` does not exist on `object<Maketok\DataMigra...n\Hashmap\ArrayHashmap>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
21
22			$this->assertSame(1, $this->map->somevar);
			0 ignored issues – show Documentation introduced 2018-01-03 15:59 UTC by Report Bug Copy Issue Report The property `somevar` does not exist on `object<Maketok\DataMigra...n\Hashmap\ArrayHashmap>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
23			$this->assertSame(1, $this->map['somevar']);
24			$this->assertNull($this->map['someothervar']);
25			}
26
27			public function testHas()
28			{
29			$this->map['somevar'] = 1;
30
31			$this->assertTrue(isset($this->map['somevar']));
32			$this->assertTrue($this->map->offsetExists('somevar'));
33			}
34
35			public function testUnset()
36			{
37			$this->map->somevar = 1;
			0 ignored issues – show Documentation introduced 2018-01-03 15:59 UTC by Report Bug Copy Issue Report The property `somevar` does not exist on `object<Maketok\DataMigra...n\Hashmap\ArrayHashmap>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
38			unset($this->map['somevar']);
39
40			// should not produce error
41			unset($this->map->someothervar);
42
43			$this->assertFalse(isset($this->map['somevar']));
44			}
45
46			public function testLoad()
47			{
48			$this->map->load([
49			'somevar' => 2
50			]);
51
52			$this->assertEquals(2, $this->map->somevar);
			0 ignored issues – show Documentation introduced 2018-01-03 15:59 UTC by Report Bug Copy Issue Report The property `somevar` does not exist on `object<Maketok\DataMigra...n\Hashmap\ArrayHashmap>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
53			}
54			}
55

SlayerBirden / datamigration

ArrayHashmapTest::testUnset() A last analyzed 2018-09-06 14:12 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

ArrayHashmapTest::testUnset() A
last analyzed 2018-09-06 14:12 UTC