ExportDbUnit - Code Metrics - SlayerBirden/datamigration - Measure and Improve Code Quality continuously with Scrutinizer

ExportDbUnit A
last analyzed 2018-09-06 14:12 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	66
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Test Coverage

Coverage

100%

Importance

Changes

Metric	Value
dl	0
loc	66
c	0
b	0
f	0
wmc	6
lcom	0
cbo	1
ccs	15
cts	15
cp	1
rs	10

6 Methods

Rating	Name	Size	Complexity
A	getReverseMoveOrder()	4	1
A	setReverseMoveOrder()	4	1
A	getReverseMoveDirection()	4	1
A	setReverseMoveDirection()	4	1
A	getReverseMoveConditions()	4	1
A	setReverseMoveConditions()	4	1

<?php

namespace Maketok\DataMigration\Unit\Type;

use Maketok\DataMigration\Unit\ExportDbUnitInterface;

abstract class ExportDbUnit extends ImportDbUnit implements ExportDbUnitInterface
{
    /**
     * Order by columns for reverse move
     * @var array
     */
    protected $reverseMoveOrder = [];
    /**
     * Direction for reverse move
     * @var string
     */
    protected $reverseDirection = 'asc';
    /**
     * Conditions for reverse move
     * @var array
     */
    protected $reverseConditions = [];

    /**
     * {@inheritdoc}
     */
    public function getReverseMoveOrder()
    {
        return $this->reverseMoveOrder;
    }

    /**
     * {@inheritdoc}
     */
    public function setReverseMoveOrder(array $reverseMoveOrder)
    {
        $this->reverseMoveOrder = $reverseMoveOrder;
    }

    /**
     * {@inheritdoc}
     */
    public function getReverseMoveDirection()
    {
        return $this->reverseDirection;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /**
     * {@inheritdoc}
     */
    public function setReverseMoveDirection($direction)
    {
        $this->reverseDirection = $direction;
    }

    /**
     * {@inheritdoc}
     */
    public function getReverseMoveConditions()
    {
        return $this->reverseConditions;
    }

    /**
     * {@inheritdoc}
     */
    public function setReverseMoveConditions($conditions)
    {
        $this->reverseConditions = $conditions;
    }
}


1		<?php
2
3		namespace Maketok\DataMigration\Unit\Type;
4
5		use Maketok\DataMigration\Unit\ExportDbUnitInterface;
6
7		abstract class ExportDbUnit extends ImportDbUnit implements ExportDbUnitInterface
8		{
9		/**
10		* Order by columns for reverse move
11		* @var array
12		*/
13		protected $reverseMoveOrder = [];
14		/**
15		* Direction for reverse move
16		* @var string
17		*/
18		protected $reverseDirection = 'asc';
19		/**
20		* Conditions for reverse move
21		* @var array
22		*/
23		protected $reverseConditions = [];
24
25		/**
26		* {@inheritdoc}
27		*/
28	3	public function getReverseMoveOrder()
29		{
30	3	return $this->reverseMoveOrder;
31		}
32
33		/**
34		* {@inheritdoc}
35		*/
36	3	public function setReverseMoveOrder(array $reverseMoveOrder)
37		{
38	3	$this->reverseMoveOrder = $reverseMoveOrder;
39	3	}
40
41		/**
42		* {@inheritdoc}
43		*/
44	3	public function getReverseMoveDirection()
45		{
46	3	return $this->reverseDirection;
		0 ignored issues – show Bug Best Practice introduced 2018-01-03 15:59 UTC by Report Bug Copy Issue Report The return type of `return $this->reverseDirection;` (`string`) is incompatible with the return type declared by the interface `Maketok\DataMigration\Un...getReverseMoveDirection` of type `array`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
47		}
48
49		/**
50		* {@inheritdoc}
51		*/
52	3	public function setReverseMoveDirection($direction)
53		{
54	3	$this->reverseDirection = $direction;
55	3	}
56
57		/**
58		* {@inheritdoc}
59		*/
60	3	public function getReverseMoveConditions()
61		{
62	3	return $this->reverseConditions;
63		}
64
65		/**
66		* {@inheritdoc}
67		*/
68	1	public function setReverseMoveConditions($conditions)
69		{
70	1	$this->reverseConditions = $conditions;
71	1	}
72		}
73

SlayerBirden / datamigration

ExportDbUnit A last analyzed 2018-09-06 14:12 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

6 Methods

Duplication Side-by-Side

Filter issues like

ExportDbUnit A
last analyzed 2018-09-06 14:12 UTC