for testing and deploying your application
for finding and fixing issues
for empowering human code reviews
<?php
namespace Maketok\DataMigration\Unit;
class AbstractUnitTest extends \PHPUnit_Framework_TestCase
{
/**
* @param $code
* @return AbstractUnit
*/
public function getUnitMock($code)
return $this->getMockBuilder('\Maketok\DataMigration\Unit\AbstractUnit')
->setConstructorArgs([$code])
->getMockForAbstractClass();
}
public function testSiblings()
$uni1 = $this->getUnitMock('tst1');
$uni2 = $this->getUnitMock('tst2');
$uni3 = $this->getUnitMock('tst3');
$uni4 = $this->getUnitMock('tst4');
$uni5 = $this->getUnitMock('tst5');
$uni6 = $this->getUnitMock('tst6');
$uni7 = $this->getUnitMock('tst7');
$uni8 = $this->getUnitMock('tst8'); // orphan on purpose :)
$uni8
This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.
$myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; }
Both the $myVar assignment in line 1 and the $higher assignment in line 2 are dead. The first because $myVar is never used and the second because $higher is always overwritten for every possible time line.
$myVar
$higher
$uni9 = $this->getUnitMock('tst9');
$uni1->addSibling($uni2);
$uni1->addSibling($uni3);
$uni1->addSibling($uni4);
$uni1->addSibling($uni5);
$uni5->addSibling($uni6);
$uni6->addSibling($uni7);
$uni7->addSibling($uni9);
$siblings = [
'tst1' => $uni1,
'tst2' => $uni2,
'tst3' => $uni3,
'tst4' => $uni4,
'tst5' => $uni5,
'tst6' => $uni6,
'tst7' => $uni7,
'tst9' => $uni9,
];
/** @var AbstractUnit $unit */
foreach ($siblings as $unit) {
$toCompare = $siblings;
unset($toCompare[$unit->getCode()]);
$this->assertEquals($toCompare, $unit->getSiblings());
SlayerBirden /
datamigration
This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.
Both the
$myVarassignment in line 1 and the$higherassignment in line 2 are dead. The first because$myVaris never used and the second because$higheris always overwritten for every possible time line.