Issues in GetUsersCest.php (master) - Issues in master - SlayerBirden/dataflow-server - Measure and Improve Code Quality continuously with Scrutinizer

Issues (114)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

tests/api/user/GetUsersCest.php (7 issues)

Labels

Comprehensibility 7

Severity

Informational 7

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace codecept\user;

use codecept\ApiTester;
use Codeception\Util\HttpCode;
use SlayerBirden\DataFlowServer\Domain\Entities\User;

class GetUsersCest
{
    public function _before(ApiTester $I)

    {
        foreach (range(2, 11) as $i) {
            $I->haveInRepository(User::class, [
                'id' => $i,
                'first' => 'Tester' . $i,
                'last' => 'Tester' . $i,
                'email' => 'test' . $i . '@example.com',
            ]);
        }
    }

    public function getAllUsers(ApiTester $I)

    {
        $I->wantTo('get all users');
        $I->haveHttpHeader('Content-Type', 'application/json');
        $I->sendGET('/users?l=100');
        $I->seeResponseCodeIs(HttpCode::OK);
        $usersJson = [];
        foreach (range(2, 11) as $i) {
            $usersJson[] = [
                'email' => 'test' . $i . '@example.com',
            ];
        }
        $I->seeResponseContainsJson([
            'data' => [
                'users' => $usersJson,
                'count' => 11,
            ]
        ]);
    }

    public function getSecondPageUsers(ApiTester $I)

    {
        $I->wantTo('get second page of users');
        $I->haveHttpHeader('Content-Type', 'application/json');
        $I->sendGET('/users?p=2');
        $I->seeResponseCodeIs(HttpCode::OK);
        $I->seeResponseContainsJson([
            'data' => [
                'users' => [
                    [
                        'email' => '[email protected]',
                    ],
                ],
                'count' => 11,
            ]
        ]);
    }

    public function getFilteredUsers(ApiTester $I)

    {
        $I->wantTo('get users filtered by test1');
        $I->haveHttpHeader('Content-Type', 'application/json');
        $I->sendGET('/users?f[email]=test1');
        $I->seeResponseCodeIs(HttpCode::OK);
        $I->seeResponseContainsJson([
            'data' => [
                'users' => [
                    [
                        'email' => '[email protected]',
                    ],
                    [
                        'email' => '[email protected]',
                    ],
                    [
                        'email' => '[email protected]',
                    ],
                ],
                'count' => 3,
            ]
        ]);
    }

    public function getSortedUsers(ApiTester $I)

    {
        $I->wantTo('get users sorted by id desc');
        $I->haveHttpHeader('Content-Type', 'application/json');
        $I->sendGET('/users?s[id]=desc');
        $I->seeResponseCodeIs(HttpCode::OK);
        $I->seeResponseContainsJson([
            'data' => [
                'users' => [
                    [
                        'email' => '[email protected]',
                    ],
                ],
                'count' => 11,
            ]
        ]);
    }

    public function getNoResultsFilterUsers(ApiTester $I)

    {
        $I->wantTo('attempt to get users with no resulsts filters');
        $I->haveHttpHeader('Content-Type', 'application/json');
        $I->sendGET('/users?f[email]=bla');
        $I->seeResponseCodeIs(HttpCode::NOT_FOUND);
        $I->seeResponseContainsJson([
            'data' => [
                'users' => [],
                'count' => 0,
            ]
        ]);
    }

    public function getWrongFilterUsers(ApiTester $I)

    {
        $I->wantTo('attempt to get users with wrong filters');
        $I->haveHttpHeader('Content-Type', 'application/json');
        $I->sendGET('/users?f[age]=30');
        $I->seeResponseCodeIs(HttpCode::BAD_REQUEST);
        $I->seeResponseContainsJson([
            'data' => [
                'users' => [],
                'count' => 0,
            ]
        ]);
    }
}


1			<?php
2
3			namespace codecept\user;
4
5			use codecept\ApiTester;
6			use Codeception\Util\HttpCode;
7			use SlayerBirden\DataFlowServer\Domain\Entities\User;
8
9			class GetUsersCest
10			{
11			public function _before(ApiTester $I)
			0 ignored issues – show Comprehensibility introduced 2018-03-06 23:58 UTC by Report Bug Copy Issue Report Show Similar Issues like this Avoid variables with short names like $I. Configured minimum length is 3. Short variable names may make your code harder to understand. Variable names should be self-descriptive. This check looks for variable names who are shorter than a configured minimum. Loading history...
12			{
13			foreach (range(2, 11) as $i) {
14			$I->haveInRepository(User::class, [
15			'id' => $i,
16			'first' => 'Tester' . $i,
17			'last' => 'Tester' . $i,
18			'email' => 'test' . $i . '@example.com',
19			]);
20			}
21			}
22
23			public function getAllUsers(ApiTester $I)
			0 ignored issues – show Comprehensibility introduced 2018-03-06 23:58 UTC by Report Bug Copy Issue Report Show Similar Issues like this Avoid variables with short names like $I. Configured minimum length is 3. Short variable names may make your code harder to understand. Variable names should be self-descriptive. This check looks for variable names who are shorter than a configured minimum. Loading history...
24			{
25			$I->wantTo('get all users');
26			$I->haveHttpHeader('Content-Type', 'application/json');
27			$I->sendGET('/users?l=100');
28			$I->seeResponseCodeIs(HttpCode::OK);
29			$usersJson = [];
30			foreach (range(2, 11) as $i) {
31			$usersJson[] = [
32			'email' => 'test' . $i . '@example.com',
33			];
34			}
35			$I->seeResponseContainsJson([
36			'data' => [
37			'users' => $usersJson,
38			'count' => 11,
39			]
40			]);
41			}
42
43			public function getSecondPageUsers(ApiTester $I)
			0 ignored issues – show Comprehensibility introduced 2018-03-06 23:58 UTC by Report Bug Copy Issue Report Show Similar Issues like this Avoid variables with short names like $I. Configured minimum length is 3. Short variable names may make your code harder to understand. Variable names should be self-descriptive. This check looks for variable names who are shorter than a configured minimum. Loading history...
44			{
45			$I->wantTo('get second page of users');
46			$I->haveHttpHeader('Content-Type', 'application/json');
47			$I->sendGET('/users?p=2');
48			$I->seeResponseCodeIs(HttpCode::OK);
49			$I->seeResponseContainsJson([
50			'data' => [
51			'users' => [
52			[
53			'email' => '[email protected]',
54			],
55			],
56			'count' => 11,
57			]
58			]);
59			}
60
61			public function getFilteredUsers(ApiTester $I)
			0 ignored issues – show Comprehensibility introduced 2018-03-06 23:58 UTC by Report Bug Copy Issue Report Show Similar Issues like this Avoid variables with short names like $I. Configured minimum length is 3. Short variable names may make your code harder to understand. Variable names should be self-descriptive. This check looks for variable names who are shorter than a configured minimum. Loading history...
62			{
63			$I->wantTo('get users filtered by test1');
64			$I->haveHttpHeader('Content-Type', 'application/json');
65			$I->sendGET('/users?f[email]=test1');
66			$I->seeResponseCodeIs(HttpCode::OK);
67			$I->seeResponseContainsJson([
68			'data' => [
69			'users' => [
70			[
71			'email' => '[email protected]',
72			],
73			[
74			'email' => '[email protected]',
75			],
76			[
77			'email' => '[email protected]',
78			],
79			],
80			'count' => 3,
81			]
82			]);
83			}
84
85			public function getSortedUsers(ApiTester $I)
			0 ignored issues – show Comprehensibility introduced 2018-03-06 23:58 UTC by Report Bug Copy Issue Report Show Similar Issues like this Avoid variables with short names like $I. Configured minimum length is 3. Short variable names may make your code harder to understand. Variable names should be self-descriptive. This check looks for variable names who are shorter than a configured minimum. Loading history...
86			{
87			$I->wantTo('get users sorted by id desc');
88			$I->haveHttpHeader('Content-Type', 'application/json');
89			$I->sendGET('/users?s[id]=desc');
90			$I->seeResponseCodeIs(HttpCode::OK);
91			$I->seeResponseContainsJson([
92			'data' => [
93			'users' => [
94			[
95			'email' => '[email protected]',
96			],
97			],
98			'count' => 11,
99			]
100			]);
101			}
102
103			public function getNoResultsFilterUsers(ApiTester $I)
			0 ignored issues – show Comprehensibility introduced 2018-03-06 23:58 UTC by Report Bug Copy Issue Report Show Similar Issues like this Avoid variables with short names like $I. Configured minimum length is 3. Short variable names may make your code harder to understand. Variable names should be self-descriptive. This check looks for variable names who are shorter than a configured minimum. Loading history...
104			{
105			$I->wantTo('attempt to get users with no resulsts filters');
106			$I->haveHttpHeader('Content-Type', 'application/json');
107			$I->sendGET('/users?f[email]=bla');
108			$I->seeResponseCodeIs(HttpCode::NOT_FOUND);
109			$I->seeResponseContainsJson([
110			'data' => [
111			'users' => [],
112			'count' => 0,
113			]
114			]);
115			}
116
117			public function getWrongFilterUsers(ApiTester $I)
			0 ignored issues – show Comprehensibility introduced 2018-03-06 23:58 UTC by Report Bug Copy Issue Report Show Similar Issues like this Avoid variables with short names like $I. Configured minimum length is 3. Short variable names may make your code harder to understand. Variable names should be self-descriptive. This check looks for variable names who are shorter than a configured minimum. Loading history...
118			{
119			$I->wantTo('attempt to get users with wrong filters');
120			$I->haveHttpHeader('Content-Type', 'application/json');
121			$I->sendGET('/users?f[age]=30');
122			$I->seeResponseCodeIs(HttpCode::BAD_REQUEST);
123			$I->seeResponseContainsJson([
124			'data' => [
125			'users' => [],
126			'count' => 0,
127			]
128			]);
129			}
130			}
131

SlayerBirden / dataflow-server

Issues (114)

Security Analysis not enabled

tests/api/user/GetUsersCest.php (7 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like