AddUserAction::process() - Code Metrics - Inspection of "test coverage improvements;" - SlayerBirden/dataflow-server - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 178a08...5c0b6f )

by Oleg

created 2018-07-26 21:57 UTC

AddUserAction::process() B

↳ Parent: AddUserAction

Complexity

Conditions	5
Paths	14

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	17
CRAP Score	5.8191

Importance

Changes

Metric	Value
dl	0
loc	50
ccs	17
cts	25
cp	0.68
rs	8.7797
c	0
b	0
f	0
cc	5
nc	14
nop	2
crap	5.8191

<?php
declare(strict_types=1);

namespace SlayerBirden\DataFlowServer\Domain\Controller;

use Doctrine\DBAL\Exception\UniqueConstraintViolationException;
use Doctrine\ORM\EntityManagerInterface;
use Doctrine\ORM\ORMException;
use Doctrine\ORM\ORMInvalidArgumentException;
use Psr\Http\Message\ResponseInterface;
use Psr\Http\Message\ServerRequestInterface;
use Psr\Http\Server\MiddlewareInterface;
use Psr\Http\Server\RequestHandlerInterface;
use Psr\Log\LoggerInterface;
use SlayerBirden\DataFlowServer\Domain\Entities\User;
use SlayerBirden\DataFlowServer\Notification\DangerMessage;
use SlayerBirden\DataFlowServer\Notification\SuccessMessage;
use SlayerBirden\DataFlowServer\Stdlib\Validation\ValidationResponseFactory;
use Zend\Diactoros\Response\JsonResponse;
use Zend\Hydrator\HydratorInterface;
use Zend\InputFilter\InputFilterInterface;

class AddUserAction implements MiddlewareInterface
{
    /**
     * @var EntityManagerInterface
     */
    private $entityManager;
    /**
     * @var HydratorInterface
     */
    private $hydrator;
    /**
     * @var InputFilterInterface
     */
    private $inputFilter;
    /**
     * @var LoggerInterface
     */
    private $logger;

    public function __construct(
        EntityManagerInterface $entityManager,
        HydratorInterface $hydrator,
        InputFilterInterface $inputFilter,
        LoggerInterface $logger
    ) {
        $this->entityManager = $entityManager;
        $this->hydrator = $hydrator;
        $this->inputFilter = $inputFilter;
        $this->logger = $logger;
    }

    /**
     * @inheritdoc
     */
    public function process(ServerRequestInterface $request, RequestHandlerInterface $handler): ResponseInterface
    {
        $data = $request->getParsedBody();
        $this->inputFilter->setData($data);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

        if (!$this->inputFilter->isValid()) {
            return (new ValidationResponseFactory())('user', $this->inputFilter);
        }
        try {
            $entity = $this->getEntity($data);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
            $this->entityManager->persist($entity);
            $this->entityManager->flush();
            return new JsonResponse([
                'msg' => new SuccessMessage('User has been successfully created!'),
                'success' => true,
                'data' => [
                    'validation' => [],
                    'user' => $this->hydrator->extract($entity),
                ]
            ], 200);
        } catch (ORMInvalidArgumentException $exception) {
            return new JsonResponse([
                'msg' => new DangerMessage($exception->getMessage()),
                'success' => false,
                'data' => [
                    'validation' => [],
                    'user' => null,
                ]
            ], 400);
        } catch (UniqueConstraintViolationException $exception) {
            return new JsonResponse([
                'msg' => new DangerMessage('Provided email already exists.'),
                'success' => false,
                'data' => [
                    'validation' => [],
                    'user' => null,
                ]
            ], 400);
        } catch (ORMException $exception) {
            $this->logger->error((string)$exception);
            return new JsonResponse([
                'msg' => new DangerMessage('Error during creation operation.'),
                'success' => false,
                'data' => [
                    'validation' => [],
                    'user' => null,
                ]
            ], 400);
        }
    }

    /**
     * @param array $data
     * @return User
     */
    private function getEntity(array $data): User
    {
        $entity = new User();
        $this->hydrator->hydrate($data, $entity);

        return $entity;
    }
}


1		<?php
2		declare(strict_types=1);
3
4		namespace SlayerBirden\DataFlowServer\Domain\Controller;
5
6		use Doctrine\DBAL\Exception\UniqueConstraintViolationException;
7		use Doctrine\ORM\EntityManagerInterface;
8		use Doctrine\ORM\ORMException;
9		use Doctrine\ORM\ORMInvalidArgumentException;
10		use Psr\Http\Message\ResponseInterface;
11		use Psr\Http\Message\ServerRequestInterface;
12		use Psr\Http\Server\MiddlewareInterface;
13		use Psr\Http\Server\RequestHandlerInterface;
14		use Psr\Log\LoggerInterface;
15		use SlayerBirden\DataFlowServer\Domain\Entities\User;
16		use SlayerBirden\DataFlowServer\Notification\DangerMessage;
17		use SlayerBirden\DataFlowServer\Notification\SuccessMessage;
18		use SlayerBirden\DataFlowServer\Stdlib\Validation\ValidationResponseFactory;
19		use Zend\Diactoros\Response\JsonResponse;
20		use Zend\Hydrator\HydratorInterface;
21		use Zend\InputFilter\InputFilterInterface;
22
23		class AddUserAction implements MiddlewareInterface
24		{
25		/**
26		* @var EntityManagerInterface
27		*/
28		private $entityManager;
29		/**
30		* @var HydratorInterface
31		*/
32		private $hydrator;
33		/**
34		* @var InputFilterInterface
35		*/
36		private $inputFilter;
37		/**
38		* @var LoggerInterface
39		*/
40		private $logger;
41
42	4	public function __construct(
43		EntityManagerInterface $entityManager,
44		HydratorInterface $hydrator,
45		InputFilterInterface $inputFilter,
46		LoggerInterface $logger
47		) {
48	4	$this->entityManager = $entityManager;
49	4	$this->hydrator = $hydrator;
50	4	$this->inputFilter = $inputFilter;
51	4	$this->logger = $logger;
52	4	}
53
54		/**
55		* @inheritdoc
56		*/
57	4	public function process(ServerRequestInterface $request, RequestHandlerInterface $handler): ResponseInterface
58		{
59	4	$data = $request->getParsedBody();
60	4	$this->inputFilter->setData($data);
		0 ignored issues – show Bug introduced 2018-06-19 09:10 UTC by Report Bug Copy Issue Report It seems like `$data` defined by `$request->getParsedBody()` on line `59` can also be of type `null` or `object`; however, `Zend\InputFilter\InputFilterInterface::setData()` does only seem to accept `array\|object<Traversable>`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
61
62	4	if (!$this->inputFilter->isValid()) {
63	2	return (new ValidationResponseFactory())('user', $this->inputFilter);
64		}
65		try {
66	2	$entity = $this->getEntity($data);
		0 ignored issues – show Bug introduced 2018-03-09 21:30 UTC by Report Bug Copy Issue Report It seems like `$data` defined by `$request->getParsedBody()` on line `59` can also be of type `null` or `object`; however, `SlayerBirden\DataFlowSer...UserAction::getEntity()` does only seem to accept `array`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
67	2	$this->entityManager->persist($entity);
68	2	$this->entityManager->flush();
69	1	return new JsonResponse([
70	1	'msg' => new SuccessMessage('User has been successfully created!'),
71		'success' => true,
72		'data' => [
73		'validation' => [],
74	1	'user' => $this->hydrator->extract($entity),
75		]
76	1	], 200);
77	1	} catch (ORMInvalidArgumentException $exception) {
78		return new JsonResponse([
79		'msg' => new DangerMessage($exception->getMessage()),
80		'success' => false,
81		'data' => [
82		'validation' => [],
83		'user' => null,
84		]
85		], 400);
86	1	} catch (UniqueConstraintViolationException $exception) {
87	1	return new JsonResponse([
88	1	'msg' => new DangerMessage('Provided email already exists.'),
89		'success' => false,
90		'data' => [
91		'validation' => [],
92		'user' => null,
93		]
94	1	], 400);
95		} catch (ORMException $exception) {
96		$this->logger->error((string)$exception);
97		return new JsonResponse([
98		'msg' => new DangerMessage('Error during creation operation.'),
99		'success' => false,
100		'data' => [
101		'validation' => [],
102		'user' => null,
103		]
104		], 400);
105		}
106		}
107
108		/**
109		* @param array $data
110		* @return User
111		*/
112	2	private function getEntity(array $data): User
113		{
114	2	$entity = new User();
115	2	$this->hydrator->hydrate($data, $entity);
116
117	2	return $entity;
118		}
119		}
120

SlayerBirden / dataflow-server

Push — master ( 178a08...5c0b6f )

AddUserAction::process() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like