UpdateConfigAction::process() - Code Metrics - Inspection of "test coverage improvements;" - SlayerBirden/dataflow-server - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 178a08...5c0b6f )

by Oleg

created 2018-07-26 21:57 UTC

UpdateConfigAction::process() A

↳ Parent: UpdateConfigAction

Complexity

Conditions	4
Paths	10

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	13
CRAP Score	5.0954

Importance

Changes

Metric	Value
dl	0
loc	42
ccs	13
cts	22
cp	0.5909
rs	9.248
c	0
b	0
f	0
cc	4
nc	10
nop	2
crap	5.0954

<?php
declare(strict_types=1);

namespace SlayerBirden\DataFlowServer\Db\Controller;

use Doctrine\ORM\EntityManagerInterface;
use Doctrine\ORM\ORMException;
use Doctrine\ORM\ORMInvalidArgumentException;
use Psr\Http\Message\ResponseInterface;
use Psr\Http\Message\ServerRequestInterface;
use Psr\Http\Server\MiddlewareInterface;
use Psr\Http\Server\RequestHandlerInterface;
use Psr\Log\LoggerInterface;
use SlayerBirden\DataFlowServer\Db\Entities\DbConfiguration;
use SlayerBirden\DataFlowServer\Doctrine\Middleware\ResourceMiddlewareInterface;
use SlayerBirden\DataFlowServer\Notification\DangerMessage;
use SlayerBirden\DataFlowServer\Notification\SuccessMessage;
use SlayerBirden\DataFlowServer\Stdlib\Validation\ValidationResponseFactory;
use Zend\Diactoros\Response\JsonResponse;
use Zend\Hydrator\HydratorInterface;
use Zend\InputFilter\InputFilterInterface;

class UpdateConfigAction implements MiddlewareInterface
{
    /**
     * @var EntityManagerInterface
     */
    private $entityManager;
    /**
     * @var LoggerInterface
     */
    private $logger;
    /**
     * @var HydratorInterface
     */
    private $hydrator;
    /**
     * @var InputFilterInterface
     */
    private $inputFilter;

    public function __construct(
        EntityManagerInterface $entityManager,
        HydratorInterface $hydrator,
        InputFilterInterface $inputFilter,
        LoggerInterface $logger
    ) {
        $this->entityManager = $entityManager;
        $this->hydrator = $hydrator;
        $this->inputFilter = $inputFilter;
        $this->logger = $logger;
    }

    /**
     * @inheritdoc
     */
    public function process(ServerRequestInterface $request, RequestHandlerInterface $handler): ResponseInterface
    {
        $data = $request->getParsedBody();
        $dbConfig = $request->getAttribute(ResourceMiddlewareInterface::DATA_RESOURCE);
        $this->inputFilter->setData($data);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

        if (!$this->inputFilter->isValid()) {
            return (new ValidationResponseFactory())('configuration', $this->inputFilter);
        }
        try {
            $config = $this->getConfig($dbConfig, $data);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
            $this->entityManager->persist($config);
            $this->entityManager->flush();
            return new JsonResponse([
                'msg' => new SuccessMessage('Configuration has been updated!'),
                'success' => true,
                'data' => [
                    'configuration' => $this->hydrator->extract($config),
                    'validation' => [],
                ]
            ], 200);
        } catch (ORMInvalidArgumentException $exception) {
            return new JsonResponse([
                'msg' => new DangerMessage($exception->getMessage()),
                'success' => false,
                'data' => [
                    'configuration' => null,
                    'validation' => [],
                ]
            ], 400);
        } catch (ORMException $exception) {
            $this->logger->error((string)$exception);
            return new JsonResponse([
                'msg' => new DangerMessage('Error while updating configuration.'),
                'success' => false,
                'data' => [
                    'configuration' => null,
                    'validation' => [],
                ]
            ], 400);
        }
    }

    private function getConfig(DbConfiguration $configuration, array $data): DbConfiguration
    {
        unset($data['id']);
        $this->hydrator->hydrate($data, $configuration);

        return $configuration;
    }
}


1		<?php
2		declare(strict_types=1);
3
4		namespace SlayerBirden\DataFlowServer\Db\Controller;
5
6		use Doctrine\ORM\EntityManagerInterface;
7		use Doctrine\ORM\ORMException;
8		use Doctrine\ORM\ORMInvalidArgumentException;
9		use Psr\Http\Message\ResponseInterface;
10		use Psr\Http\Message\ServerRequestInterface;
11		use Psr\Http\Server\MiddlewareInterface;
12		use Psr\Http\Server\RequestHandlerInterface;
13		use Psr\Log\LoggerInterface;
14		use SlayerBirden\DataFlowServer\Db\Entities\DbConfiguration;
15		use SlayerBirden\DataFlowServer\Doctrine\Middleware\ResourceMiddlewareInterface;
16		use SlayerBirden\DataFlowServer\Notification\DangerMessage;
17		use SlayerBirden\DataFlowServer\Notification\SuccessMessage;
18		use SlayerBirden\DataFlowServer\Stdlib\Validation\ValidationResponseFactory;
19		use Zend\Diactoros\Response\JsonResponse;
20		use Zend\Hydrator\HydratorInterface;
21		use Zend\InputFilter\InputFilterInterface;
22
23		class UpdateConfigAction implements MiddlewareInterface
24		{
25		/**
26		* @var EntityManagerInterface
27		*/
28		private $entityManager;
29		/**
30		* @var LoggerInterface
31		*/
32		private $logger;
33		/**
34		* @var HydratorInterface
35		*/
36		private $hydrator;
37		/**
38		* @var InputFilterInterface
39		*/
40		private $inputFilter;
41
42	2	public function __construct(
43		EntityManagerInterface $entityManager,
44		HydratorInterface $hydrator,
45		InputFilterInterface $inputFilter,
46		LoggerInterface $logger
47		) {
48	2	$this->entityManager = $entityManager;
49	2	$this->hydrator = $hydrator;
50	2	$this->inputFilter = $inputFilter;
51	2	$this->logger = $logger;
52	2	}
53
54		/**
55		* @inheritdoc
56		*/
57	2	public function process(ServerRequestInterface $request, RequestHandlerInterface $handler): ResponseInterface
58		{
59	2	$data = $request->getParsedBody();
60	2	$dbConfig = $request->getAttribute(ResourceMiddlewareInterface::DATA_RESOURCE);
61	2	$this->inputFilter->setData($data);
		0 ignored issues – show Bug introduced 2018-06-19 09:10 UTC by Report Bug Copy Issue Report It seems like `$data` defined by `$request->getParsedBody()` on line `59` can also be of type `null` or `object`; however, `Zend\InputFilter\InputFilterInterface::setData()` does only seem to accept `array\|object<Traversable>`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
62
63	2	if (!$this->inputFilter->isValid()) {
64	1	return (new ValidationResponseFactory())('configuration', $this->inputFilter);
65		}
66		try {
67	1	$config = $this->getConfig($dbConfig, $data);
		0 ignored issues – show Bug introduced 2018-06-19 09:10 UTC by Report Bug Copy Issue Report It seems like `$data` defined by `$request->getParsedBody()` on line `59` can also be of type `null` or `object`; however, `SlayerBirden\DataFlowSer...nfigAction::getConfig()` does only seem to accept `array`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
68	1	$this->entityManager->persist($config);
69	1	$this->entityManager->flush();
70	1	return new JsonResponse([
71	1	'msg' => new SuccessMessage('Configuration has been updated!'),
72		'success' => true,
73		'data' => [
74	1	'configuration' => $this->hydrator->extract($config),
75		'validation' => [],
76		]
77	1	], 200);
78		} catch (ORMInvalidArgumentException $exception) {
79		return new JsonResponse([
80		'msg' => new DangerMessage($exception->getMessage()),
81		'success' => false,
82		'data' => [
83		'configuration' => null,
84		'validation' => [],
85		]
86		], 400);
87		} catch (ORMException $exception) {
88		$this->logger->error((string)$exception);
89		return new JsonResponse([
90		'msg' => new DangerMessage('Error while updating configuration.'),
91		'success' => false,
92		'data' => [
93		'configuration' => null,
94		'validation' => [],
95		]
96		], 400);
97		}
98		}
99
100	1	private function getConfig(DbConfiguration $configuration, array $data): DbConfiguration
101		{
102	1	unset($data['id']);
103	1	$this->hydrator->hydrate($data, $configuration);
104
105	1	return $configuration;
106		}
107		}
108

SlayerBirden / dataflow-server

Push — master ( 178a08...5c0b6f )

UpdateConfigAction::process() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like