PasswordManager::isValid() - Code Metrics - Inspection of "test coverage improvements;" - SlayerBirden/dataflow-server - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 178a08...5c0b6f )

by Oleg

created 2018-07-26 21:57 UTC

PasswordManager::isValid() A

↳ Parent: PasswordManager

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	3
CRAP Score	2.0625

Importance

Changes

Metric	Value
dl	0
loc	7
ccs	3
cts	4
cp	0.75
rs	10
c	0
b	0
f	0
cc	2
nc	2
nop	2
crap	2.0625

<?php
declare(strict_types=1);

namespace SlayerBirden\DataFlowServer\Authentication\Service;

use Doctrine\Common\Collections\Criteria;
use Doctrine\ORM\EntityManager;
use Psr\Log\LoggerInterface;
use SlayerBirden\DataFlowServer\Authentication\Entities\Password;
use SlayerBirden\DataFlowServer\Authentication\Exception\InvalidCredentialsException;
use SlayerBirden\DataFlowServer\Authentication\Exception\PasswordExpiredException;
use SlayerBirden\DataFlowServer\Authentication\PasswordManagerInterface;
use SlayerBirden\DataFlowServer\Domain\Entities\User;

class PasswordManager implements PasswordManagerInterface
{
    /**
     * @var EntityManager
     */
    private $entityManager;
    /**
     * @var LoggerInterface
     */
    private $logger;

    public function __construct(EntityManager $entityManager, LoggerInterface $logger)
function someFunction(ManagerRegistry $registry) {
    $em = $registry->getManager();
    $em->getConnection()->beginTransaction();
    try {
        // Do something.
        $em->getConnection()->commit();
    } catch (\Exception $ex) {
        $em->getConnection()->rollback();
        $em->close();

        throw $ex;
    }
}
    {
        $this->entityManager = $entityManager;
        $this->logger = $logger;
    }

    public function isValidForUser(string $password, User $user): bool
    {
        $results = $this->entityManager
            ->getRepository(Password::class)
            ->matching(
                Criteria::create()
                    ->where(Criteria::expr()->eq('owner', $user))
                    ->andWhere(Criteria::expr()->eq('active', true))
            );
        if ($results->count()) {
            /** @var Password $pw */
            $pw = $results->first();
            return $this->isValid($password, $pw);
        } else {
            throw new InvalidCredentialsException('Invalid login/password combination.');
        }
    }

    /**
     * @param Password $password
     * @return bool
     */
    private function isExpired(Password $password)
    {
        return $password->getDue() < new \DateTime();
    }

    public function getHash(string $password): string
    {
        return password_hash($password, PASSWORD_DEFAULT);
    }

    /**
     * @inheritdoc
     */
    public function isValid(string $password, Password $passwordObject): bool
    {
        if ($this->isExpired($passwordObject)) {
            throw new PasswordExpiredException('Password is expired.');
        }
        return password_verify($password, $passwordObject->getHash());
    }
}


1		<?php
2		declare(strict_types=1);
3
4		namespace SlayerBirden\DataFlowServer\Authentication\Service;
5
6		use Doctrine\Common\Collections\Criteria;
7		use Doctrine\ORM\EntityManager;
8		use Psr\Log\LoggerInterface;
9		use SlayerBirden\DataFlowServer\Authentication\Entities\Password;
10		use SlayerBirden\DataFlowServer\Authentication\Exception\InvalidCredentialsException;
11		use SlayerBirden\DataFlowServer\Authentication\Exception\PasswordExpiredException;
12		use SlayerBirden\DataFlowServer\Authentication\PasswordManagerInterface;
13		use SlayerBirden\DataFlowServer\Domain\Entities\User;
14
15		class PasswordManager implements PasswordManagerInterface
16		{
17		/**
18		* @var EntityManager
19		*/
20		private $entityManager;
21		/**
22		* @var LoggerInterface
23		*/
24		private $logger;
25
26	17	public function __construct(EntityManager $entityManager, LoggerInterface $logger)
		0 ignored issues – show Bug introduced 2018-06-19 09:10 UTC by Report Bug Copy Issue Report You have injected the EntityManager via parameter `$entityManager`. This is generally not recommended as it might get closed and become unusable. Instead, it is recommended to inject the ManagerRegistry and retrieve the EntityManager via `getManager()` each time you need it. The `EntityManager` might become unusable for example if a transaction is rolled back and it gets closed. Let’s assume that somewhere in your application, or in a third-party library, there is code such as the following: function someFunction(ManagerRegistry $registry) { $em = $registry->getManager(); $em->getConnection()->beginTransaction(); try { // Do something. $em->getConnection()->commit(); } catch (\Exception $ex) { $em->getConnection()->rollback(); $em->close(); throw $ex; } } If that code throws an exception and the `EntityManager` is closed. Any other code which depends on the same instance of the `EntityManager` during this request will fail. On the other hand, if you instead inject the `ManagerRegistry`, the `getManager()` method guarantees that you will always get a usable manager instance. Loading history...
27		{
28	17	$this->entityManager = $entityManager;
29	17	$this->logger = $logger;
30	17	}
31
32	7	public function isValidForUser(string $password, User $user): bool
33		{
34	7	$results = $this->entityManager
35	7	->getRepository(Password::class)
36	7	->matching(
37	7	Criteria::create()
38	7	->where(Criteria::expr()->eq('owner', $user))
39	7	->andWhere(Criteria::expr()->eq('active', true))
40		);
41	7	if ($results->count()) {
42		/** @var Password $pw */
43	7	$pw = $results->first();
44	7	return $this->isValid($password, $pw);
45		} else {
46		throw new InvalidCredentialsException('Invalid login/password combination.');
47		}
48		}
49
50		/**
51		* @param Password $password
52		* @return bool
53		*/
54	7	private function isExpired(Password $password)
55		{
56	7	return $password->getDue() < new \DateTime();
57		}
58
59	2	public function getHash(string $password): string
60		{
61	2	return password_hash($password, PASSWORD_DEFAULT);
62		}
63
64		/**
65		* @inheritdoc
66		*/
67	7	public function isValid(string $password, Password $passwordObject): bool
68		{
69	7	if ($this->isExpired($passwordObject)) {
70		throw new PasswordExpiredException('Password is expired.');
71		}
72	7	return password_verify($password, $passwordObject->getHash());
73		}
74		}
75

SlayerBirden / dataflow-server

Push — master ( 178a08...5c0b6f )

PasswordManager::isValid() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like