InvalidateTokenAction::__construct() - Code Metrics - Inspection of "test coverage improvements;" - SlayerBirden/dataflow-server - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 178a08...5c0b6f )

by Oleg

created 2018-07-26 21:57 UTC

InvalidateTokenAction::__construct() A

↳ Parent: InvalidateTokenAction

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	6
ccs	5
cts	5
cp	1
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	3
crap	1

<?php
declare(strict_types=1);

namespace SlayerBirden\DataFlowServer\Authentication\Controller;

use Doctrine\ORM\EntityManager;
use Doctrine\ORM\ORMException;
use Psr\Http\Message\ResponseInterface;
use Psr\Http\Message\ServerRequestInterface;
use Psr\Http\Server\MiddlewareInterface;
use Psr\Http\Server\RequestHandlerInterface;
use Psr\Log\LoggerInterface;
use SlayerBirden\DataFlowServer\Authentication\Entities\Token;
use SlayerBirden\DataFlowServer\Doctrine\Middleware\ResourceMiddlewareInterface;
use SlayerBirden\DataFlowServer\Notification\SuccessMessage;
use Zend\Diactoros\Response\JsonResponse;
use Zend\Hydrator\HydratorInterface;

class InvalidateTokenAction implements MiddlewareInterface
{
    /**
     * @var EntityManager
     */
    private $entityManager;
    /**
     * @var LoggerInterface
     */
    private $logger;
    /**
     * @var HydratorInterface
     */
    private $hydrator;

    public function __construct(EntityManager $entityManager, LoggerInterface $logger, HydratorInterface $hydrator)
function someFunction(ManagerRegistry $registry) {
    $em = $registry->getManager();
    $em->getConnection()->beginTransaction();
    try {
        // Do something.
        $em->getConnection()->commit();
    } catch (\Exception $ex) {
        $em->getConnection()->rollback();
        $em->close();

        throw $ex;
    }
}
    {
        $this->entityManager = $entityManager;
        $this->logger = $logger;
        $this->hydrator = $hydrator;
    }

    /**
     * @inheritdoc
     * @throws ORMException
     */
    public function process(ServerRequestInterface $request, RequestHandlerInterface $handler): ResponseInterface
    {
        /** @var Token $token */
        $token = $request->getAttribute(ResourceMiddlewareInterface::DATA_RESOURCE);
        $token->setActive(false);

        $this->entityManager->persist($token);
        $this->entityManager->flush();
        return new JsonResponse([
            'data' => [
                'token' => $this->hydrator->extract($token),
            ],
            'success' => true,
            'msg' => new SuccessMessage('Token invalidated.'),
        ], 200);
    }
}


1		<?php
2		declare(strict_types=1);
3
4		namespace SlayerBirden\DataFlowServer\Authentication\Controller;
5
6		use Doctrine\ORM\EntityManager;
7		use Doctrine\ORM\ORMException;
8		use Psr\Http\Message\ResponseInterface;
9		use Psr\Http\Message\ServerRequestInterface;
10		use Psr\Http\Server\MiddlewareInterface;
11		use Psr\Http\Server\RequestHandlerInterface;
12		use Psr\Log\LoggerInterface;
13		use SlayerBirden\DataFlowServer\Authentication\Entities\Token;
14		use SlayerBirden\DataFlowServer\Doctrine\Middleware\ResourceMiddlewareInterface;
15		use SlayerBirden\DataFlowServer\Notification\SuccessMessage;
16		use Zend\Diactoros\Response\JsonResponse;
17		use Zend\Hydrator\HydratorInterface;
18
19		class InvalidateTokenAction implements MiddlewareInterface
20		{
21		/**
22		* @var EntityManager
23		*/
24		private $entityManager;
25		/**
26		* @var LoggerInterface
27		*/
28		private $logger;
29		/**
30		* @var HydratorInterface
31		*/
32		private $hydrator;
33
34	1	public function __construct(EntityManager $entityManager, LoggerInterface $logger, HydratorInterface $hydrator)
		0 ignored issues – show Bug introduced 2018-06-19 09:10 UTC by Report Bug Copy Issue Report You have injected the EntityManager via parameter `$entityManager`. This is generally not recommended as it might get closed and become unusable. Instead, it is recommended to inject the ManagerRegistry and retrieve the EntityManager via `getManager()` each time you need it. The `EntityManager` might become unusable for example if a transaction is rolled back and it gets closed. Let’s assume that somewhere in your application, or in a third-party library, there is code such as the following: function someFunction(ManagerRegistry $registry) { $em = $registry->getManager(); $em->getConnection()->beginTransaction(); try { // Do something. $em->getConnection()->commit(); } catch (\Exception $ex) { $em->getConnection()->rollback(); $em->close(); throw $ex; } } If that code throws an exception and the `EntityManager` is closed. Any other code which depends on the same instance of the `EntityManager` during this request will fail. On the other hand, if you instead inject the `ManagerRegistry`, the `getManager()` method guarantees that you will always get a usable manager instance. Loading history...
35		{
36	1	$this->entityManager = $entityManager;
37	1	$this->logger = $logger;
38	1	$this->hydrator = $hydrator;
39	1	}
40
41		/**
42		* @inheritdoc
43		* @throws ORMException
44		*/
45	1	public function process(ServerRequestInterface $request, RequestHandlerInterface $handler): ResponseInterface
46		{
47		/** @var Token $token */
48	1	$token = $request->getAttribute(ResourceMiddlewareInterface::DATA_RESOURCE);
49	1	$token->setActive(false);
50
51	1	$this->entityManager->persist($token);
52	1	$this->entityManager->flush();
53	1	return new JsonResponse([
54	1	'data' => [
55	1	'token' => $this->hydrator->extract($token),
56		],
57		'success' => true,
58	1	'msg' => new SuccessMessage('Token invalidated.'),
59	1	], 200);
60		}
61		}
62

SlayerBirden / dataflow-server

Push — master ( 178a08...5c0b6f )

InvalidateTokenAction::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like