UpdatePasswordCest::_inject() - Code Metrics - Inspection of "test coverage improvements;" - SlayerBirden/dataflow-server - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 178a08...5c0b6f )

by Oleg

created 2018-07-26 21:57 UTC

UpdatePasswordCest::_inject() A

↳ Parent: UpdatePasswordCest

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	7
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	1

<?php
declare(strict_types=1);

use Codeception\Module\CleanDoctrine2;
use Codeception\Util\HttpCode;
use SlayerBirden\DataFlowServer\Authentication\Entities\Grant;
use SlayerBirden\DataFlowServer\Authentication\Entities\Password;
use SlayerBirden\DataFlowServer\Authentication\Entities\Token;
use SlayerBirden\DataFlowServer\Authentication\Service\PasswordManager;
use SlayerBirden\DataFlowServer\Domain\Entities\User;

class UpdatePasswordCest
namespace YourVendor;

class YourClass { }
{
    /**
     * @var CleanDoctrine2
     */
    private $doctrine;
    /**
     * @var int
     */
    private $userId;
    /**
     * @var \Psr\Log\LoggerInterface
     */
    private $logger;

    public function _inject(CleanDoctrine2 $cleanDoctrine2)
    {
        $this->doctrine = $cleanDoctrine2;
        $this->logger = new \Monolog\Logger('log', [
            new \Monolog\Handler\NoopHandler()
        ]);
    }

    public function _before(ApiTester $I)

    {
        $this->userId = $I->haveInRepository(User::class, [
            'first' => 'Tester2',
            'last' => 'Tester2',
            'email' => '[email protected]',
        ]);

        $user = $I->grabEntityFromRepository(User::class, ['id' => $this->userId]);
        $passwordManager = new PasswordManager(
            $this->doctrine->em,

            $this->logger
        );

        $I->haveInRepository(Password::class, [
            'owner' => $user,
            'hash' => $passwordManager->getHash('test123'),
            'createdAt' => new DateTime(),
            'due' => new DateTime('+1 year'),
            'active' => true,
        ]);

        $tokenId = $I->haveInRepository(Token::class, [
            'owner' => $user,
            'active' => true,
            'token' => 'yyy',
            'due' => new DateTime('+1 year'),
            'createdAt' => new DateTime(),
        ]);

        $token = $I->grabEntityFromRepository(Token::class, ['id' => $tokenId]);

        $I->haveInRepository(Grant::class, [
            'token' => $token,
            'resource' => 'update_password',
        ]);

        $I->amBearerAuthenticated('yyy');
    }

    public function updatePasswordSuccess(ApiTester $I)

    {
        $I->wantTo('update my password');

        $I->haveHttpHeader('Content-Type', 'application/json');
        $I->sendPost('/updatepassword', [
            'password' => 'test123',
            'new_password' => 'there is a clown on a wing',
        ]);
        $I->seeResponseCodeIs(HttpCode::OK);
        $I->seeResponseContainsJson([
            'success' => true,
        ]);

        // check that new password works
        /** @var User $user */
        $user = $I->grabEntityFromRepository(User::class, ['id' => $this->userId]);
        $passwordManager = new PasswordManager(
            $this->doctrine->em,

            $this->logger
        );
        $valid = $passwordManager->isValidForUser('there is a clown on a wing', $user);

        $I->assertSame(true, $valid);
    }

    public function updatePasswordValidationError(ApiTester $I)

    {
        $I->wantTo('update my password but providing invalid data');

        $I->haveHttpHeader('Content-Type', 'application/json');
        $I->sendPost('/updatepassword', [
            'password' => 'test123',
            'new_password' => 'short',
        ]);
        $I->seeResponseCodeIs(HttpCode::BAD_REQUEST);
        $I->seeResponseContainsJson([
            'success' => false,
            'data' => [
                'validation' => [
                    [
                        'field' => 'new_password',
                    ]
                ]
            ]
        ]);
    }

    public function updatePasswordOldPasswordWrong(ApiTester $I)

    {
        $I->wantTo('update my password but providing wrong old pw');

        $I->haveHttpHeader('Content-Type', 'application/json');
        $I->sendPost('/updatepassword', [
            'password' => 'forgot',
            'new_password' => 'cool new password',
        ]);
        $I->seeResponseCodeIs(HttpCode::PRECONDITION_FAILED);
        $I->seeResponseContainsJson([
            'success' => false,
        ]);
    }

    public function updatePasswordWithoutProvidingOld(ApiTester $I)

    {
        $I->wantTo('update my password without providing old one');

        $I->haveHttpHeader('Content-Type', 'application/json');
        $I->sendPost('/updatepassword', [
            'new_password' => 'cool new password',
        ]);
        $I->seeResponseCodeIs(HttpCode::PRECONDITION_FAILED);
        $I->seeResponseContainsJson([
            'success' => false,
        ]);
    }

    public function updatePasswordUseUsedPw(ApiTester $I)

    {
        $I->wantTo('update my password using old password which is already in the system');

        $user = $I->grabEntityFromRepository(User::class, ['id' => $this->userId]);
        $passwordManager = new PasswordManager(
            $this->doctrine->em,

            $this->logger
        );
        $I->haveInRepository(Password::class, [
            'owner' => $user,
            'hash' => $passwordManager->getHash('old cool long password'),
            'createdAt' => new DateTime('-1 year'),
            'due' => new DateTime('-1 month'),
            'active' => false,
        ]);

        $I->haveHttpHeader('Content-Type', 'application/json');
        $I->sendPost('/updatepassword', [
            'password' => 'test123',
            'new_password' => 'old cool long password',
        ]);
        $I->seeResponseCodeIs(HttpCode::BAD_REQUEST);
        $I->seeResponseContainsJson([
            'success' => false,
        ]);
    }
}


1			<?php
2			declare(strict_types=1);
3
4			use Codeception\Module\CleanDoctrine2;
5			use Codeception\Util\HttpCode;
6			use SlayerBirden\DataFlowServer\Authentication\Entities\Grant;
7			use SlayerBirden\DataFlowServer\Authentication\Entities\Password;
8			use SlayerBirden\DataFlowServer\Authentication\Entities\Token;
9			use SlayerBirden\DataFlowServer\Authentication\Service\PasswordManager;
10			use SlayerBirden\DataFlowServer\Domain\Entities\User;
11
12			class UpdatePasswordCest
			0 ignored issues – show Complexity introduced 2018-07-26 22:02 UTC by Report Bug Copy Issue Report The class UpdatePasswordCest has a coupling between objects value of 13. Consider to reduce the number of dependencies under 13. Loading history... Coding Style Compatibility introduced 2018-07-26 22:02 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
13			{
14			/**
15			* @var CleanDoctrine2
16			*/
17			private $doctrine;
18			/**
19			* @var int
20			*/
21			private $userId;
22			/**
23			* @var \Psr\Log\LoggerInterface
24			*/
25			private $logger;
26
27			public function _inject(CleanDoctrine2 $cleanDoctrine2)
28			{
29			$this->doctrine = $cleanDoctrine2;
30			$this->logger = new \Monolog\Logger('log', [
31			new \Monolog\Handler\NoopHandler()
32			]);
33			}
34
35			public function _before(ApiTester $I)
			0 ignored issues – show Comprehensibility introduced 2018-07-26 22:02 UTC by Report Bug Copy Issue Report Avoid variables with short names like $I. Configured minimum length is 3. Short variable names may make your code harder to understand. Variable names should be self-descriptive. This check looks for variable names who are shorter than a configured minimum. Loading history...
36			{
37			$this->userId = $I->haveInRepository(User::class, [
38			'first' => 'Tester2',
39			'last' => 'Tester2',
40			'email' => '[email protected]',
41			]);
42
43			$user = $I->grabEntityFromRepository(User::class, ['id' => $this->userId]);
44			$passwordManager = new PasswordManager(
45			$this->doctrine->em,
			0 ignored issues – show Compatibility introduced 2018-07-26 22:02 UTC by Report Bug Copy Issue Report `$this->doctrine->em` of type `object<Doctrine\ORM\EntityManagerInterface>` is not a sub-type of `object<Doctrine\ORM\EntityManager>`. It seems like you assume a concrete implementation of the interface `Doctrine\ORM\EntityManagerInterface` to be always present. This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass. Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type. Loading history...
46			$this->logger
47			);
48
49			$I->haveInRepository(Password::class, [
50			'owner' => $user,
51			'hash' => $passwordManager->getHash('test123'),
52			'createdAt' => new DateTime(),
53			'due' => new DateTime('+1 year'),
54			'active' => true,
55			]);
56
57			$tokenId = $I->haveInRepository(Token::class, [
58			'owner' => $user,
59			'active' => true,
60			'token' => 'yyy',
61			'due' => new DateTime('+1 year'),
62			'createdAt' => new DateTime(),
63			]);
64
65			$token = $I->grabEntityFromRepository(Token::class, ['id' => $tokenId]);
66
67			$I->haveInRepository(Grant::class, [
68			'token' => $token,
69			'resource' => 'update_password',
70			]);
71
72			$I->amBearerAuthenticated('yyy');
73			}
74
75			public function updatePasswordSuccess(ApiTester $I)
			0 ignored issues – show Comprehensibility introduced 2018-07-26 22:02 UTC by Report Bug Copy Issue Report Avoid variables with short names like $I. Configured minimum length is 3. Short variable names may make your code harder to understand. Variable names should be self-descriptive. This check looks for variable names who are shorter than a configured minimum. Loading history...
76			{
77			$I->wantTo('update my password');
78
79			$I->haveHttpHeader('Content-Type', 'application/json');
80			$I->sendPost('/updatepassword', [
81			'password' => 'test123',
82			'new_password' => 'there is a clown on a wing',
83			]);
84			$I->seeResponseCodeIs(HttpCode::OK);
85			$I->seeResponseContainsJson([
86			'success' => true,
87			]);
88
89			// check that new password works
90			/** @var User $user */
91			$user = $I->grabEntityFromRepository(User::class, ['id' => $this->userId]);
92			$passwordManager = new PasswordManager(
93			$this->doctrine->em,
			0 ignored issues – show Compatibility introduced 2018-07-26 22:02 UTC by Report Bug Copy Issue Report `$this->doctrine->em` of type `object<Doctrine\ORM\EntityManagerInterface>` is not a sub-type of `object<Doctrine\ORM\EntityManager>`. It seems like you assume a concrete implementation of the interface `Doctrine\ORM\EntityManagerInterface` to be always present. This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass. Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type. Loading history...
94			$this->logger
95			);
96			$valid = $passwordManager->isValidForUser('there is a clown on a wing', $user);
97
98			$I->assertSame(true, $valid);
99			}
100
101			public function updatePasswordValidationError(ApiTester $I)
			0 ignored issues – show Comprehensibility introduced 2018-07-26 22:02 UTC by Report Bug Copy Issue Report Avoid variables with short names like $I. Configured minimum length is 3. Short variable names may make your code harder to understand. Variable names should be self-descriptive. This check looks for variable names who are shorter than a configured minimum. Loading history...
102			{
103			$I->wantTo('update my password but providing invalid data');
104
105			$I->haveHttpHeader('Content-Type', 'application/json');
106			$I->sendPost('/updatepassword', [
107			'password' => 'test123',
108			'new_password' => 'short',
109			]);
110			$I->seeResponseCodeIs(HttpCode::BAD_REQUEST);
111			$I->seeResponseContainsJson([
112			'success' => false,
113			'data' => [
114			'validation' => [
115			[
116			'field' => 'new_password',
117			]
118			]
119			]
120			]);
121			}
122
123			public function updatePasswordOldPasswordWrong(ApiTester $I)
			0 ignored issues – show Comprehensibility introduced 2018-07-26 22:02 UTC by Report Bug Copy Issue Report Avoid variables with short names like $I. Configured minimum length is 3. Short variable names may make your code harder to understand. Variable names should be self-descriptive. This check looks for variable names who are shorter than a configured minimum. Loading history...
124			{
125			$I->wantTo('update my password but providing wrong old pw');
126
127			$I->haveHttpHeader('Content-Type', 'application/json');
128			$I->sendPost('/updatepassword', [
129			'password' => 'forgot',
130			'new_password' => 'cool new password',
131			]);
132			$I->seeResponseCodeIs(HttpCode::PRECONDITION_FAILED);
133			$I->seeResponseContainsJson([
134			'success' => false,
135			]);
136			}
137
138			public function updatePasswordWithoutProvidingOld(ApiTester $I)
			0 ignored issues – show Comprehensibility introduced 2018-07-26 22:02 UTC by Report Bug Copy Issue Report Avoid variables with short names like $I. Configured minimum length is 3. Short variable names may make your code harder to understand. Variable names should be self-descriptive. This check looks for variable names who are shorter than a configured minimum. Loading history...
139			{
140			$I->wantTo('update my password without providing old one');
141
142			$I->haveHttpHeader('Content-Type', 'application/json');
143			$I->sendPost('/updatepassword', [
144			'new_password' => 'cool new password',
145			]);
146			$I->seeResponseCodeIs(HttpCode::PRECONDITION_FAILED);
147			$I->seeResponseContainsJson([
148			'success' => false,
149			]);
150			}
151
152			public function updatePasswordUseUsedPw(ApiTester $I)
			0 ignored issues – show Comprehensibility introduced 2018-07-26 22:02 UTC by Report Bug Copy Issue Report Avoid variables with short names like $I. Configured minimum length is 3. Short variable names may make your code harder to understand. Variable names should be self-descriptive. This check looks for variable names who are shorter than a configured minimum. Loading history...
153			{
154			$I->wantTo('update my password using old password which is already in the system');
155
156			$user = $I->grabEntityFromRepository(User::class, ['id' => $this->userId]);
157			$passwordManager = new PasswordManager(
158			$this->doctrine->em,
			0 ignored issues – show Compatibility introduced 2018-07-26 22:02 UTC by Report Bug Copy Issue Report `$this->doctrine->em` of type `object<Doctrine\ORM\EntityManagerInterface>` is not a sub-type of `object<Doctrine\ORM\EntityManager>`. It seems like you assume a concrete implementation of the interface `Doctrine\ORM\EntityManagerInterface` to be always present. This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass. Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type. Loading history...
159			$this->logger
160			);
161			$I->haveInRepository(Password::class, [
162			'owner' => $user,
163			'hash' => $passwordManager->getHash('old cool long password'),
164			'createdAt' => new DateTime('-1 year'),
165			'due' => new DateTime('-1 month'),
166			'active' => false,
167			]);
168
169			$I->haveHttpHeader('Content-Type', 'application/json');
170			$I->sendPost('/updatepassword', [
171			'password' => 'test123',
172			'new_password' => 'old cool long password',
173			]);
174			$I->seeResponseCodeIs(HttpCode::BAD_REQUEST);
175			$I->seeResponseContainsJson([
176			'success' => false,
177			]);
178			}
179			}
180

SlayerBirden / dataflow-server

Push — master ( 178a08...5c0b6f )

UpdatePasswordCest::_inject() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like