SlayerBirden\DataFlowServer\Authentication\Controller\CreatePasswordAction

Complexity

Total Complexity

5

Size/Duplication

Total Lines	80
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	9

Test Coverage

Coverage

85.19%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	11	1
A	process()	0	22	3
A	createPassword()	0	17	1

<?php
declare(strict_types=1);

namespace SlayerBirden\DataFlowServer\Authentication\Controller;

use Doctrine\ORM\EntityManager;
use Psr\Http\Message\ResponseInterface;
use Psr\Http\Message\ServerRequestInterface;
use Psr\Http\Server\MiddlewareInterface;
use Psr\Http\Server\RequestHandlerInterface;
use Psr\Log\LoggerInterface;
use SlayerBirden\DataFlowServer\Authentication\Entities\Password;
use SlayerBirden\DataFlowServer\Notification\DangerMessage;
use SlayerBirden\DataFlowServer\Notification\SuccessMessage;
use SlayerBirden\DataFlowServer\Stdlib\Validation\ValidationResponseFactory;
use Zend\Diactoros\Response\JsonResponse;
use Zend\Hydrator\HydratorInterface;
use Zend\InputFilter\InputFilterInterface;

class CreatePasswordAction implements MiddlewareInterface
{
    /**
     * @var EntityManager
     */
    private $entityManager;
    /**
     * @var InputFilterInterface
     */
    private $inputFilter;
    /**
     * @var LoggerInterface
     */
    private $logger;
    /**
     * @var HydratorInterface
     */
    private $hydrator;

    public function __construct(
        EntityManager $entityManager,

You have injected the EntityManager via parameter $entityManager. This is generally not recommended as it might get closed and become unusable. Instead, it is recommended to inject the ManagerRegistry and retrieve the EntityManager via getManager() each time you need it.

        InputFilterInterface $inputFilter,
        LoggerInterface $logger,
        HydratorInterface $hydrator
    ) {
        $this->entityManager = $entityManager;
        $this->inputFilter = $inputFilter;
        $this->logger = $logger;
        $this->hydrator = $hydrator;
    }

    /**
     * @inheritdoc
     */
    public function process(ServerRequestInterface $request, RequestHandlerInterface $handler): ResponseInterface
    {
        $data = $request->getParsedBody();
        $this->inputFilter->setData($data);

It seems like $data defined by $request->getParsedBody() on line 56 can also be of type null or object; however, Zend\InputFilter\InputFilterInterface::setData() does only seem to accept array|object<Traversable>, maybe add an additional type check?

        if ($this->inputFilter->isValid()) {
            try {
                return $this->createPassword($data);

It seems like $data defined by $request->getParsedBody() on line 56 can also be of type null or object; however, SlayerBirden\DataFlowServer\Authentication\Controller\CreatePasswordAction::createPassword() does only seem to accept array, maybe add an additional type check?

            } catch (\Exception $exception) {
                return new JsonResponse([
                    'msg' => new DangerMessage('There was an error while creating password.'),
                    'success' => true,
                    'data' => [
                        'validation' => [],
                        'password' => null,
                    ]
                ], 500);
            }
        } else {
            return (new ValidationResponseFactory())('password', $this->inputFilter);
        }
    }

    /**
     * @param array $data
     * @return ResponseInterface
     * @throws \Exception
     */
    private function createPassword(array $data): ResponseInterface
    {
        $data['created_at'] = (new \DateTime())->format(\DateTime::RFC3339);
        $data['due'] = (new \DateTime())->add(new \DateInterval('P1Y'))->format(\DateTime::RFC3339);
        $data['active'] = $data['active'] ?? true;
        $password = $this->hydrator->hydrate($data, new Password());
        $this->entityManager->persist($password);
        $this->entityManager->flush();
        return new JsonResponse([
            'msg' => new SuccessMessage('Password has been successfully created!'),
            'success' => true,
            'data' => [
                'validation' => [],
                'password' => $this->hydrator->extract($password),
            ]
        ], 200);
    }
}