UpdatePasswordCest::_before() - Code Metrics - Inspection of "improve coverage; fix some inspection issues;" - SlayerBirden/dataflow-server - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 3eb757...3bc7c8 )

by Oleg

created 2018-09-07 21:27 UTC

UpdatePasswordCest::_before() A

↳ Parent: UpdatePasswordCest

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	39
rs	9.296
c	0
b	0
f	0
cc	1
nc	1
nop	1

<?php
declare(strict_types=1);

namespace codecept\authentication;

use codecept\ApiTester;
use codecept\Helper\CleanDoctrine2;
use Codeception\Util\HttpCode;
use SlayerBirden\DataFlowServer\Authentication\Entities\Grant;
use SlayerBirden\DataFlowServer\Authentication\Entities\Password;
use SlayerBirden\DataFlowServer\Authentication\Entities\Token;
use SlayerBirden\DataFlowServer\Authentication\Repository\PasswordRepository;
use SlayerBirden\DataFlowServer\Authentication\Service\PasswordManager;
use SlayerBirden\DataFlowServer\Domain\Entities\User;

class UpdatePasswordCest

{
    /**
     * @var CleanDoctrine2
     */
    private $doctrine;
    /**
     * @var int
     */
    private $userId;
    /**
     * @var \Psr\Log\LoggerInterface
     */
    private $logger;
    /**
     * @var PasswordManager
     */
    private $passwordManager;

    public function _inject(CleanDoctrine2 $cleanDoctrine2)
    {
        $this->doctrine = $cleanDoctrine2;
        $this->logger = new \Monolog\Logger('log', [
            new \Monolog\Handler\NoopHandler()
        ]);
    }

    public function _before(ApiTester $I)

    {
        $this->userId = $I->haveInRepository(User::class, [
            'first' => 'Tester2',
            'last' => 'Tester2',
            'email' => '[email protected]',
        ]);

        $user = $I->grabEntityFromRepository(User::class, ['id' => $this->userId]);
        $this->passwordManager = new PasswordManager(
            new PasswordRepository($this->doctrine->registry),
            $this->logger
        );

        $I->haveInRepository(Password::class, [
            'owner' => $user,
            'hash' => $this->passwordManager->getHash('test123'),
            'createdAt' => new \DateTime(),
            'due' => new \DateTime('+1 year'),
            'active' => true,
        ]);

        $tokenId = $I->haveInRepository(Token::class, [
            'owner' => $user,
            'active' => true,
            'token' => 'yyy',
            'due' => new \DateTime('+1 year'),
            'createdAt' => new \DateTime(),
        ]);

        $token = $I->grabEntityFromRepository(Token::class, ['id' => $tokenId]);

        $I->haveInRepository(Grant::class, [
            'token' => $token,
            'resource' => 'update_password',
        ]);

        $I->amBearerAuthenticated('yyy');
    }

    public function updatePasswordSuccess(ApiTester $I)

    {
        $I->wantTo('update my password');

        $I->haveHttpHeader('Content-Type', 'application/json');
        $I->sendPost('/updatepassword', [
            'password' => 'test123',
            'new_password' => 'there is a clown on a wing',
        ]);
        $I->seeResponseCodeIs(HttpCode::OK);
        $I->seeResponseContainsJson([
            'success' => true,
        ]);

        // check that new password works
        /** @var User $user */
        $user = $I->grabEntityFromRepository(User::class, ['id' => $this->userId]);
        $valid = $this->passwordManager->isValidForUser('there is a clown on a wing', $user);

        $I->assertSame(true, $valid);
    }

    public function updatePasswordValidationError(ApiTester $I)

    {
        $I->wantTo('update my password but providing invalid data');

        $I->haveHttpHeader('Content-Type', 'application/json');
        $I->sendPost('/updatepassword', [
            'password' => 'test123',
            'new_password' => 'short',
        ]);
        $I->seeResponseCodeIs(HttpCode::BAD_REQUEST);
        $I->seeResponseContainsJson([
            'success' => false,
            'data' => [
                'validation' => [
                    [
                        'field' => 'new_password',
                    ]
                ]
            ]
        ]);
    }

    public function updatePasswordOldPasswordWrong(ApiTester $I)

    {
        $I->wantTo('update my password but providing wrong old pw');

        $I->haveHttpHeader('Content-Type', 'application/json');
        $I->sendPost('/updatepassword', [
            'password' => 'forgot',
            'new_password' => 'cool new password',
        ]);
        $I->seeResponseCodeIs(HttpCode::PRECONDITION_FAILED);
        $I->seeResponseContainsJson([
            'success' => false,
        ]);
    }

    public function updatePasswordWithoutProvidingOld(ApiTester $I)

    {
        $I->wantTo('update my password without providing old one');

        $I->haveHttpHeader('Content-Type', 'application/json');
        $I->sendPost('/updatepassword', [
            'new_password' => 'cool new password',
        ]);
        $I->seeResponseCodeIs(HttpCode::PRECONDITION_FAILED);
        $I->seeResponseContainsJson([
            'success' => false,
        ]);
    }

    public function updatePasswordUseUsedPw(ApiTester $I)

    {
        $I->wantTo('update my password using old password which is already in the system');

        $user = $I->grabEntityFromRepository(User::class, ['id' => $this->userId]);
        $I->haveInRepository(Password::class, [
            'owner' => $user,
            'hash' => $this->passwordManager->getHash('old cool long password'),
            'createdAt' => new \DateTime('-1 year'),
            'due' => new \DateTime('-1 month'),
            'active' => false,
        ]);

        $I->haveHttpHeader('Content-Type', 'application/json');
        $I->sendPost('/updatepassword', [
            'password' => 'test123',
            'new_password' => 'old cool long password',
        ]);
        $I->seeResponseCodeIs(HttpCode::BAD_REQUEST);
        $I->seeResponseContainsJson([
            'success' => false,
        ]);
    }
}


1			<?php
2			declare(strict_types=1);
3
4			namespace codecept\authentication;
5
6			use codecept\ApiTester;
7			use codecept\Helper\CleanDoctrine2;
8			use Codeception\Util\HttpCode;
9			use SlayerBirden\DataFlowServer\Authentication\Entities\Grant;
10			use SlayerBirden\DataFlowServer\Authentication\Entities\Password;
11			use SlayerBirden\DataFlowServer\Authentication\Entities\Token;
12			use SlayerBirden\DataFlowServer\Authentication\Repository\PasswordRepository;
13			use SlayerBirden\DataFlowServer\Authentication\Service\PasswordManager;
14			use SlayerBirden\DataFlowServer\Domain\Entities\User;
15
16			class UpdatePasswordCest
			0 ignored issues – show Complexity introduced 2018-07-26 22:02 UTC by Report Bug Copy Issue Report The class UpdatePasswordCest has a coupling between objects value of 15. Consider to reduce the number of dependencies under 13. Loading history...
17			{
18			/**
19			* @var CleanDoctrine2
20			*/
21			private $doctrine;
22			/**
23			* @var int
24			*/
25			private $userId;
26			/**
27			* @var \Psr\Log\LoggerInterface
28			*/
29			private $logger;
30			/**
31			* @var PasswordManager
32			*/
33			private $passwordManager;
34
35			public function _inject(CleanDoctrine2 $cleanDoctrine2)
36			{
37			$this->doctrine = $cleanDoctrine2;
38			$this->logger = new \Monolog\Logger('log', [
39			new \Monolog\Handler\NoopHandler()
40			]);
41			}
42
43			public function _before(ApiTester $I)
			0 ignored issues – show Comprehensibility introduced 2018-07-26 22:02 UTC by Report Bug Copy Issue Report Avoid variables with short names like $I. Configured minimum length is 3. Short variable names may make your code harder to understand. Variable names should be self-descriptive. This check looks for variable names who are shorter than a configured minimum. Loading history...
44			{
45			$this->userId = $I->haveInRepository(User::class, [
46			'first' => 'Tester2',
47			'last' => 'Tester2',
48			'email' => '[email protected]',
49			]);
50
51			$user = $I->grabEntityFromRepository(User::class, ['id' => $this->userId]);
52			$this->passwordManager = new PasswordManager(
53			new PasswordRepository($this->doctrine->registry),
54			$this->logger
55			);
56
57			$I->haveInRepository(Password::class, [
58			'owner' => $user,
59			'hash' => $this->passwordManager->getHash('test123'),
60			'createdAt' => new \DateTime(),
61			'due' => new \DateTime('+1 year'),
62			'active' => true,
63			]);
64
65			$tokenId = $I->haveInRepository(Token::class, [
66			'owner' => $user,
67			'active' => true,
68			'token' => 'yyy',
69			'due' => new \DateTime('+1 year'),
70			'createdAt' => new \DateTime(),
71			]);
72
73			$token = $I->grabEntityFromRepository(Token::class, ['id' => $tokenId]);
74
75			$I->haveInRepository(Grant::class, [
76			'token' => $token,
77			'resource' => 'update_password',
78			]);
79
80			$I->amBearerAuthenticated('yyy');
81			}
82
83			public function updatePasswordSuccess(ApiTester $I)
			0 ignored issues – show Comprehensibility introduced 2018-07-26 22:02 UTC by Report Bug Copy Issue Report Avoid variables with short names like $I. Configured minimum length is 3. Short variable names may make your code harder to understand. Variable names should be self-descriptive. This check looks for variable names who are shorter than a configured minimum. Loading history...
84			{
85			$I->wantTo('update my password');
86
87			$I->haveHttpHeader('Content-Type', 'application/json');
88			$I->sendPost('/updatepassword', [
89			'password' => 'test123',
90			'new_password' => 'there is a clown on a wing',
91			]);
92			$I->seeResponseCodeIs(HttpCode::OK);
93			$I->seeResponseContainsJson([
94			'success' => true,
95			]);
96
97			// check that new password works
98			/** @var User $user */
99			$user = $I->grabEntityFromRepository(User::class, ['id' => $this->userId]);
100			$valid = $this->passwordManager->isValidForUser('there is a clown on a wing', $user);
101
102			$I->assertSame(true, $valid);
103			}
104
105			public function updatePasswordValidationError(ApiTester $I)
			0 ignored issues – show Comprehensibility introduced 2018-07-26 22:02 UTC by Report Bug Copy Issue Report Avoid variables with short names like $I. Configured minimum length is 3. Short variable names may make your code harder to understand. Variable names should be self-descriptive. This check looks for variable names who are shorter than a configured minimum. Loading history...
106			{
107			$I->wantTo('update my password but providing invalid data');
108
109			$I->haveHttpHeader('Content-Type', 'application/json');
110			$I->sendPost('/updatepassword', [
111			'password' => 'test123',
112			'new_password' => 'short',
113			]);
114			$I->seeResponseCodeIs(HttpCode::BAD_REQUEST);
115			$I->seeResponseContainsJson([
116			'success' => false,
117			'data' => [
118			'validation' => [
119			[
120			'field' => 'new_password',
121			]
122			]
123			]
124			]);
125			}
126
127			public function updatePasswordOldPasswordWrong(ApiTester $I)
			0 ignored issues – show Comprehensibility introduced 2018-07-26 22:02 UTC by Report Bug Copy Issue Report Avoid variables with short names like $I. Configured minimum length is 3. Short variable names may make your code harder to understand. Variable names should be self-descriptive. This check looks for variable names who are shorter than a configured minimum. Loading history...
128			{
129			$I->wantTo('update my password but providing wrong old pw');
130
131			$I->haveHttpHeader('Content-Type', 'application/json');
132			$I->sendPost('/updatepassword', [
133			'password' => 'forgot',
134			'new_password' => 'cool new password',
135			]);
136			$I->seeResponseCodeIs(HttpCode::PRECONDITION_FAILED);
137			$I->seeResponseContainsJson([
138			'success' => false,
139			]);
140			}
141
142			public function updatePasswordWithoutProvidingOld(ApiTester $I)
			0 ignored issues – show Comprehensibility introduced 2018-07-26 22:02 UTC by Report Bug Copy Issue Report Avoid variables with short names like $I. Configured minimum length is 3. Short variable names may make your code harder to understand. Variable names should be self-descriptive. This check looks for variable names who are shorter than a configured minimum. Loading history...
143			{
144			$I->wantTo('update my password without providing old one');
145
146			$I->haveHttpHeader('Content-Type', 'application/json');
147			$I->sendPost('/updatepassword', [
148			'new_password' => 'cool new password',
149			]);
150			$I->seeResponseCodeIs(HttpCode::PRECONDITION_FAILED);
151			$I->seeResponseContainsJson([
152			'success' => false,
153			]);
154			}
155
156			public function updatePasswordUseUsedPw(ApiTester $I)
			0 ignored issues – show Comprehensibility introduced 2018-07-26 22:02 UTC by Report Bug Copy Issue Report Avoid variables with short names like $I. Configured minimum length is 3. Short variable names may make your code harder to understand. Variable names should be self-descriptive. This check looks for variable names who are shorter than a configured minimum. Loading history...
157			{
158			$I->wantTo('update my password using old password which is already in the system');
159
160			$user = $I->grabEntityFromRepository(User::class, ['id' => $this->userId]);
161			$I->haveInRepository(Password::class, [
162			'owner' => $user,
163			'hash' => $this->passwordManager->getHash('old cool long password'),
164			'createdAt' => new \DateTime('-1 year'),
165			'due' => new \DateTime('-1 month'),
166			'active' => false,
167			]);
168
169			$I->haveHttpHeader('Content-Type', 'application/json');
170			$I->sendPost('/updatepassword', [
171			'password' => 'test123',
172			'new_password' => 'old cool long password',
173			]);
174			$I->seeResponseCodeIs(HttpCode::BAD_REQUEST);
175			$I->seeResponseContainsJson([
176			'success' => false,
177			]);
178			}
179			}
180

SlayerBirden / dataflow-server

Push — master ( 3eb757...3bc7c8 )

UpdatePasswordCest::_before() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like