GetPermissionHistoryCest::_before() - Code Metrics - Inspection of "add history getter; improve code coverate;" - SlayerBirden/dataflow-server - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( a199f7...eac768 )

by Oleg

created 2018-09-08 21:15 UTC

GetPermissionHistoryCest::_before() A

↳ Parent: GetPermissionHistoryCest

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	11
rs	9.9
c	0
b	0
f	0
cc	1
nc	1
nop	1

<?php

namespace codecept\authorization;

use codecept\ApiTester;
use Codeception\Util\HttpCode;
use SlayerBirden\DataFlowServer\Authorization\Entities\History;
use SlayerBirden\DataFlowServer\Authorization\Service\HistoryManagement;
use SlayerBirden\DataFlowServer\Domain\Entities\User;

class GetPermissionHistoryCest
{
    /**
     * @param ApiTester $I
     * @throws \Exception
     */
    public function _before(ApiTester $I)

    {
        $user = $I->grabEntityFromRepository(User::class, ['id' => $I->getCurrentUserId()]);
        $I->haveInRepository(History::class, [
            'user' => $user,
            'owner' => $user,
            'resource' => 'awesome_sauce',
            'changeAction' => HistoryManagement::ACTION_REMOVE,
            'at' => new \DateTime(),
        ]);
    }

    public function getHistorySuccess(ApiTester $I)

    {
        $I->wantTo('Get permission history');
        $I->sendGet('/history');
        $I->seeResponseCodeIs(HttpCode::OK);
        $I->seeResponseIsJson();
        $I->seeResponseJsonMatchesJsonPath('$.data.history[*]');
    }
}


1			<?php
2
3			namespace codecept\authorization;
4
5			use codecept\ApiTester;
6			use Codeception\Util\HttpCode;
7			use SlayerBirden\DataFlowServer\Authorization\Entities\History;
8			use SlayerBirden\DataFlowServer\Authorization\Service\HistoryManagement;
9			use SlayerBirden\DataFlowServer\Domain\Entities\User;
10
11			class GetPermissionHistoryCest
12			{
13			/**
14			* @param ApiTester $I
15			* @throws \Exception
16			*/
17			public function _before(ApiTester $I)
			0 ignored issues – show Comprehensibility introduced 2018-09-08 21:21 UTC by Report Bug Copy Issue Report Avoid variables with short names like $I. Configured minimum length is 3. Short variable names may make your code harder to understand. Variable names should be self-descriptive. This check looks for variable names who are shorter than a configured minimum. Loading history...
18			{
19			$user = $I->grabEntityFromRepository(User::class, ['id' => $I->getCurrentUserId()]);
20			$I->haveInRepository(History::class, [
21			'user' => $user,
22			'owner' => $user,
23			'resource' => 'awesome_sauce',
24			'changeAction' => HistoryManagement::ACTION_REMOVE,
25			'at' => new \DateTime(),
26			]);
27			}
28
29			public function getHistorySuccess(ApiTester $I)
			0 ignored issues – show Comprehensibility introduced 2018-09-08 21:21 UTC by Report Bug Copy Issue Report Avoid variables with short names like $I. Configured minimum length is 3. Short variable names may make your code harder to understand. Variable names should be self-descriptive. This check looks for variable names who are shorter than a configured minimum. Loading history...
30			{
31			$I->wantTo('Get permission history');
32			$I->sendGet('/history');
33			$I->seeResponseCodeIs(HttpCode::OK);
34			$I->seeResponseIsJson();
35			$I->seeResponseJsonMatchesJsonPath('$.data.history[*]');
36			}
37			}
38

SlayerBirden / dataflow-server

Push — master ( a199f7...eac768 )

GetPermissionHistoryCest::_before() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like