UpdateUserAction::process() - Code Metrics - Inspection of "fix build errors; change error reporting for test..." - SlayerBirden/dataflow-server - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 51e9c2...0afc07 )

by Oleg

created 2018-03-07 13:26 UTC

UpdateUserAction::process() B

↳ Parent: UpdateUserAction

Complexity

Conditions	8
Paths	19

Size

Total Lines	53
Code Lines	42

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	33
CRAP Score	8.2327

Importance

Changes

Metric	Value
cc	8
eloc	42
nc	19
nop	2
dl	0
loc	53
ccs	33
cts	39
cp	0.8462
crap	8.2327
rs	7.1199
c	0
b	0
f	0

How to fix Long Method

<?php
declare(strict_types=1);

namespace SlayerBirden\DataFlowServer\Domain\Controller;

use Doctrine\DBAL\Exception\UniqueConstraintViolationException;
use Doctrine\ORM\EntityManagerInterface;
use Doctrine\ORM\ORMException;
use Doctrine\ORM\ORMInvalidArgumentException;
use Psr\Http\Server\MiddlewareInterface;
use SlayerBirden\DataFlowServer\Doctrine\Exception\NonExistingEntity;
use SlayerBirden\DataFlowServer\Domain\Entities\User;
use SlayerBirden\DataFlowServer\Notification\DangerMessage;
use SlayerBirden\DataFlowServer\Notification\SuccessMessage;
use Psr\Http\Server\RequestHandlerInterface;
use Psr\Http\Message\ResponseInterface;
use Psr\Http\Message\ServerRequestInterface;
use Psr\Log\LoggerInterface;
use Zend\Diactoros\Response\JsonResponse;
use Zend\Hydrator\ExtractionInterface;
use Zend\Hydrator\HydratorInterface;
use Zend\InputFilter\InputFilterInterface;

class UpdateUserAction implements MiddlewareInterface
{
    /**
     * @var EntityManagerInterface
     */
    private $entityManager;
    /**
     * @var HydratorInterface
     */
    private $hydrator;
    /**
     * @var InputFilterInterface
     */
    private $inputFilter;
    /**
     * @var LoggerInterface
     */
    private $logger;
    /**
     * @var ExtractionInterface
     */
    private $extraction;

    public function __construct(
        EntityManagerInterface $entityManager,
        HydratorInterface $hydrator,
        InputFilterInterface $inputFilter,
        LoggerInterface $logger,
        ExtractionInterface $extraction
    ) {
        $this->entityManager = $entityManager;
        $this->hydrator = $hydrator;
        $this->inputFilter = $inputFilter;
        $this->logger = $logger;
        $this->extraction = $extraction;
    }

    /**
     * @inheritdoc
     */
    public function process(ServerRequestInterface $request, RequestHandlerInterface $handler): ResponseInterface
    {
        $data = $request->getParsedBody();
        $id = (int)$request->getAttribute('id');

        $this->inputFilter->setData($data);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

        $message = null;
        $validation = [];
        $updated = false;
        $status = 200;

        if ($this->inputFilter->isValid()) {
            try {
                $user = $this->getUser($id, $data);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
                $this->entityManager->persist($user);
                $this->entityManager->flush();
                $message = new SuccessMessage('User has been updated!');
                $updated = true;
            } catch (NonExistingEntity $exception) {
                $message = new DangerMessage($exception->getMessage());
                $status = 404;
            } catch (ORMInvalidArgumentException $exception) {
                $message = new DangerMessage($exception->getMessage());
                $status = 400;
            } catch (UniqueConstraintViolationException $exception) {
                $message = new DangerMessage('Email address already taken.');
                $status = 400;
            } catch (ORMException $exception) {
                $this->logger->error((string)$exception);
                $message = new DangerMessage('Error saving user.');
                $status = 400;
            }
        } else {
            foreach ($this->inputFilter->getInvalidInput() as $key => $input) {
                $messages = $input->getMessages();
                $validation[] = [
                    'field' => $key,
                    'msg' => reset($messages)
                ];
            }
            $status = 400;
        }

        return new JsonResponse([
            'msg' => $message,
            'success' => $updated,
            'data' => [
                'validation' => $validation,
                'user' => isset($user) ? $this->extraction->extract($user) : null,
            ]
        ], $status);
    }

    private function getUser(int $id, array $data): User
    {
        /** @var User $user */
        $user = $this->entityManager->find(User::class, $id);
        if (!$user) {
            throw new NonExistingEntity(sprintf('Could not find user by id %d.', $id));
        }
        if (isset($data['id'])) {
            unset($data['id']);
        }
        $this->hydrator->hydrate($data, $user);

        return $user;
    }
}


1		<?php
2		declare(strict_types=1);
3
4		namespace SlayerBirden\DataFlowServer\Domain\Controller;
5
6		use Doctrine\DBAL\Exception\UniqueConstraintViolationException;
7		use Doctrine\ORM\EntityManagerInterface;
8		use Doctrine\ORM\ORMException;
9		use Doctrine\ORM\ORMInvalidArgumentException;
10		use Psr\Http\Server\MiddlewareInterface;
11		use SlayerBirden\DataFlowServer\Doctrine\Exception\NonExistingEntity;
12		use SlayerBirden\DataFlowServer\Domain\Entities\User;
13		use SlayerBirden\DataFlowServer\Notification\DangerMessage;
14		use SlayerBirden\DataFlowServer\Notification\SuccessMessage;
15		use Psr\Http\Server\RequestHandlerInterface;
16		use Psr\Http\Message\ResponseInterface;
17		use Psr\Http\Message\ServerRequestInterface;
18		use Psr\Log\LoggerInterface;
19		use Zend\Diactoros\Response\JsonResponse;
20		use Zend\Hydrator\ExtractionInterface;
21		use Zend\Hydrator\HydratorInterface;
22		use Zend\InputFilter\InputFilterInterface;
23
24		class UpdateUserAction implements MiddlewareInterface
25		{
26		/**
27		* @var EntityManagerInterface
28		*/
29		private $entityManager;
30		/**
31		* @var HydratorInterface
32		*/
33		private $hydrator;
34		/**
35		* @var InputFilterInterface
36		*/
37		private $inputFilter;
38		/**
39		* @var LoggerInterface
40		*/
41		private $logger;
42		/**
43		* @var ExtractionInterface
44		*/
45		private $extraction;
46
47	5	public function __construct(
48		EntityManagerInterface $entityManager,
49		HydratorInterface $hydrator,
50		InputFilterInterface $inputFilter,
51		LoggerInterface $logger,
52		ExtractionInterface $extraction
53		) {
54	5	$this->entityManager = $entityManager;
55	5	$this->hydrator = $hydrator;
56	5	$this->inputFilter = $inputFilter;
57	5	$this->logger = $logger;
58	5	$this->extraction = $extraction;
59	5	}
60
61		/**
62		* @inheritdoc
63		*/
64	5	public function process(ServerRequestInterface $request, RequestHandlerInterface $handler): ResponseInterface
65		{
66	5	$data = $request->getParsedBody();
67	5	$id = (int)$request->getAttribute('id');
68
69	5	$this->inputFilter->setData($data);
		0 ignored issues – show Bug introduced 2018-03-06 23:58 UTC by Report Bug Copy Issue Report It seems like `$data` defined by `$request->getParsedBody()` on line `66` can also be of type `null` or `object`; however, `Zend\InputFilter\InputFilterInterface::setData()` does only seem to accept `array\|object<Traversable>`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
70
71	5	$message = null;
72	5	$validation = [];
73	5	$updated = false;
74	5	$status = 200;
75
76	5	if ($this->inputFilter->isValid()) {
77		try {
78	4	$user = $this->getUser($id, $data);
		0 ignored issues – show Bug introduced 2018-03-06 23:58 UTC by Report Bug Copy Issue Report It seems like `$data` defined by `$request->getParsedBody()` on line `66` can also be of type `null` or `object`; however, `SlayerBirden\DataFlowSer...teUserAction::getUser()` does only seem to accept `array`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
79	3	$this->entityManager->persist($user);
80	3	$this->entityManager->flush();
81	2	$message = new SuccessMessage('User has been updated!');
82	2	$updated = true;
83	2	} catch (NonExistingEntity $exception) {
84	1	$message = new DangerMessage($exception->getMessage());
85	1	$status = 404;
86	1	} catch (ORMInvalidArgumentException $exception) {
87		$message = new DangerMessage($exception->getMessage());
88		$status = 400;
89	1	} catch (UniqueConstraintViolationException $exception) {
90	1	$message = new DangerMessage('Email address already taken.');
91	1	$status = 400;
92		} catch (ORMException $exception) {
93		$this->logger->error((string)$exception);
94		$message = new DangerMessage('Error saving user.');
95		$status = 400;
96		}
97		} else {
98	1	foreach ($this->inputFilter->getInvalidInput() as $key => $input) {
99	1	$messages = $input->getMessages();
100	1	$validation[] = [
101	1	'field' => $key,
102	1	'msg' => reset($messages)
103		];
104		}
105	1	$status = 400;
106		}
107
108	5	return new JsonResponse([
109	5	'msg' => $message,
110	5	'success' => $updated,
111		'data' => [
112	5	'validation' => $validation,
113	3	'user' => isset($user) ? $this->extraction->extract($user) : null,
114		]
115	5	], $status);
116		}
117
118	4	private function getUser(int $id, array $data): User
119		{
120		/** @var User $user */
121	4	$user = $this->entityManager->find(User::class, $id);
122	4	if (!$user) {
123	1	throw new NonExistingEntity(sprintf('Could not find user by id %d.', $id));
124		}
125	3	if (isset($data['id'])) {
126	1	unset($data['id']);
127		}
128	3	$this->hydrator->hydrate($data, $user);
129
130	3	return $user;
131		}
132		}
133

SlayerBirden / dataflow-server

Push — master ( 51e9c2...0afc07 )

UpdateUserAction::process() B

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like