DbConfigResourceMiddleware::process() - Code Metrics - Inspection of "remove local dep" - SlayerBirden/dataflow-server - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 298ac7...0024da )

by Oleg

created 2018-06-19 08:57 UTC

DbConfigResourceMiddleware::process() B

↳ Parent: DbConfigResourceMiddleware

Complexity

Conditions	4
Paths	5

Size

Total Lines	27
Code Lines	18

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	12
CRAP Score	4.128

Importance

Changes

Metric	Value
dl	0
loc	27
ccs	12
cts	15
cp	0.8
rs	8.5806
c	0
b	0
f	0
cc	4
eloc	18
nc	5
nop	2
crap	4.128

<?php
declare(strict_types=1);

namespace SlayerBirden\DataFlowServer\Db\Middleware;

use Doctrine\ORM\EntityManager;
use Doctrine\ORM\ORMException;
use Doctrine\ORM\ORMInvalidArgumentException;
use Psr\Http\Message\ResponseInterface;
use Psr\Http\Message\ServerRequestInterface;
use Psr\Http\Server\RequestHandlerInterface;
use Psr\Log\LoggerInterface;
use SlayerBirden\DataFlowServer\Db\Entities\DbConfiguration;
use SlayerBirden\DataFlowServer\Doctrine\Middleware\ResourceMiddlewareInterface;
use SlayerBirden\DataFlowServer\Notification\DangerMessage;
use Zend\Diactoros\Response\JsonResponse;

class DbConfigResourceMiddleware implements ResourceMiddlewareInterface
{
    /**
     * @var EntityManager
     */
    private $entityManager;
    /**
     * @var LoggerInterface
     */
    private $logger;

    public function __construct(EntityManager $entityManager, LoggerInterface $logger)
function someFunction(ManagerRegistry $registry) {
    $em = $registry->getManager();
    $em->getConnection()->beginTransaction();
    try {
        // Do something.
        $em->getConnection()->commit();
    } catch (\Exception $ex) {
        $em->getConnection()->rollback();
        $em->close();

        throw $ex;
    }
}
    {
        $this->entityManager = $entityManager;
        $this->logger = $logger;
    }

    /**
     * @inheritdoc
     */
    public function process(ServerRequestInterface $request, RequestHandlerInterface $handler): ResponseInterface
    {
        $id = $request->getAttribute('id');
        $msg = new DangerMessage('Could not load Configuration by provided ID.');

        if ($id !== null) {
            try {
                $dbConfig = $this->entityManager->find(DbConfiguration::class, $id);
                if ($dbConfig) {
                    return $handler->handle(
                        $request->withAttribute(self::DATA_RESOURCE, $dbConfig)
                    );
                }
            } catch (ORMInvalidArgumentException | ORMException $exception) {
                $this->logger->error((string)$exception);
                $msg = new DangerMessage('Error during loading DB Configuration.');
            }
        }

        return new JsonResponse([
            'data' => [
                'configuration' => null,
            ],
            'success' => false,
            'msg' => $msg,
        ], 404);
    }
}


1		<?php
2		declare(strict_types=1);
3
4		namespace SlayerBirden\DataFlowServer\Db\Middleware;
5
6		use Doctrine\ORM\EntityManager;
7		use Doctrine\ORM\ORMException;
8		use Doctrine\ORM\ORMInvalidArgumentException;
9		use Psr\Http\Message\ResponseInterface;
10		use Psr\Http\Message\ServerRequestInterface;
11		use Psr\Http\Server\RequestHandlerInterface;
12		use Psr\Log\LoggerInterface;
13		use SlayerBirden\DataFlowServer\Db\Entities\DbConfiguration;
14		use SlayerBirden\DataFlowServer\Doctrine\Middleware\ResourceMiddlewareInterface;
15		use SlayerBirden\DataFlowServer\Notification\DangerMessage;
16		use Zend\Diactoros\Response\JsonResponse;
17
18		class DbConfigResourceMiddleware implements ResourceMiddlewareInterface
19		{
20		/**
21		* @var EntityManager
22		*/
23		private $entityManager;
24		/**
25		* @var LoggerInterface
26		*/
27		private $logger;
28
29	7	public function __construct(EntityManager $entityManager, LoggerInterface $logger)
		0 ignored issues – show Bug introduced 2018-06-19 09:10 UTC by Report Bug Copy Issue Report You have injected the EntityManager via parameter `$entityManager`. This is generally not recommended as it might get closed and become unusable. Instead, it is recommended to inject the ManagerRegistry and retrieve the EntityManager via `getManager()` each time you need it. The `EntityManager` might become unusable for example if a transaction is rolled back and it gets closed. Let’s assume that somewhere in your application, or in a third-party library, there is code such as the following: function someFunction(ManagerRegistry $registry) { $em = $registry->getManager(); $em->getConnection()->beginTransaction(); try { // Do something. $em->getConnection()->commit(); } catch (\Exception $ex) { $em->getConnection()->rollback(); $em->close(); throw $ex; } } If that code throws an exception and the `EntityManager` is closed. Any other code which depends on the same instance of the `EntityManager` during this request will fail. On the other hand, if you instead inject the `ManagerRegistry`, the `getManager()` method guarantees that you will always get a usable manager instance. Loading history...
30		{
31	7	$this->entityManager = $entityManager;
32	7	$this->logger = $logger;
33	7	}
34
35		/**
36		* @inheritdoc
37		*/
38	7	public function process(ServerRequestInterface $request, RequestHandlerInterface $handler): ResponseInterface
39		{
40	7	$id = $request->getAttribute('id');
41	7	$msg = new DangerMessage('Could not load Configuration by provided ID.');
42
43	7	if ($id !== null) {
44		try {
45	7	$dbConfig = $this->entityManager->find(DbConfiguration::class, $id);
46	7	if ($dbConfig) {
47	4	return $handler->handle(
48	4	$request->withAttribute(self::DATA_RESOURCE, $dbConfig)
49		);
50		}
51		} catch (ORMInvalidArgumentException \| ORMException $exception) {
52		$this->logger->error((string)$exception);
53		$msg = new DangerMessage('Error during loading DB Configuration.');
54		}
55		}
56
57	3	return new JsonResponse([
58	3	'data' => [
59		'configuration' => null,
60		],
61		'success' => false,
62	3	'msg' => $msg,
63	3	], 404);
64		}
65		}
66

SlayerBirden / dataflow-server

Push — master ( 298ac7...0024da )

DbConfigResourceMiddleware::process() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like