SlayerBirden\DataFlowServer\Authorization\Service\HistoryManagement

Complexity

Total Complexity

4

Size/Duplication

Total Lines	41
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Test Coverage

Coverage

0%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
B	fromPermission()	0	24	3

<?php
declare(strict_types=1);

namespace SlayerBirden\DataFlowServer\Authorization\Service;

use Doctrine\ORM\EntityManager;
use Doctrine\ORM\UnitOfWork;
use SlayerBirden\DataFlowServer\Authorization\Entities\History;
use SlayerBirden\DataFlowServer\Authorization\Entities\Permission;
use SlayerBirden\DataFlowServer\Authorization\HistoryManagementInterface;

class HistoryManagement implements HistoryManagementInterface
{
    const ACTION_ADD = 'added';
    const ACTION_REMOVE = 'removed';
    const ACTION_UNKNOWN = 'unknown';

    /**
     * @var EntityManager
     */
    private $entityManager;

    public function __construct(EntityManager $entityManager)

You have injected the EntityManager via parameter $entityManager. This is generally not recommended as it might get closed and become unusable. Instead, it is recommended to inject the ManagerRegistry and retrieve the EntityManager via getManager() each time you need it.

    {
        $this->entityManager = $entityManager;
    }

    public function fromPermission(Permission $permission): History
    {
        $state = $this->entityManager->getUnitOfWork()->getEntityState($permission);

        switch ($state) {
            case UnitOfWork::STATE_MANAGED:
                $action = self::ACTION_ADD;
                break;
            case UnitOfWork::STATE_REMOVED:
                $action = self::ACTION_REMOVE;
                break;
            default:
                $action = self::ACTION_UNKNOWN;
        }

        $history = new History();
        $history->setChangeAction($action);
        $history->setPermission($permission);
        $history->setResource($permission->getResource());
        $history->setUser($permission->getUser());
        $history->setAt(new \DateTime());

        return $history;
    }
}