SlayerBirden\DataFlowServer\Authentication\Service\PasswordManager

Complexity

Total Complexity

7

Size/Duplication

Total Lines	58
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	7

Test Coverage

Coverage

25%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
B	isValid()	0	26	4
A	isExpired()	0	4	1
A	getHash()	0	4	1

<?php
declare(strict_types=1);

namespace SlayerBirden\DataFlowServer\Authentication\Service;

use Doctrine\Common\Collections\Criteria;
use Doctrine\ORM\EntityManager;
use Doctrine\ORM\ORMException;
use Psr\Log\LoggerInterface;
use SlayerBirden\DataFlowServer\Authentication\Entities\Password;
use SlayerBirden\DataFlowServer\Authentication\Exception\InvalidCredentialsException;
use SlayerBirden\DataFlowServer\Authentication\Exception\PasswordExpiredException;
use SlayerBirden\DataFlowServer\Authentication\PasswordManagerInterface;
use SlayerBirden\DataFlowServer\Domain\Entities\User;

class PasswordManager implements PasswordManagerInterface
{
    /**
     * @var EntityManager
     */
    private $entityManager;
    /**
     * @var LoggerInterface
     */
    private $logger;

    public function __construct(EntityManager $entityManager, LoggerInterface $logger)

You have injected the EntityManager via parameter $entityManager. This is generally not recommended as it might get closed and become unusable. Instead, it is recommended to inject the ManagerRegistry and retrieve the EntityManager via getManager() each time you need it.

    {
        $this->entityManager = $entityManager;
        $this->logger = $logger;
    }

    public function isValid(string $password, User $user): bool
    {
        try {
            $results = $this->entityManager
                ->getRepository(Password::class)
                ->matching(
                    Criteria::create()
                        ->where(Criteria::expr()->eq('owner', $user))
                        ->andWhere(Criteria::expr()->eq('active', true))
                );
            if ($results->count()) {
                /** @var Password $pw */
                $pw = $results->first();
                if ($this->isExpired($pw)) {
                    throw new PasswordExpiredException('Password is expired.');
                }
                return password_verify($password, $pw->getHash());
            } else {
                throw new InvalidCredentialsException('Invalid login/password combination.');
            }
        } catch (ORMException $exception) {
            $this->logger->error((string)$exception);
        }

        return false;
    }

    /**
     * @param Password $password
     * @return bool
     */
    private function isExpired(Password $password)
    {
        return $password->getDue() < new \DateTime();
    }

    public function getHash(string $password): string
    {
        return password_hash($password, PASSWORD_DEFAULT);
    }
}