SlayerBirden\DataFlowServer\Domain\Controller\GetUsersAction

Complexity

Total Complexity

9

Size/Duplication

Total Lines	90
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	9

Test Coverage

Coverage

100%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	9	1
B	process()	0	44	4
A	buildCriteria()	0	16	4

<?php
declare(strict_types=1);

namespace SlayerBirden\DataFlowServer\Domain\Controller;

use Doctrine\Common\Collections\Collection;
use Doctrine\Common\Collections\Criteria;
use Doctrine\ORM\EntityManagerInterface;
use Doctrine\ORM\ORMException;
use Psr\Http\Server\MiddlewareInterface;
use SlayerBirden\DataFlowServer\Domain\Entities\User;
use SlayerBirden\DataFlowServer\Notification\DangerMessage;
use Psr\Http\Message\ResponseInterface;
use Psr\Http\Message\ServerRequestInterface;
use Psr\Http\Server\RequestHandlerInterface;
use Psr\Log\LoggerInterface;
use Zend\Diactoros\Response\JsonResponse;
use Zend\Hydrator\ExtractionInterface;

class GetUsersAction implements MiddlewareInterface
{
    /**
     * @var EntityManagerInterface
     */
    private $entityManager;
    /**
     * @var LoggerInterface
     */
    private $logger;
    /**
     * @var ExtractionInterface
     */
    private $extraction;

    public function __construct(
        EntityManagerInterface $entityManager,
        LoggerInterface $logger,
        ExtractionInterface $extraction
    ) {
        $this->entityManager = $entityManager;
        $this->logger = $logger;
        $this->extraction = $extraction;
    }

    /**
     * @inheritdoc
     */
    public function process(ServerRequestInterface $request, RequestHandlerInterface $handler): ResponseInterface
    {
        $data = $request->getQueryParams();
        $page = isset($data['p']) ? abs($data['p']) : null;
        $filters = $data['f'] ?? [];
        $sorting = $data['s'] ?? [];
        $success = false;
        $msg = '';
        $status = 200;

        try {
            $criteria = $this->buildCriteria($filters, $sorting, $page);

            /** @var Collection $users */
            $users = $this->entityManager
                ->getRepository(User::class)
                ->matching($criteria);
            // before collection load to count all records without pagination
            $count = $users->count();

            if ($count > 0) {
                $arrayUsers = array_map(function ($user) {
                    return $this->extraction->extract($user);
                }, $users->toArray());
                $success = true;
            } else {
                $msg = new DangerMessage('Could not find users using given conditions.');
                $status = 404;
            }
        } catch (ORMException $exception) {
            $this->logger->error((string)$exception);
            $msg = new DangerMessage('Could not fetch users.');
            $status = 400;
        }

        return new JsonResponse([
            'data' => [
                'users' => $arrayUsers ?? [],
                'count' => $count ?? 0,
            ],
            'success' => $success,
            'msg' => $msg,
        ], $status);
    }

    private function buildCriteria(array $filters = [], array $sorting = [], ?int $page, int $limit = 10): Criteria

Parameters which have default values should be placed at the end.

    {
        $criteria = Criteria::create();
        if ($page !== null) {
            $criteria->setFirstResult(($page - 1) * $limit)
                ->setMaxResults($limit);
        }
        foreach ($filters as $key => $value) {
            $criteria->andWhere(Criteria::expr()->contains($key, $value));
        }
        if ($sorting) {

The expression $sorting of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            $criteria->orderBy($sorting);
        }

        return $criteria;
    }
}