SlayerBirden\DataFlowServer\Db\Controller\AddConfigAction

Complexity

Total Complexity

8

Size/Duplication

Total Lines	107
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	13

Test Coverage

Coverage

80.85%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	13	1
B	process()	0	54	6
A	getConfiguration()	0	7	1

<?php
declare(strict_types=1);

namespace SlayerBirden\DataFlowServer\Db\Controller;

use Doctrine\ORM\EntityManagerInterface;
use Doctrine\ORM\ORMException;
use Doctrine\ORM\ORMInvalidArgumentException;
use Psr\Http\Message\ResponseInterface;
use Psr\Http\Message\ServerRequestInterface;
use Psr\Http\Server\MiddlewareInterface;
use Psr\Http\Server\RequestHandlerInterface;
use Psr\Log\LoggerInterface;
use SlayerBirden\DataFlowServer\Db\Entities\DbConfiguration;
use SlayerBirden\DataFlowServer\Domain\Entities\User;
use SlayerBirden\DataFlowServer\Notification\DangerMessage;
use SlayerBirden\DataFlowServer\Notification\SuccessMessage;
use Zend\Diactoros\Response\JsonResponse;
use Zend\Hydrator\ClassMethods;
use Zend\Hydrator\ExtractionInterface;
use Zend\Hydrator\HydratorInterface;
use Zend\InputFilter\InputFilterInterface;

class AddConfigAction implements MiddlewareInterface
{
    /**
     * @var EntityManagerInterface
     */
    private $entityManager;
    /**
     * @var ClassMethods
     */
    private $hydrator;
    /**
     * @var InputFilterInterface
     */
    private $inputFilter;
    /**
     * @var LoggerInterface
     */
    private $logger;
    /**
     * @var ExtractionInterface
     */
    private $extractor;

    public function __construct(
        EntityManagerInterface $entityManager,
        HydratorInterface $hydrator,
        InputFilterInterface $inputFilter,
        LoggerInterface $logger,
        ExtractionInterface $extractor
    ) {
        $this->entityManager = $entityManager;
        $this->hydrator = $hydrator;

$hydrator is of type object<Zend\Hydrator\HydratorInterface>, but the property $hydrator was declared to be of type object<Zend\Hydrator\ClassMethods>. Are you sure that you always receive this specific sub-class here, or does it make sense to add an instanceof check?

        $this->inputFilter = $inputFilter;
        $this->logger = $logger;
        $this->extractor = $extractor;
    }

    /**
     * @inheritdoc
     */
    public function process(ServerRequestInterface $request, RequestHandlerInterface $handler): ResponseInterface
    {
        $data = $request->getParsedBody();

        // todo get owner
        #### get current user
        $user = $this->entityManager
            ->getRepository(User::class)
            ->find(1);
        $data['owner'] = $user;
        ###

        $this->inputFilter->setData($data);

It seems like $data defined by $request->getParsedBody() on line 66 can also be of type object; however, Zend\InputFilter\InputFilterInterface::setData() does only seem to accept array|object<Traversable>, maybe add an additional type check?

        $message = null;
        $validation = [];
        $created = false;
        $status = 200;

        if ($this->inputFilter->isValid()) {
            try {
                $config = $this->getConfiguration($data);

It seems like $data defined by $request->getParsedBody() on line 66 can also be of type object; however, SlayerBirden\DataFlowServer\Db\Controller\AddConfigAction::getConfiguration() does only seem to accept array, maybe add an additional type check?

                $this->entityManager->persist($config);
                $this->entityManager->flush();
                $message = new SuccessMessage('Configuration has been successfully created!');
                $created = true;
            } catch (ORMInvalidArgumentException $exception) {
                $message = new DangerMessage($exception->getMessage());
                $status = 400;
            } catch (ORMException $exception) {
                $this->logger->error((string)$exception);
                $message = new DangerMessage('Error during creation operation.');
                $status = 400;
            }
        } else {
            foreach ($this->inputFilter->getInvalidInput() as $key => $input) {
                $message = new DangerMessage('There were validation errors.');
                $validation[] = [
                    'field' => $key,
                    'msg' => reset($input->getMessages())

$input->getMessages() cannot be passed to reset() as the parameter $array expects a reference.

                ];
            }
            $status = 400;
        }

        return new JsonResponse([
            'msg' => $message,
            'success' => $created,
            'data' => [
                'validation' => $validation,
                'configuration' => !empty($config) ? $this->extractor->extract($config) : null,
            ]
        ], $status);
    }

    /**
     * @param array $data
     * @return DbConfiguration
     */
    private function getConfiguration(array $data): DbConfiguration
    {
        $config = new DbConfiguration();
        $this->hydrator->hydrate($data, $config);

        return $config;
    }
}