Skwoat / ramverk-kmom10

src/Home/HomeModel.php

<?php

namespace Seb\Home;

/**
 * A sample controller to show how a controller class can be implemented.
 */
class HomeModel
{

    /**
     * Show all items.
     *
     * @return object as a response object
     */
    public function recentTopics($topics)
    {
        $arrayRes = [];
        foreach (array_reverse($topics) as $q) {
            if (count($topics)-3 < $q->id) {
                array_push($arrayRes, $q->topic);
            }
        }
        return $arrayRes;
    }

    /**
     * Show all items.
     *
     * @return object as a response object
     */
    public function topUsers($users)
    {
        $arrayRes = [];
        $array = [];

The assignment to $array is dead and can be removed.

        foreach ($users as $u) {
            $arrayRes[$u->acronym] = $u->score;
        }
        arsort($arrayRes);
        $array = array_slice($arrayRes, 0, 3);
        return $array;

The expression return $array returns the type array which is incompatible with the documented return type object.

    }

    /**
     * Show all items.
     *
     * @return object as a response object
     */
    public function topTags($tags, $questions)
    {
        $arrayRes = [];
        $tagFrequency = 0;

The assignment to $tagFrequency is dead and can be removed.

        foreach ($tags as $tag) {
            $tagFrequency = 0;
            foreach ($questions as $q) {
                if ($tag->tag == $q->tag1 || $tag->tag == $q->tag2 || $tag->tag == $q->tag3) {
                    $tagFrequency += 1;
                }
            }
            if ($tagFrequency == !0) {
                $arrayRes[$tag->tag] = $tagFrequency;
            }
        }
        arsort($arrayRes);
        $arrayRes = array_slice($arrayRes, 0, 3);
        return $arrayRes;

The expression return $arrayRes returns the type array which is incompatible with the documented return type object.

    }
}