Conditions | 1 |
Paths | 1 |
Total Lines | 86 |
Code Lines | 61 |
Lines | 0 |
Ratio | 0 % |
Changes | 1 | ||
Bugs | 1 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
20 | public function update_data() |
||
21 | { |
||
22 | return array( |
||
23 | // Global Settings |
||
24 | array('config.add', array('ppde_enable', false)), |
||
25 | array('config.add', array('ppde_header_link', false)), |
||
26 | array('config.add', array('ppde_account_id', '')), |
||
27 | array('config.add', array('ppde_default_currency', 1)), |
||
28 | array('config.add', array('ppde_default_value', 0)), |
||
29 | array('config.add', array('ppde_dropbox_enable', false)), |
||
30 | array('config.add', array('ppde_dropbox_value', '1,2,3,4,5,10,20,25,50,100')), |
||
31 | |||
32 | // IPN Settings |
||
33 | array('config.add', array('ppde_ipn_enable', false)), |
||
34 | array('config.add', array('ppde_ipn_autogroup_enable', false)), |
||
35 | array('config.add', array('ppde_ipn_donorlist_enable', false)), |
||
36 | array('config.add', array('ppde_ipn_group_id', 2)), |
||
37 | array('config.add', array('ppde_ipn_group_as_default', false)), |
||
38 | array('config.add', array('ppde_ipn_balance', 0)), |
||
39 | array('config.add', array('ppde_ipn_logging', false)), |
||
40 | array('config.add', array('ppde_ipn_notification_enable', false)), |
||
41 | array('config.add', array('ppde_curl_detected', false)), |
||
42 | array('config.add', array('ppde_curl_version', '')), |
||
43 | array('config.add', array('ppde_curl_ssl_version', '')), |
||
44 | array('config.add', array('ppde_fsock_detected', false)), |
||
45 | |||
46 | // Sandbox Settings |
||
47 | array('config.add', array('ppde_sandbox_enable', false)), |
||
48 | array('config.add', array('ppde_sandbox_founder_enable', true)), |
||
49 | array('config.add', array('ppde_sandbox_address', '')), |
||
50 | |||
51 | // Statistics Settings |
||
52 | array('config.add', array('ppde_stats_index_enable', false)), |
||
53 | array('config.add', array('ppde_goal', 0)), |
||
54 | array('config.add', array('ppde_goal_enable', false)), |
||
55 | array('config.add', array('ppde_raised', 0)), |
||
56 | array('config.add', array('ppde_raised_ipn', 0)), |
||
57 | array('config.add', array('ppde_raised_enable', false)), |
||
58 | array('config.add', array('ppde_used', 0)), |
||
59 | array('config.add', array('ppde_used_enable', false)), |
||
60 | |||
61 | // Overview Settings |
||
62 | array('config.add', array('ppde_anonymous_donors_count', 0)), |
||
63 | array('config.add', array('ppde_anonymous_donors_count_ipn', 0)), |
||
64 | array('config.add', array('ppde_known_donors_count', 0)), |
||
65 | array('config.add', array('ppde_known_donors_count_ipn', 0)), |
||
66 | array('config.add', array('ppde_transactions_count', 0)), |
||
67 | array('config.add', array('ppde_transactions_count_ipn', 0)), |
||
68 | |||
69 | //Misc Settings |
||
70 | array('config.add', array('ppde_install_date', time())), |
||
71 | array('config.add', array('ppde_first_start', true)), |
||
72 | |||
73 | // add new permissions |
||
74 | array('permission.add', array('a_ppde_manage', true)), |
||
75 | array('permission.add', array('u_ppde_use', true)), |
||
76 | array('permission.add', array('u_ppde_view_donorlist', true)), |
||
77 | |||
78 | //assign permissions to roles |
||
79 | array('permission.permission_set', array('ROLE_ADMIN_FULL', array('a_ppde_manage'))), |
||
80 | array('permission.permission_set', array('ROLE_USER_FULL', array('u_ppde_use'))), |
||
81 | array('permission.permission_set', array('ROLE_USER_FULL', array('u_ppde_view_donorlist'))), |
||
82 | |||
83 | // add new module |
||
84 | array('module.add', array( |
||
85 | 'acp', |
||
86 | 'ACP_CAT_DOT_MODS', |
||
87 | 'PPDE_ACP_DONATION', |
||
88 | array( |
||
89 | 'module_enabled' => 1, |
||
90 | 'module_display' => 1, |
||
91 | 'module_langname' => 'PPDE_ACP_DONATION', |
||
92 | 'module_auth' => 'ext_skouat/ppde && acl_a_ppde_manage', |
||
93 | ) |
||
94 | )), |
||
95 | |||
96 | array('module.add', array( |
||
97 | 'acp', |
||
98 | 'PPDE_ACP_DONATION', |
||
99 | array( |
||
100 | 'module_basename' => '\skouat\ppde\acp\ppde_module', |
||
101 | 'modes' => array('overview', 'settings', 'donation_pages', 'currency', 'transactions'), |
||
102 | ) |
||
103 | )), |
||
104 | ); |
||
105 | } |
||
106 | } |
||
107 |