Skouat / ext_paypal_donation

controller/admin_overview_controller.php

Spacing +4 added lines, -4 removed lines

@@ -100,8 +100,8 @@ 
 			'S_CURL'                    => $this->config['ppde_curl_detected'],
 			'S_FSOCKOPEN'               => $this->config['ppde_fsock_detected'],
 
-			'U_PPDE_MORE_INFORMATION'   => append_sid("index.$this->php_ext", 'i=acp_extensions&mode=main&action=details&ext_name=' . urlencode($this->ext_meta['name'])),
-			'U_PPDE_VERSIONCHECK_FORCE' => $this->u_action . '&versioncheck_force=1',
+			'U_PPDE_MORE_INFORMATION'   => append_sid("index.$this->php_ext", 'i=acp_extensions&mode=main&action=details&ext_name='.urlencode($this->ext_meta['name'])),
+			'U_PPDE_VERSIONCHECK_FORCE' => $this->u_action.'&versioncheck_force=1',
 			'U_ACTION'                  => $this->u_action,
 		));
 	}
@@ -152,7 +152,7 @@ 
 			case 'donors':
 			case 'transactions':
 				$confirm = true;
-				$confirm_lang = 'STAT_RESYNC_' . strtoupper($action) . 'COUNTS_CONFIRM';
+				$confirm_lang = 'STAT_RESYNC_'.strtoupper($action).'COUNTS_CONFIRM';
 				break;
 			default:
 				$confirm = true;
@@ -177,7 +177,7 @@ 
 	{
 		if (!$this->auth->acl_get('a_ppde_manage'))
 		{
-			trigger_error($this->user->lang['NO_AUTH_OPERATION'] . adm_back_link($this->u_action), E_USER_WARNING);
+			trigger_error($this->user->lang['NO_AUTH_OPERATION'].adm_back_link($this->u_action), E_USER_WARNING);
 		}
 
 		switch ($action)

controller/admin_transactions_controller.php

Spacing +21 added lines, -21 removed lines

@@ -70,7 +70,7 @@ 
 		$this->template = $template;
 		$this->user = $user;
 		$this->adm_relative_path = $adm_relative_path;
-		$this->phpbb_admin_path = $phpbb_root_path . $adm_relative_path;
+		$this->phpbb_admin_path = $phpbb_root_path.$adm_relative_path;
 		$this->phpbb_root_path = $phpbb_root_path;
 		$this->php_ext = $php_ext;
 		$this->table_ppde_transactions = $table_ppde_transactions;
@@ -127,7 +127,7 @@ 
 					$this->config->set('ppde_anonymous_donors_count', $this->sql_query_update_stats('ppde_anonymous_donors_count'));
 					$this->config->set('ppde_transactions_count', $this->sql_query_update_stats('ppde_transactions_count'), true);
 
-					$this->log->add('admin', $this->user->data['user_id'], $this->user->ip, 'LOG_' . $this->lang_key_prefix . '_PURGED', time());
+					$this->log->add('admin', $this->user->data['user_id'], $this->user->ip, 'LOG_'.$this->lang_key_prefix.'_PURGED', time());
 				}
 			}
 			else
@@ -164,10 +164,10 @@ 
 
 			// Define where and sort sql for use in displaying transactions
 			$sql_where = ($sort_days) ? (time() - ($sort_days * 86400)) : 0;
-			$sql_sort = $sort_by_sql[$sort_key] . ' ' . (($sort_dir == 'd') ? 'DESC' : 'ASC');
+			$sql_sort = $sort_by_sql[$sort_key].' '.(($sort_dir == 'd') ? 'DESC' : 'ASC');
 
 			$keywords = utf8_normalize_nfc($this->request->variable('keywords', '', true));
-			$keywords_param = !empty($keywords) ? '&keywords=' . urlencode(htmlspecialchars_decode($keywords)) : '';
+			$keywords_param = !empty($keywords) ? '&keywords='.urlencode(htmlspecialchars_decode($keywords)) : '';
 
 			// Grab log data
 			$log_data = array();
@@ -175,7 +175,7 @@ 
 
 			$this->view_txn_log($log_data, $log_count, $this->config['topics_per_page'], $start, $sql_where, $sql_sort, $keywords);
 
-			$base_url = $this->u_action . '&' . $u_sort_param . $keywords_param;
+			$base_url = $this->u_action.'&'.$u_sort_param.$keywords_param;
 			$pagination->generate_template_pagination($base_url, 'pagination', 'start', $log_count, $this->config['topics_per_page'], $start);
 
 			$this->template->assign_vars(array(
@@ -185,7 +185,7 @@ 
 				'S_SORT_KEY'   => $s_sort_key,
 				'S_SORT_DIR'   => $s_sort_dir,
 				'S_TXN'        => $mode,
-				'U_ACTION'     => $this->u_action . '&' . $u_sort_param . $keywords_param . '&start=' . $start,
+				'U_ACTION'     => $this->u_action.'&'.$u_sort_param.$keywords_param.'&start='.$start,
 			));
 
 			foreach ($log_data as $row)
@@ -249,14 +249,14 @@ 
 				return $sql;
 			case 'ppde_known_donors_count':
 				$sql = $this->make_stats_sql_select('payer_id');
-				$sql .= ' LEFT JOIN ' . USERS_TABLE . ' u
+				$sql .= ' LEFT JOIN '.USERS_TABLE.' u
 				 					ON txn.user_id = u.user_id
-								WHERE u.user_type = ' . USER_NORMAL . ' OR u.user_type = ' . USER_FOUNDER;
+								WHERE u.user_type = ' . USER_NORMAL.' OR u.user_type = '.USER_FOUNDER;
 
 				return $sql;
 			case 'ppde_anonymous_donors_count':
 				$sql = $this->make_stats_sql_select('payer_id');
-				$sql .= ' WHERE txn.user_id = ' . ANONYMOUS;
+				$sql .= ' WHERE txn.user_id = '.ANONYMOUS;
 
 				return $sql;
 			default:
@@ -274,8 +274,8 @@ 
 	 */
 	private function make_stats_sql_select($field_name)
 	{
-		return 'SELECT COUNT(DISTINCT txn.' . $field_name . ') AS count_result
-				FROM ' . $this->table_ppde_transactions . ' txn';
+		return 'SELECT COUNT(DISTINCT txn.'.$field_name.') AS count_result
+				FROM ' . $this->table_ppde_transactions.' txn';
 	}
 
 	/**
@@ -311,14 +311,14 @@ 
 
 				$this->template->assign_vars(array(
 					'BOARD_USERNAME' => $data['username'],
-					'EXCHANGE_RATE'  => '1 ' . $data['mc_currency'] . ' = ' . $data['exchange_rate'] . ' ' . $data['settle_currency'],
+					'EXCHANGE_RATE'  => '1 '.$data['mc_currency'].' = '.$data['exchange_rate'].' '.$data['settle_currency'],
 					'ITEM_NAME'      => $data['item_name'],
 					'ITEM_NUMBER'    => $data['item_number'],
-					'MC_CURRENCY'    => $data['net_amount'] . ' ' . $data['mc_currency'],
-					'MC_GROSS'       => $data['mc_gross'] . ' ' . $data['mc_currency'],
-					'MC_FEE'         => '-' . $data['mc_fee'] . ' ' . $data['mc_currency'],
-					'MC_NET'         => $data['net_amount'] . ' ' . $data['mc_currency'],
-					'NAME'           => $data['first_name'] . ' ' . $data['last_name'],
+					'MC_CURRENCY'    => $data['net_amount'].' '.$data['mc_currency'],
+					'MC_GROSS'       => $data['mc_gross'].' '.$data['mc_currency'],
+					'MC_FEE'         => '-'.$data['mc_fee'].' '.$data['mc_currency'],
+					'MC_NET'         => $data['net_amount'].' '.$data['mc_currency'],
+					'NAME'           => $data['first_name'].' '.$data['last_name'],
 					'PAYER_EMAIL'    => $data['payer_email'],
 					'PAYER_ID'       => $data['payer_id'],
 					'PAYER_STATUS'   => ($data['payer_status']) ? $this->user->lang['PPDE_DT_VERIFIED'] : $this->user->lang['PPDE_DT_UNVERIFIED'],
@@ -326,7 +326,7 @@ 
 					'PAYMENT_STATUS' => $payment_status_ary[strtolower($data['payment_status'])],
 					'RECEIVER_EMAIL' => $data['receiver_email'],
 					'RECEIVER_ID'    => $data['receiver_id'],
-					'SETTLE_AMOUNT'  => $data['settle_amount'] . ' ' . $data['settle_currency'],
+					'SETTLE_AMOUNT'  => $data['settle_amount'].' '.$data['settle_currency'],
 					'TXN_ID'         => $data['txn_id'],
 
 					'L_PPDE_DT_SETTLE_AMOUNT'         => $this->user->lang('PPDE_DT_SETTLE_AMOUNT', $data['settle_currency']),
@@ -388,13 +388,13 @@ 
 
 		if ($this->get_container_entity()->is_in_admin() && $this->phpbb_admin_path)
 		{
-			$url_ary['profile_url'] = append_sid($this->phpbb_admin_path . 'index.' . $this->php_ext, 'i=users&mode=overview');
-			$url_ary['txn_url'] = append_sid($this->phpbb_admin_path . 'index.' . $this->php_ext, 'i=-skouat-ppde-acp-ppde_module&mode=transactions');
+			$url_ary['profile_url'] = append_sid($this->phpbb_admin_path.'index.'.$this->php_ext, 'i=users&mode=overview');
+			$url_ary['txn_url'] = append_sid($this->phpbb_admin_path.'index.'.$this->php_ext, 'i=-skouat-ppde-acp-ppde_module&mode=transactions');
 
 		}
 		else
 		{
-			$url_ary['profile_url'] = append_sid($this->phpbb_root_path . 'memberlist.' . $this->php_ext, 'mode=viewprofile');
+			$url_ary['profile_url'] = append_sid($this->phpbb_root_path.'memberlist.'.$this->php_ext, 'mode=viewprofile');
 			$url_ary['txn_url'] = '';
 		}
 

controller/ipn_listener.php

Spacing +18 added lines, -18 removed lines

@@ -263,14 +263,14 @@ 
 			foreach ($args as $key => $value)
 			{
 				$value = urlencode($value);
-				$message .= $key . ' = ' . $value . ";\n";
+				$message .= $key.' = '.$value.";\n";
 			}
 			unset($value);
 		}
 
 		if ($log_in_file)
 		{
-			error_log(sprintf('[%s] %s %s', $error_timestamp, $message, $backtrace), 3, $this->root_path . 'store/ppde_transactions.log');
+			error_log(sprintf('[%s] %s %s', $error_timestamp, $message, $backtrace), 3, $this->root_path.'store/ppde_transactions.log');
 		}
 
 		if ($exit)
@@ -489,13 +489,13 @@ 
 		foreach ($this->get_post_data() as $key => $value)
 		{
 			$encoded = urlencode(stripslashes($value));
-			$values[] = $key . '=' . $encoded;
+			$values[] = $key.'='.$encoded;
 
 			$this->transaction_data[$key] = $value;
 		}
 
 		// implode the array into a string URI
-		$this->args_return_uri .= '&' . implode('&', $values);
+		$this->args_return_uri .= '&'.implode('&', $values);
 	}
 
 	/**
@@ -556,7 +556,7 @@ 
 		if (curl_errno($ch) != 0)
 		{
 			// cURL error
-			$this->log_error($this->user->lang['CURL_ERROR'] . curl_errno($ch) . ' (' . curl_error($ch) . ')', $this->use_log_error);
+			$this->log_error($this->user->lang['CURL_ERROR'].curl_errno($ch).' ('.curl_error($ch).')', $this->use_log_error);
 			curl_close($ch);
 		}
 		else
@@ -593,20 +593,20 @@ 
 		// post back to PayPal system to validate
 		$header = "POST /cgi-bin/webscr HTTP/1.1\r\n";
 		$header .= "Content-Type: application/x-www-form-urlencoded\r\n";
-		$header .= 'Host: ' . $parse_url['host'] . "\r\n";
-		$header .= 'Content-Length: ' . strlen($encoded_data) . "\r\n";
+		$header .= 'Host: '.$parse_url['host']."\r\n";
+		$header .= 'Content-Length: '.strlen($encoded_data)."\r\n";
 		$header .= "Connection: Close\r\n\r\n";
 
-		$fp = fsockopen('ssl://' . $parse_url['host'], 443, $errno, $errstr, $this->timeout);
+		$fp = fsockopen('ssl://'.$parse_url['host'], 443, $errno, $errstr, $this->timeout);
 
 		if (!$fp)
 		{
-			$this->log_error($this->user->lang['FSOCK_ERROR'] . $errno . ' (' . $errstr . ')', $this->use_log_error);
+			$this->log_error($this->user->lang['FSOCK_ERROR'].$errno.' ('.$errstr.')', $this->use_log_error);
 		}
 		else
 		{
 			// Send the data to PayPal
-			fputs($fp, $header . $encoded_data);
+			fputs($fp, $header.$encoded_data);
 
 			// Loop through the response
 			while (!feof($fp))
@@ -641,17 +641,17 @@ 
 		if ($this->txn_is_verified())
 		{
 			$this->verified = $this->transaction_data['confirmed'] = true;
-			$this->log_error("DEBUG VERIFIED:\n" . $this->get_text_report(), $this->use_log_error);
+			$this->log_error("DEBUG VERIFIED:\n".$this->get_text_report(), $this->use_log_error);
 		}
 		else if ($this->txn_is_invalid())
 		{
 			$this->verified = $this->transaction_data['confirmed'] = false;
-			$this->log_error("DEBUG INVALID:\n" . $this->get_text_report(), $this->use_log_error, true);
+			$this->log_error("DEBUG INVALID:\n".$this->get_text_report(), $this->use_log_error, true);
 		}
 		else
 		{
 			$this->verified = $this->transaction_data['confirmed'] = false;
-			$this->log_error("DEBUG OTHER:\n" . $this->get_text_report(), $this->use_log_error);
+			$this->log_error("DEBUG OTHER:\n".$this->get_text_report(), $this->use_log_error);
 			$this->log_error($this->user->lang['UNEXPECTED_RESPONSE'], $this->use_log_error, true);
 		}
 
@@ -711,12 +711,12 @@ 
 
 		// Date and POST url
 		$this->text_report_insert_line($r);
-		$r .= "\n[" . date('m/d/Y g:i A') . '] - ' . $this->u_paypal . ' ( ' . $this->get_curl_fsock() . " )\n";
+		$r .= "\n[".date('m/d/Y g:i A').'] - '.$this->u_paypal.' ( '.$this->get_curl_fsock()." )\n";
 
 		// HTTP Response
 		$this->text_report_insert_line($r);
-		$r .= "\n" . $this->get_report_response() . "\n";
-		$r .= "\n" . $this->get_response_status() . "\n";
+		$r .= "\n".$this->get_report_response()."\n";
+		$r .= "\n".$this->get_response_status()."\n";
 		$this->text_report_insert_line($r);
 
 		// POST vars
@@ -782,7 +782,7 @@ 
 	{
 		foreach ($this->transaction_data as $key => $value)
 		{
-			$r .= str_pad($key, 25) . $value . "\n";
+			$r .= str_pad($key, 25).$value."\n";
 		}
 	}
 
@@ -953,7 +953,7 @@ 
 		{
 			if (!function_exists('group_user_add'))
 			{
-				include($this->root_path . 'includes/functions_user.' . $this->php_ext);
+				include($this->root_path.'includes/functions_user.'.$this->php_ext);
 			}
 
 			// add the user to the donors group and set as default.