ArrayAccessTrait::offsetGet() - Code Metrics - Inspection of "Moved list methods to traits" - SiroDiaz/DataStructures - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 547e17...d8178d )

by Siro Díaz

created 2017-06-24 15:39 UTC

ArrayAccessTrait::offsetGet() A

↳ Parent: ArrayAccessTrait

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
dl	0
loc	3
rs	10
c	1
b	0
f	0
cc	1
eloc	2
nc	1
nop	1

<?php
/**
 * DataStructures for PHP
 *
 * @link      https://github.com/SiroDiaz/DataStructures
 * @copyright Copyright (c) 2017 Siro Díaz Palazón
 * @license   https://github.com/SiroDiaz/DataStructures/blob/master/README.md (MIT License)
 */
namespace DataStructures\Lists\Traits;

use OutOfBoundsException;

/**
 * ArrayAccessTrait
 *
 * ArrayAccessTrait is a trait that implements the ArrayAccess methods
 * to avoid repeating code in the List hierarchy classes.
 *
 * @author Siro Diaz Palazon <[email protected]>
 */
trait ArrayAccessTrait {
    public function offsetSet($offset, $value) {
        if (is_null($offset)) {
            $offset = $this->size;
class MyClass { }

$x = new MyClass();
$x->foo = true;
            if($this->size === 0) {
                $offset = 0;
            }
            $this->insert($offset, $value);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        } else {
            $this->insert($offset, $value);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        }
    }
    
    public function offsetExists($offset) {
        try {
            return $this->get($offset);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        } catch(OutOfBoundsException $e) {
            return false;
        }
    }

    public function offsetUnset($offset) {
        $this->delete($offset);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    public function offsetGet($offset) {
        return $this->get($offset);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }
}

1			<?php
2			/**
3			* DataStructures for PHP
4			*
5			* @link https://github.com/SiroDiaz/DataStructures
6			* @copyright Copyright (c) 2017 Siro Díaz Palazón
7			* @license https://github.com/SiroDiaz/DataStructures/blob/master/README.md (MIT License)
8			*/
9			namespace DataStructures\Lists\Traits;
10
11			use OutOfBoundsException;
12
13			/**
14			* ArrayAccessTrait
15			*
16			* ArrayAccessTrait is a trait that implements the ArrayAccess methods
17			* to avoid repeating code in the List hierarchy classes.
18			*
19			* @author Siro Diaz Palazon <[email protected]>
20			*/
21			trait ArrayAccessTrait {
22			public function offsetSet($offset, $value) {
23			if (is_null($offset)) {
24			$offset = $this->size;
			1 ignored issue – show Bug introduced 2017-06-24 15:40 UTC by Report Bug Copy Issue Report The property `size` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
25			if($this->size === 0) {
26			$offset = 0;
27			}
28			$this->insert($offset, $value);
			1 ignored issue – show Bug introduced 2017-06-24 15:40 UTC by Report Bug Copy Issue Report It seems like `insert()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
29			} else {
30			$this->insert($offset, $value);
			1 ignored issue – show Bug introduced 2017-06-24 15:40 UTC by Report Bug Copy Issue Report It seems like `insert()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
31			}
32			}
33
34			public function offsetExists($offset) {
35			try {
36			return $this->get($offset);
			1 ignored issue – show Bug introduced 2017-06-24 15:40 UTC by Report Bug Copy Issue Report It seems like `get()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
37			} catch(OutOfBoundsException $e) {
38			return false;
39			}
40			}
41
42			public function offsetUnset($offset) {
43			$this->delete($offset);
			1 ignored issue – show Bug introduced 2017-06-24 15:40 UTC by Report Bug Copy Issue Report It seems like `delete()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
44			}
45
46			public function offsetGet($offset) {
47			return $this->get($offset);
			1 ignored issue – show Bug introduced 2017-06-24 15:40 UTC by Report Bug Copy Issue Report It seems like `get()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
48			}
49			}

SiroDiaz / DataStructures

Push — master ( 547e17...d8178d )

ArrayAccessTrait::offsetGet() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like