QueueTest - Code Metrics - Inspection of "fixed many errors and added psr-4 to test director..." - SiroDiaz/DataStructures - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( d060d7...4b3449 )

by Siro Díaz

created 2017-06-22 21:33 UTC

QueueTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	119
Duplicated Lines	47.9 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

Metric	Value
wmc	9
lcom	1
cbo	2
dl	57
loc	119
c	0
b	0
f	0
rs	10

8 Methods

Rating	Name	Duplication	Size	Complexity
A	testContructMaxSize()	0	4	1
A	testEnqueueWithMaxSize()	13	13	1
A	testEnqueue()	0	10	1
A	testDequeue()	0	14	1
A	testSize()	0	14	1
A	testEmpty()	12	12	1
A	testPeek()	19	19	1
A	testIsFull()	13	13	1

How to fix Duplicated Code

<?php

namespace DataStructures\Tests\Lists;

use DataStructures\Exceptions\FullException;
use DataStructures\Lists\Queue;
use PHPUnit\Framework\TestCase;

class QueueTest extends TestCase {
    private $queue;

    public function testContructMaxSize() {
        $this->expectException(\InvalidArgumentException::class);
        $this->queue = new Queue(-1);
    }

    public function testEnqueueWithMaxSize() {

        $this->queue = new Queue(5);
        $this->queue->enqueue(1);
        $this->assertEquals($this->queue->peek(), 1);
        $this->queue->enqueue(2);
        $this->assertEquals($this->queue->peek(), 1);
        $this->queue->enqueue(3);
        $this->assertEquals($this->queue->peek(), 1);
        $this->queue->enqueue(4);
        $this->queue->enqueue(5);
        $this->expectException(FullException::class);
        $this->queue->enqueue(6);
    }

    public function testEnqueue() {
        $this->queue = new Queue();
        $this->queue->enqueue(1);
        $this->queue->enqueue(2);
        $this->queue->enqueue(3);
        $this->queue->enqueue(4);
        $this->queue->enqueue(5);
        $this->assertEquals($this->queue->size(), 5);
        $this->assertEquals($this->queue->peek(), 1);
    }

    public function testDequeue() {
        $this->queue = new Queue();
        $this->assertNull($this->queue->dequeue());
        $this->queue->enqueue(1);
        $this->queue->enqueue(2);
        $this->queue->enqueue(3);
        $this->queue->enqueue(4);
        $this->queue->enqueue(5);
        $this->assertEquals($this->queue->dequeue(), 1);
        $this->assertEquals($this->queue->dequeue(), 2);
        $this->assertEquals($this->queue->dequeue(), 3);
        $this->assertEquals($this->queue->dequeue(), 4);
        $this->assertEquals($this->queue->dequeue(), 5);
    }

    public function testSize() {
        $this->queue = new Queue();
        $this->assertEquals($this->queue->size(), 0);
        $this->queue->enqueue(1);
        $this->assertEquals($this->queue->size(), 1);
        $this->queue->enqueue(2);
        $this->assertEquals($this->queue->size(), 2);
        $this->queue->enqueue(3);
        $this->assertEquals($this->queue->size(), 3);
        $this->queue->enqueue(4);
        $this->assertEquals($this->queue->size(), 4);
        $this->queue->enqueue(5);
        $this->assertEquals($this->queue->size(), 5);
    }

    public function testEmpty() {

        $this->queue = new Queue();
        $this->assertTrue($this->queue->empty());
        $this->queue->enqueue(true);
        $this->assertFalse($this->queue->empty());
        $this->queue->enqueue("string");
        $this->queue->enqueue(3.14);
        $this->queue->dequeue();
        $this->queue->dequeue();
        $this->queue->dequeue();
        $this->assertTrue($this->queue->empty());
    }

    public function testPeek() {

        $this->queue = new Queue();
        $this->assertNull($this->queue->peek());
        $this->queue->enqueue(1000);
        $this->assertEquals($this->queue->peek(), 1000);
        $this->queue->enqueue(false);
        $this->assertEquals($this->queue->peek(), 1000);
        $this->queue->enqueue(3.14);
        $this->assertEquals($this->queue->peek(), 1000);
        $this->queue->enqueue(4);
        $this->assertEquals($this->queue->dequeue(), 1000);
        $this->assertEquals($this->queue->peek(), false);
        $this->assertEquals($this->queue->dequeue(), false);
        $this->assertEquals($this->queue->peek(), 3.14);
        $this->assertEquals($this->queue->dequeue(), 3.14);
        $this->assertEquals($this->queue->peek(), 4);
        $this->assertEquals($this->queue->dequeue(), 4);
        $this->assertNull($this->queue->peek());
    }

    public function testIsFull() {

        $this->queue = new Queue();
        $this->assertFalse($this->queue->isFull());
        $this->queue->enqueue(['hello']);
        $this->queue->enqueue(false);
        $this->queue->enqueue(['hello']);
        $this->queue->enqueue(false);
        $this->queue->enqueue(['hello']);
        $this->queue->enqueue(false);
        $this->queue->enqueue(['hello']);
        $this->queue->enqueue(false);
        $this->assertFalse($this->queue->isFull());
    }

    public function testIsFullWithMaxSize() {
        $this->queue = new Queue(2);
        $this->queue->enqueue(['hello']);
        $this->queue->enqueue(false);
        $this->assertTrue($this->queue->isFull());
        $this->queue->dequeue();
        $this->assertFalse($this->queue->isFull());
    }
}

1		<?php
2
3		namespace DataStructures\Tests\Lists;
4
5		use DataStructures\Exceptions\FullException;
6		use DataStructures\Lists\Queue;
7		use PHPUnit\Framework\TestCase;
8
9		class QueueTest extends TestCase {
10		private $queue;
11
12		public function testContructMaxSize() {
13		$this->expectException(\InvalidArgumentException::class);
14		$this->queue = new Queue(-1);
15		}
16
17	View Code Duplication	public function testEnqueueWithMaxSize() {
		0 ignored issues – show Duplication introduced 2017-06-05 14:14 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
18		$this->queue = new Queue(5);
19		$this->queue->enqueue(1);
20		$this->assertEquals($this->queue->peek(), 1);
21		$this->queue->enqueue(2);
22		$this->assertEquals($this->queue->peek(), 1);
23		$this->queue->enqueue(3);
24		$this->assertEquals($this->queue->peek(), 1);
25		$this->queue->enqueue(4);
26		$this->queue->enqueue(5);
27		$this->expectException(FullException::class);
28		$this->queue->enqueue(6);
29		}
30
31		public function testEnqueue() {
32		$this->queue = new Queue();
33		$this->queue->enqueue(1);
34		$this->queue->enqueue(2);
35		$this->queue->enqueue(3);
36		$this->queue->enqueue(4);
37		$this->queue->enqueue(5);
38		$this->assertEquals($this->queue->size(), 5);
39		$this->assertEquals($this->queue->peek(), 1);
40		}
41
42		public function testDequeue() {
43		$this->queue = new Queue();
44		$this->assertNull($this->queue->dequeue());
45		$this->queue->enqueue(1);
46		$this->queue->enqueue(2);
47		$this->queue->enqueue(3);
48		$this->queue->enqueue(4);
49		$this->queue->enqueue(5);
50		$this->assertEquals($this->queue->dequeue(), 1);
51		$this->assertEquals($this->queue->dequeue(), 2);
52		$this->assertEquals($this->queue->dequeue(), 3);
53		$this->assertEquals($this->queue->dequeue(), 4);
54		$this->assertEquals($this->queue->dequeue(), 5);
55		}
56
57		public function testSize() {
58		$this->queue = new Queue();
59		$this->assertEquals($this->queue->size(), 0);
60		$this->queue->enqueue(1);
61		$this->assertEquals($this->queue->size(), 1);
62		$this->queue->enqueue(2);
63		$this->assertEquals($this->queue->size(), 2);
64		$this->queue->enqueue(3);
65		$this->assertEquals($this->queue->size(), 3);
66		$this->queue->enqueue(4);
67		$this->assertEquals($this->queue->size(), 4);
68		$this->queue->enqueue(5);
69		$this->assertEquals($this->queue->size(), 5);
70		}
71
72	View Code Duplication	public function testEmpty() {
		0 ignored issues – show Duplication introduced 2017-06-05 14:14 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
73		$this->queue = new Queue();
74		$this->assertTrue($this->queue->empty());
75		$this->queue->enqueue(true);
76		$this->assertFalse($this->queue->empty());
77		$this->queue->enqueue("string");
78		$this->queue->enqueue(3.14);
79		$this->queue->dequeue();
80		$this->queue->dequeue();
81		$this->queue->dequeue();
82		$this->assertTrue($this->queue->empty());
83		}
84
85	View Code Duplication	public function testPeek() {
		0 ignored issues – show Duplication introduced 2017-06-05 14:14 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
86		$this->queue = new Queue();
87		$this->assertNull($this->queue->peek());
88		$this->queue->enqueue(1000);
89		$this->assertEquals($this->queue->peek(), 1000);
90		$this->queue->enqueue(false);
91		$this->assertEquals($this->queue->peek(), 1000);
92		$this->queue->enqueue(3.14);
93		$this->assertEquals($this->queue->peek(), 1000);
94		$this->queue->enqueue(4);
95		$this->assertEquals($this->queue->dequeue(), 1000);
96		$this->assertEquals($this->queue->peek(), false);
97		$this->assertEquals($this->queue->dequeue(), false);
98		$this->assertEquals($this->queue->peek(), 3.14);
99		$this->assertEquals($this->queue->dequeue(), 3.14);
100		$this->assertEquals($this->queue->peek(), 4);
101		$this->assertEquals($this->queue->dequeue(), 4);
102		$this->assertNull($this->queue->peek());
103		}
104
105	View Code Duplication	public function testIsFull() {
		0 ignored issues – show Duplication introduced 2017-06-05 14:14 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
106		$this->queue = new Queue();
107		$this->assertFalse($this->queue->isFull());
108		$this->queue->enqueue(['hello']);
109		$this->queue->enqueue(false);
110		$this->queue->enqueue(['hello']);
111		$this->queue->enqueue(false);
112		$this->queue->enqueue(['hello']);
113		$this->queue->enqueue(false);
114		$this->queue->enqueue(['hello']);
115		$this->queue->enqueue(false);
116		$this->assertFalse($this->queue->isFull());
117		}
118
119		public function testIsFullWithMaxSize() {
120		$this->queue = new Queue(2);
121		$this->queue->enqueue(['hello']);
122		$this->queue->enqueue(false);
123		$this->assertTrue($this->queue->isFull());
124		$this->queue->dequeue();
125		$this->assertFalse($this->queue->isFull());
126		}
127		}

SiroDiaz / DataStructures

Push — master ( d060d7...4b3449 )

QueueTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

8 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like