BinaryTreeAbstract::isRoot() - Code Metrics - Inspection of "intermediate interface for avoid repited code in b..." - SiroDiaz/DataStructures - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( b8dd19...10cc44 )

by Siro Díaz

created 2017-06-09 14:34 UTC

BinaryTreeAbstract::isRoot() A

↳ Parent: BinaryTreeAbstract

Complexity

Conditions	2
Paths	2

Size

Total Lines	3
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	3
rs	10
cc	2
eloc	2
nc	2
nop	1

<?php

namespace DataStructures\Trees;

use DataStructures\Trees\Interfaces\TreeInterface;

abstract class BinaryTreeAbstract implements TreeInterface {
    protected $root;
    protected $size;

    public function search($key) {

        if($this->root === null) {
            return null;
        }

        if($this->root->key === $key) {
            return $this->root->data;
        } else {
            $node = $this->root;
            while($node !== null) {
                if($key < $node->left) {
                    $node = $node->left;
                } else if($key > $node->right) {
                    $node = $node->right;
                } else {
                    return $node->data;
                }
            }
        }

        return null;
    }
    
    public function isLeaf(BinaryTreeNode $node) {
        return ($node !== null && $node->left === null && $node->right === null);
    }

    public function isRoot($node) {
        return $node !== null && $node->parent === null;
    }
}

1		<?php
2
3		namespace DataStructures\Trees;
4
5		use DataStructures\Trees\Interfaces\TreeInterface;
6
7		abstract class BinaryTreeAbstract implements TreeInterface {
8		protected $root;
9		protected $size;
10
11	View Code Duplication	public function search($key) {
		0 ignored issues – show Duplication introduced 2017-06-09 14:36 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
12		if($this->root === null) {
13		return null;
14		}
15
16		if($this->root->key === $key) {
17		return $this->root->data;
18		} else {
19		$node = $this->root;
20		while($node !== null) {
21		if($key < $node->left) {
22		$node = $node->left;
23		} else if($key > $node->right) {
24		$node = $node->right;
25		} else {
26		return $node->data;
27		}
28		}
29		}
30
31		return null;
32		}
33
34		public function isLeaf(BinaryTreeNode $node) {
35		return ($node !== null && $node->left === null && $node->right === null);
36		}
37
38		public function isRoot($node) {
39		return $node !== null && $node->parent === null;
40		}
41		}

SiroDiaz / DataStructures

Push — master ( b8dd19...10cc44 )

BinaryTreeAbstract::isRoot() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like