DoublyLinkedListTest - Code Metrics - Inspection of "More methods implemented in ArrayList and more tes..." - SiroDiaz/DataStructures - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 023774...de379e )

by Siro Díaz

created 2017-06-08 11:37 UTC

DoublyLinkedListTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	221
Duplicated Lines	71.49 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

Metric	Value
wmc	23
lcom	1
cbo	2
dl	158
loc	221
rs	10
c	0
b	0
f	0

19 Methods

Rating	Name	Duplication	Size	Complexity
A	setUp()	0	3	1
A	testSize()	6	6	1
A	testEmpty()	0	3	1
A	testGetLast()	7	7	1
A	testDeleteException()	0	4	1
A	testPush()	15	15	1
A	testInsert()	23	23	1
A	testDelete()	15	15	1
A	testShift()	10	10	1
A	testPop()	16	16	1
A	testPopException()	0	4	1
A	testUnshift()	17	17	1
A	testGet()	12	12	1
A	testGetWithException()	0	4	1
A	testGetOutOfBound()	0	4	1
A	testGetAll()	17	17	3
A	testToArray()	10	10	1
A	testClear()	10	10	1
A	testIterator()	0	19	3

How to fix Duplicated Code

<?php

use DataStructures\Lists\DoublyLinkedList;
use PHPUnit\Framework\TestCase;

class DoublyLinkedListTest extends TestCase {
namespace YourVendor;

class YourClass { }
    private $list;

    public function setUp() {
        $this->list = new DoublyLinkedList();
    }

    public function testSize() {

        $this->assertEquals($this->list->size(), 0);
        $this->list->push(true);
        $this->list->push(2);
        $this->assertEquals($this->list->size(), 2);
    }

    public function testEmpty() {
        $this->assertTrue($this->list->empty());
    }

    public function testPush() {

        $this->list->push(20);
        $this->assertEquals(1, $this->list->size());
        $this->assertEquals(20, $this->list->get(0));
        $this->list->push(true);
        
        $this->assertEquals(2, $this->list->size());
        
        $this->assertTrue($this->list->get(1));
        
        $this->list->push(30);
        $this->assertEquals(20, $this->list->get(0));
        $this->assertEquals(30, $this->list->get(1));
        $this->assertEquals(true, $this->list->get(2));
    }

    public function testGetLast() {

        $this->assertNull($this->list->getLast());
        $this->list->push(true);
        $this->list->push(50);
        $this->list->push("string");
        $this->assertEquals("string", $this->list->getLast());
    }

    public function testInsert() {

        $this->list->insert(0, 100);
        $this->assertEquals(100, $this->list->get(0));
        $this->assertEquals(1, $this->list->size());
        
        $this->list->insert(0, 200);
        $this->assertEquals(2, $this->list->size());
        $this->assertEquals(200, $this->list->get(0));
        $this->assertEquals(100, $this->list->get(1));
        $this->assertEquals(100, $this->list->getLast());
        
        $this->list->insert(1, 300);
        $this->assertEquals(3, $this->list->size());
        $this->assertEquals(200, $this->list->get(0));
        $this->assertEquals(300, $this->list->get(1));
        $this->assertEquals(100, $this->list->get(2));
        $this->list->insert(2, 1000);
        $this->assertEquals(1000, $this->list->get(2));
        $this->assertEquals(100, $this->list->get(3));
        $this->list->insert(6, true);
        $this->assertTrue($this->list->get(4));
        $this->assertEquals(5, $this->list->size());
    }
    
    public function testDeleteException() {
        $this->expectException(OutOfBoundsException::class);
        $this->list->delete(10);
    }
    
    public function testDelete() {

        $this->list->push(20);
        $this->list->push(true);
        $this->list->push(15);
        $this->list->push(3.14);
        $this->list->push("string");
        
        $this->assertEquals($this->list->delete(4), "string");
        $this->assertEquals(3.14, $this->list->delete(3));
        
        $this->assertEquals(3, $this->list->size());
        $this->assertEquals(true, $this->list->delete(1));
        $this->assertEquals(false, $this->list->empty());
        $this->assertEquals(20, $this->list->delete(0));
    }
    
    public function testShift() {

        $this->assertNull($this->list->shift());
        $this->list->push(20);
        $this->list->push(true);
        $this->assertEquals(20, $this->list->shift());
        $this->assertEquals(1, $this->list->size());
        $this->assertEquals(true, $this->list->shift());
        $this->assertEquals(true, $this->list->empty());
        $this->assertNull($this->list->shift());
    }
    
    public function testPop() {

        $this->list->push(20);
        $this->list->push(true);
        $this->list->push(15);
        $this->list->push(3.14);
        $this->list->push("string");
        
        $this->assertEquals($this->list->pop(), "string");
        $this->assertEquals(3.14, $this->list->pop());
        $this->list->insert(1, ['hello']);
        $this->assertEquals(15, $this->list->pop());
        $this->assertTrue($this->list->pop());
        $this->assertSame($this->list->pop(), ['hello']);
        $this->assertSame($this->list->pop(), 20);
        $this->assertTrue($this->list->empty());
    }
    
    public function testPopException() {
        $this->expectException(OutOfBoundsException::class);
        $this->list->pop();
    }
    
    public function testUnshift() {

        $this->list->unshift(999);
        $this->assertEquals(1, $this->list->size());
        $this->assertEquals(999, $this->list->get(0));
        $this->assertEquals($this->list->getLast(), 999);
        $this->list->unshift(888);
        $this->assertEquals(2, $this->list->size());
        $this->assertEquals(888, $this->list->get(0));
        $this->assertEquals(999, $this->list->get(1));
        $this->assertEquals($this->list->getLast(), 999);
        $this->list->unshift(777);
        $this->assertEquals(3, $this->list->size());
        $this->assertEquals(777, $this->list->get(0));
        $this->assertEquals(888, $this->list->get(1));
        $this->assertEquals(999, $this->list->get(2));
        $this->assertEquals($this->list->getLast(), 999);
    }
    
    public function testGet() {

        $this->list->push(20);
        $this->list->push(true);
        $this->list->push(15);
        $this->list->push(3.14);
        $this->list->push("string");
        $this->assertEquals($this->list->get(0), 20);
        $this->assertTrue($this->list->get(1));
        $this->assertEquals($this->list->get(2), 15);
        $this->assertEquals($this->list->get(3), 3.14);
        $this->assertEquals($this->list->get(4), "string");
    }
    
    public function testGetWithException() {
        $this->expectException(OutOfBoundsException::class);
        $this->list->get(5);
    }

    public function testGetOutOfBound() {
        $this->expectException(OutOfBoundsException::class);
        $this->list->get(-1);
    }
    
    public function testGetAll() {

        foreach($this->list->getAll() as $node) {
            $this->assertNull($node);
        }
        
        $this->list->push(20);
        $this->list->push(true);
        $this->list->push(15);
        $this->list->push(3.14);
        $this->list->push("string");
        $data = [];
        foreach($this->list->getAll() as $node) {
            $data[] = $node;
        }
        $this->assertCount(5, $data);
        $this->assertSame([20, true, 15, 3.14, "string"], $data);
    }
    
    public function testToArray() {

        $this->list->push(20);
        $this->list->push(true);
        $this->list->push(15);
        $this->list->push(3.14);
        $this->list->push("string");
        $this->list->pop();
        $nodes = $this->list->toArray();
        $this->assertSame([20, true, 15, 3.14], $nodes);
    }
    
    public function testClear() {

        $this->list->push(20);
        $this->list->push(true);
        $this->list->push(15);
        $this->list->push(3.14);
        $this->list->push("string");
        $this->list->clear();
        $this->assertEmpty($this->list->toArray());
        $this->assertEquals($this->list->size(), 0);
    }

    public function testIterator() {
        $this->list->push(20);
        $this->list->push(true);
        $this->list->push(15);
        $this->list->push(3.14);
        $this->list->push("string");

        $this->list->shift();
        $expectedResult = [];
        $result = [];
        foreach($this->list->getAll() as $node) {
            $expectedResult[] = $node;
        }
        foreach($this->list as $index => $val) {
            $result[] = $val;
        }

        $this->assertSame($expectedResult, $result);
    }
}

1		<?php
2
3		use DataStructures\Lists\DoublyLinkedList;
4		use PHPUnit\Framework\TestCase;
5
6		class DoublyLinkedListTest extends TestCase {
		0 ignored issues – show Coding Style Compatibility introduced 2017-06-05 14:14 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
7		private $list;
8
9		public function setUp() {
10		$this->list = new DoublyLinkedList();
11		}
12
13	View Code Duplication	public function testSize() {
		0 ignored issues – show Duplication introduced 2017-06-05 14:14 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
14		$this->assertEquals($this->list->size(), 0);
15		$this->list->push(true);
16		$this->list->push(2);
17		$this->assertEquals($this->list->size(), 2);
18		}
19
20		public function testEmpty() {
21		$this->assertTrue($this->list->empty());
22		}
23
24	View Code Duplication	public function testPush() {
		0 ignored issues – show Duplication introduced 2017-06-08 11:39 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
25		$this->list->push(20);
26		$this->assertEquals(1, $this->list->size());
27		$this->assertEquals(20, $this->list->get(0));
28		$this->list->push(true);
29
30		$this->assertEquals(2, $this->list->size());
31
32		$this->assertTrue($this->list->get(1));
33
34		$this->list->push(30);
35		$this->assertEquals(20, $this->list->get(0));
36		$this->assertEquals(30, $this->list->get(1));
37		$this->assertEquals(true, $this->list->get(2));
38		}
39
40	View Code Duplication	public function testGetLast() {
		0 ignored issues – show Duplication introduced 2017-06-05 14:14 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
41		$this->assertNull($this->list->getLast());
42		$this->list->push(true);
43		$this->list->push(50);
44		$this->list->push("string");
45		$this->assertEquals("string", $this->list->getLast());
46		}
47
48	View Code Duplication	public function testInsert() {
		0 ignored issues – show Duplication introduced 2017-06-05 14:14 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
49		$this->list->insert(0, 100);
50		$this->assertEquals(100, $this->list->get(0));
51		$this->assertEquals(1, $this->list->size());
52
53		$this->list->insert(0, 200);
54		$this->assertEquals(2, $this->list->size());
55		$this->assertEquals(200, $this->list->get(0));
56		$this->assertEquals(100, $this->list->get(1));
57		$this->assertEquals(100, $this->list->getLast());
58
59		$this->list->insert(1, 300);
60		$this->assertEquals(3, $this->list->size());
61		$this->assertEquals(200, $this->list->get(0));
62		$this->assertEquals(300, $this->list->get(1));
63		$this->assertEquals(100, $this->list->get(2));
64		$this->list->insert(2, 1000);
65		$this->assertEquals(1000, $this->list->get(2));
66		$this->assertEquals(100, $this->list->get(3));
67		$this->list->insert(6, true);
68		$this->assertTrue($this->list->get(4));
69		$this->assertEquals(5, $this->list->size());
70		}
71
72		public function testDeleteException() {
73		$this->expectException(OutOfBoundsException::class);
74		$this->list->delete(10);
75		}
76
77	View Code Duplication	public function testDelete() {
		0 ignored issues – show Duplication introduced 2017-06-08 11:39 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
78		$this->list->push(20);
79		$this->list->push(true);
80		$this->list->push(15);
81		$this->list->push(3.14);
82		$this->list->push("string");
83
84		$this->assertEquals($this->list->delete(4), "string");
85		$this->assertEquals(3.14, $this->list->delete(3));
86
87		$this->assertEquals(3, $this->list->size());
88		$this->assertEquals(true, $this->list->delete(1));
89		$this->assertEquals(false, $this->list->empty());
90		$this->assertEquals(20, $this->list->delete(0));
91		}
92
93	View Code Duplication	public function testShift() {
		0 ignored issues – show Duplication introduced 2017-06-05 14:14 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
94		$this->assertNull($this->list->shift());
95		$this->list->push(20);
96		$this->list->push(true);
97		$this->assertEquals(20, $this->list->shift());
98		$this->assertEquals(1, $this->list->size());
99		$this->assertEquals(true, $this->list->shift());
100		$this->assertEquals(true, $this->list->empty());
101		$this->assertNull($this->list->shift());
102		}
103
104	View Code Duplication	public function testPop() {
		0 ignored issues – show Duplication introduced 2017-06-05 14:14 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
105		$this->list->push(20);
106		$this->list->push(true);
107		$this->list->push(15);
108		$this->list->push(3.14);
109		$this->list->push("string");
110
111		$this->assertEquals($this->list->pop(), "string");
112		$this->assertEquals(3.14, $this->list->pop());
113		$this->list->insert(1, ['hello']);
114		$this->assertEquals(15, $this->list->pop());
115		$this->assertTrue($this->list->pop());
116		$this->assertSame($this->list->pop(), ['hello']);
117		$this->assertSame($this->list->pop(), 20);
118		$this->assertTrue($this->list->empty());
119		}
120
121		public function testPopException() {
122		$this->expectException(OutOfBoundsException::class);
123		$this->list->pop();
124		}
125
126	View Code Duplication	public function testUnshift() {
		0 ignored issues – show Duplication introduced 2017-06-05 14:14 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
127		$this->list->unshift(999);
128		$this->assertEquals(1, $this->list->size());
129		$this->assertEquals(999, $this->list->get(0));
130		$this->assertEquals($this->list->getLast(), 999);
131		$this->list->unshift(888);
132		$this->assertEquals(2, $this->list->size());
133		$this->assertEquals(888, $this->list->get(0));
134		$this->assertEquals(999, $this->list->get(1));
135		$this->assertEquals($this->list->getLast(), 999);
136		$this->list->unshift(777);
137		$this->assertEquals(3, $this->list->size());
138		$this->assertEquals(777, $this->list->get(0));
139		$this->assertEquals(888, $this->list->get(1));
140		$this->assertEquals(999, $this->list->get(2));
141		$this->assertEquals($this->list->getLast(), 999);
142		}
143
144	View Code Duplication	public function testGet() {
		0 ignored issues – show Duplication introduced 2017-06-08 11:39 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
145		$this->list->push(20);
146		$this->list->push(true);
147		$this->list->push(15);
148		$this->list->push(3.14);
149		$this->list->push("string");
150		$this->assertEquals($this->list->get(0), 20);
151		$this->assertTrue($this->list->get(1));
152		$this->assertEquals($this->list->get(2), 15);
153		$this->assertEquals($this->list->get(3), 3.14);
154		$this->assertEquals($this->list->get(4), "string");
155		}
156
157		public function testGetWithException() {
158		$this->expectException(OutOfBoundsException::class);
159		$this->list->get(5);
160		}
161
162		public function testGetOutOfBound() {
163		$this->expectException(OutOfBoundsException::class);
164		$this->list->get(-1);
165		}
166
167	View Code Duplication	public function testGetAll() {
		0 ignored issues – show Duplication introduced 2017-06-05 14:14 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
168		foreach($this->list->getAll() as $node) {
169		$this->assertNull($node);
170		}
171
172		$this->list->push(20);
173		$this->list->push(true);
174		$this->list->push(15);
175		$this->list->push(3.14);
176		$this->list->push("string");
177		$data = [];
178		foreach($this->list->getAll() as $node) {
179		$data[] = $node;
180		}
181		$this->assertCount(5, $data);
182		$this->assertSame([20, true, 15, 3.14, "string"], $data);
183		}
184
185	View Code Duplication	public function testToArray() {
		0 ignored issues – show Duplication introduced 2017-06-05 14:14 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
186		$this->list->push(20);
187		$this->list->push(true);
188		$this->list->push(15);
189		$this->list->push(3.14);
190		$this->list->push("string");
191		$this->list->pop();
192		$nodes = $this->list->toArray();
193		$this->assertSame([20, true, 15, 3.14], $nodes);
194		}
195
196	View Code Duplication	public function testClear() {
		0 ignored issues – show Duplication introduced 2017-06-05 14:14 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
197		$this->list->push(20);
198		$this->list->push(true);
199		$this->list->push(15);
200		$this->list->push(3.14);
201		$this->list->push("string");
202		$this->list->clear();
203		$this->assertEmpty($this->list->toArray());
204		$this->assertEquals($this->list->size(), 0);
205		}
206
207		public function testIterator() {
208		$this->list->push(20);
209		$this->list->push(true);
210		$this->list->push(15);
211		$this->list->push(3.14);
212		$this->list->push("string");
213
214		$this->list->shift();
215		$expectedResult = [];
216		$result = [];
217		foreach($this->list->getAll() as $node) {
218		$expectedResult[] = $node;
219		}
220		foreach($this->list as $index => $val) {
221		$result[] = $val;
222		}
223
224		$this->assertSame($expectedResult, $result);
225		}
226		}

SiroDiaz / DataStructures

Push — master ( 023774...de379e )

DoublyLinkedListTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

19 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like