Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
24 | View Code Duplication | class BinarySearchTree extends BinaryTreeAbstract { |
|
|
|||
25 | |||
26 | public function __construct() { |
||
30 | |||
31 | /** |
||
32 | * Creates a BSTNode. |
||
33 | * |
||
34 | * @param int|string $key the key used to store. |
||
35 | * @param mixed $data the data. |
||
36 | * @param DataStructures\Trees\Nodes\BSTNode|null $parent the parent node. |
||
37 | * @param DataStructures\Trees\Nodes\BSTNode|null $left the left child node. |
||
38 | * @param DataStructures\Trees\Nodes\BSTNode|null $right the right child node. |
||
39 | * |
||
40 | * @return DataStructures\Trees\Nodes\BSTNode the new node created. |
||
41 | */ |
||
42 | public function createNode($key, $data, $parent = null, $left = null, $right = null) { |
||
45 | } |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.