Issues in SubscribersCollection.php (master) - Issues in master - SirSova/laravel-webhooks - Measure and Improve Code Quality continuously with Scrutinizer

Issues (2)

src/Subscribers/SubscribersCollection.php (1 issue)

Labels

Bug 1

Severity

Major 1

<?php


namespace SirSova\Webhooks\Subscribers;

use Illuminate\Support\Collection;
use SirSova\Webhooks\Contracts\Subscriber;
.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php

/**
 * @property Subscriber|DatabaseSubscriber[] $items
 */
class SubscribersCollection extends Collection
{
    /**
     * @return SubscribersCollection
     */
    public function getUrls(): self
    {
        return $this->map(function (Subscriber $subscriber) {
            return $subscriber->url();
        });
    }

    /**
     * @param string $eventName
     *
     * @return SubscribersCollection
     */
    public function filterByEvent(string $eventName): self
    {
        return $this->filter(function (Subscriber $subscriber) use ($eventName) {
            return $subscriber->event() === $eventName;
        });
    }

    /**
     * @return SubscribersCollection
     */
    public function filterEnabled(): self
    {
        return $this->filter(function (Subscriber $subscriber) {
            return $subscriber->isEnabled();
        });
    }
}


1			<?php
2
3
4			namespace SirSova\Webhooks\Subscribers;
5
6			use Illuminate\Support\Collection;
7			use SirSova\Webhooks\Contracts\Subscriber;
			0 ignored issues – show Bug introduced 2019-07-17 09:36 UTC by Report Bug Copy Issue Report Show Similar Issues like this This use statement conflicts with another class in this namespace, `SirSova\Webhooks\Subscribers\Subscriber`. Consider defining an alias. Let?s assume that you have a directory layout like this: . \|-- OtherDir \| \|-- Bar.php \| `-- Foo.php `-- SomeDir `-- Foo.php and let?s assume the following content of `Bar.php`: // Bar.php namespace OtherDir; use SomeDir\Foo; // This now conflicts the class OtherDir\Foo If both files `OtherDir/Foo.php` and `SomeDir/Foo.php` are loaded in the same runtime, you will see a PHP error such as the following: PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php However, as `OtherDir/Foo.php` does not necessarily have to be loaded and the error is only triggered if it is loaded before `OtherDir/Bar.php`, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: // Bar.php namespace OtherDir; use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore. Loading history...
8
9			/**
10			* @property Subscriber\|DatabaseSubscriber[] $items
11			*/
12			class SubscribersCollection extends Collection
13			{
14			/**
15			* @return SubscribersCollection
16			*/
17			public function getUrls(): self
18			{
19			return $this->map(function (Subscriber $subscriber) {
20			return $subscriber->url();
21			});
22			}
23
24			/**
25			* @param string $eventName
26			*
27			* @return SubscribersCollection
28			*/
29			public function filterByEvent(string $eventName): self
30			{
31			return $this->filter(function (Subscriber $subscriber) use ($eventName) {
32			return $subscriber->event() === $eventName;
33			});
34			}
35
36			/**
37			* @return SubscribersCollection
38			*/
39			public function filterEnabled(): self
40			{
41			return $this->filter(function (Subscriber $subscriber) {
42			return $subscriber->isEnabled();
43			});
44			}
45			}
46

SirSova / laravel-webhooks

Issues (2)

src/Subscribers/SubscribersCollection.php (1 issue)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like