Issues in Printpage.template.php (release-2.1) - Issues in release-2.1 - SimpleMachines/SMF2.1 - Measure and Improve Code Quality continuously with Scrutinizer

Issues (1014)

Themes/default/Printpage.template.php (1 issue)

Labels

Bug 1

Severity

Minor 1

<?php
/**
 * Simple Machines Forum (SMF)
 *
 * @package SMF
 * @author Simple Machines https://www.simplemachines.org
 * @copyright 2022 Simple Machines and individual contributors
 * @license https://www.simplemachines.org/about/smf/license.php BSD
 *
 * @version 2.1.0
 */

/**
 * The header. Defines the look and layout of the page as well as a form for choosing print options.
 */
function template_print_above()
{
	global $context, $txt, $modSettings;

	echo '<!DOCTYPE html>
<html', $context['right_to_left'] ? ' dir="rtl"' : '', '>
	<head>
		<meta charset="', $context['character_set'], '">
		<meta name="robots" content="noindex">
		<link rel="canonical" href="', $context['canonical_url'], '">
		<title>', $txt['print_page'], ' - ', $context['topic_subject'], '</title>
		<style>
			body, a {
				color: #000;
				background: #fff;
			}
			body, td, .normaltext {
				font-family: Verdana, arial, helvetica, serif;
				font-size: small;
			}
			h1#title {
				font-size: large;
				font-weight: bold;
			}
			h2#linktree {
				margin: 1em 0 2.5em 0;
				font-size: small;
				font-weight: bold;
			}
			dl#posts {
				width: 90%;
				margin: 0;
				padding: 0;
				list-style: none;
			}
			div.postheader, #poll_data {
				border: solid #000;
				border-width: 1px 0;
				padding: 4px 0;
			}
			div.postbody {
				margin: 1em 0 2em 2em;
			}
			table {
				empty-cells: show;
			}
			blockquote {
				margin: 0 0 8px 0;
				padding: 6px 10px;
				font-size: small;
				border: 1px solid #d6dfe2;
				border-left: 2px solid #aaa;
				border-right: 2px solid #aaa;
			}
			blockquote cite {
				display: block;
				border-bottom: 1px solid #aaa;
				font-size: 0.9em;
			}
			blockquote cite:before {
				color: #aaa;
				font-size: 22px;
				font-style: normal;
				margin-right: 5px;
			}
			code {
				border: 1px solid #000;
				margin: 3px;
				padding: 1px;
				display: block;
			}
			code {
				font: x-small monospace;
			}
			.smalltext, .codeheader {
				font-size: x-small;
			}
			.largetext {
				font-size: large;
			}
			.centertext {
				text-align: center;
			}
			hr {
				height: 1px;
				border: 0;
				color: black;
				background-color: black;
			}
			.voted {
				font-weight: bold;
			}
			#footer {
				font-family: Verdana, sans-serif;
			}
			@media print {
				.print_options {
					display: none;
				}
			}
			@media screen {
				.print_options {
					margin: 1em 0;
				}
			}';

	if (!empty($modSettings['max_image_width']))
		echo '
			.bbc_img {
				max-width: ' . $modSettings['max_image_width'] . 'px;
			}';

	if (!empty($modSettings['max_image_height']))
		echo '
			.bbc_img {
				max-height: ' . $modSettings['max_image_height'] . 'px;
			}';

	echo '
		</style>
	</head>
	<body>';

	template_print_options();

	echo '
		<h1 id="title">', $context['forum_name_html_safe'], '</h1>
		<h2 id="linktree">', $context['category_name'], ' => ', (!empty($context['parent_boards']) ? implode(' => ', $context['parent_boards']) . ' => ' : ''), $context['board_name'], ' => ', $txt['topic_started'], ': ', $context['poster_name'], ' ', $txt['search_on'], ' ', $context['post_time'], '</h2>
		<div id="posts">';
}

/**
 * The main page. This shows the relevant info in a printer-friendly format
 */
function template_main()
{
	global $context, $options, $txt, $scripturl, $topic;

	if (!empty($context['poll']))
	{
		echo '
			<div id="poll_data">', $txt['poll'], '
				<div class="question">', $txt['poll_question'], ': <strong>', $context['poll']['question'], '</strong>';

		$options = 1;
		foreach ($context['poll']['options'] as $option)
			echo '
					<div class="', $option['voted_this'] ? 'voted' : '', '">', $txt['option'], ' ', $options++, ': <strong>', $option['option'], '</strong>
						', $context['allow_poll_view'] ? $txt['votes'] . ': ' . $option['votes'] . '' : '', '
					</div>';

		echo '
			</div>';
	}

	foreach ($context['posts'] as $post)
	{
		echo '
			<div class="postheader">
				', $txt['title'], ': <strong>', $post['subject'], '</strong><br>
				', $txt['post_by'], ': <strong>', $post['member'], '</strong> ', $txt['search_on'], ' <strong>', $post['time'], '</strong>
			</div>
			<div class="postbody">
				', $post['body'];

		// Show attachment images
		if (isset($_GET['images']) && !empty($context['printattach'][$post['id_msg']]))
		{
			echo '
				<hr>';

			foreach ($context['printattach'][$post['id_msg']] as $attach)
				echo '
					<img width="' . $attach['width'] . '" height="' . $attach['height'] . '" src="', $scripturl . '?action=dlattach;topic=' . $topic . '.0;attach=' . $attach['id_attach'] . '" alt="">';
		}

		echo '
			</div><!-- .postbody -->';
	}
}

/**
 * The footer.
 */
function template_print_below()
{
	echo '
		</div><!-- #posts -->';

	template_print_options();

	echo '
		<div id="footer" class="smalltext">', theme_copyright(), '</div>
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
	</body>
</html>';
}

/**
 * Displays the print page options
 */
function template_print_options()
{
	global $scripturl, $topic, $txt;

	$url_text = $scripturl . '?action=printpage;topic=' . $topic . '.0';
	$url_images = $url_text . ';images';

	echo '
		<div class="print_options">';

	// Which option is set, text or text&images
	if (isset($_REQUEST['images']))
		echo '
			<a href="', $url_text, '">', $txt['print_page_text'], '</a> | <strong><a href="', $url_images, '">', $txt['print_page_images'], '</a></strong>';
	else
		echo '
			<strong><a href="', $url_text, '">', $txt['print_page_text'], '</a></strong> | <a href="', $url_images, '">', $txt['print_page_images'], '</a>';

	echo '
		</div><!-- .print_options -->';
}

?>

1			<?php
2			/**
3			* Simple Machines Forum (SMF)
4			*
5			* @package SMF
6			* @author Simple Machines https://www.simplemachines.org
7			* @copyright 2022 Simple Machines and individual contributors
8			* @license https://www.simplemachines.org/about/smf/license.php BSD
9			*
10			* @version 2.1.0
11			*/
12
13			/**
14			* The header. Defines the look and layout of the page as well as a form for choosing print options.
15			*/
16			function template_print_above()
17			{
18			global $context, $txt, $modSettings;
19
20			echo '<!DOCTYPE html>
21			<html', $context['right_to_left'] ? ' dir="rtl"' : '', '>
22			<head>
23			<meta charset="', $context['character_set'], '">
24			<meta name="robots" content="noindex">
25			<link rel="canonical" href="', $context['canonical_url'], '">
26			<title>', $txt['print_page'], ' - ', $context['topic_subject'], '</title>
27			<style>
28			body, a {
29			color: #000;
30			background: #fff;
31			}
32			body, td, .normaltext {
33			font-family: Verdana, arial, helvetica, serif;
34			font-size: small;
35			}
36			h1#title {
37			font-size: large;
38			font-weight: bold;
39			}
40			h2#linktree {
41			margin: 1em 0 2.5em 0;
42			font-size: small;
43			font-weight: bold;
44			}
45			dl#posts {
46			width: 90%;
47			margin: 0;
48			padding: 0;
49			list-style: none;
50			}
51			div.postheader, #poll_data {
52			border: solid #000;
53			border-width: 1px 0;
54			padding: 4px 0;
55			}
56			div.postbody {
57			margin: 1em 0 2em 2em;
58			}
59			table {
60			empty-cells: show;
61			}
62			blockquote {
63			margin: 0 0 8px 0;
64			padding: 6px 10px;
65			font-size: small;
66			border: 1px solid #d6dfe2;
67			border-left: 2px solid #aaa;
68			border-right: 2px solid #aaa;
69			}
70			blockquote cite {
71			display: block;
72			border-bottom: 1px solid #aaa;
73			font-size: 0.9em;
74			}
75			blockquote cite:before {
76			color: #aaa;
77			font-size: 22px;
78			font-style: normal;
79			margin-right: 5px;
80			}
81			code {
82			border: 1px solid #000;
83			margin: 3px;
84			padding: 1px;
85			display: block;
86			}
87			code {
88			font: x-small monospace;
89			}
90			.smalltext, .codeheader {
91			font-size: x-small;
92			}
93			.largetext {
94			font-size: large;
95			}
96			.centertext {
97			text-align: center;
98			}
99			hr {
100			height: 1px;
101			border: 0;
102			color: black;
103			background-color: black;
104			}
105			.voted {
106			font-weight: bold;
107			}
108			#footer {
109			font-family: Verdana, sans-serif;
110			}
111			@media print {
112			.print_options {
113			display: none;
114			}
115			}
116			@media screen {
117			.print_options {
118			margin: 1em 0;
119			}
120			}';
121
122			if (!empty($modSettings['max_image_width']))
123			echo '
124			.bbc_img {
125			max-width: ' . $modSettings['max_image_width'] . 'px;
126			}';
127
128			if (!empty($modSettings['max_image_height']))
129			echo '
130			.bbc_img {
131			max-height: ' . $modSettings['max_image_height'] . 'px;
132			}';
133
134			echo '
135			</style>
136			</head>
137			<body>';
138
139			template_print_options();
140
141			echo '
142			<h1 id="title">', $context['forum_name_html_safe'], '</h1>
143			<h2 id="linktree">', $context['category_name'], ' => ', (!empty($context['parent_boards']) ? implode(' => ', $context['parent_boards']) . ' => ' : ''), $context['board_name'], ' => ', $txt['topic_started'], ': ', $context['poster_name'], ' ', $txt['search_on'], ' ', $context['post_time'], '</h2>
144			<div id="posts">';
145			}
146
147			/**
148			* The main page. This shows the relevant info in a printer-friendly format
149			*/
150			function template_main()
151			{
152			global $context, $options, $txt, $scripturl, $topic;
153
154			if (!empty($context['poll']))
155			{
156			echo '
157			<div id="poll_data">', $txt['poll'], '
158			<div class="question">', $txt['poll_question'], ': <strong>', $context['poll']['question'], '</strong>';
159
160			$options = 1;
161			foreach ($context['poll']['options'] as $option)
162			echo '
163			<div class="', $option['voted_this'] ? 'voted' : '', '">', $txt['option'], ' ', $options++, ': <strong>', $option['option'], '</strong>
164			', $context['allow_poll_view'] ? $txt['votes'] . ': ' . $option['votes'] . '' : '', '
165			</div>';
166
167			echo '
168			</div>';
169			}
170
171			foreach ($context['posts'] as $post)
172			{
173			echo '
174			<div class="postheader">
175			', $txt['title'], ': <strong>', $post['subject'], '</strong><br>
176			', $txt['post_by'], ': <strong>', $post['member'], '</strong> ', $txt['search_on'], ' <strong>', $post['time'], '</strong>
177			</div>
178			<div class="postbody">
179			', $post['body'];
180
181			// Show attachment images
182			if (isset($_GET['images']) && !empty($context['printattach'][$post['id_msg']]))
183			{
184			echo '
185			<hr>';
186
187			foreach ($context['printattach'][$post['id_msg']] as $attach)
188			echo '
189			<img width="' . $attach['width'] . '" height="' . $attach['height'] . '" src="', $scripturl . '?action=dlattach;topic=' . $topic . '.0;attach=' . $attach['id_attach'] . '" alt="">';
190			}
191
192			echo '
193			</div><!-- .postbody -->';
194			}
195			}
196
197			/**
198			* The footer.
199			*/
200			function template_print_below()
201			{
202			echo '
203			</div><!-- #posts -->';
204
205			template_print_options();
206
207			echo '
208			<div id="footer" class="smalltext">', theme_copyright(), '</div>
			0 ignored issues – show Bug introduced 2018-10-21 22:13 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the usage of `theme_copyright()` is correct as it seems to always return `null`. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
209			</body>
210			</html>';
211			}
212
213			/**
214			* Displays the print page options
215			*/
216			function template_print_options()
217			{
218			global $scripturl, $topic, $txt;
219
220			$url_text = $scripturl . '?action=printpage;topic=' . $topic . '.0';
221			$url_images = $url_text . ';images';
222
223			echo '
224			<div class="print_options">';
225
226			// Which option is set, text or text&images
227			if (isset($_REQUEST['images']))
228			echo '
229			<a href="', $url_text, '">', $txt['print_page_text'], '</a> \| <strong><a href="', $url_images, '">', $txt['print_page_images'], '</a></strong>';
230			else
231			echo '
232			<strong><a href="', $url_text, '">', $txt['print_page_text'], '</a></strong> \| <a href="', $url_images, '">', $txt['print_page_images'], '</a>';
233
234			echo '
235			</div><!-- .print_options -->';
236			}
237
238			?>

SimpleMachines / SMF2.1

Issues (1014)

Themes/default/Printpage.template.php (1 issue)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like