Completed
Push — release-2.1 ( 2e000a...6761ab )
by Michael
18s
created
Sources/CacheAPI-xcache.php 1 patch
Braces   +19 added lines, -13 removed lines patch added patch discarded remove patch
@@ -11,8 +11,9 @@  discard block
 block discarded – undo
11 11
  * @version 2.1 Beta 3
12 12
  */
13 13
 
14
-if (!defined('SMF'))
14
+if (!defined('SMF')) {
15 15
 	die('Hacking attempt...');
16
+}
16 17
 
17 18
 /**
18 19
  * Our Cache API class
@@ -46,8 +47,9 @@  discard block
 block discarded – undo
46 47
 
47 48
 		$supported = function_exists('xcache_get') && function_exists('xcache_set') && ini_get('xcache.var_size') > 0;
48 49
 
49
-		if ($test)
50
-			return $supported;
50
+		if ($test) {
51
+					return $supported;
52
+		}
51 53
 		return parent::isSupported() && $supported;
52 54
 	}
53 55
 
@@ -68,10 +70,11 @@  discard block
 block discarded – undo
68 70
 	{
69 71
 		$key = $this->prefix . strtr($key, ':/', '-_');
70 72
 
71
-		if ($value === null)
72
-			return xcache_unset($key);
73
-		else
74
-			return xcache_set($key, $value, $ttl);
73
+		if ($value === null) {
74
+					return xcache_unset($key);
75
+		} else {
76
+					return xcache_set($key, $value, $ttl);
77
+		}
75 78
 	}
76 79
 
77 80
 	/**
@@ -90,10 +93,12 @@  discard block
 block discarded – undo
90 93
 		}
91 94
 
92 95
 		// if passed a type, clear that type out
93
-		if ($type === '' || $type === 'user')
94
-			xcache_clear_cache(XC_TYPE_VAR, 0);
95
-		if ($type === '' || $type === 'data')
96
-			xcache_clear_cache(XC_TYPE_PHP, 0);
96
+		if ($type === '' || $type === 'user') {
97
+					xcache_clear_cache(XC_TYPE_VAR, 0);
98
+		}
99
+		if ($type === '' || $type === 'data') {
100
+					xcache_clear_cache(XC_TYPE_PHP, 0);
101
+		}
97 102
 
98 103
 		$this->invalidateCache();
99 104
 		return true;
@@ -112,8 +117,9 @@  discard block
 block discarded – undo
112 117
 		// While we could md5 this when saving, this could be tricky to be sure it doesn't get corrupted on additional saves.
113 118
 		$config_vars[] = array('xcache_adminpass', $txt['cache_xcache_adminpass'], 'db', 'text', 0);
114 119
 
115
-		if (!isset($context['settings_post_javascript']))
116
-			$context['settings_post_javascript'] = '';
120
+		if (!isset($context['settings_post_javascript'])) {
121
+					$context['settings_post_javascript'] = '';
122
+		}
117 123
 
118 124
 		$context['settings_post_javascript'] .= '
119 125
 			$("#cache_accelerator").change(function (e) {
Please login to merge, or discard this patch.
Sources/Profile-Actions.php 1 patch
Braces   +117 added lines, -86 removed lines patch added patch discarded remove patch
@@ -13,8 +13,9 @@  discard block
 block discarded – undo
13 13
  * @version 2.1 Beta 3
14 14
  */
15 15
 
16
-if (!defined('SMF'))
16
+if (!defined('SMF')) {
17 17
 	die('No direct access...');
18
+}
18 19
 
19 20
 /**
20 21
  * Activate an account.
@@ -48,8 +49,9 @@  discard block
 block discarded – undo
48 49
 		logAction('approve_member', array('member' => $memID), 'admin');
49 50
 
50 51
 		// If we are doing approval, update the stats for the member just in case.
51
-		if (in_array($user_profile[$memID]['is_activated'], array(3, 4, 5, 13, 14, 15)))
52
-			updateSettings(array('unapprovedMembers' => ($modSettings['unapprovedMembers'] > 1 ? $modSettings['unapprovedMembers'] - 1 : 0)));
52
+		if (in_array($user_profile[$memID]['is_activated'], array(3, 4, 5, 13, 14, 15))) {
53
+					updateSettings(array('unapprovedMembers' => ($modSettings['unapprovedMembers'] > 1 ? $modSettings['unapprovedMembers'] - 1 : 0)));
54
+		}
53 55
 
54 56
 		// Make sure we update the stats too.
55 57
 		updateStats('member', false);
@@ -76,8 +78,9 @@  discard block
 block discarded – undo
76 78
 	$issueErrors = array();
77 79
 
78 80
 	// Doesn't hurt to be overly cautious.
79
-	if (empty($modSettings['warning_enable']) || ($context['user']['is_owner'] && !$cur_profile['warning']) || !allowedTo('issue_warning'))
80
-		fatal_lang_error('no_access', false);
81
+	if (empty($modSettings['warning_enable']) || ($context['user']['is_owner'] && !$cur_profile['warning']) || !allowedTo('issue_warning')) {
82
+			fatal_lang_error('no_access', false);
83
+	}
81 84
 
82 85
 	// Get the base (errors related) stuff done.
83 86
 	loadLanguage('Errors');
@@ -135,16 +138,18 @@  discard block
 block discarded – undo
135 138
 
136 139
 		// This cannot be empty!
137 140
 		$_POST['warn_reason'] = isset($_POST['warn_reason']) ? trim($_POST['warn_reason']) : '';
138
-		if ($_POST['warn_reason'] == '' && !$context['user']['is_owner'])
139
-			$issueErrors[] = 'warning_no_reason';
141
+		if ($_POST['warn_reason'] == '' && !$context['user']['is_owner']) {
142
+					$issueErrors[] = 'warning_no_reason';
143
+		}
140 144
 		$_POST['warn_reason'] = $smcFunc['htmlspecialchars']($_POST['warn_reason']);
141 145
 
142 146
 		$_POST['warning_level'] = (int) $_POST['warning_level'];
143 147
 		$_POST['warning_level'] = max(0, min(100, $_POST['warning_level']));
144
-		if ($_POST['warning_level'] < $context['min_allowed'])
145
-			$_POST['warning_level'] = $context['min_allowed'];
146
-		elseif ($_POST['warning_level'] > $context['max_allowed'])
147
-			$_POST['warning_level'] = $context['max_allowed'];
148
+		if ($_POST['warning_level'] < $context['min_allowed']) {
149
+					$_POST['warning_level'] = $context['min_allowed'];
150
+		} elseif ($_POST['warning_level'] > $context['max_allowed']) {
151
+					$_POST['warning_level'] = $context['max_allowed'];
152
+		}
148 153
 
149 154
 		// Do we actually have to issue them with a PM?
150 155
 		$id_notice = 0;
@@ -152,8 +157,9 @@  discard block
 block discarded – undo
152 157
 		{
153 158
 			$_POST['warn_sub'] = trim($_POST['warn_sub']);
154 159
 			$_POST['warn_body'] = trim($_POST['warn_body']);
155
-			if (empty($_POST['warn_sub']) || empty($_POST['warn_body']))
156
-				$issueErrors[] = 'warning_notify_blank';
160
+			if (empty($_POST['warn_sub']) || empty($_POST['warn_body'])) {
161
+							$issueErrors[] = 'warning_notify_blank';
162
+			}
157 163
 			// Send the PM?
158 164
 			else
159 165
 			{
@@ -190,8 +196,8 @@  discard block
 block discarded – undo
190 196
 		if (empty($issueErrors))
191 197
 		{
192 198
 			// Log what we've done!
193
-			if (!$context['user']['is_owner'])
194
-				$smcFunc['db_insert']('',
199
+			if (!$context['user']['is_owner']) {
200
+							$smcFunc['db_insert']('',
195 201
 					'{db_prefix}log_comments',
196 202
 					array(
197 203
 						'id_member' => 'int', 'member_name' => 'string', 'comment_type' => 'string', 'id_recipient' => 'int', 'recipient_name' => 'string-255',
@@ -203,14 +209,14 @@  discard block
 block discarded – undo
203 209
 					),
204 210
 					array('id_comment')
205 211
 				);
212
+			}
206 213
 
207 214
 			// Make the change.
208 215
 			updateMemberData($memID, array('warning' => $_POST['warning_level']));
209 216
 
210 217
 			// Leave a lovely message.
211 218
 			$context['profile_updated'] = $context['user']['is_owner'] ? $txt['profile_updated_own'] : $txt['profile_warning_success'];
212
-		}
213
-		else
219
+		} else
214 220
 		{
215 221
 			// Try to remember some bits.
216 222
 			$context['warning_data'] = array(
@@ -229,8 +235,9 @@  discard block
 block discarded – undo
229 235
 	{
230 236
 		$warning_body = !empty($_POST['warn_body']) ? trim(censorText($_POST['warn_body'])) : '';
231 237
 		$context['preview_subject'] = !empty($_POST['warn_sub']) ? trim($smcFunc['htmlspecialchars']($_POST['warn_sub'])) : '';
232
-		if (empty($_POST['warn_sub']) || empty($_POST['warn_body']))
233
-			$issueErrors[] = 'warning_notify_blank';
238
+		if (empty($_POST['warn_sub']) || empty($_POST['warn_body'])) {
239
+					$issueErrors[] = 'warning_notify_blank';
240
+		}
234 241
 
235 242
 		if (!empty($_POST['warn_body']))
236 243
 		{
@@ -254,8 +261,9 @@  discard block
 block discarded – undo
254 261
 	{
255 262
 		// Fill in the suite of errors.
256 263
 		$context['post_errors'] = array();
257
-		foreach ($issueErrors as $error)
258
-			$context['post_errors'][] = $txt[$error];
264
+		foreach ($issueErrors as $error) {
265
+					$context['post_errors'][] = $txt[$error];
266
+		}
259 267
 	}
260 268
 
261 269
 
@@ -272,9 +280,10 @@  discard block
 block discarded – undo
272 280
 		$modSettings['warning_mute'] => $txt['profile_warning_effect_mute'],
273 281
 	);
274 282
 	$context['current_level'] = 0;
275
-	foreach ($context['level_effects'] as $limit => $dummy)
276
-		if ($context['member']['warning'] >= $limit)
283
+	foreach ($context['level_effects'] as $limit => $dummy) {
284
+			if ($context['member']['warning'] >= $limit)
277 285
 			$context['current_level'] = $limit;
286
+	}
278 287
 
279 288
 	$listOptions = array(
280 289
 		'id' => 'view_warnings',
@@ -337,11 +346,12 @@  discard block
 block discarded – undo
337 346
 							' . $warning['reason'] . '
338 347
 						</div>';
339 348
 
340
-						if (!empty($warning['id_notice']))
341
-							$ret .= '
349
+						if (!empty($warning['id_notice'])) {
350
+													$ret .= '
342 351
 						<div class="floatright">
343 352
 							<a href="' . $scripturl . '?action=moderate;area=notice;nid=' . $warning['id_notice'] . '" onclick="window.open(this.href, \'\', \'scrollbars=yes,resizable=yes,width=400,height=250\');return false;" target="_blank" class="new_win" title="' . $txt['profile_warning_previous_notice'] . '"><span class="generic_icons filter centericon"></span></a>
344 353
 						</div>';
354
+						}
345 355
 
346 356
 						return $ret;
347 357
 					},
@@ -413,8 +423,9 @@  discard block
 block discarded – undo
413 423
 	while ($row = $smcFunc['db_fetch_assoc']($request))
414 424
 	{
415 425
 		// If we're not warning for a message skip any that are.
416
-		if (!$context['warning_for_message'] && strpos($row['body'], '{MESSAGE}') !== false)
417
-			continue;
426
+		if (!$context['warning_for_message'] && strpos($row['body'], '{MESSAGE}') !== false) {
427
+					continue;
428
+		}
418 429
 
419 430
 		$context['notification_templates'][] = array(
420 431
 			'title' => $row['template_title'],
@@ -424,16 +435,18 @@  discard block
 block discarded – undo
424 435
 	$smcFunc['db_free_result']($request);
425 436
 
426 437
 	// Setup the "default" templates.
427
-	foreach (array('spamming', 'offence', 'insulting') as $type)
428
-		$context['notification_templates'][] = array(
438
+	foreach (array('spamming', 'offence', 'insulting') as $type) {
439
+			$context['notification_templates'][] = array(
429 440
 			'title' => $txt['profile_warning_notify_title_' . $type],
430 441
 			'body' => sprintf($txt['profile_warning_notify_template_outline' . (!empty($context['warning_for_message']) ? '_post' : '')], $txt['profile_warning_notify_for_' . $type]),
431 442
 		);
443
+	}
432 444
 
433 445
 	// Replace all the common variables in the templates.
434
-	foreach ($context['notification_templates'] as $k => $name)
435
-		$context['notification_templates'][$k]['body'] = strtr($name['body'], array('{MEMBER}' => un_htmlspecialchars($context['member']['name']), '{MESSAGE}' => '[url=' . $scripturl . '?msg=' . $context['warning_for_message'] . ']' . un_htmlspecialchars($context['warned_message_subject']) . '[/url]', '{SCRIPTURL}' => $scripturl, '{FORUMNAME}' => $mbname, '{REGARDS}' => $txt['regards_team']));
436
-}
446
+	foreach ($context['notification_templates'] as $k => $name) {
447
+			$context['notification_templates'][$k]['body'] = strtr($name['body'], array('{MEMBER}' => un_htmlspecialchars($context['member']['name']), '{MESSAGE}' => '[url=' . $scripturl . '?msg=' . $context['warning_for_message'] . ']' . un_htmlspecialchars($context['warned_message_subject']) . '[/url]', '{SCRIPTURL}' => $scripturl, '{FORUMNAME}' => $mbname, '{REGARDS}' => $txt['regards_team']));
448
+	}
449
+	}
437 450
 
438 451
 /**
439 452
  * Get the number of warnings a user has. Callback for $listOptions['get_count'] in issueWarning()
@@ -517,10 +530,11 @@  discard block
 block discarded – undo
517 530
 {
518 531
 	global $txt, $context, $modSettings, $cur_profile;
519 532
 
520
-	if (!$context['user']['is_owner'])
521
-		isAllowedTo('profile_remove_any');
522
-	elseif (!allowedTo('profile_remove_any'))
523
-		isAllowedTo('profile_remove_own');
533
+	if (!$context['user']['is_owner']) {
534
+			isAllowedTo('profile_remove_any');
535
+	} elseif (!allowedTo('profile_remove_any')) {
536
+			isAllowedTo('profile_remove_own');
537
+	}
524 538
 
525 539
 	// Permissions for removing stuff...
526 540
 	$context['can_delete_posts'] = !$context['user']['is_owner'] && allowedTo('moderate_forum');
@@ -547,10 +561,11 @@  discard block
 block discarded – undo
547 561
 
548 562
 	// @todo Add a way to delete pms as well?
549 563
 
550
-	if (!$context['user']['is_owner'])
551
-		isAllowedTo('profile_remove_any');
552
-	elseif (!allowedTo('profile_remove_any'))
553
-		isAllowedTo('profile_remove_own');
564
+	if (!$context['user']['is_owner']) {
565
+			isAllowedTo('profile_remove_any');
566
+	} elseif (!allowedTo('profile_remove_any')) {
567
+			isAllowedTo('profile_remove_own');
568
+	}
554 569
 
555 570
 	checkSession();
556 571
 
@@ -576,8 +591,9 @@  discard block
 block discarded – undo
576 591
 		list ($another) = $smcFunc['db_fetch_row']($request);
577 592
 		$smcFunc['db_free_result']($request);
578 593
 
579
-		if (empty($another))
580
-			fatal_lang_error('at_least_one_admin', 'critical');
594
+		if (empty($another)) {
595
+					fatal_lang_error('at_least_one_admin', 'critical');
596
+		}
581 597
 	}
582 598
 
583 599
 	// This file is needed for the deleteMembers function.
@@ -656,8 +672,9 @@  discard block
 block discarded – undo
656 672
 					)
657 673
 				);
658 674
 				$topicIDs = array();
659
-				while ($row = $smcFunc['db_fetch_assoc']($request))
660
-					$topicIDs[] = $row['id_topic'];
675
+				while ($row = $smcFunc['db_fetch_assoc']($request)) {
676
+									$topicIDs[] = $row['id_topic'];
677
+				}
661 678
 				$smcFunc['db_free_result']($request);
662 679
 
663 680
 				// Actually remove the topics. Ignore recycling if we want to perma-delete things...
@@ -680,8 +697,9 @@  discard block
 block discarded – undo
680 697
 			// This could take a while... but ya know it's gonna be worth it in the end.
681 698
 			while ($row = $smcFunc['db_fetch_assoc']($request))
682 699
 			{
683
-				if (function_exists('apache_reset_timeout'))
684
-					@apache_reset_timeout();
700
+				if (function_exists('apache_reset_timeout')) {
701
+									@apache_reset_timeout();
702
+				}
685 703
 
686 704
 				removeMessage($row['id_msg']);
687 705
 			}
@@ -689,8 +707,9 @@  discard block
 block discarded – undo
689 707
 		}
690 708
 
691 709
 		// Only delete this poor members account if they are actually being booted out of camp.
692
-		if (isset($_POST['deleteAccount']))
693
-			deleteMembers($memID);
710
+		if (isset($_POST['deleteAccount'])) {
711
+					deleteMembers($memID);
712
+		}
694 713
 	}
695 714
 	// Do they need approval to delete?
696 715
 	elseif (!empty($modSettings['approveAccountDeletion']) && !allowedTo('moderate_forum'))
@@ -741,18 +760,18 @@  discard block
 block discarded – undo
741 760
 		{
742 761
 			foreach ($costs as $duration => $cost)
743 762
 			{
744
-				if ($cost != 0)
745
-					$cost_array[$duration] = $cost;
763
+				if ($cost != 0) {
764
+									$cost_array[$duration] = $cost;
765
+				}
746 766
 			}
747
-		}
748
-		else
767
+		} else
749 768
 		{
750 769
 			$cost_array['fixed'] = $costs['fixed'];
751 770
 		}
752 771
 
753
-		if (empty($cost_array))
754
-			unset($context['subscriptions'][$id]);
755
-		else
772
+		if (empty($cost_array)) {
773
+					unset($context['subscriptions'][$id]);
774
+		} else
756 775
 		{
757 776
 			$context['subscriptions'][$id]['member'] = 0;
758 777
 			$context['subscriptions'][$id]['subscribed'] = false;
@@ -765,13 +784,15 @@  discard block
 block discarded – undo
765 784
 	foreach ($gateways as $id => $gateway)
766 785
 	{
767 786
 		$gateways[$id] = new $gateway['display_class']();
768
-		if (!$gateways[$id]->gatewayEnabled())
769
-			unset($gateways[$id]);
787
+		if (!$gateways[$id]->gatewayEnabled()) {
788
+					unset($gateways[$id]);
789
+		}
770 790
 	}
771 791
 
772 792
 	// No gateways yet?
773
-	if (empty($gateways))
774
-		fatal_error($txt['paid_admin_not_setup_gateway']);
793
+	if (empty($gateways)) {
794
+			fatal_error($txt['paid_admin_not_setup_gateway']);
795
+	}
775 796
 
776 797
 	// Get the current subscriptions.
777 798
 	$request = $smcFunc['db_query']('', '
@@ -786,8 +807,9 @@  discard block
 block discarded – undo
786 807
 	while ($row = $smcFunc['db_fetch_assoc']($request))
787 808
 	{
788 809
 		// The subscription must exist!
789
-		if (!isset($context['subscriptions'][$row['id_subscribe']]))
790
-			continue;
810
+		if (!isset($context['subscriptions'][$row['id_subscribe']])) {
811
+					continue;
812
+		}
791 813
 
792 814
 		$context['current'][$row['id_subscribe']] = array(
793 815
 			'id' => $row['id_sublog'],
@@ -801,8 +823,9 @@  discard block
 block discarded – undo
801 823
 			'status_text' => $row['status'] == 0 ? ($row['payments_pending'] ? $txt['paid_pending'] : $txt['paid_finished']) : $txt['paid_active'],
802 824
 		);
803 825
 
804
-		if ($row['status'] == 1)
805
-			$context['subscriptions'][$row['id_subscribe']]['subscribed'] = true;
826
+		if ($row['status'] == 1) {
827
+					$context['subscriptions'][$row['id_subscribe']]['subscribed'] = true;
828
+		}
806 829
 	}
807 830
 	$smcFunc['db_free_result']($request);
808 831
 
@@ -853,21 +876,25 @@  discard block
 block discarded – undo
853 876
 	if (isset($_GET['confirm']) && isset($_POST['sub_id']) && is_array($_POST['sub_id']))
854 877
 	{
855 878
 		// Hopefully just one.
856
-		foreach ($_POST['sub_id'] as $k => $v)
857
-			$ID_SUB = (int) $k;
879
+		foreach ($_POST['sub_id'] as $k => $v) {
880
+					$ID_SUB = (int) $k;
881
+		}
858 882
 
859
-		if (!isset($context['subscriptions'][$ID_SUB]) || $context['subscriptions'][$ID_SUB]['active'] == 0)
860
-			fatal_lang_error('paid_sub_not_active');
883
+		if (!isset($context['subscriptions'][$ID_SUB]) || $context['subscriptions'][$ID_SUB]['active'] == 0) {
884
+					fatal_lang_error('paid_sub_not_active');
885
+		}
861 886
 
862 887
 		// Simplify...
863 888
 		$context['sub'] = $context['subscriptions'][$ID_SUB];
864 889
 		$period = 'xx';
865
-		if ($context['sub']['flexible'])
866
-			$period = isset($_POST['cur'][$ID_SUB]) && isset($context['sub']['costs'][$_POST['cur'][$ID_SUB]]) ? $_POST['cur'][$ID_SUB] : 'xx';
890
+		if ($context['sub']['flexible']) {
891
+					$period = isset($_POST['cur'][$ID_SUB]) && isset($context['sub']['costs'][$_POST['cur'][$ID_SUB]]) ? $_POST['cur'][$ID_SUB] : 'xx';
892
+		}
867 893
 
868 894
 		// Check we have a valid cost.
869
-		if ($context['sub']['flexible'] && $period == 'xx')
870
-			fatal_lang_error('paid_sub_not_active');
895
+		if ($context['sub']['flexible'] && $period == 'xx') {
896
+					fatal_lang_error('paid_sub_not_active');
897
+		}
871 898
 
872 899
 		// Sort out the cost/currency.
873 900
 		$context['currency'] = $modSettings['paid_currency_code'];
@@ -880,8 +907,7 @@  discard block
 block discarded – undo
880 907
 			$context['cost'] = sprintf($modSettings['paid_currency_symbol'], $context['value']) . '/' . $txt[$_POST['cur'][$ID_SUB]];
881 908
 			// The period value for paypal.
882 909
 			$context['paypal_period'] = strtoupper(substr($_POST['cur'][$ID_SUB], 0, 1));
883
-		}
884
-		else
910
+		} else
885 911
 		{
886 912
 			// Real cost...
887 913
 			$context['value'] = $context['sub']['costs']['fixed'];
@@ -898,13 +924,15 @@  discard block
 block discarded – undo
898 924
 		foreach ($gateways as $id => $gateway)
899 925
 		{
900 926
 			$fields = $gateways[$id]->fetchGatewayFields($context['sub']['id'] . '+' . $memID, $context['sub'], $context['value'], $period, $scripturl . '?action=profile;u=' . $memID . ';area=subscriptions;sub_id=' . $context['sub']['id'] . ';done');
901
-			if (!empty($fields['form']))
902
-				$context['gateways'][] = $fields;
927
+			if (!empty($fields['form'])) {
928
+							$context['gateways'][] = $fields;
929
+			}
903 930
 		}
904 931
 
905 932
 		// Bugger?!
906
-		if (empty($context['gateways']))
907
-			fatal_error($txt['paid_admin_not_setup_gateway']);
933
+		if (empty($context['gateways'])) {
934
+					fatal_error($txt['paid_admin_not_setup_gateway']);
935
+		}
908 936
 
909 937
 		// Now we are going to assume they want to take this out ;)
910 938
 		$new_data = array($context['sub']['id'], $context['value'], $period, 'prepay');
@@ -912,16 +940,19 @@  discard block
 block discarded – undo
912 940
 		{
913 941
 			// What are the details like?
914 942
 			$current_pending = array();
915
-			if ($context['current'][$context['sub']['id']]['pending_details'] != '')
916
-				$current_pending = smf_json_decode($context['current'][$context['sub']['id']]['pending_details'], true);
943
+			if ($context['current'][$context['sub']['id']]['pending_details'] != '') {
944
+							$current_pending = smf_json_decode($context['current'][$context['sub']['id']]['pending_details'], true);
945
+			}
917 946
 			// Don't get silly.
918
-			if (count($current_pending) > 9)
919
-				$current_pending = array();
947
+			if (count($current_pending) > 9) {
948
+							$current_pending = array();
949
+			}
920 950
 			$pending_count = 0;
921 951
 			// Only record real pending payments as will otherwise confuse the admin!
922
-			foreach ($current_pending as $pending)
923
-				if ($pending[3] == 'payback')
952
+			foreach ($current_pending as $pending) {
953
+							if ($pending[3] == 'payback')
924 954
 					$pending_count++;
955
+			}
925 956
 
926 957
 			if (!in_array($new_data, $current_pending))
927 958
 			{
@@ -966,9 +997,9 @@  discard block
 block discarded – undo
966 997
 
967 998
 		// Quit.
968 999
 		return;
1000
+	} else {
1001
+			$context['sub_template'] = 'user_subscription';
1002
+	}
969 1003
 	}
970
-	else
971
-		$context['sub_template'] = 'user_subscription';
972
-}
973 1004
 
974 1005
 ?>
975 1006
\ No newline at end of file
Please login to merge, or discard this patch.
Sources/Admin.php 1 patch
Braces   +75 added lines, -52 removed lines patch added patch discarded remove patch
@@ -13,8 +13,9 @@  discard block
 block discarded – undo
13 13
  * @version 2.1 Beta 3
14 14
  */
15 15
 
16
-if (!defined('SMF'))
16
+if (!defined('SMF')) {
17 17
 	die('No direct access...');
18
+}
18 19
 
19 20
 /**
20 21
  * The main admin handling function.<br>
@@ -444,8 +445,9 @@  discard block
 block discarded – undo
444 445
 		foreach ($admin_includes as $include)
445 446
 		{
446 447
 			$include = strtr(trim($include), array('$boarddir' => $boarddir, '$sourcedir' => $sourcedir, '$themedir' => $settings['theme_dir']));
447
-			if (file_exists($include))
448
-				require_once($include);
448
+			if (file_exists($include)) {
449
+							require_once($include);
450
+			}
449 451
 		}
450 452
 	}
451 453
 
@@ -457,24 +459,27 @@  discard block
 block discarded – undo
457 459
 	unset($admin_areas);
458 460
 
459 461
 	// Nothing valid?
460
-	if ($admin_include_data == false)
461
-		fatal_lang_error('no_access', false);
462
+	if ($admin_include_data == false) {
463
+			fatal_lang_error('no_access', false);
464
+	}
462 465
 
463 466
 	// Build the link tree.
464 467
 	$context['linktree'][] = array(
465 468
 		'url' => $scripturl . '?action=admin',
466 469
 		'name' => $txt['admin_center'],
467 470
 	);
468
-	if (isset($admin_include_data['current_area']) && $admin_include_data['current_area'] != 'index')
469
-		$context['linktree'][] = array(
471
+	if (isset($admin_include_data['current_area']) && $admin_include_data['current_area'] != 'index') {
472
+			$context['linktree'][] = array(
470 473
 			'url' => $scripturl . '?action=admin;area=' . $admin_include_data['current_area'] . ';' . $context['session_var'] . '=' . $context['session_id'],
471 474
 			'name' => $admin_include_data['label'],
472 475
 		);
473
-	if (!empty($admin_include_data['current_subsection']) && $admin_include_data['subsections'][$admin_include_data['current_subsection']][0] != $admin_include_data['label'])
474
-		$context['linktree'][] = array(
476
+	}
477
+	if (!empty($admin_include_data['current_subsection']) && $admin_include_data['subsections'][$admin_include_data['current_subsection']][0] != $admin_include_data['label']) {
478
+			$context['linktree'][] = array(
475 479
 			'url' => $scripturl . '?action=admin;area=' . $admin_include_data['current_area'] . ';sa=' . $admin_include_data['current_subsection'] . ';' . $context['session_var'] . '=' . $context['session_id'],
476 480
 			'name' => $admin_include_data['subsections'][$admin_include_data['current_subsection']][0],
477 481
 		);
482
+	}
478 483
 
479 484
 	// Make a note of the Unique ID for this menu.
480 485
 	$context['admin_menu_id'] = $context['max_menu_id'];
@@ -484,16 +489,18 @@  discard block
 block discarded – undo
484 489
 	$context['admin_area'] = $admin_include_data['current_area'];
485 490
 
486 491
 	// Now - finally - call the right place!
487
-	if (isset($admin_include_data['file']))
488
-		require_once($sourcedir . '/' . $admin_include_data['file']);
492
+	if (isset($admin_include_data['file'])) {
493
+			require_once($sourcedir . '/' . $admin_include_data['file']);
494
+	}
489 495
 
490 496
 	// Get the right callable.
491 497
 	$call = call_helper($admin_include_data['function'], true);
492 498
 
493 499
 	// Is it valid?
494
-	if (!empty($call))
495
-		call_user_func($call);
496
-}
500
+	if (!empty($call)) {
501
+			call_user_func($call);
502
+	}
503
+	}
497 504
 
498 505
 /**
499 506
  * The main administration section.
@@ -547,13 +554,14 @@  discard block
 block discarded – undo
547 554
 
548 555
 	$context['sub_template'] = $context['admin_area'] == 'credits' ? 'credits' : 'admin';
549 556
 	$context['page_title'] = $context['admin_area'] == 'credits' ? $txt['support_credits_title'] : $txt['admin_center'];
550
-	if ($context['admin_area'] != 'credits')
551
-		$context[$context['admin_menu_name']]['tab_data'] = array(
557
+	if ($context['admin_area'] != 'credits') {
558
+			$context[$context['admin_menu_name']]['tab_data'] = array(
552 559
 			'title' => $txt['admin_center'],
553 560
 			'help' => '',
554 561
 			'description' => '<strong>' . $txt['hello_guest'] . ' ' . $context['user']['name'] . '!</strong>
555 562
 						' . sprintf($txt['admin_main_welcome'], $txt['admin_center'], $txt['help'], $txt['help']),
556 563
 		);
564
+	}
557 565
 
558 566
 	// Lastly, fill in the blanks in the support resources paragraphs.
559 567
 	$txt['support_resources_p1'] = sprintf($txt['support_resources_p1'],
@@ -571,9 +579,10 @@  discard block
 block discarded – undo
571 579
 		'http://www.simplemachines.org/redirect/customize_support'
572 580
 	);
573 581
 
574
-	if ($context['admin_area'] == 'admin')
575
-		loadJavaScriptFile('admin.js', array('defer' => false), 'smf_admin');
576
-}
582
+	if ($context['admin_area'] == 'admin') {
583
+			loadJavaScriptFile('admin.js', array('defer' => false), 'smf_admin');
584
+	}
585
+	}
577 586
 
578 587
 /**
579 588
  * Get one of the admin information files from Simple Machines.
@@ -584,8 +593,9 @@  discard block
 block discarded – undo
584 593
 
585 594
 	setMemoryLimit('32M');
586 595
 
587
-	if (empty($_REQUEST['filename']) || !is_string($_REQUEST['filename']))
588
-		fatal_lang_error('no_access', false);
596
+	if (empty($_REQUEST['filename']) || !is_string($_REQUEST['filename'])) {
597
+			fatal_lang_error('no_access', false);
598
+	}
589 599
 
590 600
 	// Strip off the forum cache part or we won't find it...
591 601
 	$_REQUEST['filename'] = str_replace($modSettings['browser_cache'], '', $_REQUEST['filename']);
@@ -600,27 +610,30 @@  discard block
 block discarded – undo
600 610
 		)
601 611
 	);
602 612
 
603
-	if ($smcFunc['db_num_rows']($request) == 0)
604
-		fatal_lang_error('admin_file_not_found', true, array($_REQUEST['filename']), 404);
613
+	if ($smcFunc['db_num_rows']($request) == 0) {
614
+			fatal_lang_error('admin_file_not_found', true, array($_REQUEST['filename']), 404);
615
+	}
605 616
 
606 617
 	list ($file_data, $filetype) = $smcFunc['db_fetch_row']($request);
607 618
 	$smcFunc['db_free_result']($request);
608 619
 
609 620
 	// @todo Temp
610 621
 	// Figure out if sesc is still being used.
611
-	if (strpos($file_data, ';sesc=') !== false && $filetype == 'text/javascript')
612
-		$file_data = '
622
+	if (strpos($file_data, ';sesc=') !== false && $filetype == 'text/javascript') {
623
+			$file_data = '
613 624
 if (!(\'smfForum_sessionvar\' in window))
614 625
 	window.smfForum_sessionvar = \'sesc\';
615 626
 ' . strtr($file_data, array(';sesc=' => ';\' + window.smfForum_sessionvar + \'='));
627
+	}
616 628
 
617 629
 	$context['template_layers'] = array();
618 630
 	// Lets make sure we aren't going to output anything nasty.
619 631
 	@ob_end_clean();
620
-	if (!empty($modSettings['enableCompressedOutput']))
621
-		@ob_start('ob_gzhandler');
622
-	else
623
-		@ob_start();
632
+	if (!empty($modSettings['enableCompressedOutput'])) {
633
+			@ob_start('ob_gzhandler');
634
+	} else {
635
+			@ob_start();
636
+	}
624 637
 
625 638
 	// Make sure they know what type of file we are.
626 639
 	header('Content-Type: ' . $filetype);
@@ -660,11 +673,12 @@  discard block
 block discarded – undo
660 673
 		updateAdminPreferences();
661 674
 	}
662 675
 
663
-	if (trim($context['search_term']) == '')
664
-		$context['search_results'] = array();
665
-	else
666
-		call_helper($subActions[$context['search_type']]);
667
-}
676
+	if (trim($context['search_term']) == '') {
677
+			$context['search_results'] = array();
678
+	} else {
679
+			call_helper($subActions[$context['search_type']]);
680
+	}
681
+	}
668 682
 
669 683
 /**
670 684
  * A complicated but relatively quick internal search.
@@ -728,8 +742,9 @@  discard block
 block discarded – undo
728 742
 
729 743
 	loadLanguage(implode('+', $language_files));
730 744
 
731
-	foreach ($include_files as $file)
732
-		require_once($sourcedir . '/' . $file . '.php');
745
+	foreach ($include_files as $file) {
746
+			require_once($sourcedir . '/' . $file . '.php');
747
+	}
733 748
 
734 749
 	/* This is the huge array that defines everything... it's a huge array of items formatted as follows:
735 750
 		0 = Language index (Can be array of indexes) to search through for this setting.
@@ -753,11 +768,12 @@  discard block
 block discarded – undo
753 768
 		foreach ($section['areas'] as $menu_key => $menu_item)
754 769
 		{
755 770
 			$search_data['sections'][] = array($menu_item['label'], 'area=' . $menu_key);
756
-			if (!empty($menu_item['subsections']))
757
-				foreach ($menu_item['subsections'] as $key => $sublabel)
771
+			if (!empty($menu_item['subsections'])) {
772
+							foreach ($menu_item['subsections'] as $key => $sublabel)
758 773
 				{
759 774
 					if (isset($sublabel['label']))
760 775
 						$search_data['sections'][] = array($sublabel['label'], 'area=' . $menu_key . ';sa=' . $key);
776
+			}
761 777
 				}
762 778
 		}
763 779
 	}
@@ -767,9 +783,10 @@  discard block
 block discarded – undo
767 783
 		// Get a list of their variables.
768 784
 		$config_vars = $setting_area[0](true);
769 785
 
770
-		foreach ($config_vars as $var)
771
-			if (!empty($var[1]) && !in_array($var[0], array('permissions', 'switch', 'desc')))
786
+		foreach ($config_vars as $var) {
787
+					if (!empty($var[1]) && !in_array($var[0], array('permissions', 'switch', 'desc')))
772 788
 				$search_data['settings'][] = array($var[(isset($var[2]) && in_array($var[2], array('file', 'db'))) ? 0 : 1], $setting_area[1]);
789
+		}
773 790
 	}
774 791
 
775 792
 	$context['page_title'] = $txt['admin_search_results'];
@@ -782,8 +799,9 @@  discard block
 block discarded – undo
782 799
 		foreach ($data as $item)
783 800
 		{
784 801
 			$found = false;
785
-			if (!is_array($item[0]))
786
-				$item[0] = array($item[0]);
802
+			if (!is_array($item[0])) {
803
+							$item[0] = array($item[0]);
804
+			}
787 805
 			foreach ($item[0] as $term)
788 806
 			{
789 807
 				if (stripos($term, $search_term) !== false || (isset($txt[$term]) && stripos($txt[$term], $search_term) !== false) || (isset($txt['setting_' . $term]) && stripos($txt['setting_' . $term], $search_term) !== false))
@@ -841,8 +859,9 @@  discard block
 block discarded – undo
841 859
 	$postVars = explode(' ', $context['search_term']);
842 860
 
843 861
 	// Encode the search data.
844
-	foreach ($postVars as $k => $v)
845
-		$postVars[$k] = urlencode($v);
862
+	foreach ($postVars as $k => $v) {
863
+			$postVars[$k] = urlencode($v);
864
+	}
846 865
 
847 866
 	// This is what we will send.
848 867
 	$postVars = implode('+', $postVars);
@@ -854,8 +873,9 @@  discard block
 block discarded – undo
854 873
 	$search_results = fetch_web_data($context['doc_apiurl'] . '?action=query&list=search&srprop=timestamp|snippet&format=xml&srwhat=text&srsearch=' . $postVars);
855 874
 
856 875
 	// If we didn't get any xml back we are in trouble - perhaps the doc site is overloaded?
857
-	if (!$search_results || preg_match('~<' . '\?xml\sversion="\d+\.\d+"\?' . '>\s*(<api>.+?</api>)~is', $search_results, $matches) != true)
858
-		fatal_lang_error('cannot_connect_doc_site');
876
+	if (!$search_results || preg_match('~<' . '\?xml\sversion="\d+\.\d+"\?' . '>\s*(<api>.+?</api>)~is', $search_results, $matches) != true) {
877
+			fatal_lang_error('cannot_connect_doc_site');
878
+	}
859 879
 
860 880
 	$search_results = $matches[1];
861 881
 
@@ -867,8 +887,9 @@  discard block
 block discarded – undo
867 887
 	$results = new xmlArray($search_results, false);
868 888
 
869 889
 	// Move through the api layer.
870
-	if (!$results->exists('api'))
871
-		fatal_lang_error('cannot_connect_doc_site');
890
+	if (!$results->exists('api')) {
891
+			fatal_lang_error('cannot_connect_doc_site');
892
+	}
872 893
 
873 894
 	// Are there actually some results?
874 895
 	if ($results->exists('api/query/search/p'))
@@ -904,8 +925,9 @@  discard block
 block discarded – undo
904 925
 	);
905 926
 
906 927
 	// If it's not got a sa set it must have come here for first time, pretend error log should be reversed.
907
-	if (!isset($_REQUEST['sa']))
908
-		$_REQUEST['desc'] = true;
928
+	if (!isset($_REQUEST['sa'])) {
929
+			$_REQUEST['desc'] = true;
930
+	}
909 931
 
910 932
 	// Setup some tab stuff.
911 933
 	$context[$context['admin_menu_name']]['tab_data'] = array(
@@ -955,9 +977,10 @@  discard block
 block discarded – undo
955 977
 	unset($_SESSION['admin_time']);
956 978
 
957 979
 	// Clean any admin tokens as well.
958
-	foreach ($_SESSION['token'] as $key => $token)
959
-		if (strpos($key, '-admin') !== false)
980
+	foreach ($_SESSION['token'] as $key => $token) {
981
+			if (strpos($key, '-admin') !== false)
960 982
 			unset($_SESSION['token'][$key]);
983
+	}
961 984
 
962 985
 	redirectexit();
963 986
 }
Please login to merge, or discard this patch.
Sources/Subs-Compat.php 1 patch
Braces   +27 added lines, -19 removed lines patch added patch discarded remove patch
@@ -16,8 +16,9 @@  discard block
 block discarded – undo
16 16
  * @version 2.1 Beta 3
17 17
  */
18 18
 
19
-if (!defined('SMF'))
19
+if (!defined('SMF')) {
20 20
 	die('No direct access...');
21
+}
21 22
 
22 23
 
23 24
 /**
@@ -28,14 +29,16 @@  discard block
 block discarded – undo
28 29
 function sha1_smf($str)
29 30
 {
30 31
 	// If we have mhash loaded in, use it instead!
31
-	if (function_exists('mhash') && defined('MHASH_SHA1'))
32
-		return bin2hex(mhash(MHASH_SHA1, $str));
32
+	if (function_exists('mhash') && defined('MHASH_SHA1')) {
33
+			return bin2hex(mhash(MHASH_SHA1, $str));
34
+	}
33 35
 
34 36
 	$nblk = (strlen($str) + 8 >> 6) + 1;
35 37
 	$blks = array_pad(array(), $nblk * 16, 0);
36 38
 
37
-	for ($i = 0; $i < strlen($str); $i++)
38
-		$blks[$i >> 2] |= ord($str{$i}) << (24 - ($i % 4) * 8);
39
+	for ($i = 0; $i < strlen($str); $i++) {
40
+			$blks[$i >> 2] |= ord($str{$i}) << (24 - ($i % 4) * 8);
41
+	}
39 42
 
40 43
 	$blks[$i >> 2] |= 0x80 << (24 - ($i % 4) * 8);
41 44
 
@@ -70,10 +73,11 @@  discard block
 block discarded – undo
70 73
 
71 74
 		for ($j = 0; $j < 80; $j++)
72 75
 		{
73
-			if ($j < 16)
74
-				$w[$j] = isset($x[$i + $j]) ? $x[$i + $j] : 0;
75
-			else
76
-				$w[$j] = sha1_rol($w[$j - 3] ^ $w[$j - 8] ^ $w[$j - 14] ^ $w[$j - 16], 1);
76
+			if ($j < 16) {
77
+							$w[$j] = isset($x[$i + $j]) ? $x[$i + $j] : 0;
78
+			} else {
79
+							$w[$j] = sha1_rol($w[$j - 3] ^ $w[$j - 8] ^ $w[$j - 14] ^ $w[$j - 16], 1);
80
+			}
77 81
 
78 82
 			$t = sha1_rol($a, 5) + sha1_ft($j, $b, $c, $d) + $e + $w[$j] + sha1_kt($j);
79 83
 			$e = $d;
@@ -103,12 +107,15 @@  discard block
 block discarded – undo
103 107
  */
104 108
 function sha1_ft($t, $b, $c, $d)
105 109
 {
106
-	if ($t < 20)
107
-		return ($b & $c) | ((~$b) & $d);
108
-	if ($t < 40)
109
-		return $b ^ $c ^ $d;
110
-	if ($t < 60)
111
-		return ($b & $c) | ($b & $d) | ($c & $d);
110
+	if ($t < 20) {
111
+			return ($b & $c) | ((~$b) & $d);
112
+	}
113
+	if ($t < 40) {
114
+			return $b ^ $c ^ $d;
115
+	}
116
+	if ($t < 60) {
117
+			return ($b & $c) | ($b & $d) | ($c & $d);
118
+	}
112 119
 
113 120
 	return $b ^ $c ^ $d;
114 121
 }
@@ -132,10 +139,11 @@  discard block
 block discarded – undo
132 139
 function sha1_rol($num, $cnt)
133 140
 {
134 141
 	// Unfortunately, PHP uses unsigned 32-bit longs only.  So we have to kludge it a bit.
135
-	if ($num & 0x80000000)
136
-		$a = ($num >> 1 & 0x7fffffff) >> (31 - $cnt);
137
-	else
138
-		$a = $num >> (32 - $cnt);
142
+	if ($num & 0x80000000) {
143
+			$a = ($num >> 1 & 0x7fffffff) >> (31 - $cnt);
144
+	} else {
145
+			$a = $num >> (32 - $cnt);
146
+	}
139 147
 
140 148
 	return ($num << $cnt) | $a;
141 149
 }
Please login to merge, or discard this patch.
Themes/default/Post.template.php 1 patch
Braces   +98 added lines, -67 removed lines patch added patch discarded remove patch
@@ -22,22 +22,24 @@  discard block
 block discarded – undo
22 22
 		<script>';
23 23
 
24 24
 	// When using Go Back due to fatal_error, allow the form to be re-submitted with changes.
25
-	if (isBrowser('is_firefox'))
26
-		echo '
25
+	if (isBrowser('is_firefox')) {
26
+			echo '
27 27
 			window.addEventListener("pageshow", reActivate, false);';
28
+	}
28 29
 
29 30
 	// Start with message icons - and any missing from this theme.
30 31
 	echo '
31 32
 			var icon_urls = {';
32
-	foreach ($context['icons'] as $icon)
33
-		echo '
33
+	foreach ($context['icons'] as $icon) {
34
+			echo '
34 35
 				\'', $icon['value'], '\': \'', $icon['url'], '\'', $icon['is_last'] ? '' : ',';
36
+	}
35 37
 	echo '
36 38
 			};';
37 39
 
38 40
 	// If this is a poll - use some javascript to ensure the user doesn't create a poll with illegal option combinations.
39
-	if ($context['make_poll'])
40
-		echo '
41
+	if ($context['make_poll']) {
42
+			echo '
41 43
 			var pollOptionNum = 0, pollTabIndex;
42 44
 			var pollOptionId = ', $context['last_choice_id'], ';
43 45
 			function addPollOption()
@@ -56,11 +58,13 @@  discard block
 block discarded – undo
56 58
 
57 59
 				setOuterHTML(document.getElementById(\'pollMoreOptions\'), ', JavaScriptEscape('<dt><label for="options-'), ' + pollOptionId + ', JavaScriptEscape('">' . $txt['option'] . ' '), ' + pollOptionNum + ', JavaScriptEscape('</label>:</dt><dd><input type="text" name="options['), ' + pollOptionId + ', JavaScriptEscape(']" id="options-'), ' + pollOptionId + ', JavaScriptEscape('" value="" size="80" maxlength="255" tabindex="'), ' + pollTabIndex + ', JavaScriptEscape('" class="input_text"></dd><p id="pollMoreOptions"></p>'), ');
58 60
 			}';
61
+	}
59 62
 
60 63
 	// If we are making a calendar event we want to ensure we show the current days in a month etc... this is done here.
61
-	if ($context['make_event'])
62
-		echo '
64
+	if ($context['make_event']) {
65
+			echo '
63 66
 			var monthLength = [31, 28, 31, 30, 31, 30, 31, 31, 30, 31, 30, 31];';
67
+	}
64 68
 
65 69
 	// End of the javascript, start the form and display the link tree.
66 70
 	echo '
@@ -80,9 +84,10 @@  discard block
 block discarded – undo
80 84
 				</div>
81 85
 			</div><br>';
82 86
 
83
-	if ($context['make_event'] && (!$context['event']['new'] || !empty($context['current_board'])))
84
-		echo '
87
+	if ($context['make_event'] && (!$context['event']['new'] || !empty($context['current_board']))) {
88
+			echo '
85 89
 			<input type="hidden" name="eventid" value="', $context['event']['id'], '">';
90
+	}
86 91
 
87 92
 	// Start the main table.
88 93
 	echo '
@@ -117,26 +122,28 @@  discard block
 block discarded – undo
117 122
 	}
118 123
 
119 124
 	// If it's locked, show a message to warn the replier.
120
-	if (!empty($context['locked']))
121
-	echo '
125
+	if (!empty($context['locked'])) {
126
+		echo '
122 127
 					<p class="errorbox">
123 128
 						', $txt['topic_locked_no_reply'], '
124 129
 					</p>';
130
+	}
125 131
 
126
-	if (!empty($modSettings['drafts_post_enabled']))
127
-		echo '
132
+	if (!empty($modSettings['drafts_post_enabled'])) {
133
+			echo '
128 134
 					<div id="draft_section" class="infobox"', isset($context['draft_saved']) ? '' : ' style="display: none;"', '>',
129 135
 						sprintf($txt['draft_saved'], $scripturl . '?action=profile;u=' . $context['user']['id'] . ';area=showdrafts'), '
130 136
 						', (!empty($modSettings['drafts_keep_days']) ? ' <strong>' . sprintf($txt['draft_save_warning'], $modSettings['drafts_keep_days']) . '</strong>' : ''), '
131 137
 					</div>';
138
+	}
132 139
 
133 140
 	// The post header... important stuff
134 141
 	echo '
135 142
 					<dl id="post_header">';
136 143
 
137 144
 	// Custom posting fields.
138
-	if (!empty($context['posting_fields']) && is_array($context['posting_fields']))
139
-		foreach ($context['posting_fields'] as $pf)
145
+	if (!empty($context['posting_fields']) && is_array($context['posting_fields'])) {
146
+			foreach ($context['posting_fields'] as $pf)
140 147
 			echo '
141 148
 						<dt>
142 149
 							', $pf['dt'] ,'
@@ -144,6 +151,7 @@  discard block
 block discarded – undo
144 151
 						<dd>
145 152
 							', $pf['dd'] ,'
146 153
 						</dd>';
154
+	}
147 155
 
148 156
 
149 157
 	// Guests have to put in their name and email...
@@ -157,14 +165,15 @@  discard block
 block discarded – undo
157 165
 							<input type="text" name="guestname" size="25" value="', $context['name'], '" tabindex="', $context['tabindex']++, '" class="input_text">
158 166
 						</dd>';
159 167
 
160
-		if (empty($modSettings['guest_post_no_email']))
161
-			echo '
168
+		if (empty($modSettings['guest_post_no_email'])) {
169
+					echo '
162 170
 						<dt>
163 171
 							<span', isset($context['post_error']['no_email']) || isset($context['post_error']['bad_email']) ? ' class="error"' : '', ' id="caption_email">', $txt['email'], ':</span>
164 172
 						</dt>
165 173
 						<dd>
166 174
 							<input type="email" name="email" size="25" value="', $context['email'], '" tabindex="', $context['tabindex']++, '" class="input_text" required>
167 175
 						</dd>';
176
+		}
168 177
 	}
169 178
 
170 179
 	// Now show the subject box for this post.
@@ -182,9 +191,10 @@  discard block
 block discarded – undo
182 191
 							<select name="icon" id="icon" onchange="showimage()">';
183 192
 
184 193
 	// Loop through each message icon allowed, adding it to the drop down list.
185
-	foreach ($context['icons'] as $icon)
186
-		echo '
194
+	foreach ($context['icons'] as $icon) {
195
+			echo '
187 196
 								<option value="', $icon['value'], '"', $icon['value'] == $context['icon'] ? ' selected' : '', '>', $icon['name'], '</option>';
197
+	}
188 198
 
189 199
 	echo '
190 200
 							</select>
@@ -219,9 +229,10 @@  discard block
 block discarded – undo
219 229
 				{
220 230
 					echo '
221 231
 										<optgroup label="', $category['name'], '">';
222
-					foreach ($category['boards'] as $board)
223
-						echo '
232
+					foreach ($category['boards'] as $board) {
233
+											echo '
224 234
 											<option value="', $board['id'], '"', $board['selected'] ? ' selected' : '', '>', $board['child_level'] > 0 ? str_repeat('==', $board['child_level'] - 1) . '=&gt;' : '', ' ', $board['name'], '&nbsp;</option>';
235
+					}
225 236
 					echo '
226 237
 										</optgroup>';
227 238
 				}
@@ -257,9 +268,10 @@  discard block
 block discarded – undo
257 268
 									<span class="label">', $txt['calendar_timezone'], '</span>
258 269
 									<select name="tz" id="tz"', !empty($context['event']['allday']) ? ' disabled' : '', '>';
259 270
 
260
-			foreach ($context['all_timezones'] as $tz => $tzname)
261
-				echo '
271
+			foreach ($context['all_timezones'] as $tz => $tzname) {
272
+							echo '
262 273
 										<option value="', $tz, '"', $tz == $context['event']['tz'] ? ' selected' : '', '>', $tzname, '</option>';
274
+			}
263 275
 
264 276
 			echo '
265 277
 									</select>
@@ -325,14 +337,15 @@  discard block
 block discarded – undo
325 337
 									<input type="checkbox" id="poll_change_vote" name="poll_change_vote"', !empty($context['poll']['change_vote']) ? ' checked' : '', ' class="input_check">
326 338
 								</dd>';
327 339
 
328
-		if ($context['poll_options']['guest_vote_enabled'])
329
-			echo '
340
+		if ($context['poll_options']['guest_vote_enabled']) {
341
+					echo '
330 342
 								<dt>
331 343
 									<label for="poll_guest_vote">', $txt['poll_guest_vote'], ':</label>
332 344
 								</dt>
333 345
 								<dd>
334 346
 									<input type="checkbox" id="poll_guest_vote" name="poll_guest_vote"', !empty($context['poll_options']['guest_vote']) ? ' checked' : '', ' class="input_check">
335 347
 								</dd>';
348
+		}
336 349
 
337 350
 		echo '
338 351
 								<dt>
@@ -353,8 +366,8 @@  discard block
 block discarded – undo
353 366
 					', template_control_richedit($context['post_box_name'], 'smileyBox_message', 'bbcBox_message');
354 367
 
355 368
 	// If we're editing and displaying edit details, show a box where they can say why
356
-	if (isset($context['editing']) && $modSettings['show_modify'])
357
-		echo '
369
+	if (isset($context['editing']) && $modSettings['show_modify']) {
370
+			echo '
358 371
 					<dl>
359 372
 						<dt class="clear">
360 373
 							<span id="caption_edit_reason">', $txt['reason_for_edit'], ':</span>
@@ -363,20 +376,23 @@  discard block
 block discarded – undo
363 376
 							<input type="text" name="modify_reason"', isset($context['last_modified_reason']) ? ' value="' . $context['last_modified_reason'] . '"' : '', ' tabindex="', $context['tabindex']++, '" size="80" maxlength="80" class="input_text">
364 377
 						</dd>
365 378
 					</dl>';
379
+	}
366 380
 
367 381
 	// If this message has been edited in the past - display when it was.
368
-	if (isset($context['last_modified']))
369
-		echo '
382
+	if (isset($context['last_modified'])) {
383
+			echo '
370 384
 					<div class="padding smalltext">
371 385
 						', $context['last_modified_text'], '
372 386
 					</div>';
387
+	}
373 388
 
374 389
 	// If the admin has enabled the hiding of the additional options - show a link and image for it.
375
-	if (!empty($modSettings['additional_options_collapsable']))
376
-		echo '
390
+	if (!empty($modSettings['additional_options_collapsable'])) {
391
+			echo '
377 392
 					<div id="postAdditionalOptionsHeader">
378 393
 						<strong><a href="#" id="postMoreExpandLink"> ', $context['can_post_attachment'] ? $txt['post_additionalopt_attach'] : $txt['post_additionalopt'], '</a></strong>
379 394
 					</div>';
395
+	}
380 396
 
381 397
 	echo '
382 398
 					<div id="postAdditionalOptions">';
@@ -408,19 +424,21 @@  discard block
 block discarded – undo
408 424
 								<input type="hidden" name="attach_del[]" value="0">
409 425
 								', $txt['uncheck_unwatchd_attach'], ':
410 426
 							</dd>';
411
-		foreach ($context['current_attachments'] as $attachment)
412
-			echo '
427
+		foreach ($context['current_attachments'] as $attachment) {
428
+					echo '
413 429
 							<dd class="smalltext">
414 430
 								<label for="attachment_', $attachment['attachID'], '"><input type="checkbox" id="attachment_', $attachment['attachID'], '" name="attach_del[]" value="', $attachment['attachID'], '"', empty($attachment['unchecked']) ? ' checked' : '', ' class="input_check"> ', $attachment['name'], (empty($attachment['approved']) ? ' (' . $txt['awaiting_approval'] . ')' : ''),
415 431
 								!empty($modSettings['attachmentPostLimit']) || !empty($modSettings['attachmentSizeLimit']) ? sprintf($txt['attach_kb'], comma_format(round(max($attachment['size'], 1028) / 1028), 0)) : '', '</label>
416 432
 							</dd>';
433
+		}
417 434
 
418 435
 		echo '
419 436
 						</dl>';
420 437
 
421
-		if (!empty($context['files_in_session_warning']))
422
-			echo '
438
+		if (!empty($context['files_in_session_warning'])) {
439
+					echo '
423 440
 						<div class="smalltext">', $context['files_in_session_warning'], '</div>';
441
+		}
424 442
 	}
425 443
 
426 444
 	// Is the user allowed to post any additional ones? If so give them the boxes to do it!
@@ -473,8 +491,8 @@  discard block
 block discarded – undo
473 491
 								', empty($modSettings['attachmentSizeLimit']) ? '' : ('<input type="hidden" name="MAX_FILE_SIZE" value="' . $modSettings['attachmentSizeLimit'] * 1028 . '">');
474 492
 
475 493
 		// Show more boxes if they aren't approaching that limit.
476
-		if ($context['num_allowed_attachments'] > 1)
477
-			echo '
494
+		if ($context['num_allowed_attachments'] > 1) {
495
+					echo '
478 496
 										<script>
479 497
 											var allowed_attachments = ', $context['num_allowed_attachments'], ';
480 498
 											var current_attachment = 1;
@@ -495,9 +513,10 @@  discard block
 block discarded – undo
495 513
 									</div>
496 514
 								</div>
497 515
 							</dd>';
498
-		else
499
-			echo '
516
+		} else {
517
+					echo '
500 518
 							</dd>';
519
+		}
501 520
 
502 521
 		// Add any template changes for an alternative upload system here.
503 522
 		call_integration_hook('integrate_upload_template');
@@ -506,21 +525,25 @@  discard block
 block discarded – undo
506 525
 							<dd class="smalltext">';
507 526
 
508 527
 		// Show some useful information such as allowed extensions, maximum size and amount of attachments allowed.
509
-		if (!empty($modSettings['attachmentCheckExtensions']))
510
-			echo '
528
+		if (!empty($modSettings['attachmentCheckExtensions'])) {
529
+					echo '
511 530
 								', $txt['allowed_types'], ': ', $context['allowed_extensions'], '<br>';
531
+		}
512 532
 
513
-		if (!empty($context['attachment_restrictions']))
514
-			echo '
533
+		if (!empty($context['attachment_restrictions'])) {
534
+					echo '
515 535
 								', $txt['attach_restrictions'], ' ', implode(', ', $context['attachment_restrictions']), '<br>';
536
+		}
516 537
 
517
-		if ($context['num_allowed_attachments'] == 0)
518
-			echo '
538
+		if ($context['num_allowed_attachments'] == 0) {
539
+					echo '
519 540
 								', $txt['attach_limit_nag'], '<br>';
541
+		}
520 542
 
521
-		if (!$context['can_post_attachment_unapproved'])
522
-			echo '
543
+		if (!$context['can_post_attachment_unapproved']) {
544
+					echo '
523 545
 								<span class="alert">', $txt['attachment_requires_approval'], '</span>', '<br>';
546
+		}
524 547
 
525 548
 		echo '
526 549
 							</dd>
@@ -543,10 +566,11 @@  discard block
 block discarded – undo
543 566
 							<dt><strong>', $txt['subject'], '</strong></dt>
544 567
 							<dd><strong>', $txt['draft_saved_on'], '</strong></dd>';
545 568
 
546
-		foreach ($context['drafts'] as $draft)
547
-			echo '
569
+		foreach ($context['drafts'] as $draft) {
570
+					echo '
548 571
 							<dt>', $draft['link'], '</dt>
549 572
 							<dd>', $draft['poster_time'], '</dd>';
573
+		}
550 574
 		echo '
551 575
 						</dl>
552 576
 					</div>';
@@ -571,9 +595,10 @@  discard block
 block discarded – undo
571 595
 						', template_control_richedit_buttons($context['post_box_name']);
572 596
 
573 597
 	// Option to delete an event if user is editing one.
574
-	if ($context['make_event'] && !$context['event']['new'])
575
-		echo '
598
+	if ($context['make_event'] && !$context['event']['new']) {
599
+			echo '
576 600
 						<input type="submit" name="deleteevent" value="', $txt['event_delete'], '" data-confirm="', $txt['event_delete_confirm'] ,'" class="button_submit you_sure">';
601
+	}
577 602
 
578 603
 	echo '
579 604
 					</span>
@@ -582,9 +607,10 @@  discard block
 block discarded – undo
582 607
 			<br class="clear">';
583 608
 
584 609
 	// Assuming this isn't a new topic pass across the last message id.
585
-	if (isset($context['topic_last_message']))
586
-		echo '
610
+	if (isset($context['topic_last_message'])) {
611
+			echo '
587 612
 			<input type="hidden" name="last_msg" value="', $context['topic_last_message'], '">';
613
+	}
588 614
 
589 615
 	echo '
590 616
 			<input type="hidden" name="additional_options" id="additional_options" value="', $context['show_additional_options'] ? '1' : '0', '">
@@ -726,9 +752,10 @@  discard block
 block discarded – undo
726 752
 
727 753
 						newPostsHTML += \'<div class="windowbg\' + (++reply_counter % 2 == 0 ? \'2\' : \'\') + \'"><div id="msg\' + newPosts[i].getAttribute("id") + \'"><div class="floatleft"><h5>', $txt['posted_by'], ': \' + newPosts[i].getElementsByTagName("poster")[0].firstChild.nodeValue + \'</h5><span class="smalltext">&#171;&nbsp;<strong>', $txt['on'], ':</strong> \' + newPosts[i].getElementsByTagName("time")[0].firstChild.nodeValue + \'&nbsp;&#187;</span> <span class="new_posts" id="image_new_\' + newPosts[i].getAttribute("id") + \'">', $txt['new'], '</span></div>\';';
728 754
 
729
-	if ($context['can_quote'])
730
-		echo '
755
+	if ($context['can_quote']) {
756
+			echo '
731 757
 						newPostsHTML += \'<ul class="quickbuttons" id="msg_\' + newPosts[i].getAttribute("id") + \'_quote"><li><a href="#postmodify" onclick="return insertQuoteFast(\\\'\' + newPosts[i].getAttribute("id") + \'\\\');" class="quote_button"><span>', $txt['quote'], '</span><\' + \'/a></li></ul>\';';
758
+	}
732 759
 
733 760
 	echo '
734 761
 						newPostsHTML += \'<br class="clear">\';
@@ -771,8 +798,8 @@  discard block
 block discarded – undo
771 798
 			}';
772 799
 
773 800
 	// Code for showing and hiding additional options.
774
-	if (!empty($modSettings['additional_options_collapsable']))
775
-		echo '
801
+	if (!empty($modSettings['additional_options_collapsable'])) {
802
+			echo '
776 803
 			var oSwapAdditionalOptions = new smc_Toggle({
777 804
 				bToggleEnabled: true,
778 805
 				bCurrentlyCollapsed: ', $context['show_additional_options'] ? 'false' : 'true', ',
@@ -800,10 +827,11 @@  discard block
 block discarded – undo
800 827
 					}
801 828
 				]
802 829
 			});';
830
+	}
803 831
 
804 832
 	// Code for showing and hiding drafts
805
-	if (!empty($context['drafts']))
806
-		echo '
833
+	if (!empty($context['drafts'])) {
834
+			echo '
807 835
 			var oSwapDraftOptions = new smc_Toggle({
808 836
 				bToggleEnabled: true,
809 837
 				bCurrentlyCollapsed: true,
@@ -825,6 +853,7 @@  discard block
 block discarded – undo
825 853
 					}
826 854
 				]
827 855
 			});';
856
+	}
828 857
 
829 858
 	echo '
830 859
 			var oEditorID = "', $context['post_box_name'] ,'";
@@ -845,8 +874,9 @@  discard block
 block discarded – undo
845 874
 		foreach ($context['previous_posts'] as $post)
846 875
 		{
847 876
 			$ignoring = false;
848
-			if (!empty($post['is_ignored']))
849
-				$ignored_posts[] = $ignoring = $post['id'];
877
+			if (!empty($post['is_ignored'])) {
878
+							$ignored_posts[] = $ignoring = $post['id'];
879
+			}
850 880
 
851 881
 			echo '
852 882
 			<div class="windowbg">
@@ -1029,10 +1059,10 @@  discard block
 block discarded – undo
1029 1059
 		<div id="temporary_posting_area" style="display: none;"></div>
1030 1060
 		<script>';
1031 1061
 
1032
-	if ($context['close_window'])
1033
-		echo '
1062
+	if ($context['close_window']) {
1063
+			echo '
1034 1064
 			window.close();';
1035
-	else
1065
+	} else
1036 1066
 	{
1037 1067
 		// Lucky for us, Internet Explorer has an "innerText" feature which basically converts entities <--> text. Use it if possible ;).
1038 1068
 		echo '
@@ -1086,11 +1116,12 @@  discard block
 block discarded – undo
1086 1116
 				</p>
1087 1117
 				<ul>';
1088 1118
 
1089
-	foreach ($context['groups'] as $group)
1090
-		echo '
1119
+	foreach ($context['groups'] as $group) {
1120
+			echo '
1091 1121
 					<li>
1092 1122
 						<label for="who_', $group['id'], '"><input type="checkbox" name="who[', $group['id'], ']" id="who_', $group['id'], '" value="', $group['id'], '" checked class="input_check"> ', $group['name'], '</label> <em>(', $group['member_count'], ')</em>
1093 1123
 					</li>';
1124
+	}
1094 1125
 
1095 1126
 	echo '
1096 1127
 					<li>
Please login to merge, or discard this patch.
index.php 1 patch
Braces   +37 added lines, -25 removed lines patch added patch discarded remove patch
@@ -25,8 +25,9 @@  discard block
 block discarded – undo
25 25
 
26 26
 // Get everything started up...
27 27
 define('SMF', 1);
28
-if (function_exists('set_magic_quotes_runtime') && strnatcmp(phpversion(), '5.3.0') < 0)
28
+if (function_exists('set_magic_quotes_runtime') && strnatcmp(phpversion(), '5.3.0') < 0) {
29 29
 	@set_magic_quotes_runtime(0);
30
+}
30 31
 error_reporting(defined('E_STRICT') ? E_ALL | E_STRICT : E_ALL);
31 32
 $time_start = microtime();
32 33
 
@@ -34,16 +35,18 @@  discard block
 block discarded – undo
34 35
 ob_start();
35 36
 
36 37
 // Do some cleaning, just in case.
37
-foreach (array('db_character_set', 'cachedir') as $variable)
38
+foreach (array('db_character_set', 'cachedir') as $variable) {
38 39
 	if (isset($GLOBALS[$variable]))
39 40
 		unset($GLOBALS[$variable], $GLOBALS[$variable]);
41
+}
40 42
 
41 43
 // Load the settings...
42 44
 require_once(dirname(__FILE__) . '/Settings.php');
43 45
 
44 46
 // Make absolutely sure the cache directory is defined.
45
-if ((empty($cachedir) || !file_exists($cachedir)) && file_exists($boarddir . '/cache'))
47
+if ((empty($cachedir) || !file_exists($cachedir)) && file_exists($boarddir . '/cache')) {
46 48
 	$cachedir = $boarddir . '/cache';
49
+}
47 50
 
48 51
 // Without those we can't go anywhere
49 52
 require_once($sourcedir . '/QueryString.php');
@@ -53,8 +56,9 @@  discard block
 block discarded – undo
53 56
 require_once($sourcedir . '/Load.php');
54 57
 
55 58
 // If $maintenance is set specifically to 2, then we're upgrading or something.
56
-if (!empty($maintenance) && $maintenance == 2)
59
+if (!empty($maintenance) && $maintenance == 2) {
57 60
 	display_maintenance_message();
61
+}
58 62
 
59 63
 // Create a variable to store some SMF specific functions in.
60 64
 $smcFunc = array();
@@ -69,8 +73,9 @@  discard block
 block discarded – undo
69 73
 cleanRequest();
70 74
 
71 75
 // Seed the random generator.
72
-if (empty($modSettings['rand_seed']) || mt_rand(1, 250) == 69)
76
+if (empty($modSettings['rand_seed']) || mt_rand(1, 250) == 69) {
73 77
 	smf_seed_generator();
78
+}
74 79
 
75 80
 // Before we get carried away, are we doing a scheduled task? If so save CPU cycles by jumping out!
76 81
 if (isset($_GET['scheduled']))
@@ -90,9 +95,9 @@  discard block
 block discarded – undo
90 95
 if (!empty($modSettings['enableCompressedOutput']) && !headers_sent())
91 96
 {
92 97
 	// If zlib is being used, turn off output compression.
93
-	if (ini_get('zlib.output_compression') >= 1 || ini_get('output_handler') == 'ob_gzhandler')
94
-		$modSettings['enableCompressedOutput'] = '0';
95
-	else
98
+	if (ini_get('zlib.output_compression') >= 1 || ini_get('output_handler') == 'ob_gzhandler') {
99
+			$modSettings['enableCompressedOutput'] = '0';
100
+	} else
96 101
 	{
97 102
 		ob_end_clean();
98 103
 		ob_start('ob_gzhandler');
@@ -141,18 +146,21 @@  discard block
 block discarded – undo
141 146
 	loadPermissions();
142 147
 
143 148
 	// Attachments don't require the entire theme to be loaded.
144
-	if (isset($_REQUEST['action']) && $_REQUEST['action'] == 'dlattach')
145
-		detectBrowser();
149
+	if (isset($_REQUEST['action']) && $_REQUEST['action'] == 'dlattach') {
150
+			detectBrowser();
151
+	}
146 152
 	// Load the current theme.  (note that ?theme=1 will also work, may be used for guest theming.)
147
-	else
148
-		loadTheme();
153
+	else {
154
+			loadTheme();
155
+	}
149 156
 
150 157
 	// Check if the user should be disallowed access.
151 158
 	is_not_banned();
152 159
 
153 160
 	// If we are in a topic and don't have permission to approve it then duck out now.
154
-	if (!empty($topic) && empty($board_info['cur_topic_approved']) && !allowedTo('approve_posts') && ($user_info['id'] != $board_info['cur_topic_starter'] || $user_info['is_guest']))
155
-		fatal_lang_error('not_a_topic', false);
161
+	if (!empty($topic) && empty($board_info['cur_topic_approved']) && !allowedTo('approve_posts') && ($user_info['id'] != $board_info['cur_topic_starter'] || $user_info['is_guest'])) {
162
+			fatal_lang_error('not_a_topic', false);
163
+	}
156 164
 
157 165
 	$no_stat_actions = array('clock', 'dlattach', 'findmember', 'jsoption', 'likes', 'loadeditorlocale', 'modifycat', 'requestmembers', 'smstats', 'suggest', 'about:unknown', '.xml', 'xmlhttp', 'verificationcode', 'viewquery', 'viewsmfile');
158 166
 	call_integration_hook('integrate_pre_log_stats', array(&$no_stat_actions));
@@ -163,8 +171,9 @@  discard block
 block discarded – undo
163 171
 		writeLog();
164 172
 
165 173
 		// Track forum statistics and hits...?
166
-		if (!empty($modSettings['hitStats']))
167
-			trackStats(array('hits' => '+'));
174
+		if (!empty($modSettings['hitStats'])) {
175
+					trackStats(array('hits' => '+'));
176
+		}
168 177
 	}
169 178
 	unset($no_stat_actions);
170 179
 
@@ -178,13 +187,14 @@  discard block
 block discarded – undo
178 187
 			return ($_REQUEST['action'] == 'login2' ? 'Login2' : ($_REQUEST['action'] == 'logintfa' ? 'LoginTFA' : 'Logout'));
179 188
 		}
180 189
 		// Don't even try it, sonny.
181
-		else
182
-			return 'InMaintenance';
190
+		else {
191
+					return 'InMaintenance';
192
+		}
183 193
 	}
184 194
 	// If guest access is off, a guest can only do one of the very few following actions.
185
-	elseif (empty($modSettings['allow_guestAccess']) && $user_info['is_guest'] && (!isset($_REQUEST['action']) || !in_array($_REQUEST['action'], array('coppa', 'login', 'login2', 'logintfa', 'reminder', 'activate', 'help', 'helpadmin', 'smstats', 'verificationcode', 'signup', 'signup2'))))
186
-		return 'KickGuest';
187
-	elseif (empty($_REQUEST['action']))
195
+	elseif (empty($modSettings['allow_guestAccess']) && $user_info['is_guest'] && (!isset($_REQUEST['action']) || !in_array($_REQUEST['action'], array('coppa', 'login', 'login2', 'logintfa', 'reminder', 'activate', 'help', 'helpadmin', 'smstats', 'verificationcode', 'signup', 'signup2')))) {
196
+			return 'KickGuest';
197
+	} elseif (empty($_REQUEST['action']))
188 198
 	{
189 199
 		// Action and board are both empty... BoardIndex! Unless someone else wants to do something different.
190 200
 		if (empty($board) && empty($topic))
@@ -200,8 +210,9 @@  discard block
 block discarded – undo
200 210
 
201 211
 				$call = call_helper($defaultAction, true);
202 212
 
203
-				if (!empty($call))
204
-					return $call;
213
+				if (!empty($call)) {
214
+									return $call;
215
+				}
205 216
 			}
206 217
 
207 218
 			// No default action huh? then go to our good old BoardIndex.
@@ -331,8 +342,9 @@  discard block
 block discarded – undo
331 342
 
332 343
 			$call = call_helper($fallbackAction, true);
333 344
 
334
-			if (!empty($call))
335
-				return $call;
345
+			if (!empty($call)) {
346
+							return $call;
347
+			}
336 348
 		}
337 349
 
338 350
 		// No fallback action, huh?
Please login to merge, or discard this patch.
Themes/default/GenericMenu.template.php 1 patch
Braces   +50 added lines, -37 removed lines patch added patch discarded remove patch
@@ -89,8 +89,9 @@  discard block
 block discarded – undo
89 89
 		foreach ($section['areas'] as $i => $area)
90 90
 		{
91 91
 			// Not supposed to be printed?
92
-			if (empty($area['label']))
93
-				continue;
92
+			if (empty($area['label'])) {
93
+							continue;
94
+			}
94 95
 
95 96
 			echo '
96 97
 								<li', !empty($area['subsections']) ? ' class="subsections"' : '', '>';
@@ -99,8 +100,9 @@  discard block
 block discarded – undo
99 100
 									<a class="', $area['icon_class'], !empty($area['selected']) ? ' chosen ' : '', '" href="', (isset($area['url']) ? $area['url'] : $menu_context['base_url'] . ';area=' . $i), $menu_context['extra_parameters'], '">', $area['icon'], $area['label'], '</a>';
100 101
 
101 102
 			// Is this the current area, or just some area?
102
-			if (!empty($area['selected']) && empty($context['tabs']))
103
-					$context['tabs'] = isset($area['subsections']) ? $area['subsections'] : array();
103
+			if (!empty($area['selected']) && empty($context['tabs'])) {
104
+								$context['tabs'] = isset($area['subsections']) ? $area['subsections'] : array();
105
+			}
104 106
 
105 107
 			// Are there any subsections?
106 108
 			if (!empty($area['subsections']))
@@ -110,8 +112,9 @@  discard block
 block discarded – undo
110 112
 
111 113
 				foreach ($area['subsections'] as $sa => $sub)
112 114
 				{
113
-					if (!empty($sub['disabled']))
114
-						continue;
115
+					if (!empty($sub['disabled'])) {
116
+											continue;
117
+					}
115 118
 
116 119
 					$url = isset($sub['url']) ? $sub['url'] : (isset($area['url']) ? $area['url'] : $menu_context['base_url'] . ';area=' . $i) . ';sa=' . $sa;
117 120
 
@@ -158,8 +161,9 @@  discard block
 block discarded – undo
158 161
 							<h3 class="catbg">';
159 162
 
160 163
 		// The function is in Admin.template.php, but since this template is used elsewhere too better check if the function is available
161
-		if (function_exists('template_admin_quick_search'))
162
-			template_admin_quick_search();
164
+		if (function_exists('template_admin_quick_search')) {
165
+					template_admin_quick_search();
166
+		}
163 167
 
164 168
 		// Exactly how many tabs do we have?
165 169
 		if (!empty($context['tabs']))
@@ -174,30 +178,36 @@  discard block
 block discarded – undo
174 178
 				}
175 179
 
176 180
 				// Did this not even exist - or do we not have a label?
177
-				if (!isset($tab_context['tabs'][$id]))
178
-					$tab_context['tabs'][$id] = array('label' => $tab['label']);
179
-				elseif (!isset($tab_context['tabs'][$id]['label']))
180
-					$tab_context['tabs'][$id]['label'] = $tab['label'];
181
+				if (!isset($tab_context['tabs'][$id])) {
182
+									$tab_context['tabs'][$id] = array('label' => $tab['label']);
183
+				} elseif (!isset($tab_context['tabs'][$id]['label'])) {
184
+									$tab_context['tabs'][$id]['label'] = $tab['label'];
185
+				}
181 186
 
182 187
 				// Has a custom URL defined in the main admin structure?
183
-				if (isset($tab['url']) && !isset($tab_context['tabs'][$id]['url']))
184
-					$tab_context['tabs'][$id]['url'] = $tab['url'];
188
+				if (isset($tab['url']) && !isset($tab_context['tabs'][$id]['url'])) {
189
+									$tab_context['tabs'][$id]['url'] = $tab['url'];
190
+				}
185 191
 
186 192
 				// Any additional paramaters for the url?
187
-				if (isset($tab['add_params']) && !isset($tab_context['tabs'][$id]['add_params']))
188
-					$tab_context['tabs'][$id]['add_params'] = $tab['add_params'];
193
+				if (isset($tab['add_params']) && !isset($tab_context['tabs'][$id]['add_params'])) {
194
+									$tab_context['tabs'][$id]['add_params'] = $tab['add_params'];
195
+				}
189 196
 
190 197
 				// Has it been deemed selected?
191
-				if (!empty($tab['is_selected']))
192
-					$tab_context['tabs'][$id]['is_selected'] = true;
198
+				if (!empty($tab['is_selected'])) {
199
+									$tab_context['tabs'][$id]['is_selected'] = true;
200
+				}
193 201
 
194 202
 				// Does it have its own help?
195
-				if (!empty($tab['help']))
196
-					$tab_context['tabs'][$id]['help'] = $tab['help'];
203
+				if (!empty($tab['help'])) {
204
+									$tab_context['tabs'][$id]['help'] = $tab['help'];
205
+				}
197 206
 
198 207
 				// Is this the last one?
199
-				if (!empty($tab['is_last']) && !isset($tab_context['override_last']))
200
-					$tab_context['tabs'][$id]['is_last'] = true;
208
+				if (!empty($tab['is_last']) && !isset($tab_context['override_last'])) {
209
+									$tab_context['tabs'][$id]['is_last'] = true;
210
+				}
201 211
 			}
202 212
 
203 213
 			// Find the selected tab
@@ -214,17 +224,18 @@  discard block
 block discarded – undo
214 224
 		// Show an icon and/or a help item?
215 225
 		if (!empty($selected_tab['icon_class']) || !empty($tab_context['icon_class']) || !empty($selected_tab['icon']) || !empty($tab_context['icon']) || !empty($selected_tab['help']) || !empty($tab_context['help']))
216 226
 		{
217
-			if (!empty($selected_tab['icon_class']) || !empty($tab_context['icon_class']))
218
-				echo '<span class="', !empty($selected_tab['icon_class']) ? $selected_tab['icon_class'] : $tab_context['icon_class'], ' icon"></span>';
219
-			elseif (!empty($selected_tab['icon']) || !empty($tab_context['icon']))
220
-				echo '<img src="', $settings['images_url'], '/icons/', !empty($selected_tab['icon']) ? $selected_tab['icon'] : $tab_context['icon'], '" alt="" class="icon">';
227
+			if (!empty($selected_tab['icon_class']) || !empty($tab_context['icon_class'])) {
228
+							echo '<span class="', !empty($selected_tab['icon_class']) ? $selected_tab['icon_class'] : $tab_context['icon_class'], ' icon"></span>';
229
+			} elseif (!empty($selected_tab['icon']) || !empty($tab_context['icon'])) {
230
+							echo '<img src="', $settings['images_url'], '/icons/', !empty($selected_tab['icon']) ? $selected_tab['icon'] : $tab_context['icon'], '" alt="" class="icon">';
231
+			}
221 232
 
222
-			if (!empty($selected_tab['help']) || !empty($tab_context['help']))
223
-				echo '<a href="', $scripturl, '?action=helpadmin;help=', !empty($selected_tab['help']) ? $selected_tab['help'] : $tab_context['help'], '" onclick="return reqOverlayDiv(this.href);" class="help"><span class="generic_icons help" title="', $txt['help'], '"></span></a>';
233
+			if (!empty($selected_tab['help']) || !empty($tab_context['help'])) {
234
+							echo '<a href="', $scripturl, '?action=helpadmin;help=', !empty($selected_tab['help']) ? $selected_tab['help'] : $tab_context['help'], '" onclick="return reqOverlayDiv(this.href);" class="help"><span class="generic_icons help" title="', $txt['help'], '"></span></a>';
235
+			}
224 236
 
225 237
 			echo $tab_context['title'];
226
-		}
227
-		else
238
+		} else
228 239
 		{
229 240
 			echo '
230 241
 							', $tab_context['title'];
@@ -237,11 +248,12 @@  discard block
 block discarded – undo
237 248
 	}
238 249
 
239 250
 	// Shall we use the tabs? Yes, it's the only known way!
240
-	if (!empty($selected_tab['description']) || !empty($tab_context['description']))
241
-		echo '
251
+	if (!empty($selected_tab['description']) || !empty($tab_context['description'])) {
252
+			echo '
242 253
 					<p class="information">
243 254
 						', !empty($selected_tab['description']) ? $selected_tab['description'] : $tab_context['description'], '
244 255
 					</p>';
256
+	}
245 257
 
246 258
 	// Print out all the items in this tab (if any).
247 259
 	if (!empty($context['tabs']))
@@ -253,8 +265,9 @@  discard block
 block discarded – undo
253 265
 
254 266
 		foreach ($tab_context['tabs'] as $sa => $tab)
255 267
 		{
256
-			if (!empty($tab['disabled']))
257
-				continue;
268
+			if (!empty($tab['disabled'])) {
269
+							continue;
270
+			}
258 271
 
259 272
 			if (!empty($tab['is_selected']))
260 273
 			{
@@ -262,12 +275,12 @@  discard block
 block discarded – undo
262 275
 							<li>
263 276
 								<a class="active" href="', isset($tab['url']) ? $tab['url'] : $menu_context['base_url'] . ';area=' . $menu_context['current_area'] . ';sa=' . $sa, $menu_context['extra_parameters'], isset($tab['add_params']) ? $tab['add_params'] : '', '">', $tab['label'], '</a>
264 277
 							</li>';
265
-			}
266
-			else
267
-				echo '
278
+			} else {
279
+							echo '
268 280
 							<li>
269 281
 								<a href="', isset($tab['url']) ? $tab['url'] : $menu_context['base_url'] . ';area=' . $menu_context['current_area'] . ';sa=' . $sa, $menu_context['extra_parameters'], isset($tab['add_params']) ? $tab['add_params'] : '', '">', $tab['label'], '</a>
270 282
 							</li>';
283
+			}
271 284
 		}
272 285
 
273 286
 		// the end of tabs
Please login to merge, or discard this patch.
Sources/Groups.php 1 patch
Braces   +80 added lines, -59 removed lines patch added patch discarded remove patch
@@ -13,8 +13,9 @@  discard block
 block discarded – undo
13 13
  * @version 2.1 Beta 3
14 14
  */
15 15
 
16
-if (!defined('SMF'))
16
+if (!defined('SMF')) {
17 17
 	die('No direct access...');
18
+}
18 19
 
19 20
 /**
20 21
  * Entry point function, permission checks, admin bars, etc.
@@ -99,27 +100,27 @@  discard block
 block discarded – undo
99 100
 					'function' => function($rowData) use ($scripturl)
100 101
 					{
101 102
 						// Since the moderator group has no explicit members, no link is needed.
102
-						if ($rowData['id_group'] == 3)
103
-							$group_name = $rowData['group_name'];
104
-						else
103
+						if ($rowData['id_group'] == 3) {
104
+													$group_name = $rowData['group_name'];
105
+						} else
105 106
 						{
106 107
 							$color_style = empty($rowData['online_color']) ? '' : sprintf(' style="color: %1$s;"', $rowData['online_color']);
107 108
 
108 109
 							if (allowedTo('manage_membergroups'))
109 110
 							{
110 111
 								$group_name = sprintf('<a href="%1$s?action=admin;area=membergroups;sa=members;group=%2$d"%3$s>%4$s</a>', $scripturl, $rowData['id_group'], $color_style, $rowData['group_name']);
111
-							}
112
-							else
112
+							} else
113 113
 							{
114 114
 								$group_name = sprintf('<a href="%1$s?action=groups;sa=members;group=%2$d"%3$s>%4$s</a>', $scripturl, $rowData['id_group'], $color_style, $rowData['group_name']);
115 115
 							}
116 116
 						}
117 117
 
118 118
 						// Add a help option for moderator and administrator.
119
-						if ($rowData['id_group'] == 1)
120
-							$group_name .= sprintf(' (<a href="%1$s?action=helpadmin;help=membergroup_administrator" onclick="return reqOverlayDiv(this.href);">?</a>)', $scripturl);
121
-						elseif ($rowData['id_group'] == 3)
122
-							$group_name .= sprintf(' (<a href="%1$s?action=helpadmin;help=membergroup_moderator" onclick="return reqOverlayDiv(this.href);">?</a>)', $scripturl);
119
+						if ($rowData['id_group'] == 1) {
120
+													$group_name .= sprintf(' (<a href="%1$s?action=helpadmin;help=membergroup_administrator" onclick="return reqOverlayDiv(this.href);">?</a>)', $scripturl);
121
+						} elseif ($rowData['id_group'] == 3) {
122
+													$group_name .= sprintf(' (<a href="%1$s?action=helpadmin;help=membergroup_moderator" onclick="return reqOverlayDiv(this.href);">?</a>)', $scripturl);
123
+						}
123 124
 
124 125
 						return $group_name;
125 126
 					},
@@ -198,8 +199,9 @@  discard block
 block discarded – undo
198 199
 	$_REQUEST['group'] = isset($_REQUEST['group']) ? (int) $_REQUEST['group'] : 0;
199 200
 
200 201
 	// No browsing of guests, membergroup 0 or moderators.
201
-	if (in_array($_REQUEST['group'], array(-1, 0, 3)))
202
-		fatal_lang_error('membergroup_does_not_exist', false);
202
+	if (in_array($_REQUEST['group'], array(-1, 0, 3))) {
203
+			fatal_lang_error('membergroup_does_not_exist', false);
204
+	}
203 205
 
204 206
 	// Load up the group details.
205 207
 	$request = $smcFunc['db_query']('', '
@@ -214,8 +216,9 @@  discard block
 block discarded – undo
214 216
 		)
215 217
 	);
216 218
 	// Doesn't exist?
217
-	if ($smcFunc['db_num_rows']($request) == 0)
218
-		fatal_lang_error('membergroup_does_not_exist', false);
219
+	if ($smcFunc['db_num_rows']($request) == 0) {
220
+			fatal_lang_error('membergroup_does_not_exist', false);
221
+	}
219 222
 	$context['group'] = $smcFunc['db_fetch_assoc']($request);
220 223
 	$smcFunc['db_free_result']($request);
221 224
 
@@ -248,21 +251,25 @@  discard block
 block discarded – undo
248 251
 			'name' => $row['real_name']
249 252
 		);
250 253
 
251
-		if ($user_info['id'] == $row['id_member'] && $context['group']['group_type'] != 1)
252
-			$context['group']['can_moderate'] = true;
254
+		if ($user_info['id'] == $row['id_member'] && $context['group']['group_type'] != 1) {
255
+					$context['group']['can_moderate'] = true;
256
+		}
253 257
 	}
254 258
 	$smcFunc['db_free_result']($request);
255 259
 
256 260
 	// If this group is hidden then it can only "exists" if the user can moderate it!
257
-	if ($context['group']['hidden'] && !$context['group']['can_moderate'])
258
-		fatal_lang_error('membergroup_does_not_exist', false);
261
+	if ($context['group']['hidden'] && !$context['group']['can_moderate']) {
262
+			fatal_lang_error('membergroup_does_not_exist', false);
263
+	}
259 264
 
260 265
 	// You can only assign membership if you are the moderator and/or can manage groups!
261
-	if (!$context['group']['can_moderate'])
262
-		$context['group']['assignable'] = 0;
266
+	if (!$context['group']['can_moderate']) {
267
+			$context['group']['assignable'] = 0;
268
+	}
263 269
 	// Non-admins cannot assign admins.
264
-	elseif ($context['group']['id'] == 1 && !allowedTo('admin_forum'))
265
-		$context['group']['assignable'] = 0;
270
+	elseif ($context['group']['id'] == 1 && !allowedTo('admin_forum')) {
271
+			$context['group']['assignable'] = 0;
272
+	}
266 273
 
267 274
 	// Removing member from group?
268 275
 	if (isset($_POST['remove']) && !empty($_REQUEST['rem']) && is_array($_REQUEST['rem']) && $context['group']['assignable'])
@@ -271,8 +278,9 @@  discard block
 block discarded – undo
271 278
 		validateToken('mod-mgm');
272 279
 
273 280
 		// Make sure we're dealing with integers only.
274
-		foreach ($_REQUEST['rem'] as $key => $group)
275
-			$_REQUEST['rem'][$key] = (int) $group;
281
+		foreach ($_REQUEST['rem'] as $key => $group) {
282
+					$_REQUEST['rem'][$key] = (int) $group;
283
+		}
276 284
 
277 285
 		require_once($sourcedir . '/Subs-Membergroups.php');
278 286
 		removeMembersFromGroups($_REQUEST['rem'], $_REQUEST['group'], true);
@@ -295,16 +303,18 @@  discard block
 block discarded – undo
295 303
 		{
296 304
 			$member_names[$index] = trim($smcFunc['strtolower']($member_names[$index]));
297 305
 
298
-			if (strlen($member_names[$index]) == 0)
299
-				unset($member_names[$index]);
306
+			if (strlen($member_names[$index]) == 0) {
307
+							unset($member_names[$index]);
308
+			}
300 309
 		}
301 310
 
302 311
 		// Any passed by ID?
303 312
 		$member_ids = array();
304
-		if (!empty($_REQUEST['member_add']))
305
-			foreach ($_REQUEST['member_add'] as $id)
313
+		if (!empty($_REQUEST['member_add'])) {
314
+					foreach ($_REQUEST['member_add'] as $id)
306 315
 				if ($id > 0)
307 316
 					$member_ids[] = (int) $id;
317
+		}
308 318
 
309 319
 		// Construct the query pelements.
310 320
 		if (!empty($member_ids))
@@ -332,8 +342,9 @@  discard block
 block discarded – undo
332 342
 					'id_group' => $_REQUEST['group'],
333 343
 				))
334 344
 			);
335
-			while ($row = $smcFunc['db_fetch_assoc']($request))
336
-				$members[] = $row['id_member'];
345
+			while ($row = $smcFunc['db_fetch_assoc']($request)) {
346
+							$members[] = $row['id_member'];
347
+			}
337 348
 			$smcFunc['db_free_result']($request);
338 349
 		}
339 350
 
@@ -372,10 +383,11 @@  discard block
 block discarded – undo
372 383
 	$context['sort_direction'] = isset($_REQUEST['desc']) ? 'down' : 'up';
373 384
 
374 385
 	// The where on the query is interesting. Non-moderators should only see people who are in this group as primary.
375
-	if ($context['group']['can_moderate'])
376
-		$where = $context['group']['is_post_group'] ? 'id_post_group = {int:group}' : 'id_group = {int:group} OR FIND_IN_SET({int:group}, additional_groups) != 0';
377
-	else
378
-		$where = $context['group']['is_post_group'] ? 'id_post_group = {int:group}' : 'id_group = {int:group}';
386
+	if ($context['group']['can_moderate']) {
387
+			$where = $context['group']['is_post_group'] ? 'id_post_group = {int:group}' : 'id_group = {int:group} OR FIND_IN_SET({int:group}, additional_groups) != 0';
388
+	} else {
389
+			$where = $context['group']['is_post_group'] ? 'id_post_group = {int:group}' : 'id_group = {int:group}';
390
+	}
379 391
 
380 392
 	// Count members of the group.
381 393
 	$request = $smcFunc['db_query']('', '
@@ -416,8 +428,9 @@  discard block
 block discarded – undo
416 428
 		$last_online = empty($row['last_login']) ? $txt['never'] : timeformat($row['last_login']);
417 429
 
418 430
 		// Italicize the online note if they aren't activated.
419
-		if ($row['is_activated'] % 10 != 1)
420
-			$last_online = '<em title="' . $txt['not_activated'] . '">' . $last_online . '</em>';
431
+		if ($row['is_activated'] % 10 != 1) {
432
+					$last_online = '<em title="' . $txt['not_activated'] . '">' . $last_online . '</em>';
433
+		}
421 434
 
422 435
 		$context['members'][] = array(
423 436
 			'id' => $row['id_member'],
@@ -437,9 +450,10 @@  discard block
 block discarded – undo
437 450
 	$context['page_title'] = $txt['membergroups_members_title'] . ': ' . $context['group']['name'];
438 451
 	createToken('mod-mgm');
439 452
 
440
-	if ($context['group']['assignable'])
441
-		loadJavaScriptFile('suggest.js', array('defer' => false), 'smf_suggest');
442
-}
453
+	if ($context['group']['assignable']) {
454
+			loadJavaScriptFile('suggest.js', array('defer' => false), 'smf_suggest');
455
+	}
456
+	}
443 457
 
444 458
 /**
445 459
  * Show and manage all group requests.
@@ -453,16 +467,18 @@  discard block
 block discarded – undo
453 467
 	$context['sub_template'] = 'show_list';
454 468
 
455 469
 	// Verify we can be here.
456
-	if ($user_info['mod_cache']['gq'] == '0=1')
457
-		isAllowedTo('manage_membergroups');
470
+	if ($user_info['mod_cache']['gq'] == '0=1') {
471
+			isAllowedTo('manage_membergroups');
472
+	}
458 473
 
459 474
 	// Normally, we act normally...
460 475
 	$where = ($user_info['mod_cache']['gq'] == '1=1' || $user_info['mod_cache']['gq'] == '0=1' ? $user_info['mod_cache']['gq'] : 'lgr.' . $user_info['mod_cache']['gq']);
461 476
 
462
-	if (isset($_GET['closed']))
463
-		$where .= ' AND lgr.status != {int:status_open}';
464
-	else
465
-		$where .= ' AND lgr.status = {int:status_open}';
477
+	if (isset($_GET['closed'])) {
478
+			$where .= ' AND lgr.status != {int:status_open}';
479
+	} else {
480
+			$where .= ' AND lgr.status = {int:status_open}';
481
+	}
466 482
 
467 483
 	$where_parameters = array(
468 484
 		'status_open' => 0,
@@ -475,8 +491,9 @@  discard block
 block discarded – undo
475 491
 		validateToken('mod-gr');
476 492
 
477 493
 		// Clean the values.
478
-		foreach ($_POST['groupr'] as $k => $request)
479
-			$_POST['groupr'][$k] = (int) $request;
494
+		foreach ($_POST['groupr'] as $k => $request) {
495
+					$_POST['groupr'][$k] = (int) $request;
496
+		}
480 497
 
481 498
 		$log_changes = array();
482 499
 
@@ -513,8 +530,8 @@  discard block
 block discarded – undo
513 530
 			$request_list = array();
514 531
 			while ($row = $smcFunc['db_fetch_assoc']($request))
515 532
 			{
516
-				if (!isset($log_changes[$row['id_request']]))
517
-					$log_changes[$row['id_request']] = array(
533
+				if (!isset($log_changes[$row['id_request']])) {
534
+									$log_changes[$row['id_request']] = array(
518 535
 						'id_request' => $row['id_request'],
519 536
 						'status' => $_POST['req_action'] == 'approve' ? 1 : 2, // 1 = approved, 2 = rejected
520 537
 						'id_member_acted' => $user_info['id'],
@@ -522,6 +539,7 @@  discard block
 block discarded – undo
522 539
 						'time_acted' => time(),
523 540
 						'act_reason' => $_POST['req_action'] != 'approve' && !empty($_POST['groupreason']) && !empty($_POST['groupreason'][$row['id_request']]) ? $smcFunc['htmlspecialchars']($_POST['groupreason'][$row['id_request']], ENT_QUOTES) : '',
524 541
 					);
542
+				}
525 543
 				$request_list[] = $row['id_request'];
526 544
 			}
527 545
 			$smcFunc['db_free_result']($request);
@@ -744,21 +762,24 @@  discard block
 block discarded – undo
744 762
 	$group_requests = array();
745 763
 	while ($row = $smcFunc['db_fetch_assoc']($request))
746 764
 	{
747
-		if (empty($row['reason']))
748
-			$reason = '<em>(' . $txt['mc_groupr_no_reason'] . ')</em>';
749
-		else
750
-			$reason = censorText($row['reason']);
765
+		if (empty($row['reason'])) {
766
+					$reason = '<em>(' . $txt['mc_groupr_no_reason'] . ')</em>';
767
+		} else {
768
+					$reason = censorText($row['reason']);
769
+		}
751 770
 
752 771
 		if (isset($_GET['closed']))
753 772
 		{
754
-			if ($row['status'] == 1)
755
-				$reason .= '<br><br><strong>' . $txt['mc_groupr_approved'] . '</strong>';
756
-			elseif ($row['status'] == 2)
757
-				$reason .= '<br><br><strong>' . $txt['mc_groupr_rejected'] . '</strong>';
773
+			if ($row['status'] == 1) {
774
+							$reason .= '<br><br><strong>' . $txt['mc_groupr_approved'] . '</strong>';
775
+			} elseif ($row['status'] == 2) {
776
+							$reason .= '<br><br><strong>' . $txt['mc_groupr_rejected'] . '</strong>';
777
+			}
758 778
 
759 779
 				$reason .= ' (' . timeformat($row['time_acted']) . ')';
760
-			if (!empty($row['act_reason']))
761
-				$reason .= '<br><br>' . censorText($row['act_reason']);
780
+			if (!empty($row['act_reason'])) {
781
+							$reason .= '<br><br>' . censorText($row['act_reason']);
782
+			}
762 783
 		}
763 784
 
764 785
 		$group_requests[] = array(
Please login to merge, or discard this patch.
Sources/Post.php 1 patch
Braces   +664 added lines, -515 removed lines patch added patch discarded remove patch
@@ -14,8 +14,9 @@  discard block
 block discarded – undo
14 14
  * @version 2.1 Beta 3
15 15
  */
16 16
 
17
-if (!defined('SMF'))
17
+if (!defined('SMF')) {
18 18
 	die('No direct access...');
19
+}
19 20
 
20 21
 /**
21 22
  * Handles showing the post screen, loading the post to be modified, and loading any post quoted.
@@ -35,12 +36,14 @@  discard block
 block discarded – undo
35 36
 	global $sourcedir, $smcFunc, $language;
36 37
 
37 38
 	loadLanguage('Post');
38
-	if (!empty($modSettings['drafts_post_enabled']))
39
-		loadLanguage('Drafts');
39
+	if (!empty($modSettings['drafts_post_enabled'])) {
40
+			loadLanguage('Drafts');
41
+	}
40 42
 
41 43
 	// You can't reply with a poll... hacker.
42
-	if (isset($_REQUEST['poll']) && !empty($topic) && !isset($_REQUEST['msg']))
43
-		unset($_REQUEST['poll']);
44
+	if (isset($_REQUEST['poll']) && !empty($topic) && !isset($_REQUEST['msg'])) {
45
+			unset($_REQUEST['poll']);
46
+	}
44 47
 
45 48
 	// Posting an event?
46 49
 	$context['make_event'] = isset($_REQUEST['calendar']);
@@ -55,8 +58,9 @@  discard block
 block discarded – undo
55 58
 	$context['auto_notify'] = !empty($context['notify_prefs']['msg_auto_notify']);
56 59
 
57 60
 	// You must be posting to *some* board.
58
-	if (empty($board) && !$context['make_event'])
59
-		fatal_lang_error('no_board', false);
61
+	if (empty($board) && !$context['make_event']) {
62
+			fatal_lang_error('no_board', false);
63
+	}
60 64
 
61 65
 	require_once($sourcedir . '/Subs-Post.php');
62 66
 
@@ -79,10 +83,11 @@  discard block
 block discarded – undo
79 83
 			array(
80 84
 				'msg' => (int) $_REQUEST['msg'],
81 85
 		));
82
-		if ($smcFunc['db_num_rows']($request) != 1)
83
-			unset($_REQUEST['msg'], $_POST['msg'], $_GET['msg']);
84
-		else
85
-			list ($topic) = $smcFunc['db_fetch_row']($request);
86
+		if ($smcFunc['db_num_rows']($request) != 1) {
87
+					unset($_REQUEST['msg'], $_POST['msg'], $_GET['msg']);
88
+		} else {
89
+					list ($topic) = $smcFunc['db_fetch_row']($request);
90
+		}
86 91
 		$smcFunc['db_free_result']($request);
87 92
 	}
88 93
 
@@ -109,33 +114,36 @@  discard block
 block discarded – undo
109 114
 		$smcFunc['db_free_result']($request);
110 115
 
111 116
 		// If this topic already has a poll, they sure can't add another.
112
-		if (isset($_REQUEST['poll']) && $pollID > 0)
113
-			unset($_REQUEST['poll']);
117
+		if (isset($_REQUEST['poll']) && $pollID > 0) {
118
+					unset($_REQUEST['poll']);
119
+		}
114 120
 
115 121
 		if (empty($_REQUEST['msg']))
116 122
 		{
117
-			if ($user_info['is_guest'] && !allowedTo('post_reply_any') && (!$modSettings['postmod_active'] || !allowedTo('post_unapproved_replies_any')))
118
-				is_not_guest();
123
+			if ($user_info['is_guest'] && !allowedTo('post_reply_any') && (!$modSettings['postmod_active'] || !allowedTo('post_unapproved_replies_any'))) {
124
+							is_not_guest();
125
+			}
119 126
 
120 127
 			// By default the reply will be approved...
121 128
 			$context['becomes_approved'] = true;
122 129
 			if ($id_member_poster != $user_info['id'] || $user_info['is_guest'])
123 130
 			{
124
-				if ($modSettings['postmod_active'] && allowedTo('post_unapproved_replies_any') && !allowedTo('post_reply_any'))
125
-					$context['becomes_approved'] = false;
126
-				else
127
-					isAllowedTo('post_reply_any');
128
-			}
129
-			elseif (!allowedTo('post_reply_any'))
131
+				if ($modSettings['postmod_active'] && allowedTo('post_unapproved_replies_any') && !allowedTo('post_reply_any')) {
132
+									$context['becomes_approved'] = false;
133
+				} else {
134
+									isAllowedTo('post_reply_any');
135
+				}
136
+			} elseif (!allowedTo('post_reply_any'))
130 137
 			{
131
-				if ($modSettings['postmod_active'] && ((allowedTo('post_unapproved_replies_own') && !allowedTo('post_reply_own')) || allowedTo('post_unapproved_replies_any')))
132
-					$context['becomes_approved'] = false;
133
-				else
134
-					isAllowedTo('post_reply_own');
138
+				if ($modSettings['postmod_active'] && ((allowedTo('post_unapproved_replies_own') && !allowedTo('post_reply_own')) || allowedTo('post_unapproved_replies_any'))) {
139
+									$context['becomes_approved'] = false;
140
+				} else {
141
+									isAllowedTo('post_reply_own');
142
+				}
135 143
 			}
144
+		} else {
145
+					$context['becomes_approved'] = true;
136 146
 		}
137
-		else
138
-			$context['becomes_approved'] = true;
139 147
 
140 148
 		$context['can_lock'] = allowedTo('lock_any') || ($user_info['id'] == $id_member_poster && allowedTo('lock_own'));
141 149
 		$context['can_sticky'] = allowedTo('make_sticky');
@@ -147,18 +155,19 @@  discard block
 block discarded – undo
147 155
 		$context['sticky'] = isset($_REQUEST['sticky']) ? !empty($_REQUEST['sticky']) : $sticky;
148 156
 
149 157
 		// Check whether this is a really old post being bumped...
150
-		if (!empty($modSettings['oldTopicDays']) && $lastPostTime + $modSettings['oldTopicDays'] * 86400 < time() && empty($sticky) && !isset($_REQUEST['subject']))
151
-			$post_errors[] = array('old_topic', array($modSettings['oldTopicDays']));
152
-	}
153
-	else
158
+		if (!empty($modSettings['oldTopicDays']) && $lastPostTime + $modSettings['oldTopicDays'] * 86400 < time() && empty($sticky) && !isset($_REQUEST['subject'])) {
159
+					$post_errors[] = array('old_topic', array($modSettings['oldTopicDays']));
160
+		}
161
+	} else
154 162
 	{
155 163
 		$context['becomes_approved'] = true;
156 164
 		if ((!$context['make_event'] || !empty($board)))
157 165
 		{
158
-			if ($modSettings['postmod_active'] && !allowedTo('post_new') && allowedTo('post_unapproved_topics'))
159
-				$context['becomes_approved'] = false;
160
-			else
161
-				isAllowedTo('post_new');
166
+			if ($modSettings['postmod_active'] && !allowedTo('post_new') && allowedTo('post_unapproved_topics')) {
167
+							$context['becomes_approved'] = false;
168
+			} else {
169
+							isAllowedTo('post_new');
170
+			}
162 171
 		}
163 172
 
164 173
 		$locked = 0;
@@ -196,20 +205,24 @@  discard block
 block discarded – undo
196 205
 	}
197 206
 
198 207
 	// Don't allow a post if it's locked and you aren't all powerful.
199
-	if ($locked && !allowedTo('moderate_board'))
200
-		fatal_lang_error('topic_locked', false);
208
+	if ($locked && !allowedTo('moderate_board')) {
209
+			fatal_lang_error('topic_locked', false);
210
+	}
201 211
 	// Check the users permissions - is the user allowed to add or post a poll?
202 212
 	if (isset($_REQUEST['poll']) && $modSettings['pollMode'] == '1')
203 213
 	{
204 214
 		// New topic, new poll.
205
-		if (empty($topic))
206
-			isAllowedTo('poll_post');
215
+		if (empty($topic)) {
216
+					isAllowedTo('poll_post');
217
+		}
207 218
 		// This is an old topic - but it is yours!  Can you add to it?
208
-		elseif ($user_info['id'] == $id_member_poster && !allowedTo('poll_add_any'))
209
-			isAllowedTo('poll_add_own');
219
+		elseif ($user_info['id'] == $id_member_poster && !allowedTo('poll_add_any')) {
220
+					isAllowedTo('poll_add_own');
221
+		}
210 222
 		// If you're not the owner, can you add to any poll?
211
-		else
212
-			isAllowedTo('poll_add_any');
223
+		else {
224
+					isAllowedTo('poll_add_any');
225
+		}
213 226
 
214 227
 		require_once($sourcedir . '/Subs-Members.php');
215 228
 		$allowedVoteGroups = groupsAllowedTo('poll_vote', $board);
@@ -238,8 +251,9 @@  discard block
 block discarded – undo
238 251
 	if ($context['make_event'])
239 252
 	{
240 253
 		// They might want to pick a board.
241
-		if (!isset($context['current_board']))
242
-			$context['current_board'] = 0;
254
+		if (!isset($context['current_board'])) {
255
+					$context['current_board'] = 0;
256
+		}
243 257
 
244 258
 		// Start loading up the event info.
245 259
 		$context['event'] = array();
@@ -253,10 +267,11 @@  discard block
 block discarded – undo
253 267
 		isAllowedTo('calendar_post');
254 268
 
255 269
 		// We want a fairly compact version of the time, but as close as possible to the user's settings.
256
-		if (preg_match('~%[HkIlMpPrRSTX](?:[^%]*%[HkIlMpPrRSTX])*~', $user_info['time_format'], $matches) == 0 || empty($matches[0]))
257
-			$time_string = '%k:%M';
258
-		else
259
-			$time_string = str_replace(array('%I', '%H', '%S', '%r', '%R', '%T'), array('%l', '%k', '', '%l:%M %p', '%k:%M', '%l:%M'), $matches[0]);
270
+		if (preg_match('~%[HkIlMpPrRSTX](?:[^%]*%[HkIlMpPrRSTX])*~', $user_info['time_format'], $matches) == 0 || empty($matches[0])) {
271
+					$time_string = '%k:%M';
272
+		} else {
273
+					$time_string = str_replace(array('%I', '%H', '%S', '%r', '%R', '%T'), array('%l', '%k', '', '%l:%M %p', '%k:%M', '%l:%M'), $matches[0]);
274
+		}
260 275
 
261 276
 		$js_time_string = str_replace(
262 277
 			array('%H', '%k', '%I', '%l', '%M', '%p', '%P', '%r',      '%R',  '%S', '%T',    '%X'),
@@ -278,8 +293,7 @@  discard block
 block discarded – undo
278 293
 			require_once($sourcedir . '/Subs-Calendar.php');
279 294
 			$eventProperties = getEventProperties($context['event']['id']);
280 295
 			$context['event'] = array_merge($context['event'], $eventProperties);
281
-		}
282
-		else
296
+		} else
283 297
 		{
284 298
 			// Get the current event information.
285 299
 			require_once($sourcedir . '/Subs-Calendar.php');
@@ -287,15 +301,18 @@  discard block
 block discarded – undo
287 301
 			$context['event'] = array_merge($context['event'], $eventProperties);
288 302
 
289 303
 			// Make sure the year and month are in the valid range.
290
-			if ($context['event']['month'] < 1 || $context['event']['month'] > 12)
291
-				fatal_lang_error('invalid_month', false);
292
-			if ($context['event']['year'] < $modSettings['cal_minyear'] || $context['event']['year'] > $modSettings['cal_maxyear'])
293
-				fatal_lang_error('invalid_year', false);
304
+			if ($context['event']['month'] < 1 || $context['event']['month'] > 12) {
305
+							fatal_lang_error('invalid_month', false);
306
+			}
307
+			if ($context['event']['year'] < $modSettings['cal_minyear'] || $context['event']['year'] > $modSettings['cal_maxyear']) {
308
+							fatal_lang_error('invalid_year', false);
309
+			}
294 310
 
295 311
 			// Get a list of boards they can post in.
296 312
 			$boards = boardsAllowedTo('post_new');
297
-			if (empty($boards))
298
-				fatal_lang_error('cannot_post_new', 'user');
313
+			if (empty($boards)) {
314
+							fatal_lang_error('cannot_post_new', 'user');
315
+			}
299 316
 
300 317
 			// Load a list of boards for this event in the context.
301 318
 			require_once($sourcedir . '/Subs-MessageIndex.php');
@@ -414,10 +431,11 @@  discard block
 block discarded – undo
414 431
 
415 432
 			if (!empty($context['new_replies']))
416 433
 			{
417
-				if ($context['new_replies'] == 1)
418
-					$txt['error_new_replies'] = isset($_GET['last_msg']) ? $txt['error_new_reply_reading'] : $txt['error_new_reply'];
419
-				else
420
-					$txt['error_new_replies'] = sprintf(isset($_GET['last_msg']) ? $txt['error_new_replies_reading'] : $txt['error_new_replies'], $context['new_replies']);
434
+				if ($context['new_replies'] == 1) {
435
+									$txt['error_new_replies'] = isset($_GET['last_msg']) ? $txt['error_new_reply_reading'] : $txt['error_new_reply'];
436
+				} else {
437
+									$txt['error_new_replies'] = sprintf(isset($_GET['last_msg']) ? $txt['error_new_replies_reading'] : $txt['error_new_replies'], $context['new_replies']);
438
+				}
421 439
 
422 440
 				$post_errors[] = 'new_replies';
423 441
 
@@ -429,9 +447,9 @@  discard block
 block discarded – undo
429 447
 	// Get a response prefix (like 'Re:') in the default forum language.
430 448
 	if (!isset($context['response_prefix']) && !($context['response_prefix'] = cache_get_data('response_prefix')))
431 449
 	{
432
-		if ($language === $user_info['language'])
433
-			$context['response_prefix'] = $txt['response_prefix'];
434
-		else
450
+		if ($language === $user_info['language']) {
451
+					$context['response_prefix'] = $txt['response_prefix'];
452
+		} else
435 453
 		{
436 454
 			loadLanguage('index', $language, false);
437 455
 			$context['response_prefix'] = $txt['response_prefix'];
@@ -444,8 +462,9 @@  discard block
 block discarded – undo
444 462
 	// Do we have a body, but an error happened.
445 463
 	if (isset($_REQUEST['message']) || isset($_REQUEST['quickReply']) || !empty($context['post_error']))
446 464
 	{
447
-		if (isset($_REQUEST['quickReply']))
448
-			$_REQUEST['message'] = $_REQUEST['quickReply'];
465
+		if (isset($_REQUEST['quickReply'])) {
466
+					$_REQUEST['message'] = $_REQUEST['quickReply'];
467
+		}
449 468
 
450 469
 		// Validate inputs.
451 470
 		if (empty($context['post_error']))
@@ -453,15 +472,17 @@  discard block
 block discarded – undo
453 472
 			// This means they didn't click Post and get an error.
454 473
 			$really_previewing = true;
455 474
 
456
-		}
457
-		else
475
+		} else
458 476
 		{
459
-			if (!isset($_REQUEST['subject']))
460
-				$_REQUEST['subject'] = '';
461
-			if (!isset($_REQUEST['message']))
462
-				$_REQUEST['message'] = '';
463
-			if (!isset($_REQUEST['icon']))
464
-				$_REQUEST['icon'] = 'xx';
477
+			if (!isset($_REQUEST['subject'])) {
478
+							$_REQUEST['subject'] = '';
479
+			}
480
+			if (!isset($_REQUEST['message'])) {
481
+							$_REQUEST['message'] = '';
482
+			}
483
+			if (!isset($_REQUEST['icon'])) {
484
+							$_REQUEST['icon'] = 'xx';
485
+			}
465 486
 
466 487
 			// They are previewing if they asked to preview (i.e. came from quick reply).
467 488
 			$really_previewing = !empty($_POST['preview']);
@@ -477,8 +498,9 @@  discard block
 block discarded – undo
477 498
 		$form_message = $smcFunc['htmlspecialchars']($_REQUEST['message'], ENT_QUOTES);
478 499
 
479 500
 		// Make sure the subject isn't too long - taking into account special characters.
480
-		if ($smcFunc['strlen']($form_subject) > 100)
481
-			$form_subject = $smcFunc['substr']($form_subject, 0, 100);
501
+		if ($smcFunc['strlen']($form_subject) > 100) {
502
+					$form_subject = $smcFunc['substr']($form_subject, 0, 100);
503
+		}
482 504
 
483 505
 		if (isset($_REQUEST['poll']))
484 506
 		{
@@ -490,8 +512,9 @@  discard block
 block discarded – undo
490 512
 			$_POST['options'] = empty($_POST['options']) ? array() : htmlspecialchars__recursive($_POST['options']);
491 513
 			foreach ($_POST['options'] as $option)
492 514
 			{
493
-				if (trim($option) == '')
494
-					continue;
515
+				if (trim($option) == '') {
516
+									continue;
517
+				}
495 518
 
496 519
 				$context['choices'][] = array(
497 520
 					'id' => $choice_id++,
@@ -553,13 +576,14 @@  discard block
 block discarded – undo
553 576
 				$context['preview_subject'] = $form_subject;
554 577
 
555 578
 				censorText($context['preview_subject']);
579
+			} else {
580
+							$context['preview_subject'] = '<em>' . $txt['no_subject'] . '</em>';
556 581
 			}
557
-			else
558
-				$context['preview_subject'] = '<em>' . $txt['no_subject'] . '</em>';
559 582
 
560 583
 			// Protect any CDATA blocks.
561
-			if (isset($_REQUEST['xml']))
562
-				$context['preview_message'] = strtr($context['preview_message'], array(']]>' => ']]]]><![CDATA[>'));
584
+			if (isset($_REQUEST['xml'])) {
585
+							$context['preview_message'] = strtr($context['preview_message'], array(']]>' => ']]]]><![CDATA[>'));
586
+			}
563 587
 		}
564 588
 
565 589
 		// Set up the checkboxes.
@@ -598,29 +622,32 @@  discard block
 block discarded – undo
598 622
 			);
599 623
 			// The message they were trying to edit was most likely deleted.
600 624
 			// @todo Change this error message?
601
-			if ($smcFunc['db_num_rows']($request) == 0)
602
-				fatal_lang_error('no_board', false);
625
+			if ($smcFunc['db_num_rows']($request) == 0) {
626
+							fatal_lang_error('no_board', false);
627
+			}
603 628
 			$row = $smcFunc['db_fetch_assoc']($request);
604 629
 
605 630
 			$attachment_stuff = array($row);
606
-			while ($row2 = $smcFunc['db_fetch_assoc']($request))
607
-				$attachment_stuff[] = $row2;
631
+			while ($row2 = $smcFunc['db_fetch_assoc']($request)) {
632
+							$attachment_stuff[] = $row2;
633
+			}
608 634
 			$smcFunc['db_free_result']($request);
609 635
 
610 636
 			if ($row['id_member'] == $user_info['id'] && !allowedTo('modify_any'))
611 637
 			{
612 638
 				// Give an extra five minutes over the disable time threshold, so they can type - assuming the post is public.
613
-				if ($row['approved'] && !empty($modSettings['edit_disable_time']) && $row['poster_time'] + ($modSettings['edit_disable_time'] + 5) * 60 < time())
614
-					fatal_lang_error('modify_post_time_passed', false);
615
-				elseif ($row['id_member_poster'] == $user_info['id'] && !allowedTo('modify_own'))
616
-					isAllowedTo('modify_replies');
617
-				else
618
-					isAllowedTo('modify_own');
639
+				if ($row['approved'] && !empty($modSettings['edit_disable_time']) && $row['poster_time'] + ($modSettings['edit_disable_time'] + 5) * 60 < time()) {
640
+									fatal_lang_error('modify_post_time_passed', false);
641
+				} elseif ($row['id_member_poster'] == $user_info['id'] && !allowedTo('modify_own')) {
642
+									isAllowedTo('modify_replies');
643
+				} else {
644
+									isAllowedTo('modify_own');
645
+				}
646
+			} elseif ($row['id_member_poster'] == $user_info['id'] && !allowedTo('modify_any')) {
647
+							isAllowedTo('modify_replies');
648
+			} else {
649
+							isAllowedTo('modify_any');
619 650
 			}
620
-			elseif ($row['id_member_poster'] == $user_info['id'] && !allowedTo('modify_any'))
621
-				isAllowedTo('modify_replies');
622
-			else
623
-				isAllowedTo('modify_any');
624 651
 
625 652
 			if ($context['can_announce'] && !empty($row['id_action']))
626 653
 			{
@@ -644,8 +671,9 @@  discard block
 block discarded – undo
644 671
 
645 672
 				while ($row = $smcFunc['db_fetch_assoc']($request))
646 673
 				{
647
-					if ($row['filesize'] <= 0)
648
-						continue;
674
+					if ($row['filesize'] <= 0) {
675
+											continue;
676
+					}
649 677
 					$context['current_attachments'][$row['id_attach']] = array(
650 678
 						'name' => $smcFunc['htmlspecialchars']($row['filename']),
651 679
 						'size' => $row['filesize'],
@@ -715,29 +743,32 @@  discard block
 block discarded – undo
715 743
 			)
716 744
 		);
717 745
 		// The message they were trying to edit was most likely deleted.
718
-		if ($smcFunc['db_num_rows']($request) == 0)
719
-			fatal_lang_error('no_message', false);
746
+		if ($smcFunc['db_num_rows']($request) == 0) {
747
+					fatal_lang_error('no_message', false);
748
+		}
720 749
 		$row = $smcFunc['db_fetch_assoc']($request);
721 750
 
722 751
 		$attachment_stuff = array($row);
723
-		while ($row2 = $smcFunc['db_fetch_assoc']($request))
724
-			$attachment_stuff[] = $row2;
752
+		while ($row2 = $smcFunc['db_fetch_assoc']($request)) {
753
+					$attachment_stuff[] = $row2;
754
+		}
725 755
 		$smcFunc['db_free_result']($request);
726 756
 
727 757
 		if ($row['id_member'] == $user_info['id'] && !allowedTo('modify_any'))
728 758
 		{
729 759
 			// Give an extra five minutes over the disable time threshold, so they can type - assuming the post is public.
730
-			if ($row['approved'] && !empty($modSettings['edit_disable_time']) && $row['poster_time'] + ($modSettings['edit_disable_time'] + 5) * 60 < time())
731
-				fatal_lang_error('modify_post_time_passed', false);
732
-			elseif ($row['id_member_poster'] == $user_info['id'] && !allowedTo('modify_own'))
733
-				isAllowedTo('modify_replies');
734
-			else
735
-				isAllowedTo('modify_own');
760
+			if ($row['approved'] && !empty($modSettings['edit_disable_time']) && $row['poster_time'] + ($modSettings['edit_disable_time'] + 5) * 60 < time()) {
761
+							fatal_lang_error('modify_post_time_passed', false);
762
+			} elseif ($row['id_member_poster'] == $user_info['id'] && !allowedTo('modify_own')) {
763
+							isAllowedTo('modify_replies');
764
+			} else {
765
+							isAllowedTo('modify_own');
766
+			}
767
+		} elseif ($row['id_member_poster'] == $user_info['id'] && !allowedTo('modify_any')) {
768
+					isAllowedTo('modify_replies');
769
+		} else {
770
+					isAllowedTo('modify_any');
736 771
 		}
737
-		elseif ($row['id_member_poster'] == $user_info['id'] && !allowedTo('modify_any'))
738
-			isAllowedTo('modify_replies');
739
-		else
740
-			isAllowedTo('modify_any');
741 772
 
742 773
 		if ($context['can_announce'] && !empty($row['id_action']))
743 774
 		{
@@ -764,15 +795,17 @@  discard block
 block discarded – undo
764 795
 		$context['icon'] = $row['icon'];
765 796
 
766 797
 		// Show an "approve" box if the user can approve it, and the message isn't approved.
767
-		if (!$row['approved'] && !$context['show_approval'])
768
-			$context['show_approval'] = allowedTo('approve_posts');
798
+		if (!$row['approved'] && !$context['show_approval']) {
799
+					$context['show_approval'] = allowedTo('approve_posts');
800
+		}
769 801
 
770 802
 		// Sort the attachments so they are in the order saved
771 803
 		$temp = array();
772 804
 		foreach ($attachment_stuff as $attachment)
773 805
 		{
774
-			if ($attachment['filesize'] >= 0 && !empty($modSettings['attachmentEnable']))
775
-				$temp[$attachment['id_attach']] = $attachment;
806
+			if ($attachment['filesize'] >= 0 && !empty($modSettings['attachmentEnable'])) {
807
+							$temp[$attachment['id_attach']] = $attachment;
808
+			}
776 809
 
777 810
 		}
778 811
 		ksort($temp);
@@ -834,14 +867,16 @@  discard block
 block discarded – undo
834 867
 					'is_approved' => 1,
835 868
 				)
836 869
 			);
837
-			if ($smcFunc['db_num_rows']($request) == 0)
838
-				fatal_lang_error('quoted_post_deleted', false);
870
+			if ($smcFunc['db_num_rows']($request) == 0) {
871
+							fatal_lang_error('quoted_post_deleted', false);
872
+			}
839 873
 			list ($form_subject, $mname, $mdate, $form_message) = $smcFunc['db_fetch_row']($request);
840 874
 			$smcFunc['db_free_result']($request);
841 875
 
842 876
 			// Add 'Re: ' to the front of the quoted subject.
843
-			if (trim($context['response_prefix']) != '' && $smcFunc['strpos']($form_subject, trim($context['response_prefix'])) !== 0)
844
-				$form_subject = $context['response_prefix'] . $form_subject;
877
+			if (trim($context['response_prefix']) != '' && $smcFunc['strpos']($form_subject, trim($context['response_prefix'])) !== 0) {
878
+							$form_subject = $context['response_prefix'] . $form_subject;
879
+			}
845 880
 
846 881
 			// Censor the message and subject.
847 882
 			censorText($form_message);
@@ -854,10 +889,11 @@  discard block
 block discarded – undo
854 889
 				for ($i = 0, $n = count($parts); $i < $n; $i++)
855 890
 				{
856 891
 					// It goes 0 = outside, 1 = begin tag, 2 = inside, 3 = close tag, repeat.
857
-					if ($i % 4 == 0)
858
-						$parts[$i] = preg_replace_callback('~\[html\](.+?)\[/html\]~is', function($m)
892
+					if ($i % 4 == 0) {
893
+											$parts[$i] = preg_replace_callback('~\[html\](.+?)\[/html\]~is', function($m)
859 894
 						{
860 895
 							return '[html]' . preg_replace('~<br\s?/?' . '>~i', '&lt;br /&gt;<br>', "$m[1]") . '[/html]';
896
+					}
861 897
 						}, $parts[$i]);
862 898
 				}
863 899
 				$form_message = implode('', $parts);
@@ -866,8 +902,9 @@  discard block
 block discarded – undo
866 902
 			$form_message = preg_replace('~<br ?/?' . '>~i', "\n", $form_message);
867 903
 
868 904
 			// Remove any nested quotes, if necessary.
869
-			if (!empty($modSettings['removeNestedQuotes']))
870
-				$form_message = preg_replace(array('~\n?\[quote.*?\].+?\[/quote\]\n?~is', '~^\n~', '~\[/quote\]~'), '', $form_message);
905
+			if (!empty($modSettings['removeNestedQuotes'])) {
906
+							$form_message = preg_replace(array('~\n?\[quote.*?\].+?\[/quote\]\n?~is', '~^\n~', '~\[/quote\]~'), '', $form_message);
907
+			}
871 908
 
872 909
 			// Add a quote string on the front and end.
873 910
 			$form_message = '[quote author=' . $mname . ' link=msg=' . (int) $_REQUEST['quote'] . ' date=' . $mdate . ']' . "\n" . rtrim($form_message) . "\n" . '[/quote]';
@@ -879,15 +916,15 @@  discard block
 block discarded – undo
879 916
 			$form_subject = $first_subject;
880 917
 
881 918
 			// Add 'Re: ' to the front of the subject.
882
-			if (trim($context['response_prefix']) != '' && $form_subject != '' && $smcFunc['strpos']($form_subject, trim($context['response_prefix'])) !== 0)
883
-				$form_subject = $context['response_prefix'] . $form_subject;
919
+			if (trim($context['response_prefix']) != '' && $form_subject != '' && $smcFunc['strpos']($form_subject, trim($context['response_prefix'])) !== 0) {
920
+							$form_subject = $context['response_prefix'] . $form_subject;
921
+			}
884 922
 
885 923
 			// Censor the subject.
886 924
 			censorText($form_subject);
887 925
 
888 926
 			$form_message = '';
889
-		}
890
-		else
927
+		} else
891 928
 		{
892 929
 			$form_subject = isset($_GET['subject']) ? $_GET['subject'] : '';
893 930
 			$form_message = '';
@@ -905,13 +942,15 @@  discard block
 block discarded – undo
905 942
 		if (isset($_REQUEST['msg']))
906 943
 		{
907 944
 			$context['attachments']['quantity'] = count($context['current_attachments']);
908
-			foreach ($context['current_attachments'] as $attachment)
909
-				$context['attachments']['total_size'] += $attachment['size'];
945
+			foreach ($context['current_attachments'] as $attachment) {
946
+							$context['attachments']['total_size'] += $attachment['size'];
947
+			}
910 948
 		}
911 949
 
912 950
 		// A bit of house keeping first.
913
-		if (!empty($_SESSION['temp_attachments']) && count($_SESSION['temp_attachments']) == 1)
914
-			unset($_SESSION['temp_attachments']);
951
+		if (!empty($_SESSION['temp_attachments']) && count($_SESSION['temp_attachments']) == 1) {
952
+					unset($_SESSION['temp_attachments']);
953
+		}
915 954
 
916 955
 		if (!empty($_SESSION['temp_attachments']))
917 956
 		{
@@ -920,9 +959,10 @@  discard block
 block discarded – undo
920 959
 			{
921 960
 				foreach ($_SESSION['temp_attachments'] as $attachID => $attachment)
922 961
 				{
923
-					if (strpos($attachID, 'post_tmp_' . $user_info['id']) !== false)
924
-						if (file_exists($attachment['tmp_name']))
962
+					if (strpos($attachID, 'post_tmp_' . $user_info['id']) !== false) {
963
+											if (file_exists($attachment['tmp_name']))
925 964
 							unlink($attachment['tmp_name']);
965
+					}
926 966
 				}
927 967
 				$post_errors[] = 'temp_attachments_gone';
928 968
 				$_SESSION['temp_attachments'] = array();
@@ -936,8 +976,9 @@  discard block
 block discarded – undo
936 976
 					// See if any files still exist before showing the warning message and the files attached.
937 977
 					foreach ($_SESSION['temp_attachments'] as $attachID => $attachment)
938 978
 					{
939
-						if (strpos($attachID, 'post_tmp_' . $user_info['id']) === false)
940
-							continue;
979
+						if (strpos($attachID, 'post_tmp_' . $user_info['id']) === false) {
980
+													continue;
981
+						}
941 982
 
942 983
 						if (file_exists($attachment['tmp_name']))
943 984
 						{
@@ -947,20 +988,21 @@  discard block
 block discarded – undo
947 988
 							break;
948 989
 						}
949 990
 					}
950
-				}
951
-				else
991
+				} else
952 992
 				{
953 993
 					// Since, they don't belong here. Let's inform the user that they exist..
954
-					if (!empty($topic))
955
-						$delete_url = $scripturl . '?action=post' . (!empty($_REQUEST['msg']) ? (';msg=' . $_REQUEST['msg']) : '') . (!empty($_REQUEST['last_msg']) ? (';last_msg=' . $_REQUEST['last_msg']) : '') . ';topic=' . $topic . ';delete_temp';
956
-					else
957
-						$delete_url = $scripturl . '?action=post;board=' . $board . ';delete_temp';
994
+					if (!empty($topic)) {
995
+											$delete_url = $scripturl . '?action=post' . (!empty($_REQUEST['msg']) ? (';msg=' . $_REQUEST['msg']) : '') . (!empty($_REQUEST['last_msg']) ? (';last_msg=' . $_REQUEST['last_msg']) : '') . ';topic=' . $topic . ';delete_temp';
996
+					} else {
997
+											$delete_url = $scripturl . '?action=post;board=' . $board . ';delete_temp';
998
+					}
958 999
 
959 1000
 					// Compile a list of the files to show the user.
960 1001
 					$file_list = array();
961
-					foreach ($_SESSION['temp_attachments'] as $attachID => $attachment)
962
-						if (strpos($attachID, 'post_tmp_' . $user_info['id']) !== false)
1002
+					foreach ($_SESSION['temp_attachments'] as $attachID => $attachment) {
1003
+											if (strpos($attachID, 'post_tmp_' . $user_info['id']) !== false)
963 1004
 							$file_list[] = $attachment['name'];
1005
+					}
964 1006
 
965 1007
 					$_SESSION['temp_attachments']['post']['files'] = $file_list;
966 1008
 					$file_list = '<div class="attachments">' . implode('<br>', $file_list) . '</div>';
@@ -972,8 +1014,7 @@  discard block
 block discarded – undo
972 1014
 
973 1015
 						$post_errors[] = array('temp_attachments_found', array($delete_url, $goback_url, $file_list));
974 1016
 						$context['ignore_temp_attachments'] = true;
975
-					}
976
-					else
1017
+					} else
977 1018
 					{
978 1019
 						$post_errors[] = array('temp_attachments_lost', array($delete_url, $file_list));
979 1020
 						$context['ignore_temp_attachments'] = true;
@@ -981,16 +1022,19 @@  discard block
 block discarded – undo
981 1022
 				}
982 1023
 			}
983 1024
 
984
-			if (!empty($context['we_are_history']))
985
-				$post_errors[] = $context['we_are_history'];
1025
+			if (!empty($context['we_are_history'])) {
1026
+							$post_errors[] = $context['we_are_history'];
1027
+			}
986 1028
 
987 1029
 			foreach ($_SESSION['temp_attachments'] as $attachID => $attachment)
988 1030
 			{
989
-				if (isset($context['ignore_temp_attachments']) || isset($_SESSION['temp_attachments']['post']['files']))
990
-					break;
1031
+				if (isset($context['ignore_temp_attachments']) || isset($_SESSION['temp_attachments']['post']['files'])) {
1032
+									break;
1033
+				}
991 1034
 
992
-				if ($attachID != 'initial_error' && strpos($attachID, 'post_tmp_' . $user_info['id']) === false)
993
-					continue;
1035
+				if ($attachID != 'initial_error' && strpos($attachID, 'post_tmp_' . $user_info['id']) === false) {
1036
+									continue;
1037
+				}
994 1038
 
995 1039
 				if ($attachID == 'initial_error')
996 1040
 				{
@@ -1005,15 +1049,17 @@  discard block
 block discarded – undo
1005 1049
 				{
1006 1050
 					$txt['error_attach_errors'] = empty($txt['error_attach_errors']) ? '<br>' : '';
1007 1051
 					$txt['error_attach_errors'] .= vsprintf($txt['attach_warning'], $attachment['name']) . '<div style="padding: 0 1em;">';
1008
-					foreach ($attachment['errors'] as $error)
1009
-						$txt['error_attach_errors'] .= (is_array($error) ? vsprintf($txt[$error[0]], $error[1]) : $txt[$error]) . '<br >';
1052
+					foreach ($attachment['errors'] as $error) {
1053
+											$txt['error_attach_errors'] .= (is_array($error) ? vsprintf($txt[$error[0]], $error[1]) : $txt[$error]) . '<br >';
1054
+					}
1010 1055
 					$txt['error_attach_errors'] .= '</div>';
1011 1056
 					$post_errors[] = 'attach_errors';
1012 1057
 
1013 1058
 					// Take out the trash.
1014 1059
 					unset($_SESSION['temp_attachments'][$attachID]);
1015
-					if (file_exists($attachment['tmp_name']))
1016
-						unlink($attachment['tmp_name']);
1060
+					if (file_exists($attachment['tmp_name'])) {
1061
+											unlink($attachment['tmp_name']);
1062
+					}
1017 1063
 					continue;
1018 1064
 				}
1019 1065
 
@@ -1026,8 +1072,9 @@  discard block
 block discarded – undo
1026 1072
 
1027 1073
 				$context['attachments']['quantity']++;
1028 1074
 				$context['attachments']['total_size'] += $attachment['size'];
1029
-				if (!isset($context['files_in_session_warning']))
1030
-					$context['files_in_session_warning'] = $txt['attached_files_in_session'];
1075
+				if (!isset($context['files_in_session_warning'])) {
1076
+									$context['files_in_session_warning'] = $txt['attached_files_in_session'];
1077
+				}
1031 1078
 
1032 1079
 				$context['current_attachments'][$attachID] = array(
1033 1080
 					'name' => '<u>' . $smcFunc['htmlspecialchars']($attachment['name']) . '</u>',
@@ -1055,8 +1102,9 @@  discard block
 block discarded – undo
1055 1102
 	}
1056 1103
 
1057 1104
 	// If they came from quick reply, and have to enter verification details, give them some notice.
1058
-	if (!empty($_REQUEST['from_qr']) && !empty($context['require_verification']))
1059
-		$post_errors[] = 'need_qr_verification';
1105
+	if (!empty($_REQUEST['from_qr']) && !empty($context['require_verification'])) {
1106
+			$post_errors[] = 'need_qr_verification';
1107
+	}
1060 1108
 
1061 1109
 	/*
1062 1110
 	 * There are two error types: serious and minor. Serious errors
@@ -1073,52 +1121,56 @@  discard block
 block discarded – undo
1073 1121
 	{
1074 1122
 		loadLanguage('Errors');
1075 1123
 		$context['error_type'] = 'minor';
1076
-		foreach ($post_errors as $post_error)
1077
-			if (is_array($post_error))
1124
+		foreach ($post_errors as $post_error) {
1125
+					if (is_array($post_error))
1078 1126
 			{
1079 1127
 				$post_error_id = $post_error[0];
1128
+		}
1080 1129
 				$context['post_error'][$post_error_id] = vsprintf($txt['error_' . $post_error_id], $post_error[1]);
1081 1130
 
1082 1131
 				// If it's not a minor error flag it as such.
1083
-				if (!in_array($post_error_id, $minor_errors))
1084
-					$context['error_type'] = 'serious';
1085
-			}
1086
-			else
1132
+				if (!in_array($post_error_id, $minor_errors)) {
1133
+									$context['error_type'] = 'serious';
1134
+				}
1135
+			} else
1087 1136
 			{
1088 1137
 				$context['post_error'][$post_error] = $txt['error_' . $post_error];
1089 1138
 
1090 1139
 				// If it's not a minor error flag it as such.
1091
-				if (!in_array($post_error, $minor_errors))
1092
-					$context['error_type'] = 'serious';
1140
+				if (!in_array($post_error, $minor_errors)) {
1141
+									$context['error_type'] = 'serious';
1142
+				}
1093 1143
 			}
1094 1144
 	}
1095 1145
 
1096 1146
 	// What are you doing? Posting a poll, modifying, previewing, new post, or reply...
1097
-	if (isset($_REQUEST['poll']))
1098
-		$context['page_title'] = $txt['new_poll'];
1099
-	elseif ($context['make_event'])
1100
-		$context['page_title'] = $context['event']['id'] == -1 ? $txt['calendar_post_event'] : $txt['calendar_edit'];
1101
-	elseif (isset($_REQUEST['msg']))
1102
-		$context['page_title'] = $txt['modify_msg'];
1103
-	elseif (isset($_REQUEST['subject'], $context['preview_subject']))
1104
-		$context['page_title'] = $txt['preview'] . ' - ' . strip_tags($context['preview_subject']);
1105
-	elseif (empty($topic))
1106
-		$context['page_title'] = $txt['start_new_topic'];
1107
-	else
1108
-		$context['page_title'] = $txt['post_reply'];
1147
+	if (isset($_REQUEST['poll'])) {
1148
+			$context['page_title'] = $txt['new_poll'];
1149
+	} elseif ($context['make_event']) {
1150
+			$context['page_title'] = $context['event']['id'] == -1 ? $txt['calendar_post_event'] : $txt['calendar_edit'];
1151
+	} elseif (isset($_REQUEST['msg'])) {
1152
+			$context['page_title'] = $txt['modify_msg'];
1153
+	} elseif (isset($_REQUEST['subject'], $context['preview_subject'])) {
1154
+			$context['page_title'] = $txt['preview'] . ' - ' . strip_tags($context['preview_subject']);
1155
+	} elseif (empty($topic)) {
1156
+			$context['page_title'] = $txt['start_new_topic'];
1157
+	} else {
1158
+			$context['page_title'] = $txt['post_reply'];
1159
+	}
1109 1160
 
1110 1161
 	// Build the link tree.
1111
-	if (empty($topic))
1112
-		$context['linktree'][] = array(
1162
+	if (empty($topic)) {
1163
+			$context['linktree'][] = array(
1113 1164
 			'name' => '<em>' . $txt['start_new_topic'] . '</em>'
1114 1165
 		);
1115
-	else
1116
-		$context['linktree'][] = array(
1166
+	} else {
1167
+			$context['linktree'][] = array(
1117 1168
 			'url' => $scripturl . '?topic=' . $topic . '.' . $_REQUEST['start'],
1118 1169
 			'name' => $form_subject,
1119 1170
 			'extra_before' => '<span><strong class="nav">' . $context['page_title'] . ' (</strong></span>',
1120 1171
 			'extra_after' => '<span><strong class="nav">)</strong></span>'
1121 1172
 		);
1173
+	}
1122 1174
 
1123 1175
 	$context['subject'] = addcslashes($form_subject, '"');
1124 1176
 	$context['message'] = str_replace(array('"', '<', '>', '&nbsp;'), array('&quot;', '&lt;', '&gt;', ' '), $form_message);
@@ -1162,8 +1214,9 @@  discard block
 block discarded – undo
1162 1214
 	// Message icons - customized icons are off?
1163 1215
 	$context['icons'] = getMessageIcons($board);
1164 1216
 
1165
-	if (!empty($context['icons']))
1166
-		$context['icons'][count($context['icons']) - 1]['is_last'] = true;
1217
+	if (!empty($context['icons'])) {
1218
+			$context['icons'][count($context['icons']) - 1]['is_last'] = true;
1219
+	}
1167 1220
 
1168 1221
 	// Are we starting a poll? if set the poll icon as selected if its available
1169 1222
 	if (isset($_REQUEST['poll']))
@@ -1183,8 +1236,9 @@  discard block
 block discarded – undo
1183 1236
 	for ($i = 0, $n = count($context['icons']); $i < $n; $i++)
1184 1237
 	{
1185 1238
 		$context['icons'][$i]['selected'] = $context['icon'] == $context['icons'][$i]['value'];
1186
-		if ($context['icons'][$i]['selected'])
1187
-			$context['icon_url'] = $context['icons'][$i]['url'];
1239
+		if ($context['icons'][$i]['selected']) {
1240
+					$context['icon_url'] = $context['icons'][$i]['url'];
1241
+		}
1188 1242
 	}
1189 1243
 	if (empty($context['icon_url']))
1190 1244
 	{
@@ -1198,8 +1252,9 @@  discard block
 block discarded – undo
1198 1252
 		));
1199 1253
 	}
1200 1254
 
1201
-	if (!empty($topic) && !empty($modSettings['topicSummaryPosts']))
1202
-		getTopic();
1255
+	if (!empty($topic) && !empty($modSettings['topicSummaryPosts'])) {
1256
+			getTopic();
1257
+	}
1203 1258
 
1204 1259
 	// If the user can post attachments prepare the warning labels.
1205 1260
 	if ($context['can_post_attachment'])
@@ -1210,15 +1265,17 @@  discard block
 block discarded – undo
1210 1265
 		$context['attachment_restrictions'] = array();
1211 1266
 		$context['allowed_extensions'] = strtr(strtolower($modSettings['attachmentExtensions']), array(',' => ', '));
1212 1267
 		$attachmentRestrictionTypes = array('attachmentNumPerPostLimit', 'attachmentPostLimit', 'attachmentSizeLimit');
1213
-		foreach ($attachmentRestrictionTypes as $type)
1214
-			if (!empty($modSettings[$type]))
1268
+		foreach ($attachmentRestrictionTypes as $type) {
1269
+					if (!empty($modSettings[$type]))
1215 1270
 			{
1216 1271
 				$context['attachment_restrictions'][] = sprintf($txt['attach_restrict_' . $type . ($modSettings[$type] >= 1024 ? '_MB' : '')], comma_format($modSettings[$type], 0));
1272
+		}
1217 1273
 				// Show some numbers. If they exist.
1218
-				if ($type == 'attachmentNumPerPostLimit' && $context['attachments']['quantity'] > 0)
1219
-					$context['attachment_restrictions'][] = sprintf($txt['attach_remaining'], $modSettings['attachmentNumPerPostLimit'] - $context['attachments']['quantity']);
1220
-				elseif ($type == 'attachmentPostLimit' && $context['attachments']['total_size'] > 0)
1221
-					$context['attachment_restrictions'][] = sprintf($txt['attach_available'], comma_format(round(max($modSettings['attachmentPostLimit'] - ($context['attachments']['total_size'] / 1024), 0)), 0));
1274
+				if ($type == 'attachmentNumPerPostLimit' && $context['attachments']['quantity'] > 0) {
1275
+									$context['attachment_restrictions'][] = sprintf($txt['attach_remaining'], $modSettings['attachmentNumPerPostLimit'] - $context['attachments']['quantity']);
1276
+				} elseif ($type == 'attachmentPostLimit' && $context['attachments']['total_size'] > 0) {
1277
+									$context['attachment_restrictions'][] = sprintf($txt['attach_available'], comma_format(round(max($modSettings['attachmentPostLimit'] - ($context['attachments']['total_size'] / 1024), 0)), 0));
1278
+				}
1222 1279
 			}
1223 1280
 	}
1224 1281
 
@@ -1252,8 +1309,8 @@  discard block
 block discarded – undo
1252 1309
 
1253 1310
 	if (!empty($context['current_attachments']))
1254 1311
 	{
1255
-		foreach ($context['current_attachments'] as $key => $mock)
1256
-			addInlineJavaScript('
1312
+		foreach ($context['current_attachments'] as $key => $mock) {
1313
+					addInlineJavaScript('
1257 1314
 	current_attachments.push({
1258 1315
 		name: '. JavaScriptEscape($mock['name']) . ',
1259 1316
 		size: '. $mock['size'] . ',
@@ -1262,6 +1319,7 @@  discard block
 block discarded – undo
1262 1319
 		type: '. JavaScriptEscape(!empty($mock['mime_type']) ? $mock['mime_type'] : '') . ',
1263 1320
 		thumbID: '. (!empty($mock['thumb']) ? $mock['thumb'] : 0) . '
1264 1321
 	});', true);
1322
+		}
1265 1323
 	}
1266 1324
 
1267 1325
 	// File Upload.
@@ -1306,8 +1364,9 @@  discard block
 block discarded – undo
1306 1364
 	var current_board = '. (empty($context['current_board']) ? 'null' : $context['current_board']) . ';', false);
1307 1365
 
1308 1366
 	// Finally, load the template.
1309
-	if (!isset($_REQUEST['xml']))
1310
-		loadTemplate('Post');
1367
+	if (!isset($_REQUEST['xml'])) {
1368
+			loadTemplate('Post');
1369
+	}
1311 1370
 
1312 1371
 	call_integration_hook('integrate_post_end');
1313 1372
 }
@@ -1328,13 +1387,14 @@  discard block
 block discarded – undo
1328 1387
 	// Sneaking off, are we?
1329 1388
 	if (empty($_POST) && empty($topic))
1330 1389
 	{
1331
-		if (empty($_SERVER['CONTENT_LENGTH']))
1332
-			redirectexit('action=post;board=' . $board . '.0');
1333
-		else
1334
-			fatal_lang_error('post_upload_error', false);
1390
+		if (empty($_SERVER['CONTENT_LENGTH'])) {
1391
+					redirectexit('action=post;board=' . $board . '.0');
1392
+		} else {
1393
+					fatal_lang_error('post_upload_error', false);
1394
+		}
1395
+	} elseif (empty($_POST) && !empty($topic)) {
1396
+			redirectexit('action=post;topic=' . $topic . '.0');
1335 1397
 	}
1336
-	elseif (empty($_POST) && !empty($topic))
1337
-		redirectexit('action=post;topic=' . $topic . '.0');
1338 1398
 
1339 1399
 	// No need!
1340 1400
 	$context['robot_no_index'] = true;
@@ -1346,8 +1406,9 @@  discard block
 block discarded – undo
1346 1406
 	$post_errors = array();
1347 1407
 
1348 1408
 	// If the session has timed out, let the user re-submit their form.
1349
-	if (checkSession('post', '', false) != '')
1350
-		$post_errors[] = 'session_timeout';
1409
+	if (checkSession('post', '', false) != '') {
1410
+			$post_errors[] = 'session_timeout';
1411
+	}
1351 1412
 
1352 1413
 	// Wrong verification code?
1353 1414
 	if (!$user_info['is_admin'] && !$user_info['is_mod'] && !empty($modSettings['posts_require_captcha']) && ($user_info['posts'] < $modSettings['posts_require_captcha'] || ($user_info['is_guest'] && $modSettings['posts_require_captcha'] == -1)))
@@ -1357,33 +1418,38 @@  discard block
 block discarded – undo
1357 1418
 			'id' => 'post',
1358 1419
 		);
1359 1420
 		$context['require_verification'] = create_control_verification($verificationOptions, true);
1360
-		if (is_array($context['require_verification']))
1361
-			$post_errors = array_merge($post_errors, $context['require_verification']);
1421
+		if (is_array($context['require_verification'])) {
1422
+					$post_errors = array_merge($post_errors, $context['require_verification']);
1423
+		}
1362 1424
 	}
1363 1425
 
1364 1426
 	require_once($sourcedir . '/Subs-Post.php');
1365 1427
 	loadLanguage('Post');
1366 1428
 
1367 1429
 	// Drafts enabled and needed?
1368
-	if (!empty($modSettings['drafts_post_enabled']) && (isset($_POST['save_draft']) || isset($_POST['id_draft'])))
1369
-		require_once($sourcedir . '/Drafts.php');
1430
+	if (!empty($modSettings['drafts_post_enabled']) && (isset($_POST['save_draft']) || isset($_POST['id_draft']))) {
1431
+			require_once($sourcedir . '/Drafts.php');
1432
+	}
1370 1433
 
1371 1434
 	// First check to see if they are trying to delete any current attachments.
1372 1435
 	if (isset($_POST['attach_del']))
1373 1436
 	{
1374 1437
 		$keep_temp = array();
1375 1438
 		$keep_ids = array();
1376
-		foreach ($_POST['attach_del'] as $dummy)
1377
-			if (strpos($dummy, 'post_tmp_' . $user_info['id']) !== false)
1439
+		foreach ($_POST['attach_del'] as $dummy) {
1440
+					if (strpos($dummy, 'post_tmp_' . $user_info['id']) !== false)
1378 1441
 				$keep_temp[] = $dummy;
1379
-			else
1380
-				$keep_ids[] = (int) $dummy;
1442
+		}
1443
+			else {
1444
+							$keep_ids[] = (int) $dummy;
1445
+			}
1381 1446
 
1382
-		if (isset($_SESSION['temp_attachments']))
1383
-			foreach ($_SESSION['temp_attachments'] as $attachID => $attachment)
1447
+		if (isset($_SESSION['temp_attachments'])) {
1448
+					foreach ($_SESSION['temp_attachments'] as $attachID => $attachment)
1384 1449
 			{
1385 1450
 				if ((isset($_SESSION['temp_attachments']['post']['files'], $attachment['name']) && in_array($attachment['name'], $_SESSION['temp_attachments']['post']['files'])) || in_array($attachID, $keep_temp) || strpos($attachID, 'post_tmp_' . $user_info['id']) === false)
1386 1451
 					continue;
1452
+		}
1387 1453
 
1388 1454
 				unset($_SESSION['temp_attachments'][$attachID]);
1389 1455
 				unlink($attachment['tmp_name']);
@@ -1425,24 +1491,28 @@  discard block
 block discarded – undo
1425 1491
 		$smcFunc['db_free_result']($request);
1426 1492
 
1427 1493
 		// Though the topic should be there, it might have vanished.
1428
-		if (!is_array($topic_info))
1429
-			fatal_lang_error('topic_doesnt_exist', 404);
1494
+		if (!is_array($topic_info)) {
1495
+					fatal_lang_error('topic_doesnt_exist', 404);
1496
+		}
1430 1497
 
1431 1498
 		// Did this topic suddenly move? Just checking...
1432
-		if ($topic_info['id_board'] != $board)
1433
-			fatal_lang_error('not_a_topic');
1499
+		if ($topic_info['id_board'] != $board) {
1500
+					fatal_lang_error('not_a_topic');
1501
+		}
1434 1502
 	}
1435 1503
 
1436 1504
 	// Replying to a topic?
1437 1505
 	if (!empty($topic) && !isset($_REQUEST['msg']))
1438 1506
 	{
1439 1507
 		// Don't allow a post if it's locked.
1440
-		if ($topic_info['locked'] != 0 && !allowedTo('moderate_board'))
1441
-			fatal_lang_error('topic_locked', false);
1508
+		if ($topic_info['locked'] != 0 && !allowedTo('moderate_board')) {
1509
+					fatal_lang_error('topic_locked', false);
1510
+		}
1442 1511
 
1443 1512
 		// Sorry, multiple polls aren't allowed... yet.  You should stop giving me ideas :P.
1444
-		if (isset($_REQUEST['poll']) && $topic_info['id_poll'] > 0)
1445
-			unset($_REQUEST['poll']);
1513
+		if (isset($_REQUEST['poll']) && $topic_info['id_poll'] > 0) {
1514
+					unset($_REQUEST['poll']);
1515
+		}
1446 1516
 
1447 1517
 		// Do the permissions and approval stuff...
1448 1518
 		$becomesApproved = true;
@@ -1458,44 +1528,43 @@  discard block
 block discarded – undo
1458 1528
 
1459 1529
 			// Set a nice session var...
1460 1530
 			$_SESSION['becomesUnapproved'] = true;
1461
-		}
1462
-
1463
-		elseif ($topic_info['id_member_started'] != $user_info['id'])
1531
+		} elseif ($topic_info['id_member_started'] != $user_info['id'])
1464 1532
 		{
1465
-			if ($modSettings['postmod_active'] && allowedTo('post_unapproved_replies_any') && !allowedTo('post_reply_any'))
1466
-				$becomesApproved = false;
1467
-
1468
-			else
1469
-				isAllowedTo('post_reply_any');
1470
-		}
1471
-		elseif (!allowedTo('post_reply_any'))
1533
+			if ($modSettings['postmod_active'] && allowedTo('post_unapproved_replies_any') && !allowedTo('post_reply_any')) {
1534
+							$becomesApproved = false;
1535
+			} else {
1536
+							isAllowedTo('post_reply_any');
1537
+			}
1538
+		} elseif (!allowedTo('post_reply_any'))
1472 1539
 		{
1473
-			if ($modSettings['postmod_active'] && allowedTo('post_unapproved_replies_own') && !allowedTo('post_reply_own'))
1474
-				$becomesApproved = false;
1475
-
1476
-			else
1477
-				isAllowedTo('post_reply_own');
1540
+			if ($modSettings['postmod_active'] && allowedTo('post_unapproved_replies_own') && !allowedTo('post_reply_own')) {
1541
+							$becomesApproved = false;
1542
+			} else {
1543
+							isAllowedTo('post_reply_own');
1544
+			}
1478 1545
 		}
1479 1546
 
1480 1547
 		if (isset($_POST['lock']))
1481 1548
 		{
1482 1549
 			// Nothing is changed to the lock.
1483
-			if ((empty($topic_info['locked']) && empty($_POST['lock'])) || (!empty($_POST['lock']) && !empty($topic_info['locked'])))
1484
-				unset($_POST['lock']);
1550
+			if ((empty($topic_info['locked']) && empty($_POST['lock'])) || (!empty($_POST['lock']) && !empty($topic_info['locked']))) {
1551
+							unset($_POST['lock']);
1552
+			}
1485 1553
 
1486 1554
 			// You're have no permission to lock this topic.
1487
-			elseif (!allowedTo(array('lock_any', 'lock_own')) || (!allowedTo('lock_any') && $user_info['id'] != $topic_info['id_member_started']))
1488
-				unset($_POST['lock']);
1555
+			elseif (!allowedTo(array('lock_any', 'lock_own')) || (!allowedTo('lock_any') && $user_info['id'] != $topic_info['id_member_started'])) {
1556
+							unset($_POST['lock']);
1557
+			}
1489 1558
 
1490 1559
 			// You are allowed to (un)lock your own topic only.
1491 1560
 			elseif (!allowedTo('lock_any'))
1492 1561
 			{
1493 1562
 				// You cannot override a moderator lock.
1494
-				if ($topic_info['locked'] == 1)
1495
-					unset($_POST['lock']);
1496
-
1497
-				else
1498
-					$_POST['lock'] = empty($_POST['lock']) ? 0 : 2;
1563
+				if ($topic_info['locked'] == 1) {
1564
+									unset($_POST['lock']);
1565
+				} else {
1566
+									$_POST['lock'] = empty($_POST['lock']) ? 0 : 2;
1567
+				}
1499 1568
 			}
1500 1569
 			// Hail mighty moderator, (un)lock this topic immediately.
1501 1570
 			else
@@ -1503,19 +1572,21 @@  discard block
 block discarded – undo
1503 1572
 				$_POST['lock'] = empty($_POST['lock']) ? 0 : 1;
1504 1573
 
1505 1574
 				// Did someone (un)lock this while you were posting?
1506
-				if (isset($_POST['already_locked']) && $_POST['already_locked'] != $topic_info['locked'])
1507
-					$post_errors[] = 'topic_' . (empty($topic_info['locked']) ? 'un' : '') . 'locked';
1575
+				if (isset($_POST['already_locked']) && $_POST['already_locked'] != $topic_info['locked']) {
1576
+									$post_errors[] = 'topic_' . (empty($topic_info['locked']) ? 'un' : '') . 'locked';
1577
+				}
1508 1578
 			}
1509 1579
 		}
1510 1580
 
1511 1581
 		// So you wanna (un)sticky this...let's see.
1512
-		if (isset($_POST['sticky']) && ($_POST['sticky'] == $topic_info['is_sticky'] || !allowedTo('make_sticky')))
1513
-			unset($_POST['sticky']);
1514
-		elseif (isset($_POST['sticky']))
1582
+		if (isset($_POST['sticky']) && ($_POST['sticky'] == $topic_info['is_sticky'] || !allowedTo('make_sticky'))) {
1583
+					unset($_POST['sticky']);
1584
+		} elseif (isset($_POST['sticky']))
1515 1585
 		{
1516 1586
 			// Did someone (un)sticky this while you were posting?
1517
-			if (isset($_POST['already_sticky']) && $_POST['already_sticky'] != $topic_info['is_sticky'])
1518
-				$post_errors[] = 'topic_' . (empty($topic_info['is_sticky']) ? 'un' : '') . 'sticky';
1587
+			if (isset($_POST['already_sticky']) && $_POST['already_sticky'] != $topic_info['is_sticky']) {
1588
+							$post_errors[] = 'topic_' . (empty($topic_info['is_sticky']) ? 'un' : '') . 'sticky';
1589
+			}
1519 1590
 		}
1520 1591
 
1521 1592
 		// If drafts are enabled, then pass this off
@@ -1542,26 +1613,31 @@  discard block
 block discarded – undo
1542 1613
 
1543 1614
 		// Do like, the permissions, for safety and stuff...
1544 1615
 		$becomesApproved = true;
1545
-		if ($modSettings['postmod_active'] && !allowedTo('post_new') && allowedTo('post_unapproved_topics'))
1546
-			$becomesApproved = false;
1547
-		else
1548
-			isAllowedTo('post_new');
1616
+		if ($modSettings['postmod_active'] && !allowedTo('post_new') && allowedTo('post_unapproved_topics')) {
1617
+					$becomesApproved = false;
1618
+		} else {
1619
+					isAllowedTo('post_new');
1620
+		}
1549 1621
 
1550 1622
 		if (isset($_POST['lock']))
1551 1623
 		{
1552 1624
 			// New topics are by default not locked.
1553
-			if (empty($_POST['lock']))
1554
-				unset($_POST['lock']);
1625
+			if (empty($_POST['lock'])) {
1626
+							unset($_POST['lock']);
1627
+			}
1555 1628
 			// Besides, you need permission.
1556
-			elseif (!allowedTo(array('lock_any', 'lock_own')))
1557
-				unset($_POST['lock']);
1629
+			elseif (!allowedTo(array('lock_any', 'lock_own'))) {
1630
+							unset($_POST['lock']);
1631
+			}
1558 1632
 			// A moderator-lock (1) can override a user-lock (2).
1559
-			else
1560
-				$_POST['lock'] = allowedTo('lock_any') ? 1 : 2;
1633
+			else {
1634
+							$_POST['lock'] = allowedTo('lock_any') ? 1 : 2;
1635
+			}
1561 1636
 		}
1562 1637
 
1563
-		if (isset($_POST['sticky']) && (empty($_POST['sticky']) || !allowedTo('make_sticky')))
1564
-			unset($_POST['sticky']);
1638
+		if (isset($_POST['sticky']) && (empty($_POST['sticky']) || !allowedTo('make_sticky'))) {
1639
+					unset($_POST['sticky']);
1640
+		}
1565 1641
 
1566 1642
 		// Saving your new topic as a draft first?
1567 1643
 		if (!empty($modSettings['drafts_post_enabled']) && isset($_POST['save_draft']))
@@ -1586,31 +1662,37 @@  discard block
 block discarded – undo
1586 1662
 				'id_msg' => $_REQUEST['msg'],
1587 1663
 			)
1588 1664
 		);
1589
-		if ($smcFunc['db_num_rows']($request) == 0)
1590
-			fatal_lang_error('cant_find_messages', false);
1665
+		if ($smcFunc['db_num_rows']($request) == 0) {
1666
+					fatal_lang_error('cant_find_messages', false);
1667
+		}
1591 1668
 		$row = $smcFunc['db_fetch_assoc']($request);
1592 1669
 		$smcFunc['db_free_result']($request);
1593 1670
 
1594
-		if (!empty($topic_info['locked']) && !allowedTo('moderate_board'))
1595
-			fatal_lang_error('topic_locked', false);
1671
+		if (!empty($topic_info['locked']) && !allowedTo('moderate_board')) {
1672
+					fatal_lang_error('topic_locked', false);
1673
+		}
1596 1674
 
1597 1675
 		if (isset($_POST['lock']))
1598 1676
 		{
1599 1677
 			// Nothing changes to the lock status.
1600
-			if ((empty($_POST['lock']) && empty($topic_info['locked'])) || (!empty($_POST['lock']) && !empty($topic_info['locked'])))
1601
-				unset($_POST['lock']);
1678
+			if ((empty($_POST['lock']) && empty($topic_info['locked'])) || (!empty($_POST['lock']) && !empty($topic_info['locked']))) {
1679
+							unset($_POST['lock']);
1680
+			}
1602 1681
 			// You're simply not allowed to (un)lock this.
1603
-			elseif (!allowedTo(array('lock_any', 'lock_own')) || (!allowedTo('lock_any') && $user_info['id'] != $topic_info['id_member_started']))
1604
-				unset($_POST['lock']);
1682
+			elseif (!allowedTo(array('lock_any', 'lock_own')) || (!allowedTo('lock_any') && $user_info['id'] != $topic_info['id_member_started'])) {
1683
+							unset($_POST['lock']);
1684
+			}
1605 1685
 			// You're only allowed to lock your own topics.
1606 1686
 			elseif (!allowedTo('lock_any'))
1607 1687
 			{
1608 1688
 				// You're not allowed to break a moderator's lock.
1609
-				if ($topic_info['locked'] == 1)
1610
-					unset($_POST['lock']);
1689
+				if ($topic_info['locked'] == 1) {
1690
+									unset($_POST['lock']);
1691
+				}
1611 1692
 				// Lock it with a soft lock or unlock it.
1612
-				else
1613
-					$_POST['lock'] = empty($_POST['lock']) ? 0 : 2;
1693
+				else {
1694
+									$_POST['lock'] = empty($_POST['lock']) ? 0 : 2;
1695
+				}
1614 1696
 			}
1615 1697
 			// You must be the moderator.
1616 1698
 			else
@@ -1618,44 +1700,46 @@  discard block
 block discarded – undo
1618 1700
 				$_POST['lock'] = empty($_POST['lock']) ? 0 : 1;
1619 1701
 
1620 1702
 				// Did someone (un)lock this while you were posting?
1621
-				if (isset($_POST['already_locked']) && $_POST['already_locked'] != $topic_info['locked'])
1622
-					$post_errors[] = 'topic_' . (empty($topic_info['locked']) ? 'un' : '') . 'locked';
1703
+				if (isset($_POST['already_locked']) && $_POST['already_locked'] != $topic_info['locked']) {
1704
+									$post_errors[] = 'topic_' . (empty($topic_info['locked']) ? 'un' : '') . 'locked';
1705
+				}
1623 1706
 			}
1624 1707
 		}
1625 1708
 
1626 1709
 		// Change the sticky status of this topic?
1627
-		if (isset($_POST['sticky']) && (!allowedTo('make_sticky') || $_POST['sticky'] == $topic_info['is_sticky']))
1628
-			unset($_POST['sticky']);
1629
-		elseif (isset($_POST['sticky']))
1710
+		if (isset($_POST['sticky']) && (!allowedTo('make_sticky') || $_POST['sticky'] == $topic_info['is_sticky'])) {
1711
+					unset($_POST['sticky']);
1712
+		} elseif (isset($_POST['sticky']))
1630 1713
 		{
1631 1714
 			// Did someone (un)sticky this while you were posting?
1632
-			if (isset($_POST['already_sticky']) && $_POST['already_sticky'] != $topic_info['is_sticky'])
1633
-				$post_errors[] = 'topic_' . (empty($topic_info['locked']) ? 'un' : '') . 'stickied';
1715
+			if (isset($_POST['already_sticky']) && $_POST['already_sticky'] != $topic_info['is_sticky']) {
1716
+							$post_errors[] = 'topic_' . (empty($topic_info['locked']) ? 'un' : '') . 'stickied';
1717
+			}
1634 1718
 		}
1635 1719
 
1636 1720
 		if ($row['id_member'] == $user_info['id'] && !allowedTo('modify_any'))
1637 1721
 		{
1638
-			if ((!$modSettings['postmod_active'] || $row['approved']) && !empty($modSettings['edit_disable_time']) && $row['poster_time'] + ($modSettings['edit_disable_time'] + 5) * 60 < time())
1639
-				fatal_lang_error('modify_post_time_passed', false);
1640
-			elseif ($topic_info['id_member_started'] == $user_info['id'] && !allowedTo('modify_own'))
1641
-				isAllowedTo('modify_replies');
1642
-			else
1643
-				isAllowedTo('modify_own');
1644
-		}
1645
-		elseif ($topic_info['id_member_started'] == $user_info['id'] && !allowedTo('modify_any'))
1722
+			if ((!$modSettings['postmod_active'] || $row['approved']) && !empty($modSettings['edit_disable_time']) && $row['poster_time'] + ($modSettings['edit_disable_time'] + 5) * 60 < time()) {
1723
+							fatal_lang_error('modify_post_time_passed', false);
1724
+			} elseif ($topic_info['id_member_started'] == $user_info['id'] && !allowedTo('modify_own')) {
1725
+							isAllowedTo('modify_replies');
1726
+			} else {
1727
+							isAllowedTo('modify_own');
1728
+			}
1729
+		} elseif ($topic_info['id_member_started'] == $user_info['id'] && !allowedTo('modify_any'))
1646 1730
 		{
1647 1731
 			isAllowedTo('modify_replies');
1648 1732
 
1649 1733
 			// If you're modifying a reply, I say it better be logged...
1650 1734
 			$moderationAction = true;
1651
-		}
1652
-		else
1735
+		} else
1653 1736
 		{
1654 1737
 			isAllowedTo('modify_any');
1655 1738
 
1656 1739
 			// Log it, assuming you're not modifying your own post.
1657
-			if ($row['id_member'] != $user_info['id'])
1658
-				$moderationAction = true;
1740
+			if ($row['id_member'] != $user_info['id']) {
1741
+							$moderationAction = true;
1742
+			}
1659 1743
 		}
1660 1744
 
1661 1745
 		// If drafts are enabled, then lets send this off to save
@@ -1692,20 +1776,24 @@  discard block
 block discarded – undo
1692 1776
 		$_POST['guestname'] = !isset($_POST['guestname']) ? '' : trim($_POST['guestname']);
1693 1777
 		$_POST['email'] = !isset($_POST['email']) ? '' : trim($_POST['email']);
1694 1778
 
1695
-		if ($_POST['guestname'] == '' || $_POST['guestname'] == '_')
1696
-			$post_errors[] = 'no_name';
1697
-		if ($smcFunc['strlen']($_POST['guestname']) > 25)
1698
-			$post_errors[] = 'long_name';
1779
+		if ($_POST['guestname'] == '' || $_POST['guestname'] == '_') {
1780
+					$post_errors[] = 'no_name';
1781
+		}
1782
+		if ($smcFunc['strlen']($_POST['guestname']) > 25) {
1783
+					$post_errors[] = 'long_name';
1784
+		}
1699 1785
 
1700 1786
 		if (empty($modSettings['guest_post_no_email']))
1701 1787
 		{
1702 1788
 			// Only check if they changed it!
1703 1789
 			if (!isset($row) || $row['poster_email'] != $_POST['email'])
1704 1790
 			{
1705
-				if (!allowedTo('moderate_forum') && (!isset($_POST['email']) || $_POST['email'] == ''))
1706
-					$post_errors[] = 'no_email';
1707
-				if (!allowedTo('moderate_forum') && !filter_var($_POST['email'], FILTER_VALIDATE_EMAIL))
1708
-					$post_errors[] = 'bad_email';
1791
+				if (!allowedTo('moderate_forum') && (!isset($_POST['email']) || $_POST['email'] == '')) {
1792
+									$post_errors[] = 'no_email';
1793
+				}
1794
+				if (!allowedTo('moderate_forum') && !filter_var($_POST['email'], FILTER_VALIDATE_EMAIL)) {
1795
+									$post_errors[] = 'bad_email';
1796
+				}
1709 1797
 			}
1710 1798
 
1711 1799
 			// Now make sure this email address is not banned from posting.
@@ -1721,75 +1809,89 @@  discard block
 block discarded – undo
1721 1809
 	}
1722 1810
 
1723 1811
 	// Coming from the quickReply?
1724
-	if (isset($_POST['quickReply']))
1725
-		$_POST['message'] = $_POST['quickReply'];
1812
+	if (isset($_POST['quickReply'])) {
1813
+			$_POST['message'] = $_POST['quickReply'];
1814
+	}
1726 1815
 
1727 1816
 	// Check the subject and message.
1728
-	if (!isset($_POST['subject']) || $smcFunc['htmltrim']($smcFunc['htmlspecialchars']($_POST['subject'])) === '')
1729
-		$post_errors[] = 'no_subject';
1730
-	if (!isset($_POST['message']) || $smcFunc['htmltrim']($smcFunc['htmlspecialchars']($_POST['message']), ENT_QUOTES) === '')
1731
-		$post_errors[] = 'no_message';
1732
-	elseif (!empty($modSettings['max_messageLength']) && $smcFunc['strlen']($_POST['message']) > $modSettings['max_messageLength'])
1733
-		$post_errors[] = array('long_message', array($modSettings['max_messageLength']));
1734
-	else
1817
+	if (!isset($_POST['subject']) || $smcFunc['htmltrim']($smcFunc['htmlspecialchars']($_POST['subject'])) === '') {
1818
+			$post_errors[] = 'no_subject';
1819
+	}
1820
+	if (!isset($_POST['message']) || $smcFunc['htmltrim']($smcFunc['htmlspecialchars']($_POST['message']), ENT_QUOTES) === '') {
1821
+			$post_errors[] = 'no_message';
1822
+	} elseif (!empty($modSettings['max_messageLength']) && $smcFunc['strlen']($_POST['message']) > $modSettings['max_messageLength']) {
1823
+			$post_errors[] = array('long_message', array($modSettings['max_messageLength']));
1824
+	} else
1735 1825
 	{
1736 1826
 		// Prepare the message a bit for some additional testing.
1737 1827
 		$_POST['message'] = $smcFunc['htmlspecialchars']($_POST['message'], ENT_QUOTES);
1738 1828
 
1739 1829
 		// Preparse code. (Zef)
1740
-		if ($user_info['is_guest'])
1741
-			$user_info['name'] = $_POST['guestname'];
1830
+		if ($user_info['is_guest']) {
1831
+					$user_info['name'] = $_POST['guestname'];
1832
+		}
1742 1833
 		preparsecode($_POST['message']);
1743 1834
 
1744 1835
 		// Let's see if there's still some content left without the tags.
1745
-		if ($smcFunc['htmltrim'](strip_tags(parse_bbc($_POST['message'], false), implode('', $context['allowed_html_tags']))) === '' && (!allowedTo('admin_forum') || strpos($_POST['message'], '[html]') === false))
1746
-			$post_errors[] = 'no_message';
1836
+		if ($smcFunc['htmltrim'](strip_tags(parse_bbc($_POST['message'], false), implode('', $context['allowed_html_tags']))) === '' && (!allowedTo('admin_forum') || strpos($_POST['message'], '[html]') === false)) {
1837
+					$post_errors[] = 'no_message';
1838
+		}
1839
+	}
1840
+	if (isset($_POST['calendar']) && !isset($_REQUEST['deleteevent']) && $smcFunc['htmltrim']($_POST['evtitle']) === '') {
1841
+			$post_errors[] = 'no_event';
1747 1842
 	}
1748
-	if (isset($_POST['calendar']) && !isset($_REQUEST['deleteevent']) && $smcFunc['htmltrim']($_POST['evtitle']) === '')
1749
-		$post_errors[] = 'no_event';
1750 1843
 	// You are not!
1751
-	if (isset($_POST['message']) && strtolower($_POST['message']) == 'i am the administrator.' && !$user_info['is_admin'])
1752
-		fatal_error('Knave! Masquerader! Charlatan!', false);
1844
+	if (isset($_POST['message']) && strtolower($_POST['message']) == 'i am the administrator.' && !$user_info['is_admin']) {
1845
+			fatal_error('Knave! Masquerader! Charlatan!', false);
1846
+	}
1753 1847
 
1754 1848
 	// Validate the poll...
1755 1849
 	if (isset($_REQUEST['poll']) && $modSettings['pollMode'] == '1')
1756 1850
 	{
1757
-		if (!empty($topic) && !isset($_REQUEST['msg']))
1758
-			fatal_lang_error('no_access', false);
1851
+		if (!empty($topic) && !isset($_REQUEST['msg'])) {
1852
+					fatal_lang_error('no_access', false);
1853
+		}
1759 1854
 
1760 1855
 		// This is a new topic... so it's a new poll.
1761
-		if (empty($topic))
1762
-			isAllowedTo('poll_post');
1856
+		if (empty($topic)) {
1857
+					isAllowedTo('poll_post');
1858
+		}
1763 1859
 		// Can you add to your own topics?
1764
-		elseif ($user_info['id'] == $topic_info['id_member_started'] && !allowedTo('poll_add_any'))
1765
-			isAllowedTo('poll_add_own');
1860
+		elseif ($user_info['id'] == $topic_info['id_member_started'] && !allowedTo('poll_add_any')) {
1861
+					isAllowedTo('poll_add_own');
1862
+		}
1766 1863
 		// Can you add polls to any topic, then?
1767
-		else
1768
-			isAllowedTo('poll_add_any');
1864
+		else {
1865
+					isAllowedTo('poll_add_any');
1866
+		}
1769 1867
 
1770
-		if (!isset($_POST['question']) || trim($_POST['question']) == '')
1771
-			$post_errors[] = 'no_question';
1868
+		if (!isset($_POST['question']) || trim($_POST['question']) == '') {
1869
+					$post_errors[] = 'no_question';
1870
+		}
1772 1871
 
1773 1872
 		$_POST['options'] = empty($_POST['options']) ? array() : htmltrim__recursive($_POST['options']);
1774 1873
 
1775 1874
 		// Get rid of empty ones.
1776
-		foreach ($_POST['options'] as $k => $option)
1777
-			if ($option == '')
1875
+		foreach ($_POST['options'] as $k => $option) {
1876
+					if ($option == '')
1778 1877
 				unset($_POST['options'][$k], $_POST['options'][$k]);
1878
+		}
1779 1879
 
1780 1880
 		// What are you going to vote between with one choice?!?
1781
-		if (count($_POST['options']) < 2)
1782
-			$post_errors[] = 'poll_few';
1783
-		elseif (count($_POST['options']) > 256)
1784
-			$post_errors[] = 'poll_many';
1881
+		if (count($_POST['options']) < 2) {
1882
+					$post_errors[] = 'poll_few';
1883
+		} elseif (count($_POST['options']) > 256) {
1884
+					$post_errors[] = 'poll_many';
1885
+		}
1785 1886
 	}
1786 1887
 
1787 1888
 	if ($posterIsGuest)
1788 1889
 	{
1789 1890
 		// If user is a guest, make sure the chosen name isn't taken.
1790 1891
 		require_once($sourcedir . '/Subs-Members.php');
1791
-		if (isReservedName($_POST['guestname'], 0, true, false) && (!isset($row['poster_name']) || $_POST['guestname'] != $row['poster_name']))
1792
-			$post_errors[] = 'bad_name';
1892
+		if (isReservedName($_POST['guestname'], 0, true, false) && (!isset($row['poster_name']) || $_POST['guestname'] != $row['poster_name'])) {
1893
+					$post_errors[] = 'bad_name';
1894
+		}
1793 1895
 	}
1794 1896
 	// If the user isn't a guest, get his or her name and email.
1795 1897
 	elseif (!isset($_REQUEST['msg']))
@@ -1820,8 +1922,9 @@  discard block
 block discarded – undo
1820 1922
 	}
1821 1923
 
1822 1924
 	// Make sure the user isn't spamming the board.
1823
-	if (!isset($_REQUEST['msg']))
1824
-		spamProtection('post');
1925
+	if (!isset($_REQUEST['msg'])) {
1926
+			spamProtection('post');
1927
+	}
1825 1928
 
1826 1929
 	// At about this point, we're posting and that's that.
1827 1930
 	ignore_user_abort(true);
@@ -1834,32 +1937,36 @@  discard block
 block discarded – undo
1834 1937
 	$_POST['modify_reason'] = empty($_POST['modify_reason']) ? '' : strtr($smcFunc['htmlspecialchars']($_POST['modify_reason']), array("\r" => '', "\n" => '', "\t" => ''));
1835 1938
 
1836 1939
 	// At this point, we want to make sure the subject isn't too long.
1837
-	if ($smcFunc['strlen']($_POST['subject']) > 100)
1838
-		$_POST['subject'] = $smcFunc['substr']($_POST['subject'], 0, 100);
1940
+	if ($smcFunc['strlen']($_POST['subject']) > 100) {
1941
+			$_POST['subject'] = $smcFunc['substr']($_POST['subject'], 0, 100);
1942
+	}
1839 1943
 
1840 1944
 	// Same with the "why did you edit this" text.
1841
-	if ($smcFunc['strlen']($_POST['modify_reason']) > 100)
1842
-		$_POST['modify_reason'] = $smcFunc['substr']($_POST['modify_reason'], 0, 100);
1945
+	if ($smcFunc['strlen']($_POST['modify_reason']) > 100) {
1946
+			$_POST['modify_reason'] = $smcFunc['substr']($_POST['modify_reason'], 0, 100);
1947
+	}
1843 1948
 
1844 1949
 	// Make the poll...
1845 1950
 	if (isset($_REQUEST['poll']))
1846 1951
 	{
1847 1952
 		// Make sure that the user has not entered a ridiculous number of options..
1848
-		if (empty($_POST['poll_max_votes']) || $_POST['poll_max_votes'] <= 0)
1849
-			$_POST['poll_max_votes'] = 1;
1850
-		elseif ($_POST['poll_max_votes'] > count($_POST['options']))
1851
-			$_POST['poll_max_votes'] = count($_POST['options']);
1852
-		else
1853
-			$_POST['poll_max_votes'] = (int) $_POST['poll_max_votes'];
1953
+		if (empty($_POST['poll_max_votes']) || $_POST['poll_max_votes'] <= 0) {
1954
+					$_POST['poll_max_votes'] = 1;
1955
+		} elseif ($_POST['poll_max_votes'] > count($_POST['options'])) {
1956
+					$_POST['poll_max_votes'] = count($_POST['options']);
1957
+		} else {
1958
+					$_POST['poll_max_votes'] = (int) $_POST['poll_max_votes'];
1959
+		}
1854 1960
 
1855 1961
 		$_POST['poll_expire'] = (int) $_POST['poll_expire'];
1856 1962
 		$_POST['poll_expire'] = $_POST['poll_expire'] > 9999 ? 9999 : ($_POST['poll_expire'] < 0 ? 0 : $_POST['poll_expire']);
1857 1963
 
1858 1964
 		// Just set it to zero if it's not there..
1859
-		if (!isset($_POST['poll_hide']))
1860
-			$_POST['poll_hide'] = 0;
1861
-		else
1862
-			$_POST['poll_hide'] = (int) $_POST['poll_hide'];
1965
+		if (!isset($_POST['poll_hide'])) {
1966
+					$_POST['poll_hide'] = 0;
1967
+		} else {
1968
+					$_POST['poll_hide'] = (int) $_POST['poll_hide'];
1969
+		}
1863 1970
 		$_POST['poll_change_vote'] = isset($_POST['poll_change_vote']) ? 1 : 0;
1864 1971
 
1865 1972
 		$_POST['poll_guest_vote'] = isset($_POST['poll_guest_vote']) ? 1 : 0;
@@ -1868,16 +1975,19 @@  discard block
 block discarded – undo
1868 1975
 		{
1869 1976
 			require_once($sourcedir . '/Subs-Members.php');
1870 1977
 			$allowedVoteGroups = groupsAllowedTo('poll_vote', $board);
1871
-			if (!in_array(-1, $allowedVoteGroups['allowed']))
1872
-				$_POST['poll_guest_vote'] = 0;
1978
+			if (!in_array(-1, $allowedVoteGroups['allowed'])) {
1979
+							$_POST['poll_guest_vote'] = 0;
1980
+			}
1873 1981
 		}
1874 1982
 
1875 1983
 		// If the user tries to set the poll too far in advance, don't let them.
1876
-		if (!empty($_POST['poll_expire']) && $_POST['poll_expire'] < 1)
1877
-			fatal_lang_error('poll_range_error', false);
1984
+		if (!empty($_POST['poll_expire']) && $_POST['poll_expire'] < 1) {
1985
+					fatal_lang_error('poll_range_error', false);
1986
+		}
1878 1987
 		// Don't allow them to select option 2 for hidden results if it's not time limited.
1879
-		elseif (empty($_POST['poll_expire']) && $_POST['poll_hide'] == 2)
1880
-			$_POST['poll_hide'] = 1;
1988
+		elseif (empty($_POST['poll_expire']) && $_POST['poll_hide'] == 2) {
1989
+					$_POST['poll_hide'] = 1;
1990
+		}
1881 1991
 
1882 1992
 		// Clean up the question and answers.
1883 1993
 		$_POST['question'] = $smcFunc['htmlspecialchars']($_POST['question']);
@@ -1891,13 +2001,15 @@  discard block
 block discarded – undo
1891 2001
 	{
1892 2002
 		$attachIDs = array();
1893 2003
 		$attach_errors = array();
1894
-		if (!empty($context['we_are_history']))
1895
-			$attach_errors[] = '<dd>' . $txt['error_temp_attachments_flushed'] . '<br><br></dd>';
2004
+		if (!empty($context['we_are_history'])) {
2005
+					$attach_errors[] = '<dd>' . $txt['error_temp_attachments_flushed'] . '<br><br></dd>';
2006
+		}
1896 2007
 
1897 2008
 		foreach ($_SESSION['temp_attachments'] as  $attachID => $attachment)
1898 2009
 		{
1899
-			if ($attachID != 'initial_error' && strpos($attachID, 'post_tmp_' . $user_info['id']) === false)
1900
-				continue;
2010
+			if ($attachID != 'initial_error' && strpos($attachID, 'post_tmp_' . $user_info['id']) === false) {
2011
+							continue;
2012
+			}
1901 2013
 
1902 2014
 			// If there was an initial error just show that message.
1903 2015
 			if ($attachID == 'initial_error')
@@ -1926,12 +2038,13 @@  discard block
 block discarded – undo
1926 2038
 				if (createAttachment($attachmentOptions))
1927 2039
 				{
1928 2040
 					$attachIDs[] = $attachmentOptions['id'];
1929
-					if (!empty($attachmentOptions['thumb']))
1930
-						$attachIDs[] = $attachmentOptions['thumb'];
2041
+					if (!empty($attachmentOptions['thumb'])) {
2042
+											$attachIDs[] = $attachmentOptions['thumb'];
2043
+					}
1931 2044
 				}
2045
+			} else {
2046
+							$attach_errors[] = '<dt>&nbsp;</dt>';
1932 2047
 			}
1933
-			else
1934
-				$attach_errors[] = '<dt>&nbsp;</dt>';
1935 2048
 
1936 2049
 			if (!empty($attachmentOptions['errors']))
1937 2050
 			{
@@ -1943,14 +2056,16 @@  discard block
 block discarded – undo
1943 2056
 					if (!is_array($error))
1944 2057
 					{
1945 2058
 						$attach_errors[] = '<dd>' . $txt[$error] . '</dd>';
1946
-						if (in_array($error, $log_these))
1947
-							log_error($attachment['name'] . ': ' . $txt[$error], 'critical');
2059
+						if (in_array($error, $log_these)) {
2060
+													log_error($attachment['name'] . ': ' . $txt[$error], 'critical');
2061
+						}
2062
+					} else {
2063
+											$attach_errors[] = '<dd>' . vsprintf($txt[$error[0]], $error[1]) . '</dd>';
1948 2064
 					}
1949
-					else
1950
-						$attach_errors[] = '<dd>' . vsprintf($txt[$error[0]], $error[1]) . '</dd>';
1951 2065
 				}
1952
-				if (file_exists($attachment['tmp_name']))
1953
-					unlink($attachment['tmp_name']);
2066
+				if (file_exists($attachment['tmp_name'])) {
2067
+									unlink($attachment['tmp_name']);
2068
+				}
1954 2069
 			}
1955 2070
 		}
1956 2071
 		unset($_SESSION['temp_attachments']);
@@ -1991,24 +2106,24 @@  discard block
 block discarded – undo
1991 2106
 		);
1992 2107
 
1993 2108
 		call_integration_hook('integrate_poll_add_edit', array($id_poll, false));
2109
+	} else {
2110
+			$id_poll = 0;
1994 2111
 	}
1995
-	else
1996
-		$id_poll = 0;
1997 2112
 
1998 2113
 	// Creating a new topic?
1999 2114
 	$newTopic = empty($_REQUEST['msg']) && empty($topic);
2000 2115
 
2001 2116
 	// Check the icon.
2002
-	if (!isset($_POST['icon']))
2003
-		$_POST['icon'] = 'xx';
2004
-
2005
-	else
2117
+	if (!isset($_POST['icon'])) {
2118
+			$_POST['icon'] = 'xx';
2119
+	} else
2006 2120
 	{
2007 2121
 		$_POST['icon'] = $smcFunc['htmlspecialchars']($_POST['icon']);
2008 2122
 
2009 2123
 		// Need to figure it out if this is a valid icon name.
2010
-		if ((!file_exists($settings['theme_dir'] . '/images/post/' . $_POST['icon'] . '.png')) && (!file_exists($settings['default_theme_dir'] . '/images/post/' . $_POST['icon'] . '.png')))
2011
-			$_POST['icon'] = 'xx';
2124
+		if ((!file_exists($settings['theme_dir'] . '/images/post/' . $_POST['icon'] . '.png')) && (!file_exists($settings['default_theme_dir'] . '/images/post/' . $_POST['icon'] . '.png'))) {
2125
+					$_POST['icon'] = 'xx';
2126
+		}
2012 2127
 	}
2013 2128
 
2014 2129
 	// Collect all parameters for the creation or modification of a post.
@@ -2049,8 +2164,9 @@  discard block
 block discarded – undo
2049 2164
 		}
2050 2165
 
2051 2166
 		// This will save some time...
2052
-		if (empty($approve_has_changed))
2053
-			unset($msgOptions['approved']);
2167
+		if (empty($approve_has_changed)) {
2168
+					unset($msgOptions['approved']);
2169
+		}
2054 2170
 
2055 2171
 		modifyPost($msgOptions, $topicOptions, $posterOptions);
2056 2172
 	}
@@ -2059,8 +2175,9 @@  discard block
 block discarded – undo
2059 2175
 	{
2060 2176
 		createPost($msgOptions, $topicOptions, $posterOptions);
2061 2177
 
2062
-		if (isset($topicOptions['id']))
2063
-			$topic = $topicOptions['id'];
2178
+		if (isset($topicOptions['id'])) {
2179
+					$topic = $topicOptions['id'];
2180
+		}
2064 2181
 	}
2065 2182
 
2066 2183
 	// Assign the previously uploaded attachments to the brand new message.
@@ -2072,8 +2189,9 @@  discard block
 block discarded – undo
2072 2189
 	}
2073 2190
 
2074 2191
 	// If we had a draft for this, its time to remove it since it was just posted
2075
-	if (!empty($modSettings['drafts_post_enabled']) && !empty($_POST['id_draft']))
2076
-		DeleteDraft($_POST['id_draft']);
2192
+	if (!empty($modSettings['drafts_post_enabled']) && !empty($_POST['id_draft'])) {
2193
+			DeleteDraft($_POST['id_draft']);
2194
+	}
2077 2195
 
2078 2196
 	// Editing or posting an event?
2079 2197
 	if (isset($_POST['calendar']) && (!isset($_REQUEST['eventid']) || $_REQUEST['eventid'] == -1))
@@ -2092,8 +2210,7 @@  discard block
 block discarded – undo
2092 2210
 			'member' => $user_info['id'],
2093 2211
 		);
2094 2212
 		insertEvent($eventOptions);
2095
-	}
2096
-	elseif (isset($_POST['calendar']))
2213
+	} elseif (isset($_POST['calendar']))
2097 2214
 	{
2098 2215
 		$_REQUEST['eventid'] = (int) $_REQUEST['eventid'];
2099 2216
 
@@ -2121,14 +2238,15 @@  discard block
 block discarded – undo
2121 2238
 		}
2122 2239
 
2123 2240
 		// Delete it?
2124
-		if (isset($_REQUEST['deleteevent']))
2125
-			$smcFunc['db_query']('', '
2241
+		if (isset($_REQUEST['deleteevent'])) {
2242
+					$smcFunc['db_query']('', '
2126 2243
 				DELETE FROM {db_prefix}calendar
2127 2244
 				WHERE id_event = {int:id_event}',
2128 2245
 				array(
2129 2246
 					'id_event' => $_REQUEST['eventid'],
2130 2247
 				)
2131 2248
 			);
2249
+		}
2132 2250
 		// ... or just update it?
2133 2251
 		else
2134 2252
 		{
@@ -2170,9 +2288,8 @@  discard block
 block discarded – undo
2170 2288
 			array($user_info['id'], $topic, 0),
2171 2289
 			array('id_member', 'id_topic', 'id_board')
2172 2290
 		);
2173
-	}
2174
-	elseif (!$newTopic)
2175
-		$smcFunc['db_query']('', '
2291
+	} elseif (!$newTopic) {
2292
+			$smcFunc['db_query']('', '
2176 2293
 			DELETE FROM {db_prefix}log_notify
2177 2294
 			WHERE id_member = {int:current_member}
2178 2295
 				AND id_topic = {int:current_topic}',
@@ -2181,16 +2298,20 @@  discard block
 block discarded – undo
2181 2298
 				'current_topic' => $topic,
2182 2299
 			)
2183 2300
 		);
2301
+	}
2184 2302
 
2185 2303
 	// Log an act of moderation - modifying.
2186
-	if (!empty($moderationAction))
2187
-		logAction('modify', array('topic' => $topic, 'message' => (int) $_REQUEST['msg'], 'member' => $row['id_member'], 'board' => $board));
2304
+	if (!empty($moderationAction)) {
2305
+			logAction('modify', array('topic' => $topic, 'message' => (int) $_REQUEST['msg'], 'member' => $row['id_member'], 'board' => $board));
2306
+	}
2188 2307
 
2189
-	if (isset($_POST['lock']) && $_POST['lock'] != 2)
2190
-		logAction(empty($_POST['lock']) ? 'unlock' : 'lock', array('topic' => $topicOptions['id'], 'board' => $topicOptions['board']));
2308
+	if (isset($_POST['lock']) && $_POST['lock'] != 2) {
2309
+			logAction(empty($_POST['lock']) ? 'unlock' : 'lock', array('topic' => $topicOptions['id'], 'board' => $topicOptions['board']));
2310
+	}
2191 2311
 
2192
-	if (isset($_POST['sticky']))
2193
-		logAction(empty($_POST['sticky']) ? 'unsticky' : 'sticky', array('topic' => $topicOptions['id'], 'board' => $topicOptions['board']));
2312
+	if (isset($_POST['sticky'])) {
2313
+			logAction(empty($_POST['sticky']) ? 'unsticky' : 'sticky', array('topic' => $topicOptions['id'], 'board' => $topicOptions['board']));
2314
+	}
2194 2315
 
2195 2316
 	// Returning to the topic?
2196 2317
 	if (!empty($_REQUEST['goback']))
@@ -2209,26 +2330,31 @@  discard block
 block discarded – undo
2209 2330
 		);
2210 2331
 	}
2211 2332
 
2212
-	if ($board_info['num_topics'] == 0)
2213
-		cache_put_data('board-' . $board, null, 120);
2333
+	if ($board_info['num_topics'] == 0) {
2334
+			cache_put_data('board-' . $board, null, 120);
2335
+	}
2214 2336
 
2215 2337
 	call_integration_hook('integrate_post2_end');
2216 2338
 
2217
-	if (!empty($_POST['announce_topic']))
2218
-		redirectexit('action=announce;sa=selectgroup;topic=' . $topic . (!empty($_POST['move']) && allowedTo('move_any') ? ';move' : '') . (empty($_REQUEST['goback']) ? '' : ';goback'));
2339
+	if (!empty($_POST['announce_topic'])) {
2340
+			redirectexit('action=announce;sa=selectgroup;topic=' . $topic . (!empty($_POST['move']) && allowedTo('move_any') ? ';move' : '') . (empty($_REQUEST['goback']) ? '' : ';goback'));
2341
+	}
2219 2342
 
2220
-	if (!empty($_POST['move']) && allowedTo('move_any'))
2221
-		redirectexit('action=movetopic;topic=' . $topic . '.0' . (empty($_REQUEST['goback']) ? '' : ';goback'));
2343
+	if (!empty($_POST['move']) && allowedTo('move_any')) {
2344
+			redirectexit('action=movetopic;topic=' . $topic . '.0' . (empty($_REQUEST['goback']) ? '' : ';goback'));
2345
+	}
2222 2346
 
2223 2347
 	// Return to post if the mod is on.
2224
-	if (isset($_REQUEST['msg']) && !empty($_REQUEST['goback']))
2225
-		redirectexit('topic=' . $topic . '.msg' . $_REQUEST['msg'] . '#msg' . $_REQUEST['msg'], isBrowser('ie'));
2226
-	elseif (!empty($_REQUEST['goback']))
2227
-		redirectexit('topic=' . $topic . '.new#new', isBrowser('ie'));
2348
+	if (isset($_REQUEST['msg']) && !empty($_REQUEST['goback'])) {
2349
+			redirectexit('topic=' . $topic . '.msg' . $_REQUEST['msg'] . '#msg' . $_REQUEST['msg'], isBrowser('ie'));
2350
+	} elseif (!empty($_REQUEST['goback'])) {
2351
+			redirectexit('topic=' . $topic . '.new#new', isBrowser('ie'));
2352
+	}
2228 2353
 	// Dut-dut-duh-duh-DUH-duh-dut-duh-duh!  *dances to the Final Fantasy Fanfare...*
2229
-	else
2230
-		redirectexit('board=' . $board . '.0');
2231
-}
2354
+	else {
2355
+			redirectexit('board=' . $board . '.0');
2356
+	}
2357
+	}
2232 2358
 
2233 2359
 /**
2234 2360
  * Handle the announce topic function (action=announce).
@@ -2246,8 +2372,9 @@  discard block
 block discarded – undo
2246 2372
 
2247 2373
 	validateSession();
2248 2374
 
2249
-	if (empty($topic))
2250
-		fatal_lang_error('topic_gone', false);
2375
+	if (empty($topic)) {
2376
+			fatal_lang_error('topic_gone', false);
2377
+	}
2251 2378
 
2252 2379
 	loadLanguage('Post');
2253 2380
 	loadTemplate('Post');
@@ -2274,8 +2401,9 @@  discard block
 block discarded – undo
2274 2401
 	global $txt, $context, $topic, $board, $board_info, $smcFunc;
2275 2402
 
2276 2403
 	$groups = array_merge($board_info['groups'], array(1));
2277
-	foreach ($groups as $id => $group)
2278
-		$groups[$id] = (int) $group;
2404
+	foreach ($groups as $id => $group) {
2405
+			$groups[$id] = (int) $group;
2406
+	}
2279 2407
 
2280 2408
 	$context['groups'] = array();
2281 2409
 	if (in_array(0, $groups))
@@ -2318,8 +2446,9 @@  discard block
 block discarded – undo
2318 2446
 			'group_list' => $groups,
2319 2447
 		)
2320 2448
 	);
2321
-	while ($row = $smcFunc['db_fetch_assoc']($request))
2322
-		$context['groups'][$row['id_group']]['name'] = $row['group_name'];
2449
+	while ($row = $smcFunc['db_fetch_assoc']($request)) {
2450
+			$context['groups'][$row['id_group']]['name'] = $row['group_name'];
2451
+	}
2323 2452
 	$smcFunc['db_free_result']($request);
2324 2453
 
2325 2454
 	// Get the subject of the topic we're about to announce.
@@ -2361,16 +2490,19 @@  discard block
 block discarded – undo
2361 2490
 	$context['start'] = empty($_REQUEST['start']) ? 0 : (int) $_REQUEST['start'];
2362 2491
 	$groups = array_merge($board_info['groups'], array(1));
2363 2492
 
2364
-	if (isset($_POST['membergroups']))
2365
-		$_POST['who'] = explode(',', $_POST['membergroups']);
2493
+	if (isset($_POST['membergroups'])) {
2494
+			$_POST['who'] = explode(',', $_POST['membergroups']);
2495
+	}
2366 2496
 
2367 2497
 	// Check whether at least one membergroup was selected.
2368
-	if (empty($_POST['who']))
2369
-		fatal_lang_error('no_membergroup_selected');
2498
+	if (empty($_POST['who'])) {
2499
+			fatal_lang_error('no_membergroup_selected');
2500
+	}
2370 2501
 
2371 2502
 	// Make sure all membergroups are integers and can access the board of the announcement.
2372
-	foreach ($_POST['who'] as $id => $mg)
2373
-		$_POST['who'][$id] = in_array((int) $mg, $groups) ? (int) $mg : 0;
2503
+	foreach ($_POST['who'] as $id => $mg) {
2504
+			$_POST['who'][$id] = in_array((int) $mg, $groups) ? (int) $mg : 0;
2505
+	}
2374 2506
 
2375 2507
 	// Get the topic subject and censor it.
2376 2508
 	$request = $smcFunc['db_query']('', '
@@ -2416,12 +2548,13 @@  discard block
 block discarded – undo
2416 2548
 	if ($smcFunc['db_num_rows']($request) == 0)
2417 2549
 	{
2418 2550
 		logAction('announce_topic', array('topic' => $topic), 'user');
2419
-		if (!empty($_REQUEST['move']) && allowedTo('move_any'))
2420
-			redirectexit('action=movetopic;topic=' . $topic . '.0' . (empty($_REQUEST['goback']) ? '' : ';goback'));
2421
-		elseif (!empty($_REQUEST['goback']))
2422
-			redirectexit('topic=' . $topic . '.new;boardseen#new', isBrowser('ie'));
2423
-		else
2424
-			redirectexit('board=' . $board . '.0');
2551
+		if (!empty($_REQUEST['move']) && allowedTo('move_any')) {
2552
+					redirectexit('action=movetopic;topic=' . $topic . '.0' . (empty($_REQUEST['goback']) ? '' : ';goback'));
2553
+		} elseif (!empty($_REQUEST['goback'])) {
2554
+					redirectexit('topic=' . $topic . '.new;boardseen#new', isBrowser('ie'));
2555
+		} else {
2556
+					redirectexit('board=' . $board . '.0');
2557
+		}
2425 2558
 	}
2426 2559
 
2427 2560
 	$announcements = array();
@@ -2440,8 +2573,9 @@  discard block
 block discarded – undo
2440 2573
 	foreach ($rows as $row)
2441 2574
 	{
2442 2575
 		// Force them to have it?
2443
-		if (empty($prefs[$row['id_member']]['announcements']))
2444
-			continue;
2576
+		if (empty($prefs[$row['id_member']]['announcements'])) {
2577
+					continue;
2578
+		}
2445 2579
 
2446 2580
 		$cur_language = empty($row['lngfile']) || empty($modSettings['userLanguage']) ? $language : $row['lngfile'];
2447 2581
 
@@ -2469,8 +2603,9 @@  discard block
 block discarded – undo
2469 2603
 	}
2470 2604
 
2471 2605
 	// For each language send a different mail - low priority...
2472
-	foreach ($announcements as $lang => $mail)
2473
-		sendmail($mail['recipients'], $mail['subject'], $mail['body'], null, 'ann-' . $lang, $mail['is_html'], 5);
2606
+	foreach ($announcements as $lang => $mail) {
2607
+			sendmail($mail['recipients'], $mail['subject'], $mail['body'], null, 'ann-' . $lang, $mail['is_html'], 5);
2608
+	}
2474 2609
 
2475 2610
 	$context['percentage_done'] = round(100 * $context['start'] / $modSettings['latestMember'], 1);
2476 2611
 
@@ -2480,9 +2615,10 @@  discard block
 block discarded – undo
2480 2615
 	$context['sub_template'] = 'announcement_send';
2481 2616
 
2482 2617
 	// Go back to the correct language for the user ;).
2483
-	if (!empty($modSettings['userLanguage']))
2484
-		loadLanguage('Post');
2485
-}
2618
+	if (!empty($modSettings['userLanguage'])) {
2619
+			loadLanguage('Post');
2620
+	}
2621
+	}
2486 2622
 
2487 2623
 /**
2488 2624
  * Get the topic for display purposes.
@@ -2495,12 +2631,13 @@  discard block
 block discarded – undo
2495 2631
 {
2496 2632
 	global $topic, $modSettings, $context, $smcFunc, $counter, $options;
2497 2633
 
2498
-	if (isset($_REQUEST['xml']))
2499
-		$limit = '
2634
+	if (isset($_REQUEST['xml'])) {
2635
+			$limit = '
2500 2636
 		LIMIT ' . (empty($context['new_replies']) ? '0' : $context['new_replies']);
2501
-	else
2502
-		$limit = empty($modSettings['topicSummaryPosts']) ? '' : '
2637
+	} else {
2638
+			$limit = empty($modSettings['topicSummaryPosts']) ? '' : '
2503 2639
 		LIMIT ' . (int) $modSettings['topicSummaryPosts'];
2640
+	}
2504 2641
 
2505 2642
 	// If you're modifying, get only those posts before the current one. (otherwise get all.)
2506 2643
 	$request = $smcFunc['db_query']('', '
@@ -2538,8 +2675,9 @@  discard block
 block discarded – undo
2538 2675
 			'is_ignored' => !empty($modSettings['enable_buddylist']) && !empty($options['posts_apply_ignore_list']) && in_array($row['id_member'], $context['user']['ignoreusers']),
2539 2676
 		);
2540 2677
 
2541
-		if (!empty($context['new_replies']))
2542
-			$context['new_replies']--;
2678
+		if (!empty($context['new_replies'])) {
2679
+					$context['new_replies']--;
2680
+		}
2543 2681
 	}
2544 2682
 	$smcFunc['db_free_result']($request);
2545 2683
 }
@@ -2556,8 +2694,9 @@  discard block
 block discarded – undo
2556 2694
 	global $sourcedir, $smcFunc;
2557 2695
 
2558 2696
 	loadLanguage('Post');
2559
-	if (!isset($_REQUEST['xml']))
2560
-		loadTemplate('Post');
2697
+	if (!isset($_REQUEST['xml'])) {
2698
+			loadTemplate('Post');
2699
+	}
2561 2700
 
2562 2701
 	include_once($sourcedir . '/Subs-Post.php');
2563 2702
 
@@ -2588,8 +2727,9 @@  discard block
 block discarded – undo
2588 2727
 	$smcFunc['db_free_result']($request);
2589 2728
 
2590 2729
 	$context['sub_template'] = 'quotefast';
2591
-	if (!empty($row))
2592
-		$can_view_post = $row['approved'] || ($row['id_member'] != 0 && $row['id_member'] == $user_info['id']) || allowedTo('approve_posts', $row['id_board']);
2730
+	if (!empty($row)) {
2731
+			$can_view_post = $row['approved'] || ($row['id_member'] != 0 && $row['id_member'] == $user_info['id']) || allowedTo('approve_posts', $row['id_board']);
2732
+	}
2593 2733
 
2594 2734
 	if (!empty($can_view_post))
2595 2735
 	{
@@ -2622,8 +2762,9 @@  discard block
 block discarded – undo
2622 2762
 		}
2623 2763
 
2624 2764
 		// Remove any nested quotes.
2625
-		if (!empty($modSettings['removeNestedQuotes']))
2626
-			$row['body'] = preg_replace(array('~\n?\[quote.*?\].+?\[/quote\]\n?~is', '~^\n~', '~\[/quote\]~'), '', $row['body']);
2765
+		if (!empty($modSettings['removeNestedQuotes'])) {
2766
+					$row['body'] = preg_replace(array('~\n?\[quote.*?\].+?\[/quote\]\n?~is', '~^\n~', '~\[/quote\]~'), '', $row['body']);
2767
+		}
2627 2768
 
2628 2769
 		$lb = "\n";
2629 2770
 
@@ -2649,14 +2790,14 @@  discard block
 block discarded – undo
2649 2790
 				'time' => '',
2650 2791
 			),
2651 2792
 		);
2652
-	}
2653
-	else
2654
-		$context['quote'] = array(
2793
+	} else {
2794
+			$context['quote'] = array(
2655 2795
 			'xml' => '',
2656 2796
 			'mozilla' => '',
2657 2797
 			'text' => '',
2658 2798
 		);
2659
-}
2799
+	}
2800
+	}
2660 2801
 
2661 2802
 /**
2662 2803
  * Used to edit the body or subject of a message inline
@@ -2668,8 +2809,9 @@  discard block
 block discarded – undo
2668 2809
 	global $user_info, $context, $smcFunc, $language, $board_info;
2669 2810
 
2670 2811
 	// We have to have a topic!
2671
-	if (empty($topic))
2672
-		obExit(false);
2812
+	if (empty($topic)) {
2813
+			obExit(false);
2814
+	}
2673 2815
 
2674 2816
 	checkSession('get');
2675 2817
 	require_once($sourcedir . '/Subs-Post.php');
@@ -2695,31 +2837,35 @@  discard block
 block discarded – undo
2695 2837
 			'guest_id' => 0,
2696 2838
 		)
2697 2839
 	);
2698
-	if ($smcFunc['db_num_rows']($request) == 0)
2699
-		fatal_lang_error('no_board', false);
2840
+	if ($smcFunc['db_num_rows']($request) == 0) {
2841
+			fatal_lang_error('no_board', false);
2842
+	}
2700 2843
 	$row = $smcFunc['db_fetch_assoc']($request);
2701 2844
 	$smcFunc['db_free_result']($request);
2702 2845
 
2703 2846
 	// Change either body or subject requires permissions to modify messages.
2704 2847
 	if (isset($_POST['message']) || isset($_POST['subject']) || isset($_REQUEST['icon']))
2705 2848
 	{
2706
-		if (!empty($row['locked']))
2707
-			isAllowedTo('moderate_board');
2849
+		if (!empty($row['locked'])) {
2850
+					isAllowedTo('moderate_board');
2851
+		}
2708 2852
 
2709 2853
 		if ($row['id_member'] == $user_info['id'] && !allowedTo('modify_any'))
2710 2854
 		{
2711
-			if ((!$modSettings['postmod_active'] || $row['approved']) && !empty($modSettings['edit_disable_time']) && $row['poster_time'] + ($modSettings['edit_disable_time'] + 5) * 60 < time())
2712
-				fatal_lang_error('modify_post_time_passed', false);
2713
-			elseif ($row['id_member_started'] == $user_info['id'] && !allowedTo('modify_own'))
2714
-				isAllowedTo('modify_replies');
2715
-			else
2716
-				isAllowedTo('modify_own');
2855
+			if ((!$modSettings['postmod_active'] || $row['approved']) && !empty($modSettings['edit_disable_time']) && $row['poster_time'] + ($modSettings['edit_disable_time'] + 5) * 60 < time()) {
2856
+							fatal_lang_error('modify_post_time_passed', false);
2857
+			} elseif ($row['id_member_started'] == $user_info['id'] && !allowedTo('modify_own')) {
2858
+							isAllowedTo('modify_replies');
2859
+			} else {
2860
+							isAllowedTo('modify_own');
2861
+			}
2717 2862
 		}
2718 2863
 		// Otherwise, they're locked out; someone who can modify the replies is needed.
2719
-		elseif ($row['id_member_started'] == $user_info['id'] && !allowedTo('modify_any'))
2720
-			isAllowedTo('modify_replies');
2721
-		else
2722
-			isAllowedTo('modify_any');
2864
+		elseif ($row['id_member_started'] == $user_info['id'] && !allowedTo('modify_any')) {
2865
+					isAllowedTo('modify_replies');
2866
+		} else {
2867
+					isAllowedTo('modify_any');
2868
+		}
2723 2869
 
2724 2870
 		// Only log this action if it wasn't your message.
2725 2871
 		$moderationAction = $row['id_member'] != $user_info['id'];
@@ -2731,10 +2877,10 @@  discard block
 block discarded – undo
2731 2877
 		$_POST['subject'] = strtr($smcFunc['htmlspecialchars']($_POST['subject']), array("\r" => '', "\n" => '', "\t" => ''));
2732 2878
 
2733 2879
 		// Maximum number of characters.
2734
-		if ($smcFunc['strlen']($_POST['subject']) > 100)
2735
-			$_POST['subject'] = $smcFunc['substr']($_POST['subject'], 0, 100);
2736
-	}
2737
-	elseif (isset($_POST['subject']))
2880
+		if ($smcFunc['strlen']($_POST['subject']) > 100) {
2881
+					$_POST['subject'] = $smcFunc['substr']($_POST['subject'], 0, 100);
2882
+		}
2883
+	} elseif (isset($_POST['subject']))
2738 2884
 	{
2739 2885
 		$post_errors[] = 'no_subject';
2740 2886
 		unset($_POST['subject']);
@@ -2746,13 +2892,11 @@  discard block
 block discarded – undo
2746 2892
 		{
2747 2893
 			$post_errors[] = 'no_message';
2748 2894
 			unset($_POST['message']);
2749
-		}
2750
-		elseif (!empty($modSettings['max_messageLength']) && $smcFunc['strlen']($_POST['message']) > $modSettings['max_messageLength'])
2895
+		} elseif (!empty($modSettings['max_messageLength']) && $smcFunc['strlen']($_POST['message']) > $modSettings['max_messageLength'])
2751 2896
 		{
2752 2897
 			$post_errors[] = 'long_message';
2753 2898
 			unset($_POST['message']);
2754
-		}
2755
-		else
2899
+		} else
2756 2900
 		{
2757 2901
 			$_POST['message'] = $smcFunc['htmlspecialchars']($_POST['message'], ENT_QUOTES);
2758 2902
 
@@ -2768,31 +2912,34 @@  discard block
 block discarded – undo
2768 2912
 
2769 2913
 	if (isset($_POST['lock']))
2770 2914
 	{
2771
-		if (!allowedTo(array('lock_any', 'lock_own')) || (!allowedTo('lock_any') && $user_info['id'] != $row['id_member']))
2772
-			unset($_POST['lock']);
2773
-		elseif (!allowedTo('lock_any'))
2915
+		if (!allowedTo(array('lock_any', 'lock_own')) || (!allowedTo('lock_any') && $user_info['id'] != $row['id_member'])) {
2916
+					unset($_POST['lock']);
2917
+		} elseif (!allowedTo('lock_any'))
2774 2918
 		{
2775
-			if ($row['locked'] == 1)
2776
-				unset($_POST['lock']);
2777
-			else
2778
-				$_POST['lock'] = empty($_POST['lock']) ? 0 : 2;
2919
+			if ($row['locked'] == 1) {
2920
+							unset($_POST['lock']);
2921
+			} else {
2922
+							$_POST['lock'] = empty($_POST['lock']) ? 0 : 2;
2923
+			}
2924
+		} elseif (!empty($row['locked']) && !empty($_POST['lock']) || $_POST['lock'] == $row['locked']) {
2925
+					unset($_POST['lock']);
2926
+		} else {
2927
+					$_POST['lock'] = empty($_POST['lock']) ? 0 : 1;
2779 2928
 		}
2780
-		elseif (!empty($row['locked']) && !empty($_POST['lock']) || $_POST['lock'] == $row['locked'])
2781
-			unset($_POST['lock']);
2782
-		else
2783
-			$_POST['lock'] = empty($_POST['lock']) ? 0 : 1;
2784 2929
 	}
2785 2930
 
2786
-	if (isset($_POST['sticky']) && !allowedTo('make_sticky'))
2787
-		unset($_POST['sticky']);
2931
+	if (isset($_POST['sticky']) && !allowedTo('make_sticky')) {
2932
+			unset($_POST['sticky']);
2933
+	}
2788 2934
 
2789 2935
 	if (isset($_POST['modify_reason']))
2790 2936
 	{
2791 2937
 		$_POST['modify_reason'] = strtr($smcFunc['htmlspecialchars']($_POST['modify_reason']), array("\r" => '', "\n" => '', "\t" => ''));
2792 2938
 
2793 2939
 		// Maximum number of characters.
2794
-		if ($smcFunc['strlen']($_POST['modify_reason']) > 100)
2795
-			$_POST['modify_reason'] = $smcFunc['substr']($_POST['modify_reason'], 0, 100);
2940
+		if ($smcFunc['strlen']($_POST['modify_reason']) > 100) {
2941
+					$_POST['modify_reason'] = $smcFunc['substr']($_POST['modify_reason'], 0, 100);
2942
+		}
2796 2943
 	}
2797 2944
 
2798 2945
 	if (empty($post_errors))
@@ -2829,8 +2976,9 @@  discard block
 block discarded – undo
2829 2976
 			}
2830 2977
 		}
2831 2978
 		// If nothing was changed there's no need to add an entry to the moderation log.
2832
-		else
2833
-			$moderationAction = false;
2979
+		else {
2980
+					$moderationAction = false;
2981
+		}
2834 2982
 
2835 2983
 		modifyPost($msgOptions, $topicOptions, $posterOptions);
2836 2984
 
@@ -2848,9 +2996,9 @@  discard block
 block discarded – undo
2848 2996
 			// Get the proper (default language) response prefix first.
2849 2997
 			if (!isset($context['response_prefix']) && !($context['response_prefix'] = cache_get_data('response_prefix')))
2850 2998
 			{
2851
-				if ($language === $user_info['language'])
2852
-					$context['response_prefix'] = $txt['response_prefix'];
2853
-				else
2999
+				if ($language === $user_info['language']) {
3000
+									$context['response_prefix'] = $txt['response_prefix'];
3001
+				} else
2854 3002
 				{
2855 3003
 					loadLanguage('index', $language, false);
2856 3004
 					$context['response_prefix'] = $txt['response_prefix'];
@@ -2872,8 +3020,9 @@  discard block
 block discarded – undo
2872 3020
 			);
2873 3021
 		}
2874 3022
 
2875
-		if (!empty($moderationAction))
2876
-			logAction('modify', array('topic' => $topic, 'message' => $row['id_msg'], 'member' => $row['id_member'], 'board' => $board));
3023
+		if (!empty($moderationAction)) {
3024
+					logAction('modify', array('topic' => $topic, 'message' => $row['id_msg'], 'member' => $row['id_member'], 'board' => $board));
3025
+		}
2877 3026
 	}
2878 3027
 
2879 3028
 	if (isset($_REQUEST['xml']))
@@ -2914,8 +3063,7 @@  discard block
 block discarded – undo
2914 3063
 			);
2915 3064
 
2916 3065
 			censorText($context['message']['subject']);
2917
-		}
2918
-		else
3066
+		} else
2919 3067
 		{
2920 3068
 			$context['message'] = array(
2921 3069
 				'id' => $row['id_msg'],
@@ -2927,15 +3075,16 @@  discard block
 block discarded – undo
2927 3075
 			loadLanguage('Errors');
2928 3076
 			foreach ($post_errors as $post_error)
2929 3077
 			{
2930
-				if ($post_error == 'long_message')
2931
-					$context['message']['errors'][] = sprintf($txt['error_' . $post_error], $modSettings['max_messageLength']);
2932
-				else
2933
-					$context['message']['errors'][] = $txt['error_' . $post_error];
3078
+				if ($post_error == 'long_message') {
3079
+									$context['message']['errors'][] = sprintf($txt['error_' . $post_error], $modSettings['max_messageLength']);
3080
+				} else {
3081
+									$context['message']['errors'][] = $txt['error_' . $post_error];
3082
+				}
2934 3083
 			}
2935 3084
 		}
3085
+	} else {
3086
+			obExit(false);
3087
+	}
2936 3088
 	}
2937
-	else
2938
-		obExit(false);
2939
-}
2940 3089
 
2941 3090
 ?>
2942 3091
\ No newline at end of file
Please login to merge, or discard this patch.