Complex classes like CSS often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use CSS, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 18 | class CSS extends Minify |
||
| 19 | { |
||
| 20 | /** |
||
| 21 | * @var int |
||
| 22 | */ |
||
| 23 | protected $maxImportSize = 5; |
||
| 24 | |||
| 25 | /** |
||
| 26 | * @var string[] |
||
| 27 | */ |
||
| 28 | protected $importExtensions = array( |
||
| 29 | 'gif' => 'data:image/gif', |
||
| 30 | 'png' => 'data:image/png', |
||
| 31 | 'jpe' => 'data:image/jpeg', |
||
| 32 | 'jpg' => 'data:image/jpeg', |
||
| 33 | 'jpeg' => 'data:image/jpeg', |
||
| 34 | 'svg' => 'data:image/svg+xml', |
||
| 35 | 'woff' => 'data:application/x-font-woff', |
||
| 36 | 'tif' => 'image/tiff', |
||
| 37 | 'tiff' => 'image/tiff', |
||
| 38 | 'xbm' => 'image/x-xbitmap', |
||
| 39 | ); |
||
| 40 | |||
| 41 | /** |
||
| 42 | * Set the maximum size if files to be imported. |
||
| 43 | * |
||
| 44 | * Files larger than this size (in kB) will not be imported into the CSS. |
||
| 45 | * Importing files into the CSS as data-uri will save you some connections, |
||
| 46 | * but we should only import relatively small decorative images so that our |
||
| 47 | * CSS file doesn't get too bulky. |
||
| 48 | * |
||
| 49 | * @param int $size Size in kB |
||
| 50 | */ |
||
| 51 | public function setMaxImportSize($size) |
||
| 55 | |||
| 56 | /** |
||
| 57 | * Set the type of extensions to be imported into the CSS (to save network |
||
| 58 | * connections). |
||
| 59 | * Keys of the array should be the file extensions & respective values |
||
| 60 | * should be the data type. |
||
| 61 | * |
||
| 62 | * @param string[] $extensions Array of file extensions |
||
| 63 | */ |
||
| 64 | public function setImportExtensions(array $extensions) |
||
| 68 | |||
| 69 | /** |
||
| 70 | * Move any import statements to the top. |
||
| 71 | * |
||
| 72 | * @param string $content Nearly finished CSS content |
||
| 73 | * |
||
| 74 | * @return string |
||
| 75 | */ |
||
| 76 | protected function moveImportsToTop($content) |
||
| 77 | { |
||
| 78 | if (preg_match_all('/@import[^;]+;/', $content, $matches)) { |
||
| 79 | // remove from content |
||
| 80 | foreach ($matches[0] as $import) { |
||
| 81 | $content = str_replace($import, '', $content); |
||
| 82 | } |
||
| 83 | |||
| 84 | // add to top |
||
| 85 | $content = implode('', $matches[0]).$content; |
||
| 86 | } |
||
| 87 | |||
| 88 | return $content; |
||
| 89 | } |
||
| 90 | |||
| 91 | /** |
||
| 92 | * Combine CSS from import statements. |
||
| 93 | * |
||
| 94 | * @import's will be loaded and their content merged into the original file, |
||
| 95 | * to save HTTP requests. |
||
| 96 | * |
||
| 97 | * @param string $source The file to combine imports for |
||
| 98 | * @param string $content The CSS content to combine imports for |
||
| 99 | * @param string[] $parents Parent paths, for circular reference checks |
||
| 100 | * |
||
| 101 | * @return string |
||
| 102 | * |
||
| 103 | * @throws FileImportException |
||
| 104 | */ |
||
| 105 | protected function combineImports($source, $content, $parents) |
||
| 106 | { |
||
| 107 | $importRegexes = array( |
||
| 108 | // @import url(xxx) |
||
| 109 | '/ |
||
| 110 | # import statement |
||
| 111 | @import |
||
| 112 | |||
| 113 | # whitespace |
||
| 114 | \s+ |
||
| 115 | |||
| 116 | # open url() |
||
| 117 | url\( |
||
| 118 | |||
| 119 | # (optional) open path enclosure |
||
| 120 | (?P<quotes>["\']?) |
||
| 121 | |||
| 122 | # fetch path |
||
| 123 | (?P<path> |
||
| 124 | |||
| 125 | # do not fetch data uris or external sources |
||
| 126 | (?!( |
||
| 127 | ["\']? |
||
| 128 | (data|https?): |
||
| 129 | )) |
||
| 130 | |||
| 131 | .+? |
||
| 132 | ) |
||
| 133 | |||
| 134 | # (optional) close path enclosure |
||
| 135 | (?P=quotes) |
||
| 136 | |||
| 137 | # close url() |
||
| 138 | \) |
||
| 139 | |||
| 140 | # (optional) trailing whitespace |
||
| 141 | \s* |
||
| 142 | |||
| 143 | # (optional) media statement(s) |
||
| 144 | (?P<media>[^;]*) |
||
| 145 | |||
| 146 | # (optional) trailing whitespace |
||
| 147 | \s* |
||
| 148 | |||
| 149 | # (optional) closing semi-colon |
||
| 150 | ;? |
||
| 151 | |||
| 152 | /ix', |
||
| 153 | |||
| 154 | // @import 'xxx' |
||
| 155 | '/ |
||
| 156 | |||
| 157 | # import statement |
||
| 158 | @import |
||
| 159 | |||
| 160 | # whitespace |
||
| 161 | \s+ |
||
| 162 | |||
| 163 | # open path enclosure |
||
| 164 | (?P<quotes>["\']) |
||
| 165 | |||
| 166 | # fetch path |
||
| 167 | (?P<path> |
||
| 168 | |||
| 169 | # do not fetch data uris or external sources |
||
| 170 | (?!( |
||
| 171 | ["\']? |
||
| 172 | (data|https?): |
||
| 173 | )) |
||
| 174 | |||
| 175 | .+? |
||
| 176 | ) |
||
| 177 | |||
| 178 | # close path enclosure |
||
| 179 | (?P=quotes) |
||
| 180 | |||
| 181 | # (optional) trailing whitespace |
||
| 182 | \s* |
||
| 183 | |||
| 184 | # (optional) media statement(s) |
||
| 185 | (?P<media>[^;]*) |
||
| 186 | |||
| 187 | # (optional) trailing whitespace |
||
| 188 | \s* |
||
| 189 | |||
| 190 | # (optional) closing semi-colon |
||
| 191 | ;? |
||
| 192 | |||
| 193 | /ix', |
||
| 194 | ); |
||
| 195 | |||
| 196 | // find all relative imports in css |
||
| 197 | $matches = array(); |
||
| 198 | foreach ($importRegexes as $importRegex) { |
||
| 199 | if (preg_match_all($importRegex, $content, $regexMatches, PREG_SET_ORDER)) { |
||
| 200 | $matches = array_merge($matches, $regexMatches); |
||
| 201 | } |
||
| 202 | } |
||
| 203 | |||
| 204 | $search = array(); |
||
| 205 | $replace = array(); |
||
| 206 | |||
| 207 | // loop the matches |
||
| 208 | foreach ($matches as $match) { |
||
| 209 | // get the path for the file that will be imported |
||
| 210 | $importPath = dirname($source).'/'.$match['path']; |
||
| 211 | |||
| 212 | // only replace the import with the content if we can grab the |
||
| 213 | // content of the file |
||
| 214 | if ($this->canImportFile($importPath)) { |
||
| 215 | // check if current file was not imported previously in the same |
||
| 216 | // import chain. |
||
| 217 | if (in_array($importPath, $parents)) { |
||
| 218 | throw new FileImportException('Failed to import file "'.$importPath.'": circular reference detected.'); |
||
| 219 | } |
||
| 220 | |||
| 221 | // grab referenced file & minify it (which may include importing |
||
| 222 | // yet other @import statements recursively) |
||
| 223 | $minifier = new static($importPath); |
||
| 224 | $importContent = $minifier->execute($source, $parents); |
||
| 225 | |||
| 226 | // check if this is only valid for certain media |
||
| 227 | if (!empty($match['media'])) { |
||
| 228 | $importContent = '@media '.$match['media'].'{'.$importContent.'}'; |
||
| 229 | } |
||
| 230 | |||
| 231 | // add to replacement array |
||
| 232 | $search[] = $match[0]; |
||
| 233 | $replace[] = $importContent; |
||
| 234 | } |
||
| 235 | } |
||
| 236 | |||
| 237 | // replace the import statements |
||
| 238 | $content = str_replace($search, $replace, $content); |
||
| 239 | |||
| 240 | return $content; |
||
| 241 | } |
||
| 242 | |||
| 243 | /** |
||
| 244 | * Import files into the CSS, base64-ized. |
||
| 245 | * |
||
| 246 | * @url(image.jpg) images will be loaded and their content merged into the |
||
| 247 | * original file, to save HTTP requests. |
||
| 248 | * |
||
| 249 | * @param string $source The file to import files for |
||
| 250 | * @param string $content The CSS content to import files for |
||
| 251 | * |
||
| 252 | * @return string |
||
| 253 | */ |
||
| 254 | protected function importFiles($source, $content) |
||
| 255 | { |
||
| 256 | $extensions = array_keys($this->importExtensions); |
||
| 257 | $regex = '/url\((["\']?)((?!["\']?data:).*?\.('.implode('|', $extensions).'))\\1\)/i'; |
||
| 258 | if ($extensions && preg_match_all($regex, $content, $matches, PREG_SET_ORDER)) { |
||
|
|
|||
| 259 | $search = array(); |
||
| 260 | $replace = array(); |
||
| 261 | |||
| 262 | // loop the matches |
||
| 263 | foreach ($matches as $match) { |
||
| 264 | // get the path for the file that will be imported |
||
| 265 | $path = $match[2]; |
||
| 266 | $path = dirname($source).'/'.$path; |
||
| 267 | $extension = $match[3]; |
||
| 268 | |||
| 269 | // only replace the import with the content if we're able to get |
||
| 270 | // the content of the file, and it's relatively small |
||
| 271 | if ($this->canImportFile($path) && $this->canImportBySize($path)) { |
||
| 272 | // grab content && base64-ize |
||
| 273 | $importContent = $this->load($path); |
||
| 274 | $importContent = base64_encode($importContent); |
||
| 275 | |||
| 276 | // build replacement |
||
| 277 | $search[] = $match[0]; |
||
| 278 | $replace[] = 'url('.$this->importExtensions[$extension].';base64,'.$importContent.')'; |
||
| 279 | } |
||
| 280 | } |
||
| 281 | |||
| 282 | // replace the import statements |
||
| 283 | $content = str_replace($search, $replace, $content); |
||
| 284 | } |
||
| 285 | |||
| 286 | return $content; |
||
| 287 | } |
||
| 288 | |||
| 289 | /** |
||
| 290 | * Minify the data. |
||
| 291 | * Perform CSS optimizations. |
||
| 292 | * |
||
| 293 | * @param string[optional] $path Path to write the data to |
||
| 294 | * @param string[] $parents Parent paths, for circular reference checks |
||
| 295 | * |
||
| 296 | * @return string The minified data |
||
| 297 | */ |
||
| 298 | public function execute($path = null, $parents = array()) |
||
| 299 | { |
||
| 300 | $content = ''; |
||
| 301 | |||
| 302 | // loop css data (raw data and files) |
||
| 303 | foreach ($this->data as $source => $css) { |
||
| 304 | /* |
||
| 305 | * Let's first take out strings & comments, since we can't just remove |
||
| 306 | * whitespace anywhere. If whitespace occurs inside a string, we should |
||
| 307 | * leave it alone. E.g.: |
||
| 308 | * p { content: "a test" } |
||
| 309 | */ |
||
| 310 | $this->extractStrings(); |
||
| 311 | $this->stripComments(); |
||
| 312 | $css = $this->replace($css); |
||
| 313 | |||
| 314 | $css = $this->stripWhitespace($css); |
||
| 315 | $css = $this->shortenHex($css); |
||
| 316 | $css = $this->shortenZeroes($css); |
||
| 317 | $css = $this->shortenFontWeights($css); |
||
| 318 | $css = $this->stripEmptyTags($css); |
||
| 319 | |||
| 320 | // restore the string we've extracted earlier |
||
| 321 | $css = $this->restoreExtractedData($css); |
||
| 322 | |||
| 323 | $source = is_int($source) ? '' : $source; |
||
| 324 | $parents = $source ? array_merge($parents, array($source)) : $parents; |
||
| 325 | $css = $this->combineImports($source, $css, $parents); |
||
| 326 | $css = $this->importFiles($source, $css); |
||
| 327 | |||
| 328 | /* |
||
| 329 | * If we'll save to a new path, we'll have to fix the relative paths |
||
| 330 | * to be relative no longer to the source file, but to the new path. |
||
| 331 | * If we don't write to a file, fall back to same path so no |
||
| 332 | * conversion happens (because we still want it to go through most |
||
| 333 | * of the move code...) |
||
| 334 | */ |
||
| 335 | $converter = new Converter($source, $path ?: $source); |
||
| 336 | $css = $this->move($converter, $css); |
||
| 337 | |||
| 338 | // combine css |
||
| 339 | $content .= $css; |
||
| 340 | } |
||
| 341 | |||
| 342 | $content = $this->moveImportsToTop($content); |
||
| 343 | |||
| 344 | return $content; |
||
| 345 | } |
||
| 346 | |||
| 347 | /** |
||
| 348 | * Moving a css file should update all relative urls. |
||
| 349 | * Relative references (e.g. ../images/image.gif) in a certain css file, |
||
| 350 | * will have to be updated when a file is being saved at another location |
||
| 351 | * (e.g. ../../images/image.gif, if the new CSS file is 1 folder deeper). |
||
| 352 | * |
||
| 353 | * @param Converter $converter Relative path converter |
||
| 354 | * @param string $content The CSS content to update relative urls for |
||
| 355 | * |
||
| 356 | * @return string |
||
| 357 | */ |
||
| 358 | protected function move(Converter $converter, $content) |
||
| 477 | |||
| 478 | /** |
||
| 479 | * Shorthand hex color codes. |
||
| 480 | * #FF0000 -> #F00. |
||
| 481 | * |
||
| 482 | * @param string $content The CSS content to shorten the hex color codes for |
||
| 483 | * |
||
| 484 | * @return string |
||
| 485 | */ |
||
| 486 | protected function shortenHex($content) |
||
| 529 | |||
| 530 | /** |
||
| 531 | * Shorten CSS font weights. |
||
| 532 | * |
||
| 533 | * @param string $content The CSS content to shorten the font weights for |
||
| 534 | * |
||
| 535 | * @return string |
||
| 536 | */ |
||
| 537 | protected function shortenFontWeights($content) |
||
| 550 | |||
| 551 | /** |
||
| 552 | * Shorthand 0 values to plain 0, instead of e.g. -0em. |
||
| 553 | * |
||
| 554 | * @param string $content The CSS content to shorten the zero values for |
||
| 555 | * |
||
| 556 | * @return string |
||
| 557 | */ |
||
| 558 | protected function shortenZeroes($content) |
||
| 608 | |||
| 609 | /** |
||
| 610 | * Strip comments from source code. |
||
| 611 | * |
||
| 612 | * @param string $content |
||
| 613 | * |
||
| 614 | * @return string |
||
| 615 | */ |
||
| 616 | protected function stripEmptyTags($content) |
||
| 620 | |||
| 621 | /** |
||
| 622 | * Strip comments from source code. |
||
| 623 | */ |
||
| 624 | protected function stripComments() |
||
| 628 | |||
| 629 | /** |
||
| 630 | * Strip whitespace. |
||
| 631 | * |
||
| 632 | * @param string $content The CSS content to strip the whitespace for |
||
| 633 | * |
||
| 634 | * @return string |
||
| 635 | */ |
||
| 636 | protected function stripWhitespace($content) |
||
| 662 | |||
| 663 | /** |
||
| 664 | * Check if file is small enough to be imported. |
||
| 665 | * |
||
| 666 | * @param string $path The path to the file |
||
| 667 | * |
||
| 668 | * @return bool |
||
| 669 | */ |
||
| 670 | protected function canImportBySize($path) |
||
| 674 | } |
||
| 675 |
This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent.
Consider making the comparison explicit by using
empty(..)or! empty(...)instead.