SimpleMachines / SMF2.1

Sources/Subs-Editor.php

Braces -3 removed lines

@@ -332,7 +332,6 @@ 
 					$replacement .= $precedingStyle . $extra_attr . $afterStyle;
 			}
 		}
-
 		elseif (preg_match('~</([A-Za-z]+)>~', $part, $matches) === 1)
 		{
 			// Is this the element that we've been waiting for to be closed?
@@ -592,7 +591,6 @@ 
 							$parts[$i + 2] = str_repeat("\t", $listDepth) . '[/list]';
 							$parts[$i + 3] = '';
 						}
-
 						else
 						{
 							// We're in a list item.
@@ -631,7 +629,6 @@ 
 							$parts[$i + 2] = '';
 							$parts[$i + 3] = '';
 						}
-
 						else
 						{
 							// Remove the trailing breaks from the list item.

Sources/Class-Graphics.php

Spacing +1 added lines, -1 removed lines

@@ -280,7 +280,7 @@
 			$ret .=
 				chr(($this->m_arColors[$i] & 0x000000FF)) . // R
 				chr(($this->m_arColors[$i] & 0x0000FF00) >> 8) . // G
-				chr(($this->m_arColors[$i] & 0x00FF0000) >> 16);  // B
+				chr(($this->m_arColors[$i] & 0x00FF0000) >> 16); // B
 		}
 
 		return $ret;

Sources/Class-Punycode.php

Spacing +2 added lines, -2 removed lines

@@ -145,7 +145,7 @@ 
 				}
 				if ($c === $n) {
 					$q = $delta;
-					for ($k = static::BASE;; $k += static::BASE) {
+					for ($k = static::BASE; ; $k += static::BASE) {
 						$t = $this->calculateThreshold($k, $bias);
 						if ($q < $t) {
 							break;
@@ -227,7 +227,7 @@ 
 			$oldi = $i;
 			$w = 1;
 
-			for ($k = static::BASE;; $k += static::BASE)
+			for ($k = static::BASE; ; $k += static::BASE)
 			{
 				$digit = static::$decodeTable[$input[$pos++]];
 				$i = $i + ($digit * $w);

Braces +20 added lines, -10 removed lines

@@ -94,7 +94,8 @@ 
 	{
 		$input = mb_strtolower($input, $this->encoding);
 		$parts = explode('.', $input);
-		foreach ($parts as &$part) {
+		foreach ($parts as &$part)
+		{
 			$part = $this->encodePart($part);
 		}
 		$output = implode('.', $parts);
@@ -119,13 +120,16 @@ 
 		$h = $b = count($codePoints['basic']);
 
 		$output = '';
-		foreach ($codePoints['basic'] as $code) {
+		foreach ($codePoints['basic'] as $code)
+		{
 			$output .= $this->codePointToChar($code);
 		}
-		if ($input === $output) {
+		if ($input === $output)
+		{
 			return $output;
 		}
-		if ($b > 0) {
+		if ($b > 0)
+		{
 			$output .= static::DELIMITER;
 		}
 
@@ -134,20 +138,26 @@ 
 
 		$i = 0;
 		$length = mb_strlen($input, $this->encoding);
-		while ($h < $length) {
+		while ($h < $length)
+		{
 			$m = $codePoints['nonBasic'][$i++];
 			$delta = $delta + ($m - $n) * ($h + 1);
 			$n = $m;
 
-			foreach ($codePoints['all'] as $c) {
-				if ($c < $n || $c < static::INITIAL_N) {
+			foreach ($codePoints['all'] as $c)
+			{
+				if ($c < $n || $c < static::INITIAL_N)
+				{
 					$delta++;
 				}
-				if ($c === $n) {
+				if ($c === $n)
+				{
 					$q = $delta;
-					for ($k = static::BASE;; $k += static::BASE) {
+					for ($k = static::BASE;; $k += static::BASE)
+					{
 						$t = $this->calculateThreshold($k, $bias);
-						if ($q < $t) {
+						if ($q < $t)
+						{
 							break;
 						}
 

Sources/Subs-Db-postgresql.php

Braces +4 added lines, -2 removed lines

@@ -979,7 +979,8 @@ 
 		$error_array[2] = null;
 
 	if(empty($db_persist))
-	{ // without pooling
+	{
+// without pooling
 		if (empty($pg_error_data_prep))
 			$pg_error_data_prep = pg_prepare($db_connection, 'smf_log_errors',
 				'INSERT INTO ' . $db_prefix . 'log_errors
@@ -990,7 +991,8 @@ 
 		pg_execute($db_connection, 'smf_log_errors', $error_array);
 	}
 	else
-	{ //with pooling
+	{
+//with pooling
 		$pg_error_data_prep = pg_prepare($db_connection, '',
 			'INSERT INTO ' . $db_prefix . 'log_errors
 				(id_member, log_time, ip, url, message, session, error_type, file, line, backtrace)

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -670,7 +670,7 @@
 		foreach ($columns as $columnName => $type)
 		{
 			//check pk fiel
-			IF (in_array($columnName, $keys))
+			if (in_array($columnName, $keys))
 			{
 				$key_str .= ($count_pk > 0 ? ',' : '');
 				$key_str .= $columnName;

Spacing +2 added lines, -2 removed lines

@@ -75,7 +75,7 @@ 
 		display_db_error();
 
 	// We need to escape ' and \
-	$db_passwd = str_replace(array('\\','\''), array('\\\\','\\\''), $db_passwd);
+	$db_passwd = str_replace(array('\\', '\''), array('\\\\', '\\\''), $db_passwd);
 
 	// Since pg_connect doesn't feed error info to pg_last_error, we have to catch issues with a try/catch.
 	set_error_handler(
@@ -910,7 +910,7 @@ 
 	if (filter_var($error_array[2], FILTER_VALIDATE_IP) === false)
 		$error_array[2] = null;
 
-	if(empty($db_persist))
+	if (empty($db_persist))
 	{ // without pooling
 		if (empty($pg_error_data_prep))
 			$pg_error_data_prep = pg_prepare($db_connection, 'smf_log_errors',

Sources/ManageMembers.php

Spacing +1 added lines, -1 removed lines

@@ -738,7 +738,7 @@
 			);
 		else
 			$context['allowed_actions'] = array(
-				'ok' => $txt['admin_browse_w_approve'] .' '. $txt['admin_browse_no_email'],
+				'ok' => $txt['admin_browse_w_approve'] . ' ' . $txt['admin_browse_no_email'],
 				'okemail' => $txt['admin_browse_w_approve'] . ' ' . $txt['admin_browse_w_email'],
 				'require_activation' => $txt['admin_browse_w_approve_require_activate'],
 				'reject' => $txt['admin_browse_w_reject'],

Sources/ManageSmileys.php

Spacing +1 added lines, -1 removed lines

@@ -1965,7 +1965,7 @@
 	// Remove anything that isn't actually new from our list of files
 	foreach ($to_unset as $key => $ids)
 	{
-		if (array_reduce($ids, function ($carry, $item) { return $carry * $item; }, true) == true)
+		if (array_reduce($ids, function($carry, $item) { return $carry * $item; }, true) == true)
 			unset($smiley_files[$key]);
 	}
 

Braces +3 added lines, -1 removed lines

@@ -1965,7 +1965,9 @@
 	// Remove anything that isn't actually new from our list of files
 	foreach ($to_unset as $key => $ids)
 	{
-		if (array_reduce($ids, function ($carry, $item) { return $carry * $item; }, true) == true)
+		if (array_reduce($ids, function ($carry, $item)
+		{
+return $carry * $item; }, true) == true)
 			unset($smiley_files[$key]);
 	}
 

Sources/Subs-Post.php

Braces -1 removed lines

@@ -1254,7 +1254,6 @@
 
 		return array($charset, $string, 'base64');
 	}
-
 	else
 		return array($charset, $string, '7bit');
 }

Sources/Subs-Db-mysql.php

Spacing +1 added lines, -1 removed lines

@@ -975,7 +975,7 @@
 	else
 	{
 		$return = array();
-		while($row = mysqli_fetch_assoc($request))
+		while ($row = mysqli_fetch_assoc($request))
 			$return[] = $row;
 	}
 	return !empty($return) ? $return : array();

Themes/default/ManageMembergroups.template.php

Spacing +2 added lines, -2 removed lines

@@ -388,7 +388,7 @@ 
 	<script>
 		function swapPostGroup(isChecked)
 		{
-			var is_moderator_group = ', (int)$context['is_moderator_group'], ';
+			var is_moderator_group = ', (int) $context['is_moderator_group'], ';
 			var group_type = ', $context['group']['type'], ';
 			var min_posts_text = document.getElementById(\'min_posts_text\');
 			var group_desc_text = document.getElementById(\'group_desc_text\');
@@ -453,7 +453,7 @@ 
 		if (empty($modSettings['deny_boards_access']))
 			echo '
 									<li class="category">
-										<a href="javascript:void(0);" onclick="selectBoards([', implode(', ', $category['child_ids']), '], \''.$form_id.'\'); return false;"><strong>', $category['name'], '</strong></a>
+										<a href="javascript:void(0);" onclick="selectBoards([', implode(', ', $category['child_ids']), '], \'' . $form_id . '\'); return false;"><strong>', $category['name'], '</strong></a>
 										<ul>';
 		else
 			echo '