Completed
Push — release-2.1 ( a51b86...3c6b17 )
by Colin
08:06
created
Themes/default/Stats.template.php 1 patch
Braces   +26 added lines, -18 removed lines patch added patch discarded remove patch
@@ -44,10 +44,11 @@  discard block
 block discarded – undo
44 44
 				<dt>', $txt['users_online_today'], ':</dt>
45 45
 				<dd>', $context['online_today'], '</dd>';
46 46
 
47
-	if (!empty($modSettings['hitStats']))
48
-		echo '
47
+	if (!empty($modSettings['hitStats'])) {
48
+			echo '
49 49
 				<dt>', $txt['num_hits'], ':</dt>
50 50
 				<dd>', $context['num_hits'], '</dd>';
51
+	}
51 52
 
52 53
 	echo '
53 54
 			</dl>
@@ -71,17 +72,19 @@  discard block
 block discarded – undo
71 72
 				<dt>', $txt['gender_stats'], ':</dt>
72 73
 				<dd>';
73 74
 
74
-		foreach ($context['gender'] as $g => $n)
75
-			echo $g, ': ', $n, '<br>';
75
+		foreach ($context['gender'] as $g => $n) {
76
+					echo $g, ': ', $n, '<br>';
77
+		}
76 78
 
77 79
 		echo '
78 80
 				</dd>';
79 81
 	}
80 82
 
81
-	if (!empty($modSettings['hitStats']))
82
-		echo '
83
+	if (!empty($modSettings['hitStats'])) {
84
+			echo '
83 85
 				<dt>', $txt['average_hits'], ':</dt>
84 86
 				<dd>', $context['average_hits'], '</dd>';
87
+	}
85 88
 
86 89
 	echo '
87 90
 			</dl>';
@@ -105,14 +108,15 @@  discard block
 block discarded – undo
105 108
 					</dt>
106 109
 					<dd class="statsbar">';
107 110
 
108
-			if (!empty($item['percent']))
109
-				echo '
111
+			if (!empty($item['percent'])) {
112
+							echo '
110 113
 						<div class="bar" style="width: ', $item['percent'], '%;">
111 114
 							<span class="righttext">', $item['num'], '</span>
112 115
 						</div>';
113
-			else
114
-				echo '
116
+			} else {
117
+							echo '
115 118
 						<div class="bar empty"><span class="righttext">', $item['num'], '</span></div>';
119
+			}
116 120
 
117 121
 			echo '
118 122
 					</dd>';
@@ -144,9 +148,10 @@  discard block
 block discarded – undo
144 148
 					<th>', $txt['stats_new_members'], '</th>
145 149
 					<th>', $txt['most_online'], '</th>';
146 150
 
147
-		if (!empty($modSettings['hitStats']))
148
-			echo '
151
+		if (!empty($modSettings['hitStats'])) {
152
+					echo '
149 153
 					<th>', $txt['page_views'], '</th>';
154
+		}
150 155
 
151 156
 		echo '
152 157
 				</tr>
@@ -165,9 +170,10 @@  discard block
 block discarded – undo
165 170
 					<th>', $year['new_members'], '</th>
166 171
 					<th>', $year['most_members_online'], '</th>';
167 172
 
168
-			if (!empty($modSettings['hitStats']))
169
-				echo '
173
+			if (!empty($modSettings['hitStats'])) {
174
+							echo '
170 175
 					<th>', $year['hits'], '</th>';
176
+			}
171 177
 
172 178
 			echo '
173 179
 				</tr>';
@@ -184,9 +190,10 @@  discard block
 block discarded – undo
184 190
 					<th>', $month['new_members'], '</th>
185 191
 					<th>', $month['most_members_online'], '</th>';
186 192
 
187
-				if (!empty($modSettings['hitStats']))
188
-					echo '
193
+				if (!empty($modSettings['hitStats'])) {
194
+									echo '
189 195
 					<th>', $month['hits'], '</th>';
196
+				}
190 197
 
191 198
 				echo '
192 199
 				</tr>';
@@ -203,9 +210,10 @@  discard block
 block discarded – undo
203 210
 					<td>', $day['new_members'], '</td>
204 211
 					<td>', $day['most_members_online'], '</td>';
205 212
 
206
-						if (!empty($modSettings['hitStats']))
207
-							echo '
213
+						if (!empty($modSettings['hitStats'])) {
214
+													echo '
208 215
 					<td>', $day['hits'], '</td>';
216
+						}
209 217
 
210 218
 						echo '
211 219
 				</tr>';
Please login to merge, or discard this patch.
Themes/default/ModerationCenter.template.php 1 patch
Braces   +56 added lines, -39 removed lines patch added patch discarded remove patch
@@ -55,18 +55,20 @@  discard block
 block discarded – undo
55 55
 			<div class="modbox">
56 56
 				<ul>';
57 57
 
58
-		foreach ($context['group_requests'] as $request)
59
-			echo '
58
+		foreach ($context['group_requests'] as $request) {
59
+					echo '
60 60
 					<li class="smalltext">
61 61
 						<a href="', $request['request_href'], '">', $request['group']['name'], '</a> ', $txt['mc_groupr_by'], ' ', $request['member']['link'], '
62 62
 					</li>';
63
+		}
63 64
 
64 65
 		// Don't have any watched users right now?
65
-		if (empty($context['group_requests']))
66
-			echo '
66
+		if (empty($context['group_requests'])) {
67
+					echo '
67 68
 					<li>
68 69
 						<strong class="smalltext">', $txt['mc_group_requests_none'], '</strong>
69 70
 					</li>';
71
+		}
70 72
 
71 73
 		echo '
72 74
 				</ul>
@@ -124,18 +126,20 @@  discard block
 block discarded – undo
124 126
 			<div class="modbox">
125 127
 				<ul>';
126 128
 
127
-		foreach ($context['watched_users'] as $user)
128
-			echo '
129
+		foreach ($context['watched_users'] as $user) {
130
+					echo '
129 131
 					<li>
130 132
 						<span class="smalltext">', sprintf(!empty($user['last_login']) ? $txt['mc_seen'] : $txt['mc_seen_never'], $user['link'], $user['last_login']), '</span>
131 133
 					</li>';
134
+		}
132 135
 
133 136
 		// Don't have any watched users right now?
134
-		if (empty($context['watched_users']))
135
-			echo '
137
+		if (empty($context['watched_users'])) {
138
+					echo '
136 139
 					<li>
137 140
 						<strong class="smalltext">', $txt['mc_watched_users_none'], '</strong>
138 141
 					</li>';
142
+		}
139 143
 
140 144
 		echo '
141 145
 				</ul>
@@ -193,18 +197,20 @@  discard block
 block discarded – undo
193 197
 			<div class="modbox">
194 198
 				<ul>';
195 199
 
196
-		foreach ($context['reported_posts'] as $post)
197
-			echo '
200
+		foreach ($context['reported_posts'] as $post) {
201
+					echo '
198 202
 					<li>
199 203
 						<span class="smalltext">', sprintf($txt['mc_post_report'], $post['report_link'], $post['author']['link']), '</span>
200 204
 					</li>';
205
+		}
201 206
 
202 207
 		// Don't have any watched users right now?
203
-		if (empty($context['reported_posts']))
204
-			echo '
208
+		if (empty($context['reported_posts'])) {
209
+					echo '
205 210
 					<li>
206 211
 						<strong class="smalltext">', $txt['mc_recent_reports_none'], '</strong>
207 212
 					</li>';
213
+		}
208 214
 
209 215
 		echo '
210 216
 				</ul>
@@ -262,18 +268,20 @@  discard block
 block discarded – undo
262 268
 			<div class="modbox">
263 269
 				<ul>';
264 270
 
265
-		foreach ($context['reported_users'] as $user)
266
-			echo '
271
+		foreach ($context['reported_users'] as $user) {
272
+					echo '
267 273
 					<li>
268 274
 						<span class="smalltext">', $user['user']['link'], '</span>
269 275
 					</li>';
276
+		}
270 277
 
271 278
 		// Don't have any watched users right now?
272
-		if (empty($context['reported_users']))
273
-			echo '
279
+		if (empty($context['reported_users'])) {
280
+					echo '
274 281
 					<li>
275 282
 						<strong class="smalltext">', $txt['mc_reported_users_none'], '</strong>
276 283
 					</li>';
284
+		}
277 285
 
278 286
 		echo '
279 287
 				</ul>
@@ -344,11 +352,12 @@  discard block
 block discarded – undo
344 352
 						<ul class="moderation_notes">';
345 353
 
346 354
 		// Cycle through the notes.
347
-		foreach ($context['notes'] as $note)
348
-			echo '
355
+		foreach ($context['notes'] as $note) {
356
+					echo '
349 357
 							<li class="smalltext">
350 358
 								', ($note['can_delete'] ? '<a href="' . $note['delete_href'] . ';' . $context['mod-modnote-del_token_var'] . '=' . $context['mod-modnote-del_token'] . '" data-confirm="' . $txt['mc_reportedp_delete_confirm'] . '" class="you_sure"><span class="generic_icons delete"></span></a>' : ''), $note['time'], ' <strong>', $note['author']['link'], ':</strong> ', $note['text'], '
351 359
 							</li>';
360
+		}
352 361
 
353 362
 		echo '
354 363
 						</ul>
@@ -390,18 +399,19 @@  discard block
 block discarded – undo
390 399
 	$remove_button = create_button('delete', 'remove_message', 'remove');
391 400
 
392 401
 	// No posts?
393
-	if (empty($context['unapproved_items']))
394
-		echo '
402
+	if (empty($context['unapproved_items'])) {
403
+			echo '
395 404
 			<div class="windowbg2">
396 405
 				<p class="centertext">
397 406
 					', $txt['mc_unapproved_' . $context['current_view'] . '_none_found'], '
398 407
 				</p>
399 408
 			</div>';
400
-	else
401
-		echo '
409
+	} else {
410
+			echo '
402 411
 			<div class="pagesection floatleft">
403 412
 				', $context['page_index'], '
404 413
 			</div>';
414
+	}
405 415
 
406 416
 	foreach ($context['unapproved_items'] as $item)
407 417
 	{
@@ -420,14 +430,16 @@  discard block
 block discarded – undo
420 430
 				<span class="floatright">
421 431
 					<a href="', $scripturl, '?action=moderate;area=postmod;sa=', $context['current_view'], ';start=', $context['start'], ';', $context['session_var'], '=', $context['session_id'], ';approve=', $item['id'], '">', $approve_button, '</a>';
422 432
 
423
-		if ($item['can_delete'])
424
-			echo '
433
+		if ($item['can_delete']) {
434
+					echo '
425 435
 					', $context['menu_separator'], '
426 436
 					<a href="', $scripturl, '?action=moderate;area=postmod;sa=', $context['current_view'], ';start=', $context['start'], ';', $context['session_var'], '=', $context['session_id'], ';delete=', $item['id'], '">', $remove_button, '</a>';
437
+		}
427 438
 
428
-		if (!empty($options['display_quick_mod']) && $options['display_quick_mod'] == 1)
429
-			echo '
439
+		if (!empty($options['display_quick_mod']) && $options['display_quick_mod'] == 1) {
440
+					echo '
430 441
 					<input type="checkbox" name="item[]" value="', $item['id'], '" checked> ';
442
+		}
431 443
 
432 444
 		echo '
433 445
 				</span>
@@ -437,8 +449,8 @@  discard block
 block discarded – undo
437 449
 	echo '
438 450
 			<div class="pagesection">';
439 451
 
440
-	if (!empty($options['display_quick_mod']) && $options['display_quick_mod'] == 1)
441
-		echo '
452
+	if (!empty($options['display_quick_mod']) && $options['display_quick_mod'] == 1) {
453
+			echo '
442 454
 				<div class="floatright">
443 455
 					<select name="do" onchange="if (this.value != 0 &amp;&amp; confirm(\'', $txt['mc_unapproved_sure'], '\')) submit();">
444 456
 						<option value="0">', $txt['with_selected'], ':</option>
@@ -450,12 +462,14 @@  discard block
 block discarded – undo
450 462
 						<input type="submit" name="mc_go" value="', $txt['go'], '" class="button">
451 463
 					</noscript>
452 464
 				</div>';
465
+	}
453 466
 
454
-	if (!empty($context['unapproved_items']))
455
-		echo '
467
+	if (!empty($context['unapproved_items'])) {
468
+			echo '
456 469
 				<div class="floatleft">
457 470
 					<div class="pagelinks">', $context['page_index'], '</div>
458 471
 				</div>';
472
+	}
459 473
 
460 474
 	echo '
461 475
 			</div><!-- .pagesection -->
@@ -475,8 +489,9 @@  discard block
 block discarded – undo
475 489
 	global $scripturl, $context, $txt, $delete_button;
476 490
 
477 491
 	// We'll have a delete please bob.
478
-	if (empty($delete_button))
479
-		$delete_button = create_button('delete', 'remove_message', 'remove', 'class="centericon"');
492
+	if (empty($delete_button)) {
493
+			$delete_button = create_button('delete', 'remove_message', 'remove', 'class="centericon"');
494
+	}
480 495
 
481 496
 	$output_html = '
482 497
 					<div>
@@ -485,10 +500,11 @@  discard block
 block discarded – undo
485 500
 						</div>
486 501
 						<div class="floatright">';
487 502
 
488
-	if ($post['can_delete'])
489
-		$output_html .= '
503
+	if ($post['can_delete']) {
504
+			$output_html .= '
490 505
 							<a href="' . $scripturl . '?action=moderate;area=userwatch;sa=post;delete=' . $post['id'] . ';start=' . $context['start'] . ';' . $context['session_var'] . '=' . $context['session_id'] . '" data-confirm="' . $txt['mc_watched_users_delete_post'] . '" class="you_sure">' . $delete_button . '</a>
491 506
 							<input type="checkbox" name="delete[]" value="' . $post['id'] . '">';
507
+	}
492 508
 
493 509
 	$output_html .= '
494 510
 						</div>
@@ -531,12 +547,12 @@  discard block
 block discarded – undo
531 547
 				<input type="submit" name="save" value="', $txt['save'], '" class="button">
532 548
 			</div>
533 549
 		</form>';
534
-	}
535
-	else
536
-		echo '
550
+	} else {
551
+			echo '
537 552
 		<div class="windowbg">
538 553
 			<div class="centertext">', $txt['mc_no_settings'], '</div>
539 554
 		</div>';
555
+	}
540 556
 
541 557
 	echo '
542 558
 	</div><!-- #modcenter -->';
@@ -632,13 +648,14 @@  discard block
 block discarded – undo
632 648
 					</dd>
633 649
 				</dl>';
634 650
 
635
-	if ($context['template_data']['can_edit_personal'])
636
-		echo '
651
+	if ($context['template_data']['can_edit_personal']) {
652
+			echo '
637 653
 				<input type="checkbox" name="make_personal" id="make_personal"', $context['template_data']['personal'] ? ' checked' : '', '>
638 654
 					<label for="make_personal">
639 655
 						<strong>', $txt['mc_warning_template_personal'], '</strong>
640 656
 					</label><br>
641 657
 					<span class="smalltext">', $txt['mc_warning_template_personal_desc'], '</span><br>';
658
+	}
642 659
 
643 660
 	echo '
644 661
 				<hr>
Please login to merge, or discard this patch.
Themes/default/ManageCalendar.template.php 1 patch
Braces   +14 added lines, -10 removed lines patch added patch discarded remove patch
@@ -40,9 +40,10 @@  discard block
 block discarded – undo
40 40
 							<option value="0000"', $context['holiday']['year'] == '0000' ? ' selected' : '', '>', $txt['every_year'], '</option>';
41 41
 
42 42
 	// Show a list of all the years we allow...
43
-	for ($year = $modSettings['cal_minyear']; $year <= $modSettings['cal_maxyear']; $year++)
44
-		echo '
43
+	for ($year = $modSettings['cal_minyear']; $year <= $modSettings['cal_maxyear']; $year++) {
44
+			echo '
45 45
 							<option value="', $year, '"', $year == $context['holiday']['year'] ? ' selected' : '', '>', $year, '</option>';
46
+	}
46 47
 
47 48
 	echo '
48 49
 						</select>&nbsp;
@@ -50,9 +51,10 @@  discard block
 block discarded – undo
50 51
 						<select name="month" id="month" onchange="generateDays();">';
51 52
 
52 53
 	// There are 12 months per year - ensure that they all get listed.
53
-	for ($month = 1; $month <= 12; $month++)
54
-		echo '
54
+	for ($month = 1; $month <= 12; $month++) {
55
+			echo '
55 56
 							<option value="', $month, '"', $month == $context['holiday']['month'] ? ' selected' : '', '>', $txt['months'][$month], '</option>';
57
+	}
56 58
 
57 59
 	echo '
58 60
 						</select>&nbsp;
@@ -60,23 +62,25 @@  discard block
 block discarded – undo
60 62
 						<select name="day" id="day" onchange="generateDays();">';
61 63
 
62 64
 	// This prints out all the days in the current month - this changes dynamically as we switch months.
63
-	for ($day = 1; $day <= $context['holiday']['last_day']; $day++)
64
-		echo '
65
+	for ($day = 1; $day <= $context['holiday']['last_day']; $day++) {
66
+			echo '
65 67
 							<option value="', $day, '"', $day == $context['holiday']['day'] ? ' selected' : '', '>', $day, '</option>';
68
+	}
66 69
 
67 70
 	echo '
68 71
 						</select>
69 72
 					</dd>
70 73
 				</dl>';
71 74
 
72
-	if ($context['is_new'])
73
-		echo '
75
+	if ($context['is_new']) {
76
+			echo '
74 77
 				<input type="submit" value="', $txt['holidays_button_add'], '" class="button">';
75
-	else
76
-		echo '
78
+	} else {
79
+			echo '
77 80
 				<input type="submit" name="edit" value="', $txt['holidays_button_edit'], '" class="button">
78 81
 				<input type="submit" name="delete" value="', $txt['holidays_button_remove'], '" class="button">
79 82
 				<input type="hidden" name="holiday" value="', $context['holiday']['id'], '">';
83
+	}
80 84
 	echo '
81 85
 				<input type="hidden" name="', $context['session_var'], '" value="', $context['session_id'], '">
82 86
 			</div><!-- .windowbg2 -->
Please login to merge, or discard this patch.
Themes/default/ReportedContent.template.php 1 patch
Braces   +54 added lines, -36 removed lines patch added patch discarded remove patch
@@ -55,8 +55,9 @@  discard block
 block discarded – undo
55 55
 		// Prepare the comments...
56 56
 		$comments = array();
57 57
 
58
-		foreach ($report['comments'] as $comment)
59
-			$comments[$comment['member']['id']] = $comment['member']['link'];
58
+		foreach ($report['comments'] as $comment) {
59
+					$comments[$comment['member']['id']] = $comment['member']['link'];
60
+		}
60 61
 
61 62
 		echo '
62 63
 				', $txt['mc_reportedp_reported_by'], ': ', implode(', ', $comments), '
@@ -72,18 +73,21 @@  discard block
 block discarded – undo
72 73
 				<li><a href="', $scripturl, '?action=moderate;area=reportedposts;sa=handle;closed=', (int) !$report['closed'], ';rid=', $report['id'], ';start=', $context['start'], ';', $context['session_var'], '=', $context['session_id'], ';', $context['mod-report-closed_token_var'], '=', $context['mod-report-closed_token'], '">', $close_button, '</a></li>';
73 74
 
74 75
 		// Delete message button.
75
-		if (!$report['closed'] && (is_array($context['report_remove_any_boards']) && in_array($report['topic']['id_board'], $context['report_remove_any_boards'])))
76
-			echo '
76
+		if (!$report['closed'] && (is_array($context['report_remove_any_boards']) && in_array($report['topic']['id_board'], $context['report_remove_any_boards']))) {
77
+					echo '
77 78
 				<li><a href="', $scripturl, '?action=deletemsg;topic=', $report['topic']['id'], '.0;msg=', $report['topic']['id_msg'], ';modcenter;', $context['session_var'], '=', $context['session_id'], '" data-confirm="', $txt['mc_reportedp_delete_confirm'], '" class="you_sure">', $delete_button, '</a></li>';
79
+		}
78 80
 
79 81
 		// Ban this user button.
80
-		if (!$report['closed'] && !empty($context['report_manage_bans']))
81
-			echo '
82
+		if (!$report['closed'] && !empty($context['report_manage_bans'])) {
83
+					echo '
82 84
 				<li><a href="', $scripturl, '?action=admin;area=ban;sa=add', (!empty($report['author']['id']) ? ';u=' . $report['author']['id'] : ';msg=' . $report['topic']['id_msg']), ';', $context['session_var'], '=', $context['session_id'], '">', $ban_button, '</a></li>';
85
+		}
83 86
 
84
-		if (!$context['view_closed'])
85
-			echo '
87
+		if (!$context['view_closed']) {
88
+					echo '
86 89
 				<li><input type="checkbox" name="close[]" value="' . $report['id'] . '"></li>';
90
+		}
87 91
 
88 92
 			echo '
89 93
 			</ul>
@@ -91,18 +95,20 @@  discard block
 block discarded – undo
91 95
 	}
92 96
 
93 97
 	// Were none found?
94
-	if (empty($context['reports']))
95
-		echo '
98
+	if (empty($context['reports'])) {
99
+			echo '
96 100
 		<div class="windowbg2">
97 101
 			<p class="centertext">', $txt['mc_reportedp_none_found'], '</p>
98 102
 		</div>';
103
+	}
99 104
 
100 105
 	echo '
101 106
 		<div class="pagesection">';
102 107
 	
103
-	if (!empty($context['total_reports']) && $context['total_reports'] >= $context['reports_how_many'])
104
-		echo '
108
+	if (!empty($context['total_reports']) && $context['total_reports'] >= $context['reports_how_many']) {
109
+			echo '
105 110
 			<div class="pagelinks floatleft">' . $context['page_index'] . '</div>';
111
+	}
106 112
 
107 113
 	echo '
108 114
 			<div class="floatright">', !$context['view_closed'] ? '
@@ -133,18 +139,20 @@  discard block
 block discarded – undo
133 139
 			<div class="modbox">
134 140
 				<ul>';
135 141
 
136
-	foreach ($context['reported_posts'] as $report)
137
-		echo '
142
+	foreach ($context['reported_posts'] as $report) {
143
+			echo '
138 144
 					<li class="smalltext">
139 145
 						<a href="', $report['report_href'], '">', $report['subject'], '</a> ', $txt['mc_reportedp_by'], ' ', $report['author']['link'], '
140 146
 					</li>';
147
+	}
141 148
 
142 149
 	// Don't have any watched users right now?
143
-	if (empty($context['reported_posts']))
144
-		echo '
150
+	if (empty($context['reported_posts'])) {
151
+			echo '
145 152
 					<li>
146 153
 						<strong class="smalltext">', $txt['mc_recent_reports_none'], '</strong>
147 154
 					</li>';
155
+	}
148 156
 
149 157
 	echo '
150 158
 				</ul>
@@ -234,14 +242,15 @@  discard block
 block discarded – undo
234 242
 				<h3 class="catbg">', $txt['mc_modreport_whoreported_title'], '</h3>
235 243
 			</div>';
236 244
 
237
-	foreach ($context['report']['comments'] as $comment)
238
-		echo '
245
+	foreach ($context['report']['comments'] as $comment) {
246
+			echo '
239 247
 			<div class="windowbg">
240 248
 				<p class="smalltext">
241 249
 					', sprintf($txt['mc_modreport_whoreported_data'], $comment['member']['link'] . (empty($comment['member']['id']) && !empty($comment['member']['ip']) ? ' (' . $comment['member']['ip'] . ')' : ''), $comment['time']), '
242 250
 				</p>
243 251
 				<p>', $comment['message'], '</p>
244 252
 			</div>';
253
+	}
245 254
 
246 255
 	echo '
247 256
 			<br>
@@ -250,11 +259,12 @@  discard block
 block discarded – undo
250 259
 			</div>
251 260
 			<div>';
252 261
 
253
-	if (empty($context['report']['mod_comments']))
254
-		echo '
262
+	if (empty($context['report']['mod_comments'])) {
263
+			echo '
255 264
 				<div class="information">
256 265
 					<p class="centertext">', $txt['mc_modreport_no_mod_comment'], '</p>
257 266
 				</div>';
267
+	}
258 268
 
259 269
 	foreach ($context['report']['mod_comments'] as $comment)
260 270
 	{
@@ -346,18 +356,20 @@  discard block
 block discarded – undo
346 356
 			<div class="modbox">
347 357
 				<ul>';
348 358
 
349
-	foreach ($context['reported_members'] as $report)
350
-		echo '
359
+	foreach ($context['reported_members'] as $report) {
360
+			echo '
351 361
 					<li class="smalltext">
352 362
 						<a href="', $report['report_href'], '">', $report['user_name'], '</a>
353 363
 					</li>';
364
+	}
354 365
 
355 366
 	// Don't have any reported members right now?
356
-	if (empty($context['reported_members']))
357
-		echo '
367
+	if (empty($context['reported_members'])) {
368
+			echo '
358 369
 					<li>
359 370
 						<strong class="smalltext">', $txt['mc_recent_reports_none'], '</strong>
360 371
 					</li>';
372
+	}
361 373
 
362 374
 	echo '
363 375
 				</ul>
@@ -443,8 +455,9 @@  discard block
 block discarded – undo
443 455
 
444 456
 		// Prepare the comments...
445 457
 		$comments = array();
446
-		foreach ($report['comments'] as $comment)
447
-			$comments[$comment['member']['id']] = $comment['member']['link'];
458
+		foreach ($report['comments'] as $comment) {
459
+					$comments[$comment['member']['id']] = $comment['member']['link'];
460
+		}
448 461
 
449 462
 		echo '
450 463
 				', $txt['mc_reportedp_reported_by'], ': ', implode(', ', $comments), '
@@ -456,13 +469,15 @@  discard block
 block discarded – undo
456 469
 				<li><a href="', $scripturl, '?action=moderate;area=reportedmembers;sa=handle;closed=', (int) !$report['closed'], ';rid=', $report['id'], ';start=', $context['start'], ';', $context['session_var'], '=', $context['session_id'], ';', $context['mod-report-closed_token_var'], '=', $context['mod-report-closed_token'], '">', $close_button, '</a></li>';
457 470
 
458 471
 		// Ban this user button.
459
-		if (!$report['closed'] && !empty($context['report_manage_bans']) && !empty($report['user']['id']))
460
-			echo '
472
+		if (!$report['closed'] && !empty($context['report_manage_bans']) && !empty($report['user']['id'])) {
473
+					echo '
461 474
 				<li><a href="', $scripturl, '?action=admin;area=ban;sa=add;u=', $report['user']['id'], ';', $context['session_var'], '=', $context['session_id'], '">', $ban_button, '</a></li>';
475
+		}
462 476
 
463
-		if (!$context['view_closed'])
464
-			echo '
477
+		if (!$context['view_closed']) {
478
+					echo '
465 479
 				<li><input type="checkbox" name="close[]" value="' . $report['id'] . '"></li>';
480
+		}
466 481
 
467 482
 			echo '
468 483
 			</ul>
@@ -470,11 +485,12 @@  discard block
 block discarded – undo
470 485
 	}
471 486
 
472 487
 	// Were none found?
473
-	if (empty($context['reports']))
474
-		echo '
488
+	if (empty($context['reports'])) {
489
+			echo '
475 490
 		<div class="windowbg2">
476 491
 			<p class="centertext">', $txt['mc_reportedp_none_found'], '</p>
477 492
 		</div>';
493
+	}
478 494
 
479 495
 	echo '
480 496
 		<div class="pagesection">
@@ -534,14 +550,15 @@  discard block
 block discarded – undo
534 550
 				<h3 class="catbg">', $txt['mc_memberreport_whoreported_title'], '</h3>
535 551
 			</div>';
536 552
 
537
-	foreach ($context['report']['comments'] as $comment)
538
-		echo '
553
+	foreach ($context['report']['comments'] as $comment) {
554
+			echo '
539 555
 			<div class="windowbg">
540 556
 				<p class="smalltext">
541 557
 					', sprintf($txt['mc_modreport_whoreported_data'], $comment['member']['link'] . (empty($comment['member']['id']) && !empty($comment['member']['ip']) ? ' (' . $comment['member']['ip'] . ')' : ''), $comment['time']), '
542 558
 				</p>
543 559
 				<p>', $comment['message'], '</p>
544 560
 			</div>';
561
+	}
545 562
 
546 563
 	echo '
547 564
 			<br>
@@ -550,11 +567,12 @@  discard block
 block discarded – undo
550 567
 			</div>
551 568
 			<div>';
552 569
 
553
-	if (empty($context['report']['mod_comments']))
554
-		echo '
570
+	if (empty($context['report']['mod_comments'])) {
571
+			echo '
555 572
 				<div class="information">
556 573
 					<p class="centertext">', $txt['mc_modreport_no_mod_comment'], '</p>
557 574
 				</div>';
575
+	}
558 576
 
559 577
 	foreach ($context['report']['mod_comments'] as $comment)
560 578
 	{
Please login to merge, or discard this patch.
Themes/default/ReportToMod.template.php 1 patch
Braces   +6 added lines, -5 removed lines patch added patch discarded remove patch
@@ -62,16 +62,17 @@
 block discarded – undo
62 62
 				<div id="error_box" class="errorbox">
63 63
 					<ul id="error_list">';
64 64
 
65
-		foreach ($context['post_errors'] as $key => $error)
66
-			echo '
65
+		foreach ($context['post_errors'] as $key => $error) {
66
+					echo '
67 67
 						<li id="error_', $key, '" class="error">', $error, '</li>';
68
+		}
68 69
 
69 70
 		echo '
70 71
 					</ul>';
71
-	}
72
-	else
73
-		echo '
72
+	} else {
73
+			echo '
74 74
 					<div style="display:none" id="error_box" class="errorbox">';
75
+	}
75 76
 
76 77
 	echo '
77 78
 					</div>';
Please login to merge, or discard this patch.
Themes/default/ManageMaintenance.template.php 1 patch
Braces   +36 added lines, -25 removed lines patch added patch discarded remove patch
@@ -18,11 +18,12 @@  discard block
 block discarded – undo
18 18
 	global $context, $txt, $scripturl, $modSettings;
19 19
 
20 20
 	// If maintenance has finished tell the user.
21
-	if (!empty($context['maintenance_finished']))
22
-		echo '
21
+	if (!empty($context['maintenance_finished'])) {
22
+			echo '
23 23
 	<div class="infobox">
24 24
 		', sprintf($txt['maintain_done'], $context['maintenance_finished']), '
25 25
 	</div>';
26
+	}
26 27
 
27 28
 	echo '
28 29
 	<div id="manage_maintenance">
@@ -107,11 +108,12 @@  discard block
 block discarded – undo
107 108
 	<div id="manage_maintenance">';
108 109
 
109 110
 	// If maintenance has finished tell the user.
110
-	if (!empty($context['maintenance_finished']))
111
-		echo '
111
+	if (!empty($context['maintenance_finished'])) {
112
+			echo '
112 113
 		<div class="infobox">
113 114
 			', sprintf($txt['maintain_done'], $context['maintenance_finished']), '
114 115
 		</div>';
116
+	}
115 117
 
116 118
 	echo '
117 119
 		<div class="cat_bar">
@@ -243,11 +245,12 @@  discard block
 block discarded – undo
243 245
 	<div id="manage_maintenance">';
244 246
 
245 247
 	// If maintenance has finished tell the user.
246
-	if (!empty($context['maintenance_finished']))
247
-	echo '
248
+	if (!empty($context['maintenance_finished'])) {
249
+		echo '
248 250
 		<div class="infobox">
249 251
 			', sprintf($txt['maintain_done'], $context['maintenance_finished']), '
250 252
 		</div>';
253
+	}
251 254
 
252 255
 	echo '
253 256
 		<div class="cat_bar">
@@ -311,9 +314,10 @@  discard block
 block discarded – undo
311 314
 				</p>
312 315
 				<div style="display: none; padding: 3px" id="membersPanel">';
313 316
 
314
-	foreach ($context['membergroups'] as $group)
315
-		echo '
317
+	foreach ($context['membergroups'] as $group) {
318
+			echo '
316 319
 					<label for="groups', $group['id'], '"><input type="checkbox" name="groups[', $group['id'], ']" id="groups', $group['id'], '" checked> ', $group['name'], '</label><br>';
320
+	}
317 321
 
318 322
 	echo '
319 323
 				</div>
@@ -357,11 +361,12 @@  discard block
 block discarded – undo
357 361
 	global $scripturl, $txt, $context, $settings, $modSettings;
358 362
 
359 363
 	// If maintenance has finished tell the user.
360
-	if (!empty($context['maintenance_finished']))
361
-		echo '
364
+	if (!empty($context['maintenance_finished'])) {
365
+			echo '
362 366
 	<div class="infobox">
363 367
 		', sprintf($txt['maintain_done'], $context['maintenance_finished']), '
364 368
 	</div>';
369
+	}
365 370
 
366 371
 	// Bit of javascript for showing which boards to prune in an otherwise hidden list.
367 372
 	echo '
@@ -429,21 +434,23 @@  discard block
 block discarded – undo
429 434
 								<ul>';
430 435
 
431 436
 		// Display a checkbox with every board.
432
-		foreach ($category['boards'] as $board)
433
-			echo '
437
+		foreach ($category['boards'] as $board) {
438
+					echo '
434 439
 									<li style="margin-', $context['right_to_left'] ? 'right' : 'left', ': ', $board['child_level'] * 1.5, 'em;">
435 440
 										<label for="boards_', $board['id'], '"><input type="checkbox" name="boards[', $board['id'], ']" id="boards_', $board['id'], '" checked>', $board['name'], '</label>
436 441
 									</li>';
442
+		}
437 443
 
438 444
 		echo '
439 445
 								</ul>
440 446
 							</fieldset>';
441 447
 
442 448
 		// Increase $i, and check if we're at the middle yet.
443
-		if (++$i == $middle)
444
-			echo '
449
+		if (++$i == $middle) {
450
+					echo '
445 451
 						</div><!-- .floatleft -->
446 452
 						<div class="floatright" style="width: 49%;">';
453
+		}
447 454
 	}
448 455
 
449 456
 	echo '
@@ -485,9 +492,10 @@  discard block
 block discarded – undo
485 492
 		echo '
486 493
 						<optgroup label="', $category['name'], '">';
487 494
 
488
-		foreach ($category['boards'] as $board)
489
-			echo '
495
+		foreach ($category['boards'] as $board) {
496
+					echo '
490 497
 							<option value="', $board['id'], '"> ', str_repeat('==', $board['child_level']), '=&gt;&nbsp;', $board['name'], '</option>';
498
+		}
491 499
 
492 500
 		echo '
493 501
 						</optgroup>';
@@ -505,9 +513,10 @@  discard block
 block discarded – undo
505 513
 		echo '
506 514
 						<optgroup label="', $category['name'], '">';
507 515
 
508
-		foreach ($category['boards'] as $board)
509
-			echo '
516
+		foreach ($category['boards'] as $board) {
517
+					echo '
510 518
 							<option value="', $board['id'], '"> ', str_repeat('==', $board['child_level']), '=&gt;&nbsp;', $board['name'], '</option>';
519
+		}
511 520
 
512 521
 		echo '
513 522
 						</optgroup>';
@@ -548,9 +557,10 @@  discard block
 block discarded – undo
548 557
 				', $txt['database_optimize_attempt'], '<br>';
549 558
 
550 559
 	// List each table being optimized...
551
-	foreach ($context['optimized_tables'] as $table)
552
-		echo '
560
+	foreach ($context['optimized_tables'] as $table) {
561
+			echo '
553 562
 				', sprintf($txt['database_optimizing'], $table['name'], $table['data_freed']), '<br>';
563
+	}
554 564
 
555 565
 	// How did we go?
556 566
 	echo '
@@ -610,13 +620,14 @@  discard block
 block discarded – undo
610 620
 				</li>
611 621
 			</ul>';
612 622
 
613
-		if (!empty($context['exceeding_messages_morethan']))
614
-			echo '
623
+		if (!empty($context['exceeding_messages_morethan'])) {
624
+					echo '
615 625
 			<p>', $context['exceeding_messages_morethan'], '</p>';
616
-	}
617
-	else
618
-		echo '
626
+		}
627
+	} else {
628
+			echo '
619 629
 			<p class="infobox">', $txt['convert_to_text'], '</p>';
630
+	}
620 631
 
621 632
 	echo '
622 633
 			<form action="', $scripturl, '?action=admin;area=maintain;sa=database;activity=convertmsgbody" method="post" accept-charset="', $context['character_set'], '">
Please login to merge, or discard this patch.
Themes/default/Who.template.php 1 patch
Braces   +39 added lines, -27 removed lines patch added patch discarded remove patch
@@ -31,9 +31,10 @@  discard block
 block discarded – undo
31 31
 					<div class="selectbox floatright" id="upper_show">', $txt['who_show1'], '
32 32
 						<select name="show_top" onchange="document.forms.whoFilter.show.value = this.value; document.forms.whoFilter.submit();">';
33 33
 
34
-	foreach ($context['show_methods'] as $value => $label)
35
-		echo '
34
+	foreach ($context['show_methods'] as $value => $label) {
35
+			echo '
36 36
 							<option value="', $value, '" ', $value == $context['show_by'] ? ' selected' : '', '>', $label, '</option>';
37
+	}
37 38
 	echo '
38 39
 						</select>
39 40
 						<noscript>
@@ -71,9 +72,10 @@  discard block
 block discarded – undo
71 72
 									', $member['is_guest'] ? $member['name'] : '<a href="' . $member['href'] . '" title="' . $txt['profile_of'] . ' ' . $member['name'] . '"' . (empty($member['color']) ? '' : ' style="color: ' . $member['color'] . '"') . '>' . $member['name'] . '</a>', '
72 73
 								</span>';
73 74
 
74
-		if (!empty($member['ip']))
75
-			echo '
75
+		if (!empty($member['ip'])) {
76
+					echo '
76 77
 								(<a href="' . $scripturl . '?action=', ($member['is_guest'] ? 'trackip' : 'profile;area=tracking;sa=ip;u=' . $member['id']), ';searchip=' . $member['ip'] . '">' . $member['ip'] . '</a>)';
78
+		}
77 79
 
78 80
 		echo '
79 81
 							</td>
@@ -103,9 +105,10 @@  discard block
 block discarded – undo
103 105
 					<div class="selectbox floatright">', $txt['who_show1'], '
104 106
 						<select name="show" onchange="document.forms.whoFilter.submit();">';
105 107
 
106
-	foreach ($context['show_methods'] as $value => $label)
107
-		echo '
108
+	foreach ($context['show_methods'] as $value => $label) {
109
+			echo '
108 110
 							<option value="', $value, '" ', $value == $context['show_by'] ? ' selected' : '', '>', $label, '</option>';
111
+	}
109 112
 	echo '
110 113
 						</select>
111 114
 						<noscript>
@@ -134,17 +137,19 @@  discard block
 block discarded – undo
134 137
 
135 138
 	foreach ($context['credits'] as $section)
136 139
 	{
137
-		if (isset($section['pretext']))
138
-			echo '
140
+		if (isset($section['pretext'])) {
141
+					echo '
139 142
 		<div class="windowbg noup">
140 143
 			<p>', $section['pretext'], '</p>
141 144
 		</div>';
145
+		}
142 146
 
143
-		if (isset($section['title']))
144
-			echo '
147
+		if (isset($section['title'])) {
148
+					echo '
145 149
 		<div class="cat_bar">
146 150
 			<h3 class="catbg">', $section['title'], '</h3>
147 151
 		</div>';
152
+		}
148 153
 
149 154
 		echo '
150 155
 		<div class="windowbg2 noup">
@@ -152,17 +157,18 @@  discard block
 block discarded – undo
152 157
 
153 158
 		foreach ($section['groups'] as $group)
154 159
 		{
155
-			if (isset($group['title']))
156
-				echo '
160
+			if (isset($group['title'])) {
161
+							echo '
157 162
 				<dt>
158 163
 					<strong>', $group['title'], '</strong>
159 164
 				</dt>
160 165
 				<dd>';
166
+			}
161 167
 
162 168
 			// Try to make this read nicely.
163
-			if (count($group['members']) <= 2)
164
-				echo implode(' ' . $txt['credits_and'] . ' ', $group['members']);
165
-			else
169
+			if (count($group['members']) <= 2) {
170
+							echo implode(' ' . $txt['credits_and'] . ' ', $group['members']);
171
+			} else
166 172
 			{
167 173
 				$last_peep = array_pop($group['members']);
168 174
 				echo implode(', ', $group['members']), ' ', $txt['credits_and'], ' ', $last_peep;
@@ -175,9 +181,10 @@  discard block
 block discarded – undo
175 181
 		echo '
176 182
 			</dl>';
177 183
 
178
-		if (isset($section['posttext']))
179
-			echo '
184
+		if (isset($section['posttext'])) {
185
+					echo '
180 186
 				<p class="posttext">', $section['posttext'], '</p>';
187
+		}
181 188
 
182 189
 		echo '
183 190
 		</div>';
@@ -192,26 +199,29 @@  discard block
 block discarded – undo
192 199
 		</div>
193 200
 		<div class="windowbg noup">';
194 201
 
195
-		if (!empty($context['credits_software_graphics']['graphics']))
196
-			echo '
202
+		if (!empty($context['credits_software_graphics']['graphics'])) {
203
+					echo '
197 204
 			<dl>
198 205
 				<dt><strong>', $txt['credits_graphics'], '</strong></dt>
199 206
 				<dd>', implode('</dd><dd>', $context['credits_software_graphics']['graphics']), '</dd>
200 207
 			</dl>';
208
+		}
201 209
 
202
-		if (!empty($context['credits_software_graphics']['software']))
203
-			echo '
210
+		if (!empty($context['credits_software_graphics']['software'])) {
211
+					echo '
204 212
 			<dl>
205 213
 				<dt><strong>', $txt['credits_software'], '</strong></dt>
206 214
 				<dd>', implode('</dd><dd>', $context['credits_software_graphics']['software']), '</dd>
207 215
 			</dl>';
216
+		}
208 217
 
209
-		if (!empty($context['credits_software_graphics']['fonts']))
210
-			echo '
218
+		if (!empty($context['credits_software_graphics']['fonts'])) {
219
+					echo '
211 220
 			<dl>
212 221
 				<dt><strong>', $txt['credits_fonts'], '</strong></dt>
213 222
 				<dd>', implode('</dd><dd>', $context['credits_software_graphics']['fonts']), '</dd>
214 223
 			</dl>';
224
+		}
215 225
 		echo '
216 226
 		</div>';
217 227
 	}
@@ -227,14 +237,16 @@  discard block
 block discarded – undo
227 237
 			<ul>';
228 238
 
229 239
 		// Display the credits.
230
-		if (!empty($context['credits_modifications']))
231
-			echo '
240
+		if (!empty($context['credits_modifications'])) {
241
+					echo '
232 242
 				<li>', implode('</li><li>', $context['credits_modifications']), '</li>';
243
+		}
233 244
 
234 245
 		// Legacy.
235
-		if (!empty($context['copyrights']['mods']))
236
-			echo '
246
+		if (!empty($context['copyrights']['mods'])) {
247
+					echo '
237 248
 				<li>', implode('</li><li>', $context['copyrights']['mods']), '</li>';
249
+		}
238 250
 
239 251
 		echo '
240 252
 			</ul>
Please login to merge, or discard this patch.
Themes/default/Poll.template.php 1 patch
Braces   +12 added lines, -8 removed lines patch added patch discarded remove patch
@@ -46,8 +46,8 @@  discard block
 block discarded – undo
46 46
 				<h3 class="catbg">', $context['page_title'], '</h3>
47 47
 			</div>';
48 48
 
49
-	if (!empty($context['poll_error']['messages']))
50
-		echo '
49
+	if (!empty($context['poll_error']['messages'])) {
50
+			echo '
51 51
 			<div class="errorbox">
52 52
 				<dl class="poll_error">
53 53
 					<dt>
@@ -58,6 +58,7 @@  discard block
 block discarded – undo
58 58
 					</dt>
59 59
 				</dl>
60 60
 			</div>';
61
+	}
61 62
 
62 63
 	echo '
63 64
 			<div>
@@ -79,8 +80,9 @@  discard block
 block discarded – undo
79 80
 								<input type="text" name="options[', $choice['id'], ']" id="options-', $choice['id'], '" value="', $choice['label'], '" size="80" maxlength="255">';
80 81
 
81 82
 		// Does this option have a vote count yet, or is it new?
82
-		if ($choice['votes'] != -1)
83
-			echo ' (', $choice['votes'], ' ', $txt['votes'], ')';
83
+		if ($choice['votes'] != -1) {
84
+					echo ' (', $choice['votes'], ' ', $txt['votes'], ')';
85
+		}
84 86
 
85 87
 		echo '
86 88
 							</dd>';
@@ -118,14 +120,15 @@  discard block
 block discarded – undo
118 120
 								<input type="checkbox" id="poll_change_vote" name="poll_change_vote"', !empty($context['poll']['change_vote']) ? ' checked' : '', '>
119 121
 							</dd>';
120 122
 
121
-		if ($context['poll']['guest_vote_allowed'])
122
-			echo '
123
+		if ($context['poll']['guest_vote_allowed']) {
124
+					echo '
123 125
 							<dt>
124 126
 								<label for="poll_guest_vote">', $txt['poll_guest_vote'], ':</label>
125 127
 							</dt>
126 128
 							<dd>
127 129
 								<input type="checkbox" id="poll_guest_vote" name="poll_guest_vote"', !empty($context['poll']['guest_vote']) ? ' checked' : '', '>
128 130
 							</dd>';
131
+		}
129 132
 	}
130 133
 
131 134
 	echo '
@@ -141,12 +144,13 @@  discard block
 block discarded – undo
141 144
 					</fieldset>';
142 145
 
143 146
 	// If this is an edit, we can allow them to reset the vote counts.
144
-	if ($context['is_edit'])
145
-		echo '
147
+	if ($context['is_edit']) {
148
+			echo '
146 149
 					<fieldset id="poll_reset">
147 150
 						<legend>', $txt['reset_votes'], '</legend>
148 151
 						<input type="checkbox" name="resetVoteCount" value="on"> ' . $txt['reset_votes_check'] . '
149 152
 					</fieldset>';
153
+	}
150 154
 	echo '
151 155
 					<input type="submit" name="post" value="', $txt['save'], '" onclick="return submitThisOnce(this);" accesskey="s" class="button">
152 156
 				</div><!-- .roundframe -->
Please login to merge, or discard this patch.
Themes/default/Post.template.php 2 patches
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -422,8 +422,8 @@  discard block
 block discarded – undo
422 422
 									</div><!-- .attached_BBC -->
423 423
 									<div class="progressBar" role="progressBar" aria-valuemin="0" aria-valuemax="100" aria-valuenow="0"><span></span></div>
424 424
 									<div class="attach-ui">
425
-										<a data-dz-remove class="button cancel">', $txt['modify_cancel'] ,'</a>
426
-										<a class="button upload">', $txt['upload'] ,'</a>
425
+										<a data-dz-remove class="button cancel">', $txt['modify_cancel'], '</a>
426
+										<a class="button upload">', $txt['upload'], '</a>
427 427
 									</div>
428 428
 								</div><!-- .attach-info -->
429 429
 							</div><!-- #au-template -->
@@ -441,10 +441,10 @@  discard block
 block discarded – undo
441 441
 							</dt>
442 442
 							<dd class="smalltext fallback">
443 443
 								<div id="attachUpload" class="descbox">
444
-									<h5>', $txt['attach_drop_zone'] ,'</h5>
445
-									<a class="button" id="attach-cancelAll">', $txt['attached_cancelAll'] ,'</a>
446
-									<a class="button" id="attach-uploadAll">', $txt['attached_uploadAll'] ,'</a>
447
-									<a class="button fileinput-button">', $txt['attach_add'] ,'</a>
444
+									<h5>', $txt['attach_drop_zone'], '</h5>
445
+									<a class="button" id="attach-cancelAll">', $txt['attached_cancelAll'], '</a>
446
+									<a class="button" id="attach-uploadAll">', $txt['attached_uploadAll'], '</a>
447
+									<a class="button fileinput-button">', $txt['attach_add'], '</a>
448 448
 									<div id="total-progress" class="progressBar" role="progressBar" aria-valuemin="0" aria-valuemax="100" aria-valuenow="0"><span></span></div>
449 449
 									<div class="fallback">
450 450
 										<input type="file" multiple="multiple" name="attachment[]" id="attachment1" class="fallback"> (<a href="javascript:void(0);" onclick="cleanFileInput(\'attachment1\');">', $txt['clean_attach'], '</a>)
@@ -552,7 +552,7 @@  discard block
 block discarded – undo
552 552
 	// Option to delete an event if user is editing one.
553 553
 	if ($context['make_event'] && !$context['event']['new'])
554 554
 		echo '
555
-						<input type="submit" name="deleteevent" value="', $txt['event_delete'], '" data-confirm="', $txt['event_delete_confirm'] ,'" class="button you_sure">';
555
+						<input type="submit" name="deleteevent" value="', $txt['event_delete'], '" data-confirm="', $txt['event_delete_confirm'], '" class="button you_sure">';
556 556
 
557 557
 	echo '
558 558
 					</span>
@@ -806,7 +806,7 @@  discard block
 block discarded – undo
806 806
 			});';
807 807
 
808 808
 	echo '
809
-			var oEditorID = "', $context['post_box_name'] ,'";
809
+			var oEditorID = "', $context['post_box_name'], '";
810 810
 			var oEditorObject = oEditorHandle_', $context['post_box_name'], ';
811 811
 		</script>';
812 812
 
@@ -838,7 +838,7 @@  discard block
 block discarded – undo
838 838
 			{
839 839
 				echo '
840 840
 					<ul class="quickbuttons" id="msg_', $post['id'], '_quote">
841
-						<li style="display:none;" id="quoteSelected_', $post['id'], '" data-msgid="', $post['id'], '"><a href="javascript:void(0)"><span class="generic_icons quote_selected"></span>', $txt['quote_selected_action'] ,'</a></li>
841
+						<li style="display:none;" id="quoteSelected_', $post['id'], '" data-msgid="', $post['id'], '"><a href="javascript:void(0)"><span class="generic_icons quote_selected"></span>', $txt['quote_selected_action'], '</a></li>
842 842
 						<li id="post_modify"><a href="#postmodify" onclick="return insertQuoteFast(', $post['id'], ');"><span class="generic_icons quote"></span>', $txt['quote'], '</a></li>
843 843
 					</ul>';
844 844
 			}
@@ -925,7 +925,7 @@  discard block
 block discarded – undo
925 925
 	<head>
926 926
 		<meta charset="', $context['character_set'], '">
927 927
 		<title>', $txt['spell_check'], '</title>
928
-		<link rel="stylesheet" href="', $settings['theme_url'], '/css/index', $context['theme_variant'], '.css', $modSettings['browser_cache'] ,'">
928
+		<link rel="stylesheet" href="', $settings['theme_url'], '/css/index', $context['theme_variant'], '.css', $modSettings['browser_cache'], '">
929 929
 		<style>
930 930
 			body, td {
931 931
 				font-size: small;
@@ -955,8 +955,8 @@  discard block
 block discarded – undo
955 955
 			var spell_formname = window.opener.spell_formname;
956 956
 			var spell_fieldname = window.opener.spell_fieldname;
957 957
 		</script>
958
-		<script src="', $settings['default_theme_url'], '/scripts/spellcheck.js', $modSettings['browser_cache'] ,'"></script>
959
-		<script src="', $settings['default_theme_url'], '/scripts/script.js', $modSettings['browser_cache'] ,'"></script>
958
+		<script src="', $settings['default_theme_url'], '/scripts/spellcheck.js', $modSettings['browser_cache'], '"></script>
959
+		<script src="', $settings['default_theme_url'], '/scripts/script.js', $modSettings['browser_cache'], '"></script>
960 960
 		<script>
961 961
 			', $context['spell_js'], '
962 962
 		</script>
@@ -1000,7 +1000,7 @@  discard block
 block discarded – undo
1000 1000
 	<head>
1001 1001
 		<meta charset="', $context['character_set'], '">
1002 1002
 		<title>', $txt['retrieving_quote'], '</title>
1003
-		<script src="', $settings['default_theme_url'], '/scripts/script.js', $modSettings['browser_cache'] ,'"></script>
1003
+		<script src="', $settings['default_theme_url'], '/scripts/script.js', $modSettings['browser_cache'], '"></script>
1004 1004
 	</head>
1005 1005
 	<body>
1006 1006
 		', $txt['retrieving_quote'], '
Please login to merge, or discard this patch.
Braces   +89 added lines, -61 removed lines patch added patch discarded remove patch
@@ -22,23 +22,25 @@  discard block
 block discarded – undo
22 22
 		<script>';
23 23
 
24 24
 	// When using Go Back due to fatal_error, allow the form to be re-submitted with changes.
25
-	if (isBrowser('is_firefox'))
26
-		echo '
25
+	if (isBrowser('is_firefox')) {
26
+			echo '
27 27
 			window.addEventListener("pageshow", reActivate, false);';
28
+	}
28 29
 
29 30
 	// Start with message icons - and any missing from this theme.
30 31
 	echo '
31 32
 			var icon_urls = {';
32 33
 
33
-	foreach ($context['icons'] as $icon)
34
-		echo '
34
+	foreach ($context['icons'] as $icon) {
35
+			echo '
35 36
 				\'', $icon['value'], '\': \'', $icon['url'], '\'', $icon['is_last'] ? '' : ',';
37
+	}
36 38
 	echo '
37 39
 			};';
38 40
 
39 41
 	// If this is a poll - use some javascript to ensure the user doesn't create a poll with illegal option combinations.
40
-	if ($context['make_poll'])
41
-		echo '
42
+	if ($context['make_poll']) {
43
+			echo '
42 44
 			var pollOptionNum = 0, pollTabIndex;
43 45
 			var pollOptionId = ', $context['last_choice_id'], ';
44 46
 			function addPollOption()
@@ -57,11 +59,13 @@  discard block
 block discarded – undo
57 59
 
58 60
 				setOuterHTML(document.getElementById(\'pollMoreOptions\'), ', JavaScriptEscape('<dt><label for="options-'), ' + pollOptionId + ', JavaScriptEscape('">' . $txt['option'] . ' '), ' + pollOptionNum + ', JavaScriptEscape('</label>:</dt><dd><input type="text" name="options['), ' + pollOptionId + ', JavaScriptEscape(']" id="options-'), ' + pollOptionId + ', JavaScriptEscape('" value="" size="80" maxlength="255" tabindex="'), ' + pollTabIndex + ', JavaScriptEscape('"></dd><p id="pollMoreOptions"></p>'), ');
59 61
 			}';
62
+	}
60 63
 
61 64
 	// If we are making a calendar event we want to ensure we show the current days in a month etc... this is done here.
62
-	if ($context['make_event'])
63
-		echo '
65
+	if ($context['make_event']) {
66
+			echo '
64 67
 			var monthLength = [31, 28, 31, 30, 31, 30, 31, 31, 30, 31, 30, 31];';
68
+	}
65 69
 
66 70
 	// End of the javascript, start the form and display the link tree.
67 71
 	echo '
@@ -82,9 +86,10 @@  discard block
 block discarded – undo
82 86
 			</div>
83 87
 			<br>';
84 88
 
85
-	if ($context['make_event'] && (!$context['event']['new'] || !empty($context['current_board'])))
86
-		echo '
89
+	if ($context['make_event'] && (!$context['event']['new'] || !empty($context['current_board']))) {
90
+			echo '
87 91
 			<input type="hidden" name="eventid" value="', $context['event']['id'], '">';
92
+	}
88 93
 
89 94
 	// Start the main table.
90 95
 	echo '
@@ -119,18 +124,20 @@  discard block
 block discarded – undo
119 124
 	}
120 125
 
121 126
 	// If it's locked, show a message to warn the replier.
122
-	if (!empty($context['locked']))
123
-	echo '
127
+	if (!empty($context['locked'])) {
128
+		echo '
124 129
 					<div class="errorbox">
125 130
 						', $txt['topic_locked_no_reply'], '
126 131
 					</div>';
132
+	}
127 133
 
128
-	if (!empty($modSettings['drafts_post_enabled']))
129
-		echo '
134
+	if (!empty($modSettings['drafts_post_enabled'])) {
135
+			echo '
130 136
 					<div id="draft_section" class="infobox"', isset($context['draft_saved']) ? '' : ' style="display: none;"', '>',
131 137
 						sprintf($txt['draft_saved'], $scripturl . '?action=profile;u=' . $context['user']['id'] . ';area=showdrafts'), '
132 138
 						', (!empty($modSettings['drafts_keep_days']) ? ' <strong>' . sprintf($txt['draft_save_warning'], $modSettings['drafts_keep_days']) . '</strong>' : ''), '
133 139
 					</div>';
140
+	}
134 141
 
135 142
 	// The post header... important stuff
136 143
 	echo '
@@ -183,9 +190,10 @@  discard block
 block discarded – undo
183 190
 				echo '
184 191
 										<optgroup label="', $category['name'], '">';
185 192
 
186
-				foreach ($category['boards'] as $board)
187
-					echo '
193
+				foreach ($category['boards'] as $board) {
194
+									echo '
188 195
 											<option value="', $board['id'], '"', $board['selected'] ? ' selected' : '', '>', $board['child_level'] > 0 ? str_repeat('==', $board['child_level'] - 1) . '=&gt;' : '', ' ', $board['name'], '&nbsp;</option>';
196
+				}
189 197
 				echo '
190 198
 										</optgroup>';
191 199
 			}
@@ -221,9 +229,10 @@  discard block
 block discarded – undo
221 229
 									<span class="label">', $txt['calendar_timezone'], '</span>
222 230
 									<select name="tz" id="tz"', !empty($context['event']['allday']) ? ' disabled' : '', '>';
223 231
 
224
-		foreach ($context['all_timezones'] as $tz => $tzname)
225
-			echo '
232
+		foreach ($context['all_timezones'] as $tz => $tzname) {
233
+					echo '
226 234
 										<option value="', $tz, '"', $tz == $context['event']['tz'] ? ' selected' : '', '>', $tzname, '</option>';
235
+		}
227 236
 
228 237
 		echo '
229 238
 									</select>
@@ -291,14 +300,15 @@  discard block
 block discarded – undo
291 300
 									<input type="checkbox" id="poll_change_vote" name="poll_change_vote"', !empty($context['poll']['change_vote']) ? ' checked' : '', '>
292 301
 								</dd>';
293 302
 
294
-		if ($context['poll_options']['guest_vote_enabled'])
295
-			echo '
303
+		if ($context['poll_options']['guest_vote_enabled']) {
304
+					echo '
296 305
 								<dt>
297 306
 									<label for="poll_guest_vote">', $txt['poll_guest_vote'], ':</label>
298 307
 								</dt>
299 308
 								<dd>
300 309
 									<input type="checkbox" id="poll_guest_vote" name="poll_guest_vote"', !empty($context['poll_options']['guest_vote']) ? ' checked' : '', '>
301 310
 								</dd>';
311
+		}
302 312
 
303 313
 		echo '
304 314
 								<dt>
@@ -319,8 +329,8 @@  discard block
 block discarded – undo
319 329
 					', template_control_richedit($context['post_box_name'], 'smileyBox_message', 'bbcBox_message');
320 330
 
321 331
 	// If we're editing and displaying edit details, show a box where they can say why
322
-	if (isset($context['editing']) && $modSettings['show_modify'])
323
-		echo '
332
+	if (isset($context['editing']) && $modSettings['show_modify']) {
333
+			echo '
324 334
 					<dl>
325 335
 						<dt class="clear">
326 336
 							<span id="caption_edit_reason">', $txt['reason_for_edit'], ':</span>
@@ -329,20 +339,23 @@  discard block
 block discarded – undo
329 339
 							<input type="text" name="modify_reason"', isset($context['last_modified_reason']) ? ' value="' . $context['last_modified_reason'] . '"' : '', ' tabindex="', $context['tabindex']++, '" size="80" maxlength="80">
330 340
 						</dd>
331 341
 					</dl>';
342
+	}
332 343
 
333 344
 	// If this message has been edited in the past - display when it was.
334
-	if (isset($context['last_modified']))
335
-		echo '
345
+	if (isset($context['last_modified'])) {
346
+			echo '
336 347
 					<div class="padding smalltext">
337 348
 						', $context['last_modified_text'], '
338 349
 					</div>';
350
+	}
339 351
 
340 352
 	// If the admin has enabled the hiding of the additional options - show a link and image for it.
341
-	if (!empty($modSettings['additional_options_collapsable']))
342
-		echo '
353
+	if (!empty($modSettings['additional_options_collapsable'])) {
354
+			echo '
343 355
 					<div id="postAdditionalOptionsHeader">
344 356
 						<strong><a href="#" id="postMoreExpandLink"> ', $context['can_post_attachment'] ? $txt['post_additionalopt_attach'] : $txt['post_additionalopt'], '</a></strong>
345 357
 					</div>';
358
+	}
346 359
 
347 360
 	echo '
348 361
 					<div id="postAdditionalOptions">';
@@ -375,19 +388,21 @@  discard block
 block discarded – undo
375 388
 								', $txt['uncheck_unwatchd_attach'], ':
376 389
 							</dd>';
377 390
 
378
-		foreach ($context['current_attachments'] as $attachment)
379
-			echo '
391
+		foreach ($context['current_attachments'] as $attachment) {
392
+					echo '
380 393
 							<dd class="smalltext">
381 394
 								<label for="attachment_', $attachment['attachID'], '"><input type="checkbox" id="attachment_', $attachment['attachID'], '" name="attach_del[]" value="', $attachment['attachID'], '"', empty($attachment['unchecked']) ? ' checked' : '', '> ', $attachment['name'], (empty($attachment['approved']) ? ' (' . $txt['awaiting_approval'] . ')' : ''),
382 395
 								!empty($modSettings['attachmentPostLimit']) || !empty($modSettings['attachmentSizeLimit']) ? sprintf($txt['attach_kb'], comma_format(round(max($attachment['size'], 1024) / 1024), 0)) : '', '</label>
383 396
 							</dd>';
397
+		}
384 398
 
385 399
 		echo '
386 400
 						</dl>';
387 401
 
388
-		if (!empty($context['files_in_session_warning']))
389
-			echo '
402
+		if (!empty($context['files_in_session_warning'])) {
403
+					echo '
390 404
 						<div class="smalltext">', $context['files_in_session_warning'], '</div>';
405
+		}
391 406
 	}
392 407
 
393 408
 	// Is the user allowed to post any additional ones? If so give them the boxes to do it!
@@ -451,8 +466,8 @@  discard block
 block discarded – undo
451 466
 								', empty($modSettings['attachmentSizeLimit']) ? '' : ('<input type="hidden" name="MAX_FILE_SIZE" value="' . $modSettings['attachmentSizeLimit'] * 1024 . '">');
452 467
 
453 468
 		// Show more boxes if they aren't approaching that limit.
454
-		if ($context['num_allowed_attachments'] > 1)
455
-			echo '
469
+		if ($context['num_allowed_attachments'] > 1) {
470
+					echo '
456 471
 										<script>
457 472
 											var allowed_attachments = ', $context['num_allowed_attachments'], ';
458 473
 											var current_attachment = 1;
@@ -473,9 +488,10 @@  discard block
 block discarded – undo
473 488
 									</div><!-- .fallback -->
474 489
 								</div><!-- #attachUpload -->
475 490
 							</dd>';
476
-		else
477
-			echo '
491
+		} else {
492
+					echo '
478 493
 							</dd>';
494
+		}
479 495
 
480 496
 		// Add any template changes for an alternative upload system here.
481 497
 		call_integration_hook('integrate_upload_template');
@@ -484,21 +500,25 @@  discard block
 block discarded – undo
484 500
 							<dd class="smalltext">';
485 501
 
486 502
 		// Show some useful information such as allowed extensions, maximum size and amount of attachments allowed.
487
-		if (!empty($modSettings['attachmentCheckExtensions']))
488
-			echo '
503
+		if (!empty($modSettings['attachmentCheckExtensions'])) {
504
+					echo '
489 505
 								', $txt['allowed_types'], ': ', $context['allowed_extensions'], '<br>';
506
+		}
490 507
 
491
-		if (!empty($context['attachment_restrictions']))
492
-			echo '
508
+		if (!empty($context['attachment_restrictions'])) {
509
+					echo '
493 510
 								', $txt['attach_restrictions'], ' ', implode(', ', $context['attachment_restrictions']), '<br>';
511
+		}
494 512
 
495
-		if ($context['num_allowed_attachments'] == 0)
496
-			echo '
513
+		if ($context['num_allowed_attachments'] == 0) {
514
+					echo '
497 515
 								', $txt['attach_limit_nag'], '<br>';
516
+		}
498 517
 
499
-		if (!$context['can_post_attachment_unapproved'])
500
-			echo '
518
+		if (!$context['can_post_attachment_unapproved']) {
519
+					echo '
501 520
 								<span class="alert">', $txt['attachment_requires_approval'], '</span>', '<br>';
521
+		}
502 522
 
503 523
 		echo '
504 524
 							</dd>
@@ -522,10 +542,11 @@  discard block
 block discarded – undo
522 542
 							<dt><strong>', $txt['subject'], '</strong></dt>
523 543
 							<dd><strong>', $txt['draft_saved_on'], '</strong></dd>';
524 544
 
525
-		foreach ($context['drafts'] as $draft)
526
-			echo '
545
+		foreach ($context['drafts'] as $draft) {
546
+					echo '
527 547
 							<dt>', $draft['link'], '</dt>
528 548
 							<dd>', $draft['poster_time'], '</dd>';
549
+		}
529 550
 		echo '
530 551
 						</dl>
531 552
 					</div>';
@@ -550,9 +571,10 @@  discard block
 block discarded – undo
550 571
 						', template_control_richedit_buttons($context['post_box_name']);
551 572
 
552 573
 	// Option to delete an event if user is editing one.
553
-	if ($context['make_event'] && !$context['event']['new'])
554
-		echo '
574
+	if ($context['make_event'] && !$context['event']['new']) {
575
+			echo '
555 576
 						<input type="submit" name="deleteevent" value="', $txt['event_delete'], '" data-confirm="', $txt['event_delete_confirm'] ,'" class="button you_sure">';
577
+	}
556 578
 
557 579
 	echo '
558 580
 					</span>
@@ -561,9 +583,10 @@  discard block
 block discarded – undo
561 583
 			<br class="clear">';
562 584
 
563 585
 	// Assuming this isn't a new topic pass across the last message id.
564
-	if (isset($context['topic_last_message']))
565
-		echo '
586
+	if (isset($context['topic_last_message'])) {
587
+			echo '
566 588
 			<input type="hidden" name="last_msg" value="', $context['topic_last_message'], '">';
589
+	}
567 590
 
568 591
 	echo '
569 592
 			<input type="hidden" name="additional_options" id="additional_options" value="', $context['show_additional_options'] ? '1' : '0', '">
@@ -705,9 +728,10 @@  discard block
 block discarded – undo
705 728
 
706 729
 						newPostsHTML += \'<div class="windowbg\' + (++reply_counter % 2 == 0 ? \'2\' : \'\') + \'"><div id="msg\' + newPosts[i].getAttribute("id") + \'"><div class="floatleft"><h5>', $txt['posted_by'], ': \' + newPosts[i].getElementsByTagName("poster")[0].firstChild.nodeValue + \'</h5><span class="smalltext">&#171;&nbsp;<strong>', $txt['on'], ':</strong> \' + newPosts[i].getElementsByTagName("time")[0].firstChild.nodeValue + \'&nbsp;&#187;</span> <span class="new_posts" id="image_new_\' + newPosts[i].getAttribute("id") + \'">', $txt['new'], '</span></div>\';';
707 730
 
708
-	if ($context['can_quote'])
709
-		echo '
731
+	if ($context['can_quote']) {
732
+			echo '
710 733
 						newPostsHTML += \'<ul class="quickbuttons" id="msg_\' + newPosts[i].getAttribute("id") + \'_quote"><li><a href="#postmodify" onclick="return insertQuoteFast(\\\'\' + newPosts[i].getAttribute("id") + \'\\\');" class="quote_button"><span>', $txt['quote'], '</span><\' + \'/a></li></ul>\';';
734
+	}
711 735
 
712 736
 	echo '
713 737
 						newPostsHTML += \'<br class="clear">\';
@@ -750,8 +774,8 @@  discard block
 block discarded – undo
750 774
 			}';
751 775
 
752 776
 	// Code for showing and hiding additional options.
753
-	if (!empty($modSettings['additional_options_collapsable']))
754
-		echo '
777
+	if (!empty($modSettings['additional_options_collapsable'])) {
778
+			echo '
755 779
 			var oSwapAdditionalOptions = new smc_Toggle({
756 780
 				bToggleEnabled: true,
757 781
 				bCurrentlyCollapsed: ', $context['show_additional_options'] ? 'false' : 'true', ',
@@ -779,10 +803,11 @@  discard block
 block discarded – undo
779 803
 					}
780 804
 				]
781 805
 			});';
806
+	}
782 807
 
783 808
 	// Code for showing and hiding drafts
784
-	if (!empty($context['drafts']))
785
-		echo '
809
+	if (!empty($context['drafts'])) {
810
+			echo '
786 811
 			var oSwapDraftOptions = new smc_Toggle({
787 812
 				bToggleEnabled: true,
788 813
 				bCurrentlyCollapsed: true,
@@ -804,6 +829,7 @@  discard block
 block discarded – undo
804 829
 					}
805 830
 				]
806 831
 			});';
832
+	}
807 833
 
808 834
 	echo '
809 835
 			var oEditorID = "', $context['post_box_name'] ,'";
@@ -824,8 +850,9 @@  discard block
 block discarded – undo
824 850
 		foreach ($context['previous_posts'] as $post)
825 851
 		{
826 852
 			$ignoring = false;
827
-			if (!empty($post['is_ignored']))
828
-				$ignored_posts[] = $ignoring = $post['id'];
853
+			if (!empty($post['is_ignored'])) {
854
+							$ignored_posts[] = $ignoring = $post['id'];
855
+			}
829 856
 
830 857
 			echo '
831 858
 			<div class="windowbg">
@@ -1007,10 +1034,10 @@  discard block
 block discarded – undo
1007 1034
 		<div id="temporary_posting_area" style="display: none;"></div>
1008 1035
 		<script>';
1009 1036
 
1010
-	if ($context['close_window'])
1011
-		echo '
1037
+	if ($context['close_window']) {
1038
+			echo '
1012 1039
 			window.close();';
1013
-	else
1040
+	} else
1014 1041
 	{
1015 1042
 		// Lucky for us, Internet Explorer has an "innerText" feature which basically converts entities <--> text. Use it if possible ;)
1016 1043
 		echo '
@@ -1064,11 +1091,12 @@  discard block
 block discarded – undo
1064 1091
 				</p>
1065 1092
 				<ul>';
1066 1093
 
1067
-	foreach ($context['groups'] as $group)
1068
-		echo '
1094
+	foreach ($context['groups'] as $group) {
1095
+			echo '
1069 1096
 					<li>
1070 1097
 						<label for="who_', $group['id'], '"><input type="checkbox" name="who[', $group['id'], ']" id="who_', $group['id'], '" value="', $group['id'], '" checked> ', $group['name'], '</label> <em>(', $group['member_count'], ')</em>
1071 1098
 					</li>';
1099
+	}
1072 1100
 
1073 1101
 	echo '
1074 1102
 					<li>
Please login to merge, or discard this patch.