Completed
Push — release-2.1 ( 1ee551...a09951 )
by Michael
29s
created
Sources/Load.php 1 patch
Braces   +792 added lines, -598 removed lines patch added patch discarded remove patch
@@ -13,8 +13,9 @@  discard block
 block discarded – undo
13 13
  * @version 2.1 Beta 4
14 14
  */
15 15
 
16
-if (!defined('SMF'))
16
+if (!defined('SMF')) {
17 17
 	die('No direct access...');
18
+}
18 19
 
19 20
 /**
20 21
  * Load the $modSettings array.
@@ -25,13 +26,14 @@  discard block
 block discarded – undo
25 26
 	global $cache_enable, $sourcedir, $context;
26 27
 
27 28
 	// Most database systems have not set UTF-8 as their default input charset.
28
-	if (!empty($db_character_set))
29
-		$smcFunc['db_query']('', '
29
+	if (!empty($db_character_set)) {
30
+			$smcFunc['db_query']('', '
30 31
 			SET NAMES {string:db_character_set}',
31 32
 			array(
32 33
 				'db_character_set' => $db_character_set,
33 34
 			)
34 35
 		);
36
+	}
35 37
 
36 38
 	// We need some caching support, maybe.
37 39
 	loadCacheAccelerator();
@@ -46,28 +48,36 @@  discard block
 block discarded – undo
46 48
 			)
47 49
 		);
48 50
 		$modSettings = array();
49
-		if (!$request)
50
-			display_db_error();
51
-		while ($row = $smcFunc['db_fetch_row']($request))
52
-			$modSettings[$row[0]] = $row[1];
51
+		if (!$request) {
52
+					display_db_error();
53
+		}
54
+		while ($row = $smcFunc['db_fetch_row']($request)) {
55
+					$modSettings[$row[0]] = $row[1];
56
+		}
53 57
 		$smcFunc['db_free_result']($request);
54 58
 
55 59
 		// Do a few things to protect against missing settings or settings with invalid values...
56
-		if (empty($modSettings['defaultMaxTopics']) || $modSettings['defaultMaxTopics'] <= 0 || $modSettings['defaultMaxTopics'] > 999)
57
-			$modSettings['defaultMaxTopics'] = 20;
58
-		if (empty($modSettings['defaultMaxMessages']) || $modSettings['defaultMaxMessages'] <= 0 || $modSettings['defaultMaxMessages'] > 999)
59
-			$modSettings['defaultMaxMessages'] = 15;
60
-		if (empty($modSettings['defaultMaxMembers']) || $modSettings['defaultMaxMembers'] <= 0 || $modSettings['defaultMaxMembers'] > 999)
61
-			$modSettings['defaultMaxMembers'] = 30;
62
-		if (empty($modSettings['defaultMaxListItems']) || $modSettings['defaultMaxListItems'] <= 0 || $modSettings['defaultMaxListItems'] > 999)
63
-			$modSettings['defaultMaxListItems'] = 15;
60
+		if (empty($modSettings['defaultMaxTopics']) || $modSettings['defaultMaxTopics'] <= 0 || $modSettings['defaultMaxTopics'] > 999) {
61
+					$modSettings['defaultMaxTopics'] = 20;
62
+		}
63
+		if (empty($modSettings['defaultMaxMessages']) || $modSettings['defaultMaxMessages'] <= 0 || $modSettings['defaultMaxMessages'] > 999) {
64
+					$modSettings['defaultMaxMessages'] = 15;
65
+		}
66
+		if (empty($modSettings['defaultMaxMembers']) || $modSettings['defaultMaxMembers'] <= 0 || $modSettings['defaultMaxMembers'] > 999) {
67
+					$modSettings['defaultMaxMembers'] = 30;
68
+		}
69
+		if (empty($modSettings['defaultMaxListItems']) || $modSettings['defaultMaxListItems'] <= 0 || $modSettings['defaultMaxListItems'] > 999) {
70
+					$modSettings['defaultMaxListItems'] = 15;
71
+		}
64 72
 
65 73
 		// We excpiclity do not use $smcFunc['json_decode'] here yet, as $smcFunc is not fully loaded.
66
-		if (!is_array($modSettings['attachmentUploadDir']))
67
-			$modSettings['attachmentUploadDir'] = smf_json_decode($modSettings['attachmentUploadDir'], true);
74
+		if (!is_array($modSettings['attachmentUploadDir'])) {
75
+					$modSettings['attachmentUploadDir'] = smf_json_decode($modSettings['attachmentUploadDir'], true);
76
+		}
68 77
 
69
-		if (!empty($cache_enable))
70
-			cache_put_data('modSettings', $modSettings, 90);
78
+		if (!empty($cache_enable)) {
79
+					cache_put_data('modSettings', $modSettings, 90);
80
+		}
71 81
 	}
72 82
 
73 83
 	$modSettings['cache_enable'] = $cache_enable;
@@ -87,8 +97,9 @@  discard block
 block discarded – undo
87 97
 		};
88 98
 	$fix_utf8mb4 = function($string) use ($utf8, $smcFunc)
89 99
 	{
90
-		if (!$utf8 || $smcFunc['db_mb4'])
91
-			return $string;
100
+		if (!$utf8 || $smcFunc['db_mb4']) {
101
+					return $string;
102
+		}
92 103
 
93 104
 		$i = 0;
94 105
 		$len = strlen($string);
@@ -100,18 +111,15 @@  discard block
 block discarded – undo
100 111
 			{
101 112
 				$new_string .= $string[$i];
102 113
 				$i++;
103
-			}
104
-			elseif ($ord < 224)
114
+			} elseif ($ord < 224)
105 115
 			{
106 116
 				$new_string .= $string[$i] . $string[$i + 1];
107 117
 				$i += 2;
108
-			}
109
-			elseif ($ord < 240)
118
+			} elseif ($ord < 240)
110 119
 			{
111 120
 				$new_string .= $string[$i] . $string[$i + 1] . $string[$i + 2];
112 121
 				$i += 3;
113
-			}
114
-			elseif ($ord < 248)
122
+			} elseif ($ord < 248)
115 123
 			{
116 124
 				// Magic happens.
117 125
 				$val = (ord($string[$i]) & 0x07) << 18;
@@ -155,8 +163,7 @@  discard block
 block discarded – undo
155 163
 			{
156 164
 				$result = array_search($needle, array_slice($haystack_arr, $offset));
157 165
 				return is_int($result) ? $result + $offset : false;
158
-			}
159
-			else
166
+			} else
160 167
 			{
161 168
 				$needle_arr = preg_split('~(&#' . (empty($modSettings['disableEntityCheck']) ? '\d{1,7}' : '021') . ';|&quot;|&amp;|&lt;|&gt;|&nbsp;|.)~' . ($utf8 ? 'u' : '') . '', $ent_check($needle), -1, PREG_SPLIT_DELIM_CAPTURE | PREG_SPLIT_NO_EMPTY);
162 169
 				$needle_size = count($needle_arr);
@@ -165,8 +172,9 @@  discard block
 block discarded – undo
165 172
 				while ((int) $result === $result)
166 173
 				{
167 174
 					$offset += $result;
168
-					if (array_slice($haystack_arr, $offset, $needle_size) === $needle_arr)
169
-						return $offset;
175
+					if (array_slice($haystack_arr, $offset, $needle_size) === $needle_arr) {
176
+											return $offset;
177
+					}
170 178
 					$result = array_search($needle_arr[0], array_slice($haystack_arr, ++$offset));
171 179
 				}
172 180
 				return false;
@@ -204,8 +212,9 @@  discard block
 block discarded – undo
204 212
 			$string = $ent_check($string);
205 213
 			preg_match('~^(' . $ent_list . '|.){' . $smcFunc['strlen'](substr($string, 0, $length)) . '}~' . ($utf8 ? 'u' : ''), $string, $matches);
206 214
 			$string = $matches[0];
207
-			while (strlen($string) > $length)
208
-				$string = preg_replace('~(?:' . $ent_list . '|.)$~' . ($utf8 ? 'u' : ''), '', $string);
215
+			while (strlen($string) > $length) {
216
+							$string = preg_replace('~(?:' . $ent_list . '|.)$~' . ($utf8 ? 'u' : ''), '', $string);
217
+			}
209 218
 			return $string;
210 219
 		},
211 220
 		'ucfirst' => $utf8 ? function($string) use (&$smcFunc)
@@ -215,8 +224,9 @@  discard block
 block discarded – undo
215 224
 		'ucwords' => $utf8 ? function($string) use (&$smcFunc)
216 225
 		{
217 226
 			$words = preg_split('~([\s\r\n\t]+)~', $string, -1, PREG_SPLIT_DELIM_CAPTURE);
218
-			for ($i = 0, $n = count($words); $i < $n; $i += 2)
219
-				$words[$i] = $smcFunc['ucfirst']($words[$i]);
227
+			for ($i = 0, $n = count($words); $i < $n; $i += 2) {
228
+							$words[$i] = $smcFunc['ucfirst']($words[$i]);
229
+			}
220 230
 			return implode('', $words);
221 231
 		} : 'ucwords',
222 232
 		'json_decode' => 'smf_json_decode',
@@ -224,16 +234,17 @@  discard block
 block discarded – undo
224 234
 	);
225 235
 
226 236
 	// Setting the timezone is a requirement for some functions.
227
-	if (isset($modSettings['default_timezone']) && in_array($modSettings['default_timezone'], timezone_identifiers_list()))
228
-		date_default_timezone_set($modSettings['default_timezone']);
229
-	else
237
+	if (isset($modSettings['default_timezone']) && in_array($modSettings['default_timezone'], timezone_identifiers_list())) {
238
+			date_default_timezone_set($modSettings['default_timezone']);
239
+	} else
230 240
 	{
231 241
 		// Get PHP's default timezone, if set
232 242
 		$ini_tz = ini_get('date.timezone');
233
-		if (!empty($ini_tz))
234
-			$modSettings['default_timezone'] = $ini_tz;
235
-		else
236
-			$modSettings['default_timezone'] = '';
243
+		if (!empty($ini_tz)) {
244
+					$modSettings['default_timezone'] = $ini_tz;
245
+		} else {
246
+					$modSettings['default_timezone'] = '';
247
+		}
237 248
 
238 249
 		// If date.timezone is unset, invalid, or just plain weird, make a best guess
239 250
 		if (!in_array($modSettings['default_timezone'], timezone_identifiers_list()))
@@ -251,22 +262,26 @@  discard block
 block discarded – undo
251 262
 		if (($modSettings['load_average'] = cache_get_data('loadavg', 90)) == null)
252 263
 		{
253 264
 			$modSettings['load_average'] = @file_get_contents('/proc/loadavg');
254
-			if (!empty($modSettings['load_average']) && preg_match('~^([^ ]+?) ([^ ]+?) ([^ ]+)~', $modSettings['load_average'], $matches) != 0)
255
-				$modSettings['load_average'] = (float) $matches[1];
256
-			elseif (($modSettings['load_average'] = @`uptime`) != null && preg_match('~load average[s]?: (\d+\.\d+), (\d+\.\d+), (\d+\.\d+)~i', $modSettings['load_average'], $matches) != 0)
257
-				$modSettings['load_average'] = (float) $matches[1];
258
-			else
259
-				unset($modSettings['load_average']);
265
+			if (!empty($modSettings['load_average']) && preg_match('~^([^ ]+?) ([^ ]+?) ([^ ]+)~', $modSettings['load_average'], $matches) != 0) {
266
+							$modSettings['load_average'] = (float) $matches[1];
267
+			} elseif (($modSettings['load_average'] = @`uptime`) != null && preg_match('~load average[s]?: (\d+\.\d+), (\d+\.\d+), (\d+\.\d+)~i', $modSettings['load_average'], $matches) != 0) {
268
+							$modSettings['load_average'] = (float) $matches[1];
269
+			} else {
270
+							unset($modSettings['load_average']);
271
+			}
260 272
 
261
-			if (!empty($modSettings['load_average']) || $modSettings['load_average'] === 0.0)
262
-				cache_put_data('loadavg', $modSettings['load_average'], 90);
273
+			if (!empty($modSettings['load_average']) || $modSettings['load_average'] === 0.0) {
274
+							cache_put_data('loadavg', $modSettings['load_average'], 90);
275
+			}
263 276
 		}
264 277
 
265
-		if (!empty($modSettings['load_average']) || $modSettings['load_average'] === 0.0)
266
-			call_integration_hook('integrate_load_average', array($modSettings['load_average']));
278
+		if (!empty($modSettings['load_average']) || $modSettings['load_average'] === 0.0) {
279
+					call_integration_hook('integrate_load_average', array($modSettings['load_average']));
280
+		}
267 281
 
268
-		if (!empty($modSettings['loadavg_forum']) && !empty($modSettings['load_average']) && $modSettings['load_average'] >= $modSettings['loadavg_forum'])
269
-			display_loadavg_error();
282
+		if (!empty($modSettings['loadavg_forum']) && !empty($modSettings['load_average']) && $modSettings['load_average'] >= $modSettings['loadavg_forum']) {
283
+					display_loadavg_error();
284
+		}
270 285
 	}
271 286
 
272 287
 	// Is post moderation alive and well? Everywhere else assumes this has been defined, so let's make sure it is.
@@ -287,8 +302,9 @@  discard block
 block discarded – undo
287 302
 	if (defined('SMF_INTEGRATION_SETTINGS'))
288 303
 	{
289 304
 		$integration_settings = $smcFUnc['json_decode'](SMF_INTEGRATION_SETTINGS, true);
290
-		foreach ($integration_settings as $hook => $function)
291
-			add_integration_function($hook, $function, '', false);
305
+		foreach ($integration_settings as $hook => $function) {
306
+					add_integration_function($hook, $function, '', false);
307
+		}
292 308
 	}
293 309
 
294 310
 	// Any files to pre include?
@@ -298,8 +314,9 @@  discard block
 block discarded – undo
298 314
 		foreach ($pre_includes as $include)
299 315
 		{
300 316
 			$include = strtr(trim($include), array('$boarddir' => $boarddir, '$sourcedir' => $sourcedir));
301
-			if (file_exists($include))
302
-				require_once($include);
317
+			if (file_exists($include)) {
318
+							require_once($include);
319
+			}
303 320
 		}
304 321
 	}
305 322
 
@@ -403,27 +420,28 @@  discard block
 block discarded – undo
403 420
 				break;
404 421
 			}
405 422
 		}
423
+	} else {
424
+			$id_member = 0;
406 425
 	}
407
-	else
408
-		$id_member = 0;
409 426
 
410 427
 	if (empty($id_member) && isset($_COOKIE[$cookiename]))
411 428
 	{
412 429
 		$cookie_data = $smcFunc['json_decode']($_COOKIE[$cookiename], true, false);
413 430
 
414
-		if (empty($cookie_data))
415
-			$cookie_data = safe_unserialize($_COOKIE[$cookiename]);
431
+		if (empty($cookie_data)) {
432
+					$cookie_data = safe_unserialize($_COOKIE[$cookiename]);
433
+		}
416 434
 
417 435
 		list ($id_member, $password) = $cookie_data;
418 436
 		$id_member = !empty($id_member) && strlen($password) > 0 ? (int) $id_member : 0;
419
-	}
420
-	elseif (empty($id_member) && isset($_SESSION['login_' . $cookiename]) && ($_SESSION['USER_AGENT'] == $_SERVER['HTTP_USER_AGENT'] || !empty($modSettings['disableCheckUA'])))
437
+	} elseif (empty($id_member) && isset($_SESSION['login_' . $cookiename]) && ($_SESSION['USER_AGENT'] == $_SERVER['HTTP_USER_AGENT'] || !empty($modSettings['disableCheckUA'])))
421 438
 	{
422 439
 		// @todo Perhaps we can do some more checking on this, such as on the first octet of the IP?
423 440
 		$cookie_data = $smcFunc['json_decode']($_SESSION['login_' . $cookiename]);
424 441
 
425
-		if (empty($cookie_data))
426
-			$cookie_data = safe_unserialize($_SESSION['login_' . $cookiename]);
442
+		if (empty($cookie_data)) {
443
+					$cookie_data = safe_unserialize($_SESSION['login_' . $cookiename]);
444
+		}
427 445
 
428 446
 		list ($id_member, $password, $login_span) = $cookie_data;
429 447
 		$id_member = !empty($id_member) && strlen($password) == 128 && $login_span > time() ? (int) $id_member : 0;
@@ -448,30 +466,34 @@  discard block
 block discarded – undo
448 466
 			$user_settings = $smcFunc['db_fetch_assoc']($request);
449 467
 			$smcFunc['db_free_result']($request);
450 468
 
451
-			if (!empty($modSettings['force_ssl']) && $image_proxy_enabled && stripos($user_settings['avatar'], 'http://') !== false)
452
-				$user_settings['avatar'] = strtr($boardurl, array('http://' => 'https://')) . '/proxy.php?request=' . urlencode($user_settings['avatar']) . '&hash=' . md5($user_settings['avatar'] . $image_proxy_secret);
469
+			if (!empty($modSettings['force_ssl']) && $image_proxy_enabled && stripos($user_settings['avatar'], 'http://') !== false) {
470
+							$user_settings['avatar'] = strtr($boardurl, array('http://' => 'https://')) . '/proxy.php?request=' . urlencode($user_settings['avatar']) . '&hash=' . md5($user_settings['avatar'] . $image_proxy_secret);
471
+			}
453 472
 
454
-			if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 2)
455
-				cache_put_data('user_settings-' . $id_member, $user_settings, 60);
473
+			if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 2) {
474
+							cache_put_data('user_settings-' . $id_member, $user_settings, 60);
475
+			}
456 476
 		}
457 477
 
458 478
 		// Did we find 'im?  If not, junk it.
459 479
 		if (!empty($user_settings))
460 480
 		{
461 481
 			// As much as the password should be right, we can assume the integration set things up.
462
-			if (!empty($already_verified) && $already_verified === true)
463
-				$check = true;
482
+			if (!empty($already_verified) && $already_verified === true) {
483
+							$check = true;
484
+			}
464 485
 			// SHA-512 hash should be 128 characters long.
465
-			elseif (strlen($password) == 128)
466
-				$check = hash_salt($user_settings['passwd'], $user_settings['password_salt']) == $password;
467
-			else
468
-				$check = false;
486
+			elseif (strlen($password) == 128) {
487
+							$check = hash_salt($user_settings['passwd'], $user_settings['password_salt']) == $password;
488
+			} else {
489
+							$check = false;
490
+			}
469 491
 
470 492
 			// Wrong password or not activated - either way, you're going nowhere.
471 493
 			$id_member = $check && ($user_settings['is_activated'] == 1 || $user_settings['is_activated'] == 11) ? (int) $user_settings['id_member'] : 0;
494
+		} else {
495
+					$id_member = 0;
472 496
 		}
473
-		else
474
-			$id_member = 0;
475 497
 
476 498
 		// If we no longer have the member maybe they're being all hackey, stop brute force!
477 499
 		if (!$id_member)
@@ -495,8 +517,9 @@  discard block
 block discarded – undo
495 517
 
496 518
 					list ($tfamember, $tfasecret) = $tfa_data;
497 519
 
498
-					if (!isset($tfamember, $tfasecret) || (int) $tfamember != $id_member)
499
-						$tfasecret = null;
520
+					if (!isset($tfamember, $tfasecret) || (int) $tfamember != $id_member) {
521
+											$tfasecret = null;
522
+					}
500 523
 				}
501 524
 
502 525
 				if (empty($tfasecret) || hash_salt($user_settings['tfa_backup'], $user_settings['password_salt']) != $tfasecret)
@@ -516,10 +539,12 @@  discard block
 block discarded – undo
516 539
 		// Are we forcing 2FA? Need to check if the user groups actually require 2FA
517 540
 		elseif (!empty($modSettings['tfa_mode']) && $modSettings['tfa_mode'] >= 2 && $id_member && empty($user_settings['tfa_secret']))
518 541
 		{
519
-			if ($modSettings['tfa_mode'] == 2) //only do this if we are just forcing SOME membergroups
542
+			if ($modSettings['tfa_mode'] == 2) {
543
+				//only do this if we are just forcing SOME membergroups
520 544
 			{
521 545
 				//Build an array of ALL user membergroups.
522 546
 				$full_groups = array($user_settings['id_group']);
547
+			}
523 548
 				if (!empty($user_settings['additional_groups']))
524 549
 				{
525 550
 					$full_groups = array_merge($full_groups, explode(',', $user_settings['additional_groups']));
@@ -539,15 +564,17 @@  discard block
 block discarded – undo
539 564
 				);
540 565
 				$row = $smcFunc['db_fetch_assoc']($request);
541 566
 				$smcFunc['db_free_result']($request);
567
+			} else {
568
+							$row['total'] = 1;
542 569
 			}
543
-			else
544
-				$row['total'] = 1; //simplifies logics in the next "if"
570
+			//simplifies logics in the next "if"
545 571
 
546 572
 			$area = !empty($_REQUEST['area']) ? $_REQUEST['area'] : '';
547 573
 			$action = !empty($_REQUEST['action']) ? $_REQUEST['action'] : '';
548 574
 
549
-			if ($row['total'] > 0 && !in_array($action, array('profile', 'logout')) || ($action == 'profile' && $area != 'tfasetup'))
550
-				redirectexit('action=profile;area=tfasetup;forced');
575
+			if ($row['total'] > 0 && !in_array($action, array('profile', 'logout')) || ($action == 'profile' && $area != 'tfasetup')) {
576
+							redirectexit('action=profile;area=tfasetup;forced');
577
+			}
551 578
 		}
552 579
 	}
553 580
 
@@ -584,33 +611,37 @@  discard block
 block discarded – undo
584 611
 				updateMemberData($id_member, array('id_msg_last_visit' => (int) $modSettings['maxMsgID'], 'last_login' => time(), 'member_ip' => $_SERVER['REMOTE_ADDR'], 'member_ip2' => $_SERVER['BAN_CHECK_IP']));
585 612
 				$user_settings['last_login'] = time();
586 613
 
587
-				if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 2)
588
-					cache_put_data('user_settings-' . $id_member, $user_settings, 60);
614
+				if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 2) {
615
+									cache_put_data('user_settings-' . $id_member, $user_settings, 60);
616
+				}
589 617
 
590
-				if (!empty($modSettings['cache_enable']))
591
-					cache_put_data('user_last_visit-' . $id_member, $_SESSION['id_msg_last_visit'], 5 * 3600);
618
+				if (!empty($modSettings['cache_enable'])) {
619
+									cache_put_data('user_last_visit-' . $id_member, $_SESSION['id_msg_last_visit'], 5 * 3600);
620
+				}
592 621
 			}
622
+		} elseif (empty($_SESSION['id_msg_last_visit'])) {
623
+					$_SESSION['id_msg_last_visit'] = $user_settings['id_msg_last_visit'];
593 624
 		}
594
-		elseif (empty($_SESSION['id_msg_last_visit']))
595
-			$_SESSION['id_msg_last_visit'] = $user_settings['id_msg_last_visit'];
596 625
 
597 626
 		$username = $user_settings['member_name'];
598 627
 
599
-		if (empty($user_settings['additional_groups']))
600
-			$user_info = array(
628
+		if (empty($user_settings['additional_groups'])) {
629
+					$user_info = array(
601 630
 				'groups' => array($user_settings['id_group'], $user_settings['id_post_group'])
602 631
 			);
603
-		else
604
-			$user_info = array(
632
+		} else {
633
+					$user_info = array(
605 634
 				'groups' => array_merge(
606 635
 					array($user_settings['id_group'], $user_settings['id_post_group']),
607 636
 					explode(',', $user_settings['additional_groups'])
608 637
 				)
609 638
 			);
639
+		}
610 640
 
611 641
 		// Because history has proven that it is possible for groups to go bad - clean up in case.
612
-		foreach ($user_info['groups'] as $k => $v)
613
-			$user_info['groups'][$k] = (int) $v;
642
+		foreach ($user_info['groups'] as $k => $v) {
643
+					$user_info['groups'][$k] = (int) $v;
644
+		}
614 645
 
615 646
 		// This is a logged in user, so definitely not a spider.
616 647
 		$user_info['possibly_robot'] = false;
@@ -624,8 +655,7 @@  discard block
 block discarded – undo
624 655
 			$time_system = new DateTime('now', $tz_system);
625 656
 			$time_user = new DateTime('now', $tz_user);
626 657
 			$user_info['time_offset'] = ($tz_user->getOffset($time_user) - $tz_system->getOffset($time_system)) / 3600;
627
-		}
628
-		else
658
+		} else
629 659
 		{
630 660
 			// !!! Compatibility.
631 661
 			$user_info['time_offset'] = empty($user_settings['time_offset']) ? 0 : $user_settings['time_offset'];
@@ -639,8 +669,9 @@  discard block
 block discarded – undo
639 669
 		$user_info = array('groups' => array(-1));
640 670
 		$user_settings = array();
641 671
 
642
-		if (isset($_COOKIE[$cookiename]) && empty($context['tfa_member']))
643
-			$_COOKIE[$cookiename] = '';
672
+		if (isset($_COOKIE[$cookiename]) && empty($context['tfa_member'])) {
673
+					$_COOKIE[$cookiename] = '';
674
+		}
644 675
 
645 676
 		// Expire the 2FA cookie
646 677
 		if (isset($_COOKIE[$cookiename . '_tfa']) && empty($context['tfa_member']))
@@ -657,19 +688,20 @@  discard block
 block discarded – undo
657 688
 		}
658 689
 
659 690
 		// Create a login token if it doesn't exist yet.
660
-		if (!isset($_SESSION['token']['post-login']))
661
-			createToken('login');
662
-		else
663
-			list ($context['login_token_var'],,, $context['login_token']) = $_SESSION['token']['post-login'];
691
+		if (!isset($_SESSION['token']['post-login'])) {
692
+					createToken('login');
693
+		} else {
694
+					list ($context['login_token_var'],,, $context['login_token']) = $_SESSION['token']['post-login'];
695
+		}
664 696
 
665 697
 		// Do we perhaps think this is a search robot? Check every five minutes just in case...
666 698
 		if ((!empty($modSettings['spider_mode']) || !empty($modSettings['spider_group'])) && (!isset($_SESSION['robot_check']) || $_SESSION['robot_check'] < time() - 300))
667 699
 		{
668 700
 			require_once($sourcedir . '/ManageSearchEngines.php');
669 701
 			$user_info['possibly_robot'] = SpiderCheck();
702
+		} elseif (!empty($modSettings['spider_mode'])) {
703
+					$user_info['possibly_robot'] = isset($_SESSION['id_robot']) ? $_SESSION['id_robot'] : 0;
670 704
 		}
671
-		elseif (!empty($modSettings['spider_mode']))
672
-			$user_info['possibly_robot'] = isset($_SESSION['id_robot']) ? $_SESSION['id_robot'] : 0;
673 705
 		// If we haven't turned on proper spider hunts then have a guess!
674 706
 		else
675 707
 		{
@@ -717,8 +749,9 @@  discard block
 block discarded – undo
717 749
 	$user_info['groups'] = array_unique($user_info['groups']);
718 750
 
719 751
 	// Make sure that the last item in the ignore boards array is valid. If the list was too long it could have an ending comma that could cause problems.
720
-	if (!empty($user_info['ignoreboards']) && empty($user_info['ignoreboards'][$tmp = count($user_info['ignoreboards']) - 1]))
721
-		unset($user_info['ignoreboards'][$tmp]);
752
+	if (!empty($user_info['ignoreboards']) && empty($user_info['ignoreboards'][$tmp = count($user_info['ignoreboards']) - 1])) {
753
+			unset($user_info['ignoreboards'][$tmp]);
754
+	}
722 755
 
723 756
 	// Allow the user to change their language.
724 757
 	if (!empty($modSettings['userLanguage']))
@@ -731,31 +764,36 @@  discard block
 block discarded – undo
731 764
 			$user_info['language'] = strtr($_GET['language'], './\\:', '____');
732 765
 
733 766
 			// Make it permanent for members.
734
-			if (!empty($user_info['id']))
735
-				updateMemberData($user_info['id'], array('lngfile' => $user_info['language']));
736
-			else
737
-				$_SESSION['language'] = $user_info['language'];
767
+			if (!empty($user_info['id'])) {
768
+							updateMemberData($user_info['id'], array('lngfile' => $user_info['language']));
769
+			} else {
770
+							$_SESSION['language'] = $user_info['language'];
771
+			}
772
+		} elseif (!empty($_SESSION['language']) && isset($languages[strtr($_SESSION['language'], './\\:', '____')])) {
773
+					$user_info['language'] = strtr($_SESSION['language'], './\\:', '____');
738 774
 		}
739
-		elseif (!empty($_SESSION['language']) && isset($languages[strtr($_SESSION['language'], './\\:', '____')]))
740
-			$user_info['language'] = strtr($_SESSION['language'], './\\:', '____');
741 775
 	}
742 776
 
743 777
 	// Just build this here, it makes it easier to change/use - administrators can see all boards.
744
-	if ($user_info['is_admin'])
745
-		$user_info['query_see_board'] = '1=1';
778
+	if ($user_info['is_admin']) {
779
+			$user_info['query_see_board'] = '1=1';
780
+	}
746 781
 	// Otherwise just the groups in $user_info['groups'].
747
-	else
748
-		$user_info['query_see_board'] = '((FIND_IN_SET(' . implode(', b.member_groups) != 0 OR FIND_IN_SET(', $user_info['groups']) . ', b.member_groups) != 0)' . (!empty($modSettings['deny_boards_access']) ? ' AND (FIND_IN_SET(' . implode(', b.deny_member_groups) = 0 AND FIND_IN_SET(', $user_info['groups']) . ', b.deny_member_groups) = 0)' : '') . (isset($user_info['mod_cache']) ? ' OR ' . $user_info['mod_cache']['mq'] : '') . ')';
782
+	else {
783
+			$user_info['query_see_board'] = '((FIND_IN_SET(' . implode(', b.member_groups) != 0 OR FIND_IN_SET(', $user_info['groups']) . ', b.member_groups) != 0)' . (!empty($modSettings['deny_boards_access']) ? ' AND (FIND_IN_SET(' . implode(', b.deny_member_groups) = 0 AND FIND_IN_SET(', $user_info['groups']) . ', b.deny_member_groups) = 0)' : '') . (isset($user_info['mod_cache']) ? ' OR ' . $user_info['mod_cache']['mq'] : '') . ')';
784
+	}
749 785
 
750 786
 	// Build the list of boards they WANT to see.
751 787
 	// This will take the place of query_see_boards in certain spots, so it better include the boards they can see also
752 788
 
753 789
 	// If they aren't ignoring any boards then they want to see all the boards they can see
754
-	if (empty($user_info['ignoreboards']))
755
-		$user_info['query_wanna_see_board'] = $user_info['query_see_board'];
790
+	if (empty($user_info['ignoreboards'])) {
791
+			$user_info['query_wanna_see_board'] = $user_info['query_see_board'];
792
+	}
756 793
 	// Ok I guess they don't want to see all the boards
757
-	else
758
-		$user_info['query_wanna_see_board'] = '(' . $user_info['query_see_board'] . ' AND b.id_board NOT IN (' . implode(',', $user_info['ignoreboards']) . '))';
794
+	else {
795
+			$user_info['query_wanna_see_board'] = '(' . $user_info['query_see_board'] . ' AND b.id_board NOT IN (' . implode(',', $user_info['ignoreboards']) . '))';
796
+	}
759 797
 
760 798
 	call_integration_hook('integrate_user_info');
761 799
 }
@@ -813,9 +851,9 @@  discard block
 block discarded – undo
813 851
 		}
814 852
 
815 853
 		// Remember redirection is the key to avoiding fallout from your bosses.
816
-		if (!empty($topic))
817
-			redirectexit('topic=' . $topic . '.msg' . $_REQUEST['msg'] . '#msg' . $_REQUEST['msg']);
818
-		else
854
+		if (!empty($topic)) {
855
+					redirectexit('topic=' . $topic . '.msg' . $_REQUEST['msg'] . '#msg' . $_REQUEST['msg']);
856
+		} else
819 857
 		{
820 858
 			loadPermissions();
821 859
 			loadTheme();
@@ -833,10 +871,11 @@  discard block
 block discarded – undo
833 871
 	if (!empty($modSettings['cache_enable']) && (empty($topic) || $modSettings['cache_enable'] >= 3))
834 872
 	{
835 873
 		// @todo SLOW?
836
-		if (!empty($topic))
837
-			$temp = cache_get_data('topic_board-' . $topic, 120);
838
-		else
839
-			$temp = cache_get_data('board-' . $board, 120);
874
+		if (!empty($topic)) {
875
+					$temp = cache_get_data('topic_board-' . $topic, 120);
876
+		} else {
877
+					$temp = cache_get_data('board-' . $board, 120);
878
+		}
840 879
 
841 880
 		if (!empty($temp))
842 881
 		{
@@ -874,8 +913,9 @@  discard block
 block discarded – undo
874 913
 			$row = $smcFunc['db_fetch_assoc']($request);
875 914
 
876 915
 			// Set the current board.
877
-			if (!empty($row['id_board']))
878
-				$board = $row['id_board'];
916
+			if (!empty($row['id_board'])) {
917
+							$board = $row['id_board'];
918
+			}
879 919
 
880 920
 			// Basic operating information. (globals... :/)
881 921
 			$board_info = array(
@@ -911,21 +951,23 @@  discard block
 block discarded – undo
911 951
 
912 952
 			do
913 953
 			{
914
-				if (!empty($row['id_moderator']))
915
-					$board_info['moderators'][$row['id_moderator']] = array(
954
+				if (!empty($row['id_moderator'])) {
955
+									$board_info['moderators'][$row['id_moderator']] = array(
916 956
 						'id' => $row['id_moderator'],
917 957
 						'name' => $row['real_name'],
918 958
 						'href' => $scripturl . '?action=profile;u=' . $row['id_moderator'],
919 959
 						'link' => '<a href="' . $scripturl . '?action=profile;u=' . $row['id_moderator'] . '">' . $row['real_name'] . '</a>'
920 960
 					);
961
+				}
921 962
 
922
-				if (!empty($row['id_moderator_group']))
923
-					$board_info['moderator_groups'][$row['id_moderator_group']] = array(
963
+				if (!empty($row['id_moderator_group'])) {
964
+									$board_info['moderator_groups'][$row['id_moderator_group']] = array(
924 965
 						'id' => $row['id_moderator_group'],
925 966
 						'name' => $row['group_name'],
926 967
 						'href' => $scripturl . '?action=groups;sa=members;group=' . $row['id_moderator_group'],
927 968
 						'link' => '<a href="' . $scripturl . '?action=groups;sa=members;group=' . $row['id_moderator_group'] . '">' . $row['group_name'] . '</a>'
928 969
 					);
970
+				}
929 971
 			}
930 972
 			while ($row = $smcFunc['db_fetch_assoc']($request));
931 973
 
@@ -957,12 +999,12 @@  discard block
 block discarded – undo
957 999
 			if (!empty($modSettings['cache_enable']) && (empty($topic) || $modSettings['cache_enable'] >= 3))
958 1000
 			{
959 1001
 				// @todo SLOW?
960
-				if (!empty($topic))
961
-					cache_put_data('topic_board-' . $topic, $board_info, 120);
1002
+				if (!empty($topic)) {
1003
+									cache_put_data('topic_board-' . $topic, $board_info, 120);
1004
+				}
962 1005
 				cache_put_data('board-' . $board, $board_info, 120);
963 1006
 			}
964
-		}
965
-		else
1007
+		} else
966 1008
 		{
967 1009
 			// Otherwise the topic is invalid, there are no moderators, etc.
968 1010
 			$board_info = array(
@@ -976,8 +1018,9 @@  discard block
 block discarded – undo
976 1018
 		$smcFunc['db_free_result']($request);
977 1019
 	}
978 1020
 
979
-	if (!empty($topic))
980
-		$_GET['board'] = (int) $board;
1021
+	if (!empty($topic)) {
1022
+			$_GET['board'] = (int) $board;
1023
+	}
981 1024
 
982 1025
 	if (!empty($board))
983 1026
 	{
@@ -987,10 +1030,12 @@  discard block
 block discarded – undo
987 1030
 		// Now check if the user is a moderator.
988 1031
 		$user_info['is_mod'] = isset($board_info['moderators'][$user_info['id']]) || count(array_intersect($user_info['groups'], $moderator_groups)) != 0;
989 1032
 
990
-		if (count(array_intersect($user_info['groups'], $board_info['groups'])) == 0 && !$user_info['is_admin'])
991
-			$board_info['error'] = 'access';
992
-		if (!empty($modSettings['deny_boards_access']) && count(array_intersect($user_info['groups'], $board_info['deny_groups'])) != 0 && !$user_info['is_admin'])
993
-			$board_info['error'] = 'access';
1033
+		if (count(array_intersect($user_info['groups'], $board_info['groups'])) == 0 && !$user_info['is_admin']) {
1034
+					$board_info['error'] = 'access';
1035
+		}
1036
+		if (!empty($modSettings['deny_boards_access']) && count(array_intersect($user_info['groups'], $board_info['deny_groups'])) != 0 && !$user_info['is_admin']) {
1037
+					$board_info['error'] = 'access';
1038
+		}
994 1039
 
995 1040
 		// Build up the linktree.
996 1041
 		$context['linktree'] = array_merge(
@@ -1013,8 +1058,9 @@  discard block
 block discarded – undo
1013 1058
 	$context['current_board'] = $board;
1014 1059
 
1015 1060
 	// No posting in redirection boards!
1016
-	if (!empty($_REQUEST['action']) && $_REQUEST['action'] == 'post' && !empty($board_info['redirect']))
1017
-		$board_info['error'] == 'post_in_redirect';
1061
+	if (!empty($_REQUEST['action']) && $_REQUEST['action'] == 'post' && !empty($board_info['redirect'])) {
1062
+			$board_info['error'] == 'post_in_redirect';
1063
+	}
1018 1064
 
1019 1065
 	// Hacker... you can't see this topic, I'll tell you that. (but moderators can!)
1020 1066
 	if (!empty($board_info['error']) && (!empty($modSettings['deny_boards_access']) || $board_info['error'] != 'access' || !$user_info['is_mod']))
@@ -1040,24 +1086,23 @@  discard block
 block discarded – undo
1040 1086
 			ob_end_clean();
1041 1087
 			header('HTTP/1.1 403 Forbidden');
1042 1088
 			die;
1043
-		}
1044
-		elseif ($board_info['error'] == 'post_in_redirect')
1089
+		} elseif ($board_info['error'] == 'post_in_redirect')
1045 1090
 		{
1046 1091
 			// Slightly different error message here...
1047 1092
 			fatal_lang_error('cannot_post_redirect', false);
1048
-		}
1049
-		elseif ($user_info['is_guest'])
1093
+		} elseif ($user_info['is_guest'])
1050 1094
 		{
1051 1095
 			loadLanguage('Errors');
1052 1096
 			is_not_guest($txt['topic_gone']);
1097
+		} else {
1098
+					fatal_lang_error('topic_gone', false);
1053 1099
 		}
1054
-		else
1055
-			fatal_lang_error('topic_gone', false);
1056 1100
 	}
1057 1101
 
1058
-	if ($user_info['is_mod'])
1059
-		$user_info['groups'][] = 3;
1060
-}
1102
+	if ($user_info['is_mod']) {
1103
+			$user_info['groups'][] = 3;
1104
+	}
1105
+	}
1061 1106
 
1062 1107
 /**
1063 1108
  * Load this user's permissions.
@@ -1078,8 +1123,9 @@  discard block
 block discarded – undo
1078 1123
 		asort($cache_groups);
1079 1124
 		$cache_groups = implode(',', $cache_groups);
1080 1125
 		// If it's a spider then cache it different.
1081
-		if ($user_info['possibly_robot'])
1082
-			$cache_groups .= '-spider';
1126
+		if ($user_info['possibly_robot']) {
1127
+					$cache_groups .= '-spider';
1128
+		}
1083 1129
 
1084 1130
 		if ($modSettings['cache_enable'] >= 2 && !empty($board) && ($temp = cache_get_data('permissions:' . $cache_groups . ':' . $board, 240)) != null && time() - 240 > $modSettings['settings_updated'])
1085 1131
 		{
@@ -1087,9 +1133,9 @@  discard block
 block discarded – undo
1087 1133
 			banPermissions();
1088 1134
 
1089 1135
 			return;
1136
+		} elseif (($temp = cache_get_data('permissions:' . $cache_groups, 240)) != null && time() - 240 > $modSettings['settings_updated']) {
1137
+					list ($user_info['permissions'], $removals) = $temp;
1090 1138
 		}
1091
-		elseif (($temp = cache_get_data('permissions:' . $cache_groups, 240)) != null && time() - 240 > $modSettings['settings_updated'])
1092
-			list ($user_info['permissions'], $removals) = $temp;
1093 1139
 	}
1094 1140
 
1095 1141
 	// If it is detected as a robot, and we are restricting permissions as a special group - then implement this.
@@ -1111,23 +1157,26 @@  discard block
 block discarded – undo
1111 1157
 		$removals = array();
1112 1158
 		while ($row = $smcFunc['db_fetch_assoc']($request))
1113 1159
 		{
1114
-			if (empty($row['add_deny']))
1115
-				$removals[] = $row['permission'];
1116
-			else
1117
-				$user_info['permissions'][] = $row['permission'];
1160
+			if (empty($row['add_deny'])) {
1161
+							$removals[] = $row['permission'];
1162
+			} else {
1163
+							$user_info['permissions'][] = $row['permission'];
1164
+			}
1118 1165
 		}
1119 1166
 		$smcFunc['db_free_result']($request);
1120 1167
 
1121
-		if (isset($cache_groups))
1122
-			cache_put_data('permissions:' . $cache_groups, array($user_info['permissions'], $removals), 240);
1168
+		if (isset($cache_groups)) {
1169
+					cache_put_data('permissions:' . $cache_groups, array($user_info['permissions'], $removals), 240);
1170
+		}
1123 1171
 	}
1124 1172
 
1125 1173
 	// Get the board permissions.
1126 1174
 	if (!empty($board))
1127 1175
 	{
1128 1176
 		// Make sure the board (if any) has been loaded by loadBoard().
1129
-		if (!isset($board_info['profile']))
1130
-			fatal_lang_error('no_board');
1177
+		if (!isset($board_info['profile'])) {
1178
+					fatal_lang_error('no_board');
1179
+		}
1131 1180
 
1132 1181
 		$request = $smcFunc['db_query']('', '
1133 1182
 			SELECT permission, add_deny
@@ -1143,20 +1192,23 @@  discard block
 block discarded – undo
1143 1192
 		);
1144 1193
 		while ($row = $smcFunc['db_fetch_assoc']($request))
1145 1194
 		{
1146
-			if (empty($row['add_deny']))
1147
-				$removals[] = $row['permission'];
1148
-			else
1149
-				$user_info['permissions'][] = $row['permission'];
1195
+			if (empty($row['add_deny'])) {
1196
+							$removals[] = $row['permission'];
1197
+			} else {
1198
+							$user_info['permissions'][] = $row['permission'];
1199
+			}
1150 1200
 		}
1151 1201
 		$smcFunc['db_free_result']($request);
1152 1202
 	}
1153 1203
 
1154 1204
 	// Remove all the permissions they shouldn't have ;).
1155
-	if (!empty($modSettings['permission_enable_deny']))
1156
-		$user_info['permissions'] = array_diff($user_info['permissions'], $removals);
1205
+	if (!empty($modSettings['permission_enable_deny'])) {
1206
+			$user_info['permissions'] = array_diff($user_info['permissions'], $removals);
1207
+	}
1157 1208
 
1158
-	if (isset($cache_groups) && !empty($board) && $modSettings['cache_enable'] >= 2)
1159
-		cache_put_data('permissions:' . $cache_groups . ':' . $board, array($user_info['permissions'], null), 240);
1209
+	if (isset($cache_groups) && !empty($board) && $modSettings['cache_enable'] >= 2) {
1210
+			cache_put_data('permissions:' . $cache_groups . ':' . $board, array($user_info['permissions'], null), 240);
1211
+	}
1160 1212
 
1161 1213
 	// Banned?  Watch, don't touch..
1162 1214
 	banPermissions();
@@ -1168,17 +1220,18 @@  discard block
 block discarded – undo
1168 1220
 		{
1169 1221
 			require_once($sourcedir . '/Subs-Auth.php');
1170 1222
 			rebuildModCache();
1223
+		} else {
1224
+					$user_info['mod_cache'] = $_SESSION['mc'];
1171 1225
 		}
1172
-		else
1173
-			$user_info['mod_cache'] = $_SESSION['mc'];
1174 1226
 
1175 1227
 		// This is a useful phantom permission added to the current user, and only the current user while they are logged in.
1176 1228
 		// For example this drastically simplifies certain changes to the profile area.
1177 1229
 		$user_info['permissions'][] = 'is_not_guest';
1178 1230
 		// And now some backwards compatibility stuff for mods and whatnot that aren't expecting the new permissions.
1179 1231
 		$user_info['permissions'][] = 'profile_view_own';
1180
-		if (in_array('profile_view', $user_info['permissions']))
1181
-			$user_info['permissions'][] = 'profile_view_any';
1232
+		if (in_array('profile_view', $user_info['permissions'])) {
1233
+					$user_info['permissions'][] = 'profile_view_any';
1234
+		}
1182 1235
 	}
1183 1236
 }
1184 1237
 
@@ -1196,8 +1249,9 @@  discard block
 block discarded – undo
1196 1249
 	global $image_proxy_enabled, $image_proxy_secret, $boardurl;
1197 1250
 
1198 1251
 	// Can't just look for no users :P.
1199
-	if (empty($users))
1200
-		return array();
1252
+	if (empty($users)) {
1253
+			return array();
1254
+	}
1201 1255
 
1202 1256
 	// Pass the set value
1203 1257
 	$context['loadMemberContext_set'] = $set;
@@ -1212,8 +1266,9 @@  discard block
 block discarded – undo
1212 1266
 		for ($i = 0, $n = count($users); $i < $n; $i++)
1213 1267
 		{
1214 1268
 			$data = cache_get_data('member_data-' . $set . '-' . $users[$i], 240);
1215
-			if ($data == null)
1216
-				continue;
1269
+			if ($data == null) {
1270
+							continue;
1271
+			}
1217 1272
 
1218 1273
 			$loaded_ids[] = $data['id_member'];
1219 1274
 			$user_profile[$data['id_member']] = $data;
@@ -1280,13 +1335,16 @@  discard block
 block discarded – undo
1280 1335
 			$row['avatar_original'] = !empty($row['avatar']) ? $row['avatar'] : '';
1281 1336
 
1282 1337
 			// Take care of proxying avatar if required, do this here for maximum reach
1283
-			if ($image_proxy_enabled && !empty($row['avatar']) && stripos($row['avatar'], 'http://') !== false)
1284
-				$row['avatar'] = $boardurl . '/proxy.php?request=' . urlencode($row['avatar']) . '&hash=' . md5($row['avatar'] . $image_proxy_secret);
1338
+			if ($image_proxy_enabled && !empty($row['avatar']) && stripos($row['avatar'], 'http://') !== false) {
1339
+							$row['avatar'] = $boardurl . '/proxy.php?request=' . urlencode($row['avatar']) . '&hash=' . md5($row['avatar'] . $image_proxy_secret);
1340
+			}
1285 1341
 
1286
-			if (isset($row['member_ip']))
1287
-				$row['member_ip'] = inet_dtop($row['member_ip']);
1288
-			if (isset($row['member_ip2']))
1289
-				$row['member_ip2'] = inet_dtop($row['member_ip2']);
1342
+			if (isset($row['member_ip'])) {
1343
+							$row['member_ip'] = inet_dtop($row['member_ip']);
1344
+			}
1345
+			if (isset($row['member_ip2'])) {
1346
+							$row['member_ip2'] = inet_dtop($row['member_ip2']);
1347
+			}
1290 1348
 			$new_loaded_ids[] = $row['id_member'];
1291 1349
 			$loaded_ids[] = $row['id_member'];
1292 1350
 			$row['options'] = array();
@@ -1305,8 +1363,9 @@  discard block
 block discarded – undo
1305 1363
 				'loaded_ids' => $new_loaded_ids,
1306 1364
 			)
1307 1365
 		);
1308
-		while ($row = $smcFunc['db_fetch_assoc']($request))
1309
-			$user_profile[$row['id_member']]['options'][$row['variable']] = $row['value'];
1366
+		while ($row = $smcFunc['db_fetch_assoc']($request)) {
1367
+					$user_profile[$row['id_member']]['options'][$row['variable']] = $row['value'];
1368
+		}
1310 1369
 		$smcFunc['db_free_result']($request);
1311 1370
 	}
1312 1371
 
@@ -1317,10 +1376,11 @@  discard block
 block discarded – undo
1317 1376
 	{
1318 1377
 		foreach ($loaded_ids as $a_member)
1319 1378
 		{
1320
-			if (!empty($user_profile[$a_member]['additional_groups']))
1321
-				$groups = array_merge(array($user_profile[$a_member]['id_group']), explode(',', $user_profile[$a_member]['additional_groups']));
1322
-			else
1323
-				$groups = array($user_profile[$a_member]['id_group']);
1379
+			if (!empty($user_profile[$a_member]['additional_groups'])) {
1380
+							$groups = array_merge(array($user_profile[$a_member]['id_group']), explode(',', $user_profile[$a_member]['additional_groups']));
1381
+			} else {
1382
+							$groups = array($user_profile[$a_member]['id_group']);
1383
+			}
1324 1384
 
1325 1385
 			$temp = array_intersect($groups, array_keys($board_info['moderator_groups']));
1326 1386
 
@@ -1333,8 +1393,9 @@  discard block
 block discarded – undo
1333 1393
 
1334 1394
 	if (!empty($new_loaded_ids) && !empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 3)
1335 1395
 	{
1336
-		for ($i = 0, $n = count($new_loaded_ids); $i < $n; $i++)
1337
-			cache_put_data('member_data-' . $set . '-' . $new_loaded_ids[$i], $user_profile[$new_loaded_ids[$i]], 240);
1396
+		for ($i = 0, $n = count($new_loaded_ids); $i < $n; $i++) {
1397
+					cache_put_data('member_data-' . $set . '-' . $new_loaded_ids[$i], $user_profile[$new_loaded_ids[$i]], 240);
1398
+		}
1338 1399
 	}
1339 1400
 
1340 1401
 	// Are we loading any moderators?  If so, fix their group data...
@@ -1360,14 +1421,17 @@  discard block
 block discarded – undo
1360 1421
 		foreach ($temp_mods as $id)
1361 1422
 		{
1362 1423
 			// By popular demand, don't show admins or global moderators as moderators.
1363
-			if ($user_profile[$id]['id_group'] != 1 && $user_profile[$id]['id_group'] != 2)
1364
-				$user_profile[$id]['member_group'] = $row['member_group'];
1424
+			if ($user_profile[$id]['id_group'] != 1 && $user_profile[$id]['id_group'] != 2) {
1425
+							$user_profile[$id]['member_group'] = $row['member_group'];
1426
+			}
1365 1427
 
1366 1428
 			// If the Moderator group has no color or icons, but their group does... don't overwrite.
1367
-			if (!empty($row['icons']))
1368
-				$user_profile[$id]['icons'] = $row['icons'];
1369
-			if (!empty($row['member_group_color']))
1370
-				$user_profile[$id]['member_group_color'] = $row['member_group_color'];
1429
+			if (!empty($row['icons'])) {
1430
+							$user_profile[$id]['icons'] = $row['icons'];
1431
+			}
1432
+			if (!empty($row['member_group_color'])) {
1433
+							$user_profile[$id]['member_group_color'] = $row['member_group_color'];
1434
+			}
1371 1435
 		}
1372 1436
 	}
1373 1437
 
@@ -1389,12 +1453,14 @@  discard block
 block discarded – undo
1389 1453
 	static $loadedLanguages = array();
1390 1454
 
1391 1455
 	// If this person's data is already loaded, skip it.
1392
-	if (isset($dataLoaded[$user]))
1393
-		return true;
1456
+	if (isset($dataLoaded[$user])) {
1457
+			return true;
1458
+	}
1394 1459
 
1395 1460
 	// We can't load guests or members not loaded by loadMemberData()!
1396
-	if ($user == 0)
1397
-		return false;
1461
+	if ($user == 0) {
1462
+			return false;
1463
+	}
1398 1464
 	if (!isset($user_profile[$user]))
1399 1465
 	{
1400 1466
 		trigger_error('loadMemberContext(): member id ' . $user . ' not previously loaded by loadMemberData()', E_USER_WARNING);
@@ -1420,12 +1486,16 @@  discard block
 block discarded – undo
1420 1486
 	$buddy_list = !empty($profile['buddy_list']) ? explode(',', $profile['buddy_list']) : array();
1421 1487
 
1422 1488
 	//We need a little fallback for the membergroup icons. If it doesn't exist in the current theme, fallback to default theme
1423
-	if (isset($profile['icons'][1]) && file_exists($settings['actual_theme_dir'] . '/images/membericons/' . $profile['icons'][1])) //icon is set and exists
1489
+	if (isset($profile['icons'][1]) && file_exists($settings['actual_theme_dir'] . '/images/membericons/' . $profile['icons'][1])) {
1490
+		//icon is set and exists
1424 1491
 		$group_icon_url = $settings['images_url'] . '/membericons/' . $profile['icons'][1];
1425
-	elseif (isset($profile['icons'][1])) //icon is set and doesn't exist, fallback to default
1492
+	} elseif (isset($profile['icons'][1])) {
1493
+		//icon is set and doesn't exist, fallback to default
1426 1494
 		$group_icon_url = $settings['default_images_url'] . '/membericons/' . $profile['icons'][1];
1427
-	else //not set, bye bye
1495
+	} else {
1496
+		//not set, bye bye
1428 1497
 		$group_icon_url = '';
1498
+	}
1429 1499
 
1430 1500
 	// These minimal values are always loaded
1431 1501
 	$memberContext[$user] = array(
@@ -1444,8 +1514,9 @@  discard block
 block discarded – undo
1444 1514
 	if ($context['loadMemberContext_set'] != 'minimal')
1445 1515
 	{
1446 1516
 		// Go the extra mile and load the user's native language name.
1447
-		if (empty($loadedLanguages))
1448
-			$loadedLanguages = getLanguages();
1517
+		if (empty($loadedLanguages)) {
1518
+					$loadedLanguages = getLanguages();
1519
+		}
1449 1520
 
1450 1521
 		$memberContext[$user] += array(
1451 1522
 			'username_color' => '<span ' . (!empty($profile['member_group_color']) ? 'style="color:' . $profile['member_group_color'] . ';"' : '') . '>' . $profile['member_name'] . '</span>',
@@ -1499,31 +1570,33 @@  discard block
 block discarded – undo
1499 1570
 	{
1500 1571
 		if (!empty($modSettings['gravatarOverride']) || (!empty($modSettings['gravatarEnabled']) && stristr($profile['avatar'], 'gravatar://')))
1501 1572
 		{
1502
-			if (!empty($modSettings['gravatarAllowExtraEmail']) && stristr($profile['avatar'], 'gravatar://') && strlen($profile['avatar']) > 11)
1503
-				$image = get_gravatar_url($smcFunc['substr']($profile['avatar'], 11));
1504
-			else
1505
-				$image = get_gravatar_url($profile['email_address']);
1506
-		}
1507
-		else
1573
+			if (!empty($modSettings['gravatarAllowExtraEmail']) && stristr($profile['avatar'], 'gravatar://') && strlen($profile['avatar']) > 11) {
1574
+							$image = get_gravatar_url($smcFunc['substr']($profile['avatar'], 11));
1575
+			} else {
1576
+							$image = get_gravatar_url($profile['email_address']);
1577
+			}
1578
+		} else
1508 1579
 		{
1509 1580
 			// So it's stored in the member table?
1510 1581
 			if (!empty($profile['avatar']))
1511 1582
 			{
1512 1583
 				$image = (stristr($profile['avatar'], 'http://') || stristr($profile['avatar'], 'https://')) ? $profile['avatar'] : $modSettings['avatar_url'] . '/' . $profile['avatar'];
1584
+			} elseif (!empty($profile['filename'])) {
1585
+							$image = $modSettings['custom_avatar_url'] . '/' . $profile['filename'];
1513 1586
 			}
1514
-			elseif (!empty($profile['filename']))
1515
-				$image = $modSettings['custom_avatar_url'] . '/' . $profile['filename'];
1516 1587
 			// Right... no avatar...use the default one
1517
-			else
1518
-				$image = $modSettings['avatar_url'] . '/default.png';
1588
+			else {
1589
+							$image = $modSettings['avatar_url'] . '/default.png';
1590
+			}
1519 1591
 		}
1520
-		if (!empty($image))
1521
-			$memberContext[$user]['avatar'] = array(
1592
+		if (!empty($image)) {
1593
+					$memberContext[$user]['avatar'] = array(
1522 1594
 				'name' => $profile['avatar'],
1523 1595
 				'image' => '<img class="avatar" src="' . $image . '" alt="avatar_' . $profile['member_name'] . '">',
1524 1596
 				'href' => $image,
1525 1597
 				'url' => $image,
1526 1598
 			);
1599
+		}
1527 1600
 	}
1528 1601
 
1529 1602
 	// Are we also loading the members custom fields into context?
@@ -1531,35 +1604,41 @@  discard block
 block discarded – undo
1531 1604
 	{
1532 1605
 		$memberContext[$user]['custom_fields'] = array();
1533 1606
 
1534
-		if (!isset($context['display_fields']))
1535
-			$context['display_fields'] = $smcFunc['json_decode']($modSettings['displayFields'], true);
1607
+		if (!isset($context['display_fields'])) {
1608
+					$context['display_fields'] = $smcFunc['json_decode']($modSettings['displayFields'], true);
1609
+		}
1536 1610
 
1537 1611
 		foreach ($context['display_fields'] as $custom)
1538 1612
 		{
1539
-			if (!isset($custom['col_name']) || trim($custom['col_name']) == '' || empty($profile['options'][$custom['col_name']]))
1540
-				continue;
1613
+			if (!isset($custom['col_name']) || trim($custom['col_name']) == '' || empty($profile['options'][$custom['col_name']])) {
1614
+							continue;
1615
+			}
1541 1616
 
1542 1617
 			$value = $profile['options'][$custom['col_name']];
1543 1618
 
1544 1619
 			// Don't show the "disabled" option for the "gender" field.
1545
-			if ($custom['col_name'] == 'cust_gender' && $value == 'Disabled')
1546
-				continue;
1620
+			if ($custom['col_name'] == 'cust_gender' && $value == 'Disabled') {
1621
+							continue;
1622
+			}
1547 1623
 
1548 1624
 			// BBC?
1549
-			if ($custom['bbc'])
1550
-				$value = parse_bbc($value);
1625
+			if ($custom['bbc']) {
1626
+							$value = parse_bbc($value);
1627
+			}
1551 1628
 			// ... or checkbox?
1552
-			elseif (isset($custom['type']) && $custom['type'] == 'check')
1553
-				$value = $value ? $txt['yes'] : $txt['no'];
1629
+			elseif (isset($custom['type']) && $custom['type'] == 'check') {
1630
+							$value = $value ? $txt['yes'] : $txt['no'];
1631
+			}
1554 1632
 
1555 1633
 			// Enclosing the user input within some other text?
1556
-			if (!empty($custom['enclose']))
1557
-				$value = strtr($custom['enclose'], array(
1634
+			if (!empty($custom['enclose'])) {
1635
+							$value = strtr($custom['enclose'], array(
1558 1636
 					'{SCRIPTURL}' => $scripturl,
1559 1637
 					'{IMAGES_URL}' => $settings['images_url'],
1560 1638
 					'{DEFAULT_IMAGES_URL}' => $settings['default_images_url'],
1561 1639
 					'{INPUT}' => $value,
1562 1640
 				));
1641
+			}
1563 1642
 
1564 1643
 			$memberContext[$user]['custom_fields'][] = array(
1565 1644
 				'title' => !empty($custom['title']) ? $custom['title'] : $custom['col_name'],
@@ -1586,8 +1665,9 @@  discard block
 block discarded – undo
1586 1665
 	global $smcFunc, $txt, $scripturl, $settings;
1587 1666
 
1588 1667
 	// Do not waste my time...
1589
-	if (empty($users) || empty($params))
1590
-		return false;
1668
+	if (empty($users) || empty($params)) {
1669
+			return false;
1670
+	}
1591 1671
 
1592 1672
 	// Make sure it's an array.
1593 1673
 	$users = !is_array($users) ? array($users) : array_unique($users);
@@ -1611,31 +1691,36 @@  discard block
 block discarded – undo
1611 1691
 	while ($row = $smcFunc['db_fetch_assoc']($request))
1612 1692
 	{
1613 1693
 		// BBC?
1614
-		if (!empty($row['bbc']))
1615
-			$row['value'] = parse_bbc($row['value']);
1694
+		if (!empty($row['bbc'])) {
1695
+					$row['value'] = parse_bbc($row['value']);
1696
+		}
1616 1697
 
1617 1698
 		// ... or checkbox?
1618
-		elseif (isset($row['type']) && $row['type'] == 'check')
1619
-			$row['value'] = !empty($row['value']) ? $txt['yes'] : $txt['no'];
1699
+		elseif (isset($row['type']) && $row['type'] == 'check') {
1700
+					$row['value'] = !empty($row['value']) ? $txt['yes'] : $txt['no'];
1701
+		}
1620 1702
 
1621 1703
 		// Enclosing the user input within some other text?
1622
-		if (!empty($row['enclose']))
1623
-			$row['value'] = strtr($row['enclose'], array(
1704
+		if (!empty($row['enclose'])) {
1705
+					$row['value'] = strtr($row['enclose'], array(
1624 1706
 				'{SCRIPTURL}' => $scripturl,
1625 1707
 				'{IMAGES_URL}' => $settings['images_url'],
1626 1708
 				'{DEFAULT_IMAGES_URL}' => $settings['default_images_url'],
1627 1709
 				'{INPUT}' => un_htmlspecialchars($row['value']),
1628 1710
 			));
1711
+		}
1629 1712
 
1630 1713
 		// Send a simple array if there is just 1 param
1631
-		if (count($params) == 1)
1632
-			$return[$row['id_member']] = $row;
1714
+		if (count($params) == 1) {
1715
+					$return[$row['id_member']] = $row;
1716
+		}
1633 1717
 
1634 1718
 		// More than 1? knock yourself out...
1635 1719
 		else
1636 1720
 		{
1637
-			if (!isset($return[$row['id_member']]))
1638
-				$return[$row['id_member']] = array();
1721
+			if (!isset($return[$row['id_member']])) {
1722
+							$return[$row['id_member']] = array();
1723
+			}
1639 1724
 
1640 1725
 			$return[$row['id_member']][$row['variable']] = $row;
1641 1726
 		}
@@ -1669,8 +1754,9 @@  discard block
 block discarded – undo
1669 1754
 	global $context;
1670 1755
 
1671 1756
 	// Don't know any browser!
1672
-	if (empty($context['browser']))
1673
-		detectBrowser();
1757
+	if (empty($context['browser'])) {
1758
+			detectBrowser();
1759
+	}
1674 1760
 
1675 1761
 	return !empty($context['browser'][$browser]) || !empty($context['browser']['is_' . $browser]) ? true : false;
1676 1762
 }
@@ -1688,8 +1774,9 @@  discard block
 block discarded – undo
1688 1774
 	global $context, $settings, $options, $sourcedir, $ssi_theme, $smcFunc, $language, $board, $image_proxy_enabled;
1689 1775
 
1690 1776
 	// The theme was specified by parameter.
1691
-	if (!empty($id_theme))
1692
-		$id_theme = (int) $id_theme;
1777
+	if (!empty($id_theme)) {
1778
+			$id_theme = (int) $id_theme;
1779
+	}
1693 1780
 	// The theme was specified by REQUEST.
1694 1781
 	elseif (!empty($_REQUEST['theme']) && (!empty($modSettings['theme_allow']) || allowedTo('admin_forum')))
1695 1782
 	{
@@ -1697,51 +1784,58 @@  discard block
 block discarded – undo
1697 1784
 		$_SESSION['id_theme'] = $id_theme;
1698 1785
 	}
1699 1786
 	// The theme was specified by REQUEST... previously.
1700
-	elseif (!empty($_SESSION['id_theme']) && (!empty($modSettings['theme_allow']) || allowedTo('admin_forum')))
1701
-		$id_theme = (int) $_SESSION['id_theme'];
1787
+	elseif (!empty($_SESSION['id_theme']) && (!empty($modSettings['theme_allow']) || allowedTo('admin_forum'))) {
1788
+			$id_theme = (int) $_SESSION['id_theme'];
1789
+	}
1702 1790
 	// The theme is just the user's choice. (might use ?board=1;theme=0 to force board theme.)
1703
-	elseif (!empty($user_info['theme']) && !isset($_REQUEST['theme']))
1704
-		$id_theme = $user_info['theme'];
1791
+	elseif (!empty($user_info['theme']) && !isset($_REQUEST['theme'])) {
1792
+			$id_theme = $user_info['theme'];
1793
+	}
1705 1794
 	// The theme was specified by the board.
1706
-	elseif (!empty($board_info['theme']))
1707
-		$id_theme = $board_info['theme'];
1795
+	elseif (!empty($board_info['theme'])) {
1796
+			$id_theme = $board_info['theme'];
1797
+	}
1708 1798
 	// The theme is the forum's default.
1709
-	else
1710
-		$id_theme = $modSettings['theme_guests'];
1799
+	else {
1800
+			$id_theme = $modSettings['theme_guests'];
1801
+	}
1711 1802
 
1712 1803
 	// Verify the id_theme... no foul play.
1713 1804
 	// Always allow the board specific theme, if they are overriding.
1714
-	if (!empty($board_info['theme']) && $board_info['override_theme'])
1715
-		$id_theme = $board_info['theme'];
1805
+	if (!empty($board_info['theme']) && $board_info['override_theme']) {
1806
+			$id_theme = $board_info['theme'];
1807
+	}
1716 1808
 	// If they have specified a particular theme to use with SSI allow it to be used.
1717
-	elseif (!empty($ssi_theme) && $id_theme == $ssi_theme)
1718
-		$id_theme = (int) $id_theme;
1719
-	elseif (!empty($modSettings['enableThemes']) && !allowedTo('admin_forum'))
1809
+	elseif (!empty($ssi_theme) && $id_theme == $ssi_theme) {
1810
+			$id_theme = (int) $id_theme;
1811
+	} elseif (!empty($modSettings['enableThemes']) && !allowedTo('admin_forum'))
1720 1812
 	{
1721 1813
 		$themes = explode(',', $modSettings['enableThemes']);
1722
-		if (!in_array($id_theme, $themes))
1723
-			$id_theme = $modSettings['theme_guests'];
1724
-		else
1814
+		if (!in_array($id_theme, $themes)) {
1815
+					$id_theme = $modSettings['theme_guests'];
1816
+		} else {
1817
+					$id_theme = (int) $id_theme;
1818
+		}
1819
+	} else {
1725 1820
 			$id_theme = (int) $id_theme;
1726 1821
 	}
1727
-	else
1728
-		$id_theme = (int) $id_theme;
1729 1822
 
1730 1823
 	$member = empty($user_info['id']) ? -1 : $user_info['id'];
1731 1824
 
1732 1825
 	// Disable image proxy if we don't have SSL enabled
1733
-	if (empty($modSettings['force_ssl']) || $modSettings['force_ssl'] < 2)
1734
-		$image_proxy_enabled = false;
1826
+	if (empty($modSettings['force_ssl']) || $modSettings['force_ssl'] < 2) {
1827
+			$image_proxy_enabled = false;
1828
+	}
1735 1829
 
1736 1830
 	if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 2 && ($temp = cache_get_data('theme_settings-' . $id_theme . ':' . $member, 60)) != null && time() - 60 > $modSettings['settings_updated'])
1737 1831
 	{
1738 1832
 		$themeData = $temp;
1739 1833
 		$flag = true;
1834
+	} elseif (($temp = cache_get_data('theme_settings-' . $id_theme, 90)) != null && time() - 60 > $modSettings['settings_updated']) {
1835
+			$themeData = $temp + array($member => array());
1836
+	} else {
1837
+			$themeData = array(-1 => array(), 0 => array(), $member => array());
1740 1838
 	}
1741
-	elseif (($temp = cache_get_data('theme_settings-' . $id_theme, 90)) != null && time() - 60 > $modSettings['settings_updated'])
1742
-		$themeData = $temp + array($member => array());
1743
-	else
1744
-		$themeData = array(-1 => array(), 0 => array(), $member => array());
1745 1839
 
1746 1840
 	if (empty($flag))
1747 1841
 	{
@@ -1760,31 +1854,37 @@  discard block
 block discarded – undo
1760 1854
 		while ($row = $smcFunc['db_fetch_assoc']($result))
1761 1855
 		{
1762 1856
 			// There are just things we shouldn't be able to change as members.
1763
-			if ($row['id_member'] != 0 && in_array($row['variable'], array('actual_theme_url', 'actual_images_url', 'base_theme_dir', 'base_theme_url', 'default_images_url', 'default_theme_dir', 'default_theme_url', 'default_template', 'images_url', 'number_recent_posts', 'smiley_sets_default', 'theme_dir', 'theme_id', 'theme_layers', 'theme_templates', 'theme_url')))
1764
-				continue;
1857
+			if ($row['id_member'] != 0 && in_array($row['variable'], array('actual_theme_url', 'actual_images_url', 'base_theme_dir', 'base_theme_url', 'default_images_url', 'default_theme_dir', 'default_theme_url', 'default_template', 'images_url', 'number_recent_posts', 'smiley_sets_default', 'theme_dir', 'theme_id', 'theme_layers', 'theme_templates', 'theme_url'))) {
1858
+							continue;
1859
+			}
1765 1860
 
1766 1861
 			// If this is the theme_dir of the default theme, store it.
1767
-			if (in_array($row['variable'], array('theme_dir', 'theme_url', 'images_url')) && $row['id_theme'] == '1' && empty($row['id_member']))
1768
-				$themeData[0]['default_' . $row['variable']] = $row['value'];
1862
+			if (in_array($row['variable'], array('theme_dir', 'theme_url', 'images_url')) && $row['id_theme'] == '1' && empty($row['id_member'])) {
1863
+							$themeData[0]['default_' . $row['variable']] = $row['value'];
1864
+			}
1769 1865
 
1770 1866
 			// If this isn't set yet, is a theme option, or is not the default theme..
1771
-			if (!isset($themeData[$row['id_member']][$row['variable']]) || $row['id_theme'] != '1')
1772
-				$themeData[$row['id_member']][$row['variable']] = substr($row['variable'], 0, 5) == 'show_' ? $row['value'] == '1' : $row['value'];
1867
+			if (!isset($themeData[$row['id_member']][$row['variable']]) || $row['id_theme'] != '1') {
1868
+							$themeData[$row['id_member']][$row['variable']] = substr($row['variable'], 0, 5) == 'show_' ? $row['value'] == '1' : $row['value'];
1869
+			}
1773 1870
 		}
1774 1871
 		$smcFunc['db_free_result']($result);
1775 1872
 
1776
-		if (!empty($themeData[-1]))
1777
-			foreach ($themeData[-1] as $k => $v)
1873
+		if (!empty($themeData[-1])) {
1874
+					foreach ($themeData[-1] as $k => $v)
1778 1875
 			{
1779 1876
 				if (!isset($themeData[$member][$k]))
1780 1877
 					$themeData[$member][$k] = $v;
1878
+		}
1781 1879
 			}
1782 1880
 
1783
-		if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 2)
1784
-			cache_put_data('theme_settings-' . $id_theme . ':' . $member, $themeData, 60);
1881
+		if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 2) {
1882
+					cache_put_data('theme_settings-' . $id_theme . ':' . $member, $themeData, 60);
1883
+		}
1785 1884
 		// Only if we didn't already load that part of the cache...
1786
-		elseif (!isset($temp))
1787
-			cache_put_data('theme_settings-' . $id_theme, array(-1 => $themeData[-1], 0 => $themeData[0]), 90);
1885
+		elseif (!isset($temp)) {
1886
+					cache_put_data('theme_settings-' . $id_theme, array(-1 => $themeData[-1], 0 => $themeData[0]), 90);
1887
+		}
1788 1888
 	}
1789 1889
 
1790 1890
 	$settings = $themeData[0];
@@ -1801,20 +1901,24 @@  discard block
 block discarded – undo
1801 1901
 	$settings['template_dirs'][] = $settings['theme_dir'];
1802 1902
 
1803 1903
 	// Based on theme (if there is one).
1804
-	if (!empty($settings['base_theme_dir']))
1805
-		$settings['template_dirs'][] = $settings['base_theme_dir'];
1904
+	if (!empty($settings['base_theme_dir'])) {
1905
+			$settings['template_dirs'][] = $settings['base_theme_dir'];
1906
+	}
1806 1907
 
1807 1908
 	// Lastly the default theme.
1808
-	if ($settings['theme_dir'] != $settings['default_theme_dir'])
1809
-		$settings['template_dirs'][] = $settings['default_theme_dir'];
1909
+	if ($settings['theme_dir'] != $settings['default_theme_dir']) {
1910
+			$settings['template_dirs'][] = $settings['default_theme_dir'];
1911
+	}
1810 1912
 
1811
-	if (!$initialize)
1812
-		return;
1913
+	if (!$initialize) {
1914
+			return;
1915
+	}
1813 1916
 
1814 1917
 	// Check to see if we're forcing SSL
1815 1918
 	if (!empty($modSettings['force_ssl']) && $modSettings['force_ssl'] == 2 && empty($maintenance) &&
1816
-		(!isset($_SERVER['HTTPS']) || $_SERVER['HTTPS'] == 'off') && SMF != 'SSI')
1817
-		redirectexit(strtr($_SERVER['REQUEST_URL'], array('http://' => 'https://')));
1919
+		(!isset($_SERVER['HTTPS']) || $_SERVER['HTTPS'] == 'off') && SMF != 'SSI') {
1920
+			redirectexit(strtr($_SERVER['REQUEST_URL'], array('http://' => 'https://')));
1921
+	}
1818 1922
 
1819 1923
 	// Check to see if they're accessing it from the wrong place.
1820 1924
 	if (isset($_SERVER['HTTP_HOST']) || isset($_SERVER['SERVER_NAME']))
@@ -1822,8 +1926,9 @@  discard block
 block discarded – undo
1822 1926
 		$detected_url = isset($_SERVER['HTTPS']) && strtolower($_SERVER['HTTPS']) == 'on' ? 'https://' : 'http://';
1823 1927
 		$detected_url .= empty($_SERVER['HTTP_HOST']) ? $_SERVER['SERVER_NAME'] . (empty($_SERVER['SERVER_PORT']) || $_SERVER['SERVER_PORT'] == '80' ? '' : ':' . $_SERVER['SERVER_PORT']) : $_SERVER['HTTP_HOST'];
1824 1928
 		$temp = preg_replace('~/' . basename($scripturl) . '(/.+)?$~', '', strtr(dirname($_SERVER['PHP_SELF']), '\\', '/'));
1825
-		if ($temp != '/')
1826
-			$detected_url .= $temp;
1929
+		if ($temp != '/') {
1930
+					$detected_url .= $temp;
1931
+		}
1827 1932
 	}
1828 1933
 	if (isset($detected_url) && $detected_url != $boardurl)
1829 1934
 	{
@@ -1835,8 +1940,9 @@  discard block
 block discarded – undo
1835 1940
 			foreach ($aliases as $alias)
1836 1941
 			{
1837 1942
 				// Rip off all the boring parts, spaces, etc.
1838
-				if ($detected_url == trim($alias) || strtr($detected_url, array('http://' => '', 'https://' => '')) == trim($alias))
1839
-					$do_fix = true;
1943
+				if ($detected_url == trim($alias) || strtr($detected_url, array('http://' => '', 'https://' => '')) == trim($alias)) {
1944
+									$do_fix = true;
1945
+				}
1840 1946
 			}
1841 1947
 		}
1842 1948
 
@@ -1844,20 +1950,22 @@  discard block
 block discarded – undo
1844 1950
 		if (empty($do_fix) && strtr($detected_url, array('://' => '://www.')) == $boardurl && (empty($_GET) || count($_GET) == 1) && SMF != 'SSI')
1845 1951
 		{
1846 1952
 			// Okay, this seems weird, but we don't want an endless loop - this will make $_GET not empty ;).
1847
-			if (empty($_GET))
1848
-				redirectexit('wwwRedirect');
1849
-			else
1953
+			if (empty($_GET)) {
1954
+							redirectexit('wwwRedirect');
1955
+			} else
1850 1956
 			{
1851 1957
 				list ($k, $v) = each($_GET);
1852 1958
 
1853
-				if ($k != 'wwwRedirect')
1854
-					redirectexit('wwwRedirect;' . $k . '=' . $v);
1959
+				if ($k != 'wwwRedirect') {
1960
+									redirectexit('wwwRedirect;' . $k . '=' . $v);
1961
+				}
1855 1962
 			}
1856 1963
 		}
1857 1964
 
1858 1965
 		// #3 is just a check for SSL...
1859
-		if (strtr($detected_url, array('https://' => 'http://')) == $boardurl)
1860
-			$do_fix = true;
1966
+		if (strtr($detected_url, array('https://' => 'http://')) == $boardurl) {
1967
+					$do_fix = true;
1968
+		}
1861 1969
 
1862 1970
 		// Okay, #4 - perhaps it's an IP address?  We're gonna want to use that one, then. (assuming it's the IP or something...)
1863 1971
 		if (!empty($do_fix) || preg_match('~^http[s]?://(?:[\d\.:]+|\[[\d:]+\](?::\d+)?)(?:$|/)~', $detected_url) == 1)
@@ -1891,8 +1999,9 @@  discard block
 block discarded – undo
1891 1999
 					$board_info['moderators'][$k]['link'] = strtr($dummy['link'], array('"' . $oldurl => '"' . $boardurl));
1892 2000
 				}
1893 2001
 			}
1894
-			foreach ($context['linktree'] as $k => $dummy)
1895
-				$context['linktree'][$k]['url'] = strtr($dummy['url'], array($oldurl => $boardurl));
2002
+			foreach ($context['linktree'] as $k => $dummy) {
2003
+							$context['linktree'][$k]['url'] = strtr($dummy['url'], array($oldurl => $boardurl));
2004
+			}
1896 2005
 		}
1897 2006
 	}
1898 2007
 	// Set up the contextual user array.
@@ -1911,16 +2020,16 @@  discard block
 block discarded – undo
1911 2020
 			'email' => $user_info['email'],
1912 2021
 			'ignoreusers' => $user_info['ignoreusers'],
1913 2022
 		);
1914
-		if (!$context['user']['is_guest'])
1915
-			$context['user']['name'] = $user_info['name'];
1916
-		elseif ($context['user']['is_guest'] && !empty($txt['guest_title']))
1917
-			$context['user']['name'] = $txt['guest_title'];
2023
+		if (!$context['user']['is_guest']) {
2024
+					$context['user']['name'] = $user_info['name'];
2025
+		} elseif ($context['user']['is_guest'] && !empty($txt['guest_title'])) {
2026
+					$context['user']['name'] = $txt['guest_title'];
2027
+		}
1918 2028
 
1919 2029
 		// Determine the current smiley set.
1920 2030
 		$user_info['smiley_set'] = (!in_array($user_info['smiley_set'], explode(',', $modSettings['smiley_sets_known'])) && $user_info['smiley_set'] != 'none') || empty($modSettings['smiley_sets_enable']) ? (!empty($settings['smiley_sets_default']) ? $settings['smiley_sets_default'] : $modSettings['smiley_sets_default']) : $user_info['smiley_set'];
1921 2031
 		$context['user']['smiley_set'] = $user_info['smiley_set'];
1922
-	}
1923
-	else
2032
+	} else
1924 2033
 	{
1925 2034
 		$context['user'] = array(
1926 2035
 			'id' => -1,
@@ -1936,18 +2045,24 @@  discard block
 block discarded – undo
1936 2045
 	}
1937 2046
 
1938 2047
 	// Some basic information...
1939
-	if (!isset($context['html_headers']))
1940
-		$context['html_headers'] = '';
1941
-	if (!isset($context['javascript_files']))
1942
-		$context['javascript_files'] = array();
1943
-	if (!isset($context['css_files']))
1944
-		$context['css_files'] = array();
1945
-	if (!isset($context['css_header']))
1946
-		$context['css_header'] = array();
1947
-	if (!isset($context['javascript_inline']))
1948
-		$context['javascript_inline'] = array('standard' => array(), 'defer' => array());
1949
-	if (!isset($context['javascript_vars']))
1950
-		$context['javascript_vars'] = array();
2048
+	if (!isset($context['html_headers'])) {
2049
+			$context['html_headers'] = '';
2050
+	}
2051
+	if (!isset($context['javascript_files'])) {
2052
+			$context['javascript_files'] = array();
2053
+	}
2054
+	if (!isset($context['css_files'])) {
2055
+			$context['css_files'] = array();
2056
+	}
2057
+	if (!isset($context['css_header'])) {
2058
+			$context['css_header'] = array();
2059
+	}
2060
+	if (!isset($context['javascript_inline'])) {
2061
+			$context['javascript_inline'] = array('standard' => array(), 'defer' => array());
2062
+	}
2063
+	if (!isset($context['javascript_vars'])) {
2064
+			$context['javascript_vars'] = array();
2065
+	}
1951 2066
 
1952 2067
 	$context['login_url'] = (!empty($modSettings['force_ssl']) && $modSettings['force_ssl'] < 2 ? strtr($scripturl, array('http://' => 'https://')) : $scripturl) . '?action=login2';
1953 2068
 	$context['menu_separator'] = !empty($settings['use_image_buttons']) ? ' ' : ' | ';
@@ -1959,8 +2074,9 @@  discard block
 block discarded – undo
1959 2074
 	$context['current_action'] = isset($_REQUEST['action']) ? $smcFunc['htmlspecialchars']($_REQUEST['action']) : null;
1960 2075
 	$context['current_subaction'] = isset($_REQUEST['sa']) ? $_REQUEST['sa'] : null;
1961 2076
 	$context['can_register'] = empty($modSettings['registration_method']) || $modSettings['registration_method'] != 3;
1962
-	if (isset($modSettings['load_average']))
1963
-		$context['load_average'] = $modSettings['load_average'];
2077
+	if (isset($modSettings['load_average'])) {
2078
+			$context['load_average'] = $modSettings['load_average'];
2079
+	}
1964 2080
 
1965 2081
 	// Detect the browser. This is separated out because it's also used in attachment downloads
1966 2082
 	detectBrowser();
@@ -1974,8 +2090,9 @@  discard block
 block discarded – undo
1974 2090
 	// This allows sticking some HTML on the page output - useful for controls.
1975 2091
 	$context['insert_after_template'] = '';
1976 2092
 
1977
-	if (!isset($txt))
1978
-		$txt = array();
2093
+	if (!isset($txt)) {
2094
+			$txt = array();
2095
+	}
1979 2096
 
1980 2097
 	$simpleActions = array(
1981 2098
 		'findmember',
@@ -2021,9 +2138,10 @@  discard block
 block discarded – undo
2021 2138
 
2022 2139
 	// See if theres any extra param to check.
2023 2140
 	$requiresXML = false;
2024
-	foreach ($extraParams as $key => $extra)
2025
-		if (isset($_REQUEST[$extra]))
2141
+	foreach ($extraParams as $key => $extra) {
2142
+			if (isset($_REQUEST[$extra]))
2026 2143
 			$requiresXML = true;
2144
+	}
2027 2145
 
2028 2146
 	// Output is fully XML, so no need for the index template.
2029 2147
 	if (isset($_REQUEST['xml']) && (in_array($context['current_action'], $xmlActions) || $requiresXML))
@@ -2038,37 +2156,39 @@  discard block
 block discarded – undo
2038 2156
 	{
2039 2157
 		loadLanguage('index+Modifications');
2040 2158
 		$context['template_layers'] = array();
2041
-	}
2042
-
2043
-	else
2159
+	} else
2044 2160
 	{
2045 2161
 		// Custom templates to load, or just default?
2046
-		if (isset($settings['theme_templates']))
2047
-			$templates = explode(',', $settings['theme_templates']);
2048
-		else
2049
-			$templates = array('index');
2162
+		if (isset($settings['theme_templates'])) {
2163
+					$templates = explode(',', $settings['theme_templates']);
2164
+		} else {
2165
+					$templates = array('index');
2166
+		}
2050 2167
 
2051 2168
 		// Load each template...
2052
-		foreach ($templates as $template)
2053
-			loadTemplate($template);
2169
+		foreach ($templates as $template) {
2170
+					loadTemplate($template);
2171
+		}
2054 2172
 
2055 2173
 		// ...and attempt to load their associated language files.
2056 2174
 		$required_files = implode('+', array_merge($templates, array('Modifications')));
2057 2175
 		loadLanguage($required_files, '', false);
2058 2176
 
2059 2177
 		// Custom template layers?
2060
-		if (isset($settings['theme_layers']))
2061
-			$context['template_layers'] = explode(',', $settings['theme_layers']);
2062
-		else
2063
-			$context['template_layers'] = array('html', 'body');
2178
+		if (isset($settings['theme_layers'])) {
2179
+					$context['template_layers'] = explode(',', $settings['theme_layers']);
2180
+		} else {
2181
+					$context['template_layers'] = array('html', 'body');
2182
+		}
2064 2183
 	}
2065 2184
 
2066 2185
 	// Initialize the theme.
2067 2186
 	loadSubTemplate('init', 'ignore');
2068 2187
 
2069 2188
 	// Allow overriding the board wide time/number formats.
2070
-	if (empty($user_settings['time_format']) && !empty($txt['time_format']))
2071
-		$user_info['time_format'] = $txt['time_format'];
2189
+	if (empty($user_settings['time_format']) && !empty($txt['time_format'])) {
2190
+			$user_info['time_format'] = $txt['time_format'];
2191
+	}
2072 2192
 
2073 2193
 	// Set the character set from the template.
2074 2194
 	$context['character_set'] = empty($modSettings['global_character_set']) ? $txt['lang_character_set'] : $modSettings['global_character_set'];
@@ -2076,12 +2196,14 @@  discard block
 block discarded – undo
2076 2196
 	$context['right_to_left'] = !empty($txt['lang_rtl']);
2077 2197
 
2078 2198
 	// Guests may still need a name.
2079
-	if ($context['user']['is_guest'] && empty($context['user']['name']))
2080
-		$context['user']['name'] = $txt['guest_title'];
2199
+	if ($context['user']['is_guest'] && empty($context['user']['name'])) {
2200
+			$context['user']['name'] = $txt['guest_title'];
2201
+	}
2081 2202
 
2082 2203
 	// Any theme-related strings that need to be loaded?
2083
-	if (!empty($settings['require_theme_strings']))
2084
-		loadLanguage('ThemeStrings', '', false);
2204
+	if (!empty($settings['require_theme_strings'])) {
2205
+			loadLanguage('ThemeStrings', '', false);
2206
+	}
2085 2207
 
2086 2208
 	// Make a special URL for the language.
2087 2209
 	$settings['lang_images_url'] = $settings['images_url'] . '/' . (!empty($txt['image_lang']) ? $txt['image_lang'] : $user_info['language']);
@@ -2092,8 +2214,9 @@  discard block
 block discarded – undo
2092 2214
 	// Here is my luvly Responsive CSS
2093 2215
 	loadCSSFile('responsive.css', array('force_current' => false, 'validate' => true, 'minimize' => true), 'smf_responsive');
2094 2216
 
2095
-	if ($context['right_to_left'])
2096
-		loadCSSFile('rtl.css', array(), 'smf_rtl');
2217
+	if ($context['right_to_left']) {
2218
+			loadCSSFile('rtl.css', array(), 'smf_rtl');
2219
+	}
2097 2220
 
2098 2221
 	// We allow theme variants, because we're cool.
2099 2222
 	$context['theme_variant'] = '';
@@ -2101,14 +2224,17 @@  discard block
 block discarded – undo
2101 2224
 	if (!empty($settings['theme_variants']))
2102 2225
 	{
2103 2226
 		// Overriding - for previews and that ilk.
2104
-		if (!empty($_REQUEST['variant']))
2105
-			$_SESSION['id_variant'] = $_REQUEST['variant'];
2227
+		if (!empty($_REQUEST['variant'])) {
2228
+					$_SESSION['id_variant'] = $_REQUEST['variant'];
2229
+		}
2106 2230
 		// User selection?
2107
-		if (empty($settings['disable_user_variant']) || allowedTo('admin_forum'))
2108
-			$context['theme_variant'] = !empty($_SESSION['id_variant']) ? $_SESSION['id_variant'] : (!empty($options['theme_variant']) ? $options['theme_variant'] : '');
2231
+		if (empty($settings['disable_user_variant']) || allowedTo('admin_forum')) {
2232
+					$context['theme_variant'] = !empty($_SESSION['id_variant']) ? $_SESSION['id_variant'] : (!empty($options['theme_variant']) ? $options['theme_variant'] : '');
2233
+		}
2109 2234
 		// If not a user variant, select the default.
2110
-		if ($context['theme_variant'] == '' || !in_array($context['theme_variant'], $settings['theme_variants']))
2111
-			$context['theme_variant'] = !empty($settings['default_variant']) && in_array($settings['default_variant'], $settings['theme_variants']) ? $settings['default_variant'] : $settings['theme_variants'][0];
2235
+		if ($context['theme_variant'] == '' || !in_array($context['theme_variant'], $settings['theme_variants'])) {
2236
+					$context['theme_variant'] = !empty($settings['default_variant']) && in_array($settings['default_variant'], $settings['theme_variants']) ? $settings['default_variant'] : $settings['theme_variants'][0];
2237
+		}
2112 2238
 
2113 2239
 		// Do this to keep things easier in the templates.
2114 2240
 		$context['theme_variant'] = '_' . $context['theme_variant'];
@@ -2117,20 +2243,23 @@  discard block
 block discarded – undo
2117 2243
 		if (!empty($context['theme_variant']))
2118 2244
 		{
2119 2245
 			loadCSSFile('index' . $context['theme_variant'] . '.css', array(), 'smf_index' . $context['theme_variant']);
2120
-			if ($context['right_to_left'])
2121
-				loadCSSFile('rtl' . $context['theme_variant'] . '.css', array(), 'smf_rtl' . $context['theme_variant']);
2246
+			if ($context['right_to_left']) {
2247
+							loadCSSFile('rtl' . $context['theme_variant'] . '.css', array(), 'smf_rtl' . $context['theme_variant']);
2248
+			}
2122 2249
 		}
2123 2250
 	}
2124 2251
 
2125 2252
 	// Let's be compatible with old themes!
2126
-	if (!function_exists('template_html_above') && in_array('html', $context['template_layers']))
2127
-		$context['template_layers'] = array('main');
2253
+	if (!function_exists('template_html_above') && in_array('html', $context['template_layers'])) {
2254
+			$context['template_layers'] = array('main');
2255
+	}
2128 2256
 
2129 2257
 	$context['tabindex'] = 1;
2130 2258
 
2131 2259
 	// Compatibility.
2132
-	if (!isset($settings['theme_version']))
2133
-		$modSettings['memberCount'] = $modSettings['totalMembers'];
2260
+	if (!isset($settings['theme_version'])) {
2261
+			$modSettings['memberCount'] = $modSettings['totalMembers'];
2262
+	}
2134 2263
 
2135 2264
 	// Default JS variables for use in every theme
2136 2265
 	$context['javascript_vars'] = array(
@@ -2149,18 +2278,18 @@  discard block
 block discarded – undo
2149 2278
 	);
2150 2279
 
2151 2280
 	// Add the JQuery library to the list of files to load.
2152
-	if (isset($modSettings['jquery_source']) && $modSettings['jquery_source'] == 'cdn')
2153
-		loadJavaScriptFile('https://ajax.googleapis.com/ajax/libs/jquery/3.1.1/jquery.min.js', array('external' => true), 'smf_jquery');
2154
-
2155
-	elseif (isset($modSettings['jquery_source']) && $modSettings['jquery_source'] == 'local')
2156
-		loadJavaScriptFile('jquery-3.1.1.min.js', array('seed' => false), 'smf_jquery');
2157
-
2158
-	elseif (isset($modSettings['jquery_source'], $modSettings['jquery_custom']) && $modSettings['jquery_source'] == 'custom')
2159
-		loadJavaScriptFile($modSettings['jquery_custom'], array('external' => true), 'smf_jquery');
2281
+	if (isset($modSettings['jquery_source']) && $modSettings['jquery_source'] == 'cdn') {
2282
+			loadJavaScriptFile('https://ajax.googleapis.com/ajax/libs/jquery/3.1.1/jquery.min.js', array('external' => true), 'smf_jquery');
2283
+	} elseif (isset($modSettings['jquery_source']) && $modSettings['jquery_source'] == 'local') {
2284
+			loadJavaScriptFile('jquery-3.1.1.min.js', array('seed' => false), 'smf_jquery');
2285
+	} elseif (isset($modSettings['jquery_source'], $modSettings['jquery_custom']) && $modSettings['jquery_source'] == 'custom') {
2286
+			loadJavaScriptFile($modSettings['jquery_custom'], array('external' => true), 'smf_jquery');
2287
+	}
2160 2288
 
2161 2289
 	// Auto loading? template_javascript() will take care of the local half of this.
2162
-	else
2163
-		loadJavaScriptFile('https://ajax.googleapis.com/ajax/libs/jquery/3.1.1/jquery.min.js', array('external' => true), 'smf_jquery');
2290
+	else {
2291
+			loadJavaScriptFile('https://ajax.googleapis.com/ajax/libs/jquery/3.1.1/jquery.min.js', array('external' => true), 'smf_jquery');
2292
+	}
2164 2293
 
2165 2294
 	// Queue our JQuery plugins!
2166 2295
 	loadJavaScriptFile('smf_jquery_plugins.js', array('minimize' => true), 'smf_jquery_plugins');
@@ -2183,12 +2312,12 @@  discard block
 block discarded – undo
2183 2312
 			require_once($sourcedir . '/ScheduledTasks.php');
2184 2313
 
2185 2314
 			// What to do, what to do?!
2186
-			if (empty($modSettings['next_task_time']) || $modSettings['next_task_time'] < time())
2187
-				AutoTask();
2188
-			else
2189
-				ReduceMailQueue();
2190
-		}
2191
-		else
2315
+			if (empty($modSettings['next_task_time']) || $modSettings['next_task_time'] < time()) {
2316
+							AutoTask();
2317
+			} else {
2318
+							ReduceMailQueue();
2319
+			}
2320
+		} else
2192 2321
 		{
2193 2322
 			$type = empty($modSettings['next_task_time']) || $modSettings['next_task_time'] < time() ? 'task' : 'mailq';
2194 2323
 			$ts = $type == 'mailq' ? $modSettings['mail_next_send'] : $modSettings['next_task_time'];
@@ -2239,8 +2368,9 @@  discard block
 block discarded – undo
2239 2368
 		foreach ($theme_includes as $include)
2240 2369
 		{
2241 2370
 			$include = strtr(trim($include), array('$boarddir' => $boarddir, '$sourcedir' => $sourcedir, '$themedir' => $settings['theme_dir']));
2242
-			if (file_exists($include))
2243
-				require_once($include);
2371
+			if (file_exists($include)) {
2372
+							require_once($include);
2373
+			}
2244 2374
 		}
2245 2375
 	}
2246 2376
 
@@ -2270,16 +2400,19 @@  discard block
 block discarded – undo
2270 2400
 	// Do any style sheets first, cause we're easy with those.
2271 2401
 	if (!empty($style_sheets))
2272 2402
 	{
2273
-		if (!is_array($style_sheets))
2274
-			$style_sheets = array($style_sheets);
2403
+		if (!is_array($style_sheets)) {
2404
+					$style_sheets = array($style_sheets);
2405
+		}
2275 2406
 
2276
-		foreach ($style_sheets as $sheet)
2277
-			loadCSSFile($sheet . '.css', array(), $sheet);
2407
+		foreach ($style_sheets as $sheet) {
2408
+					loadCSSFile($sheet . '.css', array(), $sheet);
2409
+		}
2278 2410
 	}
2279 2411
 
2280 2412
 	// No template to load?
2281
-	if ($template_name === false)
2282
-		return true;
2413
+	if ($template_name === false) {
2414
+			return true;
2415
+	}
2283 2416
 
2284 2417
 	$loaded = false;
2285 2418
 	foreach ($settings['template_dirs'] as $template_dir)
@@ -2294,12 +2427,14 @@  discard block
 block discarded – undo
2294 2427
 
2295 2428
 	if ($loaded)
2296 2429
 	{
2297
-		if ($db_show_debug === true)
2298
-			$context['debug']['templates'][] = $template_name . ' (' . basename($template_dir) . ')';
2430
+		if ($db_show_debug === true) {
2431
+					$context['debug']['templates'][] = $template_name . ' (' . basename($template_dir) . ')';
2432
+		}
2299 2433
 
2300 2434
 		// If they have specified an initialization function for this template, go ahead and call it now.
2301
-		if (function_exists('template_' . $template_name . '_init'))
2302
-			call_user_func('template_' . $template_name . '_init');
2435
+		if (function_exists('template_' . $template_name . '_init')) {
2436
+					call_user_func('template_' . $template_name . '_init');
2437
+		}
2303 2438
 	}
2304 2439
 	// Hmmm... doesn't exist?!  I don't suppose the directory is wrong, is it?
2305 2440
 	elseif (!file_exists($settings['default_theme_dir']) && file_exists($boarddir . '/Themes/default'))
@@ -2319,13 +2454,14 @@  discard block
 block discarded – undo
2319 2454
 		loadTemplate($template_name);
2320 2455
 	}
2321 2456
 	// Cause an error otherwise.
2322
-	elseif ($template_name != 'Errors' && $template_name != 'index' && $fatal)
2323
-		fatal_lang_error('theme_template_error', 'template', array((string) $template_name));
2324
-	elseif ($fatal)
2325
-		die(log_error(sprintf(isset($txt['theme_template_error']) ? $txt['theme_template_error'] : 'Unable to load Themes/default/%s.template.php!', (string) $template_name), 'template'));
2326
-	else
2327
-		return false;
2328
-}
2457
+	elseif ($template_name != 'Errors' && $template_name != 'index' && $fatal) {
2458
+			fatal_lang_error('theme_template_error', 'template', array((string) $template_name));
2459
+	} elseif ($fatal) {
2460
+			die(log_error(sprintf(isset($txt['theme_template_error']) ? $txt['theme_template_error'] : 'Unable to load Themes/default/%s.template.php!', (string) $template_name), 'template'));
2461
+	} else {
2462
+			return false;
2463
+	}
2464
+	}
2329 2465
 
2330 2466
 /**
2331 2467
  * Load a sub-template.
@@ -2343,17 +2479,19 @@  discard block
 block discarded – undo
2343 2479
 {
2344 2480
 	global $context, $txt, $db_show_debug;
2345 2481
 
2346
-	if ($db_show_debug === true)
2347
-		$context['debug']['sub_templates'][] = $sub_template_name;
2482
+	if ($db_show_debug === true) {
2483
+			$context['debug']['sub_templates'][] = $sub_template_name;
2484
+	}
2348 2485
 
2349 2486
 	// Figure out what the template function is named.
2350 2487
 	$theme_function = 'template_' . $sub_template_name;
2351
-	if (function_exists($theme_function))
2352
-		$theme_function();
2353
-	elseif ($fatal === false)
2354
-		fatal_lang_error('theme_template_error', 'template', array((string) $sub_template_name));
2355
-	elseif ($fatal !== 'ignore')
2356
-		die(log_error(sprintf(isset($txt['theme_template_error']) ? $txt['theme_template_error'] : 'Unable to load the %s sub template!', (string) $sub_template_name), 'template'));
2488
+	if (function_exists($theme_function)) {
2489
+			$theme_function();
2490
+	} elseif ($fatal === false) {
2491
+			fatal_lang_error('theme_template_error', 'template', array((string) $sub_template_name));
2492
+	} elseif ($fatal !== 'ignore') {
2493
+			die(log_error(sprintf(isset($txt['theme_template_error']) ? $txt['theme_template_error'] : 'Unable to load the %s sub template!', (string) $sub_template_name), 'template'));
2494
+	}
2357 2495
 
2358 2496
 	// Are we showing debugging for templates?  Just make sure not to do it before the doctype...
2359 2497
 	if (allowedTo('admin_forum') && isset($_REQUEST['debug']) && !in_array($sub_template_name, array('init', 'main_below')) && ob_get_length() > 0 && !isset($_REQUEST['xml']))
@@ -2390,8 +2528,9 @@  discard block
 block discarded – undo
2390 2528
 	$params['validate'] = isset($params['validate']) ? $params['validate'] : true;
2391 2529
 
2392 2530
 	// If this is an external file, automatically set this to false.
2393
-	if (!empty($params['external']))
2394
-		$params['minimize'] = false;
2531
+	if (!empty($params['external'])) {
2532
+			$params['minimize'] = false;
2533
+	}
2395 2534
 
2396 2535
 	// Account for shorthand like admin.css?alp21 filenames
2397 2536
 	$has_seed = strpos($fileName, '.css?');
@@ -2408,13 +2547,10 @@  discard block
 block discarded – undo
2408 2547
 			{
2409 2548
 				$fileUrl = $settings['default_theme_url'] . '/css/' . $fileName . ($has_seed ? '' : $params['seed']);
2410 2549
 				$filePath = $settings['default_theme_dir'] . '/css/' . $fileName . ($has_seed ? '' : $params['seed']);
2550
+			} else {
2551
+							$fileUrl = false;
2411 2552
 			}
2412
-
2413
-			else
2414
-				$fileUrl = false;
2415
-		}
2416
-
2417
-		else
2553
+		} else
2418 2554
 		{
2419 2555
 			$fileUrl = $settings[$themeRef . '_url'] . '/css/' . $fileName . ($has_seed ? '' : $params['seed']);
2420 2556
 			$filePath = $settings[$themeRef . '_dir'] . '/css/' . $fileName . ($has_seed ? '' : $params['seed']);
@@ -2429,12 +2565,14 @@  discard block
 block discarded – undo
2429 2565
 	}
2430 2566
 
2431 2567
 	// Add it to the array for use in the template
2432
-	if (!empty($fileName))
2433
-		$context['css_files'][$id] = array('fileUrl' => $fileUrl, 'filePath' => $filePath, 'fileName' => $fileName, 'options' => $params);
2568
+	if (!empty($fileName)) {
2569
+			$context['css_files'][$id] = array('fileUrl' => $fileUrl, 'filePath' => $filePath, 'fileName' => $fileName, 'options' => $params);
2570
+	}
2434 2571
 
2435
-	if (!empty($context['right_to_left']) && !empty($params['rtl']))
2436
-		loadCSSFile($params['rtl'], array_diff_key($params, array('rtl' => 0)));
2437
-}
2572
+	if (!empty($context['right_to_left']) && !empty($params['rtl'])) {
2573
+			loadCSSFile($params['rtl'], array_diff_key($params, array('rtl' => 0)));
2574
+	}
2575
+	}
2438 2576
 
2439 2577
 /**
2440 2578
  * Add a block of inline css code to be executed later
@@ -2451,8 +2589,9 @@  discard block
 block discarded – undo
2451 2589
 	global $context;
2452 2590
 
2453 2591
 	// Gotta add something...
2454
-	if (empty($css))
2455
-		return false;
2592
+	if (empty($css)) {
2593
+			return false;
2594
+	}
2456 2595
 
2457 2596
 	$context['css_header'][] = $css;
2458 2597
 }
@@ -2487,8 +2626,9 @@  discard block
 block discarded – undo
2487 2626
 	$params['validate'] = isset($params['validate']) ? $params['validate'] : true;
2488 2627
 
2489 2628
 	// If this is an external file, automatically set this to false.
2490
-	if (!empty($params['external']))
2491
-		$params['minimize'] = false;
2629
+	if (!empty($params['external'])) {
2630
+			$params['minimize'] = false;
2631
+	}
2492 2632
 
2493 2633
 	// Account for shorthand like admin.js?alp21 filenames
2494 2634
 	$has_seed = strpos($fileName, '.js?');
@@ -2505,16 +2645,12 @@  discard block
 block discarded – undo
2505 2645
 			{
2506 2646
 				$fileUrl = $settings['default_theme_url'] . '/scripts/' . $fileName . ($has_seed ? '' : $params['seed']);
2507 2647
 				$filePath = $settings['default_theme_dir'] . '/scripts/' . $fileName . ($has_seed ? '' : $params['seed']);
2508
-			}
2509
-
2510
-			else
2648
+			} else
2511 2649
 			{
2512 2650
 				$fileUrl = false;
2513 2651
 				$filePath = false;
2514 2652
 			}
2515
-		}
2516
-
2517
-		else
2653
+		} else
2518 2654
 		{
2519 2655
 			$fileUrl = $settings[$themeRef . '_url'] . '/scripts/' . $fileName . ($has_seed ? '' : $params['seed']);
2520 2656
 			$filePath = $settings[$themeRef . '_dir'] . '/scripts/' . $fileName . ($has_seed ? '' : $params['seed']);
@@ -2529,9 +2665,10 @@  discard block
 block discarded – undo
2529 2665
 	}
2530 2666
 
2531 2667
 	// Add it to the array for use in the template
2532
-	if (!empty($fileName))
2533
-		$context['javascript_files'][$id] = array('fileUrl' => $fileUrl, 'filePath' => $filePath, 'fileName' => $fileName, 'options' => $params);
2534
-}
2668
+	if (!empty($fileName)) {
2669
+			$context['javascript_files'][$id] = array('fileUrl' => $fileUrl, 'filePath' => $filePath, 'fileName' => $fileName, 'options' => $params);
2670
+	}
2671
+	}
2535 2672
 
2536 2673
 /**
2537 2674
  * Add a Javascript variable for output later (for feeding text strings and similar to JS)
@@ -2545,9 +2682,10 @@  discard block
 block discarded – undo
2545 2682
 {
2546 2683
 	global $context;
2547 2684
 
2548
-	if (!empty($key) && (!empty($value) || $value === '0'))
2549
-		$context['javascript_vars'][$key] = !empty($escape) ? JavaScriptEscape($value) : $value;
2550
-}
2685
+	if (!empty($key) && (!empty($value) || $value === '0')) {
2686
+			$context['javascript_vars'][$key] = !empty($escape) ? JavaScriptEscape($value) : $value;
2687
+	}
2688
+	}
2551 2689
 
2552 2690
 /**
2553 2691
  * Add a block of inline Javascript code to be executed later
@@ -2564,8 +2702,9 @@  discard block
 block discarded – undo
2564 2702
 {
2565 2703
 	global $context;
2566 2704
 
2567
-	if (empty($javascript))
2568
-		return false;
2705
+	if (empty($javascript)) {
2706
+			return false;
2707
+	}
2569 2708
 
2570 2709
 	$context['javascript_inline'][($defer === true ? 'defer' : 'standard')][] = $javascript;
2571 2710
 }
@@ -2586,15 +2725,18 @@  discard block
 block discarded – undo
2586 2725
 	static $already_loaded = array();
2587 2726
 
2588 2727
 	// Default to the user's language.
2589
-	if ($lang == '')
2590
-		$lang = isset($user_info['language']) ? $user_info['language'] : $language;
2728
+	if ($lang == '') {
2729
+			$lang = isset($user_info['language']) ? $user_info['language'] : $language;
2730
+	}
2591 2731
 
2592 2732
 	// Do we want the English version of language file as fallback?
2593
-	if (empty($modSettings['disable_language_fallback']) && $lang != 'english')
2594
-		loadLanguage($template_name, 'english', false);
2733
+	if (empty($modSettings['disable_language_fallback']) && $lang != 'english') {
2734
+			loadLanguage($template_name, 'english', false);
2735
+	}
2595 2736
 
2596
-	if (!$force_reload && isset($already_loaded[$template_name]) && $already_loaded[$template_name] == $lang)
2597
-		return $lang;
2737
+	if (!$force_reload && isset($already_loaded[$template_name]) && $already_loaded[$template_name] == $lang) {
2738
+			return $lang;
2739
+	}
2598 2740
 
2599 2741
 	// Make sure we have $settings - if not we're in trouble and need to find it!
2600 2742
 	if (empty($settings['default_theme_dir']))
@@ -2605,8 +2747,9 @@  discard block
 block discarded – undo
2605 2747
 
2606 2748
 	// What theme are we in?
2607 2749
 	$theme_name = basename($settings['theme_url']);
2608
-	if (empty($theme_name))
2609
-		$theme_name = 'unknown';
2750
+	if (empty($theme_name)) {
2751
+			$theme_name = 'unknown';
2752
+	}
2610 2753
 
2611 2754
 	// For each file open it up and write it out!
2612 2755
 	foreach (explode('+', $template_name) as $template)
@@ -2648,8 +2791,9 @@  discard block
 block discarded – undo
2648 2791
 				$found = true;
2649 2792
 
2650 2793
 				// setlocale is required for basename() & pathinfo() to work properly on the selected language
2651
-				if (!empty($txt['lang_locale']) && !empty($modSettings['global_character_set']))
2652
-					setlocale(LC_CTYPE, $txt['lang_locale'] . '.' . $modSettings['global_character_set']);
2794
+				if (!empty($txt['lang_locale']) && !empty($modSettings['global_character_set'])) {
2795
+									setlocale(LC_CTYPE, $txt['lang_locale'] . '.' . $modSettings['global_character_set']);
2796
+				}
2653 2797
 
2654 2798
 				break;
2655 2799
 			}
@@ -2689,8 +2833,9 @@  discard block
 block discarded – undo
2689 2833
 	}
2690 2834
 
2691 2835
 	// Keep track of what we're up to soldier.
2692
-	if ($db_show_debug === true)
2693
-		$context['debug']['language_files'][] = $template_name . '.' . $lang . ' (' . $theme_name . ')';
2836
+	if ($db_show_debug === true) {
2837
+			$context['debug']['language_files'][] = $template_name . '.' . $lang . ' (' . $theme_name . ')';
2838
+	}
2694 2839
 
2695 2840
 	// Remember what we have loaded, and in which language.
2696 2841
 	$already_loaded[$template_name] = $lang;
@@ -2736,8 +2881,9 @@  discard block
 block discarded – undo
2736 2881
 				)
2737 2882
 			);
2738 2883
 			// In the EXTREMELY unlikely event this happens, give an error message.
2739
-			if ($smcFunc['db_num_rows']($result) == 0)
2740
-				fatal_lang_error('parent_not_found', 'critical');
2884
+			if ($smcFunc['db_num_rows']($result) == 0) {
2885
+							fatal_lang_error('parent_not_found', 'critical');
2886
+			}
2741 2887
 			while ($row = $smcFunc['db_fetch_assoc']($result))
2742 2888
 			{
2743 2889
 				if (!isset($boards[$row['id_board']]))
@@ -2754,8 +2900,8 @@  discard block
 block discarded – undo
2754 2900
 					);
2755 2901
 				}
2756 2902
 				// If a moderator exists for this board, add that moderator for all children too.
2757
-				if (!empty($row['id_moderator']))
2758
-					foreach ($boards as $id => $dummy)
2903
+				if (!empty($row['id_moderator'])) {
2904
+									foreach ($boards as $id => $dummy)
2759 2905
 					{
2760 2906
 						$boards[$id]['moderators'][$row['id_moderator']] = array(
2761 2907
 							'id' => $row['id_moderator'],
@@ -2763,11 +2909,12 @@  discard block
 block discarded – undo
2763 2909
 							'href' => $scripturl . '?action=profile;u=' . $row['id_moderator'],
2764 2910
 							'link' => '<a href="' . $scripturl . '?action=profile;u=' . $row['id_moderator'] . '">' . $row['real_name'] . '</a>'
2765 2911
 						);
2912
+				}
2766 2913
 					}
2767 2914
 
2768 2915
 				// If a moderator group exists for this board, add that moderator group for all children too
2769
-				if (!empty($row['id_moderator_group']))
2770
-					foreach ($boards as $id => $dummy)
2916
+				if (!empty($row['id_moderator_group'])) {
2917
+									foreach ($boards as $id => $dummy)
2771 2918
 					{
2772 2919
 						$boards[$id]['moderator_groups'][$row['id_moderator_group']] = array(
2773 2920
 							'id' => $row['id_moderator_group'],
@@ -2775,6 +2922,7 @@  discard block
 block discarded – undo
2775 2922
 							'href' => $scripturl . '?action=groups;sa=members;group=' . $row['id_moderator_group'],
2776 2923
 							'link' => '<a href="' . $scripturl . '?action=groups;sa=members;group=' . $row['id_moderator_group'] . '">' . $row['group_name'] . '</a>'
2777 2924
 						);
2925
+				}
2778 2926
 					}
2779 2927
 			}
2780 2928
 			$smcFunc['db_free_result']($result);
@@ -2801,23 +2949,27 @@  discard block
 block discarded – undo
2801 2949
 	if (!$use_cache || ($context['languages'] = cache_get_data('known_languages', !empty($modSettings['cache_enable']) && $modSettings['cache_enable'] < 1 ? 86400 : 3600)) == null)
2802 2950
 	{
2803 2951
 		// If we don't have our ucwords function defined yet, let's load the settings data.
2804
-		if (empty($smcFunc['ucwords']))
2805
-			reloadSettings();
2952
+		if (empty($smcFunc['ucwords'])) {
2953
+					reloadSettings();
2954
+		}
2806 2955
 
2807 2956
 		// If we don't have our theme information yet, let's get it.
2808
-		if (empty($settings['default_theme_dir']))
2809
-			loadTheme(0, false);
2957
+		if (empty($settings['default_theme_dir'])) {
2958
+					loadTheme(0, false);
2959
+		}
2810 2960
 
2811 2961
 		// Default language directories to try.
2812 2962
 		$language_directories = array(
2813 2963
 			$settings['default_theme_dir'] . '/languages',
2814 2964
 		);
2815
-		if (!empty($settings['actual_theme_dir']) && $settings['actual_theme_dir'] != $settings['default_theme_dir'])
2816
-			$language_directories[] = $settings['actual_theme_dir'] . '/languages';
2965
+		if (!empty($settings['actual_theme_dir']) && $settings['actual_theme_dir'] != $settings['default_theme_dir']) {
2966
+					$language_directories[] = $settings['actual_theme_dir'] . '/languages';
2967
+		}
2817 2968
 
2818 2969
 		// We possibly have a base theme directory.
2819
-		if (!empty($settings['base_theme_dir']))
2820
-			$language_directories[] = $settings['base_theme_dir'] . '/languages';
2970
+		if (!empty($settings['base_theme_dir'])) {
2971
+					$language_directories[] = $settings['base_theme_dir'] . '/languages';
2972
+		}
2821 2973
 
2822 2974
 		// Remove any duplicates.
2823 2975
 		$language_directories = array_unique($language_directories);
@@ -2831,20 +2983,21 @@  discard block
 block discarded – undo
2831 2983
 		foreach ($language_directories as $language_dir)
2832 2984
 		{
2833 2985
 			// Can't look in here... doesn't exist!
2834
-			if (!file_exists($language_dir))
2835
-				continue;
2986
+			if (!file_exists($language_dir)) {
2987
+							continue;
2988
+			}
2836 2989
 
2837 2990
 			$dir = dir($language_dir);
2838 2991
 			while ($entry = $dir->read())
2839 2992
 			{
2840 2993
 				// Look for the index language file... For good measure skip any "index.language-utf8.php" files
2841
-				if (!preg_match('~^index\.(.+[^-utf8])\.php$~', $entry, $matches))
2842
-					continue;
2843
-
2844
-				if (!empty($langList) && !empty($langList[$matches[1]]))
2845
-					$langName = $langList[$matches[1]];
2994
+				if (!preg_match('~^index\.(.+[^-utf8])\.php$~', $entry, $matches)) {
2995
+									continue;
2996
+				}
2846 2997
 
2847
-				else
2998
+				if (!empty($langList) && !empty($langList[$matches[1]])) {
2999
+									$langName = $langList[$matches[1]];
3000
+				} else
2848 3001
 				{
2849 3002
 					$langName = $smcFunc['ucwords'](strtr($matches[1], array('_' => ' ')));
2850 3003
 
@@ -2885,12 +3038,14 @@  discard block
 block discarded – undo
2885 3038
 		}
2886 3039
 
2887 3040
 		// Do we need to store the lang list?
2888
-		if (empty($langList))
2889
-			updateSettings(array('langList' => $smcFunc['json_encode']($catchLang)));
3041
+		if (empty($langList)) {
3042
+					updateSettings(array('langList' => $smcFunc['json_encode']($catchLang)));
3043
+		}
2890 3044
 
2891 3045
 		// Let's cash in on this deal.
2892
-		if (!empty($modSettings['cache_enable']))
2893
-			cache_put_data('known_languages', $context['languages'], !empty($modSettings['cache_enable']) && $modSettings['cache_enable'] < 1 ? 86400 : 3600);
3046
+		if (!empty($modSettings['cache_enable'])) {
3047
+					cache_put_data('known_languages', $context['languages'], !empty($modSettings['cache_enable']) && $modSettings['cache_enable'] < 1 ? 86400 : 3600);
3048
+		}
2894 3049
 	}
2895 3050
 
2896 3051
 	return $context['languages'];
@@ -2913,8 +3068,9 @@  discard block
 block discarded – undo
2913 3068
 	global $modSettings, $options, $txt;
2914 3069
 	static $censor_vulgar = null, $censor_proper;
2915 3070
 
2916
-	if ((!empty($options['show_no_censored']) && !empty($modSettings['allow_no_censored']) && !$force) || empty($modSettings['censor_vulgar']) || trim($text) === '')
2917
-		return $text;
3071
+	if ((!empty($options['show_no_censored']) && !empty($modSettings['allow_no_censored']) && !$force) || empty($modSettings['censor_vulgar']) || trim($text) === '') {
3072
+			return $text;
3073
+	}
2918 3074
 
2919 3075
 	// If they haven't yet been loaded, load them.
2920 3076
 	if ($censor_vulgar == null)
@@ -2942,9 +3098,9 @@  discard block
 block discarded – undo
2942 3098
 	{
2943 3099
 		$func = !empty($modSettings['censorIgnoreCase']) ? 'str_ireplace' : 'str_replace';
2944 3100
 		$text = $func($censor_vulgar, $censor_proper, $text);
3101
+	} else {
3102
+			$text = preg_replace($censor_vulgar, $censor_proper, $text);
2945 3103
 	}
2946
-	else
2947
-		$text = preg_replace($censor_vulgar, $censor_proper, $text);
2948 3104
 
2949 3105
 	return $text;
2950 3106
 }
@@ -2970,38 +3126,42 @@  discard block
 block discarded – undo
2970 3126
 	@ini_set('track_errors', '1');
2971 3127
 
2972 3128
 	// Don't include the file more than once, if $once is true.
2973
-	if ($once && in_array($filename, $templates))
2974
-		return;
3129
+	if ($once && in_array($filename, $templates)) {
3130
+			return;
3131
+	}
2975 3132
 	// Add this file to the include list, whether $once is true or not.
2976
-	else
2977
-		$templates[] = $filename;
3133
+	else {
3134
+			$templates[] = $filename;
3135
+	}
2978 3136
 
2979 3137
 	// Are we going to use eval?
2980 3138
 	if (empty($modSettings['disableTemplateEval']))
2981 3139
 	{
2982 3140
 		$file_found = file_exists($filename) && eval('?' . '>' . rtrim(file_get_contents($filename))) !== false;
2983 3141
 		$settings['current_include_filename'] = $filename;
2984
-	}
2985
-	else
3142
+	} else
2986 3143
 	{
2987 3144
 		$file_found = file_exists($filename);
2988 3145
 
2989
-		if ($once && $file_found)
2990
-			require_once($filename);
2991
-		elseif ($file_found)
2992
-			require($filename);
3146
+		if ($once && $file_found) {
3147
+					require_once($filename);
3148
+		} elseif ($file_found) {
3149
+					require($filename);
3150
+		}
2993 3151
 	}
2994 3152
 
2995 3153
 	if ($file_found !== true)
2996 3154
 	{
2997 3155
 		ob_end_clean();
2998
-		if (!empty($modSettings['enableCompressedOutput']))
2999
-			@ob_start('ob_gzhandler');
3000
-		else
3001
-			ob_start();
3156
+		if (!empty($modSettings['enableCompressedOutput'])) {
3157
+					@ob_start('ob_gzhandler');
3158
+		} else {
3159
+					ob_start();
3160
+		}
3002 3161
 
3003
-		if (isset($_GET['debug']))
3004
-			header('Content-Type: application/xhtml+xml; charset=' . (empty($context['character_set']) ? 'ISO-8859-1' : $context['character_set']));
3162
+		if (isset($_GET['debug'])) {
3163
+					header('Content-Type: application/xhtml+xml; charset=' . (empty($context['character_set']) ? 'ISO-8859-1' : $context['character_set']));
3164
+		}
3005 3165
 
3006 3166
 		// Don't cache error pages!!
3007 3167
 		header('Expires: Mon, 26 Jul 1997 05:00:00 GMT');
@@ -3020,12 +3180,13 @@  discard block
 block discarded – undo
3020 3180
 		echo '<!DOCTYPE html>
3021 3181
 <html', !empty($context['right_to_left']) ? ' dir="rtl"' : '', '>
3022 3182
 	<head>';
3023
-		if (isset($context['character_set']))
3024
-			echo '
3183
+		if (isset($context['character_set'])) {
3184
+					echo '
3025 3185
 		<meta charset="', $context['character_set'], '">';
3186
+		}
3026 3187
 
3027
-		if (!empty($maintenance) && !allowedTo('admin_forum'))
3028
-			echo '
3188
+		if (!empty($maintenance) && !allowedTo('admin_forum')) {
3189
+					echo '
3029 3190
 		<title>', $mtitle, '</title>
3030 3191
 	</head>
3031 3192
 	<body>
@@ -3033,8 +3194,8 @@  discard block
 block discarded – undo
3033 3194
 		', $mmessage, '
3034 3195
 	</body>
3035 3196
 </html>';
3036
-		elseif (!allowedTo('admin_forum'))
3037
-			echo '
3197
+		} elseif (!allowedTo('admin_forum')) {
3198
+					echo '
3038 3199
 		<title>', $txt['template_parse_error'], '</title>
3039 3200
 	</head>
3040 3201
 	<body>
@@ -3042,16 +3203,18 @@  discard block
 block discarded – undo
3042 3203
 		', $txt['template_parse_error_message'], '
3043 3204
 	</body>
3044 3205
 </html>';
3045
-		else
3206
+		} else
3046 3207
 		{
3047 3208
 			require_once($sourcedir . '/Subs-Package.php');
3048 3209
 
3049 3210
 			$error = fetch_web_data($boardurl . strtr($filename, array($boarddir => '', strtr($boarddir, '\\', '/') => '')));
3050 3211
 			$error_array = error_get_last();
3051
-			if (empty($error) && ini_get('track_errors') && !empty($error_array))
3052
-				$error = $error_array['message'];
3053
-			if (empty($error))
3054
-				$error = $txt['template_parse_errmsg'];
3212
+			if (empty($error) && ini_get('track_errors') && !empty($error_array)) {
3213
+							$error = $error_array['message'];
3214
+			}
3215
+			if (empty($error)) {
3216
+							$error = $txt['template_parse_errmsg'];
3217
+			}
3055 3218
 
3056 3219
 			$error = strtr($error, array('<b>' => '<strong>', '</b>' => '</strong>'));
3057 3220
 
@@ -3062,11 +3225,12 @@  discard block
 block discarded – undo
3062 3225
 		<h3>', $txt['template_parse_error'], '</h3>
3063 3226
 		', sprintf($txt['template_parse_error_details'], strtr($filename, array($boarddir => '', strtr($boarddir, '\\', '/') => '')));
3064 3227
 
3065
-			if (!empty($error))
3066
-				echo '
3228
+			if (!empty($error)) {
3229
+							echo '
3067 3230
 		<hr>
3068 3231
 
3069 3232
 		<div style="margin: 0 20px;"><pre>', strtr(strtr($error, array('<strong>' . $boarddir => '<strong>...', '<strong>' . strtr($boarddir, '\\', '/') => '<strong>...')), '\\', '/'), '</pre></div>';
3233
+			}
3070 3234
 
3071 3235
 			// I know, I know... this is VERY COMPLICATED.  Still, it's good.
3072 3236
 			if (preg_match('~ <strong>(\d+)</strong><br( /)?' . '>$~i', $error, $match) != 0)
@@ -3076,10 +3240,11 @@  discard block
 block discarded – undo
3076 3240
 				$data2 = preg_split('~\<br( /)?\>~', $data2);
3077 3241
 
3078 3242
 				// Fix the PHP code stuff...
3079
-				if (!isBrowser('gecko'))
3080
-					$data2 = str_replace("\t", '<span style="white-space: pre;">' . "\t" . '</span>', $data2);
3081
-				else
3082
-					$data2 = str_replace('<pre style="display: inline;">' . "\t" . '</pre>', "\t", $data2);
3243
+				if (!isBrowser('gecko')) {
3244
+									$data2 = str_replace("\t", '<span style="white-space: pre;">' . "\t" . '</span>', $data2);
3245
+				} else {
3246
+									$data2 = str_replace('<pre style="display: inline;">' . "\t" . '</pre>', "\t", $data2);
3247
+				}
3083 3248
 
3084 3249
 				// Now we get to work around a bug in PHP where it doesn't escape <br>s!
3085 3250
 				$j = -1;
@@ -3087,8 +3252,9 @@  discard block
 block discarded – undo
3087 3252
 				{
3088 3253
 					$j++;
3089 3254
 
3090
-					if (substr_count($line, '<br>') == 0)
3091
-						continue;
3255
+					if (substr_count($line, '<br>') == 0) {
3256
+											continue;
3257
+					}
3092 3258
 
3093 3259
 					$n = substr_count($line, '<br>');
3094 3260
 					for ($i = 0; $i < $n; $i++)
@@ -3107,38 +3273,42 @@  discard block
 block discarded – undo
3107 3273
 				// Figure out what the color coding was before...
3108 3274
 				$line = max($match[1] - 9, 1);
3109 3275
 				$last_line = '';
3110
-				for ($line2 = $line - 1; $line2 > 1; $line2--)
3111
-					if (strpos($data2[$line2], '<') !== false)
3276
+				for ($line2 = $line - 1; $line2 > 1; $line2--) {
3277
+									if (strpos($data2[$line2], '<') !== false)
3112 3278
 					{
3113 3279
 						if (preg_match('~(<[^/>]+>)[^<]*$~', $data2[$line2], $color_match) != 0)
3114 3280
 							$last_line = $color_match[1];
3281
+				}
3115 3282
 						break;
3116 3283
 					}
3117 3284
 
3118 3285
 				// Show the relevant lines...
3119 3286
 				for ($n = min($match[1] + 4, count($data2) + 1); $line <= $n; $line++)
3120 3287
 				{
3121
-					if ($line == $match[1])
3122
-						echo '</pre><div style="background-color: #ffb0b5;"><pre style="margin: 0;">';
3288
+					if ($line == $match[1]) {
3289
+											echo '</pre><div style="background-color: #ffb0b5;"><pre style="margin: 0;">';
3290
+					}
3123 3291
 
3124 3292
 					echo '<span style="color: black;">', sprintf('%' . strlen($n) . 's', $line), ':</span> ';
3125
-					if (isset($data2[$line]) && $data2[$line] != '')
3126
-						echo substr($data2[$line], 0, 2) == '</' ? preg_replace('~^</[^>]+>~', '', $data2[$line]) : $last_line . $data2[$line];
3293
+					if (isset($data2[$line]) && $data2[$line] != '') {
3294
+											echo substr($data2[$line], 0, 2) == '</' ? preg_replace('~^</[^>]+>~', '', $data2[$line]) : $last_line . $data2[$line];
3295
+					}
3127 3296
 
3128 3297
 					if (isset($data2[$line]) && preg_match('~(<[^/>]+>)[^<]*$~', $data2[$line], $color_match) != 0)
3129 3298
 					{
3130 3299
 						$last_line = $color_match[1];
3131 3300
 						echo '</', substr($last_line, 1, 4), '>';
3301
+					} elseif ($last_line != '' && strpos($data2[$line], '<') !== false) {
3302
+											$last_line = '';
3303
+					} elseif ($last_line != '' && $data2[$line] != '') {
3304
+											echo '</', substr($last_line, 1, 4), '>';
3132 3305
 					}
3133
-					elseif ($last_line != '' && strpos($data2[$line], '<') !== false)
3134
-						$last_line = '';
3135
-					elseif ($last_line != '' && $data2[$line] != '')
3136
-						echo '</', substr($last_line, 1, 4), '>';
3137 3306
 
3138
-					if ($line == $match[1])
3139
-						echo '</pre></div><pre style="margin: 0;">';
3140
-					else
3141
-						echo "\n";
3307
+					if ($line == $match[1]) {
3308
+											echo '</pre></div><pre style="margin: 0;">';
3309
+					} else {
3310
+											echo "\n";
3311
+					}
3142 3312
 				}
3143 3313
 
3144 3314
 				echo '</pre></div>';
@@ -3162,8 +3332,9 @@  discard block
 block discarded – undo
3162 3332
 	global $db_type, $db_name, $ssi_db_user, $ssi_db_passwd, $sourcedir, $db_prefix, $db_port;
3163 3333
 
3164 3334
 	// Figure out what type of database we are using.
3165
-	if (empty($db_type) || !file_exists($sourcedir . '/Subs-Db-' . $db_type . '.php'))
3166
-		$db_type = 'mysql';
3335
+	if (empty($db_type) || !file_exists($sourcedir . '/Subs-Db-' . $db_type . '.php')) {
3336
+			$db_type = 'mysql';
3337
+	}
3167 3338
 
3168 3339
 	// Load the file for the database.
3169 3340
 	require_once($sourcedir . '/Subs-Db-' . $db_type . '.php');
@@ -3171,8 +3342,9 @@  discard block
 block discarded – undo
3171 3342
 	$db_options = array();
3172 3343
 
3173 3344
 	// Add in the port if needed
3174
-	if (!empty($db_port))
3175
-		$db_options['port'] = $db_port;
3345
+	if (!empty($db_port)) {
3346
+			$db_options['port'] = $db_port;
3347
+	}
3176 3348
 
3177 3349
 	// If we are in SSI try them first, but don't worry if it doesn't work, we have the normal username and password we can use.
3178 3350
 	if (SMF == 'SSI' && !empty($ssi_db_user) && !empty($ssi_db_passwd))
@@ -3191,13 +3363,15 @@  discard block
 block discarded – undo
3191 3363
 	}
3192 3364
 
3193 3365
 	// Safe guard here, if there isn't a valid connection lets put a stop to it.
3194
-	if (!$db_connection)
3195
-		display_db_error();
3366
+	if (!$db_connection) {
3367
+			display_db_error();
3368
+	}
3196 3369
 
3197 3370
 	// If in SSI mode fix up the prefix.
3198
-	if (SMF == 'SSI')
3199
-		db_fix_prefix($db_prefix, $db_name);
3200
-}
3371
+	if (SMF == 'SSI') {
3372
+			db_fix_prefix($db_prefix, $db_name);
3373
+	}
3374
+	}
3201 3375
 
3202 3376
 /**
3203 3377
  * Try to load up a supported caching method. This is saved in $cacheAPI if we are not overriding it.
@@ -3211,10 +3385,11 @@  discard block
 block discarded – undo
3211 3385
 	global $sourcedir, $cacheAPI, $cache_accelerator;
3212 3386
 
3213 3387
 	// Not overriding this and we have a cacheAPI, send it back.
3214
-	if (empty($overrideCache) && is_object($cacheAPI))
3215
-		return $cacheAPI;
3216
-	elseif (is_null($cacheAPI))
3217
-		$cacheAPI = false;
3388
+	if (empty($overrideCache) && is_object($cacheAPI)) {
3389
+			return $cacheAPI;
3390
+	} elseif (is_null($cacheAPI)) {
3391
+			$cacheAPI = false;
3392
+	}
3218 3393
 
3219 3394
 	// Make sure our class is in session.
3220 3395
 	require_once($sourcedir . '/Class-CacheAPI.php');
@@ -3235,8 +3410,9 @@  discard block
 block discarded – undo
3235 3410
 		if (!$testAPI->isSupported())
3236 3411
 		{
3237 3412
 			// Can we save ourselves?
3238
-			if (!empty($fallbackSMF) && is_null($overrideCache) && $tryAccelerator != 'smf')
3239
-				return loadCacheAccelerator(null, false);
3413
+			if (!empty($fallbackSMF) && is_null($overrideCache) && $tryAccelerator != 'smf') {
3414
+							return loadCacheAccelerator(null, false);
3415
+			}
3240 3416
 			return false;
3241 3417
 		}
3242 3418
 
@@ -3248,9 +3424,9 @@  discard block
 block discarded – undo
3248 3424
 		{
3249 3425
 			$cacheAPI = $testAPI;
3250 3426
 			return $cacheAPI;
3427
+		} else {
3428
+					return $testAPI;
3251 3429
 		}
3252
-		else
3253
-			return $testAPI;
3254 3430
 	}
3255 3431
 }
3256 3432
 
@@ -3270,8 +3446,9 @@  discard block
 block discarded – undo
3270 3446
 
3271 3447
 	// @todo Why are we doing this if caching is disabled?
3272 3448
 
3273
-	if (function_exists('call_integration_hook'))
3274
-		call_integration_hook('pre_cache_quick_get', array(&$key, &$file, &$function, &$params, &$level));
3449
+	if (function_exists('call_integration_hook')) {
3450
+			call_integration_hook('pre_cache_quick_get', array(&$key, &$file, &$function, &$params, &$level));
3451
+	}
3275 3452
 
3276 3453
 	/* Refresh the cache if either:
3277 3454
 		1. Caching is disabled.
@@ -3285,16 +3462,19 @@  discard block
 block discarded – undo
3285 3462
 		require_once($sourcedir . '/' . $file);
3286 3463
 		$cache_block = call_user_func_array($function, $params);
3287 3464
 
3288
-		if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= $level)
3289
-			cache_put_data($key, $cache_block, $cache_block['expires'] - time());
3465
+		if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= $level) {
3466
+					cache_put_data($key, $cache_block, $cache_block['expires'] - time());
3467
+		}
3290 3468
 	}
3291 3469
 
3292 3470
 	// Some cached data may need a freshening up after retrieval.
3293
-	if (!empty($cache_block['post_retri_eval']))
3294
-		eval($cache_block['post_retri_eval']);
3471
+	if (!empty($cache_block['post_retri_eval'])) {
3472
+			eval($cache_block['post_retri_eval']);
3473
+	}
3295 3474
 
3296
-	if (function_exists('call_integration_hook'))
3297
-		call_integration_hook('post_cache_quick_get', array(&$cache_block));
3475
+	if (function_exists('call_integration_hook')) {
3476
+			call_integration_hook('post_cache_quick_get', array(&$cache_block));
3477
+	}
3298 3478
 
3299 3479
 	return $cache_block['data'];
3300 3480
 }
@@ -3321,8 +3501,9 @@  discard block
 block discarded – undo
3321 3501
 	global $smcFunc, $cache_enable, $cacheAPI;
3322 3502
 	global $cache_hits, $cache_count, $db_show_debug;
3323 3503
 
3324
-	if (empty($cache_enable) || empty($cacheAPI))
3325
-		return;
3504
+	if (empty($cache_enable) || empty($cacheAPI)) {
3505
+			return;
3506
+	}
3326 3507
 
3327 3508
 	$cache_count = isset($cache_count) ? $cache_count + 1 : 1;
3328 3509
 	if (isset($db_show_debug) && $db_show_debug === true)
@@ -3335,12 +3516,14 @@  discard block
 block discarded – undo
3335 3516
 	$value = $value === null ? null : (isset($smcFunc['json_encode']) ? $smcFunc['json_encode']($value) : json_encode($value));
3336 3517
 	$cacheAPI->putData($key, $value, $ttl);
3337 3518
 
3338
-	if (function_exists('call_integration_hook'))
3339
-		call_integration_hook('cache_put_data', array(&$key, &$value, &$ttl));
3519
+	if (function_exists('call_integration_hook')) {
3520
+			call_integration_hook('cache_put_data', array(&$key, &$value, &$ttl));
3521
+	}
3340 3522
 
3341
-	if (isset($db_show_debug) && $db_show_debug === true)
3342
-		$cache_hits[$cache_count]['t'] = array_sum(explode(' ', microtime())) - array_sum(explode(' ', $st));
3343
-}
3523
+	if (isset($db_show_debug) && $db_show_debug === true) {
3524
+			$cache_hits[$cache_count]['t'] = array_sum(explode(' ', microtime())) - array_sum(explode(' ', $st));
3525
+	}
3526
+	}
3344 3527
 
3345 3528
 /**
3346 3529
  * Gets the value from the cache specified by key, so long as it is not older than ttl seconds.
@@ -3356,8 +3539,9 @@  discard block
 block discarded – undo
3356 3539
 	global $smcFunc, $cache_enable, $cacheAPI;
3357 3540
 	global $cache_hits, $cache_count, $cache_misses, $cache_count_misses, $db_show_debug;
3358 3541
 
3359
-	if (empty($cache_enable) || empty($cacheAPI))
3360
-		return;
3542
+	if (empty($cache_enable) || empty($cacheAPI)) {
3543
+			return;
3544
+	}
3361 3545
 
3362 3546
 	$cache_count = isset($cache_count) ? $cache_count + 1 : 1;
3363 3547
 	if (isset($db_show_debug) && $db_show_debug === true)
@@ -3377,16 +3561,18 @@  discard block
 block discarded – undo
3377 3561
 
3378 3562
 		if (empty($value))
3379 3563
 		{
3380
-			if (!is_array($cache_misses))
3381
-				$cache_misses = array();
3564
+			if (!is_array($cache_misses)) {
3565
+							$cache_misses = array();
3566
+			}
3382 3567
 
3383 3568
 			$cache_count_misses = isset($cache_count_misses) ? $cache_count_misses + 1 : 1;
3384 3569
 			$cache_misses[$cache_count_misses] = array('k' => $original_key, 'd' => 'get');
3385 3570
 		}
3386 3571
 	}
3387 3572
 
3388
-	if (function_exists('call_integration_hook') && isset($value))
3389
-		call_integration_hook('cache_get_data', array(&$key, &$ttl, &$value));
3573
+	if (function_exists('call_integration_hook') && isset($value)) {
3574
+			call_integration_hook('cache_get_data', array(&$key, &$ttl, &$value));
3575
+	}
3390 3576
 
3391 3577
 	return empty($value) ? null : (isset($smcFunc['json_encode']) ? $smcFunc['json_decode']($value, true) : smf_json_decode($value, true));
3392 3578
 }
@@ -3408,8 +3594,9 @@  discard block
 block discarded – undo
3408 3594
 	global $cacheAPI;
3409 3595
 
3410 3596
 	// If we can't get to the API, can't do this.
3411
-	if (empty($cacheAPI))
3412
-		return;
3597
+	if (empty($cacheAPI)) {
3598
+			return;
3599
+	}
3413 3600
 
3414 3601
 	// Ask the API to do the heavy lifting. cleanCache also calls invalidateCache to be sure.
3415 3602
 	$cacheAPI->cleanCache($type);
@@ -3434,8 +3621,9 @@  discard block
 block discarded – undo
3434 3621
 	global $modSettings, $boardurl, $smcFunc, $image_proxy_enabled, $image_proxy_secret;
3435 3622
 
3436 3623
 	// Come on!
3437
-	if (empty($data))
3438
-		return array();
3624
+	if (empty($data)) {
3625
+			return array();
3626
+	}
3439 3627
 
3440 3628
 	// Set a nice default var.
3441 3629
 	$image = '';
@@ -3443,11 +3631,11 @@  discard block
 block discarded – undo
3443 3631
 	// Gravatar has been set as mandatory!
3444 3632
 	if (!empty($modSettings['gravatarOverride']))
3445 3633
 	{
3446
-		if (!empty($modSettings['gravatarAllowExtraEmail']) && !empty($data['avatar']) && stristr($data['avatar'], 'gravatar://'))
3447
-			$image = get_gravatar_url($smcFunc['substr']($data['avatar'], 11));
3448
-
3449
-		else if (!empty($data['email']))
3450
-			$image = get_gravatar_url($data['email']);
3634
+		if (!empty($modSettings['gravatarAllowExtraEmail']) && !empty($data['avatar']) && stristr($data['avatar'], 'gravatar://')) {
3635
+					$image = get_gravatar_url($smcFunc['substr']($data['avatar'], 11));
3636
+		} else if (!empty($data['email'])) {
3637
+					$image = get_gravatar_url($data['email']);
3638
+		}
3451 3639
 	}
3452 3640
 
3453 3641
 	// Look if the user has a gravatar field or has set an external url as avatar.
@@ -3459,54 +3647,60 @@  discard block
 block discarded – undo
3459 3647
 			// Gravatar.
3460 3648
 			if (stristr($data['avatar'], 'gravatar://'))
3461 3649
 			{
3462
-				if ($data['avatar'] == 'gravatar://')
3463
-					$image = get_gravatar_url($data['email']);
3464
-
3465
-				elseif (!empty($modSettings['gravatarAllowExtraEmail']))
3466
-					$image = get_gravatar_url($smcFunc['substr']($data['avatar'], 11));
3650
+				if ($data['avatar'] == 'gravatar://') {
3651
+									$image = get_gravatar_url($data['email']);
3652
+				} elseif (!empty($modSettings['gravatarAllowExtraEmail'])) {
3653
+									$image = get_gravatar_url($smcFunc['substr']($data['avatar'], 11));
3654
+				}
3467 3655
 			}
3468 3656
 
3469 3657
 			// External url.
3470 3658
 			else
3471 3659
 			{
3472 3660
 				// Using ssl?
3473
-				if (!empty($modSettings['force_ssl']) && $image_proxy_enabled && stripos($data['avatar'], 'http://') !== false)
3474
-					$image = strtr($boardurl, array('http://' => 'https://')) . '/proxy.php?request=' . urlencode($data['avatar']) . '&hash=' . md5($data['avatar'] . $image_proxy_secret);
3661
+				if (!empty($modSettings['force_ssl']) && $image_proxy_enabled && stripos($data['avatar'], 'http://') !== false) {
3662
+									$image = strtr($boardurl, array('http://' => 'https://')) . '/proxy.php?request=' . urlencode($data['avatar']) . '&hash=' . md5($data['avatar'] . $image_proxy_secret);
3663
+				}
3475 3664
 
3476 3665
 				// Just a plain external url.
3477
-				else
3478
-					$image = (stristr($data['avatar'], 'http://') || stristr($data['avatar'], 'https://')) ? $data['avatar'] : $modSettings['avatar_url'] . '/' . $data['avatar'];
3666
+				else {
3667
+									$image = (stristr($data['avatar'], 'http://') || stristr($data['avatar'], 'https://')) ? $data['avatar'] : $modSettings['avatar_url'] . '/' . $data['avatar'];
3668
+				}
3479 3669
 			}
3480 3670
 		}
3481 3671
 
3482 3672
 		// Perhaps this user has an attachment as avatar...
3483
-		else if (!empty($data['filename']))
3484
-			$image = $modSettings['custom_avatar_url'] . '/' . $data['filename'];
3673
+		else if (!empty($data['filename'])) {
3674
+					$image = $modSettings['custom_avatar_url'] . '/' . $data['filename'];
3675
+		}
3485 3676
 
3486 3677
 		// Right... no avatar... use our default image.
3487
-		else
3488
-			$image = $modSettings['avatar_url'] . '/default.png';
3678
+		else {
3679
+					$image = $modSettings['avatar_url'] . '/default.png';
3680
+		}
3489 3681
 	}
3490 3682
 
3491 3683
 	call_integration_hook('integrate_set_avatar_data', array(&$image, &$data));
3492 3684
 
3493 3685
 	// At this point in time $image has to be filled unless you chose to force gravatar and the user doesn't have the needed data to retrieve it... thus a check for !empty() is still needed.
3494
-	if (!empty($image))
3495
-		return array(
3686
+	if (!empty($image)) {
3687
+			return array(
3496 3688
 			'name' => !empty($data['avatar']) ? $data['avatar'] : '',
3497 3689
 			'image' => '<img class="avatar" src="' . $image . '" />',
3498 3690
 			'href' => $image,
3499 3691
 			'url' => $image,
3500 3692
 		);
3693
+	}
3501 3694
 
3502 3695
 	// Fallback to make life easier for everyone...
3503
-	else
3504
-		return array(
3696
+	else {
3697
+			return array(
3505 3698
 			'name' => '',
3506 3699
 			'image' => '',
3507 3700
 			'href' => '',
3508 3701
 			'url' => '',
3509 3702
 		);
3510
-}
3703
+	}
3704
+	}
3511 3705
 
3512 3706
 ?>
3513 3707
\ No newline at end of file
Please login to merge, or discard this patch.