smf_strftime()

Complexity

Conditions	40
Paths	2368

Size

Total Lines	291
Code Lines	182

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
function smf_strftime(string $format, int $timestamp = null, string $tzid = null)
{
	global $txt, $smcFunc, $sourcedir;

	if (!isset($timestamp))
		$timestamp = time();

	if (!isset($tzid))
		$tzid = getUserTimezone();

	// In case this function is called before reloadSettings().
	if (!isset($smcFunc['strtoupper']))
	{
		if (function_exists('mb_strtoupper'))
		{
			$smcFunc['strtoupper'] = 'mb_strtoupper';
			$smcFunc['strtolower'] = 'mb_strtolower';
		}
		elseif (isset($sourcedir))
		{
			require_once($sourcedir . '/Subs-Charset.php');
			$smcFunc['strtoupper'] = 'utf8_strtoupper';
			$smcFunc['strtolower'] = 'utf8_strtolower';
		}
		else
		{
			$smcFunc['strtoupper'] = 'strtoupper';
			$smcFunc['strtolower'] = 'strtolower';
		}
	}

	// A couple substitutions to make life easier.
	$format = strtr($format, array(
		'%h' => '%b',
		'%r' => '%I:%M:%S %p',
	));

	$format_equivalents = array(
		// Day
		'a' => 'D',
		'A' => 'l',
		'e' => 'j', // Complex: sprintf to prepend whitespace.
		'd' => 'd',
		'j' => 'z', // Complex: must add one and then sprintf to prepend zeros.
		'u' => 'N',
		'w' => 'w',
		// Week
		'U' => 'z_w_0', // Complex: calculated from these other values.
		'V' => 'W',
		'W' => 'z_w_1', // Complex: calculated from these other values.
		// Month
		'b' => 'M',
		'B' => 'F',
		'm' => 'm',
		// Year
		'C' => 'Y', // Complex: Get 'Y' then truncate to first two digits.
		'g' => 'o', // Complex: Get 'o' then truncate to last two digits.
		'G' => 'o', // Complex: Get 'o' then sprintf to ensure four digits.
		'y' => 'y',
		'Y' => 'Y',
		// Time
		'H' => 'H',
		'k' => 'G',
		'I' => 'h',
		'l' => 'g',
		'M' => 'i',
		'p' => 'A',
		'P' => 'a',
		'R' => 'H:i',
		'S' => 's',
		'T' => 'H:i:s',
		'X' => 'H:i:s', // No direct equivalent possible, so use ISO format.
		'z' => 'O',
		'Z' => 'T',
		// Time and Date Stamps
		'c' => 'c', // No direct equivalent possible, so use ISO format.
		'D' => 'm/d/y',
		'F' => 'Y-m-d',
		's' => 'U',
		'x' => 'Y-m-d', // No direct equivalent possible, so use ISO format.
		// Miscellaneous
		'n' => "\n",
		't' => "\t",
		'%' => '%',
	);

	$parts = preg_split('/%(' . implode('|', array_keys($format_equivalents)) . ')/', $format, 0, PREG_SPLIT_DELIM_CAPTURE);

	$placeholders = array();
	$complex = false;

	for ($i = 0; $i < count($parts); $i++)

It seems like you are calling the size function count() as part of the test condition. You might want to compute the size beforehand, and not on each iteration.

	{
		// Parts that are not strftime formats.
		if ($i % 2 === 0 || !isset($format_equivalents[$parts[$i]]))
		{
			if ($parts[$i] === '')
				continue;

			$placeholder = "\xEE\x84\x80" . $i . "\xEE\x84\x81";

			$placeholders[$placeholder] = $parts[$i];
			$parts[$i] = $placeholder;
		}
		// Parts that need localized strings.
		elseif (in_array($parts[$i], array('a', 'A', 'b', 'B')))
		{
			switch ($parts[$i])
			{
				case 'a':
					$min = 0;
					$max = 6;
					$key = 'days_short';
					$f = 'w';
					$placeholder_end = "\xEE\x84\x83";

					break;

				case 'A':
					$min = 0;
					$max = 6;
					$key = 'days';
					$f = 'w';
					$placeholder_end = "\xEE\x84\x82";

					break;

				case 'b':
					$min = 1;
					$max = 12;
					$key = 'months_short';
					$f = 'n';
					$placeholder_end = "\xEE\x84\x85";

					break;

				case 'B':
					$min = 1;
					$max = 12;
					$key = 'months';
					$f = 'n';
					$placeholder_end = "\xEE\x84\x84";

					break;
			}

			$placeholder = "\xEE\x84\x80" . $f . $placeholder_end;

The variable $f does not seem to be defined for all execution paths leading up to this point.

The variable $placeholder_end does not seem to be defined for all execution paths leading up to this point.

			// Check whether $txt contains all expected strings.
			// If not, use English default.
			$txt_strings_exist = true;
			for ($num = $min; $num <= $max; $num++)

The variable $min does not seem to be defined for all execution paths leading up to this point.

The variable $max does not seem to be defined for all execution paths leading up to this point.

			{
				if (!isset($txt[$key][$num]))

The variable $key does not seem to be defined for all execution paths leading up to this point.

				{
					$txt_strings_exist = false;
					break;
				}
				else
					$placeholders[str_replace($f, $num, $placeholder)] = $txt[$key][$num];
			}

			$parts[$i] = $txt_strings_exist ? $placeholder : $format_equivalents[$parts[$i]];
		}
		elseif (in_array($parts[$i], array('p', 'P')))
		{
			if (!isset($txt['time_am']) || !isset($txt['time_pm']))
				continue;

			$placeholder = "\xEE\x84\x90" . $format_equivalents[$parts[$i]] . "\xEE\x84\x91";

			switch ($parts[$i])
			{
				// Lower case
				case 'p':
					$placeholders[str_replace($format_equivalents[$parts[$i]], 'AM', $placeholder)] = $smcFunc['strtoupper']($txt['time_am']);
					$placeholders[str_replace($format_equivalents[$parts[$i]], 'PM', $placeholder)] = $smcFunc['strtoupper']($txt['time_pm']);
					break;

				// Upper case
				case 'P':
					$placeholders[str_replace($format_equivalents[$parts[$i]], 'am', $placeholder)] = $smcFunc['strtolower']($txt['time_am']);
					$placeholders[str_replace($format_equivalents[$parts[$i]], 'pm', $placeholder)] = $smcFunc['strtolower']($txt['time_pm']);
					break;
			}

			$parts[$i] = $placeholder;
		}
		// Parts that will need further processing.
		elseif (in_array($parts[$i], array('j', 'C', 'U', 'W', 'G', 'g', 'e', 'l')))
		{
			$complex = true;

			switch ($parts[$i])
			{
				case 'j':
					$placeholder_end = "\xEE\x84\xA1";
					break;

				case 'C':
					$placeholder_end = "\xEE\x84\xA2";
					break;

				case 'U':
				case 'W':
					$placeholder_end = "\xEE\x84\xA3";
					break;

				case 'G':
					$placeholder_end = "\xEE\x84\xA4";
					break;

				case 'g':
					$placeholder_end = "\xEE\x84\xA5";
					break;

				case 'e':
				case 'l':
					$placeholder_end = "\xEE\x84\xA6";
			}

			$parts[$i] = "\xEE\x84\xA0" . $format_equivalents[$parts[$i]] . $placeholder_end;
		}
		// Parts with simple equivalents.
		else
			$parts[$i] = $format_equivalents[$parts[$i]];
	}

	// The main event.
	$d = date_create('@' . $timestamp);

	if (($tz = @timezone_open($tzid)) === false)
		$tz = timezone_open(date_default_timezone_get());

	date_timezone_set($d, $tz);

	$date_string = strtr(date_format($d, implode('', $parts)), $placeholders);

	// Deal with the complicated ones.
	if ($complex)

The condition $complex is always false.

	{
		$date_string = preg_replace_callback(
			'/\xEE\x84\xA0([\d_]+)(\xEE\x84(?:[\xA1-\xAF]))/',
			function ($matches)
			{
				switch ($matches[2])
				{
					// %j
					case "\xEE\x84\xA1":
						$replacement = sprintf('%03d', (int) $matches[1] + 1);
						break;

					// %C
					case "\xEE\x84\xA2":
						$replacement = substr(sprintf('%04d', $matches[1]), 0, 2);
						break;

					// %U and %W
					case "\xEE\x84\xA3":
						list($day_of_year, $day_of_week, $first_day) = explode('_', $matches[1]);
						$replacement = sprintf('%02d', floor(((int) $day_of_year - (int) $day_of_week + (int) $first_day) / 7) + 1);
						break;

					// %G
					case "\xEE\x84\xA4":
						$replacement = sprintf('%04d', $matches[1]);
						break;

					// %g
					case "\xEE\x84\xA5":
						$replacement = substr(sprintf('%04d', $matches[1]), -2);
						break;

					// %e and %l
					case "\xEE\x84\xA6":
						$replacement = sprintf('%2d', $matches[1]);
						break;

					// Shouldn't happen, but just in case...
					default:
						$replacement = $matches[1];
						break;
				}

				return $replacement;
			},
			$date_string
		);
	}

	return $date_string;
}
?>