Completed
Pull Request — release-2.1 (#4995)
by Jeremy
06:17
created
Sources/Errors.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -45,7 +45,7 @@  discard block
 block discarded – undo
45 45
 		$backtrace = debug_backtrace();
46 46
 
47 47
 	// are we in a loop?
48
-	if($error_call > 2)
48
+	if ($error_call > 2)
49 49
 	{
50 50
 		var_dump($backtrace);
51 51
 		die('Error loop.');
@@ -549,7 +549,7 @@  discard block
 block discarded – undo
549 549
 		$url['error'] = $error;
550 550
 		// Url field got a max length of 1024 in db
551 551
 		if (strlen($url['error']) > 500)
552
-			$url['error'] = substr($url['error'],0,500);
552
+			$url['error'] = substr($url['error'], 0, 500);
553 553
 
554 554
 		if (!empty($sprintf))
555 555
 			$url['error_params'] = $sprintf;
Please login to merge, or discard this patch.
Sources/MessageIndex.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -324,7 +324,7 @@  discard block
 block discarded – undo
324 324
 				' . (empty($sort_methods_table[$context['sort_by']]) ? '' : $sort_methods_table[$context['sort_by']]) . '
325 325
 				WHERE t.id_board = {int:current_board} '
326 326
 				. (!$modSettings['postmod_active'] || $context['can_approve_posts'] ? '' : '
327
-					AND (t.approved = {int:is_approved}' . ($user_info['is_guest'] ? '' : ' OR t.id_member_started = {int:current_member}') . ')') .'
327
+					AND (t.approved = {int:is_approved}' . ($user_info['is_guest'] ? '' : ' OR t.id_member_started = {int:current_member}') . ')') . '
328 328
 				ORDER BY is_sticky' . ($fake_ascending ? '' : ' DESC') . ', ' . $_REQUEST['sort'] . ($ascending ? '' : ' DESC') . ' 
329 329
 				LIMIT {int:maxindex}
330 330
 					OFFSET {int:start} ';
@@ -333,7 +333,7 @@  discard block
 block discarded – undo
333 333
 		SELECT
334 334
 			t.id_topic, t.num_replies, t.locked, t.num_views, t.is_sticky, t.id_poll, t.id_previous_board,
335 335
 			' . ($user_info['is_guest'] ? '0' : 'COALESCE(lt.id_msg, COALESCE(lmr.id_msg, -1)) + 1') . ' AS new_from,
336
-			' . ( $enableParticipation ? ' COALESCE(( SELECT 1 FROM {db_prefix}messages AS parti WHERE t.id_topic = parti.id_topic and parti.id_member = {int:current_member} LIMIT 1) , 0) as is_posted_in,
336
+			' . ($enableParticipation ? ' COALESCE(( SELECT 1 FROM {db_prefix}messages AS parti WHERE t.id_topic = parti.id_topic and parti.id_member = {int:current_member} LIMIT 1) , 0) as is_posted_in,
337 337
 			'	: '') . '
338 338
 			t.id_last_msg, t.approved, t.unapproved_posts, ml.poster_time AS last_poster_time, t.id_redirect_topic,
339 339
 			ml.id_msg_modified, ml.subject AS last_subject, ml.icon AS last_icon,
@@ -357,7 +357,7 @@  discard block
 block discarded – undo
357 357
 			LEFT JOIN {db_prefix}log_mark_read AS lmr ON (lmr.id_board = {int:current_board} AND lmr.id_member = {int:current_member})') . '
358 358
 			' . (!empty($message_index_tables) ? implode("\n\t\t\t\t", $message_index_tables) : '') . '
359 359
 			' . (!empty($message_index_wheres) ? ' WHERE ' . implode("\n\t\t\t\tAND ", $message_index_wheres) : '') . '
360
-		ORDER BY is_sticky' . ($fake_ascending ? '' : ' DESC') . ', ' . $_REQUEST['sort'] . ($ascending ? '' : ' DESC') ,
360
+		ORDER BY is_sticky' . ($fake_ascending ? '' : ' DESC') . ', ' . $_REQUEST['sort'] . ($ascending ? '' : ' DESC'),
361 361
 		$message_index_parameters
362 362
 	);
363 363
 
Please login to merge, or discard this patch.
Themes/default/Memberlist.template.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -106,7 +106,7 @@
 block discarded – undo
106 106
 			if (!empty($context['custom_profile_fields']['columns']))
107 107
 				foreach ($context['custom_profile_fields']['columns'] as $key => $column)
108 108
 					echo '
109
-						<td class="' , $key , ' centertext">', $member['options'][$key], '</td>';
109
+						<td class="' , $key, ' centertext">', $member['options'][$key], '</td>';
110 110
 
111 111
 			echo '
112 112
 					</tr>';
Please login to merge, or discard this patch.
Sources/ManageBans.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -283,11 +283,11 @@  discard block
 block discarded – undo
283 283
 			if (removeItems == 0)
284 284
 			{
285 285
 				e.preventDefault();
286
-				return alert("'. $txt['select_item_check'] .'");
286
+				return alert("'. $txt['select_item_check'] . '");
287 287
 			}
288 288
 
289 289
 
290
-			return confirm("'. $txt['ban_remove_selected_confirm'] .'");
290
+			return confirm("'. $txt['ban_remove_selected_confirm'] . '");
291 291
 		});',
292 292
 	);
293 293
 
@@ -486,7 +486,7 @@  discard block
 block discarded – undo
486 486
 					array(
487 487
 						'position' => 'below_table_data',
488 488
 						'value' => '
489
-						<input type="submit" name="remove_selection" value="' . $txt['ban_remove_selected_triggers'] . '" class="button"> <a class="button" href="' . $scripturl	. '?action=admin;area=ban;sa=edittrigger;bg=' . $ban_group_id . '">' . $txt['ban_add_trigger'] . '</a>',
489
+						<input type="submit" name="remove_selection" value="' . $txt['ban_remove_selected_triggers'] . '" class="button"> <a class="button" href="' . $scripturl . '?action=admin;area=ban;sa=edittrigger;bg=' . $ban_group_id . '">' . $txt['ban_add_trigger'] . '</a>',
490 490
 						'style' => 'text-align: right;',
491 491
 					),
492 492
 					array(
@@ -506,11 +506,11 @@  discard block
 block discarded – undo
506 506
 			if (removeItems == 0)
507 507
 			{
508 508
 				e.preventDefault();
509
-				return alert("'. $txt['select_item_check'] .'");
509
+				return alert("'. $txt['select_item_check'] . '");
510 510
 			}
511 511
 
512 512
 
513
-			return confirm("'. $txt['ban_remove_selected_confirm'] .'");
513
+			return confirm("'. $txt['ban_remove_selected_confirm'] . '");
514 514
 		});',
515 515
 			);
516 516
 			createList($listOptions);
Please login to merge, or discard this patch.
Themes/default/Errors.template.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -328,7 +328,7 @@
 block discarded – undo
328 328
 		foreach ($context['error_info']['backtrace'] as $key => $value)
329 329
 		{
330 330
 			//Check for existing
331
-			if (!property_exists($value,'file') || empty($value->file))
331
+			if (!property_exists($value, 'file') || empty($value->file))
332 332
 				$value->file = $txt['unknown'];
333 333
 			if (!property_exists($value, 'line') || empty($value->line))
334 334
 				$value->line = -1;
Please login to merge, or discard this patch.
Sources/Subs.php 1 patch
Spacing   +111 added lines, -111 removed lines patch added patch discarded remove patch
@@ -391,7 +391,7 @@  discard block
 block discarded – undo
391 391
 			{
392 392
 				$val = 'CASE ';
393 393
 				foreach ($members as $k => $v)
394
-					$val .= 'WHEN id_member = ' . $v . ' THEN '. count(fetch_alerts($v, false, 0, array(), false)) . ' ';
394
+					$val .= 'WHEN id_member = ' . $v . ' THEN ' . count(fetch_alerts($v, false, 0, array(), false)) . ' ';
395 395
 				$val = $val . ' END';
396 396
 				$type = 'raw';
397 397
 			}
@@ -744,7 +744,7 @@  discard block
 block discarded – undo
744 744
 	static $non_twelve_hour, $locale_cache;
745 745
 	static $unsupportedFormats, $finalizedFormats;
746 746
 
747
-	$unsupportedFormatsWindows = array('z','Z');
747
+	$unsupportedFormatsWindows = array('z', 'Z');
748 748
 
749 749
 	// Ensure required values are set
750 750
 	$user_info['time_offset'] = !empty($user_info['time_offset']) ? $user_info['time_offset'] : 0;
@@ -829,7 +829,7 @@  discard block
 block discarded – undo
829 829
 			$unsupportedFormats = (array) cache_get_data('unsupportedtimeformats', 86400);
830 830
 		if (empty($unsupportedFormats))
831 831
 		{
832
-			foreach($strftimeFormatSubstitutions as $format => $substitution)
832
+			foreach ($strftimeFormatSubstitutions as $format => $substitution)
833 833
 			{
834 834
 				// Avoid a crashing bug with PHP 7 on certain versions of Windows
835 835
 				if ($context['server']['is_windows'] && in_array($format, $unsupportedFormatsWindows))
@@ -1206,7 +1206,7 @@  discard block
 block discarded – undo
1206 1206
 					'height' => array('optional' => true, 'match' => '(\d+)'),
1207 1207
 				),
1208 1208
 				'content' => '$1',
1209
-				'validate' => function (&$tag, &$data, $disabled, $params) use ($modSettings, $context, $sourcedir, $txt)
1209
+				'validate' => function(&$tag, &$data, $disabled, $params) use ($modSettings, $context, $sourcedir, $txt)
1210 1210
 				{
1211 1211
 					$returnContext = '';
1212 1212
 
@@ -1241,7 +1241,7 @@  discard block
 block discarded – undo
1241 1241
 						}
1242 1242
 
1243 1243
 						if ($currentAttachment['thumbnail']['has_thumb'] && empty($params['{width}']) && empty($params['{height}']))
1244
-							$returnContext .= '<a href="'. $currentAttachment['href']. ';image" id="link_'. $currentAttachment['id']. '" onclick="'. $currentAttachment['thumbnail']['javascript']. '"><img src="'. $currentAttachment['thumbnail']['href']. '"' . $alt . $title . ' id="thumb_'. $currentAttachment['id']. '" class="atc_img"></a>';
1244
+							$returnContext .= '<a href="' . $currentAttachment['href'] . ';image" id="link_' . $currentAttachment['id'] . '" onclick="' . $currentAttachment['thumbnail']['javascript'] . '"><img src="' . $currentAttachment['thumbnail']['href'] . '"' . $alt . $title . ' id="thumb_' . $currentAttachment['id'] . '" class="atc_img"></a>';
1245 1245
 						else
1246 1246
 							$returnContext .= '<img src="' . $currentAttachment['href'] . ';image"' . $alt . $title . $width . $height . ' class="bbc_img"/>';
1247 1247
 					}
@@ -1293,7 +1293,7 @@  discard block
 block discarded – undo
1293 1293
 				'type' => 'unparsed_content',
1294 1294
 				'content' => '<div class="codeheader"><span class="code floatleft">' . $txt['code'] . '</span> <a class="codeoperation smf_select_text">' . $txt['code_select'] . '</a></div><code class="bbc_code">$1</code>',
1295 1295
 				// @todo Maybe this can be simplified?
1296
-				'validate' => isset($disabled['code']) ? null : function (&$tag, &$data, $disabled) use ($context)
1296
+				'validate' => isset($disabled['code']) ? null : function(&$tag, &$data, $disabled) use ($context)
1297 1297
 				{
1298 1298
 					if (!isset($disabled['code']))
1299 1299
 					{
@@ -1330,7 +1330,7 @@  discard block
 block discarded – undo
1330 1330
 				'type' => 'unparsed_equals_content',
1331 1331
 				'content' => '<div class="codeheader"><span class="code floatleft">' . $txt['code'] . '</span> ($2) <a class="codeoperation smf_select_text">' . $txt['code_select'] . '</a></div><code class="bbc_code">$1</code>',
1332 1332
 				// @todo Maybe this can be simplified?
1333
-				'validate' => isset($disabled['code']) ? null : function (&$tag, &$data, $disabled) use ($context)
1333
+				'validate' => isset($disabled['code']) ? null : function(&$tag, &$data, $disabled) use ($context)
1334 1334
 				{
1335 1335
 					if (!isset($disabled['code']))
1336 1336
 					{
@@ -1374,7 +1374,7 @@  discard block
 block discarded – undo
1374 1374
 				'type' => 'unparsed_content',
1375 1375
 				'content' => '<a href="mailto:$1" class="bbc_email">$1</a>',
1376 1376
 				// @todo Should this respect guest_hideContacts?
1377
-				'validate' => function (&$tag, &$data, $disabled)
1377
+				'validate' => function(&$tag, &$data, $disabled)
1378 1378
 				{
1379 1379
 					$data = strtr($data, array('<br>' => ''));
1380 1380
 				},
@@ -1394,7 +1394,7 @@  discard block
 block discarded – undo
1394 1394
 				'test' => '(left|right)(\s+max=\d+(?:%|px|em|rem|ex|pt|pc|ch|vw|vh|vmin|vmax|cm|mm|in)?)?\]',
1395 1395
 				'before' => '<div $1>',
1396 1396
 				'after' => '</div>',
1397
-				'validate' => function (&$tag, &$data, $disabled)
1397
+				'validate' => function(&$tag, &$data, $disabled)
1398 1398
 				{
1399 1399
 					$class = 'class="bbc_float float' . (strpos($data, 'left') === 0 ? 'left' : 'right') . '"';
1400 1400
 
@@ -1480,7 +1480,7 @@  discard block
 block discarded – undo
1480 1480
 					'height' => array('optional' => true, 'value' => ' height="$1"', 'match' => '(\d+)'),
1481 1481
 				),
1482 1482
 				'content' => '<img src="$1" alt="{alt}" title="{title}"{width}{height} class="bbc_img resized">',
1483
-				'validate' => function (&$tag, &$data, $disabled)
1483
+				'validate' => function(&$tag, &$data, $disabled)
1484 1484
 				{
1485 1485
 					global $image_proxy_enabled, $user_info;
1486 1486
 
@@ -1506,7 +1506,7 @@  discard block
 block discarded – undo
1506 1506
 				'tag' => 'img',
1507 1507
 				'type' => 'unparsed_content',
1508 1508
 				'content' => '<img src="$1" alt="" class="bbc_img">',
1509
-				'validate' => function (&$tag, &$data, $disabled)
1509
+				'validate' => function(&$tag, &$data, $disabled)
1510 1510
 				{
1511 1511
 					global $image_proxy_enabled, $user_info;
1512 1512
 
@@ -1532,7 +1532,7 @@  discard block
 block discarded – undo
1532 1532
 				'tag' => 'iurl',
1533 1533
 				'type' => 'unparsed_content',
1534 1534
 				'content' => '<a href="$1" class="bbc_link">$1</a>',
1535
-				'validate' => function (&$tag, &$data, $disabled)
1535
+				'validate' => function(&$tag, &$data, $disabled)
1536 1536
 				{
1537 1537
 					$data = strtr($data, array('<br>' => ''));
1538 1538
 					$scheme = parse_url($data, PHP_URL_SCHEME);
@@ -1546,7 +1546,7 @@  discard block
 block discarded – undo
1546 1546
 				'quoted' => 'optional',
1547 1547
 				'before' => '<a href="$1" class="bbc_link">',
1548 1548
 				'after' => '</a>',
1549
-				'validate' => function (&$tag, &$data, $disabled)
1549
+				'validate' => function(&$tag, &$data, $disabled)
1550 1550
 				{
1551 1551
 					if (substr($data, 0, 1) == '#')
1552 1552
 						$data = '#post_' . substr($data, 1);
@@ -1639,7 +1639,7 @@  discard block
 block discarded – undo
1639 1639
 				'tag' => 'php',
1640 1640
 				'type' => 'unparsed_content',
1641 1641
 				'content' => '<span class="phpcode">$1</span>',
1642
-				'validate' => isset($disabled['php']) ? null : function (&$tag, &$data, $disabled)
1642
+				'validate' => isset($disabled['php']) ? null : function(&$tag, &$data, $disabled)
1643 1643
 				{
1644 1644
 					if (!isset($disabled['php']))
1645 1645
 					{
@@ -1788,7 +1788,7 @@  discard block
 block discarded – undo
1788 1788
 				'test' => '[1-7]\]',
1789 1789
 				'before' => '<span style="font-size: $1;" class="bbc_size">',
1790 1790
 				'after' => '</span>',
1791
-				'validate' => function (&$tag, &$data, $disabled)
1791
+				'validate' => function(&$tag, &$data, $disabled)
1792 1792
 				{
1793 1793
 					$sizes = array(1 => 0.7, 2 => 1.0, 3 => 1.35, 4 => 1.45, 5 => 2.0, 6 => 2.65, 7 => 3.95);
1794 1794
 					$data = $sizes[$data] . 'em';
@@ -1826,7 +1826,7 @@  discard block
 block discarded – undo
1826 1826
 				'tag' => 'time',
1827 1827
 				'type' => 'unparsed_content',
1828 1828
 				'content' => '$1',
1829
-				'validate' => function (&$tag, &$data, $disabled)
1829
+				'validate' => function(&$tag, &$data, $disabled)
1830 1830
 				{
1831 1831
 					if (is_numeric($data))
1832 1832
 						$data = timeformat($data);
@@ -1859,7 +1859,7 @@  discard block
 block discarded – undo
1859 1859
 				'tag' => 'url',
1860 1860
 				'type' => 'unparsed_content',
1861 1861
 				'content' => '<a href="$1" class="bbc_link" target="_blank" rel="noopener">$1</a>',
1862
-				'validate' => function (&$tag, &$data, $disabled)
1862
+				'validate' => function(&$tag, &$data, $disabled)
1863 1863
 				{
1864 1864
 					$data = strtr($data, array('<br>' => ''));
1865 1865
 					$scheme = parse_url($data, PHP_URL_SCHEME);
@@ -1873,7 +1873,7 @@  discard block
 block discarded – undo
1873 1873
 				'quoted' => 'optional',
1874 1874
 				'before' => '<a href="$1" class="bbc_link" target="_blank" rel="noopener">',
1875 1875
 				'after' => '</a>',
1876
-				'validate' => function (&$tag, &$data, $disabled)
1876
+				'validate' => function(&$tag, &$data, $disabled)
1877 1877
 				{
1878 1878
 					$scheme = parse_url($data, PHP_URL_SCHEME);
1879 1879
 					if (empty($scheme))
@@ -1912,7 +1912,7 @@  discard block
 block discarded – undo
1912 1912
 		{
1913 1913
 			if (isset($temp_bbc))
1914 1914
 				$bbc_codes = $temp_bbc;
1915
-			usort($codes, function ($a, $b) {
1915
+			usort($codes, function($a, $b) {
1916 1916
 				return strcmp($a['tag'], $b['tag']);
1917 1917
 			});
1918 1918
 			return $codes;
@@ -2128,7 +2128,7 @@  discard block
 block discarded – undo
2128 2128
 										# a run of Unicode domain name characters and a dot
2129 2129
 										[\p{L}\p{M}\p{N}\-.:@]+\.
2130 2130
 										# and then a TLD valid in the DNS or the reserved "local" TLD
2131
-										(?:'. $modSettings['tld_regex'] .'|local)
2131
+										(?:'. $modSettings['tld_regex'] . '|local)
2132 2132
 									)
2133 2133
 									# followed by a non-domain character or end of line
2134 2134
 									(?=[^\p{L}\p{N}\-.]|$)
@@ -2196,7 +2196,7 @@  discard block
 block discarded – undo
2196 2196
 						)?
2197 2197
 						';
2198 2198
 
2199
-						$data = preg_replace_callback('~' . $url_regex . '~xi' . ($context['utf8'] ? 'u' : ''), function ($matches) {
2199
+						$data = preg_replace_callback('~' . $url_regex . '~xi' . ($context['utf8'] ? 'u' : ''), function($matches) {
2200 2200
 							$url = array_shift($matches);
2201 2201
 
2202 2202
 							// If this isn't a clean URL, bail out
@@ -2221,7 +2221,7 @@  discard block
 block discarded – undo
2221 2221
 								$fullUrl = $url;
2222 2222
 
2223 2223
 							// Make sure that $fullUrl really is valid
2224
-							if (validate_iri((strpos($fullUrl, '//') === 0 ? 'http:' : '' ) . $fullUrl) === false)
2224
+							if (validate_iri((strpos($fullUrl, '//') === 0 ? 'http:' : '') . $fullUrl) === false)
2225 2225
 								return $url;
2226 2226
 
2227 2227
 							return '[url=&quot;' . str_replace(array('[', ']'), array('&#91;', '&#93;'), $fullUrl) . '&quot;]' . $url . '[/url]';
@@ -2285,7 +2285,7 @@  discard block
 block discarded – undo
2285 2285
 			$look_for = strtolower(substr($message, $pos + 2, $pos2 - $pos - 2));
2286 2286
 
2287 2287
 			// A closing tag that doesn't match any open tags? Skip it.
2288
-			if (!in_array($look_for, array_map(function($code){return $code['tag'];}, $open_tags)))
2288
+			if (!in_array($look_for, array_map(function($code) {return $code['tag']; }, $open_tags)))
2289 2289
 				continue;
2290 2290
 
2291 2291
 			$to_close = array();
@@ -2958,7 +2958,7 @@  discard block
 block discarded – undo
2958 2958
 			{
2959 2959
 				$exts = array('svg', 'png', 'gif', 'jpg');
2960 2960
 				$fname = pathinfo($smileysto[$i], PATHINFO_FILENAME);
2961
-				$alt_images = glob($smileys_dir . $fname .  '.{' . (implode(',', $exts)) . '}', GLOB_BRACE);
2961
+				$alt_images = glob($smileys_dir . $fname . '.{' . (implode(',', $exts)) . '}', GLOB_BRACE);
2962 2962
 				if (!empty($alt_images))
2963 2963
 				{
2964 2964
 					foreach ($exts as $ext)
@@ -2974,7 +2974,7 @@  discard block
 block discarded – undo
2974 2974
 			}
2975 2975
 
2976 2976
 			$specialChars = $smcFunc['htmlspecialchars']($smileysfrom[$i], ENT_QUOTES);
2977
-			$smileyCode = '<img src="' . $smileys_path . $smileysto[$i] . '" alt="' . strtr($specialChars, array(':' => '&#58;', '(' => '&#40;', ')' => '&#41;', '$' => '&#36;', '[' => '&#091;')). '" title="' . strtr($smcFunc['htmlspecialchars']($smileysdescs[$i]), array(':' => '&#58;', '(' => '&#40;', ')' => '&#41;', '$' => '&#36;', '[' => '&#091;')) . '" class="smiley">';
2977
+			$smileyCode = '<img src="' . $smileys_path . $smileysto[$i] . '" alt="' . strtr($specialChars, array(':' => '&#58;', '(' => '&#40;', ')' => '&#41;', '$' => '&#36;', '[' => '&#091;')) . '" title="' . strtr($smcFunc['htmlspecialchars']($smileysdescs[$i]), array(':' => '&#58;', '(' => '&#40;', ')' => '&#41;', '$' => '&#36;', '[' => '&#091;')) . '" class="smiley">';
2978 2978
 
2979 2979
 			$smileyPregReplacements[$smileysfrom[$i]] = $smileyCode;
2980 2980
 
@@ -2991,7 +2991,7 @@  discard block
 block discarded – undo
2991 2991
 
2992 2992
 	// Replace away!
2993 2993
 	$message = preg_replace_callback($smileyPregSearch,
2994
-		function ($matches) use ($smileyPregReplacements)
2994
+		function($matches) use ($smileyPregReplacements)
2995 2995
 		{
2996 2996
 			return $smileyPregReplacements[$matches[1]];
2997 2997
 		}, $message);
@@ -3088,13 +3088,13 @@  discard block
 block discarded – undo
3088 3088
 	{
3089 3089
 		if (defined('SID') && SID != '')
3090 3090
 			$setLocation = preg_replace_callback('~^' . preg_quote($scripturl, '~') . '\?(?:' . SID . '(?:;|&|&amp;))((?:board|topic)=[^#]+?)(#[^"]*?)?$~',
3091
-				function ($m) use ($scripturl)
3091
+				function($m) use ($scripturl)
3092 3092
 				{
3093
-					return $scripturl . '/' . strtr("$m[1]", '&;=', '//,') . '.html?' . SID. (isset($m[2]) ? "$m[2]" : "");
3093
+					return $scripturl . '/' . strtr("$m[1]", '&;=', '//,') . '.html?' . SID . (isset($m[2]) ? "$m[2]" : "");
3094 3094
 				}, $setLocation);
3095 3095
 		else
3096 3096
 			$setLocation = preg_replace_callback('~^' . preg_quote($scripturl, '~') . '\?((?:board|topic)=[^#"]+?)(#[^"]*?)?$~',
3097
-				function ($m) use ($scripturl)
3097
+				function($m) use ($scripturl)
3098 3098
 				{
3099 3099
 					return $scripturl . '/' . strtr("$m[1]", '&;=', '//,') . '.html' . (isset($m[2]) ? "$m[2]" : "");
3100 3100
 				}, $setLocation);
@@ -3415,7 +3415,7 @@  discard block
 block discarded – undo
3415 3415
 
3416 3416
 	// Add a generic "Are you sure?" confirmation message.
3417 3417
 	addInlineJavaScript('
3418
-	var smf_you_sure =' . JavaScriptEscape($txt['quickmod_confirm']) .';');
3418
+	var smf_you_sure =' . JavaScriptEscape($txt['quickmod_confirm']) . ';');
3419 3419
 
3420 3420
 	// Now add the capping code for avatars.
3421 3421
 	if (!empty($modSettings['avatar_max_width_external']) && !empty($modSettings['avatar_max_height_external']) && !empty($modSettings['avatar_action_too_large']) && $modSettings['avatar_action_too_large'] == 'option_css_resize')
@@ -3881,7 +3881,7 @@  discard block
 block discarded – undo
3881 3881
 	if (!empty($normal))
3882 3882
 		foreach ($normal as $nf)
3883 3883
 			echo '
3884
-	<link rel="stylesheet" href="', $nf ,'">';
3884
+	<link rel="stylesheet" href="', $nf, '">';
3885 3885
 
3886 3886
 	if ($db_show_debug === true)
3887 3887
 	{
@@ -3897,7 +3897,7 @@  discard block
 block discarded – undo
3897 3897
 	<style>';
3898 3898
 
3899 3899
 		foreach ($context['css_header'] as $css)
3900
-			echo $css .'
3900
+			echo $css . '
3901 3901
 	';
3902 3902
 
3903 3903
 		echo'
@@ -3941,7 +3941,7 @@  discard block
 block discarded – undo
3941 3941
 
3942 3942
 
3943 3943
 	// No namespaces, sorry!
3944
-	$classType = 'MatthiasMullie\\Minify\\'. strtoupper($type);
3944
+	$classType = 'MatthiasMullie\\Minify\\' . strtoupper($type);
3945 3945
 
3946 3946
 	// Temp path.
3947 3947
 	$cTempPath = $settings['theme_dir'] . '/' . ($type == 'css' ? 'css' : 'scripts') . '/';
@@ -4121,7 +4121,7 @@  discard block
 block discarded – undo
4121 4121
 	else
4122 4122
 		$path = $modSettings['attachmentUploadDir'];
4123 4123
 
4124
-	return $path . '/' . $attachment_id . '_' . $file_hash .'.dat';
4124
+	return $path . '/' . $attachment_id . '_' . $file_hash . '.dat';
4125 4125
 }
4126 4126
 
4127 4127
 /**
@@ -4165,10 +4165,10 @@  discard block
 block discarded – undo
4165 4165
 		$valid_low = isValidIP($ip_parts[0]);
4166 4166
 		$valid_high = isValidIP($ip_parts[1]);
4167 4167
 		$count = 0;
4168
-		$mode = (preg_match('/:/',$ip_parts[0]) > 0 ? ':' : '.');
4168
+		$mode = (preg_match('/:/', $ip_parts[0]) > 0 ? ':' : '.');
4169 4169
 		$max = ($mode == ':' ? 'ffff' : '255');
4170 4170
 		$min = 0;
4171
-		if(!$valid_low)
4171
+		if (!$valid_low)
4172 4172
 		{
4173 4173
 			$ip_parts[0] = preg_replace('/\*/', '0', $ip_parts[0]);
4174 4174
 			$valid_low = isValidIP($ip_parts[0]);
@@ -4182,7 +4182,7 @@  discard block
 block discarded – undo
4182 4182
 		}
4183 4183
 
4184 4184
 		$count = 0;
4185
-		if(!$valid_high)
4185
+		if (!$valid_high)
4186 4186
 		{
4187 4187
 			$ip_parts[1] = preg_replace('/\*/', $max, $ip_parts[1]);
4188 4188
 			$valid_high = isValidIP($ip_parts[1]);
@@ -4195,7 +4195,7 @@  discard block
 block discarded – undo
4195 4195
 			}
4196 4196
 		}
4197 4197
 
4198
-		if($valid_high && $valid_low)
4198
+		if ($valid_high && $valid_low)
4199 4199
 		{
4200 4200
 			$ip_array['low'] = $ip_parts[0];
4201 4201
 			$ip_array['high'] = $ip_parts[1];
@@ -4376,7 +4376,7 @@  discard block
 block discarded – undo
4376 4376
 		addInlineJavaScript('
4377 4377
 	var user_menus = new smc_PopupMenu();
4378 4378
 	user_menus.add("profile", "' . $scripturl . '?action=profile;area=popup");
4379
-	user_menus.add("alerts", "' . $scripturl . '?action=profile;area=alerts_popup;u='. $context['user']['id'] .'");', true);
4379
+	user_menus.add("alerts", "' . $scripturl . '?action=profile;area=alerts_popup;u=' . $context['user']['id'] . '");', true);
4380 4380
 		if ($context['allow_pm'])
4381 4381
 			addInlineJavaScript('
4382 4382
 	user_menus.add("pm", "' . $scripturl . '?action=pm;sa=popup");', true);
@@ -5012,7 +5012,7 @@  discard block
 block discarded – undo
5012 5012
 		// No? try a fallback to $sourcedir
5013 5013
 		else
5014 5014
 		{
5015
-			$absPath = $sourcedir .'/'. $file;
5015
+			$absPath = $sourcedir . '/' . $file;
5016 5016
 
5017 5017
 			if (file_exists($absPath))
5018 5018
 				require_once($absPath);
@@ -5279,15 +5279,15 @@  discard block
 block discarded – undo
5279 5279
 
5280 5280
 	// UTF-8 occurences of MS special characters
5281 5281
 	$findchars_utf8 = array(
5282
-		"\xe2\x80\x9a",	// single low-9 quotation mark
5283
-		"\xe2\x80\x9e",	// double low-9 quotation mark
5284
-		"\xe2\x80\xa6",	// horizontal ellipsis
5285
-		"\xe2\x80\x98",	// left single curly quote
5286
-		"\xe2\x80\x99",	// right single curly quote
5287
-		"\xe2\x80\x9c",	// left double curly quote
5288
-		"\xe2\x80\x9d",	// right double curly quote
5289
-		"\xe2\x80\x93",	// en dash
5290
-		"\xe2\x80\x94",	// em dash
5282
+		"\xe2\x80\x9a", // single low-9 quotation mark
5283
+		"\xe2\x80\x9e", // double low-9 quotation mark
5284
+		"\xe2\x80\xa6", // horizontal ellipsis
5285
+		"\xe2\x80\x98", // left single curly quote
5286
+		"\xe2\x80\x99", // right single curly quote
5287
+		"\xe2\x80\x9c", // left double curly quote
5288
+		"\xe2\x80\x9d", // right double curly quote
5289
+		"\xe2\x80\x93", // en dash
5290
+		"\xe2\x80\x94", // em dash
5291 5291
 	);
5292 5292
 
5293 5293
 	// windows 1252 / iso equivalents
@@ -5305,15 +5305,15 @@  discard block
 block discarded – undo
5305 5305
 
5306 5306
 	// safe replacements
5307 5307
 	$replacechars = array(
5308
-		',',	// &sbquo;
5309
-		',,',	// &bdquo;
5310
-		'...',	// &hellip;
5311
-		"'",	// &lsquo;
5312
-		"'",	// &rsquo;
5313
-		'"',	// &ldquo;
5314
-		'"',	// &rdquo;
5315
-		'-',	// &ndash;
5316
-		'--',	// &mdash;
5308
+		',', // &sbquo;
5309
+		',,', // &bdquo;
5310
+		'...', // &hellip;
5311
+		"'", // &lsquo;
5312
+		"'", // &rsquo;
5313
+		'"', // &ldquo;
5314
+		'"', // &rdquo;
5315
+		'-', // &ndash;
5316
+		'--', // &mdash;
5317 5317
 	);
5318 5318
 
5319 5319
 	if ($context['utf8'])
@@ -5633,7 +5633,7 @@  discard block
 block discarded – undo
5633 5633
  */
5634 5634
 function inet_dtop($bin)
5635 5635
 {
5636
-	if(empty($bin))
5636
+	if (empty($bin))
5637 5637
 		return '';
5638 5638
 
5639 5639
 	global $db_type;
@@ -5664,28 +5664,28 @@  discard block
 block discarded – undo
5664 5664
  */
5665 5665
 function _safe_serialize($value)
5666 5666
 {
5667
-	if(is_null($value))
5667
+	if (is_null($value))
5668 5668
 		return 'N;';
5669 5669
 
5670
-	if(is_bool($value))
5671
-		return 'b:'. (int) $value .';';
5670
+	if (is_bool($value))
5671
+		return 'b:' . (int) $value . ';';
5672 5672
 
5673
-	if(is_int($value))
5674
-		return 'i:'. $value .';';
5673
+	if (is_int($value))
5674
+		return 'i:' . $value . ';';
5675 5675
 
5676
-	if(is_float($value))
5677
-		return 'd:'. str_replace(',', '.', $value) .';';
5676
+	if (is_float($value))
5677
+		return 'd:' . str_replace(',', '.', $value) . ';';
5678 5678
 
5679
-	if(is_string($value))
5680
-		return 's:'. strlen($value) .':"'. $value .'";';
5679
+	if (is_string($value))
5680
+		return 's:' . strlen($value) . ':"' . $value . '";';
5681 5681
 
5682
-	if(is_array($value))
5682
+	if (is_array($value))
5683 5683
 	{
5684 5684
 		$out = '';
5685
-		foreach($value as $k => $v)
5685
+		foreach ($value as $k => $v)
5686 5686
 			$out .= _safe_serialize($k) . _safe_serialize($v);
5687 5687
 
5688
-		return 'a:'. count($value) .':{'. $out .'}';
5688
+		return 'a:' . count($value) . ':{' . $out . '}';
5689 5689
 	}
5690 5690
 
5691 5691
 	// safe_serialize cannot serialize resources or objects.
@@ -5727,7 +5727,7 @@  discard block
 block discarded – undo
5727 5727
 function _safe_unserialize($str)
5728 5728
 {
5729 5729
 	// Input  is not a string.
5730
-	if(empty($str) || !is_string($str))
5730
+	if (empty($str) || !is_string($str))
5731 5731
 		return false;
5732 5732
 
5733 5733
 	$stack = array();
@@ -5741,40 +5741,40 @@  discard block
 block discarded – undo
5741 5741
 	 *   3 - in array, expecting value or another array
5742 5742
 	 */
5743 5743
 	$state = 0;
5744
-	while($state != 1)
5744
+	while ($state != 1)
5745 5745
 	{
5746 5746
 		$type = isset($str[0]) ? $str[0] : '';
5747
-		if($type == '}')
5747
+		if ($type == '}')
5748 5748
 			$str = substr($str, 1);
5749 5749
 
5750
-		else if($type == 'N' && $str[1] == ';')
5750
+		else if ($type == 'N' && $str[1] == ';')
5751 5751
 		{
5752 5752
 			$value = null;
5753 5753
 			$str = substr($str, 2);
5754 5754
 		}
5755
-		else if($type == 'b' && preg_match('/^b:([01]);/', $str, $matches))
5755
+		else if ($type == 'b' && preg_match('/^b:([01]);/', $str, $matches))
5756 5756
 		{
5757 5757
 			$value = $matches[1] == '1' ? true : false;
5758 5758
 			$str = substr($str, 4);
5759 5759
 		}
5760
-		else if($type == 'i' && preg_match('/^i:(-?[0-9]+);(.*)/s', $str, $matches))
5760
+		else if ($type == 'i' && preg_match('/^i:(-?[0-9]+);(.*)/s', $str, $matches))
5761 5761
 		{
5762
-			$value = (int)$matches[1];
5762
+			$value = (int) $matches[1];
5763 5763
 			$str = $matches[2];
5764 5764
 		}
5765
-		else if($type == 'd' && preg_match('/^d:(-?[0-9]+\.?[0-9]*(E[+-][0-9]+)?);(.*)/s', $str, $matches))
5765
+		else if ($type == 'd' && preg_match('/^d:(-?[0-9]+\.?[0-9]*(E[+-][0-9]+)?);(.*)/s', $str, $matches))
5766 5766
 		{
5767
-			$value = (float)$matches[1];
5767
+			$value = (float) $matches[1];
5768 5768
 			$str = $matches[3];
5769 5769
 		}
5770
-		else if($type == 's' && preg_match('/^s:([0-9]+):"(.*)/s', $str, $matches) && substr($matches[2], (int)$matches[1], 2) == '";')
5770
+		else if ($type == 's' && preg_match('/^s:([0-9]+):"(.*)/s', $str, $matches) && substr($matches[2], (int) $matches[1], 2) == '";')
5771 5771
 		{
5772
-			$value = substr($matches[2], 0, (int)$matches[1]);
5773
-			$str = substr($matches[2], (int)$matches[1] + 2);
5772
+			$value = substr($matches[2], 0, (int) $matches[1]);
5773
+			$str = substr($matches[2], (int) $matches[1] + 2);
5774 5774
 		}
5775
-		else if($type == 'a' && preg_match('/^a:([0-9]+):{(.*)/s', $str, $matches))
5775
+		else if ($type == 'a' && preg_match('/^a:([0-9]+):{(.*)/s', $str, $matches))
5776 5776
 		{
5777
-			$expectedLength = (int)$matches[1];
5777
+			$expectedLength = (int) $matches[1];
5778 5778
 			$str = $matches[2];
5779 5779
 		}
5780 5780
 
@@ -5782,10 +5782,10 @@  discard block
 block discarded – undo
5782 5782
 		else
5783 5783
 			return false;
5784 5784
 
5785
-		switch($state)
5785
+		switch ($state)
5786 5786
 		{
5787 5787
 			case 3: // In array, expecting value or another array.
5788
-				if($type == 'a')
5788
+				if ($type == 'a')
5789 5789
 				{
5790 5790
 					$stack[] = &$list;
5791 5791
 					$list[$key] = array();
@@ -5794,7 +5794,7 @@  discard block
 block discarded – undo
5794 5794
 					$state = 2;
5795 5795
 					break;
5796 5796
 				}
5797
-				if($type != '}')
5797
+				if ($type != '}')
5798 5798
 				{
5799 5799
 					$list[$key] = $value;
5800 5800
 					$state = 2;
@@ -5805,29 +5805,29 @@  discard block
 block discarded – undo
5805 5805
 				return false;
5806 5806
 
5807 5807
 			case 2: // in array, expecting end of array or a key
5808
-				if($type == '}')
5808
+				if ($type == '}')
5809 5809
 				{
5810 5810
 					// Array size is less than expected.
5811
-					if(count($list) < end($expected))
5811
+					if (count($list) < end($expected))
5812 5812
 						return false;
5813 5813
 
5814 5814
 					unset($list);
5815
-					$list = &$stack[count($stack)-1];
5815
+					$list = &$stack[count($stack) - 1];
5816 5816
 					array_pop($stack);
5817 5817
 
5818 5818
 					// Go to terminal state if we're at the end of the root array.
5819 5819
 					array_pop($expected);
5820 5820
 
5821
-					if(count($expected) == 0)
5821
+					if (count($expected) == 0)
5822 5822
 						$state = 1;
5823 5823
 
5824 5824
 					break;
5825 5825
 				}
5826 5826
 
5827
-				if($type == 'i' || $type == 's')
5827
+				if ($type == 'i' || $type == 's')
5828 5828
 				{
5829 5829
 					// Array size exceeds expected length.
5830
-					if(count($list) >= end($expected))
5830
+					if (count($list) >= end($expected))
5831 5831
 						return false;
5832 5832
 
5833 5833
 					$key = $value;
@@ -5840,7 +5840,7 @@  discard block
 block discarded – undo
5840 5840
 
5841 5841
 			// Expecting array or value.
5842 5842
 			case 0:
5843
-				if($type == 'a')
5843
+				if ($type == 'a')
5844 5844
 				{
5845 5845
 					$data = array();
5846 5846
 					$list = &$data;
@@ -5849,7 +5849,7 @@  discard block
 block discarded – undo
5849 5849
 					break;
5850 5850
 				}
5851 5851
 
5852
-				if($type != '}')
5852
+				if ($type != '}')
5853 5853
 				{
5854 5854
 					$data = $value;
5855 5855
 					$state = 1;
@@ -5862,7 +5862,7 @@  discard block
 block discarded – undo
5862 5862
 	}
5863 5863
 
5864 5864
 	// Trailing data in input.
5865
-	if(!empty($str))
5865
+	if (!empty($str))
5866 5866
 		return false;
5867 5867
 
5868 5868
 	return $data;
@@ -5916,7 +5916,7 @@  discard block
 block discarded – undo
5916 5916
 	// Set different modes.
5917 5917
 	$chmodValues = $isDir ? array(0750, 0755, 0775, 0777) : array(0644, 0664, 0666);
5918 5918
 
5919
-	foreach($chmodValues as $val)
5919
+	foreach ($chmodValues as $val)
5920 5920
 	{
5921 5921
 		// If it's writable, break out of the loop.
5922 5922
 		if (is_writable($file))
@@ -5951,13 +5951,13 @@  discard block
 block discarded – undo
5951 5951
 	$returnArray = @json_decode($json, $returnAsArray);
5952 5952
 
5953 5953
 	// PHP 5.3 so no json_last_error_msg()
5954
-	switch(json_last_error())
5954
+	switch (json_last_error())
5955 5955
 	{
5956 5956
 		case JSON_ERROR_NONE:
5957 5957
 			$jsonError = false;
5958 5958
 			break;
5959 5959
 		case JSON_ERROR_DEPTH:
5960
-			$jsonError =  'JSON_ERROR_DEPTH';
5960
+			$jsonError = 'JSON_ERROR_DEPTH';
5961 5961
 			break;
5962 5962
 		case JSON_ERROR_STATE_MISMATCH:
5963 5963
 			$jsonError = 'JSON_ERROR_STATE_MISMATCH';
@@ -5985,10 +5985,10 @@  discard block
 block discarded – undo
5985 5985
 		loadLanguage('Errors');
5986 5986
 
5987 5987
 		if (!empty($jsonDebug))
5988
-			log_error($txt['json_'. $jsonError], 'critical', $jsonDebug['file'], $jsonDebug['line']);
5988
+			log_error($txt['json_' . $jsonError], 'critical', $jsonDebug['file'], $jsonDebug['line']);
5989 5989
 
5990 5990
 		else
5991
-			log_error($txt['json_'. $jsonError], 'critical');
5991
+			log_error($txt['json_' . $jsonError], 'critical');
5992 5992
 
5993 5993
 		// Everyone expects an array.
5994 5994
 		return array();
@@ -6105,7 +6105,7 @@  discard block
 block discarded – undo
6105 6105
 		// Convert Punycode to Unicode
6106 6106
 		require_once($sourcedir . '/Class-Punycode.php');
6107 6107
 		$Punycode = new Punycode();
6108
-		$tlds = array_map(function ($input) use ($Punycode) { return $Punycode->decode($input); }, $tlds);
6108
+		$tlds = array_map(function($input) use ($Punycode) { return $Punycode->decode($input); }, $tlds);
6109 6109
 	}
6110 6110
 	// Otherwise, use the 2012 list of gTLDs and ccTLDs for now and schedule a background update
6111 6111
 	else
@@ -6199,7 +6199,7 @@  discard block
 block discarded – undo
6199 6199
 	}
6200 6200
 
6201 6201
 	// This recursive function creates the index array from the strings
6202
-	$add_string_to_index = function ($string, $index) use (&$strlen, &$substr, &$add_string_to_index)
6202
+	$add_string_to_index = function($string, $index) use (&$strlen, &$substr, &$add_string_to_index)
6203 6203
 	{
6204 6204
 		static $depth = 0;
6205 6205
 		$depth++;
@@ -6226,7 +6226,7 @@  discard block
 block discarded – undo
6226 6226
 	};
6227 6227
 
6228 6228
 	// This recursive function turns the index array into a regular expression
6229
-	$index_to_regex = function (&$index, $delim) use (&$strlen, &$index_to_regex)
6229
+	$index_to_regex = function(&$index, $delim) use (&$strlen, &$index_to_regex)
6230 6230
 	{
6231 6231
 		static $depth = 0;
6232 6232
 		$depth++;
@@ -6250,11 +6250,11 @@  discard block
 block discarded – undo
6250 6250
 
6251 6251
 				if (count(array_keys($value)) == 1)
6252 6252
 				{
6253
-					$new_key_array = explode('(?'.'>', $sub_regex);
6253
+					$new_key_array = explode('(?' . '>', $sub_regex);
6254 6254
 					$new_key .= $new_key_array[0];
6255 6255
 				}
6256 6256
 				else
6257
-					$sub_regex = '(?'.'>' . $sub_regex . ')';
6257
+					$sub_regex = '(?' . '>' . $sub_regex . ')';
6258 6258
 			}
6259 6259
 
6260 6260
 			if ($depth > 1)
@@ -6297,10 +6297,10 @@  discard block
 block discarded – undo
6297 6297
 	{
6298 6298
 		$regex = array();
6299 6299
 		while (!empty($index))
6300
-			$regex[] = '(?'.'>' . $index_to_regex($index, $delim) . ')';
6300
+			$regex[] = '(?' . '>' . $index_to_regex($index, $delim) . ')';
6301 6301
 	}
6302 6302
 	else
6303
-		$regex = '(?'.'>' . $index_to_regex($index, $delim) . ')';
6303
+		$regex = '(?' . '>' . $index_to_regex($index, $delim) . ')';
6304 6304
 
6305 6305
 	// Restore PHP's internal character encoding to whatever it was originally
6306 6306
 	if (!empty($current_encoding))
@@ -6524,7 +6524,7 @@  discard block
 block discarded – undo
6524 6524
 function sanitize_iri($iri)
6525 6525
 {
6526 6526
 	// Encode any non-ASCII characters (but not space or control characters of any sort)
6527
-	$iri = preg_replace_callback('~[^\x00-\x7F\pZ\pC]~u', function ($matches) {
6527
+	$iri = preg_replace_callback('~[^\x00-\x7F\pZ\pC]~u', function($matches) {
6528 6528
 		return rawurlencode($matches[0]);
6529 6529
 	}, $iri);
6530 6530
 
@@ -6566,7 +6566,7 @@  discard block
 block discarded – undo
6566 6566
 	$unescaped = array(
6567 6567
 		'%21'=>'!', '%23'=>'#', '%24'=>'$', '%26'=>'&',
6568 6568
 		'%27'=>"'", '%28'=>'(', '%29'=>')', '%2A'=>'*',
6569
-		'%2B'=>'+', '%2C'=>',',	'%2F'=>'/', '%3A'=>':',
6569
+		'%2B'=>'+', '%2C'=>',', '%2F'=>'/', '%3A'=>':',
6570 6570
 		'%3B'=>';', '%3D'=>'=', '%3F'=>'?', '%40'=>'@',
6571 6571
 	);
6572 6572
 	$iri = strtr(rawurlencode($iri), $unescaped);
Please login to merge, or discard this patch.
other/upgrade.php 1 patch
Spacing   +100 added lines, -100 removed lines patch added patch discarded remove patch
@@ -841,13 +841,13 @@  discard block
 block discarded – undo
841 841
 	// We're going to check that their board dir setting is right in case they've been moving stuff around.
842 842
 	if (strtr($boarddir, array('/' => '', '\\' => '')) != strtr(dirname(__FILE__), array('/' => '', '\\' => '')))
843 843
 		$upcontext['warning'] = '
844
-			'. sprintf($txt['upgrade_boarddir_settings'], $boarddir, dirname(__FILE__)) .'<br>
844
+			'. sprintf($txt['upgrade_boarddir_settings'], $boarddir, dirname(__FILE__)) . '<br>
845 845
 			<ul>
846
-				<li>'. $txt['upgrade_boarddir'] .'  ' . $boarddir . '</li>
847
-				<li>'. $txt['upgrade_sourcedir'] .'  ' . $boarddir . '</li>
848
-				<li>'. $txt['upgrade_cachedir'] .'  ' . $cachedir_temp . '</li>
846
+				<li>'. $txt['upgrade_boarddir'] . '  ' . $boarddir . '</li>
847
+				<li>'. $txt['upgrade_sourcedir'] . '  ' . $boarddir . '</li>
848
+				<li>'. $txt['upgrade_cachedir'] . '  ' . $cachedir_temp . '</li>
849 849
 			</ul>
850
-			'. $txt['upgrade_incorrect_settings'] .'';
850
+			'. $txt['upgrade_incorrect_settings'] . '';
851 851
 
852 852
 	// Confirm mbstring is loaded...
853 853
 	if (!extension_loaded('mbstring'))
@@ -1781,7 +1781,7 @@  discard block
 block discarded – undo
1781 1781
 
1782 1782
 	// Our custom error handler - does nothing but does stop public errors from XML!
1783 1783
 	set_error_handler(
1784
-		function ($errno, $errstr, $errfile, $errline) use ($support_js)
1784
+		function($errno, $errstr, $errfile, $errline) use ($support_js)
1785 1785
 		{
1786 1786
 			if ($support_js)
1787 1787
 				return true;
@@ -2109,13 +2109,13 @@  discard block
 block discarded – undo
2109 2109
 
2110 2110
 	// Otherwise we have to display this somewhere appropriate if possible.
2111 2111
 	$upcontext['forced_error_message'] = '
2112
-			<strong>'. $txt['upgrade_unsuccessful'] .'</strong><br>
2112
+			<strong>'. $txt['upgrade_unsuccessful'] . '</strong><br>
2113 2113
 
2114 2114
 			<div style="margin: 2ex;">
2115
-				'. $txt['upgrade_thisquery'] .'
2115
+				'. $txt['upgrade_thisquery'] . '
2116 2116
 				<blockquote><pre>' . nl2br(htmlspecialchars(trim($string))) . ';</pre></blockquote>
2117 2117
 
2118
-				'. $txt['upgrade_causerror'] .'
2118
+				'. $txt['upgrade_causerror'] . '
2119 2119
 				<blockquote>' . nl2br(htmlspecialchars($db_error_message)) . '</blockquote>
2120 2120
 			</div>
2121 2121
 
@@ -2780,94 +2780,94 @@  discard block
 block discarded – undo
2780 2780
 		// Translation table for the character sets not native for MySQL.
2781 2781
 		$translation_tables = array(
2782 2782
 			'windows-1255' => array(
2783
-				'0x81' => '\'\'',		'0x8A' => '\'\'',		'0x8C' => '\'\'',
2784
-				'0x8D' => '\'\'',		'0x8E' => '\'\'',		'0x8F' => '\'\'',
2785
-				'0x90' => '\'\'',		'0x9A' => '\'\'',		'0x9C' => '\'\'',
2786
-				'0x9D' => '\'\'',		'0x9E' => '\'\'',		'0x9F' => '\'\'',
2787
-				'0xCA' => '\'\'',		'0xD9' => '\'\'',		'0xDA' => '\'\'',
2788
-				'0xDB' => '\'\'',		'0xDC' => '\'\'',		'0xDD' => '\'\'',
2789
-				'0xDE' => '\'\'',		'0xDF' => '\'\'',		'0xFB' => '0xD792',
2790
-				'0xFC' => '0xE282AC',		'0xFF' => '0xD6B2',		'0xC2' => '0xFF',
2791
-				'0x80' => '0xFC',		'0xE2' => '0xFB',		'0xA0' => '0xC2A0',
2792
-				'0xA1' => '0xC2A1',		'0xA2' => '0xC2A2',		'0xA3' => '0xC2A3',
2793
-				'0xA5' => '0xC2A5',		'0xA6' => '0xC2A6',		'0xA7' => '0xC2A7',
2794
-				'0xA8' => '0xC2A8',		'0xA9' => '0xC2A9',		'0xAB' => '0xC2AB',
2795
-				'0xAC' => '0xC2AC',		'0xAD' => '0xC2AD',		'0xAE' => '0xC2AE',
2796
-				'0xAF' => '0xC2AF',		'0xB0' => '0xC2B0',		'0xB1' => '0xC2B1',
2797
-				'0xB2' => '0xC2B2',		'0xB3' => '0xC2B3',		'0xB4' => '0xC2B4',
2798
-				'0xB5' => '0xC2B5',		'0xB6' => '0xC2B6',		'0xB7' => '0xC2B7',
2799
-				'0xB8' => '0xC2B8',		'0xB9' => '0xC2B9',		'0xBB' => '0xC2BB',
2800
-				'0xBC' => '0xC2BC',		'0xBD' => '0xC2BD',		'0xBE' => '0xC2BE',
2801
-				'0xBF' => '0xC2BF',		'0xD7' => '0xD7B3',		'0xD1' => '0xD781',
2802
-				'0xD4' => '0xD7B0',		'0xD5' => '0xD7B1',		'0xD6' => '0xD7B2',
2803
-				'0xE0' => '0xD790',		'0xEA' => '0xD79A',		'0xEC' => '0xD79C',
2804
-				'0xED' => '0xD79D',		'0xEE' => '0xD79E',		'0xEF' => '0xD79F',
2805
-				'0xF0' => '0xD7A0',		'0xF1' => '0xD7A1',		'0xF2' => '0xD7A2',
2806
-				'0xF3' => '0xD7A3',		'0xF5' => '0xD7A5',		'0xF6' => '0xD7A6',
2807
-				'0xF7' => '0xD7A7',		'0xF8' => '0xD7A8',		'0xF9' => '0xD7A9',
2808
-				'0x82' => '0xE2809A',	'0x84' => '0xE2809E',	'0x85' => '0xE280A6',
2809
-				'0x86' => '0xE280A0',	'0x87' => '0xE280A1',	'0x89' => '0xE280B0',
2810
-				'0x8B' => '0xE280B9',	'0x93' => '0xE2809C',	'0x94' => '0xE2809D',
2811
-				'0x95' => '0xE280A2',	'0x97' => '0xE28094',	'0x99' => '0xE284A2',
2812
-				'0xC0' => '0xD6B0',		'0xC1' => '0xD6B1',		'0xC3' => '0xD6B3',
2813
-				'0xC4' => '0xD6B4',		'0xC5' => '0xD6B5',		'0xC6' => '0xD6B6',
2814
-				'0xC7' => '0xD6B7',		'0xC8' => '0xD6B8',		'0xC9' => '0xD6B9',
2815
-				'0xCB' => '0xD6BB',		'0xCC' => '0xD6BC',		'0xCD' => '0xD6BD',
2816
-				'0xCE' => '0xD6BE',		'0xCF' => '0xD6BF',		'0xD0' => '0xD780',
2817
-				'0xD2' => '0xD782',		'0xE3' => '0xD793',		'0xE4' => '0xD794',
2818
-				'0xE5' => '0xD795',		'0xE7' => '0xD797',		'0xE9' => '0xD799',
2819
-				'0xFD' => '0xE2808E',	'0xFE' => '0xE2808F',	'0x92' => '0xE28099',
2820
-				'0x83' => '0xC692',		'0xD3' => '0xD783',		'0x88' => '0xCB86',
2821
-				'0x98' => '0xCB9C',		'0x91' => '0xE28098',	'0x96' => '0xE28093',
2822
-				'0xBA' => '0xC3B7',		'0x9B' => '0xE280BA',	'0xAA' => '0xC397',
2823
-				'0xA4' => '0xE282AA',	'0xE1' => '0xD791',		'0xE6' => '0xD796',
2824
-				'0xE8' => '0xD798',		'0xEB' => '0xD79B',		'0xF4' => '0xD7A4',
2783
+				'0x81' => '\'\'', '0x8A' => '\'\'', '0x8C' => '\'\'',
2784
+				'0x8D' => '\'\'', '0x8E' => '\'\'', '0x8F' => '\'\'',
2785
+				'0x90' => '\'\'', '0x9A' => '\'\'', '0x9C' => '\'\'',
2786
+				'0x9D' => '\'\'', '0x9E' => '\'\'', '0x9F' => '\'\'',
2787
+				'0xCA' => '\'\'', '0xD9' => '\'\'', '0xDA' => '\'\'',
2788
+				'0xDB' => '\'\'', '0xDC' => '\'\'', '0xDD' => '\'\'',
2789
+				'0xDE' => '\'\'', '0xDF' => '\'\'', '0xFB' => '0xD792',
2790
+				'0xFC' => '0xE282AC', '0xFF' => '0xD6B2', '0xC2' => '0xFF',
2791
+				'0x80' => '0xFC', '0xE2' => '0xFB', '0xA0' => '0xC2A0',
2792
+				'0xA1' => '0xC2A1', '0xA2' => '0xC2A2', '0xA3' => '0xC2A3',
2793
+				'0xA5' => '0xC2A5', '0xA6' => '0xC2A6', '0xA7' => '0xC2A7',
2794
+				'0xA8' => '0xC2A8', '0xA9' => '0xC2A9', '0xAB' => '0xC2AB',
2795
+				'0xAC' => '0xC2AC', '0xAD' => '0xC2AD', '0xAE' => '0xC2AE',
2796
+				'0xAF' => '0xC2AF', '0xB0' => '0xC2B0', '0xB1' => '0xC2B1',
2797
+				'0xB2' => '0xC2B2', '0xB3' => '0xC2B3', '0xB4' => '0xC2B4',
2798
+				'0xB5' => '0xC2B5', '0xB6' => '0xC2B6', '0xB7' => '0xC2B7',
2799
+				'0xB8' => '0xC2B8', '0xB9' => '0xC2B9', '0xBB' => '0xC2BB',
2800
+				'0xBC' => '0xC2BC', '0xBD' => '0xC2BD', '0xBE' => '0xC2BE',
2801
+				'0xBF' => '0xC2BF', '0xD7' => '0xD7B3', '0xD1' => '0xD781',
2802
+				'0xD4' => '0xD7B0', '0xD5' => '0xD7B1', '0xD6' => '0xD7B2',
2803
+				'0xE0' => '0xD790', '0xEA' => '0xD79A', '0xEC' => '0xD79C',
2804
+				'0xED' => '0xD79D', '0xEE' => '0xD79E', '0xEF' => '0xD79F',
2805
+				'0xF0' => '0xD7A0', '0xF1' => '0xD7A1', '0xF2' => '0xD7A2',
2806
+				'0xF3' => '0xD7A3', '0xF5' => '0xD7A5', '0xF6' => '0xD7A6',
2807
+				'0xF7' => '0xD7A7', '0xF8' => '0xD7A8', '0xF9' => '0xD7A9',
2808
+				'0x82' => '0xE2809A', '0x84' => '0xE2809E', '0x85' => '0xE280A6',
2809
+				'0x86' => '0xE280A0', '0x87' => '0xE280A1', '0x89' => '0xE280B0',
2810
+				'0x8B' => '0xE280B9', '0x93' => '0xE2809C', '0x94' => '0xE2809D',
2811
+				'0x95' => '0xE280A2', '0x97' => '0xE28094', '0x99' => '0xE284A2',
2812
+				'0xC0' => '0xD6B0', '0xC1' => '0xD6B1', '0xC3' => '0xD6B3',
2813
+				'0xC4' => '0xD6B4', '0xC5' => '0xD6B5', '0xC6' => '0xD6B6',
2814
+				'0xC7' => '0xD6B7', '0xC8' => '0xD6B8', '0xC9' => '0xD6B9',
2815
+				'0xCB' => '0xD6BB', '0xCC' => '0xD6BC', '0xCD' => '0xD6BD',
2816
+				'0xCE' => '0xD6BE', '0xCF' => '0xD6BF', '0xD0' => '0xD780',
2817
+				'0xD2' => '0xD782', '0xE3' => '0xD793', '0xE4' => '0xD794',
2818
+				'0xE5' => '0xD795', '0xE7' => '0xD797', '0xE9' => '0xD799',
2819
+				'0xFD' => '0xE2808E', '0xFE' => '0xE2808F', '0x92' => '0xE28099',
2820
+				'0x83' => '0xC692', '0xD3' => '0xD783', '0x88' => '0xCB86',
2821
+				'0x98' => '0xCB9C', '0x91' => '0xE28098', '0x96' => '0xE28093',
2822
+				'0xBA' => '0xC3B7', '0x9B' => '0xE280BA', '0xAA' => '0xC397',
2823
+				'0xA4' => '0xE282AA', '0xE1' => '0xD791', '0xE6' => '0xD796',
2824
+				'0xE8' => '0xD798', '0xEB' => '0xD79B', '0xF4' => '0xD7A4',
2825 2825
 				'0xFA' => '0xD7AA',
2826 2826
 			),
2827 2827
 			'windows-1253' => array(
2828
-				'0x81' => '\'\'',			'0x88' => '\'\'',			'0x8A' => '\'\'',
2829
-				'0x8C' => '\'\'',			'0x8D' => '\'\'',			'0x8E' => '\'\'',
2830
-				'0x8F' => '\'\'',			'0x90' => '\'\'',			'0x98' => '\'\'',
2831
-				'0x9A' => '\'\'',			'0x9C' => '\'\'',			'0x9D' => '\'\'',
2832
-				'0x9E' => '\'\'',			'0x9F' => '\'\'',			'0xAA' => '\'\'',
2833
-				'0xD2' => '0xE282AC',			'0xFF' => '0xCE92',			'0xCE' => '0xCE9E',
2834
-				'0xB8' => '0xCE88',		'0xBA' => '0xCE8A',		'0xBC' => '0xCE8C',
2835
-				'0xBE' => '0xCE8E',		'0xBF' => '0xCE8F',		'0xC0' => '0xCE90',
2836
-				'0xC8' => '0xCE98',		'0xCA' => '0xCE9A',		'0xCC' => '0xCE9C',
2837
-				'0xCD' => '0xCE9D',		'0xCF' => '0xCE9F',		'0xDA' => '0xCEAA',
2838
-				'0xE8' => '0xCEB8',		'0xEA' => '0xCEBA',		'0xEC' => '0xCEBC',
2839
-				'0xEE' => '0xCEBE',		'0xEF' => '0xCEBF',		'0xC2' => '0xFF',
2840
-				'0xBD' => '0xC2BD',		'0xED' => '0xCEBD',		'0xB2' => '0xC2B2',
2841
-				'0xA0' => '0xC2A0',		'0xA3' => '0xC2A3',		'0xA4' => '0xC2A4',
2842
-				'0xA5' => '0xC2A5',		'0xA6' => '0xC2A6',		'0xA7' => '0xC2A7',
2843
-				'0xA8' => '0xC2A8',		'0xA9' => '0xC2A9',		'0xAB' => '0xC2AB',
2844
-				'0xAC' => '0xC2AC',		'0xAD' => '0xC2AD',		'0xAE' => '0xC2AE',
2845
-				'0xB0' => '0xC2B0',		'0xB1' => '0xC2B1',		'0xB3' => '0xC2B3',
2846
-				'0xB5' => '0xC2B5',		'0xB6' => '0xC2B6',		'0xB7' => '0xC2B7',
2847
-				'0xBB' => '0xC2BB',		'0xE2' => '0xCEB2',		'0x80' => '0xD2',
2848
-				'0x82' => '0xE2809A',	'0x84' => '0xE2809E',	'0x85' => '0xE280A6',
2849
-				'0x86' => '0xE280A0',	'0xA1' => '0xCE85',		'0xA2' => '0xCE86',
2850
-				'0x87' => '0xE280A1',	'0x89' => '0xE280B0',	'0xB9' => '0xCE89',
2851
-				'0x8B' => '0xE280B9',	'0x91' => '0xE28098',	'0x99' => '0xE284A2',
2852
-				'0x92' => '0xE28099',	'0x93' => '0xE2809C',	'0x94' => '0xE2809D',
2853
-				'0x95' => '0xE280A2',	'0x96' => '0xE28093',	'0x97' => '0xE28094',
2854
-				'0x9B' => '0xE280BA',	'0xAF' => '0xE28095',	'0xB4' => '0xCE84',
2855
-				'0xC1' => '0xCE91',		'0xC3' => '0xCE93',		'0xC4' => '0xCE94',
2856
-				'0xC5' => '0xCE95',		'0xC6' => '0xCE96',		'0x83' => '0xC692',
2857
-				'0xC7' => '0xCE97',		'0xC9' => '0xCE99',		'0xCB' => '0xCE9B',
2858
-				'0xD0' => '0xCEA0',		'0xD1' => '0xCEA1',		'0xD3' => '0xCEA3',
2859
-				'0xD4' => '0xCEA4',		'0xD5' => '0xCEA5',		'0xD6' => '0xCEA6',
2860
-				'0xD7' => '0xCEA7',		'0xD8' => '0xCEA8',		'0xD9' => '0xCEA9',
2861
-				'0xDB' => '0xCEAB',		'0xDC' => '0xCEAC',		'0xDD' => '0xCEAD',
2862
-				'0xDE' => '0xCEAE',		'0xDF' => '0xCEAF',		'0xE0' => '0xCEB0',
2863
-				'0xE1' => '0xCEB1',		'0xE3' => '0xCEB3',		'0xE4' => '0xCEB4',
2864
-				'0xE5' => '0xCEB5',		'0xE6' => '0xCEB6',		'0xE7' => '0xCEB7',
2865
-				'0xE9' => '0xCEB9',		'0xEB' => '0xCEBB',		'0xF0' => '0xCF80',
2866
-				'0xF1' => '0xCF81',		'0xF2' => '0xCF82',		'0xF3' => '0xCF83',
2867
-				'0xF4' => '0xCF84',		'0xF5' => '0xCF85',		'0xF6' => '0xCF86',
2868
-				'0xF7' => '0xCF87',		'0xF8' => '0xCF88',		'0xF9' => '0xCF89',
2869
-				'0xFA' => '0xCF8A',		'0xFB' => '0xCF8B',		'0xFC' => '0xCF8C',
2870
-				'0xFD' => '0xCF8D',		'0xFE' => '0xCF8E',
2828
+				'0x81' => '\'\'', '0x88' => '\'\'', '0x8A' => '\'\'',
2829
+				'0x8C' => '\'\'', '0x8D' => '\'\'', '0x8E' => '\'\'',
2830
+				'0x8F' => '\'\'', '0x90' => '\'\'', '0x98' => '\'\'',
2831
+				'0x9A' => '\'\'', '0x9C' => '\'\'', '0x9D' => '\'\'',
2832
+				'0x9E' => '\'\'', '0x9F' => '\'\'', '0xAA' => '\'\'',
2833
+				'0xD2' => '0xE282AC', '0xFF' => '0xCE92', '0xCE' => '0xCE9E',
2834
+				'0xB8' => '0xCE88', '0xBA' => '0xCE8A', '0xBC' => '0xCE8C',
2835
+				'0xBE' => '0xCE8E', '0xBF' => '0xCE8F', '0xC0' => '0xCE90',
2836
+				'0xC8' => '0xCE98', '0xCA' => '0xCE9A', '0xCC' => '0xCE9C',
2837
+				'0xCD' => '0xCE9D', '0xCF' => '0xCE9F', '0xDA' => '0xCEAA',
2838
+				'0xE8' => '0xCEB8', '0xEA' => '0xCEBA', '0xEC' => '0xCEBC',
2839
+				'0xEE' => '0xCEBE', '0xEF' => '0xCEBF', '0xC2' => '0xFF',
2840
+				'0xBD' => '0xC2BD', '0xED' => '0xCEBD', '0xB2' => '0xC2B2',
2841
+				'0xA0' => '0xC2A0', '0xA3' => '0xC2A3', '0xA4' => '0xC2A4',
2842
+				'0xA5' => '0xC2A5', '0xA6' => '0xC2A6', '0xA7' => '0xC2A7',
2843
+				'0xA8' => '0xC2A8', '0xA9' => '0xC2A9', '0xAB' => '0xC2AB',
2844
+				'0xAC' => '0xC2AC', '0xAD' => '0xC2AD', '0xAE' => '0xC2AE',
2845
+				'0xB0' => '0xC2B0', '0xB1' => '0xC2B1', '0xB3' => '0xC2B3',
2846
+				'0xB5' => '0xC2B5', '0xB6' => '0xC2B6', '0xB7' => '0xC2B7',
2847
+				'0xBB' => '0xC2BB', '0xE2' => '0xCEB2', '0x80' => '0xD2',
2848
+				'0x82' => '0xE2809A', '0x84' => '0xE2809E', '0x85' => '0xE280A6',
2849
+				'0x86' => '0xE280A0', '0xA1' => '0xCE85', '0xA2' => '0xCE86',
2850
+				'0x87' => '0xE280A1', '0x89' => '0xE280B0', '0xB9' => '0xCE89',
2851
+				'0x8B' => '0xE280B9', '0x91' => '0xE28098', '0x99' => '0xE284A2',
2852
+				'0x92' => '0xE28099', '0x93' => '0xE2809C', '0x94' => '0xE2809D',
2853
+				'0x95' => '0xE280A2', '0x96' => '0xE28093', '0x97' => '0xE28094',
2854
+				'0x9B' => '0xE280BA', '0xAF' => '0xE28095', '0xB4' => '0xCE84',
2855
+				'0xC1' => '0xCE91', '0xC3' => '0xCE93', '0xC4' => '0xCE94',
2856
+				'0xC5' => '0xCE95', '0xC6' => '0xCE96', '0x83' => '0xC692',
2857
+				'0xC7' => '0xCE97', '0xC9' => '0xCE99', '0xCB' => '0xCE9B',
2858
+				'0xD0' => '0xCEA0', '0xD1' => '0xCEA1', '0xD3' => '0xCEA3',
2859
+				'0xD4' => '0xCEA4', '0xD5' => '0xCEA5', '0xD6' => '0xCEA6',
2860
+				'0xD7' => '0xCEA7', '0xD8' => '0xCEA8', '0xD9' => '0xCEA9',
2861
+				'0xDB' => '0xCEAB', '0xDC' => '0xCEAC', '0xDD' => '0xCEAD',
2862
+				'0xDE' => '0xCEAE', '0xDF' => '0xCEAF', '0xE0' => '0xCEB0',
2863
+				'0xE1' => '0xCEB1', '0xE3' => '0xCEB3', '0xE4' => '0xCEB4',
2864
+				'0xE5' => '0xCEB5', '0xE6' => '0xCEB6', '0xE7' => '0xCEB7',
2865
+				'0xE9' => '0xCEB9', '0xEB' => '0xCEBB', '0xF0' => '0xCF80',
2866
+				'0xF1' => '0xCF81', '0xF2' => '0xCF82', '0xF3' => '0xCF83',
2867
+				'0xF4' => '0xCF84', '0xF5' => '0xCF85', '0xF6' => '0xCF86',
2868
+				'0xF7' => '0xCF87', '0xF8' => '0xCF88', '0xF9' => '0xCF89',
2869
+				'0xFA' => '0xCF8A', '0xFB' => '0xCF8B', '0xFC' => '0xCF8C',
2870
+				'0xFD' => '0xCF8D', '0xFE' => '0xCF8E',
2871 2871
 			),
2872 2872
 		);
2873 2873
 
@@ -3081,7 +3081,7 @@  discard block
 block discarded – undo
3081 3081
 
3082 3082
 		if ($upcontext['dropping_index'] && $command_line)
3083 3083
 		{
3084
-			echo "\n" . '', $txt['upgrade_fulltext_error'] ,'';
3084
+			echo "\n" . '', $txt['upgrade_fulltext_error'], '';
3085 3085
 			flush();
3086 3086
 		}
3087 3087
 	}
@@ -3425,7 +3425,7 @@  discard block
 block discarded – undo
3425 3425
 	{
3426 3426
 		echo '
3427 3427
 		<div class="error">
3428
-			<p>', $txt['upgrade_writable_files'] ,'</p>
3428
+			<p>', $txt['upgrade_writable_files'], '</p>
3429 3429
 			<ul class="error_content">
3430 3430
 				<li>' . implode('</li>
3431 3431
 				<li>', $upcontext['chmod']['files']) . '</li>
@@ -3791,12 +3791,12 @@  discard block
 block discarded – undo
3791 3791
 					<div class="errorbox">
3792 3792
 						<h3>', $txt['upgrade_warning'], '</h3>
3793 3793
 						<p>', sprintf($txt['upgrade_time_user'], $upcontext['user']['name']), '</p>
3794
-						<p>', sprintf($txt[$agoTxt],  $ago_seconds, $ago_minutes, $ago_hours), '</p>
3794
+						<p>', sprintf($txt[$agoTxt], $ago_seconds, $ago_minutes, $ago_hours), '</p>
3795 3795
 						<p>', sprintf($txt[$updatedTxt], $updated_seconds, $updated_minutes, $updated_hours), '</p>';
3796 3796
 
3797 3797
 		if ($updated < 600)
3798 3798
 			echo '
3799
-						<p>', $txt['upgrade_run_script'], ' ', $upcontext['user']['name'],' ', $txt['upgrade_run_script2'], '</p>';
3799
+						<p>', $txt['upgrade_run_script'], ' ', $upcontext['user']['name'], ' ', $txt['upgrade_run_script2'], '</p>';
3800 3800
 
3801 3801
 		if ($updated > $upcontext['inactive_timeout'])
3802 3802
 			echo '
@@ -3905,7 +3905,7 @@  discard block
 block discarded – undo
3905 3905
 	if (!empty($upcontext['upgrade_options_warning']))
3906 3906
 		echo '
3907 3907
 				<div class="errorbox">
3908
-					<h3>', $txt['upgrade_warning'] ,'</h3>
3908
+					<h3>', $txt['upgrade_warning'], '</h3>
3909 3909
 					', $upcontext['upgrade_options_warning'], '
3910 3910
 				</div>';
3911 3911
 
@@ -3969,7 +3969,7 @@  discard block
 block discarded – undo
3969 3969
 	echo '
3970 3970
 				<form action="', $upcontext['form_url'], '" name="upform" id="upform" method="post">
3971 3971
 					<input type="hidden" name="backup_done" id="backup_done" value="0">
3972
-					<strong>', sprintf($txt['upgrade_completedtables_outof'], $upcontext['cur_table_num'], $upcontext['table_count']) ,'</strong>
3972
+					<strong>', sprintf($txt['upgrade_completedtables_outof'], $upcontext['cur_table_num'], $upcontext['table_count']), '</strong>
3973 3973
 					<div id="debug_section">
3974 3974
 						<span id="debuginfo"></span>
3975 3975
 					</div>';
Please login to merge, or discard this patch.
Themes/default/Recent.template.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -21,7 +21,7 @@  discard block
 block discarded – undo
21 21
 	<div id="recent" class="main_section">
22 22
 		<div class="cat_bar">
23 23
 			<h3 class="catbg">
24
-				<span class="xx"></span>',$txt['recent_posts'],'
24
+				<span class="xx"></span>',$txt['recent_posts'], '
25 25
 			</h3>
26 26
 		</div>
27 27
 		<div class="pagesection">', $context['page_index'], '</div>';
@@ -164,7 +164,7 @@  discard block
 block discarded – undo
164 164
 							<p class="floatleft">
165 165
 								', $topic['first_post']['started_by'], '
166 166
 							</p>
167
-							', !empty($topic['pages']) ? '<span id="pages'.$topic['first_post']['id'].'" class="topic_pages">'.$topic['pages'].'</span>' : '', '
167
+							', !empty($topic['pages']) ? '<span id="pages' . $topic['first_post']['id'] . '" class="topic_pages">' . $topic['pages'] . '</span>' : '', '
168 168
 						</div><!-- .info -->
169 169
 						<div class="board_stats centertext">
170 170
 							<p>
@@ -315,7 +315,7 @@  discard block
 block discarded – undo
315 315
 							<p class="floatleft">
316 316
 								', $topic['first_post']['started_by'], '
317 317
 							</p>
318
-							', !empty($topic['pages']) ? '<span id="pages'.$topic['first_post']['id'].'" class="topic_pages">'.$topic['pages'].'</span>' : '', '
318
+							', !empty($topic['pages']) ? '<span id="pages' . $topic['first_post']['id'] . '" class="topic_pages">' . $topic['pages'] . '</span>' : '', '
319 319
 						</div><!-- .info -->
320 320
 						<div class="board_stats centertext">
321 321
 							<p>
Please login to merge, or discard this patch.
Themes/default/GenericList.template.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -72,7 +72,7 @@  discard block
 block discarded – undo
72 72
 	}
73 73
 
74 74
 	echo '
75
-		<table class="table_grid" ', !empty($list_id) ? 'id="'.$list_id.'"' : '', ' ', !empty($cur_list['width']) ? ' style="width:' . $cur_list['width'] . '"' : '', '>';
75
+		<table class="table_grid" ', !empty($list_id) ? 'id="' . $list_id . '"' : '', ' ', !empty($cur_list['width']) ? ' style="width:' . $cur_list['width'] . '"' : '', '>';
76 76
 
77 77
 	// Show the column headers.
78 78
 	$header_count = count($cur_list['headers']);
@@ -85,7 +85,7 @@  discard block
 block discarded – undo
85 85
 		// Loop through each column and add a table header.
86 86
 		foreach ($cur_list['headers'] as $col_header)
87 87
 			echo '
88
-					<th scope="col" id="header_', $list_id, '_', $col_header['id'], '" class="' , $col_header['id'], empty($col_header['class']) ? '' : ' '.$col_header['class'] , '"', empty($col_header['style']) ? '' : ' style="' . $col_header['style'] . '"', empty($col_header['colspan']) ? '' : ' colspan="' . $col_header['colspan'] . '"', '>
88
+					<th scope="col" id="header_', $list_id, '_', $col_header['id'], '" class="', $col_header['id'], empty($col_header['class']) ? '' : ' ' . $col_header['class'], '"', empty($col_header['style']) ? '' : ' style="' . $col_header['style'] . '"', empty($col_header['colspan']) ? '' : ' colspan="' . $col_header['colspan'] . '"', '>
89 89
 						', empty($col_header['href']) ? '' : '<a href="' . $col_header['href'] . '" rel="nofollow">', empty($col_header['label']) ? '' : $col_header['label'], empty($col_header['href']) ? '' : (empty($col_header['sort_image']) ? '</a>' : ' <span class="generic_icons sort_' . $col_header['sort_image'] . '"></span></a>'), '
90 90
 					</th>';
91 91
 
@@ -117,7 +117,7 @@  discard block
 block discarded – undo
117 117
 			if (!empty($row['data']))
118 118
 				foreach ($row['data'] as $row_id => $row_data)
119 119
 					echo '
120
-					<td class="', $row_id, empty($row_data['class']) ? '' : ' ' . $row_data['class'] .'', '"', empty($row_data['style']) ? '' : ' style="' . $row_data['style'] . '"', '>
120
+					<td class="', $row_id, empty($row_data['class']) ? '' : ' ' . $row_data['class'] . '', '"', empty($row_data['style']) ? '' : ' style="' . $row_data['style'] . '"', '>
121 121
 						', $row_data['value'], '
122 122
 					</td>';
123 123
 
Please login to merge, or discard this patch.