@@ -11,8 +11,9 @@ discard block |
||
11 | 11 | * @version 2.1 Beta 3 |
12 | 12 | */ |
13 | 13 | |
14 | -if (!defined('SMF')) |
|
14 | +if (!defined('SMF')) { |
|
15 | 15 | die('No direct access...'); |
16 | +} |
|
16 | 17 | |
17 | 18 | /** |
18 | 19 | * Converts the given UTF-8 string into lowercase. |
@@ -569,8 +570,8 @@ discard block |
||
569 | 570 | ); |
570 | 571 | while ($row = $smcFunc['db_fetch_assoc']($request)) |
571 | 572 | { |
572 | - if (safe_unserialize($row['extra']) === false && preg_match('~^(a:3:{s:5:"topic";i:\d+;s:7:"subject";s:)(\d+):"(.+)"(;s:6:"member";s:5:"\d+";})$~', $row['extra'], $matches) === 1) |
|
573 | - $smcFunc['db_query']('', ' |
|
573 | + if (safe_unserialize($row['extra']) === false && preg_match('~^(a:3:{s:5:"topic";i:\d+;s:7:"subject";s:)(\d+):"(.+)"(;s:6:"member";s:5:"\d+";})$~', $row['extra'], $matches) === 1) { |
|
574 | + $smcFunc['db_query']('', ' |
|
574 | 575 | UPDATE {db_prefix}log_actions |
575 | 576 | SET extra = {string:extra} |
576 | 577 | WHERE id_action = {int:current_action}', |
@@ -579,6 +580,7 @@ discard block |
||
579 | 580 | 'extra' => $matches[1] . strlen($matches[3]) . ':"' . $matches[3] . '"' . $matches[4], |
580 | 581 | ) |
581 | 582 | ); |
583 | + } |
|
582 | 584 | } |
583 | 585 | $smcFunc['db_free_result']($request); |
584 | 586 |
@@ -11,8 +11,9 @@ discard block |
||
11 | 11 | * @version 2.1 Beta 3 |
12 | 12 | */ |
13 | 13 | |
14 | -if (!defined('SMF')) |
|
14 | +if (!defined('SMF')) { |
|
15 | 15 | die('Hacking attempt...'); |
16 | +} |
|
16 | 17 | |
17 | 18 | /** |
18 | 19 | * Our Cache API class |
@@ -29,8 +30,9 @@ discard block |
||
29 | 30 | |
30 | 31 | $supported = function_exists('apc_fetch') && function_exists('apc_store'); |
31 | 32 | |
32 | - if ($test) |
|
33 | - return $supported; |
|
33 | + if ($test) { |
|
34 | + return $supported; |
|
35 | + } |
|
34 | 36 | return parent::isSupported() && $supported; |
35 | 37 | } |
36 | 38 | |
@@ -52,10 +54,11 @@ discard block |
||
52 | 54 | $key = $this->prefix . strtr($key, ':/', '-_'); |
53 | 55 | |
54 | 56 | // An extended key is needed to counteract a bug in APC. |
55 | - if ($value === null) |
|
56 | - return apc_delete($key . 'smf'); |
|
57 | - else |
|
58 | - return apc_store($key . 'smf', $value, $ttl); |
|
57 | + if ($value === null) { |
|
58 | + return apc_delete($key . 'smf'); |
|
59 | + } else { |
|
60 | + return apc_store($key . 'smf', $value, $ttl); |
|
61 | + } |
|
59 | 62 | } |
60 | 63 | |
61 | 64 | /** |
@@ -69,9 +72,9 @@ discard block |
||
69 | 72 | // Always returns true. |
70 | 73 | apc_clear_cache('user'); |
71 | 74 | apc_clear_cache('system'); |
75 | + } elseif ($type === 'user') { |
|
76 | + apc_clear_cache('user'); |
|
72 | 77 | } |
73 | - elseif ($type === 'user') |
|
74 | - apc_clear_cache('user'); |
|
75 | 78 | |
76 | 79 | $this->invalidateCache(); |
77 | 80 | return true; |
@@ -11,8 +11,9 @@ discard block |
||
11 | 11 | * @version 2.1 Beta 3 |
12 | 12 | */ |
13 | 13 | |
14 | -if (!defined('SMF')) |
|
14 | +if (!defined('SMF')) { |
|
15 | 15 | die('Hacking attempt...'); |
16 | +} |
|
16 | 17 | |
17 | 18 | /** |
18 | 19 | * Our Cache API class |
@@ -29,8 +30,9 @@ discard block |
||
29 | 30 | |
30 | 31 | $supported = function_exists('apcu_fetch') && function_exists('apcu_store'); |
31 | 32 | |
32 | - if ($test) |
|
33 | - return $supported; |
|
33 | + if ($test) { |
|
34 | + return $supported; |
|
35 | + } |
|
34 | 36 | return parent::isSupported() && $supported; |
35 | 37 | } |
36 | 38 | |
@@ -52,10 +54,11 @@ discard block |
||
52 | 54 | $key = $this->prefix . strtr($key, ':/', '-_'); |
53 | 55 | |
54 | 56 | // An extended key is needed to counteract a bug in APC. |
55 | - if ($value === null) |
|
56 | - return apcu_delete($key . 'smf'); |
|
57 | - else |
|
58 | - return apcu_store($key . 'smf', $value, $ttl); |
|
57 | + if ($value === null) { |
|
58 | + return apcu_delete($key . 'smf'); |
|
59 | + } else { |
|
60 | + return apcu_store($key . 'smf', $value, $ttl); |
|
61 | + } |
|
59 | 62 | } |
60 | 63 | |
61 | 64 | /** |
@@ -11,8 +11,9 @@ discard block |
||
11 | 11 | * @version 2.1 Beta 3 |
12 | 12 | */ |
13 | 13 | |
14 | -if (!defined('SMF')) |
|
14 | +if (!defined('SMF')) { |
|
15 | 15 | die('Hacking attempt...'); |
16 | +} |
|
16 | 17 | |
17 | 18 | /** |
18 | 19 | * Our Cache API class |
@@ -34,8 +35,9 @@ discard block |
||
34 | 35 | |
35 | 36 | $supported = class_exists('memcached'); |
36 | 37 | |
37 | - if ($test) |
|
38 | - return $supported; |
|
38 | + if ($test) { |
|
39 | + return $supported; |
|
40 | + } |
|
39 | 41 | return parent::isSupported() && $supported && !empty($cache_memcached); |
40 | 42 | } |
41 | 43 | |
@@ -54,9 +56,9 @@ discard block |
||
54 | 56 | $currentServers = $this->memcached->getServerList(); |
55 | 57 | foreach ($servers as $server) |
56 | 58 | { |
57 | - if (strpos($server,'/') !== false) |
|
58 | - $tempServer = array($server, 0); |
|
59 | - else |
|
59 | + if (strpos($server,'/') !== false) { |
|
60 | + $tempServer = array($server, 0); |
|
61 | + } else |
|
60 | 62 | { |
61 | 63 | $server = explode(':', $server); |
62 | 64 | $tempServer = array($server[0], isset($server[1]) ? $server[1] : 11211); |
@@ -74,8 +76,9 @@ discard block |
||
74 | 76 | } |
75 | 77 | |
76 | 78 | // Found it? |
77 | - if (empty($foundServer)) |
|
78 | - $this->memcached->addServer($tempServer[0], $tempServer[1]); |
|
79 | + if (empty($foundServer)) { |
|
80 | + $this->memcached->addServer($tempServer[0], $tempServer[1]); |
|
81 | + } |
|
79 | 82 | } |
80 | 83 | |
81 | 84 | // Best guess is this worked. |
@@ -92,8 +95,9 @@ discard block |
||
92 | 95 | $value = $this->memcached->get($key); |
93 | 96 | |
94 | 97 | // $value should return either data or false (from failure, key not found or empty array). |
95 | - if ($value === false) |
|
96 | - return null; |
|
98 | + if ($value === false) { |
|
99 | + return null; |
|
100 | + } |
|
97 | 101 | return $value; |
98 | 102 | } |
99 | 103 | |
@@ -136,8 +140,9 @@ discard block |
||
136 | 140 | $config_vars[] = $txt['cache_memcache_settings']; |
137 | 141 | $config_vars[] = array('cache_memcached', $txt['cache_memcache_servers'], 'file', 'text', 0, 'cache_memcached', 'postinput' => '<br /><div class="smalltext"><em>' . $txt['cache_memcache_servers_subtext'] . '</em></div>'); |
138 | 142 | |
139 | - if (!isset($context['settings_post_javascript'])) |
|
140 | - $context['settings_post_javascript'] = ''; |
|
143 | + if (!isset($context['settings_post_javascript'])) { |
|
144 | + $context['settings_post_javascript'] = ''; |
|
145 | + } |
|
141 | 146 | |
142 | 147 | $context['settings_post_javascript'] .= ' |
143 | 148 | $("#cache_accelerator").change(function (e) { |
@@ -14,8 +14,9 @@ discard block |
||
14 | 14 | // This won't be dedicated without this - this must exist in each gateway! |
15 | 15 | // SMF Payment Gateway: paypal |
16 | 16 | |
17 | -if (!defined('SMF')) |
|
17 | +if (!defined('SMF')) { |
|
18 | 18 | die('No direct access...'); |
19 | +} |
|
19 | 20 | |
20 | 21 | /** |
21 | 22 | * Class for returning available form data for this gateway |
@@ -118,8 +119,7 @@ discard block |
||
118 | 119 | { |
119 | 120 | $return_data['hidden']['p3'] = 1; |
120 | 121 | $return_data['hidden']['t3'] = strtoupper(substr($period, 0, 1)); |
121 | - } |
|
122 | - else |
|
122 | + } else |
|
123 | 123 | { |
124 | 124 | preg_match('~(\d*)(\w)~', $sub_data['real_length'], $match); |
125 | 125 | $unit = $match[1]; |
@@ -130,14 +130,15 @@ discard block |
||
130 | 130 | } |
131 | 131 | |
132 | 132 | // If it's repeatable do some javascript to respect this idea. |
133 | - if (!empty($sub_data['repeatable'])) |
|
134 | - $return_data['javascript'] = ' |
|
133 | + if (!empty($sub_data['repeatable'])) { |
|
134 | + $return_data['javascript'] = ' |
|
135 | 135 | document.write(\'<label for="do_paypal_recur"><input type="checkbox" name="do_paypal_recur" id="do_paypal_recur" checked onclick="switchPaypalRecur();" class="input_check">' . $txt['paid_make_recurring'] . '</label><br>\'); |
136 | 136 | |
137 | 137 | function switchPaypalRecur() |
138 | 138 | { |
139 | 139 | document.getElementById("paypal_cmd").value = document.getElementById("do_paypal_recur").checked ? "_xclick-subscriptions" : "_xclick"; |
140 | 140 | }'; |
141 | + } |
|
141 | 142 | |
142 | 143 | return $return_data; |
143 | 144 | } |
@@ -160,20 +161,24 @@ discard block |
||
160 | 161 | global $modSettings; |
161 | 162 | |
162 | 163 | // Has the user set up an email address? |
163 | - if ((empty($modSettings['paidsubs_test']) && empty($modSettings['paypal_email'])) || (!empty($modSettings['paidsubs_test']) && empty($modSettings['paypal_sandbox_email']))) |
|
164 | - return false; |
|
164 | + if ((empty($modSettings['paidsubs_test']) && empty($modSettings['paypal_email'])) || (!empty($modSettings['paidsubs_test']) && empty($modSettings['paypal_sandbox_email']))) { |
|
165 | + return false; |
|
166 | + } |
|
165 | 167 | // Check the correct transaction types are even here. |
166 | - if ((!isset($_POST['txn_type']) && !isset($_POST['payment_status'])) || (!isset($_POST['business']) && !isset($_POST['receiver_email']))) |
|
167 | - return false; |
|
168 | + if ((!isset($_POST['txn_type']) && !isset($_POST['payment_status'])) || (!isset($_POST['business']) && !isset($_POST['receiver_email']))) { |
|
169 | + return false; |
|
170 | + } |
|
168 | 171 | // Correct email address? |
169 | - if (!isset($_POST['business'])) |
|
170 | - $_POST['business'] = $_POST['receiver_email']; |
|
172 | + if (!isset($_POST['business'])) { |
|
173 | + $_POST['business'] = $_POST['receiver_email']; |
|
174 | + } |
|
171 | 175 | |
172 | 176 | // Are we testing? |
173 | - if (empty($modSettings['paidsubs_test']) && strtolower($modSettings['paypal_sandbox_email']) != strtolower($_POST['business']) && (empty($modSettings['paypal_additional_emails']) || !in_array(strtolower($_POST['business']), explode(',', strtolower($modSettings['paypal_additional_emails']))))) |
|
174 | - return false; |
|
175 | - elseif (strtolower($modSettings['paypal_email']) != strtolower($_POST['business']) && (empty($modSettings['paypal_additional_emails']) || !in_array(strtolower($_POST['business']), explode(',', $modSettings['paypal_additional_emails'])))) |
|
176 | - return false; |
|
177 | + if (empty($modSettings['paidsubs_test']) && strtolower($modSettings['paypal_sandbox_email']) != strtolower($_POST['business']) && (empty($modSettings['paypal_additional_emails']) || !in_array(strtolower($_POST['business']), explode(',', strtolower($modSettings['paypal_additional_emails']))))) { |
|
178 | + return false; |
|
179 | + } elseif (strtolower($modSettings['paypal_email']) != strtolower($_POST['business']) && (empty($modSettings['paypal_additional_emails']) || !in_array(strtolower($_POST['business']), explode(',', $modSettings['paypal_additional_emails'])))) { |
|
180 | + return false; |
|
181 | + } |
|
177 | 182 | return true; |
178 | 183 | } |
179 | 184 | |
@@ -192,15 +197,17 @@ discard block |
||
192 | 197 | global $modSettings, $txt; |
193 | 198 | |
194 | 199 | // Put this to some default value. |
195 | - if (!isset($_POST['txn_type'])) |
|
196 | - $_POST['txn_type'] = ''; |
|
200 | + if (!isset($_POST['txn_type'])) { |
|
201 | + $_POST['txn_type'] = ''; |
|
202 | + } |
|
197 | 203 | |
198 | 204 | // Build the request string - starting with the minimum requirement. |
199 | 205 | $requestString = 'cmd=_notify-validate'; |
200 | 206 | |
201 | 207 | // Now my dear, add all the posted bits in the order we got them |
202 | - foreach ($_POST as $k => $v) |
|
203 | - $requestString .= '&' . $k . '=' . urlencode($v); |
|
208 | + foreach ($_POST as $k => $v) { |
|
209 | + $requestString .= '&' . $k . '=' . urlencode($v); |
|
210 | + } |
|
204 | 211 | |
205 | 212 | // Can we use curl? |
206 | 213 | if (function_exists('curl_init') && $curl = curl_init((!empty($modSettings['paidsubs_test']) ? 'https://www.sandbox.' : 'http://www.') . 'paypal.com/cgi-bin/webscr')) |
@@ -240,14 +247,16 @@ discard block |
||
240 | 247 | $header .= 'Connection: close' . "\r\n\r\n"; |
241 | 248 | |
242 | 249 | // Open the connection. |
243 | - if (!empty($modSettings['paidsubs_test'])) |
|
244 | - $fp = fsockopen('ssl://www.sandbox.paypal.com', 443, $errno, $errstr, 30); |
|
245 | - else |
|
246 | - $fp = fsockopen('www.paypal.com', 80, $errno, $errstr, 30); |
|
250 | + if (!empty($modSettings['paidsubs_test'])) { |
|
251 | + $fp = fsockopen('ssl://www.sandbox.paypal.com', 443, $errno, $errstr, 30); |
|
252 | + } else { |
|
253 | + $fp = fsockopen('www.paypal.com', 80, $errno, $errstr, 30); |
|
254 | + } |
|
247 | 255 | |
248 | 256 | // Did it work? |
249 | - if (!$fp) |
|
250 | - generateSubscriptionError($txt['paypal_could_not_connect']); |
|
257 | + if (!$fp) { |
|
258 | + generateSubscriptionError($txt['paypal_could_not_connect']); |
|
259 | + } |
|
251 | 260 | |
252 | 261 | // Put the data to the port. |
253 | 262 | fputs($fp, $header . $requestString); |
@@ -256,8 +265,9 @@ discard block |
||
256 | 265 | while (!feof($fp)) |
257 | 266 | { |
258 | 267 | $this->return_data = fgets($fp, 1024); |
259 | - if (strcmp(trim($this->return_data), 'VERIFIED') === 0) |
|
260 | - break; |
|
268 | + if (strcmp(trim($this->return_data), 'VERIFIED') === 0) { |
|
269 | + break; |
|
270 | + } |
|
261 | 271 | } |
262 | 272 | |
263 | 273 | // Clean up. |
@@ -265,28 +275,34 @@ discard block |
||
265 | 275 | } |
266 | 276 | |
267 | 277 | // If this isn't verified then give up... |
268 | - if (strcmp(trim($this->return_data), 'VERIFIED') !== 0) |
|
269 | - exit; |
|
278 | + if (strcmp(trim($this->return_data), 'VERIFIED') !== 0) { |
|
279 | + exit; |
|
280 | + } |
|
270 | 281 | |
271 | 282 | // Check that this is intended for us. |
272 | - if (strtolower($modSettings['paypal_email']) != strtolower($_POST['business']) && (empty($modSettings['paypal_additional_emails']) || !in_array(strtolower($_POST['business']), explode(',', strtolower($modSettings['paypal_additional_emails']))))) |
|
273 | - exit; |
|
283 | + if (strtolower($modSettings['paypal_email']) != strtolower($_POST['business']) && (empty($modSettings['paypal_additional_emails']) || !in_array(strtolower($_POST['business']), explode(',', strtolower($modSettings['paypal_additional_emails']))))) { |
|
284 | + exit; |
|
285 | + } |
|
274 | 286 | |
275 | 287 | // Is this a subscription - and if so is it a secondary payment that we need to process? |
276 | 288 | // If so, make sure we get it in the expected format. Seems PayPal sometimes sends it without urlencoding. |
277 | - if (!empty($_POST['item_number']) && strpos($_POST['item_number'], ' ') !== false) |
|
278 | - $_POST['item_number'] = str_replace(' ', '+', $_POST['item_number']); |
|
279 | - if ($this->isSubscription() && (empty($_POST['item_number']) || strpos($_POST['item_number'], '+') === false)) |
|
280 | - // Calculate the subscription it relates to! |
|
289 | + if (!empty($_POST['item_number']) && strpos($_POST['item_number'], ' ') !== false) { |
|
290 | + $_POST['item_number'] = str_replace(' ', '+', $_POST['item_number']); |
|
291 | + } |
|
292 | + if ($this->isSubscription() && (empty($_POST['item_number']) || strpos($_POST['item_number'], '+') === false)) { |
|
293 | + // Calculate the subscription it relates to! |
|
281 | 294 | $this->_findSubscription(); |
295 | + } |
|
282 | 296 | |
283 | 297 | // Verify the currency! |
284 | - if (strtolower($_POST['mc_currency']) !== strtolower($modSettings['paid_currency_code'])) |
|
285 | - exit; |
|
298 | + if (strtolower($_POST['mc_currency']) !== strtolower($modSettings['paid_currency_code'])) { |
|
299 | + exit; |
|
300 | + } |
|
286 | 301 | |
287 | 302 | // Can't exist if it doesn't contain anything. |
288 | - if (empty($_POST['item_number'])) |
|
289 | - exit; |
|
303 | + if (empty($_POST['item_number'])) { |
|
304 | + exit; |
|
305 | + } |
|
290 | 306 | |
291 | 307 | // Return the id_sub and id_member |
292 | 308 | return explode('+', $_POST['item_number']); |
@@ -299,10 +315,11 @@ discard block |
||
299 | 315 | */ |
300 | 316 | public function isRefund() |
301 | 317 | { |
302 | - if ($_POST['payment_status'] === 'Refunded' || $_POST['payment_status'] === 'Reversed' || $_POST['txn_type'] === 'Refunded' || ($_POST['txn_type'] === 'reversal' && $_POST['payment_status'] === 'Completed')) |
|
303 | - return true; |
|
304 | - else |
|
305 | - return false; |
|
318 | + if ($_POST['payment_status'] === 'Refunded' || $_POST['payment_status'] === 'Reversed' || $_POST['txn_type'] === 'Refunded' || ($_POST['txn_type'] === 'reversal' && $_POST['payment_status'] === 'Completed')) { |
|
319 | + return true; |
|
320 | + } else { |
|
321 | + return false; |
|
322 | + } |
|
306 | 323 | } |
307 | 324 | |
308 | 325 | /** |
@@ -312,10 +329,11 @@ discard block |
||
312 | 329 | */ |
313 | 330 | public function isSubscription() |
314 | 331 | { |
315 | - if (substr($_POST['txn_type'], 0, 14) === 'subscr_payment' && $_POST['payment_status'] === 'Completed') |
|
316 | - return true; |
|
317 | - else |
|
318 | - return false; |
|
332 | + if (substr($_POST['txn_type'], 0, 14) === 'subscr_payment' && $_POST['payment_status'] === 'Completed') { |
|
333 | + return true; |
|
334 | + } else { |
|
335 | + return false; |
|
336 | + } |
|
319 | 337 | } |
320 | 338 | |
321 | 339 | /** |
@@ -325,10 +343,11 @@ discard block |
||
325 | 343 | */ |
326 | 344 | public function isPayment() |
327 | 345 | { |
328 | - if ($_POST['payment_status'] === 'Completed' && $_POST['txn_type'] === 'web_accept') |
|
329 | - return true; |
|
330 | - else |
|
331 | - return false; |
|
346 | + if ($_POST['payment_status'] === 'Completed' && $_POST['txn_type'] === 'web_accept') { |
|
347 | + return true; |
|
348 | + } else { |
|
349 | + return false; |
|
350 | + } |
|
332 | 351 | } |
333 | 352 | |
334 | 353 | /** |
@@ -341,10 +360,11 @@ discard block |
||
341 | 360 | // subscr_cancel is sent when the user cancels, subscr_eot is sent when the subscription reaches final payment |
342 | 361 | // Neither require us to *do* anything as per performCancel(). |
343 | 362 | // subscr_eot, if sent, indicates an end of payments term. |
344 | - if (substr($_POST['txn_type'], 0, 13) === 'subscr_cancel' || substr($_POST['txn_type'], 0, 10) === 'subscr_eot') |
|
345 | - return true; |
|
346 | - else |
|
347 | - return false; |
|
363 | + if (substr($_POST['txn_type'], 0, 13) === 'subscr_cancel' || substr($_POST['txn_type'], 0, 10) === 'subscr_eot') { |
|
364 | + return true; |
|
365 | + } else { |
|
366 | + return false; |
|
367 | + } |
|
348 | 368 | } |
349 | 369 | |
350 | 370 | /** |
@@ -409,8 +429,9 @@ discard block |
||
409 | 429 | global $smcFunc; |
410 | 430 | |
411 | 431 | // Assume we have this? |
412 | - if (empty($_POST['subscr_id'])) |
|
413 | - return false; |
|
432 | + if (empty($_POST['subscr_id'])) { |
|
433 | + return false; |
|
434 | + } |
|
414 | 435 | |
415 | 436 | // Do we have this in the database? |
416 | 437 | $request = $smcFunc['db_query']('', ' |
@@ -439,11 +460,12 @@ discard block |
||
439 | 460 | 'payer_email' => $_POST['payer_email'], |
440 | 461 | ) |
441 | 462 | ); |
442 | - if ($smcFunc['db_num_rows']($request) === 0) |
|
443 | - return false; |
|
463 | + if ($smcFunc['db_num_rows']($request) === 0) { |
|
464 | + return false; |
|
465 | + } |
|
466 | + } else { |
|
467 | + return false; |
|
444 | 468 | } |
445 | - else |
|
446 | - return false; |
|
447 | 469 | } |
448 | 470 | list ($member_id, $subscription_id) = $smcFunc['db_fetch_row']($request); |
449 | 471 | $_POST['item_number'] = $member_id . '+' . $subscription_id; |
@@ -13,8 +13,9 @@ discard block |
||
13 | 13 | * @version 2.1 Beta 3 |
14 | 14 | */ |
15 | 15 | |
16 | -if (!defined('SMF')) |
|
16 | +if (!defined('SMF')) { |
|
17 | 17 | die('No direct access...'); |
18 | +} |
|
18 | 19 | |
19 | 20 | /** |
20 | 21 | * Display some useful/interesting board statistics. |
@@ -30,8 +31,9 @@ discard block |
||
30 | 31 | |
31 | 32 | isAllowedTo('view_stats'); |
32 | 33 | // Page disabled - redirect them out |
33 | - if (empty($modSettings['trackStats'])) |
|
34 | - fatal_lang_error('feature_disabled', true); |
|
34 | + if (empty($modSettings['trackStats'])) { |
|
35 | + fatal_lang_error('feature_disabled', true); |
|
36 | + } |
|
35 | 37 | |
36 | 38 | if (!empty($_REQUEST['expand'])) |
37 | 39 | { |
@@ -39,31 +41,34 @@ discard block |
||
39 | 41 | |
40 | 42 | $month = (int) substr($_REQUEST['expand'], 4); |
41 | 43 | $year = (int) substr($_REQUEST['expand'], 0, 4); |
42 | - if ($year > 1900 && $year < 2200 && $month >= 1 && $month <= 12) |
|
43 | - $_SESSION['expanded_stats'][$year][] = $month; |
|
44 | - } |
|
45 | - elseif (!empty($_REQUEST['collapse'])) |
|
44 | + if ($year > 1900 && $year < 2200 && $month >= 1 && $month <= 12) { |
|
45 | + $_SESSION['expanded_stats'][$year][] = $month; |
|
46 | + } |
|
47 | + } elseif (!empty($_REQUEST['collapse'])) |
|
46 | 48 | { |
47 | 49 | $context['robot_no_index'] = true; |
48 | 50 | |
49 | 51 | $month = (int) substr($_REQUEST['collapse'], 4); |
50 | 52 | $year = (int) substr($_REQUEST['collapse'], 0, 4); |
51 | - if (!empty($_SESSION['expanded_stats'][$year])) |
|
52 | - $_SESSION['expanded_stats'][$year] = array_diff($_SESSION['expanded_stats'][$year], array($month)); |
|
53 | + if (!empty($_SESSION['expanded_stats'][$year])) { |
|
54 | + $_SESSION['expanded_stats'][$year] = array_diff($_SESSION['expanded_stats'][$year], array($month)); |
|
55 | + } |
|
53 | 56 | } |
54 | 57 | |
55 | 58 | // Handle the XMLHttpRequest. |
56 | 59 | if (isset($_REQUEST['xml'])) |
57 | 60 | { |
58 | 61 | // Collapsing stats only needs adjustments of the session variables. |
59 | - if (!empty($_REQUEST['collapse'])) |
|
60 | - obExit(false); |
|
62 | + if (!empty($_REQUEST['collapse'])) { |
|
63 | + obExit(false); |
|
64 | + } |
|
61 | 65 | |
62 | 66 | $context['sub_template'] = 'stats'; |
63 | 67 | $context['yearly'] = array(); |
64 | 68 | |
65 | - if (empty($month) || empty($year)) |
|
66 | - return; |
|
69 | + if (empty($month) || empty($year)) { |
|
70 | + return; |
|
71 | + } |
|
67 | 72 | |
68 | 73 | getDailyStats('YEAR(date) = {int:year} AND MONTH(date) = {int:month}', array('year' => $year, 'month' => $month)); |
69 | 74 | $context['yearly'][$year]['months'][$month]['date'] = array( |
@@ -220,8 +225,9 @@ discard block |
||
220 | 225 | 'link' => '<a href="' . $scripturl . '?action=profile;u=' . $row_members['id_member'] . '">' . $row_members['real_name'] . '</a>' |
221 | 226 | ); |
222 | 227 | |
223 | - if ($max_num_posts < $row_members['posts']) |
|
224 | - $max_num_posts = $row_members['posts']; |
|
228 | + if ($max_num_posts < $row_members['posts']) { |
|
229 | + $max_num_posts = $row_members['posts']; |
|
230 | + } |
|
225 | 231 | } |
226 | 232 | $smcFunc['db_free_result']($members_result); |
227 | 233 | |
@@ -257,8 +263,9 @@ discard block |
||
257 | 263 | 'link' => '<a href="' . $scripturl . '?board=' . $row_board['id_board'] . '.0">' . $row_board['name'] . '</a>' |
258 | 264 | ); |
259 | 265 | |
260 | - if ($max_num_posts < $row_board['num_posts']) |
|
261 | - $max_num_posts = $row_board['num_posts']; |
|
266 | + if ($max_num_posts < $row_board['num_posts']) { |
|
267 | + $max_num_posts = $row_board['num_posts']; |
|
268 | + } |
|
262 | 269 | } |
263 | 270 | $smcFunc['db_free_result']($boards_result); |
264 | 271 | |
@@ -284,12 +291,13 @@ discard block |
||
284 | 291 | ) |
285 | 292 | ); |
286 | 293 | $topic_ids = array(); |
287 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
288 | - $topic_ids[] = $row['id_topic']; |
|
294 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
295 | + $topic_ids[] = $row['id_topic']; |
|
296 | + } |
|
289 | 297 | $smcFunc['db_free_result']($request); |
298 | + } else { |
|
299 | + $topic_ids = array(); |
|
290 | 300 | } |
291 | - else |
|
292 | - $topic_ids = array(); |
|
293 | 301 | |
294 | 302 | // Topic replies top 10. |
295 | 303 | $topic_reply_result = $smcFunc['db_query']('', ' |
@@ -329,8 +337,9 @@ discard block |
||
329 | 337 | 'link' => '<a href="' . $scripturl . '?topic=' . $row_topic_reply['id_topic'] . '.0">' . $row_topic_reply['subject'] . '</a>' |
330 | 338 | ); |
331 | 339 | |
332 | - if ($max_num_replies < $row_topic_reply['num_replies']) |
|
333 | - $max_num_replies = $row_topic_reply['num_replies']; |
|
340 | + if ($max_num_replies < $row_topic_reply['num_replies']) { |
|
341 | + $max_num_replies = $row_topic_reply['num_replies']; |
|
342 | + } |
|
334 | 343 | } |
335 | 344 | $smcFunc['db_free_result']($topic_reply_result); |
336 | 345 | |
@@ -354,12 +363,13 @@ discard block |
||
354 | 363 | ) |
355 | 364 | ); |
356 | 365 | $topic_ids = array(); |
357 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
358 | - $topic_ids[] = $row['id_topic']; |
|
366 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
367 | + $topic_ids[] = $row['id_topic']; |
|
368 | + } |
|
359 | 369 | $smcFunc['db_free_result']($request); |
370 | + } else { |
|
371 | + $topic_ids = array(); |
|
360 | 372 | } |
361 | - else |
|
362 | - $topic_ids = array(); |
|
363 | 373 | |
364 | 374 | // Topic views top 10. |
365 | 375 | $topic_view_result = $smcFunc['db_query']('', ' |
@@ -399,8 +409,9 @@ discard block |
||
399 | 409 | 'link' => '<a href="' . $scripturl . '?topic=' . $row_topic_views['id_topic'] . '.0">' . $row_topic_views['subject'] . '</a>' |
400 | 410 | ); |
401 | 411 | |
402 | - if ($max_num < $row_topic_views['num_views']) |
|
403 | - $max_num = $row_topic_views['num_views']; |
|
412 | + if ($max_num < $row_topic_views['num_views']) { |
|
413 | + $max_num = $row_topic_views['num_views']; |
|
414 | + } |
|
404 | 415 | } |
405 | 416 | $smcFunc['db_free_result']($topic_view_result); |
406 | 417 | |
@@ -425,15 +436,17 @@ discard block |
||
425 | 436 | ) |
426 | 437 | ); |
427 | 438 | $members = array(); |
428 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
429 | - $members[$row['id_member_started']] = $row['hits']; |
|
439 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
440 | + $members[$row['id_member_started']] = $row['hits']; |
|
441 | + } |
|
430 | 442 | $smcFunc['db_free_result']($request); |
431 | 443 | |
432 | 444 | cache_put_data('stats_top_starters', $members, 360); |
433 | 445 | } |
434 | 446 | |
435 | - if (empty($members)) |
|
436 | - $members = array(0 => 0); |
|
447 | + if (empty($members)) { |
|
448 | + $members = array(0 => 0); |
|
449 | + } |
|
437 | 450 | |
438 | 451 | // Topic poster top 10. |
439 | 452 | $members_result = $smcFunc['db_query']('', ' |
@@ -458,8 +471,9 @@ discard block |
||
458 | 471 | 'link' => '<a href="' . $scripturl . '?action=profile;u=' . $row_members['id_member'] . '">' . $row_members['real_name'] . '</a>' |
459 | 472 | ); |
460 | 473 | |
461 | - if ($max_num < $members[$row_members['id_member']]) |
|
462 | - $max_num = $members[$row_members['id_member']]; |
|
474 | + if ($max_num < $members[$row_members['id_member']]) { |
|
475 | + $max_num = $members[$row_members['id_member']]; |
|
476 | + } |
|
463 | 477 | } |
464 | 478 | ksort($context['stats_blocks']['starters']); |
465 | 479 | $smcFunc['db_free_result']($members_result); |
@@ -488,8 +502,9 @@ discard block |
||
488 | 502 | while ($row_members = $smcFunc['db_fetch_assoc']($members_result)) |
489 | 503 | { |
490 | 504 | $temp2[] = (int) $row_members['id_member']; |
491 | - if (count($context['stats_blocks']['time_online']) >= 10) |
|
492 | - continue; |
|
505 | + if (count($context['stats_blocks']['time_online']) >= 10) { |
|
506 | + continue; |
|
507 | + } |
|
493 | 508 | |
494 | 509 | // Figure out the days, hours and minutes. |
495 | 510 | $timeDays = floor($row_members['total_time_logged_in'] / 86400); |
@@ -497,10 +512,12 @@ discard block |
||
497 | 512 | |
498 | 513 | // Figure out which things to show... (days, hours, minutes, etc.) |
499 | 514 | $timelogged = ''; |
500 | - if ($timeDays > 0) |
|
501 | - $timelogged .= $timeDays . $txt['totalTimeLogged5']; |
|
502 | - if ($timeHours > 0) |
|
503 | - $timelogged .= $timeHours . $txt['totalTimeLogged6']; |
|
515 | + if ($timeDays > 0) { |
|
516 | + $timelogged .= $timeDays . $txt['totalTimeLogged5']; |
|
517 | + } |
|
518 | + if ($timeHours > 0) { |
|
519 | + $timelogged .= $timeHours . $txt['totalTimeLogged6']; |
|
520 | + } |
|
504 | 521 | $timelogged .= floor(($row_members['total_time_logged_in'] % 3600) / 60) . $txt['totalTimeLogged7']; |
505 | 522 | |
506 | 523 | $context['stats_blocks']['time_online'][] = array( |
@@ -512,17 +529,20 @@ discard block |
||
512 | 529 | 'link' => '<a href="' . $scripturl . '?action=profile;u=' . $row_members['id_member'] . '">' . $row_members['real_name'] . '</a>' |
513 | 530 | ); |
514 | 531 | |
515 | - if ($max_time_online < $row_members['total_time_logged_in']) |
|
516 | - $max_time_online = $row_members['total_time_logged_in']; |
|
532 | + if ($max_time_online < $row_members['total_time_logged_in']) { |
|
533 | + $max_time_online = $row_members['total_time_logged_in']; |
|
534 | + } |
|
517 | 535 | } |
518 | 536 | $smcFunc['db_free_result']($members_result); |
519 | 537 | |
520 | - foreach ($context['stats_blocks']['time_online'] as $i => $member) |
|
521 | - $context['stats_blocks']['time_online'][$i]['percent'] = round(($member['seconds_online'] * 100) / $max_time_online); |
|
538 | + foreach ($context['stats_blocks']['time_online'] as $i => $member) { |
|
539 | + $context['stats_blocks']['time_online'][$i]['percent'] = round(($member['seconds_online'] * 100) / $max_time_online); |
|
540 | + } |
|
522 | 541 | |
523 | 542 | // Cache the ones we found for a bit, just so we don't have to look again. |
524 | - if ($temp !== $temp2) |
|
525 | - cache_put_data('stats_total_time_members', $temp2, 480); |
|
543 | + if ($temp !== $temp2) { |
|
544 | + cache_put_data('stats_total_time_members', $temp2, 480); |
|
545 | + } |
|
526 | 546 | |
527 | 547 | // Likes. |
528 | 548 | if (!empty($modSettings['enable_likes'])) |
@@ -558,13 +578,15 @@ discard block |
||
558 | 578 | 'link' => '<a href="' . $scripturl . '?msg=' . $row_liked_message['id_msg'] .'">' . $row_liked_message['subject'] . '</a>' |
559 | 579 | ); |
560 | 580 | |
561 | - if ($max_liked_message < $row_liked_message['likes']) |
|
562 | - $max_liked_message = $row_liked_message['likes']; |
|
581 | + if ($max_liked_message < $row_liked_message['likes']) { |
|
582 | + $max_liked_message = $row_liked_message['likes']; |
|
583 | + } |
|
563 | 584 | } |
564 | 585 | $smcFunc['db_free_result']($liked_messages); |
565 | 586 | |
566 | - foreach ($context['stats_blocks']['liked_messages'] as $i => $liked_messages) |
|
567 | - $context['stats_blocks']['liked_messages'][$i]['percent'] = round(($liked_messages['num'] * 100) / $max_liked_message); |
|
587 | + foreach ($context['stats_blocks']['liked_messages'] as $i => $liked_messages) { |
|
588 | + $context['stats_blocks']['liked_messages'][$i]['percent'] = round(($liked_messages['num'] * 100) / $max_liked_message); |
|
589 | + } |
|
568 | 590 | |
569 | 591 | // Liked users top 10. |
570 | 592 | $context['stats_blocks']['liked_users'] = array(); |
@@ -595,14 +617,16 @@ discard block |
||
595 | 617 | 'link' => '<a href="' . $scripturl . '?action=profile;u=' . $row_liked_users['liked_user'] . '">' . $row_liked_users['real_name'] . '</a>', |
596 | 618 | ); |
597 | 619 | |
598 | - if ($max_liked_users < $row_liked_users['count']) |
|
599 | - $max_liked_users = $row_liked_users['count']; |
|
620 | + if ($max_liked_users < $row_liked_users['count']) { |
|
621 | + $max_liked_users = $row_liked_users['count']; |
|
622 | + } |
|
600 | 623 | } |
601 | 624 | |
602 | 625 | $smcFunc['db_free_result']($liked_users); |
603 | 626 | |
604 | - foreach ($context['stats_blocks']['liked_users'] as $i => $liked_users) |
|
605 | - $context['stats_blocks']['liked_users'][$i]['percent'] = round(($liked_users['num'] * 100) / $max_liked_users); |
|
627 | + foreach ($context['stats_blocks']['liked_users'] as $i => $liked_users) { |
|
628 | + $context['stats_blocks']['liked_users'][$i]['percent'] = round(($liked_users['num'] * 100) / $max_liked_users); |
|
629 | + } |
|
606 | 630 | } |
607 | 631 | |
608 | 632 | // Activity by month. |
@@ -620,8 +644,8 @@ discard block |
||
620 | 644 | $ID_MONTH = $row_months['stats_year'] . sprintf('%02d', $row_months['stats_month']); |
621 | 645 | $expanded = !empty($_SESSION['expanded_stats'][$row_months['stats_year']]) && in_array($row_months['stats_month'], $_SESSION['expanded_stats'][$row_months['stats_year']]); |
622 | 646 | |
623 | - if (!isset($context['yearly'][$row_months['stats_year']])) |
|
624 | - $context['yearly'][$row_months['stats_year']] = array( |
|
647 | + if (!isset($context['yearly'][$row_months['stats_year']])) { |
|
648 | + $context['yearly'][$row_months['stats_year']] = array( |
|
625 | 649 | 'year' => $row_months['stats_year'], |
626 | 650 | 'new_topics' => 0, |
627 | 651 | 'new_posts' => 0, |
@@ -633,6 +657,7 @@ discard block |
||
633 | 657 | 'expanded' => false, |
634 | 658 | 'current_year' => $row_months['stats_year'] == date('Y'), |
635 | 659 | ); |
660 | + } |
|
636 | 661 | |
637 | 662 | $context['yearly'][$row_months['stats_year']]['months'][(int) $row_months['stats_month']] = array( |
638 | 663 | 'id' => $ID_MONTH, |
@@ -678,26 +703,30 @@ discard block |
||
678 | 703 | $context['yearly'][$year]['hits'] = comma_format($data['hits']); |
679 | 704 | |
680 | 705 | // Keep a list of collapsed years. |
681 | - if (!$data['expanded'] && !$data['current_year']) |
|
682 | - $context['collapsed_years'][] = $year; |
|
706 | + if (!$data['expanded'] && !$data['current_year']) { |
|
707 | + $context['collapsed_years'][] = $year; |
|
708 | + } |
|
683 | 709 | } |
684 | 710 | |
685 | - if (empty($_SESSION['expanded_stats'])) |
|
686 | - return; |
|
711 | + if (empty($_SESSION['expanded_stats'])) { |
|
712 | + return; |
|
713 | + } |
|
687 | 714 | |
688 | 715 | $condition_text = array(); |
689 | 716 | $condition_params = array(); |
690 | - foreach ($_SESSION['expanded_stats'] as $year => $months) |
|
691 | - if (!empty($months)) |
|
717 | + foreach ($_SESSION['expanded_stats'] as $year => $months) { |
|
718 | + if (!empty($months)) |
|
692 | 719 | { |
693 | 720 | $condition_text[] = 'YEAR(date) = {int:year_' . $year . '} AND MONTH(date) IN ({array_int:months_' . $year . '})'; |
721 | + } |
|
694 | 722 | $condition_params['year_' . $year] = $year; |
695 | 723 | $condition_params['months_' . $year] = $months; |
696 | 724 | } |
697 | 725 | |
698 | 726 | // No daily stats to even look at? |
699 | - if (empty($condition_text)) |
|
700 | - return; |
|
727 | + if (empty($condition_text)) { |
|
728 | + return; |
|
729 | + } |
|
701 | 730 | |
702 | 731 | getDailyStats(implode(' OR ', $condition_text), $condition_params); |
703 | 732 | |
@@ -723,8 +752,8 @@ discard block |
||
723 | 752 | ORDER BY stats_day ASC', |
724 | 753 | $condition_parameters |
725 | 754 | ); |
726 | - while ($row_days = $smcFunc['db_fetch_assoc']($days_result)) |
|
727 | - $context['yearly'][$row_days['stats_year']]['months'][(int) $row_days['stats_month']]['days'][] = array( |
|
755 | + while ($row_days = $smcFunc['db_fetch_assoc']($days_result)) { |
|
756 | + $context['yearly'][$row_days['stats_year']]['months'][(int) $row_days['stats_month']]['days'][] = array( |
|
728 | 757 | 'day' => sprintf('%02d', $row_days['stats_day']), |
729 | 758 | 'month' => sprintf('%02d', $row_days['stats_month']), |
730 | 759 | 'year' => $row_days['stats_year'], |
@@ -734,6 +763,7 @@ discard block |
||
734 | 763 | 'most_members_online' => comma_format($row_days['most_on']), |
735 | 764 | 'hits' => comma_format($row_days['hits']) |
736 | 765 | ); |
766 | + } |
|
737 | 767 | $smcFunc['db_free_result']($days_result); |
738 | 768 | } |
739 | 769 | |
@@ -752,16 +782,19 @@ discard block |
||
752 | 782 | global $modSettings, $user_info, $forum_version, $sourcedir; |
753 | 783 | |
754 | 784 | // First, is it disabled? |
755 | - if (empty($modSettings['allow_sm_stats'])) |
|
756 | - die(); |
|
785 | + if (empty($modSettings['allow_sm_stats'])) { |
|
786 | + die(); |
|
787 | + } |
|
757 | 788 | |
758 | 789 | // Are we saying who we are, and are we right? (OR an admin) |
759 | - if (!$user_info['is_admin'] && (!isset($_GET['sid']) || $_GET['sid'] != $modSettings['allow_sm_stats'])) |
|
760 | - die(); |
|
790 | + if (!$user_info['is_admin'] && (!isset($_GET['sid']) || $_GET['sid'] != $modSettings['allow_sm_stats'])) { |
|
791 | + die(); |
|
792 | + } |
|
761 | 793 | |
762 | 794 | // Verify the referer... |
763 | - if (!$user_info['is_admin'] && (!isset($_SERVER['HTTP_REFERER']) || md5($_SERVER['HTTP_REFERER']) != '746cb59a1a0d5cf4bd240e5a67c73085')) |
|
764 | - die(); |
|
795 | + if (!$user_info['is_admin'] && (!isset($_SERVER['HTTP_REFERER']) || md5($_SERVER['HTTP_REFERER']) != '746cb59a1a0d5cf4bd240e5a67c73085')) { |
|
796 | + die(); |
|
797 | + } |
|
765 | 798 | |
766 | 799 | // Get some server versions. |
767 | 800 | require_once($sourcedir . '/Subs-Admin.php'); |
@@ -787,16 +820,17 @@ discard block |
||
787 | 820 | ); |
788 | 821 | |
789 | 822 | // Encode all the data, for security. |
790 | - foreach ($stats_to_send as $k => $v) |
|
791 | - $stats_to_send[$k] = urlencode($k) . '=' . urlencode($v); |
|
823 | + foreach ($stats_to_send as $k => $v) { |
|
824 | + $stats_to_send[$k] = urlencode($k) . '=' . urlencode($v); |
|
825 | + } |
|
792 | 826 | |
793 | 827 | // Turn this into the query string! |
794 | 828 | $stats_to_send = implode('&', $stats_to_send); |
795 | 829 | |
796 | 830 | // If we're an admin, just plonk them out. |
797 | - if ($user_info['is_admin']) |
|
798 | - echo $stats_to_send; |
|
799 | - else |
|
831 | + if ($user_info['is_admin']) { |
|
832 | + echo $stats_to_send; |
|
833 | + } else |
|
800 | 834 | { |
801 | 835 | // Connect to the collection script. |
802 | 836 | $fp = @fsockopen('www.simplemachines.org', 80, $errno, $errstr); |
@@ -14,8 +14,9 @@ discard block |
||
14 | 14 | * @version 2.1 Beta 3 |
15 | 15 | */ |
16 | 16 | |
17 | -if (!defined('SMF')) |
|
17 | +if (!defined('SMF')) { |
|
18 | 18 | die('No direct access...'); |
19 | +} |
|
19 | 20 | |
20 | 21 | /** |
21 | 22 | * View the forum's error log. |
@@ -30,8 +31,9 @@ discard block |
||
30 | 31 | global $scripturl, $txt, $context, $modSettings, $user_profile, $filter, $smcFunc; |
31 | 32 | |
32 | 33 | // Viewing contents of a file? |
33 | - if (isset($_GET['file'])) |
|
34 | - return ViewFile(); |
|
34 | + if (isset($_GET['file'])) { |
|
35 | + return ViewFile(); |
|
36 | + } |
|
35 | 37 | |
36 | 38 | // Check for the administrative permission to do this. |
37 | 39 | isAllowedTo('admin_forum'); |
@@ -85,8 +87,8 @@ discard block |
||
85 | 87 | ); |
86 | 88 | |
87 | 89 | // Set up the filtering... |
88 | - if (isset($_GET['value'], $_GET['filter']) && isset($filters[$_GET['filter']])) |
|
89 | - $filter = array( |
|
90 | + if (isset($_GET['value'], $_GET['filter']) && isset($filters[$_GET['filter']])) { |
|
91 | + $filter = array( |
|
90 | 92 | 'variable' => $_GET['filter'], |
91 | 93 | 'value' => array( |
92 | 94 | 'sql' => in_array($_GET['filter'], array('message', 'url', 'file')) ? base64_decode(strtr($_GET['value'], array(' ' => '+'))) : $smcFunc['db_escape_wildcard_string']($_GET['value']), |
@@ -94,10 +96,12 @@ discard block |
||
94 | 96 | 'href' => ';filter=' . $_GET['filter'] . ';value=' . $_GET['value'], |
95 | 97 | 'entity' => $filters[$_GET['filter']]['txt'] |
96 | 98 | ); |
99 | + } |
|
97 | 100 | |
98 | 101 | // Deleting, are we? |
99 | - if (isset($_POST['delall']) || isset($_POST['delete'])) |
|
100 | - deleteErrors(); |
|
102 | + if (isset($_POST['delall']) || isset($_POST['delete'])) { |
|
103 | + deleteErrors(); |
|
104 | + } |
|
101 | 105 | |
102 | 106 | // Just how many errors are there? |
103 | 107 | $result = $smcFunc['db_query']('', ' |
@@ -112,12 +116,14 @@ discard block |
||
112 | 116 | $smcFunc['db_free_result']($result); |
113 | 117 | |
114 | 118 | // If this filter is empty... |
115 | - if ($num_errors == 0 && isset($filter)) |
|
116 | - redirectexit('action=admin;area=logs;sa=errorlog' . (isset($_REQUEST['desc']) ? ';desc' : '')); |
|
119 | + if ($num_errors == 0 && isset($filter)) { |
|
120 | + redirectexit('action=admin;area=logs;sa=errorlog' . (isset($_REQUEST['desc']) ? ';desc' : '')); |
|
121 | + } |
|
117 | 122 | |
118 | 123 | // Clean up start. |
119 | - if (!isset($_GET['start']) || $_GET['start'] < 0) |
|
120 | - $_GET['start'] = 0; |
|
124 | + if (!isset($_GET['start']) || $_GET['start'] < 0) { |
|
125 | + $_GET['start'] = 0; |
|
126 | + } |
|
121 | 127 | |
122 | 128 | // Do we want to reverse error listing? |
123 | 129 | $context['sort_direction'] = isset($_REQUEST['desc']) ? 'down' : 'up'; |
@@ -127,9 +133,9 @@ discard block |
||
127 | 133 | $context['start'] = $_GET['start']; |
128 | 134 | |
129 | 135 | // Update the error count |
130 | - if (!isset($filter)) |
|
131 | - $context['num_errors'] = $num_errors; |
|
132 | - else |
|
136 | + if (!isset($filter)) { |
|
137 | + $context['num_errors'] = $num_errors; |
|
138 | + } else |
|
133 | 139 | { |
134 | 140 | // We want all errors, not just the number of filtered messages... |
135 | 141 | $query = $smcFunc['db_query']('', ' |
@@ -161,8 +167,9 @@ discard block |
||
161 | 167 | for ($i = 0; $row = $smcFunc['db_fetch_assoc']($request); $i ++) |
162 | 168 | { |
163 | 169 | $search_message = preg_replace('~<span class="remove">(.+?)</span>~', '%', $smcFunc['db_escape_wildcard_string']($row['message'])); |
164 | - if ($search_message == $filter['value']['sql']) |
|
165 | - $search_message = $smcFunc['db_escape_wildcard_string']($row['message']); |
|
170 | + if ($search_message == $filter['value']['sql']) { |
|
171 | + $search_message = $smcFunc['db_escape_wildcard_string']($row['message']); |
|
172 | + } |
|
166 | 173 | $show_message = strtr(strtr(preg_replace('~<span class="remove">(.+?)</span>~', '$1', $row['message']), array("\r" => '', '<br>' => "\n", '<' => '<', '>' => '>', '"' => '"')), array("\n" => '<br>')); |
167 | 174 | |
168 | 175 | $context['errors'][$row['id_error']] = array( |
@@ -221,8 +228,9 @@ discard block |
||
221 | 228 | 'members' => count($members), |
222 | 229 | ) |
223 | 230 | ); |
224 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
225 | - $members[$row['id_member']] = $row; |
|
231 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
232 | + $members[$row['id_member']] = $row; |
|
233 | + } |
|
226 | 234 | $smcFunc['db_free_result']($request); |
227 | 235 | |
228 | 236 | // This is a guest... |
@@ -254,20 +262,18 @@ discard block |
||
254 | 262 | $id = $filter['value']['sql']; |
255 | 263 | loadMemberData($id, false, 'minimal'); |
256 | 264 | $context['filter']['value']['html'] = '<a href="' . $scripturl . '?action=profile;u=' . $id . '">' . $user_profile[$id]['real_name'] . '</a>'; |
257 | - } |
|
258 | - elseif ($filter['variable'] == 'url') |
|
259 | - $context['filter']['value']['html'] = '\'' . strtr($smcFunc['htmlspecialchars']((substr($filter['value']['sql'], 0, 1) == '?' ? $scripturl : '') . $filter['value']['sql']), array('\_' => '_')) . '\''; |
|
260 | - elseif ($filter['variable'] == 'message') |
|
265 | + } elseif ($filter['variable'] == 'url') { |
|
266 | + $context['filter']['value']['html'] = '\'' . strtr($smcFunc['htmlspecialchars']((substr($filter['value']['sql'], 0, 1) == '?' ? $scripturl : '') . $filter['value']['sql']), array('\_' => '_')) . '\''; |
|
267 | + } elseif ($filter['variable'] == 'message') |
|
261 | 268 | { |
262 | 269 | $context['filter']['value']['html'] = '\'' . strtr($smcFunc['htmlspecialchars']($filter['value']['sql']), array("\n" => '<br>', '<br />' => '<br>', "\t" => ' ', '\_' => '_', '\\%' => '%', '\\\\' => '\\')) . '\''; |
263 | 270 | $context['filter']['value']['html'] = preg_replace('~&lt;span class=&quot;remove&quot;&gt;(.+?)&lt;/span&gt;~', '$1', $context['filter']['value']['html']); |
264 | - } |
|
265 | - elseif ($filter['variable'] == 'error_type') |
|
271 | + } elseif ($filter['variable'] == 'error_type') |
|
266 | 272 | { |
267 | 273 | $context['filter']['value']['html'] = '\'' . strtr($smcFunc['htmlspecialchars']($filter['value']['sql']), array("\n" => '<br>', '<br />' => '<br>', "\t" => ' ', '\_' => '_', '\\%' => '%', '\\\\' => '\\')) . '\''; |
274 | + } else { |
|
275 | + $context['filter']['value']['html'] = &$filter['value']['sql']; |
|
268 | 276 | } |
269 | - else |
|
270 | - $context['filter']['value']['html'] = &$filter['value']['sql']; |
|
271 | 277 | } |
272 | 278 | |
273 | 279 | $context['error_types'] = array(); |
@@ -308,10 +314,11 @@ discard block |
||
308 | 314 | $context['error_types']['all']['label'] .= ' (' . $sum . ')'; |
309 | 315 | |
310 | 316 | // Finally, work out what is the last tab! |
311 | - if (isset($context['error_types'][$sum])) |
|
312 | - $context['error_types'][$sum]['is_last'] = true; |
|
313 | - else |
|
314 | - $context['error_types']['all']['is_last'] = true; |
|
317 | + if (isset($context['error_types'][$sum])) { |
|
318 | + $context['error_types'][$sum]['is_last'] = true; |
|
319 | + } else { |
|
320 | + $context['error_types']['all']['is_last'] = true; |
|
321 | + } |
|
315 | 322 | |
316 | 323 | // And this is pretty basic ;). |
317 | 324 | $context['page_title'] = $txt['errlog']; |
@@ -337,21 +344,23 @@ discard block |
||
337 | 344 | validateToken('admin-el'); |
338 | 345 | |
339 | 346 | // Delete all or just some? |
340 | - if (isset($_POST['delall']) && !isset($filter)) |
|
341 | - $smcFunc['db_query']('truncate_table', ' |
|
347 | + if (isset($_POST['delall']) && !isset($filter)) { |
|
348 | + $smcFunc['db_query']('truncate_table', ' |
|
342 | 349 | TRUNCATE {db_prefix}log_errors', |
343 | 350 | array( |
344 | 351 | ) |
345 | 352 | ); |
353 | + } |
|
346 | 354 | // Deleting all with a filter? |
347 | - elseif (isset($_POST['delall']) && isset($filter)) |
|
348 | - $smcFunc['db_query']('', ' |
|
355 | + elseif (isset($_POST['delall']) && isset($filter)) { |
|
356 | + $smcFunc['db_query']('', ' |
|
349 | 357 | DELETE FROM {db_prefix}log_errors |
350 | 358 | WHERE ' . $filter['variable'] . ' LIKE {string:filter}', |
351 | 359 | array( |
352 | 360 | 'filter' => $filter['value']['sql'], |
353 | 361 | ) |
354 | 362 | ); |
363 | + } |
|
355 | 364 | // Just specific errors? |
356 | 365 | elseif (!empty($_POST['delete'])) |
357 | 366 | { |
@@ -397,15 +406,17 @@ discard block |
||
397 | 406 | $line = isset($_REQUEST['line']) ? (int) $_REQUEST['line'] : 0; |
398 | 407 | |
399 | 408 | // Make sure the file we are looking for is one they are allowed to look at |
400 | - if ($ext != '.php' || (strpos($file, $real_board) === false && strpos($file, $real_source) === false) || ($basename == 'settings.php' || $basename == 'settings_bak.php') || strpos($file, $real_cache) !== false || !is_readable($file)) |
|
401 | - fatal_lang_error('error_bad_file', true, array($smcFunc['htmlspecialchars']($file))); |
|
409 | + if ($ext != '.php' || (strpos($file, $real_board) === false && strpos($file, $real_source) === false) || ($basename == 'settings.php' || $basename == 'settings_bak.php') || strpos($file, $real_cache) !== false || !is_readable($file)) { |
|
410 | + fatal_lang_error('error_bad_file', true, array($smcFunc['htmlspecialchars']($file))); |
|
411 | + } |
|
402 | 412 | |
403 | 413 | // get the min and max lines |
404 | 414 | $min = $line - 20 <= 0 ? 1 : $line - 20; |
405 | 415 | $max = $line + 21; // One additional line to make everything work out correctly |
406 | 416 | |
407 | - if ($max <= 0 || $min >= $max) |
|
408 | - fatal_lang_error('error_bad_line'); |
|
417 | + if ($max <= 0 || $min >= $max) { |
|
418 | + fatal_lang_error('error_bad_line'); |
|
419 | + } |
|
409 | 420 | |
410 | 421 | $file_data = explode('<br />', highlight_php_code($smcFunc['htmlspecialchars'](implode('', file($file))))); |
411 | 422 |
@@ -13,8 +13,9 @@ discard block |
||
13 | 13 | * @version 2.1 Beta 3 |
14 | 14 | */ |
15 | 15 | |
16 | -if (!defined('SMF')) |
|
16 | +if (!defined('SMF')) { |
|
17 | 17 | die('No direct access...'); |
18 | +} |
|
18 | 19 | |
19 | 20 | /** |
20 | 21 | * The main entrance point for the 'Posts and topics' screen. |
@@ -98,23 +99,23 @@ discard block |
||
98 | 99 | { |
99 | 100 | $_POST['censortext'] = explode("\n", strtr($_POST['censortext'], array("\r" => ''))); |
100 | 101 | |
101 | - foreach ($_POST['censortext'] as $c) |
|
102 | - list ($censored_vulgar[], $censored_proper[]) = array_pad(explode('=', trim($c)), 2, ''); |
|
103 | - } |
|
104 | - elseif (isset($_POST['censor_vulgar'], $_POST['censor_proper'])) |
|
102 | + foreach ($_POST['censortext'] as $c) { |
|
103 | + list ($censored_vulgar[], $censored_proper[]) = array_pad(explode('=', trim($c)), 2, ''); |
|
104 | + } |
|
105 | + } elseif (isset($_POST['censor_vulgar'], $_POST['censor_proper'])) |
|
105 | 106 | { |
106 | 107 | if (is_array($_POST['censor_vulgar'])) |
107 | 108 | { |
108 | 109 | foreach ($_POST['censor_vulgar'] as $i => $value) |
109 | 110 | { |
110 | - if (trim(strtr($value, '*', ' ')) == '') |
|
111 | - unset($_POST['censor_vulgar'][$i], $_POST['censor_proper'][$i]); |
|
111 | + if (trim(strtr($value, '*', ' ')) == '') { |
|
112 | + unset($_POST['censor_vulgar'][$i], $_POST['censor_proper'][$i]); |
|
113 | + } |
|
112 | 114 | } |
113 | 115 | |
114 | 116 | $censored_vulgar = $_POST['censor_vulgar']; |
115 | 117 | $censored_proper = $_POST['censor_proper']; |
116 | - } |
|
117 | - else |
|
118 | + } else |
|
118 | 119 | { |
119 | 120 | $censored_vulgar = explode("\n", strtr($_POST['censor_vulgar'], array("\r" => ''))); |
120 | 121 | $censored_proper = explode("\n", strtr($_POST['censor_proper'], array("\r" => ''))); |
@@ -151,12 +152,14 @@ discard block |
||
151 | 152 | $context['censored_words'] = array(); |
152 | 153 | for ($i = 0, $n = count($censor_vulgar); $i < $n; $i++) |
153 | 154 | { |
154 | - if (empty($censor_vulgar[$i])) |
|
155 | - continue; |
|
155 | + if (empty($censor_vulgar[$i])) { |
|
156 | + continue; |
|
157 | + } |
|
156 | 158 | |
157 | 159 | // Skip it, it's either spaces or stars only. |
158 | - if (trim(strtr($censor_vulgar[$i], '*', ' ')) == '') |
|
159 | - continue; |
|
160 | + if (trim(strtr($censor_vulgar[$i], '*', ' ')) == '') { |
|
161 | + continue; |
|
162 | + } |
|
160 | 163 | |
161 | 164 | $context['censored_words'][$smcFunc['htmlspecialchars'](trim($censor_vulgar[$i]))] = isset($censor_proper[$i]) ? $smcFunc['htmlspecialchars']($censor_proper[$i]) : ''; |
162 | 165 | } |
@@ -187,10 +190,11 @@ discard block |
||
187 | 190 | |
188 | 191 | // Make an inline conditional a little shorter... |
189 | 192 | $can_spell_check = false; |
190 | - if (function_exists('pspell_new')) |
|
191 | - $can_spell_check = true; |
|
192 | - elseif (function_exists('enchant_broker_init') && ($txt['lang_charset'] == 'UTF-8' || function_exists('iconv'))) |
|
193 | - $can_spell_check = true; |
|
193 | + if (function_exists('pspell_new')) { |
|
194 | + $can_spell_check = true; |
|
195 | + } elseif (function_exists('enchant_broker_init') && ($txt['lang_charset'] == 'UTF-8' || function_exists('iconv'))) { |
|
196 | + $can_spell_check = true; |
|
197 | + } |
|
194 | 198 | |
195 | 199 | // All the settings... |
196 | 200 | $config_vars = array( |
@@ -221,8 +225,9 @@ discard block |
||
221 | 225 | |
222 | 226 | call_integration_hook('integrate_modify_post_settings', array(&$config_vars)); |
223 | 227 | |
224 | - if ($return_config) |
|
225 | - return $config_vars; |
|
228 | + if ($return_config) { |
|
229 | + return $config_vars; |
|
230 | + } |
|
226 | 231 | |
227 | 232 | // We'll want this for our easy save. |
228 | 233 | require_once($sourcedir . '/ManageServer.php'); |
@@ -242,17 +247,20 @@ discard block |
||
242 | 247 | db_extend('packages'); |
243 | 248 | |
244 | 249 | $colData = $smcFunc['db_list_columns']('{db_prefix}messages', true); |
245 | - foreach ($colData as $column) |
|
246 | - if ($column['name'] == 'body') |
|
250 | + foreach ($colData as $column) { |
|
251 | + if ($column['name'] == 'body') |
|
247 | 252 | $body_type = $column['type']; |
253 | + } |
|
248 | 254 | |
249 | - if (isset($body_type) && ($_POST['max_messageLength'] > 65535 || $_POST['max_messageLength'] == 0) && $body_type == 'text') |
|
250 | - fatal_lang_error('convert_to_mediumtext', false, array($scripturl . '?action=admin;area=maintain;sa=database')); |
|
255 | + if (isset($body_type) && ($_POST['max_messageLength'] > 65535 || $_POST['max_messageLength'] == 0) && $body_type == 'text') { |
|
256 | + fatal_lang_error('convert_to_mediumtext', false, array($scripturl . '?action=admin;area=maintain;sa=database')); |
|
257 | + } |
|
251 | 258 | } |
252 | 259 | |
253 | 260 | // If we're changing the post preview length let's check its valid |
254 | - if (!empty($_POST['preview_characters'])) |
|
255 | - $_POST['preview_characters'] = (int) min(max(0, $_POST['preview_characters']), 512); |
|
261 | + if (!empty($_POST['preview_characters'])) { |
|
262 | + $_POST['preview_characters'] = (int) min(max(0, $_POST['preview_characters']), 512); |
|
263 | + } |
|
256 | 264 | |
257 | 265 | call_integration_hook('integrate_save_post_settings'); |
258 | 266 | |
@@ -313,8 +321,9 @@ discard block |
||
313 | 321 | |
314 | 322 | call_integration_hook('integrate_modify_topic_settings', array(&$config_vars)); |
315 | 323 | |
316 | - if ($return_config) |
|
317 | - return $config_vars; |
|
324 | + if ($return_config) { |
|
325 | + return $config_vars; |
|
326 | + } |
|
318 | 327 | |
319 | 328 | // Get the settings template ready. |
320 | 329 | require_once($sourcedir . '/ManageServer.php'); |
@@ -367,8 +376,9 @@ discard block |
||
367 | 376 | array('int', 'drafts_autosave_frequency', 'postinput' => $txt['manageposts_seconds'], 'subtext' => $txt['drafts_autosave_frequency_subnote']), |
368 | 377 | ); |
369 | 378 | |
370 | - if ($return_config) |
|
371 | - return $config_vars; |
|
379 | + if ($return_config) { |
|
380 | + return $config_vars; |
|
381 | + } |
|
372 | 382 | |
373 | 383 | // Get the settings template ready. |
374 | 384 | require_once($sourcedir . '/ManageServer.php'); |
@@ -15,8 +15,9 @@ discard block |
||
15 | 15 | * @version 2.1 Beta 3 |
16 | 16 | */ |
17 | 17 | |
18 | -if (!defined('SMF')) |
|
18 | +if (!defined('SMF')) { |
|
19 | 19 | die('No direct access...'); |
20 | +} |
|
20 | 21 | |
21 | 22 | /** |
22 | 23 | * This helps organize things... |
@@ -37,13 +38,14 @@ discard block |
||
37 | 38 | |
38 | 39 | loadLanguage('PersonalMessage+Drafts'); |
39 | 40 | |
40 | - if (!isset($_REQUEST['xml'])) |
|
41 | - loadTemplate('PersonalMessage'); |
|
41 | + if (!isset($_REQUEST['xml'])) { |
|
42 | + loadTemplate('PersonalMessage'); |
|
43 | + } |
|
42 | 44 | |
43 | 45 | // Load up the members maximum message capacity. |
44 | - if ($user_info['is_admin']) |
|
45 | - $context['message_limit'] = 0; |
|
46 | - elseif (($context['message_limit'] = cache_get_data('msgLimit:' . $user_info['id'], 360)) === null) |
|
46 | + if ($user_info['is_admin']) { |
|
47 | + $context['message_limit'] = 0; |
|
48 | + } elseif (($context['message_limit'] = cache_get_data('msgLimit:' . $user_info['id'], 360)) === null) |
|
47 | 49 | { |
48 | 50 | // @todo Why do we do this? It seems like if they have any limit we should use it. |
49 | 51 | $request = $smcFunc['db_query']('', ' |
@@ -78,8 +80,9 @@ discard block |
||
78 | 80 | } |
79 | 81 | |
80 | 82 | // a previous message was sent successfully? show a small indication. |
81 | - if (isset($_GET['done']) && ($_GET['done'] == 'sent')) |
|
82 | - $context['pm_sent'] = true; |
|
83 | + if (isset($_GET['done']) && ($_GET['done'] == 'sent')) { |
|
84 | + $context['pm_sent'] = true; |
|
85 | + } |
|
83 | 86 | |
84 | 87 | $context['labels'] = array(); |
85 | 88 | |
@@ -210,11 +213,11 @@ discard block |
||
210 | 213 | { |
211 | 214 | $_REQUEST['sa'] = ''; |
212 | 215 | MessageFolder(); |
213 | - } |
|
214 | - else |
|
216 | + } else |
|
215 | 217 | { |
216 | - if (!isset($_REQUEST['xml']) && $_REQUEST['sa'] != 'popup') |
|
217 | - messageIndexBar($_REQUEST['sa']); |
|
218 | + if (!isset($_REQUEST['xml']) && $_REQUEST['sa'] != 'popup') { |
|
219 | + messageIndexBar($_REQUEST['sa']); |
|
220 | + } |
|
218 | 221 | |
219 | 222 | call_helper($subActions[$_REQUEST['sa']]); |
220 | 223 | } |
@@ -291,16 +294,17 @@ discard block |
||
291 | 294 | ); |
292 | 295 | |
293 | 296 | // Handle labels. |
294 | - if (empty($context['currently_using_labels'])) |
|
295 | - unset($pm_areas['labels']); |
|
296 | - else |
|
297 | + if (empty($context['currently_using_labels'])) { |
|
298 | + unset($pm_areas['labels']); |
|
299 | + } else |
|
297 | 300 | { |
298 | 301 | // Note we send labels by id as it will have less problems in the querystring. |
299 | 302 | $unread_in_labels = 0; |
300 | 303 | foreach ($context['labels'] as $label) |
301 | 304 | { |
302 | - if ($label['id'] == -1) |
|
303 | - continue; |
|
305 | + if ($label['id'] == -1) { |
|
306 | + continue; |
|
307 | + } |
|
304 | 308 | |
305 | 309 | // Count the amount of unread items in labels. |
306 | 310 | $unread_in_labels += $label['unread_messages']; |
@@ -314,8 +318,9 @@ discard block |
||
314 | 318 | ); |
315 | 319 | } |
316 | 320 | |
317 | - if (!empty($unread_in_labels)) |
|
318 | - $pm_areas['labels']['title'] .= ' <span class="amt">' . $unread_in_labels . '</span>'; |
|
321 | + if (!empty($unread_in_labels)) { |
|
322 | + $pm_areas['labels']['title'] .= ' <span class="amt">' . $unread_in_labels . '</span>'; |
|
323 | + } |
|
319 | 324 | } |
320 | 325 | |
321 | 326 | $pm_areas['folders']['areas']['inbox']['unread_messages'] = &$context['labels'][-1]['unread_messages']; |
@@ -356,8 +361,9 @@ discard block |
||
356 | 361 | unset($pm_areas); |
357 | 362 | |
358 | 363 | // No menu means no access. |
359 | - if (!$pm_include_data && (!$user_info['is_guest'] || validateSession())) |
|
360 | - fatal_lang_error('no_access', false); |
|
364 | + if (!$pm_include_data && (!$user_info['is_guest'] || validateSession())) { |
|
365 | + fatal_lang_error('no_access', false); |
|
366 | + } |
|
361 | 367 | |
362 | 368 | // Make a note of the Unique ID for this menu. |
363 | 369 | $context['pm_menu_id'] = $context['max_menu_id']; |
@@ -368,9 +374,10 @@ discard block |
||
368 | 374 | $context['menu_item_selected'] = $current_area; |
369 | 375 | |
370 | 376 | // Set the template for this area and add the profile layer. |
371 | - if (!isset($_REQUEST['xml'])) |
|
372 | - $context['template_layers'][] = 'pm'; |
|
373 | -} |
|
377 | + if (!isset($_REQUEST['xml'])) { |
|
378 | + $context['template_layers'][] = 'pm'; |
|
379 | + } |
|
380 | + } |
|
374 | 381 | |
375 | 382 | /** |
376 | 383 | * The popup for when we ask for the popup from the user. |
@@ -402,8 +409,9 @@ discard block |
||
402 | 409 | ) |
403 | 410 | ); |
404 | 411 | $pms = array(); |
405 | - while ($row = $smcFunc['db_fetch_row']($request)) |
|
406 | - $pms[] = $row[0]; |
|
412 | + while ($row = $smcFunc['db_fetch_row']($request)) { |
|
413 | + $pms[] = $row[0]; |
|
414 | + } |
|
407 | 415 | $smcFunc['db_free_result']($request); |
408 | 416 | |
409 | 417 | if (!empty($pms)) |
@@ -431,8 +439,9 @@ discard block |
||
431 | 439 | ); |
432 | 440 | while ($row = $smcFunc['db_fetch_assoc']($request)) |
433 | 441 | { |
434 | - if (!empty($row['id_member_from'])) |
|
435 | - $senders[] = $row['id_member_from']; |
|
442 | + if (!empty($row['id_member_from'])) { |
|
443 | + $senders[] = $row['id_member_from']; |
|
444 | + } |
|
436 | 445 | |
437 | 446 | $row['replied_to_you'] = $row['id_pm'] != $row['id_pm_head']; |
438 | 447 | $row['time'] = timeformat($row['timestamp']); |
@@ -442,13 +451,15 @@ discard block |
||
442 | 451 | $smcFunc['db_free_result']($request); |
443 | 452 | |
444 | 453 | $senders = loadMemberData($senders); |
445 | - foreach ($senders as $member) |
|
446 | - loadMemberContext($member); |
|
454 | + foreach ($senders as $member) { |
|
455 | + loadMemberContext($member); |
|
456 | + } |
|
447 | 457 | |
448 | 458 | // Having loaded everyone, attach them to the PMs. |
449 | - foreach ($context['unread_pms'] as $id_pm => $details) |
|
450 | - if (!empty($memberContext[$details['id_member_from']])) |
|
459 | + foreach ($context['unread_pms'] as $id_pm => $details) { |
|
460 | + if (!empty($memberContext[$details['id_member_from']])) |
|
451 | 461 | $context['unread_pms'][$id_pm]['member'] = &$memberContext[$details['id_member_from']]; |
462 | + } |
|
452 | 463 | } |
453 | 464 | } |
454 | 465 | |
@@ -468,12 +479,13 @@ discard block |
||
468 | 479 | } |
469 | 480 | |
470 | 481 | // Make sure the starting location is valid. |
471 | - if (isset($_GET['start']) && $_GET['start'] != 'new') |
|
472 | - $_GET['start'] = (int) $_GET['start']; |
|
473 | - elseif (!isset($_GET['start']) && !empty($options['view_newest_pm_first'])) |
|
474 | - $_GET['start'] = 0; |
|
475 | - else |
|
476 | - $_GET['start'] = 'new'; |
|
482 | + if (isset($_GET['start']) && $_GET['start'] != 'new') { |
|
483 | + $_GET['start'] = (int) $_GET['start']; |
|
484 | + } elseif (!isset($_GET['start']) && !empty($options['view_newest_pm_first'])) { |
|
485 | + $_GET['start'] = 0; |
|
486 | + } else { |
|
487 | + $_GET['start'] = 'new'; |
|
488 | + } |
|
477 | 489 | |
478 | 490 | // Set up some basic theme stuff. |
479 | 491 | $context['from_or_to'] = $context['folder'] != 'sent' ? 'from' : 'to'; |
@@ -490,8 +502,7 @@ discard block |
||
490 | 502 | { |
491 | 503 | $labelQuery = ' |
492 | 504 | AND pmr.in_inbox = 1'; |
493 | - } |
|
494 | - elseif ($context['folder'] != 'sent') |
|
505 | + } elseif ($context['folder'] != 'sent') |
|
495 | 506 | { |
496 | 507 | $labelJoin = ' |
497 | 508 | INNER JOIN {db_prefix}pm_labeled_messages AS pl ON (pl.id_pm = pmr.id_pm)'; |
@@ -533,22 +544,24 @@ discard block |
||
533 | 544 | $txt['delete_all'] = str_replace('PMBOX', $pmbox, $txt['delete_all']); |
534 | 545 | |
535 | 546 | // Now, build the link tree! |
536 | - if ($context['current_label_id'] == -1) |
|
537 | - $context['linktree'][] = array( |
|
547 | + if ($context['current_label_id'] == -1) { |
|
548 | + $context['linktree'][] = array( |
|
538 | 549 | 'url' => $scripturl . '?action=pm;f=' . $context['folder'], |
539 | 550 | 'name' => $pmbox |
540 | 551 | ); |
552 | + } |
|
541 | 553 | |
542 | 554 | // Build it further for a label. |
543 | - if ($context['current_label_id'] != -1) |
|
544 | - $context['linktree'][] = array( |
|
555 | + if ($context['current_label_id'] != -1) { |
|
556 | + $context['linktree'][] = array( |
|
545 | 557 | 'url' => $scripturl . '?action=pm;f=' . $context['folder'] . ';l=' . $context['current_label_id'], |
546 | 558 | 'name' => $txt['pm_current_label'] . ': ' . $context['current_label'] |
547 | 559 | ); |
560 | + } |
|
548 | 561 | |
549 | 562 | // Figure out how many messages there are. |
550 | - if ($context['folder'] == 'sent') |
|
551 | - $request = $smcFunc['db_query']('', ' |
|
563 | + if ($context['folder'] == 'sent') { |
|
564 | + $request = $smcFunc['db_query']('', ' |
|
552 | 565 | SELECT COUNT(' . ($context['display_mode'] == 2 ? 'DISTINCT pm.id_pm_head' : '*') . ') |
553 | 566 | FROM {db_prefix}personal_messages AS pm |
554 | 567 | WHERE pm.id_member_from = {int:current_member} |
@@ -558,8 +571,8 @@ discard block |
||
558 | 571 | 'not_deleted' => 0, |
559 | 572 | ) |
560 | 573 | ); |
561 | - else |
|
562 | - $request = $smcFunc['db_query']('', ' |
|
574 | + } else { |
|
575 | + $request = $smcFunc['db_query']('', ' |
|
563 | 576 | SELECT COUNT(' . ($context['display_mode'] == 2 ? 'DISTINCT pm.id_pm_head' : '*') . ') |
564 | 577 | FROM {db_prefix}pm_recipients AS pmr' . ($context['display_mode'] == 2 ? ' |
565 | 578 | INNER JOIN {db_prefix}personal_messages AS pm ON (pm.id_pm = pmr.id_pm)' : '') . $labelJoin . ' |
@@ -570,6 +583,7 @@ discard block |
||
570 | 583 | 'not_deleted' => 0, |
571 | 584 | ) |
572 | 585 | ); |
586 | + } |
|
573 | 587 | list ($max_messages) = $smcFunc['db_fetch_row']($request); |
574 | 588 | $smcFunc['db_free_result']($request); |
575 | 589 | |
@@ -578,10 +592,11 @@ discard block |
||
578 | 592 | $maxPerPage = empty($modSettings['disableCustomPerPage']) && !empty($options['messages_per_page']) ? $options['messages_per_page'] : $modSettings['defaultMaxMessages']; |
579 | 593 | |
580 | 594 | // Start on the last page. |
581 | - if (!is_numeric($_GET['start']) || $_GET['start'] >= $max_messages) |
|
582 | - $_GET['start'] = ($max_messages - 1) - (($max_messages - 1) % $maxPerPage); |
|
583 | - elseif ($_GET['start'] < 0) |
|
584 | - $_GET['start'] = 0; |
|
595 | + if (!is_numeric($_GET['start']) || $_GET['start'] >= $max_messages) { |
|
596 | + $_GET['start'] = ($max_messages - 1) - (($max_messages - 1) % $maxPerPage); |
|
597 | + } elseif ($_GET['start'] < 0) { |
|
598 | + $_GET['start'] = 0; |
|
599 | + } |
|
585 | 600 | |
586 | 601 | // ... but wait - what if we want to start from a specific message? |
587 | 602 | if (isset($_GET['pmid'])) |
@@ -589,19 +604,21 @@ discard block |
||
589 | 604 | $pmID = (int) $_GET['pmid']; |
590 | 605 | |
591 | 606 | // Make sure you have access to this PM. |
592 | - if (!isAccessiblePM($pmID, $context['folder'] == 'sent' ? 'outbox' : 'inbox')) |
|
593 | - fatal_lang_error('no_access', false); |
|
607 | + if (!isAccessiblePM($pmID, $context['folder'] == 'sent' ? 'outbox' : 'inbox')) { |
|
608 | + fatal_lang_error('no_access', false); |
|
609 | + } |
|
594 | 610 | |
595 | 611 | $context['current_pm'] = $pmID; |
596 | 612 | |
597 | 613 | // With only one page of PM's we're gonna want page 1. |
598 | - if ($max_messages <= $maxPerPage) |
|
599 | - $_GET['start'] = 0; |
|
614 | + if ($max_messages <= $maxPerPage) { |
|
615 | + $_GET['start'] = 0; |
|
616 | + } |
|
600 | 617 | // If we pass kstart we assume we're in the right place. |
601 | 618 | elseif (!isset($_GET['kstart'])) |
602 | 619 | { |
603 | - if ($context['folder'] == 'sent') |
|
604 | - $request = $smcFunc['db_query']('', ' |
|
620 | + if ($context['folder'] == 'sent') { |
|
621 | + $request = $smcFunc['db_query']('', ' |
|
605 | 622 | SELECT COUNT(' . ($context['display_mode'] == 2 ? 'DISTINCT pm.id_pm_head' : '*') . ') |
606 | 623 | FROM {db_prefix}personal_messages |
607 | 624 | WHERE id_member_from = {int:current_member} |
@@ -613,8 +630,8 @@ discard block |
||
613 | 630 | 'id_pm' => $pmID, |
614 | 631 | ) |
615 | 632 | ); |
616 | - else |
|
617 | - $request = $smcFunc['db_query']('', ' |
|
633 | + } else { |
|
634 | + $request = $smcFunc['db_query']('', ' |
|
618 | 635 | SELECT COUNT(' . ($context['display_mode'] == 2 ? 'DISTINCT pm.id_pm_head' : '*') . ') |
619 | 636 | FROM {db_prefix}pm_recipients AS pmr' . ($context['display_mode'] == 2 ? ' |
620 | 637 | INNER JOIN {db_prefix}personal_messages AS pm ON (pm.id_pm = pmr.id_pm)' : '') . $labelJoin . ' |
@@ -627,6 +644,7 @@ discard block |
||
627 | 644 | 'id_pm' => $pmID, |
628 | 645 | ) |
629 | 646 | ); |
647 | + } |
|
630 | 648 | |
631 | 649 | list ($_GET['start']) = $smcFunc['db_fetch_row']($request); |
632 | 650 | $smcFunc['db_free_result']($request); |
@@ -641,8 +659,9 @@ discard block |
||
641 | 659 | { |
642 | 660 | $pmsg = (int) $_GET['pmsg']; |
643 | 661 | |
644 | - if (!isAccessiblePM($pmsg, $context['folder'] == 'sent' ? 'outbox' : 'inbox')) |
|
645 | - fatal_lang_error('no_access', false); |
|
662 | + if (!isAccessiblePM($pmsg, $context['folder'] == 'sent' ? 'outbox' : 'inbox')) { |
|
663 | + fatal_lang_error('no_access', false); |
|
664 | + } |
|
646 | 665 | } |
647 | 666 | |
648 | 667 | // Set up the page index. |
@@ -737,8 +756,9 @@ discard block |
||
737 | 756 | { |
738 | 757 | if (!isset($recipients[$row['id_pm']])) |
739 | 758 | { |
740 | - if (isset($row['id_member_from'])) |
|
741 | - $posters[$row['id_pm']] = $row['id_member_from']; |
|
759 | + if (isset($row['id_member_from'])) { |
|
760 | + $posters[$row['id_pm']] = $row['id_member_from']; |
|
761 | + } |
|
742 | 762 | $pms[$row['id_pm']] = $row['id_pm']; |
743 | 763 | $recipients[$row['id_pm']] = array( |
744 | 764 | 'to' => array(), |
@@ -747,29 +767,33 @@ discard block |
||
747 | 767 | } |
748 | 768 | |
749 | 769 | // Keep track of the last message so we know what the head is without another query! |
750 | - if ((empty($pmID) && (empty($options['view_newest_pm_first']) || !isset($lastData))) || empty($lastData) || (!empty($pmID) && $pmID == $row['id_pm'])) |
|
751 | - $lastData = array( |
|
770 | + if ((empty($pmID) && (empty($options['view_newest_pm_first']) || !isset($lastData))) || empty($lastData) || (!empty($pmID) && $pmID == $row['id_pm'])) { |
|
771 | + $lastData = array( |
|
752 | 772 | 'id' => $row['id_pm'], |
753 | 773 | 'head' => $row['id_pm_head'], |
754 | 774 | ); |
775 | + } |
|
755 | 776 | } |
756 | 777 | $smcFunc['db_free_result']($request); |
757 | 778 | |
758 | 779 | // Make sure that we have been given a correct head pm id! |
759 | - if ($context['display_mode'] == 2 && !empty($pmID) && $pmID != $lastData['id']) |
|
760 | - fatal_lang_error('no_access', false); |
|
780 | + if ($context['display_mode'] == 2 && !empty($pmID) && $pmID != $lastData['id']) { |
|
781 | + fatal_lang_error('no_access', false); |
|
782 | + } |
|
761 | 783 | |
762 | 784 | if (!empty($pms)) |
763 | 785 | { |
764 | 786 | // Select the correct current message. |
765 | - if (empty($pmID)) |
|
766 | - $context['current_pm'] = $lastData['id']; |
|
787 | + if (empty($pmID)) { |
|
788 | + $context['current_pm'] = $lastData['id']; |
|
789 | + } |
|
767 | 790 | |
768 | 791 | // This is a list of the pm's that are used for "full" display. |
769 | - if ($context['display_mode'] == 0) |
|
770 | - $display_pms = $pms; |
|
771 | - else |
|
772 | - $display_pms = array($context['current_pm']); |
|
792 | + if ($context['display_mode'] == 0) { |
|
793 | + $display_pms = $pms; |
|
794 | + } else { |
|
795 | + $display_pms = array($context['current_pm']); |
|
796 | + } |
|
773 | 797 | |
774 | 798 | // At this point we know the main id_pm's. But - if we are looking at conversations we need the others! |
775 | 799 | if ($context['display_mode'] == 2) |
@@ -791,16 +815,18 @@ discard block |
||
791 | 815 | while ($row = $smcFunc['db_fetch_assoc']($request)) |
792 | 816 | { |
793 | 817 | // This is, frankly, a joke. We will put in a workaround for people sending to themselves - yawn! |
794 | - if ($context['folder'] == 'sent' && $row['id_member_from'] == $user_info['id'] && $row['deleted_by_sender'] == 1) |
|
795 | - continue; |
|
796 | - elseif ($row['id_member'] == $user_info['id'] & $row['deleted'] == 1) |
|
797 | - continue; |
|
818 | + if ($context['folder'] == 'sent' && $row['id_member_from'] == $user_info['id'] && $row['deleted_by_sender'] == 1) { |
|
819 | + continue; |
|
820 | + } elseif ($row['id_member'] == $user_info['id'] & $row['deleted'] == 1) { |
|
821 | + continue; |
|
822 | + } |
|
798 | 823 | |
799 | - if (!isset($recipients[$row['id_pm']])) |
|
800 | - $recipients[$row['id_pm']] = array( |
|
824 | + if (!isset($recipients[$row['id_pm']])) { |
|
825 | + $recipients[$row['id_pm']] = array( |
|
801 | 826 | 'to' => array(), |
802 | 827 | 'bcc' => array() |
803 | 828 | ); |
829 | + } |
|
804 | 830 | $display_pms[] = $row['id_pm']; |
805 | 831 | $posters[$row['id_pm']] = $row['id_member_from']; |
806 | 832 | } |
@@ -851,8 +877,9 @@ discard block |
||
851 | 877 | while($row2 = $smcFunc['db_fetch_assoc']($request2)) |
852 | 878 | { |
853 | 879 | $l_id = $row2['id_label']; |
854 | - if (isset($context['labels'][$l_id])) |
|
855 | - $context['message_labels'][$row['id_pm']][$l_id] = array('id' => $l_id, 'name' => $context['labels'][$l_id]['name']); |
|
880 | + if (isset($context['labels'][$l_id])) { |
|
881 | + $context['message_labels'][$row['id_pm']][$l_id] = array('id' => $l_id, 'name' => $context['labels'][$l_id]['name']); |
|
882 | + } |
|
856 | 883 | } |
857 | 884 | |
858 | 885 | $smcFunc['db_free_result']($request2); |
@@ -869,9 +896,10 @@ discard block |
||
869 | 896 | // Make sure we don't load unnecessary data. |
870 | 897 | if ($context['display_mode'] == 1) |
871 | 898 | { |
872 | - foreach ($posters as $k => $v) |
|
873 | - if (!in_array($k, $display_pms)) |
|
899 | + foreach ($posters as $k => $v) { |
|
900 | + if (!in_array($k, $display_pms)) |
|
874 | 901 | unset($posters[$k]); |
902 | + } |
|
875 | 903 | } |
876 | 904 | |
877 | 905 | // Load any users.... |
@@ -882,8 +910,9 @@ discard block |
||
882 | 910 | { |
883 | 911 | // Get the order right. |
884 | 912 | $orderBy = array(); |
885 | - foreach (array_reverse($pms) as $pm) |
|
886 | - $orderBy[] = 'pm.id_pm = ' . $pm; |
|
913 | + foreach (array_reverse($pms) as $pm) { |
|
914 | + $orderBy[] = 'pm.id_pm = ' . $pm; |
|
915 | + } |
|
887 | 916 | |
888 | 917 | // Seperate query for these bits! |
889 | 918 | $subjects_request = $smcFunc['db_query']('', ' |
@@ -929,9 +958,9 @@ discard block |
||
929 | 958 | // Allow mods to add additional buttons here |
930 | 959 | call_integration_hook('integrate_conversation_buttons'); |
931 | 960 | } |
961 | + } else { |
|
962 | + $messages_request = false; |
|
932 | 963 | } |
933 | - else |
|
934 | - $messages_request = false; |
|
935 | 964 | |
936 | 965 | $context['can_send_pm'] = allowedTo('pm_send'); |
937 | 966 | $context['can_send_email'] = allowedTo('moderate_forum'); |
@@ -942,11 +971,13 @@ discard block |
||
942 | 971 | if ($context['folder'] != 'sent' && !empty($context['labels'][(int) $context['current_label_id']]['unread_messages'])) |
943 | 972 | { |
944 | 973 | // If the display mode is "old sk00l" do them all... |
945 | - if ($context['display_mode'] == 0) |
|
946 | - markMessages(null, $context['current_label_id']); |
|
974 | + if ($context['display_mode'] == 0) { |
|
975 | + markMessages(null, $context['current_label_id']); |
|
976 | + } |
|
947 | 977 | // Otherwise do just the current one! |
948 | - elseif (!empty($context['current_pm'])) |
|
949 | - markMessages($display_pms, $context['current_label_id']); |
|
978 | + elseif (!empty($context['current_pm'])) { |
|
979 | + markMessages($display_pms, $context['current_label_id']); |
|
980 | + } |
|
950 | 981 | } |
951 | 982 | } |
952 | 983 | |
@@ -964,8 +995,9 @@ discard block |
||
964 | 995 | |
965 | 996 | // Count the current message number.... |
966 | 997 | static $counter = null; |
967 | - if ($counter === null || $reset) |
|
968 | - $counter = $context['start']; |
|
998 | + if ($counter === null || $reset) { |
|
999 | + $counter = $context['start']; |
|
1000 | + } |
|
969 | 1001 | |
970 | 1002 | static $temp_pm_selected = null; |
971 | 1003 | if ($temp_pm_selected === null) |
@@ -1010,19 +1042,22 @@ discard block |
||
1010 | 1042 | } |
1011 | 1043 | |
1012 | 1044 | // Bail if it's false, ie. no messages. |
1013 | - if ($messages_request == false) |
|
1014 | - return false; |
|
1045 | + if ($messages_request == false) { |
|
1046 | + return false; |
|
1047 | + } |
|
1015 | 1048 | |
1016 | 1049 | // Reset the data? |
1017 | - if ($reset == true) |
|
1018 | - return @$smcFunc['db_data_seek']($messages_request, 0); |
|
1050 | + if ($reset == true) { |
|
1051 | + return @$smcFunc['db_data_seek']($messages_request, 0); |
|
1052 | + } |
|
1019 | 1053 | |
1020 | 1054 | // Get the next one... bail if anything goes wrong. |
1021 | 1055 | $message = $smcFunc['db_fetch_assoc']($messages_request); |
1022 | 1056 | if (!$message) |
1023 | 1057 | { |
1024 | - if ($type != 'subject') |
|
1025 | - $smcFunc['db_free_result']($messages_request); |
|
1058 | + if ($type != 'subject') { |
|
1059 | + $smcFunc['db_free_result']($messages_request); |
|
1060 | + } |
|
1026 | 1061 | |
1027 | 1062 | return false; |
1028 | 1063 | } |
@@ -1042,8 +1077,7 @@ discard block |
||
1042 | 1077 | $memberContext[$message['id_member_from']]['email'] = ''; |
1043 | 1078 | $memberContext[$message['id_member_from']]['show_email'] = false; |
1044 | 1079 | $memberContext[$message['id_member_from']]['is_guest'] = true; |
1045 | - } |
|
1046 | - else |
|
1080 | + } else |
|
1047 | 1081 | { |
1048 | 1082 | $memberContext[$message['id_member_from']]['can_view_profile'] = allowedTo('profile_view') || ($message['id_member_from'] == $user_info['id'] && !$user_info['is_guest']); |
1049 | 1083 | $memberContext[$message['id_member_from']]['can_see_warning'] = !isset($context['disabled_fields']['warning_status']) && $memberContext[$message['id_member_from']]['warning_status'] && ($context['user']['can_mod'] || (!empty($modSettings['warning_show']) && ($modSettings['warning_show'] > 1 || $message['id_member_from'] == $user_info['id']))); |
@@ -1084,12 +1118,13 @@ discard block |
||
1084 | 1118 | $counter++; |
1085 | 1119 | |
1086 | 1120 | // Any custom profile fields? |
1087 | - if (!empty($memberContext[$message['id_member_from']]['custom_fields'])) |
|
1088 | - foreach ($memberContext[$message['id_member_from']]['custom_fields'] as $custom) |
|
1121 | + if (!empty($memberContext[$message['id_member_from']]['custom_fields'])) { |
|
1122 | + foreach ($memberContext[$message['id_member_from']]['custom_fields'] as $custom) |
|
1089 | 1123 | switch ($custom['placement']) |
1090 | 1124 | { |
1091 | 1125 | case 1: |
1092 | 1126 | $output['custom_fields']['icons'][] = $custom; |
1127 | + } |
|
1093 | 1128 | break; |
1094 | 1129 | case 2: |
1095 | 1130 | $output['custom_fields']['above_signature'][] = $custom; |
@@ -1132,22 +1167,28 @@ discard block |
||
1132 | 1167 | $context['search_params'][$k] = $v; |
1133 | 1168 | } |
1134 | 1169 | } |
1135 | - if (isset($_REQUEST['search'])) |
|
1136 | - $context['search_params']['search'] = un_htmlspecialchars($_REQUEST['search']); |
|
1170 | + if (isset($_REQUEST['search'])) { |
|
1171 | + $context['search_params']['search'] = un_htmlspecialchars($_REQUEST['search']); |
|
1172 | + } |
|
1137 | 1173 | |
1138 | - if (isset($context['search_params']['search'])) |
|
1139 | - $context['search_params']['search'] = $smcFunc['htmlspecialchars']($context['search_params']['search']); |
|
1140 | - if (isset($context['search_params']['userspec'])) |
|
1141 | - $context['search_params']['userspec'] = $smcFunc['htmlspecialchars']($context['search_params']['userspec']); |
|
1174 | + if (isset($context['search_params']['search'])) { |
|
1175 | + $context['search_params']['search'] = $smcFunc['htmlspecialchars']($context['search_params']['search']); |
|
1176 | + } |
|
1177 | + if (isset($context['search_params']['userspec'])) { |
|
1178 | + $context['search_params']['userspec'] = $smcFunc['htmlspecialchars']($context['search_params']['userspec']); |
|
1179 | + } |
|
1142 | 1180 | |
1143 | - if (!empty($context['search_params']['searchtype'])) |
|
1144 | - $context['search_params']['searchtype'] = 2; |
|
1181 | + if (!empty($context['search_params']['searchtype'])) { |
|
1182 | + $context['search_params']['searchtype'] = 2; |
|
1183 | + } |
|
1145 | 1184 | |
1146 | - if (!empty($context['search_params']['minage'])) |
|
1147 | - $context['search_params']['minage'] = (int) $context['search_params']['minage']; |
|
1185 | + if (!empty($context['search_params']['minage'])) { |
|
1186 | + $context['search_params']['minage'] = (int) $context['search_params']['minage']; |
|
1187 | + } |
|
1148 | 1188 | |
1149 | - if (!empty($context['search_params']['maxage'])) |
|
1150 | - $context['search_params']['maxage'] = (int) $context['search_params']['maxage']; |
|
1189 | + if (!empty($context['search_params']['maxage'])) { |
|
1190 | + $context['search_params']['maxage'] = (int) $context['search_params']['maxage']; |
|
1191 | + } |
|
1151 | 1192 | |
1152 | 1193 | $context['search_params']['subject_only'] = !empty($context['search_params']['subject_only']); |
1153 | 1194 | $context['search_params']['show_complete'] = !empty($context['search_params']['show_complete']); |
@@ -1174,8 +1215,9 @@ discard block |
||
1174 | 1215 | $context['search_errors']['messages'] = array(); |
1175 | 1216 | foreach ($context['search_errors'] as $search_error => $dummy) |
1176 | 1217 | { |
1177 | - if ($search_error == 'messages') |
|
1178 | - continue; |
|
1218 | + if ($search_error == 'messages') { |
|
1219 | + continue; |
|
1220 | + } |
|
1179 | 1221 | |
1180 | 1222 | $context['search_errors']['messages'][] = $txt['error_' . $search_error]; |
1181 | 1223 | } |
@@ -1197,8 +1239,9 @@ discard block |
||
1197 | 1239 | global $scripturl, $modSettings, $user_info, $context, $txt; |
1198 | 1240 | global $memberContext, $smcFunc; |
1199 | 1241 | |
1200 | - if (!empty($context['load_average']) && !empty($modSettings['loadavg_search']) && $context['load_average'] >= $modSettings['loadavg_search']) |
|
1201 | - fatal_lang_error('loadavg_search_disabled', false); |
|
1242 | + if (!empty($context['load_average']) && !empty($modSettings['loadavg_search']) && $context['load_average'] >= $modSettings['loadavg_search']) { |
|
1243 | + fatal_lang_error('loadavg_search_disabled', false); |
|
1244 | + } |
|
1202 | 1245 | |
1203 | 1246 | /** |
1204 | 1247 | * @todo For the moment force the folder to the inbox. |
@@ -1227,35 +1270,40 @@ discard block |
||
1227 | 1270 | $context['start'] = isset($_GET['start']) ? (int) $_GET['start'] : 0; |
1228 | 1271 | |
1229 | 1272 | // Store whether simple search was used (needed if the user wants to do another query). |
1230 | - if (!isset($search_params['advanced'])) |
|
1231 | - $search_params['advanced'] = empty($_REQUEST['advanced']) ? 0 : 1; |
|
1273 | + if (!isset($search_params['advanced'])) { |
|
1274 | + $search_params['advanced'] = empty($_REQUEST['advanced']) ? 0 : 1; |
|
1275 | + } |
|
1232 | 1276 | |
1233 | 1277 | // 1 => 'allwords' (default, don't set as param) / 2 => 'anywords'. |
1234 | - if (!empty($search_params['searchtype']) || (!empty($_REQUEST['searchtype']) && $_REQUEST['searchtype'] == 2)) |
|
1235 | - $search_params['searchtype'] = 2; |
|
1278 | + if (!empty($search_params['searchtype']) || (!empty($_REQUEST['searchtype']) && $_REQUEST['searchtype'] == 2)) { |
|
1279 | + $search_params['searchtype'] = 2; |
|
1280 | + } |
|
1236 | 1281 | |
1237 | 1282 | // Minimum age of messages. Default to zero (don't set param in that case). |
1238 | - if (!empty($search_params['minage']) || (!empty($_REQUEST['minage']) && $_REQUEST['minage'] > 0)) |
|
1239 | - $search_params['minage'] = !empty($search_params['minage']) ? (int) $search_params['minage'] : (int) $_REQUEST['minage']; |
|
1283 | + if (!empty($search_params['minage']) || (!empty($_REQUEST['minage']) && $_REQUEST['minage'] > 0)) { |
|
1284 | + $search_params['minage'] = !empty($search_params['minage']) ? (int) $search_params['minage'] : (int) $_REQUEST['minage']; |
|
1285 | + } |
|
1240 | 1286 | |
1241 | 1287 | // Maximum age of messages. Default to infinite (9999 days: param not set). |
1242 | - if (!empty($search_params['maxage']) || (!empty($_REQUEST['maxage']) && $_REQUEST['maxage'] != 9999)) |
|
1243 | - $search_params['maxage'] = !empty($search_params['maxage']) ? (int) $search_params['maxage'] : (int) $_REQUEST['maxage']; |
|
1288 | + if (!empty($search_params['maxage']) || (!empty($_REQUEST['maxage']) && $_REQUEST['maxage'] != 9999)) { |
|
1289 | + $search_params['maxage'] = !empty($search_params['maxage']) ? (int) $search_params['maxage'] : (int) $_REQUEST['maxage']; |
|
1290 | + } |
|
1244 | 1291 | |
1245 | 1292 | $search_params['subject_only'] = !empty($search_params['subject_only']) || !empty($_REQUEST['subject_only']); |
1246 | 1293 | $search_params['show_complete'] = !empty($search_params['show_complete']) || !empty($_REQUEST['show_complete']); |
1247 | 1294 | |
1248 | 1295 | // Default the user name to a wildcard matching every user (*). |
1249 | - if (!empty($search_params['user_spec']) || (!empty($_REQUEST['userspec']) && $_REQUEST['userspec'] != '*')) |
|
1250 | - $search_params['userspec'] = isset($search_params['userspec']) ? $search_params['userspec'] : $_REQUEST['userspec']; |
|
1296 | + if (!empty($search_params['user_spec']) || (!empty($_REQUEST['userspec']) && $_REQUEST['userspec'] != '*')) { |
|
1297 | + $search_params['userspec'] = isset($search_params['userspec']) ? $search_params['userspec'] : $_REQUEST['userspec']; |
|
1298 | + } |
|
1251 | 1299 | |
1252 | 1300 | // This will be full of all kinds of parameters! |
1253 | 1301 | $searchq_parameters = array(); |
1254 | 1302 | |
1255 | 1303 | // If there's no specific user, then don't mention it in the main query. |
1256 | - if (empty($search_params['userspec'])) |
|
1257 | - $userQuery = ''; |
|
1258 | - else |
|
1304 | + if (empty($search_params['userspec'])) { |
|
1305 | + $userQuery = ''; |
|
1306 | + } else |
|
1259 | 1307 | { |
1260 | 1308 | $userString = strtr($smcFunc['htmlspecialchars']($search_params['userspec'], ENT_QUOTES), array('"' => '"')); |
1261 | 1309 | $userString = strtr($userString, array('%' => '\%', '_' => '\_', '*' => '%', '?' => '_')); |
@@ -1267,8 +1315,9 @@ discard block |
||
1267 | 1315 | { |
1268 | 1316 | $possible_users[$k] = trim($possible_users[$k]); |
1269 | 1317 | |
1270 | - if (strlen($possible_users[$k]) == 0) |
|
1271 | - unset($possible_users[$k]); |
|
1318 | + if (strlen($possible_users[$k]) == 0) { |
|
1319 | + unset($possible_users[$k]); |
|
1320 | + } |
|
1272 | 1321 | } |
1273 | 1322 | |
1274 | 1323 | if (!empty($possible_users)) |
@@ -1280,8 +1329,9 @@ discard block |
||
1280 | 1329 | { |
1281 | 1330 | $where_params['name_' . $k] = $v; |
1282 | 1331 | $where_clause[] = '{raw:real_name} LIKE {string:name_' . $k . '}'; |
1283 | - if (!isset($where_params['real_name'])) |
|
1284 | - $where_params['real_name'] = $smcFunc['db_case_sensitive'] ? 'LOWER(real_name)' : 'real_name'; |
|
1332 | + if (!isset($where_params['real_name'])) { |
|
1333 | + $where_params['real_name'] = $smcFunc['db_case_sensitive'] ? 'LOWER(real_name)' : 'real_name'; |
|
1334 | + } |
|
1285 | 1335 | } |
1286 | 1336 | |
1287 | 1337 | // Who matches those criteria? |
@@ -1294,28 +1344,28 @@ discard block |
||
1294 | 1344 | ); |
1295 | 1345 | |
1296 | 1346 | // Simply do nothing if there're too many members matching the criteria. |
1297 | - if ($smcFunc['db_num_rows']($request) > $maxMembersToSearch) |
|
1298 | - $userQuery = ''; |
|
1299 | - elseif ($smcFunc['db_num_rows']($request) == 0) |
|
1347 | + if ($smcFunc['db_num_rows']($request) > $maxMembersToSearch) { |
|
1348 | + $userQuery = ''; |
|
1349 | + } elseif ($smcFunc['db_num_rows']($request) == 0) |
|
1300 | 1350 | { |
1301 | 1351 | $userQuery = 'AND pm.id_member_from = 0 AND ({raw:pm_from_name} LIKE {raw:guest_user_name_implode})'; |
1302 | 1352 | $searchq_parameters['guest_user_name_implode'] = '\'' . implode('\' OR ' . ($smcFunc['db_case_sensitive'] ? 'LOWER(pm.from_name)' : 'pm.from_name') . ' LIKE \'', $possible_users) . '\''; |
1303 | 1353 | $searchq_parameters['pm_from_name'] = $smcFunc['db_case_sensitive'] ? 'LOWER(pm.from_name)' : 'pm.from_name'; |
1304 | - } |
|
1305 | - else |
|
1354 | + } else |
|
1306 | 1355 | { |
1307 | 1356 | $memberlist = array(); |
1308 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
1309 | - $memberlist[] = $row['id_member']; |
|
1357 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
1358 | + $memberlist[] = $row['id_member']; |
|
1359 | + } |
|
1310 | 1360 | $userQuery = 'AND (pm.id_member_from IN ({array_int:member_list}) OR (pm.id_member_from = 0 AND ({raw:pm_from_name} LIKE {raw:guest_user_name_implode})))'; |
1311 | 1361 | $searchq_parameters['guest_user_name_implode'] = '\'' . implode('\' OR ' . ($smcFunc['db_case_sensitive'] ? 'LOWER(pm.from_name)' : 'pm.from_name') . ' LIKE \'', $possible_users) . '\''; |
1312 | 1362 | $searchq_parameters['member_list'] = $memberlist; |
1313 | 1363 | $searchq_parameters['pm_from_name'] = $smcFunc['db_case_sensitive'] ? 'LOWER(pm.from_name)' : 'pm.from_name'; |
1314 | 1364 | } |
1315 | 1365 | $smcFunc['db_free_result']($request); |
1366 | + } else { |
|
1367 | + $userQuery = ''; |
|
1316 | 1368 | } |
1317 | - else |
|
1318 | - $userQuery = ''; |
|
1319 | 1369 | } |
1320 | 1370 | |
1321 | 1371 | // Setup the sorting variables... |
@@ -1323,8 +1373,9 @@ discard block |
||
1323 | 1373 | $sort_columns = array( |
1324 | 1374 | 'pm.id_pm', |
1325 | 1375 | ); |
1326 | - if (empty($search_params['sort']) && !empty($_REQUEST['sort'])) |
|
1327 | - list ($search_params['sort'], $search_params['sort_dir']) = array_pad(explode('|', $_REQUEST['sort']), 2, ''); |
|
1376 | + if (empty($search_params['sort']) && !empty($_REQUEST['sort'])) { |
|
1377 | + list ($search_params['sort'], $search_params['sort_dir']) = array_pad(explode('|', $_REQUEST['sort']), 2, ''); |
|
1378 | + } |
|
1328 | 1379 | $search_params['sort'] = !empty($search_params['sort']) && in_array($search_params['sort'], $sort_columns) ? $search_params['sort'] : 'pm.id_pm'; |
1329 | 1380 | $search_params['sort_dir'] = !empty($search_params['sort_dir']) && $search_params['sort_dir'] == 'asc' ? 'asc' : 'desc'; |
1330 | 1381 | |
@@ -1334,24 +1385,27 @@ discard block |
||
1334 | 1385 | if ($context['folder'] == 'inbox' && !empty($search_params['advanced']) && $context['currently_using_labels']) |
1335 | 1386 | { |
1336 | 1387 | // Came here from pagination? Put them back into $_REQUEST for sanitization. |
1337 | - if (isset($search_params['labels'])) |
|
1338 | - $_REQUEST['searchlabel'] = explode(',', $search_params['labels']); |
|
1388 | + if (isset($search_params['labels'])) { |
|
1389 | + $_REQUEST['searchlabel'] = explode(',', $search_params['labels']); |
|
1390 | + } |
|
1339 | 1391 | |
1340 | 1392 | // Assuming we have some labels - make them all integers. |
1341 | 1393 | if (!empty($_REQUEST['searchlabel']) && is_array($_REQUEST['searchlabel'])) |
1342 | 1394 | { |
1343 | - foreach ($_REQUEST['searchlabel'] as $key => $id) |
|
1344 | - $_REQUEST['searchlabel'][$key] = (int) $id; |
|
1395 | + foreach ($_REQUEST['searchlabel'] as $key => $id) { |
|
1396 | + $_REQUEST['searchlabel'][$key] = (int) $id; |
|
1397 | + } |
|
1398 | + } else { |
|
1399 | + $_REQUEST['searchlabel'] = array(); |
|
1345 | 1400 | } |
1346 | - else |
|
1347 | - $_REQUEST['searchlabel'] = array(); |
|
1348 | 1401 | |
1349 | 1402 | // Now that everything is cleaned up a bit, make the labels a param. |
1350 | 1403 | $search_params['labels'] = implode(',', $_REQUEST['searchlabel']); |
1351 | 1404 | |
1352 | 1405 | // No labels selected? That must be an error! |
1353 | - if (empty($_REQUEST['searchlabel'])) |
|
1354 | - $context['search_errors']['no_labels_selected'] = true; |
|
1406 | + if (empty($_REQUEST['searchlabel'])) { |
|
1407 | + $context['search_errors']['no_labels_selected'] = true; |
|
1408 | + } |
|
1355 | 1409 | // Otherwise prepare the query! |
1356 | 1410 | elseif (count($_REQUEST['searchlabel']) != count($context['labels'])) |
1357 | 1411 | { |
@@ -1374,8 +1428,7 @@ discard block |
||
1374 | 1428 | // Not searching the inbox - PM must be labeled |
1375 | 1429 | $labelQuery = ' AND pml.id_label IN ({array_int:labels})'; |
1376 | 1430 | $labelJoin = ' INNER JOIN {db_prefix}pm_labeled_messages AS pml ON (pml.id_pm = pmr.id_pm)'; |
1377 | - } |
|
1378 | - else |
|
1431 | + } else |
|
1379 | 1432 | { |
1380 | 1433 | // Searching the inbox - PM doesn't have to be labeled |
1381 | 1434 | $labelQuery = ' AND (' . substr($labelQuery, 5) . ' OR pml.id_label IN ({array_int:labels}))'; |
@@ -1390,8 +1443,9 @@ discard block |
||
1390 | 1443 | // What are we actually searching for? |
1391 | 1444 | $search_params['search'] = !empty($search_params['search']) ? $search_params['search'] : (isset($_REQUEST['search']) ? $_REQUEST['search'] : ''); |
1392 | 1445 | // If we ain't got nothing - we should error! |
1393 | - if (!isset($search_params['search']) || $search_params['search'] == '') |
|
1394 | - $context['search_errors']['invalid_search_string'] = true; |
|
1446 | + if (!isset($search_params['search']) || $search_params['search'] == '') { |
|
1447 | + $context['search_errors']['invalid_search_string'] = true; |
|
1448 | + } |
|
1395 | 1449 | |
1396 | 1450 | // Extract phrase parts first (e.g. some words "this is a phrase" some more words.) |
1397 | 1451 | preg_match_all('~(?:^|\s)([-]?)"([^"]+)"(?:$|\s)~' . ($context['utf8'] ? 'u' : ''), $search_params['search'], $matches, PREG_PATTERN_ORDER); |
@@ -1404,12 +1458,14 @@ discard block |
||
1404 | 1458 | $excludedWords = array(); |
1405 | 1459 | |
1406 | 1460 | // .. first, we check for things like -"some words", but not "-some words". |
1407 | - foreach ($matches[1] as $index => $word) |
|
1408 | - if ($word == '-') |
|
1461 | + foreach ($matches[1] as $index => $word) { |
|
1462 | + if ($word == '-') |
|
1409 | 1463 | { |
1410 | 1464 | $word = $smcFunc['strtolower'](trim($searchArray[$index])); |
1411 | - if (strlen($word) > 0) |
|
1412 | - $excludedWords[] = $word; |
|
1465 | + } |
|
1466 | + if (strlen($word) > 0) { |
|
1467 | + $excludedWords[] = $word; |
|
1468 | + } |
|
1413 | 1469 | unset($searchArray[$index]); |
1414 | 1470 | } |
1415 | 1471 | |
@@ -1419,8 +1475,9 @@ discard block |
||
1419 | 1475 | if (strpos(trim($word), '-') === 0) |
1420 | 1476 | { |
1421 | 1477 | $word = substr($smcFunc['strtolower']($word), 1); |
1422 | - if (strlen($word) > 0) |
|
1423 | - $excludedWords[] = $word; |
|
1478 | + if (strlen($word) > 0) { |
|
1479 | + $excludedWords[] = $word; |
|
1480 | + } |
|
1424 | 1481 | unset($tempSearch[$index]); |
1425 | 1482 | } |
1426 | 1483 | } |
@@ -1431,9 +1488,9 @@ discard block |
||
1431 | 1488 | foreach ($searchArray as $index => $value) |
1432 | 1489 | { |
1433 | 1490 | $searchArray[$index] = $smcFunc['strtolower'](trim($value)); |
1434 | - if ($searchArray[$index] == '') |
|
1435 | - unset($searchArray[$index]); |
|
1436 | - else |
|
1491 | + if ($searchArray[$index] == '') { |
|
1492 | + unset($searchArray[$index]); |
|
1493 | + } else |
|
1437 | 1494 | { |
1438 | 1495 | // Sort out entities first. |
1439 | 1496 | $searchArray[$index] = $smcFunc['htmlspecialchars']($searchArray[$index]); |
@@ -1443,27 +1500,32 @@ discard block |
||
1443 | 1500 | |
1444 | 1501 | // Create an array of replacements for highlighting. |
1445 | 1502 | $context['mark'] = array(); |
1446 | - foreach ($searchArray as $word) |
|
1447 | - $context['mark'][$word] = '<strong class="highlight">' . $word . '</strong>'; |
|
1503 | + foreach ($searchArray as $word) { |
|
1504 | + $context['mark'][$word] = '<strong class="highlight">' . $word . '</strong>'; |
|
1505 | + } |
|
1448 | 1506 | |
1449 | 1507 | // This contains *everything* |
1450 | 1508 | $searchWords = array_merge($searchArray, $excludedWords); |
1451 | 1509 | |
1452 | 1510 | // Make sure at least one word is being searched for. |
1453 | - if (empty($searchArray)) |
|
1454 | - $context['search_errors']['invalid_search_string'] = true; |
|
1511 | + if (empty($searchArray)) { |
|
1512 | + $context['search_errors']['invalid_search_string'] = true; |
|
1513 | + } |
|
1455 | 1514 | |
1456 | 1515 | // Sort out the search query so the user can edit it - if they want. |
1457 | 1516 | $context['search_params'] = $search_params; |
1458 | - if (isset($context['search_params']['search'])) |
|
1459 | - $context['search_params']['search'] = $smcFunc['htmlspecialchars']($context['search_params']['search']); |
|
1460 | - if (isset($context['search_params']['userspec'])) |
|
1461 | - $context['search_params']['userspec'] = $smcFunc['htmlspecialchars']($context['search_params']['userspec']); |
|
1517 | + if (isset($context['search_params']['search'])) { |
|
1518 | + $context['search_params']['search'] = $smcFunc['htmlspecialchars']($context['search_params']['search']); |
|
1519 | + } |
|
1520 | + if (isset($context['search_params']['userspec'])) { |
|
1521 | + $context['search_params']['userspec'] = $smcFunc['htmlspecialchars']($context['search_params']['userspec']); |
|
1522 | + } |
|
1462 | 1523 | |
1463 | 1524 | // Now we have all the parameters, combine them together for pagination and the like... |
1464 | 1525 | $context['params'] = array(); |
1465 | - foreach ($search_params as $k => $v) |
|
1466 | - $context['params'][] = $k . '|\'|' . $v; |
|
1526 | + foreach ($search_params as $k => $v) { |
|
1527 | + $context['params'][] = $k . '|\'|' . $v; |
|
1528 | + } |
|
1467 | 1529 | $context['params'] = base64_encode(implode('|"|', $context['params'])); |
1468 | 1530 | |
1469 | 1531 | // Compile the subject query part. |
@@ -1471,26 +1533,31 @@ discard block |
||
1471 | 1533 | |
1472 | 1534 | foreach ($searchWords as $index => $word) |
1473 | 1535 | { |
1474 | - if ($word == '') |
|
1475 | - continue; |
|
1536 | + if ($word == '') { |
|
1537 | + continue; |
|
1538 | + } |
|
1476 | 1539 | |
1477 | - if ($search_params['subject_only']) |
|
1478 | - $andQueryParts[] = 'pm.subject' . (in_array($word, $excludedWords) ? ' NOT' : '') . ' LIKE {string:search_' . $index . '}'; |
|
1479 | - else |
|
1480 | - $andQueryParts[] = '(pm.subject' . (in_array($word, $excludedWords) ? ' NOT' : '') . ' LIKE {string:search_' . $index . '} ' . (in_array($word, $excludedWords) ? 'AND pm.body NOT' : 'OR pm.body') . ' LIKE {string:search_' . $index . '})'; |
|
1540 | + if ($search_params['subject_only']) { |
|
1541 | + $andQueryParts[] = 'pm.subject' . (in_array($word, $excludedWords) ? ' NOT' : '') . ' LIKE {string:search_' . $index . '}'; |
|
1542 | + } else { |
|
1543 | + $andQueryParts[] = '(pm.subject' . (in_array($word, $excludedWords) ? ' NOT' : '') . ' LIKE {string:search_' . $index . '} ' . (in_array($word, $excludedWords) ? 'AND pm.body NOT' : 'OR pm.body') . ' LIKE {string:search_' . $index . '})'; |
|
1544 | + } |
|
1481 | 1545 | $searchq_parameters['search_' . $index] = '%' . strtr($word, array('_' => '\\_', '%' => '\\%')) . '%'; |
1482 | 1546 | } |
1483 | 1547 | |
1484 | 1548 | $searchQuery = ' 1=1'; |
1485 | - if (!empty($andQueryParts)) |
|
1486 | - $searchQuery = implode(!empty($search_params['searchtype']) && $search_params['searchtype'] == 2 ? ' OR ' : ' AND ', $andQueryParts); |
|
1549 | + if (!empty($andQueryParts)) { |
|
1550 | + $searchQuery = implode(!empty($search_params['searchtype']) && $search_params['searchtype'] == 2 ? ' OR ' : ' AND ', $andQueryParts); |
|
1551 | + } |
|
1487 | 1552 | |
1488 | 1553 | // Age limits? |
1489 | 1554 | $timeQuery = ''; |
1490 | - if (!empty($search_params['minage'])) |
|
1491 | - $timeQuery .= ' AND pm.msgtime < ' . (time() - $search_params['minage'] * 86400); |
|
1492 | - if (!empty($search_params['maxage'])) |
|
1493 | - $timeQuery .= ' AND pm.msgtime > ' . (time() - $search_params['maxage'] * 86400); |
|
1555 | + if (!empty($search_params['minage'])) { |
|
1556 | + $timeQuery .= ' AND pm.msgtime < ' . (time() - $search_params['minage'] * 86400); |
|
1557 | + } |
|
1558 | + if (!empty($search_params['maxage'])) { |
|
1559 | + $timeQuery .= ' AND pm.msgtime > ' . (time() - $search_params['maxage'] * 86400); |
|
1560 | + } |
|
1494 | 1561 | |
1495 | 1562 | // If we have errors - return back to the first screen... |
1496 | 1563 | if (!empty($context['search_errors'])) |
@@ -1576,8 +1643,9 @@ discard block |
||
1576 | 1643 | ) |
1577 | 1644 | ); |
1578 | 1645 | $real_pm_ids = array(); |
1579 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
1580 | - $real_pm_ids[$row['id_pm_head']] = $row['id_pm']; |
|
1646 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
1647 | + $real_pm_ids[$row['id_pm_head']] = $row['id_pm']; |
|
1648 | + } |
|
1581 | 1649 | $smcFunc['db_free_result']($request); |
1582 | 1650 | } |
1583 | 1651 | |
@@ -1607,8 +1675,9 @@ discard block |
||
1607 | 1675 | ); |
1608 | 1676 | while ($row = $smcFunc['db_fetch_assoc']($request)) |
1609 | 1677 | { |
1610 | - if ($context['folder'] == 'sent' || empty($row['bcc'])) |
|
1611 | - $recipients[$row['id_pm']][empty($row['bcc']) ? 'to' : 'bcc'][] = empty($row['id_member_to']) ? $txt['guest_title'] : '<a href="' . $scripturl . '?action=profile;u=' . $row['id_member_to'] . '">' . $row['to_name'] . '</a>'; |
|
1678 | + if ($context['folder'] == 'sent' || empty($row['bcc'])) { |
|
1679 | + $recipients[$row['id_pm']][empty($row['bcc']) ? 'to' : 'bcc'][] = empty($row['id_member_to']) ? $txt['guest_title'] : '<a href="' . $scripturl . '?action=profile;u=' . $row['id_member_to'] . '">' . $row['to_name'] . '</a>'; |
|
1680 | + } |
|
1612 | 1681 | |
1613 | 1682 | if ($row['id_member_to'] == $user_info['id'] && $context['folder'] != 'sent') |
1614 | 1683 | { |
@@ -1629,12 +1698,14 @@ discard block |
||
1629 | 1698 | while($row2 = $smcFunc['db_fetch_assoc']($request2)) |
1630 | 1699 | { |
1631 | 1700 | $l_id = $row2['id_label']; |
1632 | - if (isset($context['labels'][$l_id])) |
|
1633 | - $context['message_labels'][$row['id_pm']][$l_id] = array('id' => $l_id, 'name' => $context['labels'][$l_id]['name']); |
|
1701 | + if (isset($context['labels'][$l_id])) { |
|
1702 | + $context['message_labels'][$row['id_pm']][$l_id] = array('id' => $l_id, 'name' => $context['labels'][$l_id]['name']); |
|
1703 | + } |
|
1634 | 1704 | |
1635 | 1705 | // Here we find the first label on a message - for linking to posts in results |
1636 | - if (!isset($context['first_label'][$row['id_pm']]) && $row['in_inbox'] != 1) |
|
1637 | - $context['first_label'][$row['id_pm']] = $l_id; |
|
1706 | + if (!isset($context['first_label'][$row['id_pm']]) && $row['in_inbox'] != 1) { |
|
1707 | + $context['first_label'][$row['id_pm']] = $l_id; |
|
1708 | + } |
|
1638 | 1709 | } |
1639 | 1710 | |
1640 | 1711 | $smcFunc['db_free_result']($request2); |
@@ -1761,8 +1832,9 @@ discard block |
||
1761 | 1832 | list ($postCount) = $smcFunc['db_fetch_row']($request); |
1762 | 1833 | $smcFunc['db_free_result']($request); |
1763 | 1834 | |
1764 | - if (!empty($postCount) && $postCount >= $modSettings['pm_posts_per_hour']) |
|
1765 | - fatal_lang_error('pm_too_many_per_hour', true, array($modSettings['pm_posts_per_hour'])); |
|
1835 | + if (!empty($postCount) && $postCount >= $modSettings['pm_posts_per_hour']) { |
|
1836 | + fatal_lang_error('pm_too_many_per_hour', true, array($modSettings['pm_posts_per_hour'])); |
|
1837 | + } |
|
1766 | 1838 | } |
1767 | 1839 | |
1768 | 1840 | // Quoting/Replying to a message? |
@@ -1771,8 +1843,9 @@ discard block |
||
1771 | 1843 | $pmsg = (int) $_REQUEST['pmsg']; |
1772 | 1844 | |
1773 | 1845 | // Make sure this is yours. |
1774 | - if (!isAccessiblePM($pmsg)) |
|
1775 | - fatal_lang_error('no_access', false); |
|
1846 | + if (!isAccessiblePM($pmsg)) { |
|
1847 | + fatal_lang_error('no_access', false); |
|
1848 | + } |
|
1776 | 1849 | |
1777 | 1850 | // Work out whether this is one you've received? |
1778 | 1851 | $request = $smcFunc['db_query']('', ' |
@@ -1809,8 +1882,9 @@ discard block |
||
1809 | 1882 | 'id_pm' => $pmsg, |
1810 | 1883 | ) |
1811 | 1884 | ); |
1812 | - if ($smcFunc['db_num_rows']($request) == 0) |
|
1813 | - fatal_lang_error('pm_not_yours', false); |
|
1885 | + if ($smcFunc['db_num_rows']($request) == 0) { |
|
1886 | + fatal_lang_error('pm_not_yours', false); |
|
1887 | + } |
|
1814 | 1888 | $row_quoted = $smcFunc['db_fetch_assoc']($request); |
1815 | 1889 | $smcFunc['db_free_result']($request); |
1816 | 1890 | |
@@ -1821,9 +1895,9 @@ discard block |
||
1821 | 1895 | // Add 'Re: ' to it.... |
1822 | 1896 | if (!isset($context['response_prefix']) && !($context['response_prefix'] = cache_get_data('response_prefix'))) |
1823 | 1897 | { |
1824 | - if ($language === $user_info['language']) |
|
1825 | - $context['response_prefix'] = $txt['response_prefix']; |
|
1826 | - else |
|
1898 | + if ($language === $user_info['language']) { |
|
1899 | + $context['response_prefix'] = $txt['response_prefix']; |
|
1900 | + } else |
|
1827 | 1901 | { |
1828 | 1902 | loadLanguage('index', $language, false); |
1829 | 1903 | $context['response_prefix'] = $txt['response_prefix']; |
@@ -1832,22 +1906,25 @@ discard block |
||
1832 | 1906 | cache_put_data('response_prefix', $context['response_prefix'], 600); |
1833 | 1907 | } |
1834 | 1908 | $form_subject = $row_quoted['subject']; |
1835 | - if ($context['reply'] && trim($context['response_prefix']) != '' && $smcFunc['strpos']($form_subject, trim($context['response_prefix'])) !== 0) |
|
1836 | - $form_subject = $context['response_prefix'] . $form_subject; |
|
1909 | + if ($context['reply'] && trim($context['response_prefix']) != '' && $smcFunc['strpos']($form_subject, trim($context['response_prefix'])) !== 0) { |
|
1910 | + $form_subject = $context['response_prefix'] . $form_subject; |
|
1911 | + } |
|
1837 | 1912 | |
1838 | 1913 | if (isset($_REQUEST['quote'])) |
1839 | 1914 | { |
1840 | 1915 | // Remove any nested quotes and <br>... |
1841 | 1916 | $form_message = preg_replace('~<br ?/?' . '>~i', "\n", $row_quoted['body']); |
1842 | - if (!empty($modSettings['removeNestedQuotes'])) |
|
1843 | - $form_message = preg_replace(array('~\n?\[quote.*?\].+?\[/quote\]\n?~is', '~^\n~', '~\[/quote\]~'), '', $form_message); |
|
1844 | - if (empty($row_quoted['id_member'])) |
|
1845 | - $form_message = '[quote author="' . $row_quoted['real_name'] . '"]' . "\n" . $form_message . "\n" . '[/quote]'; |
|
1846 | - else |
|
1847 | - $form_message = '[quote author=' . $row_quoted['real_name'] . ' link=action=profile;u=' . $row_quoted['id_member'] . ' date=' . $row_quoted['msgtime'] . ']' . "\n" . $form_message . "\n" . '[/quote]'; |
|
1917 | + if (!empty($modSettings['removeNestedQuotes'])) { |
|
1918 | + $form_message = preg_replace(array('~\n?\[quote.*?\].+?\[/quote\]\n?~is', '~^\n~', '~\[/quote\]~'), '', $form_message); |
|
1919 | + } |
|
1920 | + if (empty($row_quoted['id_member'])) { |
|
1921 | + $form_message = '[quote author="' . $row_quoted['real_name'] . '"]' . "\n" . $form_message . "\n" . '[/quote]'; |
|
1922 | + } else { |
|
1923 | + $form_message = '[quote author=' . $row_quoted['real_name'] . ' link=action=profile;u=' . $row_quoted['id_member'] . ' date=' . $row_quoted['msgtime'] . ']' . "\n" . $form_message . "\n" . '[/quote]'; |
|
1924 | + } |
|
1925 | + } else { |
|
1926 | + $form_message = ''; |
|
1848 | 1927 | } |
1849 | - else |
|
1850 | - $form_message = ''; |
|
1851 | 1928 | |
1852 | 1929 | // Do the BBC thang on the message. |
1853 | 1930 | $row_quoted['body'] = parse_bbc($row_quoted['body'], true, 'pm' . $row_quoted['id_pm']); |
@@ -1868,8 +1945,7 @@ discard block |
||
1868 | 1945 | 'timestamp' => forum_time(true, $row_quoted['msgtime']), |
1869 | 1946 | 'body' => $row_quoted['body'] |
1870 | 1947 | ); |
1871 | - } |
|
1872 | - else |
|
1948 | + } else |
|
1873 | 1949 | { |
1874 | 1950 | $context['quoted_message'] = false; |
1875 | 1951 | $form_subject = ''; |
@@ -1888,11 +1964,12 @@ discard block |
||
1888 | 1964 | if ($_REQUEST['u'] == 'all' && isset($row_quoted)) |
1889 | 1965 | { |
1890 | 1966 | // Firstly, to reply to all we clearly already have $row_quoted - so have the original member from. |
1891 | - if ($row_quoted['id_member'] != $user_info['id']) |
|
1892 | - $context['recipients']['to'][] = array( |
|
1967 | + if ($row_quoted['id_member'] != $user_info['id']) { |
|
1968 | + $context['recipients']['to'][] = array( |
|
1893 | 1969 | 'id' => $row_quoted['id_member'], |
1894 | 1970 | 'name' => $smcFunc['htmlspecialchars']($row_quoted['real_name']), |
1895 | 1971 | ); |
1972 | + } |
|
1896 | 1973 | |
1897 | 1974 | // Now to get the others. |
1898 | 1975 | $request = $smcFunc['db_query']('', ' |
@@ -1908,18 +1985,19 @@ discard block |
||
1908 | 1985 | 'not_bcc' => 0, |
1909 | 1986 | ) |
1910 | 1987 | ); |
1911 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
1912 | - $context['recipients']['to'][] = array( |
|
1988 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
1989 | + $context['recipients']['to'][] = array( |
|
1913 | 1990 | 'id' => $row['id_member'], |
1914 | 1991 | 'name' => $row['real_name'], |
1915 | 1992 | ); |
1993 | + } |
|
1916 | 1994 | $smcFunc['db_free_result']($request); |
1917 | - } |
|
1918 | - else |
|
1995 | + } else |
|
1919 | 1996 | { |
1920 | 1997 | $_REQUEST['u'] = explode(',', $_REQUEST['u']); |
1921 | - foreach ($_REQUEST['u'] as $key => $uID) |
|
1922 | - $_REQUEST['u'][$key] = (int) $uID; |
|
1998 | + foreach ($_REQUEST['u'] as $key => $uID) { |
|
1999 | + $_REQUEST['u'][$key] = (int) $uID; |
|
2000 | + } |
|
1923 | 2001 | |
1924 | 2002 | $_REQUEST['u'] = array_unique($_REQUEST['u']); |
1925 | 2003 | |
@@ -1933,22 +2011,24 @@ discard block |
||
1933 | 2011 | 'limit' => count($_REQUEST['u']), |
1934 | 2012 | ) |
1935 | 2013 | ); |
1936 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
1937 | - $context['recipients']['to'][] = array( |
|
2014 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
2015 | + $context['recipients']['to'][] = array( |
|
1938 | 2016 | 'id' => $row['id_member'], |
1939 | 2017 | 'name' => $row['real_name'], |
1940 | 2018 | ); |
2019 | + } |
|
1941 | 2020 | $smcFunc['db_free_result']($request); |
1942 | 2021 | } |
1943 | 2022 | |
1944 | 2023 | // Get a literal name list in case the user has JavaScript disabled. |
1945 | 2024 | $names = array(); |
1946 | - foreach ($context['recipients']['to'] as $to) |
|
1947 | - $names[] = $to['name']; |
|
2025 | + foreach ($context['recipients']['to'] as $to) { |
|
2026 | + $names[] = $to['name']; |
|
2027 | + } |
|
1948 | 2028 | $context['to_value'] = empty($names) ? '' : '"' . implode('", "', $names) . '"'; |
2029 | + } else { |
|
2030 | + $context['to_value'] = ''; |
|
1949 | 2031 | } |
1950 | - else |
|
1951 | - $context['to_value'] = ''; |
|
1952 | 2032 | |
1953 | 2033 | // Set the defaults... |
1954 | 2034 | $context['subject'] = $form_subject; |
@@ -2018,8 +2098,9 @@ discard block |
||
2018 | 2098 | |
2019 | 2099 | // validate with loadMemberData() |
2020 | 2100 | $memberResult = loadMemberData($user_info['id'], false); |
2021 | - if (!$memberResult) |
|
2022 | - fatal_lang_error('not_a_user', false); |
|
2101 | + if (!$memberResult) { |
|
2102 | + fatal_lang_error('not_a_user', false); |
|
2103 | + } |
|
2023 | 2104 | list ($memID) = $memberResult; |
2024 | 2105 | |
2025 | 2106 | // drafts is where the functions reside |
@@ -2045,9 +2126,9 @@ discard block |
||
2045 | 2126 | $context['sub_template'] = 'send'; |
2046 | 2127 | loadJavaScriptFile('PersonalMessage.js', array('defer' => false), 'smf_pms'); |
2047 | 2128 | loadJavaScriptFile('suggest.js', array('defer' => false), 'smf_suggest'); |
2129 | + } else { |
|
2130 | + $context['sub_template'] = 'pm'; |
|
2048 | 2131 | } |
2049 | - else |
|
2050 | - $context['sub_template'] = 'pm'; |
|
2051 | 2132 | |
2052 | 2133 | $context['page_title'] = $txt['send_message']; |
2053 | 2134 | |
@@ -2108,10 +2189,11 @@ discard block |
||
2108 | 2189 | ); |
2109 | 2190 | if ($smcFunc['db_num_rows']($request) == 0) |
2110 | 2191 | { |
2111 | - if (!isset($_REQUEST['xml'])) |
|
2112 | - fatal_lang_error('pm_not_yours', false); |
|
2113 | - else |
|
2114 | - $error_types[] = 'pm_not_yours'; |
|
2192 | + if (!isset($_REQUEST['xml'])) { |
|
2193 | + fatal_lang_error('pm_not_yours', false); |
|
2194 | + } else { |
|
2195 | + $error_types[] = 'pm_not_yours'; |
|
2196 | + } |
|
2115 | 2197 | } |
2116 | 2198 | $row_quoted = $smcFunc['db_fetch_assoc']($request); |
2117 | 2199 | $smcFunc['db_free_result']($request); |
@@ -2158,14 +2240,16 @@ discard block |
||
2158 | 2240 | $context['post_error'][$error_type] = true; |
2159 | 2241 | if (isset($txt['error_' . $error_type])) |
2160 | 2242 | { |
2161 | - if ($error_type == 'long_message') |
|
2162 | - $txt['error_' . $error_type] = sprintf($txt['error_' . $error_type], $modSettings['max_messageLength']); |
|
2243 | + if ($error_type == 'long_message') { |
|
2244 | + $txt['error_' . $error_type] = sprintf($txt['error_' . $error_type], $modSettings['max_messageLength']); |
|
2245 | + } |
|
2163 | 2246 | $context['post_error']['messages'][] = $txt['error_' . $error_type]; |
2164 | 2247 | } |
2165 | 2248 | |
2166 | 2249 | // If it's not a minor error flag it as such. |
2167 | - if (!in_array($error_type, array('new_reply', 'not_approved', 'new_replies', 'old_topic', 'need_qr_verification', 'no_subject'))) |
|
2168 | - $context['error_type'] = 'serious'; |
|
2250 | + if (!in_array($error_type, array('new_reply', 'not_approved', 'new_replies', 'old_topic', 'need_qr_verification', 'no_subject'))) { |
|
2251 | + $context['error_type'] = 'serious'; |
|
2252 | + } |
|
2169 | 2253 | } |
2170 | 2254 | |
2171 | 2255 | // We need to load the editor once more. |
@@ -2223,8 +2307,9 @@ discard block |
||
2223 | 2307 | require_once($sourcedir . '/Subs-Auth.php'); |
2224 | 2308 | |
2225 | 2309 | // PM Drafts enabled and needed? |
2226 | - if ($context['drafts_pm_save'] && (isset($_POST['save_draft']) || isset($_POST['id_pm_draft']))) |
|
2227 | - require_once($sourcedir . '/Drafts.php'); |
|
2310 | + if ($context['drafts_pm_save'] && (isset($_POST['save_draft']) || isset($_POST['id_pm_draft']))) { |
|
2311 | + require_once($sourcedir . '/Drafts.php'); |
|
2312 | + } |
|
2228 | 2313 | |
2229 | 2314 | loadLanguage('PersonalMessage', '', false); |
2230 | 2315 | |
@@ -2254,24 +2339,27 @@ discard block |
||
2254 | 2339 | |
2255 | 2340 | if (!empty($postCount) && $postCount >= $modSettings['pm_posts_per_hour']) |
2256 | 2341 | { |
2257 | - if (!isset($_REQUEST['xml'])) |
|
2258 | - fatal_lang_error('pm_too_many_per_hour', true, array($modSettings['pm_posts_per_hour'])); |
|
2259 | - else |
|
2260 | - $post_errors[] = 'pm_too_many_per_hour'; |
|
2342 | + if (!isset($_REQUEST['xml'])) { |
|
2343 | + fatal_lang_error('pm_too_many_per_hour', true, array($modSettings['pm_posts_per_hour'])); |
|
2344 | + } else { |
|
2345 | + $post_errors[] = 'pm_too_many_per_hour'; |
|
2346 | + } |
|
2261 | 2347 | } |
2262 | 2348 | } |
2263 | 2349 | |
2264 | 2350 | // If your session timed out, show an error, but do allow to re-submit. |
2265 | - if (!isset($_REQUEST['xml']) && checkSession('post', '', false) != '') |
|
2266 | - $post_errors[] = 'session_timeout'; |
|
2351 | + if (!isset($_REQUEST['xml']) && checkSession('post', '', false) != '') { |
|
2352 | + $post_errors[] = 'session_timeout'; |
|
2353 | + } |
|
2267 | 2354 | |
2268 | 2355 | $_REQUEST['subject'] = isset($_REQUEST['subject']) ? trim($_REQUEST['subject']) : ''; |
2269 | 2356 | $_REQUEST['to'] = empty($_POST['to']) ? (empty($_GET['to']) ? '' : $_GET['to']) : $_POST['to']; |
2270 | 2357 | $_REQUEST['bcc'] = empty($_POST['bcc']) ? (empty($_GET['bcc']) ? '' : $_GET['bcc']) : $_POST['bcc']; |
2271 | 2358 | |
2272 | 2359 | // Route the input from the 'u' parameter to the 'to'-list. |
2273 | - if (!empty($_POST['u'])) |
|
2274 | - $_POST['recipient_to'] = explode(',', $_POST['u']); |
|
2360 | + if (!empty($_POST['u'])) { |
|
2361 | + $_POST['recipient_to'] = explode(',', $_POST['u']); |
|
2362 | + } |
|
2275 | 2363 | |
2276 | 2364 | // Construct the list of recipients. |
2277 | 2365 | $recipientList = array(); |
@@ -2283,8 +2371,9 @@ discard block |
||
2283 | 2371 | $recipientList[$recipientType] = array(); |
2284 | 2372 | if (!empty($_POST['recipient_' . $recipientType]) && is_array($_POST['recipient_' . $recipientType])) |
2285 | 2373 | { |
2286 | - foreach ($_POST['recipient_' . $recipientType] as $recipient) |
|
2287 | - $recipientList[$recipientType][] = (int) $recipient; |
|
2374 | + foreach ($_POST['recipient_' . $recipientType] as $recipient) { |
|
2375 | + $recipientList[$recipientType][] = (int) $recipient; |
|
2376 | + } |
|
2288 | 2377 | } |
2289 | 2378 | |
2290 | 2379 | // Are there also literal names set? |
@@ -2298,10 +2387,11 @@ discard block |
||
2298 | 2387 | |
2299 | 2388 | foreach ($namedRecipientList[$recipientType] as $index => $recipient) |
2300 | 2389 | { |
2301 | - if (strlen(trim($recipient)) > 0) |
|
2302 | - $namedRecipientList[$recipientType][$index] = $smcFunc['htmlspecialchars']($smcFunc['strtolower'](trim($recipient))); |
|
2303 | - else |
|
2304 | - unset($namedRecipientList[$recipientType][$index]); |
|
2390 | + if (strlen(trim($recipient)) > 0) { |
|
2391 | + $namedRecipientList[$recipientType][$index] = $smcFunc['htmlspecialchars']($smcFunc['strtolower'](trim($recipient))); |
|
2392 | + } else { |
|
2393 | + unset($namedRecipientList[$recipientType][$index]); |
|
2394 | + } |
|
2305 | 2395 | } |
2306 | 2396 | |
2307 | 2397 | if (!empty($namedRecipientList[$recipientType])) |
@@ -2331,8 +2421,9 @@ discard block |
||
2331 | 2421 | } |
2332 | 2422 | |
2333 | 2423 | // Selected a recipient to be deleted? Remove them now. |
2334 | - if (!empty($_POST['delete_recipient'])) |
|
2335 | - $recipientList[$recipientType] = array_diff($recipientList[$recipientType], array((int) $_POST['delete_recipient'])); |
|
2424 | + if (!empty($_POST['delete_recipient'])) { |
|
2425 | + $recipientList[$recipientType] = array_diff($recipientList[$recipientType], array((int) $_POST['delete_recipient'])); |
|
2426 | + } |
|
2336 | 2427 | |
2337 | 2428 | // Make sure we don't include the same name twice |
2338 | 2429 | $recipientList[$recipientType] = array_unique($recipientList[$recipientType]); |
@@ -2342,8 +2433,9 @@ discard block |
||
2342 | 2433 | $is_recipient_change = !empty($_POST['delete_recipient']) || !empty($_POST['to_submit']) || !empty($_POST['bcc_submit']); |
2343 | 2434 | |
2344 | 2435 | // Check if there's at least one recipient. |
2345 | - if (empty($recipientList['to']) && empty($recipientList['bcc'])) |
|
2346 | - $post_errors[] = 'no_to'; |
|
2436 | + if (empty($recipientList['to']) && empty($recipientList['bcc'])) { |
|
2437 | + $post_errors[] = 'no_to'; |
|
2438 | + } |
|
2347 | 2439 | |
2348 | 2440 | // Make sure that we remove the members who did get it from the screen. |
2349 | 2441 | if (!$is_recipient_change) |
@@ -2357,28 +2449,31 @@ discard block |
||
2357 | 2449 | // Since we already have a post error, remove the previous one. |
2358 | 2450 | $post_errors = array_diff($post_errors, array('no_to')); |
2359 | 2451 | |
2360 | - foreach ($namesNotFound[$recipientType] as $name) |
|
2361 | - $context['send_log']['failed'][] = sprintf($txt['pm_error_user_not_found'], $name); |
|
2452 | + foreach ($namesNotFound[$recipientType] as $name) { |
|
2453 | + $context['send_log']['failed'][] = sprintf($txt['pm_error_user_not_found'], $name); |
|
2454 | + } |
|
2362 | 2455 | } |
2363 | 2456 | } |
2364 | 2457 | } |
2365 | 2458 | |
2366 | 2459 | // Did they make any mistakes? |
2367 | - if ($_REQUEST['subject'] == '') |
|
2368 | - $post_errors[] = 'no_subject'; |
|
2369 | - if (!isset($_REQUEST['message']) || $_REQUEST['message'] == '') |
|
2370 | - $post_errors[] = 'no_message'; |
|
2371 | - elseif (!empty($modSettings['max_messageLength']) && $smcFunc['strlen']($_REQUEST['message']) > $modSettings['max_messageLength']) |
|
2372 | - $post_errors[] = 'long_message'; |
|
2373 | - else |
|
2460 | + if ($_REQUEST['subject'] == '') { |
|
2461 | + $post_errors[] = 'no_subject'; |
|
2462 | + } |
|
2463 | + if (!isset($_REQUEST['message']) || $_REQUEST['message'] == '') { |
|
2464 | + $post_errors[] = 'no_message'; |
|
2465 | + } elseif (!empty($modSettings['max_messageLength']) && $smcFunc['strlen']($_REQUEST['message']) > $modSettings['max_messageLength']) { |
|
2466 | + $post_errors[] = 'long_message'; |
|
2467 | + } else |
|
2374 | 2468 | { |
2375 | 2469 | // Preparse the message. |
2376 | 2470 | $message = $_REQUEST['message']; |
2377 | 2471 | preparsecode($message); |
2378 | 2472 | |
2379 | 2473 | // Make sure there's still some content left without the tags. |
2380 | - if ($smcFunc['htmltrim'](strip_tags(parse_bbc($smcFunc['htmlspecialchars']($message, ENT_QUOTES), false), '<img>')) === '' && (!allowedTo('admin_forum') || strpos($message, '[html]') === false)) |
|
2381 | - $post_errors[] = 'no_message'; |
|
2474 | + if ($smcFunc['htmltrim'](strip_tags(parse_bbc($smcFunc['htmlspecialchars']($message, ENT_QUOTES), false), '<img>')) === '' && (!allowedTo('admin_forum') || strpos($message, '[html]') === false)) { |
|
2475 | + $post_errors[] = 'no_message'; |
|
2476 | + } |
|
2382 | 2477 | } |
2383 | 2478 | |
2384 | 2479 | // Wrong verification code? |
@@ -2390,13 +2485,15 @@ discard block |
||
2390 | 2485 | ); |
2391 | 2486 | $context['require_verification'] = create_control_verification($verificationOptions, true); |
2392 | 2487 | |
2393 | - if (is_array($context['require_verification'])) |
|
2394 | - $post_errors = array_merge($post_errors, $context['require_verification']); |
|
2488 | + if (is_array($context['require_verification'])) { |
|
2489 | + $post_errors = array_merge($post_errors, $context['require_verification']); |
|
2490 | + } |
|
2395 | 2491 | } |
2396 | 2492 | |
2397 | 2493 | // If they did, give a chance to make ammends. |
2398 | - if (!empty($post_errors) && !$is_recipient_change && !isset($_REQUEST['preview']) && !isset($_REQUEST['xml'])) |
|
2399 | - return messagePostError($post_errors, $namedRecipientList, $recipientList); |
|
2494 | + if (!empty($post_errors) && !$is_recipient_change && !isset($_REQUEST['preview']) && !isset($_REQUEST['xml'])) { |
|
2495 | + return messagePostError($post_errors, $namedRecipientList, $recipientList); |
|
2496 | + } |
|
2400 | 2497 | |
2401 | 2498 | // Want to take a second glance before you send? |
2402 | 2499 | if (isset($_REQUEST['preview'])) |
@@ -2427,8 +2524,9 @@ discard block |
||
2427 | 2524 | foreach ($namesNotFound as $recipientType => $names) |
2428 | 2525 | { |
2429 | 2526 | $post_errors[] = 'bad_' . $recipientType; |
2430 | - foreach ($names as $name) |
|
2431 | - $context['send_log']['failed'][] = sprintf($txt['pm_error_user_not_found'], $name); |
|
2527 | + foreach ($names as $name) { |
|
2528 | + $context['send_log']['failed'][] = sprintf($txt['pm_error_user_not_found'], $name); |
|
2529 | + } |
|
2432 | 2530 | } |
2433 | 2531 | |
2434 | 2532 | return messagePostError(array(), $namedRecipientList, $recipientList); |
@@ -2458,13 +2556,14 @@ discard block |
||
2458 | 2556 | checkSubmitOnce('check'); |
2459 | 2557 | |
2460 | 2558 | // Do the actual sending of the PM. |
2461 | - if (!empty($recipientList['to']) || !empty($recipientList['bcc'])) |
|
2462 | - $context['send_log'] = sendpm($recipientList, $_REQUEST['subject'], $_REQUEST['message'], true, null, !empty($_REQUEST['pm_head']) ? (int) $_REQUEST['pm_head'] : 0); |
|
2463 | - else |
|
2464 | - $context['send_log'] = array( |
|
2559 | + if (!empty($recipientList['to']) || !empty($recipientList['bcc'])) { |
|
2560 | + $context['send_log'] = sendpm($recipientList, $_REQUEST['subject'], $_REQUEST['message'], true, null, !empty($_REQUEST['pm_head']) ? (int) $_REQUEST['pm_head'] : 0); |
|
2561 | + } else { |
|
2562 | + $context['send_log'] = array( |
|
2465 | 2563 | 'sent' => array(), |
2466 | 2564 | 'failed' => array() |
2467 | 2565 | ); |
2566 | + } |
|
2468 | 2567 | |
2469 | 2568 | // Mark the message as "replied to". |
2470 | 2569 | if (!empty($context['send_log']['sent']) && !empty($_REQUEST['replied_to']) && isset($_REQUEST['f']) && $_REQUEST['f'] == 'inbox') |
@@ -2482,11 +2581,12 @@ discard block |
||
2482 | 2581 | } |
2483 | 2582 | |
2484 | 2583 | // If one or more of the recipient were invalid, go back to the post screen with the failed usernames. |
2485 | - if (!empty($context['send_log']['failed'])) |
|
2486 | - return messagePostError($post_errors, $namesNotFound, array( |
|
2584 | + if (!empty($context['send_log']['failed'])) { |
|
2585 | + return messagePostError($post_errors, $namesNotFound, array( |
|
2487 | 2586 | 'to' => array_intersect($recipientList['to'], $context['send_log']['failed']), |
2488 | 2587 | 'bcc' => array_intersect($recipientList['bcc'], $context['send_log']['failed']) |
2489 | 2588 | )); |
2589 | + } |
|
2490 | 2590 | |
2491 | 2591 | // Message sent successfully? |
2492 | 2592 | if (!empty($context['send_log']) && empty($context['send_log']['failed'])) |
@@ -2494,8 +2594,9 @@ discard block |
||
2494 | 2594 | $context['current_label_redirect'] = $context['current_label_redirect'] . ';done=sent'; |
2495 | 2595 | |
2496 | 2596 | // If we had a PM draft for this one, then its time to remove it since it was just sent |
2497 | - if ($context['drafts_pm_save'] && !empty($_POST['id_pm_draft'])) |
|
2498 | - DeleteDraft($_POST['id_pm_draft']); |
|
2597 | + if ($context['drafts_pm_save'] && !empty($_POST['id_pm_draft'])) { |
|
2598 | + DeleteDraft($_POST['id_pm_draft']); |
|
2599 | + } |
|
2499 | 2600 | } |
2500 | 2601 | |
2501 | 2602 | // Go back to the where they sent from, if possible... |
@@ -2510,24 +2611,28 @@ discard block |
||
2510 | 2611 | |
2511 | 2612 | checkSession('request'); |
2512 | 2613 | |
2513 | - if (isset($_REQUEST['del_selected'])) |
|
2514 | - $_REQUEST['pm_action'] = 'delete'; |
|
2614 | + if (isset($_REQUEST['del_selected'])) { |
|
2615 | + $_REQUEST['pm_action'] = 'delete'; |
|
2616 | + } |
|
2515 | 2617 | |
2516 | 2618 | if (isset($_REQUEST['pm_action']) && $_REQUEST['pm_action'] != '' && !empty($_REQUEST['pms']) && is_array($_REQUEST['pms'])) |
2517 | 2619 | { |
2518 | - foreach ($_REQUEST['pms'] as $pm) |
|
2519 | - $_REQUEST['pm_actions'][(int) $pm] = $_REQUEST['pm_action']; |
|
2620 | + foreach ($_REQUEST['pms'] as $pm) { |
|
2621 | + $_REQUEST['pm_actions'][(int) $pm] = $_REQUEST['pm_action']; |
|
2622 | + } |
|
2520 | 2623 | } |
2521 | 2624 | |
2522 | - if (empty($_REQUEST['pm_actions'])) |
|
2523 | - redirectexit($context['current_label_redirect']); |
|
2625 | + if (empty($_REQUEST['pm_actions'])) { |
|
2626 | + redirectexit($context['current_label_redirect']); |
|
2627 | + } |
|
2524 | 2628 | |
2525 | 2629 | // If we are in conversation, we may need to apply this to every message in the conversation. |
2526 | 2630 | if ($context['display_mode'] == 2 && isset($_REQUEST['conversation'])) |
2527 | 2631 | { |
2528 | 2632 | $id_pms = array(); |
2529 | - foreach ($_REQUEST['pm_actions'] as $pm => $dummy) |
|
2530 | - $id_pms[] = (int) $pm; |
|
2633 | + foreach ($_REQUEST['pm_actions'] as $pm => $dummy) { |
|
2634 | + $id_pms[] = (int) $pm; |
|
2635 | + } |
|
2531 | 2636 | |
2532 | 2637 | $request = $smcFunc['db_query']('', ' |
2533 | 2638 | SELECT id_pm_head, id_pm |
@@ -2538,8 +2643,9 @@ discard block |
||
2538 | 2643 | ) |
2539 | 2644 | ); |
2540 | 2645 | $pm_heads = array(); |
2541 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
2542 | - $pm_heads[$row['id_pm_head']] = $row['id_pm']; |
|
2646 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
2647 | + $pm_heads[$row['id_pm_head']] = $row['id_pm']; |
|
2648 | + } |
|
2543 | 2649 | $smcFunc['db_free_result']($request); |
2544 | 2650 | |
2545 | 2651 | $request = $smcFunc['db_query']('', ' |
@@ -2553,8 +2659,9 @@ discard block |
||
2553 | 2659 | // Copy the action from the single to PM to the others. |
2554 | 2660 | while ($row = $smcFunc['db_fetch_assoc']($request)) |
2555 | 2661 | { |
2556 | - if (isset($pm_heads[$row['id_pm_head']]) && isset($_REQUEST['pm_actions'][$pm_heads[$row['id_pm_head']]])) |
|
2557 | - $_REQUEST['pm_actions'][$row['id_pm']] = $_REQUEST['pm_actions'][$pm_heads[$row['id_pm_head']]]; |
|
2662 | + if (isset($pm_heads[$row['id_pm_head']]) && isset($_REQUEST['pm_actions'][$pm_heads[$row['id_pm_head']]])) { |
|
2663 | + $_REQUEST['pm_actions'][$row['id_pm']] = $_REQUEST['pm_actions'][$pm_heads[$row['id_pm_head']]]; |
|
2664 | + } |
|
2558 | 2665 | } |
2559 | 2666 | $smcFunc['db_free_result']($request); |
2560 | 2667 | } |
@@ -2566,22 +2673,21 @@ discard block |
||
2566 | 2673 | $labels = array(); |
2567 | 2674 | foreach ($_REQUEST['pm_actions'] as $pm => $action) |
2568 | 2675 | { |
2569 | - if ($action === 'delete') |
|
2570 | - $to_delete[] = (int) $pm; |
|
2571 | - else |
|
2676 | + if ($action === 'delete') { |
|
2677 | + $to_delete[] = (int) $pm; |
|
2678 | + } else |
|
2572 | 2679 | { |
2573 | 2680 | if (substr($action, 0, 4) == 'add_') |
2574 | 2681 | { |
2575 | 2682 | $type = 'add'; |
2576 | 2683 | $action = substr($action, 4); |
2577 | - } |
|
2578 | - elseif (substr($action, 0, 4) == 'rem_') |
|
2684 | + } elseif (substr($action, 0, 4) == 'rem_') |
|
2579 | 2685 | { |
2580 | 2686 | $type = 'rem'; |
2581 | 2687 | $action = substr($action, 4); |
2688 | + } else { |
|
2689 | + $type = 'unk'; |
|
2582 | 2690 | } |
2583 | - else |
|
2584 | - $type = 'unk'; |
|
2585 | 2691 | |
2586 | 2692 | if ($action == '-1' || (int) $action > 0) |
2587 | 2693 | { |
@@ -2592,8 +2698,9 @@ discard block |
||
2592 | 2698 | } |
2593 | 2699 | |
2594 | 2700 | // Deleting, it looks like? |
2595 | - if (!empty($to_delete)) |
|
2596 | - deleteMessages($to_delete, $context['display_mode'] == 2 ? null : $context['folder']); |
|
2701 | + if (!empty($to_delete)) { |
|
2702 | + deleteMessages($to_delete, $context['display_mode'] == 2 ? null : $context['folder']); |
|
2703 | + } |
|
2597 | 2704 | |
2598 | 2705 | // Are we labeling anything? |
2599 | 2706 | if (!empty($to_label) && $context['folder'] == 'inbox') |
@@ -2661,8 +2768,7 @@ discard block |
||
2661 | 2768 | } |
2662 | 2769 | |
2663 | 2770 | $smcFunc['db_free_result']($request2); |
2664 | - } |
|
2665 | - elseif ($type == 'rem') |
|
2771 | + } elseif ($type == 'rem') |
|
2666 | 2772 | { |
2667 | 2773 | // If we're removing from the inbox, see if we have at least one other label. |
2668 | 2774 | // This query is faster than the one above |
@@ -2694,21 +2800,25 @@ discard block |
||
2694 | 2800 | if ($to_label[$row['id_pm']] != '-1') |
2695 | 2801 | { |
2696 | 2802 | // If this label is in the list and we're not adding it, remove it |
2697 | - if (array_key_exists($to_label[$row['id_pm']], $labels) && $type !== 'add') |
|
2698 | - unset($labels[$to_label[$row['id_pm']]]); |
|
2699 | - else if ($type !== 'rem') |
|
2700 | - $labels[$to_label[$row['id_pm']]] = $to_label[$row['id_pm']]; |
|
2803 | + if (array_key_exists($to_label[$row['id_pm']], $labels) && $type !== 'add') { |
|
2804 | + unset($labels[$to_label[$row['id_pm']]]); |
|
2805 | + } else if ($type !== 'rem') { |
|
2806 | + $labels[$to_label[$row['id_pm']]] = $to_label[$row['id_pm']]; |
|
2807 | + } |
|
2701 | 2808 | } |
2702 | 2809 | |
2703 | 2810 | // Removing all labels or just removing the inbox label |
2704 | - if ($type == 'rem' && empty($labels)) |
|
2705 | - $in_inbox = (empty($context['can_remove_inbox']) ? 1 : 0); |
|
2811 | + if ($type == 'rem' && empty($labels)) { |
|
2812 | + $in_inbox = (empty($context['can_remove_inbox']) ? 1 : 0); |
|
2813 | + } |
|
2706 | 2814 | // Adding new labels, but removing inbox and applying new ones |
2707 | - elseif ($type == 'add' && !empty($options['pm_remove_inbox_label']) && !empty($labels)) |
|
2708 | - $in_inbox = 0; |
|
2815 | + elseif ($type == 'add' && !empty($options['pm_remove_inbox_label']) && !empty($labels)) { |
|
2816 | + $in_inbox = 0; |
|
2817 | + } |
|
2709 | 2818 | // Just adding it to the inbox |
2710 | - else |
|
2711 | - $in_inbox = 1; |
|
2819 | + else { |
|
2820 | + $in_inbox = 1; |
|
2821 | + } |
|
2712 | 2822 | |
2713 | 2823 | // Are we adding it to or removing it from the inbox? |
2714 | 2824 | if ($in_inbox != $row['in_inbox']) |
@@ -2750,8 +2860,9 @@ discard block |
||
2750 | 2860 | if (!empty($labels_to_apply)) |
2751 | 2861 | { |
2752 | 2862 | $inserts = array(); |
2753 | - foreach ($labels_to_apply as $label) |
|
2754 | - $inserts[] = array($row['id_pm'], $label); |
|
2863 | + foreach ($labels_to_apply as $label) { |
|
2864 | + $inserts[] = array($row['id_pm'], $label); |
|
2865 | + } |
|
2755 | 2866 | |
2756 | 2867 | $smcFunc['db_insert']('', |
2757 | 2868 | '{db_prefix}pm_labeled_messages', |
@@ -2795,11 +2906,13 @@ discard block |
||
2795 | 2906 | checkSession('get'); |
2796 | 2907 | |
2797 | 2908 | // If all then delete all messages the user has. |
2798 | - if ($_REQUEST['f'] == 'all') |
|
2799 | - deleteMessages(null, null); |
|
2909 | + if ($_REQUEST['f'] == 'all') { |
|
2910 | + deleteMessages(null, null); |
|
2911 | + } |
|
2800 | 2912 | // Otherwise just the selected folder. |
2801 | - else |
|
2802 | - deleteMessages(null, $_REQUEST['f'] != 'sent' ? 'inbox' : 'sent'); |
|
2913 | + else { |
|
2914 | + deleteMessages(null, $_REQUEST['f'] != 'sent' ? 'inbox' : 'sent'); |
|
2915 | + } |
|
2803 | 2916 | |
2804 | 2917 | // Done... all gone. |
2805 | 2918 | redirectexit($context['current_label_redirect']); |
@@ -2836,8 +2949,9 @@ discard block |
||
2836 | 2949 | 'msgtime' => $deleteTime, |
2837 | 2950 | ) |
2838 | 2951 | ); |
2839 | - while ($row = $smcFunc['db_fetch_row']($request)) |
|
2840 | - $toDelete[] = $row[0]; |
|
2952 | + while ($row = $smcFunc['db_fetch_row']($request)) { |
|
2953 | + $toDelete[] = $row[0]; |
|
2954 | + } |
|
2841 | 2955 | $smcFunc['db_free_result']($request); |
2842 | 2956 | |
2843 | 2957 | // Select all messages in their inbox older than $deleteTime. |
@@ -2854,8 +2968,9 @@ discard block |
||
2854 | 2968 | 'msgtime' => $deleteTime, |
2855 | 2969 | ) |
2856 | 2970 | ); |
2857 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
2858 | - $toDelete[] = $row['id_pm']; |
|
2971 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
2972 | + $toDelete[] = $row['id_pm']; |
|
2973 | + } |
|
2859 | 2974 | $smcFunc['db_free_result']($request); |
2860 | 2975 | |
2861 | 2976 | // Delete the actual messages. |
@@ -2886,26 +3001,29 @@ discard block |
||
2886 | 3001 | { |
2887 | 3002 | global $user_info, $smcFunc; |
2888 | 3003 | |
2889 | - if ($owner === null) |
|
2890 | - $owner = array($user_info['id']); |
|
2891 | - elseif (empty($owner)) |
|
2892 | - return; |
|
2893 | - elseif (!is_array($owner)) |
|
2894 | - $owner = array($owner); |
|
3004 | + if ($owner === null) { |
|
3005 | + $owner = array($user_info['id']); |
|
3006 | + } elseif (empty($owner)) { |
|
3007 | + return; |
|
3008 | + } elseif (!is_array($owner)) { |
|
3009 | + $owner = array($owner); |
|
3010 | + } |
|
2895 | 3011 | |
2896 | 3012 | if ($personal_messages !== null) |
2897 | 3013 | { |
2898 | - if (empty($personal_messages) || !is_array($personal_messages)) |
|
2899 | - return; |
|
3014 | + if (empty($personal_messages) || !is_array($personal_messages)) { |
|
3015 | + return; |
|
3016 | + } |
|
2900 | 3017 | |
2901 | - foreach ($personal_messages as $index => $delete_id) |
|
2902 | - $personal_messages[$index] = (int) $delete_id; |
|
3018 | + foreach ($personal_messages as $index => $delete_id) { |
|
3019 | + $personal_messages[$index] = (int) $delete_id; |
|
3020 | + } |
|
2903 | 3021 | |
2904 | 3022 | $where = ' |
2905 | 3023 | AND id_pm IN ({array_int:pm_list})'; |
3024 | + } else { |
|
3025 | + $where = ''; |
|
2906 | 3026 | } |
2907 | - else |
|
2908 | - $where = ''; |
|
2909 | 3027 | |
2910 | 3028 | if ($folder == 'sent' || $folder === null) |
2911 | 3029 | { |
@@ -2940,17 +3058,19 @@ discard block |
||
2940 | 3058 | // ...And update the statistics accordingly - now including unread messages!. |
2941 | 3059 | while ($row = $smcFunc['db_fetch_assoc']($request)) |
2942 | 3060 | { |
2943 | - if ($row['is_read']) |
|
2944 | - updateMemberData($row['id_member'], array('instant_messages' => $where == '' ? 0 : 'instant_messages - ' . $row['num_deleted_messages'])); |
|
2945 | - else |
|
2946 | - updateMemberData($row['id_member'], array('instant_messages' => $where == '' ? 0 : 'instant_messages - ' . $row['num_deleted_messages'], 'unread_messages' => $where == '' ? 0 : 'unread_messages - ' . $row['num_deleted_messages'])); |
|
3061 | + if ($row['is_read']) { |
|
3062 | + updateMemberData($row['id_member'], array('instant_messages' => $where == '' ? 0 : 'instant_messages - ' . $row['num_deleted_messages'])); |
|
3063 | + } else { |
|
3064 | + updateMemberData($row['id_member'], array('instant_messages' => $where == '' ? 0 : 'instant_messages - ' . $row['num_deleted_messages'], 'unread_messages' => $where == '' ? 0 : 'unread_messages - ' . $row['num_deleted_messages'])); |
|
3065 | + } |
|
2947 | 3066 | |
2948 | 3067 | // If this is the current member we need to make their message count correct. |
2949 | 3068 | if ($user_info['id'] == $row['id_member']) |
2950 | 3069 | { |
2951 | 3070 | $user_info['messages'] -= $row['num_deleted_messages']; |
2952 | - if (!($row['is_read'])) |
|
2953 | - $user_info['unread_messages'] -= $row['num_deleted_messages']; |
|
3071 | + if (!($row['is_read'])) { |
|
3072 | + $user_info['unread_messages'] -= $row['num_deleted_messages']; |
|
3073 | + } |
|
2954 | 3074 | } |
2955 | 3075 | } |
2956 | 3076 | $smcFunc['db_free_result']($request); |
@@ -3018,8 +3138,9 @@ discard block |
||
3018 | 3138 | ) |
3019 | 3139 | ); |
3020 | 3140 | $remove_pms = array(); |
3021 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
3022 | - $remove_pms[] = $row['sender']; |
|
3141 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
3142 | + $remove_pms[] = $row['sender']; |
|
3143 | + } |
|
3023 | 3144 | $smcFunc['db_free_result']($request); |
3024 | 3145 | |
3025 | 3146 | if (!empty($remove_pms)) |
@@ -3064,8 +3185,9 @@ discard block |
||
3064 | 3185 | { |
3065 | 3186 | global $user_info, $context, $smcFunc; |
3066 | 3187 | |
3067 | - if ($owner === null) |
|
3068 | - $owner = $user_info['id']; |
|
3188 | + if ($owner === null) { |
|
3189 | + $owner = $user_info['id']; |
|
3190 | + } |
|
3069 | 3191 | |
3070 | 3192 | $in_inbox = ''; |
3071 | 3193 | |
@@ -3089,8 +3211,7 @@ discard block |
||
3089 | 3211 | } |
3090 | 3212 | |
3091 | 3213 | $smcFunc['db_free_result']($get_messages); |
3092 | - } |
|
3093 | - elseif ($label = '-1') |
|
3214 | + } elseif ($label = '-1') |
|
3094 | 3215 | { |
3095 | 3216 | // Marking all PMs in your inbox read |
3096 | 3217 | $in_inbox = ' |
@@ -3115,8 +3236,9 @@ discard block |
||
3115 | 3236 | { |
3116 | 3237 | if ($owner == $user_info['id']) |
3117 | 3238 | { |
3118 | - foreach ($context['labels'] as $label) |
|
3119 | - $context['labels'][(int) $label['id']]['unread_messages'] = 0; |
|
3239 | + foreach ($context['labels'] as $label) { |
|
3240 | + $context['labels'][(int) $label['id']]['unread_messages'] = 0; |
|
3241 | + } |
|
3120 | 3242 | } |
3121 | 3243 | |
3122 | 3244 | $result = $smcFunc['db_query']('', ' |
@@ -3136,8 +3258,9 @@ discard block |
||
3136 | 3258 | { |
3137 | 3259 | $total_unread += $row['num']; |
3138 | 3260 | |
3139 | - if ($owner != $user_info['id'] || empty($row['id_pm'])) |
|
3140 | - continue; |
|
3261 | + if ($owner != $user_info['id'] || empty($row['id_pm'])) { |
|
3262 | + continue; |
|
3263 | + } |
|
3141 | 3264 | |
3142 | 3265 | $this_labels = array(); |
3143 | 3266 | |
@@ -3161,11 +3284,13 @@ discard block |
||
3161 | 3284 | |
3162 | 3285 | $smcFunc['db_free_result']($result2); |
3163 | 3286 | |
3164 | - foreach ($this_labels as $this_label) |
|
3165 | - $context['labels'][$this_label]['unread_messages'] += $row['num']; |
|
3287 | + foreach ($this_labels as $this_label) { |
|
3288 | + $context['labels'][$this_label]['unread_messages'] += $row['num']; |
|
3289 | + } |
|
3166 | 3290 | |
3167 | - if ($row['in_inbox'] == 1) |
|
3168 | - $context['labels'][-1]['unread_messages'] += $row['num']; |
|
3291 | + if ($row['in_inbox'] == 1) { |
|
3292 | + $context['labels'][-1]['unread_messages'] += $row['num']; |
|
3293 | + } |
|
3169 | 3294 | } |
3170 | 3295 | $smcFunc['db_free_result']($result); |
3171 | 3296 | |
@@ -3174,8 +3299,9 @@ discard block |
||
3174 | 3299 | updateMemberData($owner, array('unread_messages' => $total_unread)); |
3175 | 3300 | |
3176 | 3301 | // If it was for the current member, reflect this in the $user_info array too. |
3177 | - if ($owner == $user_info['id']) |
|
3178 | - $user_info['unread_messages'] = $total_unread; |
|
3302 | + if ($owner == $user_info['id']) { |
|
3303 | + $user_info['unread_messages'] = $total_unread; |
|
3304 | + } |
|
3179 | 3305 | } |
3180 | 3306 | } |
3181 | 3307 | |
@@ -3203,8 +3329,9 @@ discard block |
||
3203 | 3329 | // Add all existing labels to the array to save, slashing them as necessary... |
3204 | 3330 | foreach ($context['labels'] as $label) |
3205 | 3331 | { |
3206 | - if ($label['id'] != -1) |
|
3207 | - $the_labels[$label['id']] = $label['name']; |
|
3332 | + if ($label['id'] != -1) { |
|
3333 | + $the_labels[$label['id']] = $label['name']; |
|
3334 | + } |
|
3208 | 3335 | } |
3209 | 3336 | |
3210 | 3337 | if (isset($_POST[$context['session_var']])) |
@@ -3223,8 +3350,9 @@ discard block |
||
3223 | 3350 | { |
3224 | 3351 | $_POST['label'] = strtr($smcFunc['htmlspecialchars'](trim($_POST['label'])), array(',' => ',')); |
3225 | 3352 | |
3226 | - if ($smcFunc['strlen']($_POST['label']) > 30) |
|
3227 | - $_POST['label'] = $smcFunc['substr']($_POST['label'], 0, 30); |
|
3353 | + if ($smcFunc['strlen']($_POST['label']) > 30) { |
|
3354 | + $_POST['label'] = $smcFunc['substr']($_POST['label'], 0, 30); |
|
3355 | + } |
|
3228 | 3356 | if ($_POST['label'] != '') |
3229 | 3357 | { |
3230 | 3358 | $the_labels[] = $_POST['label']; |
@@ -3245,24 +3373,25 @@ discard block |
||
3245 | 3373 | { |
3246 | 3374 | foreach ($the_labels as $id => $name) |
3247 | 3375 | { |
3248 | - if ($id == -1) |
|
3249 | - continue; |
|
3250 | - elseif (isset($_POST['label_name'][$id])) |
|
3376 | + if ($id == -1) { |
|
3377 | + continue; |
|
3378 | + } elseif (isset($_POST['label_name'][$id])) |
|
3251 | 3379 | { |
3252 | 3380 | $_POST['label_name'][$id] = trim(strtr($smcFunc['htmlspecialchars']($_POST['label_name'][$id]), array(',' => ','))); |
3253 | 3381 | |
3254 | - if ($smcFunc['strlen']($_POST['label_name'][$id]) > 30) |
|
3255 | - $_POST['label_name'][$id] = $smcFunc['substr']($_POST['label_name'][$id], 0, 30); |
|
3382 | + if ($smcFunc['strlen']($_POST['label_name'][$id]) > 30) { |
|
3383 | + $_POST['label_name'][$id] = $smcFunc['substr']($_POST['label_name'][$id], 0, 30); |
|
3384 | + } |
|
3256 | 3385 | if ($_POST['label_name'][$id] != '') |
3257 | 3386 | { |
3258 | 3387 | // Changing the name of this label? |
3259 | - if ($the_labels[$id] != $_POST['label_name'][$id]) |
|
3260 | - $label_updates[$id] = $_POST['label_name'][$id]; |
|
3388 | + if ($the_labels[$id] != $_POST['label_name'][$id]) { |
|
3389 | + $label_updates[$id] = $_POST['label_name'][$id]; |
|
3390 | + } |
|
3261 | 3391 | |
3262 | 3392 | $the_labels[(int) $id] = $_POST['label_name'][$id]; |
3263 | 3393 | |
3264 | - } |
|
3265 | - else |
|
3394 | + } else |
|
3266 | 3395 | { |
3267 | 3396 | unset($the_labels[(int) $id]); |
3268 | 3397 | $labels_to_remove[] = $id; |
@@ -3276,8 +3405,9 @@ discard block |
||
3276 | 3405 | if (!empty($labels_to_add)) |
3277 | 3406 | { |
3278 | 3407 | $inserts = array(); |
3279 | - foreach ($labels_to_add AS $label) |
|
3280 | - $inserts[] = array($user_info['id'], $label); |
|
3408 | + foreach ($labels_to_add AS $label) { |
|
3409 | + $inserts[] = array($user_info['id'], $label); |
|
3410 | + } |
|
3281 | 3411 | |
3282 | 3412 | $smcFunc['db_insert']('', '{db_prefix}pm_labels', array('id_member' => 'int', 'name' => 'string-30'), $inserts, array()); |
3283 | 3413 | } |
@@ -3367,8 +3497,9 @@ discard block |
||
3367 | 3497 | // Each action... |
3368 | 3498 | foreach ($rule['actions'] as $k2 => $action) |
3369 | 3499 | { |
3370 | - if ($action['t'] != 'lab' || !in_array($action['v'], $labels_to_remove)) |
|
3371 | - continue; |
|
3500 | + if ($action['t'] != 'lab' || !in_array($action['v'], $labels_to_remove)) { |
|
3501 | + continue; |
|
3502 | + } |
|
3372 | 3503 | |
3373 | 3504 | $rule_changes[] = $rule['id']; |
3374 | 3505 | |
@@ -3383,8 +3514,8 @@ discard block |
||
3383 | 3514 | { |
3384 | 3515 | $rule_changes = array_unique($rule_changes); |
3385 | 3516 | // Update/delete as appropriate. |
3386 | - foreach ($rule_changes as $k => $id) |
|
3387 | - if (!empty($context['rules'][$id]['actions'])) |
|
3517 | + foreach ($rule_changes as $k => $id) { |
|
3518 | + if (!empty($context['rules'][$id]['actions'])) |
|
3388 | 3519 | { |
3389 | 3520 | $smcFunc['db_query']('', ' |
3390 | 3521 | UPDATE {db_prefix}pm_rules |
@@ -3397,12 +3528,13 @@ discard block |
||
3397 | 3528 | 'actions' => json_encode($context['rules'][$id]['actions']), |
3398 | 3529 | ) |
3399 | 3530 | ); |
3531 | + } |
|
3400 | 3532 | unset($rule_changes[$k]); |
3401 | 3533 | } |
3402 | 3534 | |
3403 | 3535 | // Anything left here means it's lost all actions... |
3404 | - if (!empty($rule_changes)) |
|
3405 | - $smcFunc['db_query']('', ' |
|
3536 | + if (!empty($rule_changes)) { |
|
3537 | + $smcFunc['db_query']('', ' |
|
3406 | 3538 | DELETE FROM {db_prefix}pm_rules |
3407 | 3539 | WHERE id_rule IN ({array_int:rule_list}) |
3408 | 3540 | AND id_member = {int:current_member}', |
@@ -3411,6 +3543,7 @@ discard block |
||
3411 | 3543 | 'rule_list' => $rule_changes, |
3412 | 3544 | ) |
3413 | 3545 | ); |
3546 | + } |
|
3414 | 3547 | } |
3415 | 3548 | |
3416 | 3549 | // Make sure we're not caching this! |
@@ -3480,8 +3613,9 @@ discard block |
||
3480 | 3613 | // Save the fields. |
3481 | 3614 | saveProfileFields(); |
3482 | 3615 | |
3483 | - if (!empty($profile_vars)) |
|
3484 | - updateMemberData($user_info['id'], $profile_vars); |
|
3616 | + if (!empty($profile_vars)) { |
|
3617 | + updateMemberData($user_info['id'], $profile_vars); |
|
3618 | + } |
|
3485 | 3619 | } |
3486 | 3620 | |
3487 | 3621 | setupProfileContext( |
@@ -3506,13 +3640,15 @@ discard block |
||
3506 | 3640 | global $user_info, $language, $modSettings, $smcFunc; |
3507 | 3641 | |
3508 | 3642 | // Check that this feature is even enabled! |
3509 | - if (empty($modSettings['enableReportPM']) || empty($_REQUEST['pmsg'])) |
|
3510 | - fatal_lang_error('no_access', false); |
|
3643 | + if (empty($modSettings['enableReportPM']) || empty($_REQUEST['pmsg'])) { |
|
3644 | + fatal_lang_error('no_access', false); |
|
3645 | + } |
|
3511 | 3646 | |
3512 | 3647 | $pmsg = (int) $_REQUEST['pmsg']; |
3513 | 3648 | |
3514 | - if (!isAccessiblePM($pmsg, 'inbox')) |
|
3515 | - fatal_lang_error('no_access', false); |
|
3649 | + if (!isAccessiblePM($pmsg, 'inbox')) { |
|
3650 | + fatal_lang_error('no_access', false); |
|
3651 | + } |
|
3516 | 3652 | |
3517 | 3653 | $context['pm_id'] = $pmsg; |
3518 | 3654 | $context['page_title'] = $txt['pm_report_title']; |
@@ -3534,8 +3670,9 @@ discard block |
||
3534 | 3670 | ) |
3535 | 3671 | ); |
3536 | 3672 | $context['admins'] = array(); |
3537 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
3538 | - $context['admins'][$row['id_member']] = $row['real_name']; |
|
3673 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
3674 | + $context['admins'][$row['id_member']] = $row['real_name']; |
|
3675 | + } |
|
3539 | 3676 | $smcFunc['db_free_result']($request); |
3540 | 3677 | |
3541 | 3678 | // How many admins in total? |
@@ -3564,8 +3701,9 @@ discard block |
||
3564 | 3701 | ) |
3565 | 3702 | ); |
3566 | 3703 | // Can only be a hacker here! |
3567 | - if ($smcFunc['db_num_rows']($request) == 0) |
|
3568 | - fatal_lang_error('no_access', false); |
|
3704 | + if ($smcFunc['db_num_rows']($request) == 0) { |
|
3705 | + fatal_lang_error('no_access', false); |
|
3706 | + } |
|
3569 | 3707 | list ($subject, $body, $time, $memberFromID, $memberFromName) = $smcFunc['db_fetch_row']($request); |
3570 | 3708 | $smcFunc['db_free_result']($request); |
3571 | 3709 | |
@@ -3589,15 +3727,17 @@ discard block |
||
3589 | 3727 | while ($row = $smcFunc['db_fetch_assoc']($request)) |
3590 | 3728 | { |
3591 | 3729 | // If it's hidden still don't reveal their names - privacy after all ;) |
3592 | - if ($row['bcc']) |
|
3593 | - $hidden_recipients++; |
|
3594 | - else |
|
3595 | - $recipients[] = '[url=' . $scripturl . '?action=profile;u=' . $row['id_member_to'] . ']' . $row['to_name'] . '[/url]'; |
|
3730 | + if ($row['bcc']) { |
|
3731 | + $hidden_recipients++; |
|
3732 | + } else { |
|
3733 | + $recipients[] = '[url=' . $scripturl . '?action=profile;u=' . $row['id_member_to'] . ']' . $row['to_name'] . '[/url]'; |
|
3734 | + } |
|
3596 | 3735 | } |
3597 | 3736 | $smcFunc['db_free_result']($request); |
3598 | 3737 | |
3599 | - if ($hidden_recipients) |
|
3600 | - $recipients[] = sprintf($txt['pm_report_pm_hidden'], $hidden_recipients); |
|
3738 | + if ($hidden_recipients) { |
|
3739 | + $recipients[] = sprintf($txt['pm_report_pm_hidden'], $hidden_recipients); |
|
3740 | + } |
|
3601 | 3741 | |
3602 | 3742 | // Now let's get out and loop through the admins. |
3603 | 3743 | $request = $smcFunc['db_query']('', ' |
@@ -3613,8 +3753,9 @@ discard block |
||
3613 | 3753 | ); |
3614 | 3754 | |
3615 | 3755 | // Maybe we shouldn't advertise this? |
3616 | - if ($smcFunc['db_num_rows']($request) == 0) |
|
3617 | - fatal_lang_error('no_access', false); |
|
3756 | + if ($smcFunc['db_num_rows']($request) == 0) { |
|
3757 | + fatal_lang_error('no_access', false); |
|
3758 | + } |
|
3618 | 3759 | |
3619 | 3760 | $memberFromName = un_htmlspecialchars($memberFromName); |
3620 | 3761 | |
@@ -3633,8 +3774,9 @@ discard block |
||
3633 | 3774 | // Make the body. |
3634 | 3775 | $report_body = str_replace(array('{REPORTER}', '{SENDER}'), array(un_htmlspecialchars($user_info['name']), $memberFromName), $txt['pm_report_pm_user_sent']); |
3635 | 3776 | $report_body .= "\n" . '[b]' . $_POST['reason'] . '[/b]' . "\n\n"; |
3636 | - if (!empty($recipients)) |
|
3637 | - $report_body .= $txt['pm_report_pm_other_recipients'] . ' ' . implode(', ', $recipients) . "\n\n"; |
|
3777 | + if (!empty($recipients)) { |
|
3778 | + $report_body .= $txt['pm_report_pm_other_recipients'] . ' ' . implode(', ', $recipients) . "\n\n"; |
|
3779 | + } |
|
3638 | 3780 | $report_body .= $txt['pm_report_pm_unedited_below'] . "\n" . '[quote author=' . (empty($memberFromID) ? '"' . $memberFromName . '"' : $memberFromName . ' link=action=profile;u=' . $memberFromID . ' date=' . $time) . ']' . "\n" . un_htmlspecialchars($body) . '[/quote]'; |
3639 | 3781 | |
3640 | 3782 | // Plonk it in the array ;) |
@@ -3654,12 +3796,14 @@ discard block |
||
3654 | 3796 | $smcFunc['db_free_result']($request); |
3655 | 3797 | |
3656 | 3798 | // Send a different email for each language. |
3657 | - foreach ($messagesToSend as $lang => $message) |
|
3658 | - sendpm($message['recipients'], $message['subject'], $message['body']); |
|
3799 | + foreach ($messagesToSend as $lang => $message) { |
|
3800 | + sendpm($message['recipients'], $message['subject'], $message['body']); |
|
3801 | + } |
|
3659 | 3802 | |
3660 | 3803 | // Give the user their own language back! |
3661 | - if (!empty($modSettings['userLanguage'])) |
|
3662 | - loadLanguage('PersonalMessage', '', false); |
|
3804 | + if (!empty($modSettings['userLanguage'])) { |
|
3805 | + loadLanguage('PersonalMessage', '', false); |
|
3806 | + } |
|
3663 | 3807 | |
3664 | 3808 | // Leave them with a template. |
3665 | 3809 | $context['sub_template'] = 'report_message_complete'; |
@@ -3705,8 +3849,9 @@ discard block |
||
3705 | 3849 | while ($row = $smcFunc['db_fetch_assoc']($request)) |
3706 | 3850 | { |
3707 | 3851 | // Hide hidden groups! |
3708 | - if ($row['hidden'] && !$row['can_moderate'] && !allowedTo('manage_membergroups')) |
|
3709 | - continue; |
|
3852 | + if ($row['hidden'] && !$row['can_moderate'] && !allowedTo('manage_membergroups')) { |
|
3853 | + continue; |
|
3854 | + } |
|
3710 | 3855 | |
3711 | 3856 | $context['groups'][$row['id_group']] = $row['group_name']; |
3712 | 3857 | } |
@@ -3732,9 +3877,10 @@ discard block |
||
3732 | 3877 | $context['rule'] = $context['rules'][$context['rid']]; |
3733 | 3878 | $members = array(); |
3734 | 3879 | // Need to get member names! |
3735 | - foreach ($context['rule']['criteria'] as $k => $criteria) |
|
3736 | - if ($criteria['t'] == 'mid' && !empty($criteria['v'])) |
|
3880 | + foreach ($context['rule']['criteria'] as $k => $criteria) { |
|
3881 | + if ($criteria['t'] == 'mid' && !empty($criteria['v'])) |
|
3737 | 3882 | $members[(int) $criteria['v']] = $k; |
3883 | + } |
|
3738 | 3884 | |
3739 | 3885 | if (!empty($members)) |
3740 | 3886 | { |
@@ -3746,19 +3892,20 @@ discard block |
||
3746 | 3892 | 'member_list' => array_keys($members), |
3747 | 3893 | ) |
3748 | 3894 | ); |
3749 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
3750 | - $context['rule']['criteria'][$members[$row['id_member']]]['v'] = $row['member_name']; |
|
3895 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
3896 | + $context['rule']['criteria'][$members[$row['id_member']]]['v'] = $row['member_name']; |
|
3897 | + } |
|
3751 | 3898 | $smcFunc['db_free_result']($request); |
3752 | 3899 | } |
3753 | - } |
|
3754 | - else |
|
3755 | - $context['rule'] = array( |
|
3900 | + } else { |
|
3901 | + $context['rule'] = array( |
|
3756 | 3902 | 'id' => '', |
3757 | 3903 | 'name' => '', |
3758 | 3904 | 'criteria' => array(), |
3759 | 3905 | 'actions' => array(), |
3760 | 3906 | 'logic' => 'and', |
3761 | 3907 | ); |
3908 | + } |
|
3762 | 3909 | } |
3763 | 3910 | // Saving? |
3764 | 3911 | elseif (isset($_GET['save'])) |
@@ -3768,22 +3915,25 @@ discard block |
||
3768 | 3915 | |
3769 | 3916 | // Name is easy! |
3770 | 3917 | $ruleName = $smcFunc['htmlspecialchars'](trim($_POST['rule_name'])); |
3771 | - if (empty($ruleName)) |
|
3772 | - fatal_lang_error('pm_rule_no_name', false); |
|
3918 | + if (empty($ruleName)) { |
|
3919 | + fatal_lang_error('pm_rule_no_name', false); |
|
3920 | + } |
|
3773 | 3921 | |
3774 | 3922 | // Sanity check... |
3775 | - if (empty($_POST['ruletype']) || empty($_POST['acttype'])) |
|
3776 | - fatal_lang_error('pm_rule_no_criteria', false); |
|
3923 | + if (empty($_POST['ruletype']) || empty($_POST['acttype'])) { |
|
3924 | + fatal_lang_error('pm_rule_no_criteria', false); |
|
3925 | + } |
|
3777 | 3926 | |
3778 | 3927 | // Let's do the criteria first - it's also hardest! |
3779 | 3928 | $criteria = array(); |
3780 | 3929 | foreach ($_POST['ruletype'] as $ind => $type) |
3781 | 3930 | { |
3782 | 3931 | // Check everything is here... |
3783 | - if ($type == 'gid' && (!isset($_POST['ruledefgroup'][$ind]) || !isset($context['groups'][$_POST['ruledefgroup'][$ind]]))) |
|
3784 | - continue; |
|
3785 | - elseif ($type != 'bud' && !isset($_POST['ruledef'][$ind])) |
|
3786 | - continue; |
|
3932 | + if ($type == 'gid' && (!isset($_POST['ruledefgroup'][$ind]) || !isset($context['groups'][$_POST['ruledefgroup'][$ind]]))) { |
|
3933 | + continue; |
|
3934 | + } elseif ($type != 'bud' && !isset($_POST['ruledef'][$ind])) { |
|
3935 | + continue; |
|
3936 | + } |
|
3787 | 3937 | |
3788 | 3938 | // Members need to be found. |
3789 | 3939 | if ($type == 'mid') |
@@ -3807,13 +3957,13 @@ discard block |
||
3807 | 3957 | $smcFunc['db_free_result']($request); |
3808 | 3958 | |
3809 | 3959 | $criteria[] = array('t' => 'mid', 'v' => $memID); |
3960 | + } elseif ($type == 'bud') { |
|
3961 | + $criteria[] = array('t' => 'bud', 'v' => 1); |
|
3962 | + } elseif ($type == 'gid') { |
|
3963 | + $criteria[] = array('t' => 'gid', 'v' => (int) $_POST['ruledefgroup'][$ind]); |
|
3964 | + } elseif (in_array($type, array('sub', 'msg')) && trim($_POST['ruledef'][$ind]) != '') { |
|
3965 | + $criteria[] = array('t' => $type, 'v' => $smcFunc['htmlspecialchars'](trim($_POST['ruledef'][$ind]))); |
|
3810 | 3966 | } |
3811 | - elseif ($type == 'bud') |
|
3812 | - $criteria[] = array('t' => 'bud', 'v' => 1); |
|
3813 | - elseif ($type == 'gid') |
|
3814 | - $criteria[] = array('t' => 'gid', 'v' => (int) $_POST['ruledefgroup'][$ind]); |
|
3815 | - elseif (in_array($type, array('sub', 'msg')) && trim($_POST['ruledef'][$ind]) != '') |
|
3816 | - $criteria[] = array('t' => $type, 'v' => $smcFunc['htmlspecialchars'](trim($_POST['ruledef'][$ind]))); |
|
3817 | 3967 | } |
3818 | 3968 | |
3819 | 3969 | // Also do the actions! |
@@ -3823,26 +3973,29 @@ discard block |
||
3823 | 3973 | foreach ($_POST['acttype'] as $ind => $type) |
3824 | 3974 | { |
3825 | 3975 | // Picking a valid label? |
3826 | - if ($type == 'lab' && (!isset($_POST['labdef'][$ind]) || !isset($context['labels'][$_POST['labdef'][$ind]]))) |
|
3827 | - continue; |
|
3976 | + if ($type == 'lab' && (!isset($_POST['labdef'][$ind]) || !isset($context['labels'][$_POST['labdef'][$ind]]))) { |
|
3977 | + continue; |
|
3978 | + } |
|
3828 | 3979 | |
3829 | 3980 | // Record what we're doing. |
3830 | - if ($type == 'del') |
|
3831 | - $doDelete = 1; |
|
3832 | - elseif ($type == 'lab') |
|
3833 | - $actions[] = array('t' => 'lab', 'v' => (int) $_POST['labdef'][$ind]); |
|
3981 | + if ($type == 'del') { |
|
3982 | + $doDelete = 1; |
|
3983 | + } elseif ($type == 'lab') { |
|
3984 | + $actions[] = array('t' => 'lab', 'v' => (int) $_POST['labdef'][$ind]); |
|
3985 | + } |
|
3834 | 3986 | } |
3835 | 3987 | |
3836 | - if (empty($criteria) || (empty($actions) && !$doDelete)) |
|
3837 | - fatal_lang_error('pm_rule_no_criteria', false); |
|
3988 | + if (empty($criteria) || (empty($actions) && !$doDelete)) { |
|
3989 | + fatal_lang_error('pm_rule_no_criteria', false); |
|
3990 | + } |
|
3838 | 3991 | |
3839 | 3992 | // What are we storing? |
3840 | 3993 | $criteria = json_encode($criteria); |
3841 | 3994 | $actions = json_encode($actions); |
3842 | 3995 | |
3843 | 3996 | // Create the rule? |
3844 | - if (empty($context['rid'])) |
|
3845 | - $smcFunc['db_insert']('', |
|
3997 | + if (empty($context['rid'])) { |
|
3998 | + $smcFunc['db_insert']('', |
|
3846 | 3999 | '{db_prefix}pm_rules', |
3847 | 4000 | array( |
3848 | 4001 | 'id_member' => 'int', 'rule_name' => 'string', 'criteria' => 'string', 'actions' => 'string', |
@@ -3853,8 +4006,8 @@ discard block |
||
3853 | 4006 | ), |
3854 | 4007 | array('id_rule') |
3855 | 4008 | ); |
3856 | - else |
|
3857 | - $smcFunc['db_query']('', ' |
|
4009 | + } else { |
|
4010 | + $smcFunc['db_query']('', ' |
|
3858 | 4011 | UPDATE {db_prefix}pm_rules |
3859 | 4012 | SET rule_name = {string:rule_name}, criteria = {string:criteria}, actions = {string:actions}, |
3860 | 4013 | delete_pm = {int:delete_pm}, is_or = {int:is_or} |
@@ -3870,6 +4023,7 @@ discard block |
||
3870 | 4023 | 'actions' => $actions, |
3871 | 4024 | ) |
3872 | 4025 | ); |
4026 | + } |
|
3873 | 4027 | |
3874 | 4028 | redirectexit('action=pm;sa=manrules'); |
3875 | 4029 | } |
@@ -3878,11 +4032,12 @@ discard block |
||
3878 | 4032 | { |
3879 | 4033 | checkSession(); |
3880 | 4034 | $toDelete = array(); |
3881 | - foreach ($_POST['delrule'] as $k => $v) |
|
3882 | - $toDelete[] = (int) $k; |
|
4035 | + foreach ($_POST['delrule'] as $k => $v) { |
|
4036 | + $toDelete[] = (int) $k; |
|
4037 | + } |
|
3883 | 4038 | |
3884 | - if (!empty($toDelete)) |
|
3885 | - $smcFunc['db_query']('', ' |
|
4039 | + if (!empty($toDelete)) { |
|
4040 | + $smcFunc['db_query']('', ' |
|
3886 | 4041 | DELETE FROM {db_prefix}pm_rules |
3887 | 4042 | WHERE id_rule IN ({array_int:delete_list}) |
3888 | 4043 | AND id_member = {int:current_member}', |
@@ -3891,6 +4046,7 @@ discard block |
||
3891 | 4046 | 'delete_list' => $toDelete, |
3892 | 4047 | ) |
3893 | 4048 | ); |
4049 | + } |
|
3894 | 4050 | |
3895 | 4051 | redirectexit('action=pm;sa=manrules'); |
3896 | 4052 | } |
@@ -3909,8 +4065,9 @@ discard block |
||
3909 | 4065 | loadRules(); |
3910 | 4066 | |
3911 | 4067 | // No rules? |
3912 | - if (empty($context['rules'])) |
|
3913 | - return; |
|
4068 | + if (empty($context['rules'])) { |
|
4069 | + return; |
|
4070 | + } |
|
3914 | 4071 | |
3915 | 4072 | // Just unread ones? |
3916 | 4073 | $ruleQuery = $all_messages ? '' : ' AND pmr.is_new = 1'; |
@@ -3940,8 +4097,9 @@ discard block |
||
3940 | 4097 | // Loop through all the criteria hoping to make a match. |
3941 | 4098 | foreach ($rule['criteria'] as $criterium) |
3942 | 4099 | { |
3943 | - if (($criterium['t'] == 'mid' && $criterium['v'] == $row['id_member_from']) || ($criterium['t'] == 'gid' && $criterium['v'] == $row['id_group']) || ($criterium['t'] == 'sub' && strpos($row['subject'], $criterium['v']) !== false) || ($criterium['t'] == 'msg' && strpos($row['body'], $criterium['v']) !== false)) |
|
3944 | - $match = true; |
|
4100 | + if (($criterium['t'] == 'mid' && $criterium['v'] == $row['id_member_from']) || ($criterium['t'] == 'gid' && $criterium['v'] == $row['id_group']) || ($criterium['t'] == 'sub' && strpos($row['subject'], $criterium['v']) !== false) || ($criterium['t'] == 'msg' && strpos($row['body'], $criterium['v']) !== false)) { |
|
4101 | + $match = true; |
|
4102 | + } |
|
3945 | 4103 | // If we're adding and one criteria don't match then we stop! |
3946 | 4104 | elseif ($rule['logic'] == 'and') |
3947 | 4105 | { |
@@ -3953,17 +4111,18 @@ discard block |
||
3953 | 4111 | // If we have a match the rule must be true - act! |
3954 | 4112 | if ($match) |
3955 | 4113 | { |
3956 | - if ($rule['delete']) |
|
3957 | - $actions['deletes'][] = $row['id_pm']; |
|
3958 | - else |
|
4114 | + if ($rule['delete']) { |
|
4115 | + $actions['deletes'][] = $row['id_pm']; |
|
4116 | + } else |
|
3959 | 4117 | { |
3960 | 4118 | foreach ($rule['actions'] as $ruleAction) |
3961 | 4119 | { |
3962 | 4120 | if ($ruleAction['t'] == 'lab') |
3963 | 4121 | { |
3964 | 4122 | // Get a basic pot started! |
3965 | - if (!isset($actions['labels'][$row['id_pm']])) |
|
3966 | - $actions['labels'][$row['id_pm']] = array(); |
|
4123 | + if (!isset($actions['labels'][$row['id_pm']])) { |
|
4124 | + $actions['labels'][$row['id_pm']] = array(); |
|
4125 | + } |
|
3967 | 4126 | $actions['labels'][$row['id_pm']][] = $ruleAction['v']; |
3968 | 4127 | } |
3969 | 4128 | } |
@@ -3974,8 +4133,9 @@ discard block |
||
3974 | 4133 | $smcFunc['db_free_result']($request); |
3975 | 4134 | |
3976 | 4135 | // Deletes are easy! |
3977 | - if (!empty($actions['deletes'])) |
|
3978 | - deleteMessages($actions['deletes']); |
|
4136 | + if (!empty($actions['deletes'])) { |
|
4137 | + deleteMessages($actions['deletes']); |
|
4138 | + } |
|
3979 | 4139 | |
3980 | 4140 | // Relabel? |
3981 | 4141 | if (!empty($actions['labels'])) |
@@ -4002,8 +4162,7 @@ discard block |
||
4002 | 4162 | 'current_member' => $user_info['id'], |
4003 | 4163 | ) |
4004 | 4164 | ); |
4005 | - } |
|
4006 | - else |
|
4165 | + } else |
|
4007 | 4166 | { |
4008 | 4167 | $realLabels[] = $label['id']; |
4009 | 4168 | } |
@@ -4012,8 +4171,9 @@ discard block |
||
4012 | 4171 | |
4013 | 4172 | $inserts = array(); |
4014 | 4173 | // Now we insert the label info |
4015 | - foreach ($realLabels as $a_label) |
|
4016 | - $inserts[] = array($pm, $a_label); |
|
4174 | + foreach ($realLabels as $a_label) { |
|
4175 | + $inserts[] = array($pm, $a_label); |
|
4176 | + } |
|
4017 | 4177 | |
4018 | 4178 | $smcFunc['db_insert']('ignore', |
4019 | 4179 | '{db_prefix}pm_labeled_messages', |
@@ -4034,8 +4194,9 @@ discard block |
||
4034 | 4194 | { |
4035 | 4195 | global $user_info, $context, $smcFunc; |
4036 | 4196 | |
4037 | - if (isset($context['rules']) && !$reload) |
|
4038 | - return; |
|
4197 | + if (isset($context['rules']) && !$reload) { |
|
4198 | + return; |
|
4199 | + } |
|
4039 | 4200 | |
4040 | 4201 | $request = $smcFunc['db_query']('', ' |
4041 | 4202 | SELECT |
@@ -4059,8 +4220,9 @@ discard block |
||
4059 | 4220 | 'logic' => $row['is_or'] ? 'or' : 'and', |
4060 | 4221 | ); |
4061 | 4222 | |
4062 | - if ($row['delete_pm']) |
|
4063 | - $context['rules'][$row['id_rule']]['actions'][] = array('t' => 'del', 'v' => 1); |
|
4223 | + if ($row['delete_pm']) { |
|
4224 | + $context['rules'][$row['id_rule']]['actions'][] = array('t' => 'del', 'v' => 1); |
|
4225 | + } |
|
4064 | 4226 | } |
4065 | 4227 | $smcFunc['db_free_result']($request); |
4066 | 4228 | } |