Passed
Pull Request — release-2.1 (#7287)
by Mathias
04:46
created
other/upgrade.php 1 patch
Spacing   +87 added lines, -87 removed lines patch added patch discarded remove patch
@@ -539,7 +539,7 @@  discard block
 block discarded – undo
539 539
 		$to = explode('/', $lang_dir);
540 540
 		$relPath = $to;
541 541
 
542
-		foreach($from as $depth => $dir)
542
+		foreach ($from as $depth => $dir)
543 543
 		{
544 544
 			if ($dir === $to[$depth])
545 545
 				array_shift($relPath);
@@ -3043,94 +3043,94 @@  discard block
 block discarded – undo
3043 3043
 		// Translation table for the character sets not native for MySQL.
3044 3044
 		$translation_tables = array(
3045 3045
 			'windows-1255' => array(
3046
-				'0x81' => '\'\'',		'0x8A' => '\'\'',		'0x8C' => '\'\'',
3047
-				'0x8D' => '\'\'',		'0x8E' => '\'\'',		'0x8F' => '\'\'',
3048
-				'0x90' => '\'\'',		'0x9A' => '\'\'',		'0x9C' => '\'\'',
3049
-				'0x9D' => '\'\'',		'0x9E' => '\'\'',		'0x9F' => '\'\'',
3050
-				'0xCA' => '\'\'',		'0xD9' => '\'\'',		'0xDA' => '\'\'',
3051
-				'0xDB' => '\'\'',		'0xDC' => '\'\'',		'0xDD' => '\'\'',
3052
-				'0xDE' => '\'\'',		'0xDF' => '\'\'',		'0xFB' => '0xD792',
3053
-				'0xFC' => '0xE282AC',		'0xFF' => '0xD6B2',		'0xC2' => '0xFF',
3054
-				'0x80' => '0xFC',		'0xE2' => '0xFB',		'0xA0' => '0xC2A0',
3055
-				'0xA1' => '0xC2A1',		'0xA2' => '0xC2A2',		'0xA3' => '0xC2A3',
3056
-				'0xA5' => '0xC2A5',		'0xA6' => '0xC2A6',		'0xA7' => '0xC2A7',
3057
-				'0xA8' => '0xC2A8',		'0xA9' => '0xC2A9',		'0xAB' => '0xC2AB',
3058
-				'0xAC' => '0xC2AC',		'0xAD' => '0xC2AD',		'0xAE' => '0xC2AE',
3059
-				'0xAF' => '0xC2AF',		'0xB0' => '0xC2B0',		'0xB1' => '0xC2B1',
3060
-				'0xB2' => '0xC2B2',		'0xB3' => '0xC2B3',		'0xB4' => '0xC2B4',
3061
-				'0xB5' => '0xC2B5',		'0xB6' => '0xC2B6',		'0xB7' => '0xC2B7',
3062
-				'0xB8' => '0xC2B8',		'0xB9' => '0xC2B9',		'0xBB' => '0xC2BB',
3063
-				'0xBC' => '0xC2BC',		'0xBD' => '0xC2BD',		'0xBE' => '0xC2BE',
3064
-				'0xBF' => '0xC2BF',		'0xD7' => '0xD7B3',		'0xD1' => '0xD781',
3065
-				'0xD4' => '0xD7B0',		'0xD5' => '0xD7B1',		'0xD6' => '0xD7B2',
3066
-				'0xE0' => '0xD790',		'0xEA' => '0xD79A',		'0xEC' => '0xD79C',
3067
-				'0xED' => '0xD79D',		'0xEE' => '0xD79E',		'0xEF' => '0xD79F',
3068
-				'0xF0' => '0xD7A0',		'0xF1' => '0xD7A1',		'0xF2' => '0xD7A2',
3069
-				'0xF3' => '0xD7A3',		'0xF5' => '0xD7A5',		'0xF6' => '0xD7A6',
3070
-				'0xF7' => '0xD7A7',		'0xF8' => '0xD7A8',		'0xF9' => '0xD7A9',
3071
-				'0x82' => '0xE2809A',	'0x84' => '0xE2809E',	'0x85' => '0xE280A6',
3072
-				'0x86' => '0xE280A0',	'0x87' => '0xE280A1',	'0x89' => '0xE280B0',
3073
-				'0x8B' => '0xE280B9',	'0x93' => '0xE2809C',	'0x94' => '0xE2809D',
3074
-				'0x95' => '0xE280A2',	'0x97' => '0xE28094',	'0x99' => '0xE284A2',
3075
-				'0xC0' => '0xD6B0',		'0xC1' => '0xD6B1',		'0xC3' => '0xD6B3',
3076
-				'0xC4' => '0xD6B4',		'0xC5' => '0xD6B5',		'0xC6' => '0xD6B6',
3077
-				'0xC7' => '0xD6B7',		'0xC8' => '0xD6B8',		'0xC9' => '0xD6B9',
3078
-				'0xCB' => '0xD6BB',		'0xCC' => '0xD6BC',		'0xCD' => '0xD6BD',
3079
-				'0xCE' => '0xD6BE',		'0xCF' => '0xD6BF',		'0xD0' => '0xD780',
3080
-				'0xD2' => '0xD782',		'0xE3' => '0xD793',		'0xE4' => '0xD794',
3081
-				'0xE5' => '0xD795',		'0xE7' => '0xD797',		'0xE9' => '0xD799',
3082
-				'0xFD' => '0xE2808E',	'0xFE' => '0xE2808F',	'0x92' => '0xE28099',
3083
-				'0x83' => '0xC692',		'0xD3' => '0xD783',		'0x88' => '0xCB86',
3084
-				'0x98' => '0xCB9C',		'0x91' => '0xE28098',	'0x96' => '0xE28093',
3085
-				'0xBA' => '0xC3B7',		'0x9B' => '0xE280BA',	'0xAA' => '0xC397',
3086
-				'0xA4' => '0xE282AA',	'0xE1' => '0xD791',		'0xE6' => '0xD796',
3087
-				'0xE8' => '0xD798',		'0xEB' => '0xD79B',		'0xF4' => '0xD7A4',
3046
+				'0x81' => '\'\'', '0x8A' => '\'\'', '0x8C' => '\'\'',
3047
+				'0x8D' => '\'\'', '0x8E' => '\'\'', '0x8F' => '\'\'',
3048
+				'0x90' => '\'\'', '0x9A' => '\'\'', '0x9C' => '\'\'',
3049
+				'0x9D' => '\'\'', '0x9E' => '\'\'', '0x9F' => '\'\'',
3050
+				'0xCA' => '\'\'', '0xD9' => '\'\'', '0xDA' => '\'\'',
3051
+				'0xDB' => '\'\'', '0xDC' => '\'\'', '0xDD' => '\'\'',
3052
+				'0xDE' => '\'\'', '0xDF' => '\'\'', '0xFB' => '0xD792',
3053
+				'0xFC' => '0xE282AC', '0xFF' => '0xD6B2', '0xC2' => '0xFF',
3054
+				'0x80' => '0xFC', '0xE2' => '0xFB', '0xA0' => '0xC2A0',
3055
+				'0xA1' => '0xC2A1', '0xA2' => '0xC2A2', '0xA3' => '0xC2A3',
3056
+				'0xA5' => '0xC2A5', '0xA6' => '0xC2A6', '0xA7' => '0xC2A7',
3057
+				'0xA8' => '0xC2A8', '0xA9' => '0xC2A9', '0xAB' => '0xC2AB',
3058
+				'0xAC' => '0xC2AC', '0xAD' => '0xC2AD', '0xAE' => '0xC2AE',
3059
+				'0xAF' => '0xC2AF', '0xB0' => '0xC2B0', '0xB1' => '0xC2B1',
3060
+				'0xB2' => '0xC2B2', '0xB3' => '0xC2B3', '0xB4' => '0xC2B4',
3061
+				'0xB5' => '0xC2B5', '0xB6' => '0xC2B6', '0xB7' => '0xC2B7',
3062
+				'0xB8' => '0xC2B8', '0xB9' => '0xC2B9', '0xBB' => '0xC2BB',
3063
+				'0xBC' => '0xC2BC', '0xBD' => '0xC2BD', '0xBE' => '0xC2BE',
3064
+				'0xBF' => '0xC2BF', '0xD7' => '0xD7B3', '0xD1' => '0xD781',
3065
+				'0xD4' => '0xD7B0', '0xD5' => '0xD7B1', '0xD6' => '0xD7B2',
3066
+				'0xE0' => '0xD790', '0xEA' => '0xD79A', '0xEC' => '0xD79C',
3067
+				'0xED' => '0xD79D', '0xEE' => '0xD79E', '0xEF' => '0xD79F',
3068
+				'0xF0' => '0xD7A0', '0xF1' => '0xD7A1', '0xF2' => '0xD7A2',
3069
+				'0xF3' => '0xD7A3', '0xF5' => '0xD7A5', '0xF6' => '0xD7A6',
3070
+				'0xF7' => '0xD7A7', '0xF8' => '0xD7A8', '0xF9' => '0xD7A9',
3071
+				'0x82' => '0xE2809A', '0x84' => '0xE2809E', '0x85' => '0xE280A6',
3072
+				'0x86' => '0xE280A0', '0x87' => '0xE280A1', '0x89' => '0xE280B0',
3073
+				'0x8B' => '0xE280B9', '0x93' => '0xE2809C', '0x94' => '0xE2809D',
3074
+				'0x95' => '0xE280A2', '0x97' => '0xE28094', '0x99' => '0xE284A2',
3075
+				'0xC0' => '0xD6B0', '0xC1' => '0xD6B1', '0xC3' => '0xD6B3',
3076
+				'0xC4' => '0xD6B4', '0xC5' => '0xD6B5', '0xC6' => '0xD6B6',
3077
+				'0xC7' => '0xD6B7', '0xC8' => '0xD6B8', '0xC9' => '0xD6B9',
3078
+				'0xCB' => '0xD6BB', '0xCC' => '0xD6BC', '0xCD' => '0xD6BD',
3079
+				'0xCE' => '0xD6BE', '0xCF' => '0xD6BF', '0xD0' => '0xD780',
3080
+				'0xD2' => '0xD782', '0xE3' => '0xD793', '0xE4' => '0xD794',
3081
+				'0xE5' => '0xD795', '0xE7' => '0xD797', '0xE9' => '0xD799',
3082
+				'0xFD' => '0xE2808E', '0xFE' => '0xE2808F', '0x92' => '0xE28099',
3083
+				'0x83' => '0xC692', '0xD3' => '0xD783', '0x88' => '0xCB86',
3084
+				'0x98' => '0xCB9C', '0x91' => '0xE28098', '0x96' => '0xE28093',
3085
+				'0xBA' => '0xC3B7', '0x9B' => '0xE280BA', '0xAA' => '0xC397',
3086
+				'0xA4' => '0xE282AA', '0xE1' => '0xD791', '0xE6' => '0xD796',
3087
+				'0xE8' => '0xD798', '0xEB' => '0xD79B', '0xF4' => '0xD7A4',
3088 3088
 				'0xFA' => '0xD7AA',
3089 3089
 			),
3090 3090
 			'windows-1253' => array(
3091
-				'0x81' => '\'\'',			'0x88' => '\'\'',			'0x8A' => '\'\'',
3092
-				'0x8C' => '\'\'',			'0x8D' => '\'\'',			'0x8E' => '\'\'',
3093
-				'0x8F' => '\'\'',			'0x90' => '\'\'',			'0x98' => '\'\'',
3094
-				'0x9A' => '\'\'',			'0x9C' => '\'\'',			'0x9D' => '\'\'',
3095
-				'0x9E' => '\'\'',			'0x9F' => '\'\'',			'0xAA' => '\'\'',
3096
-				'0xD2' => '0xE282AC',			'0xFF' => '0xCE92',			'0xCE' => '0xCE9E',
3097
-				'0xB8' => '0xCE88',		'0xBA' => '0xCE8A',		'0xBC' => '0xCE8C',
3098
-				'0xBE' => '0xCE8E',		'0xBF' => '0xCE8F',		'0xC0' => '0xCE90',
3099
-				'0xC8' => '0xCE98',		'0xCA' => '0xCE9A',		'0xCC' => '0xCE9C',
3100
-				'0xCD' => '0xCE9D',		'0xCF' => '0xCE9F',		'0xDA' => '0xCEAA',
3101
-				'0xE8' => '0xCEB8',		'0xEA' => '0xCEBA',		'0xEC' => '0xCEBC',
3102
-				'0xEE' => '0xCEBE',		'0xEF' => '0xCEBF',		'0xC2' => '0xFF',
3103
-				'0xBD' => '0xC2BD',		'0xED' => '0xCEBD',		'0xB2' => '0xC2B2',
3104
-				'0xA0' => '0xC2A0',		'0xA3' => '0xC2A3',		'0xA4' => '0xC2A4',
3105
-				'0xA5' => '0xC2A5',		'0xA6' => '0xC2A6',		'0xA7' => '0xC2A7',
3106
-				'0xA8' => '0xC2A8',		'0xA9' => '0xC2A9',		'0xAB' => '0xC2AB',
3107
-				'0xAC' => '0xC2AC',		'0xAD' => '0xC2AD',		'0xAE' => '0xC2AE',
3108
-				'0xB0' => '0xC2B0',		'0xB1' => '0xC2B1',		'0xB3' => '0xC2B3',
3109
-				'0xB5' => '0xC2B5',		'0xB6' => '0xC2B6',		'0xB7' => '0xC2B7',
3110
-				'0xBB' => '0xC2BB',		'0xE2' => '0xCEB2',		'0x80' => '0xD2',
3111
-				'0x82' => '0xE2809A',	'0x84' => '0xE2809E',	'0x85' => '0xE280A6',
3112
-				'0x86' => '0xE280A0',	'0xA1' => '0xCE85',		'0xA2' => '0xCE86',
3113
-				'0x87' => '0xE280A1',	'0x89' => '0xE280B0',	'0xB9' => '0xCE89',
3114
-				'0x8B' => '0xE280B9',	'0x91' => '0xE28098',	'0x99' => '0xE284A2',
3115
-				'0x92' => '0xE28099',	'0x93' => '0xE2809C',	'0x94' => '0xE2809D',
3116
-				'0x95' => '0xE280A2',	'0x96' => '0xE28093',	'0x97' => '0xE28094',
3117
-				'0x9B' => '0xE280BA',	'0xAF' => '0xE28095',	'0xB4' => '0xCE84',
3118
-				'0xC1' => '0xCE91',		'0xC3' => '0xCE93',		'0xC4' => '0xCE94',
3119
-				'0xC5' => '0xCE95',		'0xC6' => '0xCE96',		'0x83' => '0xC692',
3120
-				'0xC7' => '0xCE97',		'0xC9' => '0xCE99',		'0xCB' => '0xCE9B',
3121
-				'0xD0' => '0xCEA0',		'0xD1' => '0xCEA1',		'0xD3' => '0xCEA3',
3122
-				'0xD4' => '0xCEA4',		'0xD5' => '0xCEA5',		'0xD6' => '0xCEA6',
3123
-				'0xD7' => '0xCEA7',		'0xD8' => '0xCEA8',		'0xD9' => '0xCEA9',
3124
-				'0xDB' => '0xCEAB',		'0xDC' => '0xCEAC',		'0xDD' => '0xCEAD',
3125
-				'0xDE' => '0xCEAE',		'0xDF' => '0xCEAF',		'0xE0' => '0xCEB0',
3126
-				'0xE1' => '0xCEB1',		'0xE3' => '0xCEB3',		'0xE4' => '0xCEB4',
3127
-				'0xE5' => '0xCEB5',		'0xE6' => '0xCEB6',		'0xE7' => '0xCEB7',
3128
-				'0xE9' => '0xCEB9',		'0xEB' => '0xCEBB',		'0xF0' => '0xCF80',
3129
-				'0xF1' => '0xCF81',		'0xF2' => '0xCF82',		'0xF3' => '0xCF83',
3130
-				'0xF4' => '0xCF84',		'0xF5' => '0xCF85',		'0xF6' => '0xCF86',
3131
-				'0xF7' => '0xCF87',		'0xF8' => '0xCF88',		'0xF9' => '0xCF89',
3132
-				'0xFA' => '0xCF8A',		'0xFB' => '0xCF8B',		'0xFC' => '0xCF8C',
3133
-				'0xFD' => '0xCF8D',		'0xFE' => '0xCF8E',
3091
+				'0x81' => '\'\'', '0x88' => '\'\'', '0x8A' => '\'\'',
3092
+				'0x8C' => '\'\'', '0x8D' => '\'\'', '0x8E' => '\'\'',
3093
+				'0x8F' => '\'\'', '0x90' => '\'\'', '0x98' => '\'\'',
3094
+				'0x9A' => '\'\'', '0x9C' => '\'\'', '0x9D' => '\'\'',
3095
+				'0x9E' => '\'\'', '0x9F' => '\'\'', '0xAA' => '\'\'',
3096
+				'0xD2' => '0xE282AC', '0xFF' => '0xCE92', '0xCE' => '0xCE9E',
3097
+				'0xB8' => '0xCE88', '0xBA' => '0xCE8A', '0xBC' => '0xCE8C',
3098
+				'0xBE' => '0xCE8E', '0xBF' => '0xCE8F', '0xC0' => '0xCE90',
3099
+				'0xC8' => '0xCE98', '0xCA' => '0xCE9A', '0xCC' => '0xCE9C',
3100
+				'0xCD' => '0xCE9D', '0xCF' => '0xCE9F', '0xDA' => '0xCEAA',
3101
+				'0xE8' => '0xCEB8', '0xEA' => '0xCEBA', '0xEC' => '0xCEBC',
3102
+				'0xEE' => '0xCEBE', '0xEF' => '0xCEBF', '0xC2' => '0xFF',
3103
+				'0xBD' => '0xC2BD', '0xED' => '0xCEBD', '0xB2' => '0xC2B2',
3104
+				'0xA0' => '0xC2A0', '0xA3' => '0xC2A3', '0xA4' => '0xC2A4',
3105
+				'0xA5' => '0xC2A5', '0xA6' => '0xC2A6', '0xA7' => '0xC2A7',
3106
+				'0xA8' => '0xC2A8', '0xA9' => '0xC2A9', '0xAB' => '0xC2AB',
3107
+				'0xAC' => '0xC2AC', '0xAD' => '0xC2AD', '0xAE' => '0xC2AE',
3108
+				'0xB0' => '0xC2B0', '0xB1' => '0xC2B1', '0xB3' => '0xC2B3',
3109
+				'0xB5' => '0xC2B5', '0xB6' => '0xC2B6', '0xB7' => '0xC2B7',
3110
+				'0xBB' => '0xC2BB', '0xE2' => '0xCEB2', '0x80' => '0xD2',
3111
+				'0x82' => '0xE2809A', '0x84' => '0xE2809E', '0x85' => '0xE280A6',
3112
+				'0x86' => '0xE280A0', '0xA1' => '0xCE85', '0xA2' => '0xCE86',
3113
+				'0x87' => '0xE280A1', '0x89' => '0xE280B0', '0xB9' => '0xCE89',
3114
+				'0x8B' => '0xE280B9', '0x91' => '0xE28098', '0x99' => '0xE284A2',
3115
+				'0x92' => '0xE28099', '0x93' => '0xE2809C', '0x94' => '0xE2809D',
3116
+				'0x95' => '0xE280A2', '0x96' => '0xE28093', '0x97' => '0xE28094',
3117
+				'0x9B' => '0xE280BA', '0xAF' => '0xE28095', '0xB4' => '0xCE84',
3118
+				'0xC1' => '0xCE91', '0xC3' => '0xCE93', '0xC4' => '0xCE94',
3119
+				'0xC5' => '0xCE95', '0xC6' => '0xCE96', '0x83' => '0xC692',
3120
+				'0xC7' => '0xCE97', '0xC9' => '0xCE99', '0xCB' => '0xCE9B',
3121
+				'0xD0' => '0xCEA0', '0xD1' => '0xCEA1', '0xD3' => '0xCEA3',
3122
+				'0xD4' => '0xCEA4', '0xD5' => '0xCEA5', '0xD6' => '0xCEA6',
3123
+				'0xD7' => '0xCEA7', '0xD8' => '0xCEA8', '0xD9' => '0xCEA9',
3124
+				'0xDB' => '0xCEAB', '0xDC' => '0xCEAC', '0xDD' => '0xCEAD',
3125
+				'0xDE' => '0xCEAE', '0xDF' => '0xCEAF', '0xE0' => '0xCEB0',
3126
+				'0xE1' => '0xCEB1', '0xE3' => '0xCEB3', '0xE4' => '0xCEB4',
3127
+				'0xE5' => '0xCEB5', '0xE6' => '0xCEB6', '0xE7' => '0xCEB7',
3128
+				'0xE9' => '0xCEB9', '0xEB' => '0xCEBB', '0xF0' => '0xCF80',
3129
+				'0xF1' => '0xCF81', '0xF2' => '0xCF82', '0xF3' => '0xCF83',
3130
+				'0xF4' => '0xCF84', '0xF5' => '0xCF85', '0xF6' => '0xCF86',
3131
+				'0xF7' => '0xCF87', '0xF8' => '0xCF88', '0xF9' => '0xCF89',
3132
+				'0xFA' => '0xCF8A', '0xFB' => '0xCF8B', '0xFC' => '0xCF8C',
3133
+				'0xFD' => '0xCF8D', '0xFE' => '0xCF8E',
3134 3134
 			),
3135 3135
 		);
3136 3136
 
@@ -3390,7 +3390,7 @@  discard block
 block discarded – undo
3390 3390
 			// This bit fixes incorrect string lengths, which can happen if the character encoding was changed (e.g. conversion to UTF-8)
3391 3391
 			$new_string = preg_replace_callback(
3392 3392
 				'~\bs:(\d+):"(.*?)";(?=$|[bidsaO]:|[{}}]|N;)~s',
3393
-				function ($matches)
3393
+				function($matches)
3394 3394
 				{
3395 3395
 					return 's:' . strlen($matches[2]) . ':"' . $matches[2] . '";';
3396 3396
 				},
Please login to merge, or discard this patch.
Sources/Subs-Compat.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -222,7 +222,7 @@
 block discarded – undo
222 222
 			if (!function_exists('mb_encode_numericentity'))
223 223
 				return false;
224 224
 
225
-			$entity = mb_encode_numericentity($string, array(0x0,0x10FFFF,0x0,0xFFFFFF), $encoding);
225
+			$entity = mb_encode_numericentity($string, array(0x0, 0x10FFFF, 0x0, 0xFFFFFF), $encoding);
226 226
 
227 227
 			if (strpos($entity, '&#') !== 0)
228 228
 				return false;
Please login to merge, or discard this patch.
Sources/Register.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -315,7 +315,7 @@
 block discarded – undo
315 315
 
316 316
 	array_walk_recursive(
317 317
 		$_POST,
318
-		function (&$value, $key) use ($context, $smcFunc)
318
+		function(&$value, $key) use ($context, $smcFunc)
319 319
 		{
320 320
 			// Normalize Unicode characters. (Does nothing if not in UTF-8 mode.)
321 321
 			$value = $smcFunc['normalize']($value);
Please login to merge, or discard this patch.
Sources/ManageMaintenance.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -2060,7 +2060,7 @@
 block discarded – undo
2060 2060
 		new RecursiveIteratorIterator(
2061 2061
 			new RecursiveCallbackFilterIterator(
2062 2062
 				new RecursiveDirectoryIterator($dirname, FilesystemIterator::UNIX_PATHS),
2063
-				function ($fileInfo, $currentFile, $iterator)
2063
+				function($fileInfo, $currentFile, $iterator)
2064 2064
 				{
2065 2065
 					// Allow recursion
2066 2066
 					if ($iterator->hasChildren())
Please login to merge, or discard this patch.
Sources/Subs-Charset.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -249,7 +249,7 @@  discard block
 block discarded – undo
249 249
 	$combining_classes = utf8_combining_classes();
250 250
 
251 251
 	// Replace characters with decomposed forms.
252
-	for ($i=0; $i < count($chars); $i++)
252
+	for ($i = 0; $i < count($chars); $i++)
253 253
 	{
254 254
 		// Hangul characters.
255 255
 		if ($chars[$i] >= "\xEA\xB0\x80" && $chars[$i] <= "\xED\x9E\xA3")
@@ -283,7 +283,7 @@  discard block
 block discarded – undo
283 283
 		{
284 284
 			$temp = $chars[$i];
285 285
 			$chars[$i] = $chars[$i - 1];
286
-			$chars[$i -1] = $temp;
286
+			$chars[$i - 1] = $temp;
287 287
 
288 288
 			// Backtrack and check again.
289 289
 			if ($i > 1)
@@ -527,7 +527,7 @@  discard block
 block discarded – undo
527 527
 
528 528
 	// Use placeholders to preserve known emoji from further processing.
529 529
 	// Regex source is https://unicode.org/reports/tr51/#EBNF_and_Regex
530
-	$string  = preg_replace_callback(
530
+	$string = preg_replace_callback(
531 531
 		'/' .
532 532
 		// Flag emojis
533 533
 		'[' . $prop_classes['Regional_Indicator'] . ']{2}' .
@@ -556,7 +556,7 @@  discard block
 block discarded – undo
556 556
 			')?' .
557 557
 		')*' .
558 558
 		'/u',
559
-		function ($matches) use (&$placeholders)
559
+		function($matches) use (&$placeholders)
560 560
 		{
561 561
 			// Skip lone ASCII characters that are not actully part of an emoji sequence.
562 562
 			// This can happen because the digits 0-9 and the '*' and '#' characters are
@@ -587,7 +587,7 @@  discard block
 block discarded – undo
587 587
 		// Use placeholders for sanctioned variation selectors.
588 588
 		$string = preg_replace_callback(
589 589
 			$patterns,
590
-			function ($matches) use (&$placeholders)
590
+			function($matches) use (&$placeholders)
591 591
 			{
592 592
 				$placeholders[$matches[0]] = "\xEE\xB3\x9B" . md5($matches[0]) . "\xEE\xB3\x9C";
593 593
 				return $placeholders[$matches[0]];
@@ -667,7 +667,7 @@  discard block
 block discarded – undo
667 667
 			// Do the thing.
668 668
 			$string = preg_replace_callback(
669 669
 				'/' . $pattern . '/u',
670
-				function ($matches) use ($placeholders)
670
+				function($matches) use ($placeholders)
671 671
 				{
672 672
 					return strtr($matches[0], $placeholders);
673 673
 				},
Please login to merge, or discard this patch.
other/update_unicode_data.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -752,7 +752,7 @@  discard block
 block discarded – undo
752 752
 	}
753 753
 }
754 754
 // This sort works decently well to ensure widely used scripts are ranked before rare scripts.
755
-uasort($funcs['utf8_regex_joining_type']['data'], function ($a, $b)
755
+uasort($funcs['utf8_regex_joining_type']['data'], function($a, $b)
756 756
 {
757 757
 	if ($a['stats']['age'] == $b['stats']['age'])
758 758
 	{
@@ -828,7 +828,7 @@  discard block
 block discarded – undo
828 828
 	}
829 829
 }
830 830
 // Again, sort commonly used scripts before rare scripts.
831
-uasort($funcs['utf8_regex_indic']['data'], function ($a, $b)
831
+uasort($funcs['utf8_regex_indic']['data'], function($a, $b)
832 832
 {
833 833
 	if ($a['stats']['age'] == $b['stats']['age'])
834 834
 	{
Please login to merge, or discard this patch.
Sources/Cache/APIs/Sqlite.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -131,14 +131,14 @@  discard block
 block discarded – undo
131 131
 		$class_name = $this->getImplementationClassKeyName();
132 132
 		$class_name_txt_key = strtolower($class_name);
133 133
 
134
-		$config_vars[] = $txt['cache_'. $class_name_txt_key .'_settings'];
134
+		$config_vars[] = $txt['cache_' . $class_name_txt_key . '_settings'];
135 135
 		$config_vars[] = array(
136
-			'cachedir_'. $class_name_txt_key,
137
-			$txt['cachedir_'. $class_name_txt_key],
136
+			'cachedir_' . $class_name_txt_key,
137
+			$txt['cachedir_' . $class_name_txt_key],
138 138
 			'file',
139 139
 			'text',
140 140
 			36,
141
-			'cache_'. $class_name_txt_key .'_cachedir',
141
+			'cache_' . $class_name_txt_key . '_cachedir',
142 142
 		);
143 143
 
144 144
 		if (!isset($context['settings_post_javascript']))
@@ -147,7 +147,7 @@  discard block
 block discarded – undo
147 147
 		$context['settings_post_javascript'] .= '
148 148
 			$("#cache_accelerator").change(function (e) {
149 149
 				var cache_type = e.currentTarget.value;
150
-				$("#cachedir_'. $class_name_txt_key .'").prop("disabled", cache_type != "'. $class_name .'");
150
+				$("#cachedir_'. $class_name_txt_key . '").prop("disabled", cache_type != "' . $class_name . '");
151 151
 			});';
152 152
 	}
153 153
 
Please login to merge, or discard this patch.
Sources/Subs.php 1 patch
Spacing   +40 added lines, -40 removed lines patch added patch discarded remove patch
@@ -378,7 +378,7 @@  discard block
 block discarded – undo
378 378
 			{
379 379
 				$val = 'CASE ';
380 380
 				foreach ($members as $k => $v)
381
-					$val .= 'WHEN id_member = ' . $v . ' THEN '. alert_count($v, true) . ' ';
381
+					$val .= 'WHEN id_member = ' . $v . ' THEN ' . alert_count($v, true) . ' ';
382 382
 
383 383
 				$val = $val . ' END';
384 384
 				$type = 'raw';
@@ -868,11 +868,11 @@  discard block
 block discarded – undo
868 868
 			// Anything that isn't a specification, punctuation mark, or whitespace.
869 869
 			'~(?<!%)\p{L}|[^\p{L}\p{P}\s]~u',
870 870
 			// A series of punctuation marks (except %), possibly separated by whitespace.
871
-			'~([^%\P{P}])(\s*)(?'.'>(\1|[^%\P{Po}])\s*(?!$))*~u',
871
+			'~([^%\P{P}])(\s*)(?' . '>(\1|[^%\P{Po}])\s*(?!$))*~u',
872 872
 			// Unwanted trailing punctuation and whitespace.
873
-			'~(?'.'>([\p{Pd}\p{Ps}\p{Pi}\p{Pc}]|[^%\P{Po}])\s*)*$~u',
873
+			'~(?' . '>([\p{Pd}\p{Ps}\p{Pi}\p{Pc}]|[^%\P{Po}])\s*)*$~u',
874 874
 			// Unwanted opening punctuation and whitespace.
875
-			'~^\s*(?'.'>([\p{Pd}\p{Pe}\p{Pf}\p{Pc}]|[^%\P{Po}])\s*)*~u',
875
+			'~^\s*(?' . '>([\p{Pd}\p{Pe}\p{Pf}\p{Pc}]|[^%\P{Po}])\s*)*~u',
876 876
 		),
877 877
 		array(
878 878
 			'',
@@ -1175,7 +1175,7 @@  discard block
 block discarded – undo
1175 1175
 	{
1176 1176
 		$dates[$tzid . '_' . $timestamp]['results'][$format] = preg_replace_callback(
1177 1177
 			'/\xEE\x84\xA0([\d_]+)(\xEE\x84(?:[\xA1-\xAF]))/',
1178
-			function ($matches)
1178
+			function($matches)
1179 1179
 			{
1180 1180
 				switch ($matches[2])
1181 1181
 				{
@@ -1309,7 +1309,7 @@  discard block
 block discarded – undo
1309 1309
 	elseif (!empty($context['character_set']) && is_callable('mb_decode_numericentity'))
1310 1310
 	{
1311 1311
 		// Get whatever the default replacement character is for this encoding.
1312
-		$substitute = mb_decode_numericentity('&#xFFFD;', array(0xFFFD,0xFFFD,0,0xFFFF), $context['character_set']);
1312
+		$substitute = mb_decode_numericentity('&#xFFFD;', array(0xFFFD, 0xFFFD, 0, 0xFFFF), $context['character_set']);
1313 1313
 	}
1314 1314
 	else
1315 1315
 		$substitute = '?';
@@ -1794,7 +1794,7 @@  discard block
 block discarded – undo
1794 1794
 								$returnContext .= '<img src="' . $currentAttachment['href'] . '"' . $alt . $title . ' class="bbc_img">';
1795 1795
 							else
1796 1796
 							{
1797
-								$width = !empty($params['{width}']) ? ' width="' . $params['{width}'] . '"': '';
1797
+								$width = !empty($params['{width}']) ? ' width="' . $params['{width}'] . '"' : '';
1798 1798
 								$height = !empty($params['{height}']) ? 'height="' . $params['{height}'] . '"' : '';
1799 1799
 								$returnContext .= '<img src="' . $currentAttachment['href'] . ';image"' . $alt . $title . $width . $height . ' class="bbc_img resized"/>';
1800 1800
 							}
@@ -1805,7 +1805,7 @@  discard block
 block discarded – undo
1805 1805
 							$width = !empty($params['{width}']) ? ' width="' . $params['{width}'] . '"' : '';
1806 1806
 							$height = !empty($params['{height}']) ? ' height="' . $params['{height}'] . '"' : '';
1807 1807
 
1808
-							$returnContext .= '<div class="videocontainer"><video controls preload="metadata" src="'. $currentAttachment['href'] . '" playsinline' . $width . $height . '><a href="' . $currentAttachment['href'] . '" class="bbc_link">' . $smcFunc['htmlspecialchars'](!empty($data) ? $data : $currentAttachment['name']) . '</a></video></div>' . (!empty($data) && $data != $currentAttachment['name'] ? '<div class="smalltext">' . $data . '</div>' : '');
1808
+							$returnContext .= '<div class="videocontainer"><video controls preload="metadata" src="' . $currentAttachment['href'] . '" playsinline' . $width . $height . '><a href="' . $currentAttachment['href'] . '" class="bbc_link">' . $smcFunc['htmlspecialchars'](!empty($data) ? $data : $currentAttachment['name']) . '</a></video></div>' . (!empty($data) && $data != $currentAttachment['name'] ? '<div class="smalltext">' . $data . '</div>' : '');
1809 1809
 						}
1810 1810
 						// Audio.
1811 1811
 						elseif (strpos($currentAttachment['mime_type'], 'audio/') === 0)
@@ -1813,7 +1813,7 @@  discard block
 block discarded – undo
1813 1813
 							$width = 'max-width:100%; width: ' . (!empty($params['{width}']) ? $params['{width}'] : '400') . 'px;';
1814 1814
 							$height = !empty($params['{height}']) ? 'height: ' . $params['{height}'] . 'px;' : '';
1815 1815
 
1816
-							$returnContext .= (!empty($data) && $data != $currentAttachment['name'] ? $data . ' ' : '') . '<audio controls preload="none" src="'. $currentAttachment['href'] . '" class="bbc_audio" style="vertical-align:middle;' . $width . $height . '"><a href="' . $currentAttachment['href'] . '" class="bbc_link">' . $smcFunc['htmlspecialchars'](!empty($data) ? $data : $currentAttachment['name']) . '</a></audio>';
1816
+							$returnContext .= (!empty($data) && $data != $currentAttachment['name'] ? $data . ' ' : '') . '<audio controls preload="none" src="' . $currentAttachment['href'] . '" class="bbc_audio" style="vertical-align:middle;' . $width . $height . '"><a href="' . $currentAttachment['href'] . '" class="bbc_link">' . $smcFunc['htmlspecialchars'](!empty($data) ? $data : $currentAttachment['name']) . '</a></audio>';
1817 1817
 						}
1818 1818
 						// Anything else.
1819 1819
 						else
@@ -1982,7 +1982,7 @@  discard block
 block discarded – undo
1982 1982
 				'type' => 'unparsed_commas_content',
1983 1983
 				'test' => '\d+,\d+\]',
1984 1984
 				'content' => '<a href="$1" target="_blank" rel="noopener">$1</a>',
1985
-				'validate' => function (&$tag, &$data, $disabled)
1985
+				'validate' => function(&$tag, &$data, $disabled)
1986 1986
 				{
1987 1987
 					$data[0] = normalize_iri($data[0]);
1988 1988
 
@@ -2108,8 +2108,8 @@  discard block
 block discarded – undo
2108 2108
 					else
2109 2109
 						$url = get_proxied_url($url);
2110 2110
 
2111
-					$alt = !empty($params['{alt}']) ? ' alt="' . $params['{alt}']. '"' : ' alt=""';
2112
-					$title = !empty($params['{title}']) ? ' title="' . $params['{title}']. '"' : '';
2111
+					$alt = !empty($params['{alt}']) ? ' alt="' . $params['{alt}'] . '"' : ' alt=""';
2112
+					$title = !empty($params['{title}']) ? ' title="' . $params['{title}'] . '"' : '';
2113 2113
 
2114 2114
 					$data = isset($disabled[$tag['tag']]) ? $url : '<img src="' . $url . '"' . $alt . $title . $params['{width}'] . $params['{height}'] . ' class="bbc_img' . (!empty($params['{width}']) || !empty($params['{height}']) ? ' resized' : '') . '" loading="lazy">';
2115 2115
 				},
@@ -2540,12 +2540,12 @@  discard block
 block discarded – undo
2540 2540
 		$codes[] = array(
2541 2541
 			'tag' => 'cowsay',
2542 2542
 			'parameters' => array(
2543
-				'e' => array('optional' => true, 'quoted' => true, 'match' => '(.*?)', 'default' => 'oo', 'validate' => function ($eyes) use ($smcFunc)
2543
+				'e' => array('optional' => true, 'quoted' => true, 'match' => '(.*?)', 'default' => 'oo', 'validate' => function($eyes) use ($smcFunc)
2544 2544
 					{
2545 2545
 						return $smcFunc['substr']($eyes . 'oo', 0, 2);
2546 2546
 					},
2547 2547
 				),
2548
-				't' => array('optional' => true, 'quoted' => true, 'match' => '(.*?)', 'default' => '  ', 'validate' => function ($tongue) use ($smcFunc)
2548
+				't' => array('optional' => true, 'quoted' => true, 'match' => '(.*?)', 'default' => '  ', 'validate' => function($tongue) use ($smcFunc)
2549 2549
 					{
2550 2550
 						return $smcFunc['substr']($tongue . '  ', 0, 2);
2551 2551
 					},
@@ -4250,7 +4250,7 @@  discard block
 block discarded – undo
4250 4250
 		if ($fp != false)
4251 4251
 		{
4252 4252
 			// Send the HEAD request (since we don't have to worry about chunked, HTTP/1.1 is fine here.)
4253
-			fwrite($fp, 'HEAD /' . $match[2] . ' HTTP/1.1' . "\r\n" . 'Host: ' . $match[1] . "\r\n" . 'user-agent: '. SMF_USER_AGENT . "\r\n" . 'Connection: close' . "\r\n\r\n");
4253
+			fwrite($fp, 'HEAD /' . $match[2] . ' HTTP/1.1' . "\r\n" . 'Host: ' . $match[1] . "\r\n" . 'user-agent: ' . SMF_USER_AGENT . "\r\n" . 'Connection: close' . "\r\n\r\n");
4254 4254
 
4255 4255
 			// Read in the HTTP/1.1 or whatever.
4256 4256
 			$test = substr(fgets($fp, 11), -1);
@@ -4846,7 +4846,7 @@  discard block
 block discarded – undo
4846 4846
 
4847 4847
 	uasort(
4848 4848
 		$context['css_files'],
4849
-		function ($a, $b)
4849
+		function($a, $b)
4850 4850
 		{
4851 4851
 			return $a['options']['order_pos'] < $b['options']['order_pos'] ? -1 : ($a['options']['order_pos'] > $b['options']['order_pos'] ? 1 : 0);
4852 4852
 		}
@@ -6143,7 +6143,7 @@  discard block
 block discarded – undo
6143 6143
 			{
6144 6144
 				fwrite($fp, 'GET ' . ($match[6] !== '/' ? str_replace(' ', '%20', $match[6]) : '') . ' HTTP/1.0' . "\r\n");
6145 6145
 				fwrite($fp, 'Host: ' . $match[3] . (empty($match[5]) ? ($match[2] ? ':443' : '') : ':' . $match[5]) . "\r\n");
6146
-				fwrite($fp, 'user-agent: '. SMF_USER_AGENT . "\r\n");
6146
+				fwrite($fp, 'user-agent: ' . SMF_USER_AGENT . "\r\n");
6147 6147
 				if ($keep_alive)
6148 6148
 					fwrite($fp, 'connection: Keep-Alive' . "\r\n\r\n");
6149 6149
 				else
@@ -6153,7 +6153,7 @@  discard block
 block discarded – undo
6153 6153
 			{
6154 6154
 				fwrite($fp, 'POST ' . ($match[6] !== '/' ? $match[6] : '') . ' HTTP/1.0' . "\r\n");
6155 6155
 				fwrite($fp, 'Host: ' . $match[3] . (empty($match[5]) ? ($match[2] ? ':443' : '') : ':' . $match[5]) . "\r\n");
6156
-				fwrite($fp, 'user-agent: '. SMF_USER_AGENT . "\r\n");
6156
+				fwrite($fp, 'user-agent: ' . SMF_USER_AGENT . "\r\n");
6157 6157
 				if ($keep_alive)
6158 6158
 					fwrite($fp, 'connection: Keep-Alive' . "\r\n");
6159 6159
 				else
@@ -6402,13 +6402,13 @@  discard block
 block discarded – undo
6402 6402
 
6403 6403
 	// UTF-8 occurences of MS special characters
6404 6404
 	$findchars_utf8 = array(
6405
-		"\xe2\x80\x9a",	// single low-9 quotation mark
6406
-		"\xe2\x80\x9e",	// double low-9 quotation mark
6407
-		"\xe2\x80\xa6",	// horizontal ellipsis
6408
-		"\xe2\x80\x98",	// left single curly quote
6409
-		"\xe2\x80\x99",	// right single curly quote
6410
-		"\xe2\x80\x9c",	// left double curly quote
6411
-		"\xe2\x80\x9d",	// right double curly quote
6405
+		"\xe2\x80\x9a", // single low-9 quotation mark
6406
+		"\xe2\x80\x9e", // double low-9 quotation mark
6407
+		"\xe2\x80\xa6", // horizontal ellipsis
6408
+		"\xe2\x80\x98", // left single curly quote
6409
+		"\xe2\x80\x99", // right single curly quote
6410
+		"\xe2\x80\x9c", // left double curly quote
6411
+		"\xe2\x80\x9d", // right double curly quote
6412 6412
 	);
6413 6413
 
6414 6414
 	// windows 1252 / iso equivalents
@@ -6424,13 +6424,13 @@  discard block
 block discarded – undo
6424 6424
 
6425 6425
 	// safe replacements
6426 6426
 	$replacechars = array(
6427
-		',',	// &sbquo;
6428
-		',,',	// &bdquo;
6429
-		'...',	// &hellip;
6430
-		"'",	// &lsquo;
6431
-		"'",	// &rsquo;
6432
-		'"',	// &ldquo;
6433
-		'"',	// &rdquo;
6427
+		',', // &sbquo;
6428
+		',,', // &bdquo;
6429
+		'...', // &hellip;
6430
+		"'", // &lsquo;
6431
+		"'", // &rsquo;
6432
+		'"', // &ldquo;
6433
+		'"', // &rdquo;
6434 6434
 	);
6435 6435
 
6436 6436
 	if ($context['utf8'])
@@ -6791,7 +6791,7 @@  discard block
 block discarded – undo
6791 6791
 		// We don't want abbreviations like '+03' or '-11'.
6792 6792
 		$abbrs = array_filter(
6793 6793
 			$tzvalue['abbrs'],
6794
-			function ($abbr)
6794
+			function($abbr)
6795 6795
 			{
6796 6796
 				return !strspn($abbr, '+-');
6797 6797
 			}
@@ -7780,7 +7780,7 @@  discard block
 block discarded – undo
7780 7780
 			EXISTS (
7781 7781
 				SELECT bpv.id_board
7782 7782
 				FROM ' . $db_prefix . 'board_permissions_view AS bpv
7783
-				WHERE bpv.id_group IN ('. implode(',', $groups) .')
7783
+				WHERE bpv.id_group IN ('. implode(',', $groups) . ')
7784 7784
 					AND bpv.deny = 0
7785 7785
 					AND bpv.id_board = b.id_board
7786 7786
 			)';
@@ -7790,7 +7790,7 @@  discard block
 block discarded – undo
7790 7790
 			AND NOT EXISTS (
7791 7791
 				SELECT bpv.id_board
7792 7792
 				FROM ' . $db_prefix . 'board_permissions_view AS bpv
7793
-				WHERE bpv.id_group IN ( '. implode(',', $groups) .')
7793
+				WHERE bpv.id_group IN ( '. implode(',', $groups) . ')
7794 7794
 					AND bpv.deny = 1
7795 7795
 					AND bpv.id_board = b.id_board
7796 7796
 			)';
@@ -8197,8 +8197,8 @@  discard block
 block discarded – undo
8197 8197
 	$i = 0;
8198 8198
 	while (empty($done))
8199 8199
 	{
8200
-		if (strpos($format, '{'. --$i . '}') !== false)
8201
-			$replacements['{'. $i . '}'] = array_pop($list);
8200
+		if (strpos($format, '{' . --$i . '}') !== false)
8201
+			$replacements['{' . $i . '}'] = array_pop($list);
8202 8202
 		else
8203 8203
 			$done = true;
8204 8204
 	}
@@ -8208,8 +8208,8 @@  discard block
 block discarded – undo
8208 8208
 	$i = 0;
8209 8209
 	while (empty($done))
8210 8210
 	{
8211
-		if (strpos($format, '{'. ++$i . '}') !== false)
8212
-			$replacements['{'. $i . '}'] = array_shift($list);
8211
+		if (strpos($format, '{' . ++$i . '}') !== false)
8212
+			$replacements['{' . $i . '}'] = array_shift($list);
8213 8213
 		else
8214 8214
 			$done = true;
8215 8215
 	}
@@ -8387,7 +8387,7 @@  discard block
 block discarded – undo
8387 8387
 	if (empty($stringSubject))
8388 8388
 		return '';
8389 8389
 
8390
-	$translatable_tokens = preg_match_all('/{(.*?)}/' , $stringSubject, $matches);
8390
+	$translatable_tokens = preg_match_all('/{(.*?)}/', $stringSubject, $matches);
8391 8391
 	$toFind = array();
8392 8392
 	$replaceWith = array();
8393 8393
 
Please login to merge, or discard this patch.
other/install.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -92,7 +92,7 @@  discard block
 block discarded – undo
92 92
 				return false;
93 93
 		},
94 94
 		'utf8_version' => '8.0',
95
-		'utf8_version_check' => function (){
95
+		'utf8_version_check' => function() {
96 96
 			global $db_connection;
97 97
 			$request = pg_query($db_connection, 'SELECT version()');
98 98
 			list ($version) = pg_fetch_row($request);
@@ -987,7 +987,7 @@  discard block
 block discarded – undo
987 987
 	$incontext['continue'] = 1;
988 988
 
989 989
 	// Check Postgres setting
990
-	if ( $db_type === 'postgresql')
990
+	if ($db_type === 'postgresql')
991 991
 	{
992 992
 		load_database();
993 993
 		$result = $smcFunc['db_query']('', '
Please login to merge, or discard this patch.