@@ -63,18 +63,19 @@ discard block |
||
63 | 63 | </dt> |
64 | 64 | <dd> |
65 | 65 | ', $modSettings['smileys_url'], '/'; |
66 | - if ($context['current_set']['id'] == 'default') |
|
67 | - echo '<strong>default</strong><input type="hidden" name="smiley_sets_path" id="smiley_sets_path" value="default">'; |
|
68 | - elseif (empty($context['smiley_set_dirs'])) |
|
69 | - echo ' |
|
66 | + if ($context['current_set']['id'] == 'default') { |
|
67 | + echo '<strong>default</strong><input type="hidden" name="smiley_sets_path" id="smiley_sets_path" value="default">'; |
|
68 | + } elseif (empty($context['smiley_set_dirs'])) { |
|
69 | + echo ' |
|
70 | 70 | <input type="text" name="smiley_sets_path" id="smiley_sets_path" value="', $context['current_set']['path'], '"> '; |
71 | - else |
|
71 | + } else |
|
72 | 72 | { |
73 | 73 | echo ' |
74 | 74 | <select name="smiley_sets_path" id="smiley_sets_path">'; |
75 | - foreach ($context['smiley_set_dirs'] as $smiley_set_dir) |
|
76 | - echo ' |
|
75 | + foreach ($context['smiley_set_dirs'] as $smiley_set_dir) { |
|
76 | + echo ' |
|
77 | 77 | <option value="', $smiley_set_dir['id'], '"', $smiley_set_dir['current'] ? ' selected' : '', $smiley_set_dir['selectable'] ? '' : ' disabled', '>', $smiley_set_dir['id'], '</option>'; |
78 | + } |
|
78 | 79 | echo ' |
79 | 80 | </select> '; |
80 | 81 | } |
@@ -89,14 +90,15 @@ discard block |
||
89 | 90 | </dd>'; |
90 | 91 | |
91 | 92 | // If this is a new smiley set they have the option to import smileys already in the directory. |
92 | - if ($context['current_set']['is_new'] && !empty($modSettings['smiley_enable'])) |
|
93 | - echo ' |
|
93 | + if ($context['current_set']['is_new'] && !empty($modSettings['smiley_enable'])) { |
|
94 | + echo ' |
|
94 | 95 | <dt> |
95 | 96 | <strong><label for="smiley_sets_import">', $txt['smiley_set_import_directory'], '</label>: </strong> |
96 | 97 | </dt> |
97 | 98 | <dd> |
98 | 99 | <input type="checkbox" name="smiley_sets_import" id="smiley_sets_import" value="1"> |
99 | 100 | </dd>'; |
101 | + } |
|
100 | 102 | |
101 | 103 | echo ' |
102 | 104 | </dl> |
@@ -130,9 +132,10 @@ discard block |
||
130 | 132 | <dd> |
131 | 133 | <img src="', $modSettings['smileys_url'], '/', $modSettings['smiley_sets_default'], '/', $context['current_smiley']['filename'], '" id="preview" alt=""> (', $txt['smiley_preview_using'], ': <select name="set" onchange="updatePreview();">'; |
132 | 134 | |
133 | - foreach ($context['smiley_sets'] as $smiley_set) |
|
134 | - echo ' |
|
135 | + foreach ($context['smiley_sets'] as $smiley_set) { |
|
136 | + echo ' |
|
135 | 137 | <option value="', $smiley_set['path'], '"', $context['selected_set'] == $smiley_set['path'] ? ' selected' : '', '>', $smiley_set['name'], '</option>'; |
138 | + } |
|
136 | 139 | |
137 | 140 | echo ' |
138 | 141 | </select>) |
@@ -147,16 +150,17 @@ discard block |
||
147 | 150 | <strong><label for="smiley_filename">', $txt['smileys_filename'], '</label>: </strong> |
148 | 151 | </dt> |
149 | 152 | <dd>'; |
150 | - if (empty($context['filenames'])) |
|
151 | - echo ' |
|
153 | + if (empty($context['filenames'])) { |
|
154 | + echo ' |
|
152 | 155 | <input type="text" name="smiley_filename" id="smiley_filename" value="', $context['current_smiley']['filename'], '">'; |
153 | - else |
|
156 | + } else |
|
154 | 157 | { |
155 | 158 | echo ' |
156 | 159 | <select name="smiley_filename" id="smiley_filename" onchange="updatePreview();">'; |
157 | - foreach ($context['filenames'] as $filename) |
|
158 | - echo ' |
|
160 | + foreach ($context['filenames'] as $filename) { |
|
161 | + echo ' |
|
159 | 162 | <option value="', $filename['id'], '"', $filename['selected'] ? ' selected' : '', '>', $filename['id'], '</option>'; |
163 | + } |
|
160 | 164 | echo ' |
161 | 165 | </select>'; |
162 | 166 | } |
@@ -225,9 +229,10 @@ discard block |
||
225 | 229 | <dd> |
226 | 230 | ', $txt['smiley_preview_using'], ': <select name="set" onchange="updatePreview();selectMethod(\'existing\');">'; |
227 | 231 | |
228 | - foreach ($context['smiley_sets'] as $smiley_set) |
|
229 | - echo ' |
|
232 | + foreach ($context['smiley_sets'] as $smiley_set) { |
|
233 | + echo ' |
|
230 | 234 | <option value="', $smiley_set['path'], '"', $context['selected_set'] == $smiley_set['path'] ? ' selected' : '', '>', $smiley_set['name'], '</option>'; |
235 | + } |
|
231 | 236 | |
232 | 237 | echo ' |
233 | 238 | </select> |
@@ -236,16 +241,17 @@ discard block |
||
236 | 241 | <strong><label for="smiley_filename">', $txt['smileys_filename'], '</label>: </strong> |
237 | 242 | </dt> |
238 | 243 | <dd>'; |
239 | - if (empty($context['filenames'])) |
|
240 | - echo ' |
|
244 | + if (empty($context['filenames'])) { |
|
245 | + echo ' |
|
241 | 246 | <input type="text" name="smiley_filename" id="smiley_filename" value="', $context['current_smiley']['filename'], '" onchange="selectMethod(\'existing\');">'; |
242 | - else |
|
247 | + } else |
|
243 | 248 | { |
244 | 249 | echo ' |
245 | 250 | <select name="smiley_filename" id="smiley_filename" onchange="updatePreview();selectMethod(\'existing\');">'; |
246 | - foreach ($context['filenames'] as $filename) |
|
247 | - echo ' |
|
251 | + foreach ($context['filenames'] as $filename) { |
|
252 | + echo ' |
|
248 | 253 | <option value="', $filename['id'], '"', $filename['selected'] ? ' selected' : '', '>', $filename['id'], '</option>'; |
254 | + } |
|
249 | 255 | echo ' |
250 | 256 | </select>'; |
251 | 257 | } |
@@ -273,14 +279,15 @@ discard block |
||
273 | 279 | </fieldset> |
274 | 280 | |
275 | 281 | <dl id="uploadMore" style="display: none;" class="settings">'; |
276 | - foreach ($context['smiley_sets'] as $smiley_set) |
|
277 | - echo ' |
|
282 | + foreach ($context['smiley_sets'] as $smiley_set) { |
|
283 | + echo ' |
|
278 | 284 | <dt> |
279 | 285 | ', sprintf($txt['smileys_add_upload_for'], '<strong>' . $smiley_set['name'] . '</strong>'), ': |
280 | 286 | </dt> |
281 | 287 | <dd> |
282 | 288 | <input type="file" name="individual_', $smiley_set['name'], '" onchange="selectMethod(\'upload\');"> |
283 | 289 | </dd>'; |
290 | + } |
|
284 | 291 | echo ' |
285 | 292 | </dl> |
286 | 293 | </div> |
@@ -349,24 +356,27 @@ discard block |
||
349 | 356 | <strong>', empty($context['move_smiley']) ? $txt['smileys_move_select_smiley'] : $txt['smileys_move_select_destination'], '...</strong><br>'; |
350 | 357 | foreach ($location['rows'] as $row) |
351 | 358 | { |
352 | - if (!empty($context['move_smiley'])) |
|
353 | - echo ' |
|
359 | + if (!empty($context['move_smiley'])) { |
|
360 | + echo ' |
|
354 | 361 | <a href="', $scripturl, '?action=admin;area=smileys;sa=setorder;location=', $location['id'], ';source=', $context['move_smiley'], ';row=', $row[0]['row'], ';reorder=1;', $context['session_var'], '=', $context['session_id'], '"><span class="generic_icons select_below" title="', $txt['smileys_move_here'], '"></span></a>'; |
362 | + } |
|
355 | 363 | |
356 | 364 | foreach ($row as $smiley) |
357 | 365 | { |
358 | - if (empty($context['move_smiley'])) |
|
359 | - echo '<a href="', $scripturl, '?action=admin;area=smileys;sa=setorder;move=', $smiley['id'], '"><img src="', $modSettings['smileys_url'], '/', $modSettings['smiley_sets_default'], '/', $smiley['filename'], '" style="padding: 2px; border: 0px solid black;" alt="', $smiley['description'], '"></a>'; |
|
360 | - else |
|
361 | - echo '<img src="', $modSettings['smileys_url'], '/', $modSettings['smiley_sets_default'], '/', $smiley['filename'], '" style="padding: 2px;', $smiley['selected'] ? ' border: 2px solid red' : '', ';" alt="', $smiley['description'], '"><a href="', $scripturl, '?action=admin;area=smileys;sa=setorder;location=', $location['id'], ';source=', $context['move_smiley'], ';after=', $smiley['id'], ';reorder=1;', $context['session_var'], '=', $context['session_id'], '" title="', $txt['smileys_move_here'], '"><span class="generic_icons select_below" title="', $txt['smileys_move_here'], '"></span></a>'; |
|
366 | + if (empty($context['move_smiley'])) { |
|
367 | + echo '<a href="', $scripturl, '?action=admin;area=smileys;sa=setorder;move=', $smiley['id'], '"><img src="', $modSettings['smileys_url'], '/', $modSettings['smiley_sets_default'], '/', $smiley['filename'], '" style="padding: 2px; border: 0px solid black;" alt="', $smiley['description'], '"></a>'; |
|
368 | + } else { |
|
369 | + echo '<img src="', $modSettings['smileys_url'], '/', $modSettings['smiley_sets_default'], '/', $smiley['filename'], '" style="padding: 2px;', $smiley['selected'] ? ' border: 2px solid red' : '', ';" alt="', $smiley['description'], '"><a href="', $scripturl, '?action=admin;area=smileys;sa=setorder;location=', $location['id'], ';source=', $context['move_smiley'], ';after=', $smiley['id'], ';reorder=1;', $context['session_var'], '=', $context['session_id'], '" title="', $txt['smileys_move_here'], '"><span class="generic_icons select_below" title="', $txt['smileys_move_here'], '"></span></a>'; |
|
370 | + } |
|
362 | 371 | } |
363 | 372 | |
364 | 373 | echo ' |
365 | 374 | <br>'; |
366 | 375 | } |
367 | - if (!empty($context['move_smiley'])) |
|
368 | - echo ' |
|
376 | + if (!empty($context['move_smiley'])) { |
|
377 | + echo ' |
|
369 | 378 | <a href="', $scripturl, '?action=admin;area=smileys;sa=setorder;location=', $location['id'], ';source=', $context['move_smiley'], ';row=', $location['last_row'], ';reorder=1;', $context['session_var'], '=', $context['session_id'], '"><span class="generic_icons select_below" title="', $txt['smileys_move_here'], '"></span></a>'; |
379 | + } |
|
370 | 380 | echo ' |
371 | 381 | </div> |
372 | 382 | <input type="hidden" name="reorder" value="1"> |
@@ -402,14 +412,15 @@ discard block |
||
402 | 412 | </div> |
403 | 413 | <div class="windowbg2"> |
404 | 414 | <dl class="settings">'; |
405 | - if (!$context['new_icon']) |
|
406 | - echo ' |
|
415 | + if (!$context['new_icon']) { |
|
416 | + echo ' |
|
407 | 417 | <dt> |
408 | 418 | <strong>', $txt['smiley_preview'], ': </strong> |
409 | 419 | </dt> |
410 | 420 | <dd> |
411 | 421 | <img src="', $context['icon']['image_url'], '" alt="', $context['icon']['title'], '"> |
412 | 422 | </dd>'; |
423 | + } |
|
413 | 424 | echo ' |
414 | 425 | <dt> |
415 | 426 | <strong><label for="icon_filename">', $txt['smileys_filename'], '</label>: </strong><br><span class="smalltext">', $txt['icons_filename_all_png'], '</span> |
@@ -434,9 +445,10 @@ discard block |
||
434 | 445 | { |
435 | 446 | echo ' |
436 | 447 | <optgroup label="', $category['name'], '">'; |
437 | - foreach ($category['boards'] as $board) |
|
438 | - echo ' |
|
448 | + foreach ($category['boards'] as $board) { |
|
449 | + echo ' |
|
439 | 450 | <option value="', $board['id'], '"', $board['selected'] ? ' selected' : '', '>', $board['child_level'] > 0 ? str_repeat('==', $board['child_level'] - 1) . '=>' : '', ' ', $board['name'], '</option>'; |
451 | + } |
|
440 | 452 | echo ' |
441 | 453 | </optgroup>'; |
442 | 454 | } |
@@ -451,19 +463,21 @@ discard block |
||
451 | 463 | <option value="0"', empty($context['icon']['after']) ? ' selected' : '', '>', $txt['icons_location_first_icon'], '</option>'; |
452 | 464 | |
453 | 465 | // Print the list of all the icons it can be put after... |
454 | - foreach ($context['icons'] as $id => $data) |
|
455 | - if (empty($context['icon']['id']) || $id != $context['icon']['id']) |
|
466 | + foreach ($context['icons'] as $id => $data) { |
|
467 | + if (empty($context['icon']['id']) || $id != $context['icon']['id']) |
|
456 | 468 | echo ' |
457 | 469 | <option value="', $id, '"', !empty($context['icon']['after']) && $id == $context['icon']['after'] ? ' selected' : '', '>', $txt['icons_location_after'], ': ', $data['title'], '</option>'; |
470 | + } |
|
458 | 471 | |
459 | 472 | echo ' |
460 | 473 | </select> |
461 | 474 | </dd> |
462 | 475 | </dl>'; |
463 | 476 | |
464 | - if (!$context['new_icon']) |
|
465 | - echo ' |
|
477 | + if (!$context['new_icon']) { |
|
478 | + echo ' |
|
466 | 479 | <input type="hidden" name="icon" value="', $context['icon']['id'], '">'; |
480 | + } |
|
467 | 481 | |
468 | 482 | echo ' |
469 | 483 | <input type="submit" name="icons_save" value="', $txt['smileys_save'], '" class="button"> |
@@ -72,9 +72,10 @@ discard block |
||
72 | 72 | |
73 | 73 | // Allow css/js files to be disable for this specific theme. |
74 | 74 | // Add the identifier as an array key. IE array('smf_script'); Some external files might not add identifiers, on those cases SMF uses its filename as reference. |
75 | - if (!isset($settings['disable_files'])) |
|
76 | - $settings['disable_files'] = array(); |
|
77 | -} |
|
75 | + if (!isset($settings['disable_files'])) { |
|
76 | + $settings['disable_files'] = array(); |
|
77 | + } |
|
78 | + } |
|
78 | 79 | |
79 | 80 | /** |
80 | 81 | * The main sub template above the content. |
@@ -111,8 +112,9 @@ discard block |
||
111 | 112 | echo ' |
112 | 113 | <meta'; |
113 | 114 | |
114 | - foreach ($meta_tag as $meta_key => $meta_value) |
|
115 | - echo ' ', $meta_key, '="', $meta_value, '"'; |
|
115 | + foreach ($meta_tag as $meta_key => $meta_value) { |
|
116 | + echo ' ', $meta_key, '="', $meta_value, '"'; |
|
117 | + } |
|
116 | 118 | |
117 | 119 | echo '>'; |
118 | 120 | } |
@@ -123,14 +125,16 @@ discard block |
||
123 | 125 | <meta name="theme-color" content="#557EA0">'; |
124 | 126 | |
125 | 127 | // Please don't index these Mr Robot. |
126 | - if (!empty($context['robot_no_index'])) |
|
127 | - echo ' |
|
128 | + if (!empty($context['robot_no_index'])) { |
|
129 | + echo ' |
|
128 | 130 | <meta name="robots" content="noindex">'; |
131 | + } |
|
129 | 132 | |
130 | 133 | // Present a canonical url for search engines to prevent duplicate content in their indices. |
131 | - if (!empty($context['canonical_url'])) |
|
132 | - echo ' |
|
134 | + if (!empty($context['canonical_url'])) { |
|
135 | + echo ' |
|
133 | 136 | <link rel="canonical" href="', $context['canonical_url'], '">'; |
137 | + } |
|
134 | 138 | |
135 | 139 | // Show all the relative links, such as help, search, contents, and the like. |
136 | 140 | echo ' |
@@ -139,10 +143,11 @@ discard block |
||
139 | 143 | <link rel="search" href="' . $scripturl . '?action=search">' : ''); |
140 | 144 | |
141 | 145 | // If RSS feeds are enabled, advertise the presence of one. |
142 | - if (!empty($modSettings['xmlnews_enable']) && (!empty($modSettings['allow_guestAccess']) || $context['user']['is_logged'])) |
|
143 | - echo ' |
|
146 | + if (!empty($modSettings['xmlnews_enable']) && (!empty($modSettings['allow_guestAccess']) || $context['user']['is_logged'])) { |
|
147 | + echo ' |
|
144 | 148 | <link rel="alternate" type="application/rss+xml" title="', $context['forum_name_html_safe'], ' - ', $txt['rss'], '" href="', $scripturl, '?action=.xml;type=rss2', !empty($context['current_board']) ? ';board=' . $context['current_board'] : '', '"> |
145 | 149 | <link rel="alternate" type="application/atom+xml" title="', $context['forum_name_html_safe'], ' - ', $txt['atom'], '" href="', $scripturl, '?action=.xml;type=atom', !empty($context['current_board']) ? ';board=' . $context['current_board'] : '', '">'; |
150 | + } |
|
146 | 151 | |
147 | 152 | // If we're viewing a topic, these should be the previous and next topics, respectively. |
148 | 153 | if (!empty($context['links']['next'])) |
@@ -158,9 +163,10 @@ discard block |
||
158 | 163 | } |
159 | 164 | |
160 | 165 | // If we're in a board, or a topic for that matter, the index will be the board's index. |
161 | - if (!empty($context['current_board'])) |
|
162 | - echo ' |
|
166 | + if (!empty($context['current_board'])) { |
|
167 | + echo ' |
|
163 | 168 | <link rel="index" href="', $scripturl, '?board=', $context['current_board'], '.0">'; |
169 | + } |
|
164 | 170 | |
165 | 171 | // Output any remaining HTML headers. (from mods, maybe?) |
166 | 172 | echo $context['html_headers']; |
@@ -192,8 +198,9 @@ discard block |
||
192 | 198 | <ul class="floatleft" id="top_info"> |
193 | 199 | <li> |
194 | 200 | <a href="', $scripturl, '?action=profile"', !empty($context['self_profile']) ? ' class="active"' : '', ' id="profile_menu_top" onclick="return false;">'; |
195 | - if (!empty($context['user']['avatar'])) |
|
196 | - echo $context['user']['avatar']['image']; |
|
201 | + if (!empty($context['user']['avatar'])) { |
|
202 | + echo $context['user']['avatar']['image']; |
|
203 | + } |
|
197 | 204 | echo $context['user']['name'], '</a> |
198 | 205 | <div id="profile_menu" class="top_menu"></div> |
199 | 206 | </li>'; |
@@ -221,17 +228,18 @@ discard block |
||
221 | 228 | } |
222 | 229 | // Otherwise they're a guest. Ask them to either register or login. |
223 | 230 | else |
224 | - if (empty($maintenance)) |
|
225 | - echo ' |
|
231 | + if (empty($maintenance)) { |
|
232 | + echo ' |
|
226 | 233 | <ul class="floatleft welcome"> |
227 | 234 | <li>', sprintf($txt[$context['can_register'] ? 'welcome_guest_register' : 'welcome_guest'], $txt['guest_title'], $context['forum_name_html_safe'], $scripturl . '?action=login', 'return reqOverlayDiv(this.href, ' . JavaScriptEscape($txt['login']) . ');', $scripturl . '?action=signup'), '</li> |
228 | 235 | </ul>'; |
229 | - else |
|
230 | - //In maintenance mode, only login is allowed and don't show OverlayDiv |
|
236 | + } else { |
|
237 | + //In maintenance mode, only login is allowed and don't show OverlayDiv |
|
231 | 238 | echo ' |
232 | 239 | <ul class="floatleft welcome"> |
233 | 240 | <li>', sprintf($txt['welcome_guest'], $txt['guest_title'], '', $scripturl. '?action=login', 'return true;'), '</li> |
234 | 241 | </ul>'; |
242 | + } |
|
235 | 243 | |
236 | 244 | if (!empty($modSettings['userLanguage']) && !empty($context['languages']) && count($context['languages']) > 1) |
237 | 245 | { |
@@ -239,9 +247,10 @@ discard block |
||
239 | 247 | <form id="languages_form" method="get" class="floatright"> |
240 | 248 | <select id="language_select" name="language" onchange="this.form.submit()">'; |
241 | 249 | |
242 | - foreach ($context['languages'] as $language) |
|
243 | - echo ' |
|
250 | + foreach ($context['languages'] as $language) { |
|
251 | + echo ' |
|
244 | 252 | <option value="', $language['filename'], '"', isset($context['user']['language']) && $context['user']['language'] == $language['filename'] ? ' selected="selected"' : '', '>', str_replace('-utf8', '', $language['name']), '</option>'; |
253 | + } |
|
245 | 254 | |
246 | 255 | echo ' |
247 | 256 | </select> |
@@ -265,31 +274,36 @@ discard block |
||
265 | 274 | <option value="all"', ($selected == 'all' ? ' selected' : ''), '>', $txt['search_entireforum'], ' </option>'; |
266 | 275 | |
267 | 276 | // Can't limit it to a specific topic if we are not in one |
268 | - if (!empty($context['current_topic'])) |
|
269 | - echo ' |
|
277 | + if (!empty($context['current_topic'])) { |
|
278 | + echo ' |
|
270 | 279 | <option value="topic"', ($selected == 'current_topic' ? ' selected' : ''), '>', $txt['search_thistopic'], '</option>'; |
280 | + } |
|
271 | 281 | |
272 | 282 | // Can't limit it to a specific board if we are not in one |
273 | - if (!empty($context['current_board'])) |
|
274 | - echo ' |
|
283 | + if (!empty($context['current_board'])) { |
|
284 | + echo ' |
|
275 | 285 | <option value="board"', ($selected == 'current_board' ? ' selected' : ''), '>', $txt['search_thisbrd'], '</option>'; |
286 | + } |
|
276 | 287 | |
277 | 288 | // Can't search for members if we can't see the memberlist |
278 | - if (!empty($context['allow_memberlist'])) |
|
279 | - echo ' |
|
289 | + if (!empty($context['allow_memberlist'])) { |
|
290 | + echo ' |
|
280 | 291 | <option value="members"', ($selected == 'members' ? ' selected' : ''), '>', $txt['search_members'], ' </option>'; |
292 | + } |
|
281 | 293 | |
282 | 294 | echo ' |
283 | 295 | </select>'; |
284 | 296 | |
285 | 297 | // Search within current topic? |
286 | - if (!empty($context['current_topic'])) |
|
287 | - echo ' |
|
298 | + if (!empty($context['current_topic'])) { |
|
299 | + echo ' |
|
288 | 300 | <input type="hidden" name="sd_topic" value="', $context['current_topic'], '">'; |
301 | + } |
|
289 | 302 | // If we're on a certain board, limit it to this board ;). |
290 | - elseif (!empty($context['current_board'])) |
|
291 | - echo ' |
|
303 | + elseif (!empty($context['current_board'])) { |
|
304 | + echo ' |
|
292 | 305 | <input type="hidden" name="sd_brd" value="', $context['current_board'], '">'; |
306 | + } |
|
293 | 307 | |
294 | 308 | echo ' |
295 | 309 | <input type="submit" name="search2" value="', $txt['search'], '" class="button"> |
@@ -320,12 +334,13 @@ discard block |
||
320 | 334 | ', $context['current_time'], ' |
321 | 335 | </div>'; |
322 | 336 | // Show a random news item? (or you could pick one from news_lines...) |
323 | - if (!empty($settings['enable_news']) && !empty($context['random_news_line'])) |
|
324 | - echo ' |
|
337 | + if (!empty($settings['enable_news']) && !empty($context['random_news_line'])) { |
|
338 | + echo ' |
|
325 | 339 | <div class="news"> |
326 | 340 | <h2>', $txt['news'], ': </h2> |
327 | 341 | <p>', $context['random_news_line'], '</p> |
328 | 342 | </div>'; |
343 | + } |
|
329 | 344 | |
330 | 345 | echo ' |
331 | 346 | <hr class="clear"> |
@@ -388,9 +403,10 @@ discard block |
||
388 | 403 | </ul>'; |
389 | 404 | |
390 | 405 | // Show the load time? |
391 | - if ($context['show_load_time']) |
|
392 | - echo ' |
|
406 | + if ($context['show_load_time']) { |
|
407 | + echo ' |
|
393 | 408 | <p>', sprintf($txt['page_created_full'], $context['load_time'], $context['load_queries']), '</p>'; |
409 | + } |
|
394 | 410 | |
395 | 411 | echo ' |
396 | 412 | </div>'; |
@@ -420,19 +436,21 @@ discard block |
||
420 | 436 | global $context, $shown_linktree, $scripturl, $txt; |
421 | 437 | |
422 | 438 | // If linktree is empty, just return - also allow an override. |
423 | - if (empty($context['linktree']) || (!empty($context['dont_default_linktree']) && !$force_show)) |
|
424 | - return; |
|
439 | + if (empty($context['linktree']) || (!empty($context['dont_default_linktree']) && !$force_show)) { |
|
440 | + return; |
|
441 | + } |
|
425 | 442 | |
426 | 443 | echo ' |
427 | 444 | <div class="navigate_section"> |
428 | 445 | <ul>'; |
429 | 446 | |
430 | - if ($context['user']['is_logged']) |
|
431 | - echo ' |
|
447 | + if ($context['user']['is_logged']) { |
|
448 | + echo ' |
|
432 | 449 | <li class="unread_links"> |
433 | 450 | <a href="', $scripturl, '?action=unread" title="', $txt['unread_since_visit'], '">', $txt['view_unread_category'], '</a> |
434 | 451 | <a href="', $scripturl, '?action=unreadreplies" title="', $txt['show_unread_replies'], '">', $txt['unread_replies'], '</a> |
435 | 452 | </li>'; |
453 | + } |
|
436 | 454 | |
437 | 455 | // Each tree item has a URL and name. Some may have extra_before and extra_after. |
438 | 456 | foreach ($context['linktree'] as $link_num => $tree) |
@@ -443,25 +461,29 @@ discard block |
||
443 | 461 | // Don't show a separator for the first one. |
444 | 462 | // Better here. Always points to the next level when the linktree breaks to a second line. |
445 | 463 | // Picked a better looking HTML entity, and added support for RTL plus a span for styling. |
446 | - if ($link_num != 0) |
|
447 | - echo ' |
|
464 | + if ($link_num != 0) { |
|
465 | + echo ' |
|
448 | 466 | <span class="dividers">', $context['right_to_left'] ? ' ◄ ' : ' ► ', '</span>'; |
467 | + } |
|
449 | 468 | |
450 | 469 | // Show something before the link? |
451 | - if (isset($tree['extra_before'])) |
|
452 | - echo $tree['extra_before'], ' '; |
|
470 | + if (isset($tree['extra_before'])) { |
|
471 | + echo $tree['extra_before'], ' '; |
|
472 | + } |
|
453 | 473 | |
454 | 474 | // Show the link, including a URL if it should have one. |
455 | - if (isset($tree['url'])) |
|
456 | - echo ' |
|
475 | + if (isset($tree['url'])) { |
|
476 | + echo ' |
|
457 | 477 | <a href="' . $tree['url'] . '"><span>' . $tree['name'] . '</span></a>'; |
458 | - else |
|
459 | - echo ' |
|
478 | + } else { |
|
479 | + echo ' |
|
460 | 480 | <span>' . $tree['name'] . '</span>'; |
481 | + } |
|
461 | 482 | |
462 | 483 | // Show something after the link...? |
463 | - if (isset($tree['extra_after'])) |
|
464 | - echo ' ', $tree['extra_after']; |
|
484 | + if (isset($tree['extra_after'])) { |
|
485 | + echo ' ', $tree['extra_after']; |
|
486 | + } |
|
465 | 487 | |
466 | 488 | echo ' |
467 | 489 | </li>'; |
@@ -511,13 +533,14 @@ discard block |
||
511 | 533 | echo ' |
512 | 534 | <ul>'; |
513 | 535 | |
514 | - foreach ($childbutton['sub_buttons'] as $grandchildbutton) |
|
515 | - echo ' |
|
536 | + foreach ($childbutton['sub_buttons'] as $grandchildbutton) { |
|
537 | + echo ' |
|
516 | 538 | <li> |
517 | 539 | <a href="', $grandchildbutton['href'], '"', isset($grandchildbutton['target']) ? ' target="' . $grandchildbutton['target'] . '"' : '', '> |
518 | 540 | ', $grandchildbutton['title'], ' |
519 | 541 | </a> |
520 | 542 | </li>'; |
543 | + } |
|
521 | 544 | |
522 | 545 | echo ' |
523 | 546 | </ul>'; |
@@ -548,8 +571,9 @@ discard block |
||
548 | 571 | { |
549 | 572 | global $context, $txt; |
550 | 573 | |
551 | - if (!is_array($strip_options)) |
|
552 | - $strip_options = array(); |
|
574 | + if (!is_array($strip_options)) { |
|
575 | + $strip_options = array(); |
|
576 | + } |
|
553 | 577 | |
554 | 578 | // Create the buttons... |
555 | 579 | $buttons = array(); |
@@ -558,8 +582,9 @@ discard block |
||
558 | 582 | // As of 2.1, the 'test' for each button happens while the array is being generated. The extra 'test' check here is deprecated but kept for backward compatibility (update your mods, folks!) |
559 | 583 | if (!isset($value['test']) || !empty($context[$value['test']])) |
560 | 584 | { |
561 | - if (!isset($value['id'])) |
|
562 | - $value['id'] = $key; |
|
585 | + if (!isset($value['id'])) { |
|
586 | + $value['id'] = $key; |
|
587 | + } |
|
563 | 588 | |
564 | 589 | $button = ' |
565 | 590 | <a class="button button_strip_' . $key . (!empty($value['active']) ? ' active' : '') . (isset($value['class']) ? ' ' . $value['class'] : '') . '" ' . (!empty($value['url']) ? 'href="' . $value['url'] . '"' : '') . ' ' . (isset($value['custom']) ? ' ' . $value['custom'] : '') . '>' . $txt[$value['text']] . '</a>'; |
@@ -572,13 +597,15 @@ discard block |
||
572 | 597 | <div class="overview">'; |
573 | 598 | foreach ($value['sub_buttons'] as $element) |
574 | 599 | { |
575 | - if (isset($element['test']) && empty($context[$element['test']])) |
|
576 | - continue; |
|
600 | + if (isset($element['test']) && empty($context[$element['test']])) { |
|
601 | + continue; |
|
602 | + } |
|
577 | 603 | |
578 | 604 | $button .= ' |
579 | 605 | <a href="' . $element['url'] . '"><strong>' . $txt[$element['text']] . '</strong>'; |
580 | - if (isset($txt[$element['text'] . '_desc'])) |
|
581 | - $button .= '<br><span>' . $txt[$element['text'] . '_desc'] . '</span>'; |
|
606 | + if (isset($txt[$element['text'] . '_desc'])) { |
|
607 | + $button .= '<br><span>' . $txt[$element['text'] . '_desc'] . '</span>'; |
|
608 | + } |
|
582 | 609 | $button .= '</a>'; |
583 | 610 | } |
584 | 611 | $button .= ' |
@@ -592,8 +619,9 @@ discard block |
||
592 | 619 | } |
593 | 620 | |
594 | 621 | // No buttons? No button strip either. |
595 | - if (empty($buttons)) |
|
596 | - return; |
|
622 | + if (empty($buttons)) { |
|
623 | + return; |
|
624 | + } |
|
597 | 625 | |
598 | 626 | echo ' |
599 | 627 | <div class="buttonlist', !empty($direction) ? ' float' . $direction : '', '"', (empty($buttons) ? ' style="display: none;"' : ''), (!empty($strip_options['id']) ? ' id="' . $strip_options['id'] . '"' : ''), '> |
@@ -40,16 +40,14 @@ discard block |
||
40 | 40 | ', template_show_upcoming_list('main'), ' |
41 | 41 | </div> |
42 | 42 | '; |
43 | - } |
|
44 | - elseif ($context['calendar_view'] == 'viewweek') |
|
43 | + } elseif ($context['calendar_view'] == 'viewweek') |
|
45 | 44 | { |
46 | 45 | echo ' |
47 | 46 | <div id="main_grid"> |
48 | 47 | ', template_show_week_grid('main'), ' |
49 | 48 | </div> |
50 | 49 | '; |
51 | - } |
|
52 | - else |
|
50 | + } else |
|
53 | 51 | { |
54 | 52 | echo ' |
55 | 53 | <div id="main_grid"> |
@@ -75,8 +73,9 @@ discard block |
||
75 | 73 | global $context, $scripturl, $txt; |
76 | 74 | |
77 | 75 | // Bail out if we have nothing to work with |
78 | - if (!isset($context['calendar_grid_' . $grid_name])) |
|
79 | - return false; |
|
76 | + if (!isset($context['calendar_grid_' . $grid_name])) { |
|
77 | + return false; |
|
78 | + } |
|
80 | 79 | |
81 | 80 | // Protect programmer sanity |
82 | 81 | $calendar_data = &$context['calendar_grid_' . $grid_name]; |
@@ -113,11 +112,13 @@ discard block |
||
113 | 112 | <li class="windowbg"> |
114 | 113 | <strong class="event_title">', $event['link'], '</strong>'; |
115 | 114 | |
116 | - if ($event['can_edit']) |
|
117 | - echo ' <a href="' . $event['modify_href'] . '"><span class="generic_icons calendar_modify" title="', $txt['calendar_edit'], '"></span></a>'; |
|
115 | + if ($event['can_edit']) { |
|
116 | + echo ' <a href="' . $event['modify_href'] . '"><span class="generic_icons calendar_modify" title="', $txt['calendar_edit'], '"></span></a>'; |
|
117 | + } |
|
118 | 118 | |
119 | - if ($event['can_export']) |
|
120 | - echo ' <a href="' . $event['export_href'] . '"><span class="generic_icons calendar_export" title="', $txt['calendar_export'], '"></span></a>'; |
|
119 | + if ($event['can_export']) { |
|
120 | + echo ' <a href="' . $event['export_href'] . '"><span class="generic_icons calendar_export" title="', $txt['calendar_export'], '"></span></a>'; |
|
121 | + } |
|
121 | 122 | |
122 | 123 | echo ' |
123 | 124 | <br>'; |
@@ -125,14 +126,14 @@ discard block |
||
125 | 126 | if (!empty($event['allday'])) |
126 | 127 | { |
127 | 128 | echo '<time datetime="' . $event['start_iso_gmdate'] . '">', trim($event['start_date_local']), '</time>', ($event['start_date'] != $event['end_date']) ? ' – <time datetime="' . $event['end_iso_gmdate'] . '">' . trim($event['end_date_local']) . '</time>' : ''; |
128 | - } |
|
129 | - else |
|
129 | + } else |
|
130 | 130 | { |
131 | 131 | // Display event info relative to user's local timezone |
132 | 132 | echo '<time datetime="' . $event['start_iso_gmdate'] . '">', trim($event['start_date_local']), ', ', trim($event['start_time_local']), '</time> – <time datetime="' . $event['end_iso_gmdate'] . '">'; |
133 | 133 | |
134 | - if ($event['start_date_local'] != $event['end_date_local']) |
|
135 | - echo trim($event['end_date_local']) . ', '; |
|
134 | + if ($event['start_date_local'] != $event['end_date_local']) { |
|
135 | + echo trim($event['end_date_local']) . ', '; |
|
136 | + } |
|
136 | 137 | |
137 | 138 | echo trim($event['end_time_local']); |
138 | 139 | |
@@ -141,23 +142,27 @@ discard block |
||
141 | 142 | { |
142 | 143 | echo '</time> (<time datetime="' . $event['start_iso_gmdate'] . '">'; |
143 | 144 | |
144 | - if ($event['start_date_orig'] != $event['start_date_local'] || $event['end_date_orig'] != $event['end_date_local'] || $event['start_date_orig'] != $event['end_date_orig']) |
|
145 | - echo trim($event['start_date_orig']), ', '; |
|
145 | + if ($event['start_date_orig'] != $event['start_date_local'] || $event['end_date_orig'] != $event['end_date_local'] || $event['start_date_orig'] != $event['end_date_orig']) { |
|
146 | + echo trim($event['start_date_orig']), ', '; |
|
147 | + } |
|
146 | 148 | |
147 | 149 | echo trim($event['start_time_orig']), '</time> – <time datetime="' . $event['end_iso_gmdate'] . '">'; |
148 | 150 | |
149 | - if ($event['start_date_orig'] != $event['end_date_orig']) |
|
150 | - echo trim($event['end_date_orig']) . ', '; |
|
151 | + if ($event['start_date_orig'] != $event['end_date_orig']) { |
|
152 | + echo trim($event['end_date_orig']) . ', '; |
|
153 | + } |
|
151 | 154 | |
152 | 155 | echo trim($event['end_time_orig']), ' ', $event['tz_abbrev'], '</time>)'; |
153 | 156 | } |
154 | 157 | // Event is scheduled in the user's own timezone? Let 'em know, just to avoid confusion |
155 | - else |
|
156 | - echo ' ', $event['tz_abbrev'], '</time>'; |
|
158 | + else { |
|
159 | + echo ' ', $event['tz_abbrev'], '</time>'; |
|
160 | + } |
|
157 | 161 | } |
158 | 162 | |
159 | - if (!empty($event['location'])) |
|
160 | - echo '<br>', $event['location']; |
|
163 | + if (!empty($event['location'])) { |
|
164 | + echo '<br>', $event['location']; |
|
165 | + } |
|
161 | 166 | |
162 | 167 | echo ' |
163 | 168 | </li>'; |
@@ -189,8 +194,9 @@ discard block |
||
189 | 194 | |
190 | 195 | $birthdays = array(); |
191 | 196 | |
192 | - foreach ($date as $member) |
|
193 | - $birthdays[] = '<a href="' . $scripturl . '?action=profile;u=' . $member['id'] . '">' . $member['name'] . (isset($member['age']) ? ' (' . $member['age'] . ')' : '') . '</a>'; |
|
197 | + foreach ($date as $member) { |
|
198 | + $birthdays[] = '<a href="' . $scripturl . '?action=profile;u=' . $member['id'] . '">' . $member['name'] . (isset($member['age']) ? ' (' . $member['age'] . ')' : '') . '</a>'; |
|
199 | + } |
|
194 | 200 | |
195 | 201 | echo implode(', ', $birthdays); |
196 | 202 | |
@@ -221,8 +227,9 @@ discard block |
||
221 | 227 | $date_local = $date['date_local']; |
222 | 228 | unset($date['date_local']); |
223 | 229 | |
224 | - foreach ($date as $holiday) |
|
225 | - $holidays[] = $holiday . ' (' . $date_local . ')'; |
|
230 | + foreach ($date as $holiday) { |
|
231 | + $holidays[] = $holiday . ' (' . $date_local . ')'; |
|
232 | + } |
|
226 | 233 | } |
227 | 234 | |
228 | 235 | echo implode(', ', $holidays); |
@@ -245,17 +252,19 @@ discard block |
||
245 | 252 | global $context, $txt, $scripturl, $modSettings; |
246 | 253 | |
247 | 254 | // If the grid doesn't exist, no point in proceeding. |
248 | - if (!isset($context['calendar_grid_' . $grid_name])) |
|
249 | - return false; |
|
255 | + if (!isset($context['calendar_grid_' . $grid_name])) { |
|
256 | + return false; |
|
257 | + } |
|
250 | 258 | |
251 | 259 | // A handy little pointer variable. |
252 | 260 | $calendar_data = &$context['calendar_grid_' . $grid_name]; |
253 | 261 | |
254 | 262 | // Some conditions for whether or not we should show the week links *here*. |
255 | - if (isset($calendar_data['show_week_links']) && ($calendar_data['show_week_links'] == 3 || (($calendar_data['show_week_links'] == 1 && $is_mini === true) || $calendar_data['show_week_links'] == 2 && $is_mini === false))) |
|
256 | - $show_week_links = true; |
|
257 | - else |
|
258 | - $show_week_links = false; |
|
263 | + if (isset($calendar_data['show_week_links']) && ($calendar_data['show_week_links'] == 3 || (($calendar_data['show_week_links'] == 1 && $is_mini === true) || $calendar_data['show_week_links'] == 2 && $is_mini === false))) { |
|
264 | + $show_week_links = true; |
|
265 | + } else { |
|
266 | + $show_week_links = false; |
|
267 | + } |
|
259 | 268 | |
260 | 269 | // Assuming that we've not disabled it, show the title block! |
261 | 270 | if (empty($calendar_data['disable_title'])) |
@@ -294,8 +303,9 @@ discard block |
||
294 | 303 | } |
295 | 304 | |
296 | 305 | // Show the controls on main grids |
297 | - if ($is_mini === false) |
|
298 | - template_calendar_top($calendar_data); |
|
306 | + if ($is_mini === false) { |
|
307 | + template_calendar_top($calendar_data); |
|
308 | + } |
|
299 | 309 | |
300 | 310 | // Finally, the main calendar table. |
301 | 311 | echo '<table class="calendar_table">'; |
@@ -306,8 +316,9 @@ discard block |
||
306 | 316 | echo '<tr>'; |
307 | 317 | |
308 | 318 | // If we're showing week links, there's an extra column ahead of the week links, so let's think ahead and be prepared! |
309 | - if ($show_week_links === true) |
|
310 | - echo '<th> </th>'; |
|
319 | + if ($show_week_links === true) { |
|
320 | + echo '<th> </th>'; |
|
321 | + } |
|
311 | 322 | |
312 | 323 | // Now, loop through each actual day of the week. |
313 | 324 | foreach ($calendar_data['week_days'] as $day) |
@@ -354,27 +365,29 @@ discard block |
||
354 | 365 | // Additional classes are given for events, holidays, and birthdays. |
355 | 366 | if (!empty($day['events']) && !empty($calendar_data['highlight']['events'])) |
356 | 367 | { |
357 | - if ($is_mini === true && in_array($calendar_data['highlight']['events'], array(1, 3))) |
|
358 | - $classes[] = 'events'; |
|
359 | - elseif ($is_mini === false && in_array($calendar_data['highlight']['events'], array(2, 3))) |
|
360 | - $classes[] = 'events'; |
|
368 | + if ($is_mini === true && in_array($calendar_data['highlight']['events'], array(1, 3))) { |
|
369 | + $classes[] = 'events'; |
|
370 | + } elseif ($is_mini === false && in_array($calendar_data['highlight']['events'], array(2, 3))) { |
|
371 | + $classes[] = 'events'; |
|
372 | + } |
|
361 | 373 | } |
362 | 374 | if (!empty($day['holidays']) && !empty($calendar_data['highlight']['holidays'])) |
363 | 375 | { |
364 | - if ($is_mini === true && in_array($calendar_data['highlight']['holidays'], array(1, 3))) |
|
365 | - $classes[] = 'holidays'; |
|
366 | - elseif ($is_mini === false && in_array($calendar_data['highlight']['holidays'], array(2, 3))) |
|
367 | - $classes[] = 'holidays'; |
|
376 | + if ($is_mini === true && in_array($calendar_data['highlight']['holidays'], array(1, 3))) { |
|
377 | + $classes[] = 'holidays'; |
|
378 | + } elseif ($is_mini === false && in_array($calendar_data['highlight']['holidays'], array(2, 3))) { |
|
379 | + $classes[] = 'holidays'; |
|
380 | + } |
|
368 | 381 | } |
369 | 382 | if (!empty($day['birthdays']) && !empty($calendar_data['highlight']['birthdays'])) |
370 | 383 | { |
371 | - if ($is_mini === true && in_array($calendar_data['highlight']['birthdays'], array(1, 3))) |
|
372 | - $classes[] = 'birthdays'; |
|
373 | - elseif ($is_mini === false && in_array($calendar_data['highlight']['birthdays'], array(2, 3))) |
|
374 | - $classes[] = 'birthdays'; |
|
384 | + if ($is_mini === true && in_array($calendar_data['highlight']['birthdays'], array(1, 3))) { |
|
385 | + $classes[] = 'birthdays'; |
|
386 | + } elseif ($is_mini === false && in_array($calendar_data['highlight']['birthdays'], array(2, 3))) { |
|
387 | + $classes[] = 'birthdays'; |
|
388 | + } |
|
375 | 389 | } |
376 | - } |
|
377 | - else |
|
390 | + } else |
|
378 | 391 | { |
379 | 392 | // Default Classes (either compact or comfortable and disabled). |
380 | 393 | $classes[] = !empty($calendar_data['size']) && $calendar_data['size'] == 'small' ? 'compact' : 'comfortable'; |
@@ -392,19 +405,21 @@ discard block |
||
392 | 405 | $title_prefix = !empty($day['is_first_of_month']) && $context['current_month'] == $calendar_data['current_month'] && $is_mini === false ? (!empty($calendar_data['short_month_titles']) ? $txt['months_short'][$calendar_data['current_month']] . ' ' : $txt['months_titles'][$calendar_data['current_month']] . ' ') : ''; |
393 | 406 | |
394 | 407 | // The actual day number - be it a link, or just plain old text! |
395 | - if (!empty($modSettings['cal_daysaslink']) && $context['can_post']) |
|
396 | - echo '<a href="', $scripturl, '?action=calendar;sa=post;year=', $calendar_data['current_year'], ';month=', $calendar_data['current_month'], ';day=', $day['day'], ';', $context['session_var'], '=', $context['session_id'], '"><span class="day_text">', $title_prefix, $day['day'], '</span></a>'; |
|
397 | - elseif ($is_mini) |
|
398 | - echo '<a href="', $scripturl, '?action=calendar;', $context['calendar_view'], ';year=', $calendar_data['current_year'], ';month=', $calendar_data['current_month'], ';day=', $day['day'], '"><span class="day_text">', $title_prefix, $day['day'], '</span></a>'; |
|
399 | - else |
|
400 | - echo '<span class="day_text">', $title_prefix, $day['day'], '</span>'; |
|
408 | + if (!empty($modSettings['cal_daysaslink']) && $context['can_post']) { |
|
409 | + echo '<a href="', $scripturl, '?action=calendar;sa=post;year=', $calendar_data['current_year'], ';month=', $calendar_data['current_month'], ';day=', $day['day'], ';', $context['session_var'], '=', $context['session_id'], '"><span class="day_text">', $title_prefix, $day['day'], '</span></a>'; |
|
410 | + } elseif ($is_mini) { |
|
411 | + echo '<a href="', $scripturl, '?action=calendar;', $context['calendar_view'], ';year=', $calendar_data['current_year'], ';month=', $calendar_data['current_month'], ';day=', $day['day'], '"><span class="day_text">', $title_prefix, $day['day'], '</span></a>'; |
|
412 | + } else { |
|
413 | + echo '<span class="day_text">', $title_prefix, $day['day'], '</span>'; |
|
414 | + } |
|
401 | 415 | |
402 | 416 | // A lot of stuff, we're not showing on mini-calendars to conserve space. |
403 | 417 | if ($is_mini === false) |
404 | 418 | { |
405 | 419 | // Holidays are always fun, let's show them! |
406 | - if (!empty($day['holidays'])) |
|
407 | - echo '<div class="smalltext holiday"><span>', $txt['calendar_prompt'], '</span> ', implode(', ', $day['holidays']), '</div>'; |
|
420 | + if (!empty($day['holidays'])) { |
|
421 | + echo '<div class="smalltext holiday"><span>', $txt['calendar_prompt'], '</span> ', implode(', ', $day['holidays']), '</div>'; |
|
422 | + } |
|
408 | 423 | |
409 | 424 | // Happy Birthday Dear, Member! |
410 | 425 | if (!empty($day['birthdays'])) |
@@ -422,14 +437,16 @@ discard block |
||
422 | 437 | echo '<a href="', $scripturl, '?action=profile;u=', $member['id'], '"><span class="fix_rtl_names">', $member['name'], '</span>', isset($member['age']) ? ' (' . $member['age'] . ')' : '', '</a>', $member['is_last'] || ($count == 10 && $use_js_hide) ? '' : ', '; |
423 | 438 | |
424 | 439 | // 9...10! Let's stop there. |
425 | - if ($birthday_count == 10 && $use_js_hide) |
|
426 | - // !!TODO - Inline CSS and JavaScript should be moved. |
|
440 | + if ($birthday_count == 10 && $use_js_hide) { |
|
441 | + // !!TODO - Inline CSS and JavaScript should be moved. |
|
427 | 442 | echo '<span class="hidelink" id="bdhidelink_', $day['day'], '">...<br><a href="', $scripturl, '?action=calendar;month=', $calendar_data['current_month'], ';year=', $calendar_data['current_year'], ';showbd" onclick="document.getElementById(\'bdhide_', $day['day'], '\').style.display = \'\'; document.getElementById(\'bdhidelink_', $day['day'], '\').style.display = \'none\'; return false;">(', sprintf($txt['calendar_click_all'], count($day['birthdays'])), ')</a></span><span id="bdhide_', $day['day'], '" style="display: none;">, '; |
443 | + } |
|
428 | 444 | |
429 | 445 | ++$birthday_count; |
430 | 446 | } |
431 | - if ($use_js_hide) |
|
432 | - echo '</span>'; |
|
447 | + if ($use_js_hide) { |
|
448 | + echo '</span>'; |
|
449 | + } |
|
433 | 450 | |
434 | 451 | echo '</div>'; |
435 | 452 | } |
@@ -439,8 +456,9 @@ discard block |
||
439 | 456 | { |
440 | 457 | // Sort events by start time (all day events will be listed first) |
441 | 458 | uasort($day['events'], function($a, $b) { |
442 | - if ($a['start_timestamp'] == $b['start_timestamp']) |
|
443 | - return 0; |
|
459 | + if ($a['start_timestamp'] == $b['start_timestamp']) { |
|
460 | + return 0; |
|
461 | + } |
|
444 | 462 | return ($a['start_timestamp'] < $b['start_timestamp']) ? -1 : 1; |
445 | 463 | }); |
446 | 464 | |
@@ -456,17 +474,19 @@ discard block |
||
456 | 474 | |
457 | 475 | echo '<div class="event_wrapper', $event['starts_today'] == true ? ' event_starts_today' : '', $event['ends_today'] == true ? ' event_ends_today' : '', $event['allday'] == true ? ' allday' : '', $event['is_selected'] ? ' sel_event' : '', '">', $event['link'], '<br><span class="event_time', empty($event_icons_needed) ? ' floatright' : '', '">'; |
458 | 476 | |
459 | - if (!empty($event['start_time_local']) && $event['starts_today'] == true) |
|
460 | - echo trim(str_replace(':00 ', ' ', $event['start_time_local'])); |
|
461 | - elseif (!empty($event['end_time_local']) && $event['ends_today'] == true) |
|
462 | - echo strtolower($txt['ends']), ' ', trim(str_replace(':00 ', ' ', $event['end_time_local'])); |
|
463 | - elseif (!empty($event['allday'])) |
|
464 | - echo $txt['calendar_allday']; |
|
477 | + if (!empty($event['start_time_local']) && $event['starts_today'] == true) { |
|
478 | + echo trim(str_replace(':00 ', ' ', $event['start_time_local'])); |
|
479 | + } elseif (!empty($event['end_time_local']) && $event['ends_today'] == true) { |
|
480 | + echo strtolower($txt['ends']), ' ', trim(str_replace(':00 ', ' ', $event['end_time_local'])); |
|
481 | + } elseif (!empty($event['allday'])) { |
|
482 | + echo $txt['calendar_allday']; |
|
483 | + } |
|
465 | 484 | |
466 | 485 | echo '</span>'; |
467 | 486 | |
468 | - if (!empty($event['location'])) |
|
469 | - echo '<br><span class="event_location', empty($event_icons_needed) ? ' floatright' : '', '">' . $event['location'] . '</span>'; |
|
487 | + if (!empty($event['location'])) { |
|
488 | + echo '<br><span class="event_location', empty($event_icons_needed) ? ' floatright' : '', '">' . $event['location'] . '</span>'; |
|
489 | + } |
|
470 | 490 | |
471 | 491 | if ($event['can_edit'] || $event['can_export']) |
472 | 492 | { |
@@ -503,10 +523,11 @@ discard block |
||
503 | 523 | // Otherwise, assuming it's not a mini-calendar, we can show previous / next month days! |
504 | 524 | elseif ($is_mini === false) |
505 | 525 | { |
506 | - if (empty($current_month_started) && !empty($context['calendar_grid_prev'])) |
|
507 | - echo '<a href="', $scripturl, '?action=calendar;year=', $context['calendar_grid_prev']['current_year'], ';month=', $context['calendar_grid_prev']['current_month'], '">', $context['calendar_grid_prev']['last_of_month'] - $calendar_data['shift']-- +1, '</a>'; |
|
508 | - elseif (!empty($current_month_started) && !empty($context['calendar_grid_next'])) |
|
509 | - echo '<a href="', $scripturl, '?action=calendar;year=', $context['calendar_grid_next']['current_year'], ';month=', $context['calendar_grid_next']['current_month'], '">', $current_month_started + 1 == $count ? (!empty($calendar_data['short_month_titles']) ? $txt['months_short'][$context['calendar_grid_next']['current_month']] . ' ' : $txt['months_titles'][$context['calendar_grid_next']['current_month']] . ' ') : '', $final_count++, '</a>'; |
|
526 | + if (empty($current_month_started) && !empty($context['calendar_grid_prev'])) { |
|
527 | + echo '<a href="', $scripturl, '?action=calendar;year=', $context['calendar_grid_prev']['current_year'], ';month=', $context['calendar_grid_prev']['current_month'], '">', $context['calendar_grid_prev']['last_of_month'] - $calendar_data['shift']-- +1, '</a>'; |
|
528 | + } elseif (!empty($current_month_started) && !empty($context['calendar_grid_next'])) { |
|
529 | + echo '<a href="', $scripturl, '?action=calendar;year=', $context['calendar_grid_next']['current_year'], ';month=', $context['calendar_grid_next']['current_month'], '">', $current_month_started + 1 == $count ? (!empty($calendar_data['short_month_titles']) ? $txt['months_short'][$context['calendar_grid_next']['current_month']] . ' ' : $txt['months_titles'][$context['calendar_grid_next']['current_month']] . ' ') : '', $final_count++, '</a>'; |
|
530 | + } |
|
510 | 531 | } |
511 | 532 | |
512 | 533 | // Close this day and increase var count. |
@@ -532,8 +553,9 @@ discard block |
||
532 | 553 | global $context, $txt, $scripturl, $modSettings; |
533 | 554 | |
534 | 555 | // We might have no reason to proceed, if the variable isn't there. |
535 | - if (!isset($context['calendar_grid_' . $grid_name])) |
|
536 | - return false; |
|
556 | + if (!isset($context['calendar_grid_' . $grid_name])) { |
|
557 | + return false; |
|
558 | + } |
|
537 | 559 | |
538 | 560 | // Handy pointer. |
539 | 561 | $calendar_data = &$context['calendar_grid_' . $grid_name]; |
@@ -568,8 +590,9 @@ discard block |
||
568 | 590 | } |
569 | 591 | |
570 | 592 | // The Month Title + Week Number... |
571 | - if (!empty($calendar_data['week_title'])) |
|
572 | - echo $calendar_data['week_title']; |
|
593 | + if (!empty($calendar_data['week_title'])) { |
|
594 | + echo $calendar_data['week_title']; |
|
595 | + } |
|
573 | 596 | |
574 | 597 | echo ' |
575 | 598 | </h3> |
@@ -608,10 +631,11 @@ discard block |
||
608 | 631 | <tr class="days_wrapper"> |
609 | 632 | <td class="', implode(' ', $classes), ' act_day">'; |
610 | 633 | // Should the day number be a link? |
611 | - if (!empty($modSettings['cal_daysaslink']) && $context['can_post']) |
|
612 | - echo '<a href="', $scripturl, '?action=calendar;sa=post;month=', $month_data['current_month'], ';year=', $month_data['current_year'], ';day=', $day['day'], ';', $context['session_var'], '=', $context['session_id'], '">', $txt['days'][$day['day_of_week']], ' - ', $day['day'], '</a>'; |
|
613 | - else |
|
614 | - echo $txt['days'][$day['day_of_week']], ' - ', $day['day']; |
|
634 | + if (!empty($modSettings['cal_daysaslink']) && $context['can_post']) { |
|
635 | + echo '<a href="', $scripturl, '?action=calendar;sa=post;month=', $month_data['current_month'], ';year=', $month_data['current_year'], ';day=', $day['day'], ';', $context['session_var'], '=', $context['session_id'], '">', $txt['days'][$day['day_of_week']], ' - ', $day['day'], '</a>'; |
|
636 | + } else { |
|
637 | + echo $txt['days'][$day['day_of_week']], ' - ', $day['day']; |
|
638 | + } |
|
615 | 639 | |
616 | 640 | echo '</td> |
617 | 641 | <td class="', implode(' ', $classes), '', empty($day['events']) ? (' disabled' . ($context['can_post'] ? ' week_post' : '')) : ' events', ' event_col" data-css-prefix="' . $txt['events'] . ' ', (empty($day['events']) && empty($context['can_post'])) ? $txt['none'] : '', '">'; |
@@ -620,8 +644,9 @@ discard block |
||
620 | 644 | { |
621 | 645 | // Sort events by start time (all day events will be listed first) |
622 | 646 | uasort($day['events'], function($a, $b) { |
623 | - if ($a['start_timestamp'] == $b['start_timestamp']) |
|
624 | - return 0; |
|
647 | + if ($a['start_timestamp'] == $b['start_timestamp']) { |
|
648 | + return 0; |
|
649 | + } |
|
625 | 650 | return ($a['start_timestamp'] < $b['start_timestamp']) ? -1 : 1; |
626 | 651 | }); |
627 | 652 | |
@@ -633,15 +658,17 @@ discard block |
||
633 | 658 | |
634 | 659 | echo $event['link'], '<br><span class="event_time', empty($event_icons_needed) ? ' floatright' : '', '">'; |
635 | 660 | |
636 | - if (!empty($event['start_time_local'])) |
|
637 | - echo trim($event['start_time_local']), !empty($event['end_time_local']) ? ' – ' . trim($event['end_time_local']) : ''; |
|
638 | - else |
|
639 | - echo $txt['calendar_allday']; |
|
661 | + if (!empty($event['start_time_local'])) { |
|
662 | + echo trim($event['start_time_local']), !empty($event['end_time_local']) ? ' – ' . trim($event['end_time_local']) : ''; |
|
663 | + } else { |
|
664 | + echo $txt['calendar_allday']; |
|
665 | + } |
|
640 | 666 | |
641 | 667 | echo '</span>'; |
642 | 668 | |
643 | - if (!empty($event['location'])) |
|
644 | - echo '<br><span class="event_location', empty($event_icons_needed) ? ' floatright' : '', '">' . $event['location'] . '</span>'; |
|
669 | + if (!empty($event['location'])) { |
|
670 | + echo '<br><span class="event_location', empty($event_icons_needed) ? ' floatright' : '', '">' . $event['location'] . '</span>'; |
|
671 | + } |
|
645 | 672 | |
646 | 673 | if (!empty($event_icons_needed)) |
647 | 674 | { |
@@ -678,8 +705,7 @@ discard block |
||
678 | 705 | </div> |
679 | 706 | <br class="clear">'; |
680 | 707 | } |
681 | - } |
|
682 | - else |
|
708 | + } else |
|
683 | 709 | { |
684 | 710 | if (!empty($context['can_post'])) |
685 | 711 | { |
@@ -692,8 +718,9 @@ discard block |
||
692 | 718 | echo '</td> |
693 | 719 | <td class="', implode(' ', $classes), !empty($day['holidays']) ? ' holidays' : ' disabled', ' holiday_col" data-css-prefix="' . $txt['calendar_prompt'] . ' ">'; |
694 | 720 | // Show any holidays! |
695 | - if (!empty($day['holidays'])) |
|
696 | - echo implode('<br>', $day['holidays']); |
|
721 | + if (!empty($day['holidays'])) { |
|
722 | + echo implode('<br>', $day['holidays']); |
|
723 | + } |
|
697 | 724 | |
698 | 725 | echo '</td> |
699 | 726 | <td class="', implode(' ', $classes), '', !empty($day['birthdays']) ? ' birthdays' : ' disabled', ' birthday_col" data-css-prefix="' . $txt['birthdays'] . ' ">'; |
@@ -751,8 +778,7 @@ discard block |
||
751 | 778 | <input type="text" name="end_date" id="end_date" maxlength="10" value="', $calendar_data['end_date'], '" tabindex="', $context['tabindex']++, '" class="date_input end" data-type="date"> |
752 | 779 | <input type="submit" class="button" style="float:none" id="view_button" value="', $txt['view'], '"> |
753 | 780 | </form>'; |
754 | - } |
|
755 | - else |
|
781 | + } else |
|
756 | 782 | { |
757 | 783 | echo' |
758 | 784 | <form action="', $scripturl, '?action=calendar" id="calendar_navigation" method="post" accept-charset="', $context['character_set'], '"> |
@@ -794,8 +820,9 @@ discard block |
||
794 | 820 | echo ' |
795 | 821 | <form action="', $scripturl, '?action=calendar;sa=post" method="post" name="postevent" accept-charset="', $context['character_set'], '" onsubmit="submitonce(this);smc_saveEntities(\'postevent\', [\'evtitle\']);" style="margin: 0;">'; |
796 | 822 | |
797 | - if (!empty($context['event']['new'])) |
|
798 | - echo '<input type="hidden" name="eventid" value="', $context['event']['eventid'], '">'; |
|
823 | + if (!empty($context['event']['new'])) { |
|
824 | + echo '<input type="hidden" name="eventid" value="', $context['event']['eventid'], '">'; |
|
825 | + } |
|
799 | 826 | |
800 | 827 | // Start the main table. |
801 | 828 | echo ' |
@@ -845,9 +872,10 @@ discard block |
||
845 | 872 | { |
846 | 873 | echo ' |
847 | 874 | <optgroup label="', $category['name'], '">'; |
848 | - foreach ($category['boards'] as $board) |
|
849 | - echo ' |
|
875 | + foreach ($category['boards'] as $board) { |
|
876 | + echo ' |
|
850 | 877 | <option value="', $board['id'], '"', $board['selected'] ? ' selected' : '', '>', $board['child_level'] > 0 ? str_repeat('==', $board['child_level'] - 1) . '=>' : '', ' ', $board['name'], ' </option>'; |
878 | + } |
|
851 | 879 | echo ' |
852 | 880 | </optgroup>'; |
853 | 881 | } |
@@ -883,9 +911,10 @@ discard block |
||
883 | 911 | <span class="label">', $txt['calendar_timezone'], '</span> |
884 | 912 | <select name="tz" id="tz"', !empty($context['event']['allday']) ? ' disabled' : '', '>'; |
885 | 913 | |
886 | - foreach ($context['all_timezones'] as $tz => $tzname) |
|
887 | - echo ' |
|
914 | + foreach ($context['all_timezones'] as $tz => $tzname) { |
|
915 | + echo ' |
|
888 | 916 | <option value="', $tz, '"', $tz == $context['event']['tz'] ? ' selected' : '', '>', $tzname, '</option>'; |
917 | + } |
|
889 | 918 | |
890 | 919 | echo ' |
891 | 920 | </select> |
@@ -900,9 +929,10 @@ discard block |
||
900 | 929 | echo ' |
901 | 930 | <input type="submit" value="', empty($context['event']['new']) ? $txt['save'] : $txt['post'], '" class="button">'; |
902 | 931 | // Delete button? |
903 | - if (empty($context['event']['new'])) |
|
904 | - echo ' |
|
932 | + if (empty($context['event']['new'])) { |
|
933 | + echo ' |
|
905 | 934 | <input type="submit" name="deleteevent" value="', $txt['event_delete'], '" data-confirm="', $txt['calendar_confirm_delete'], '" class="button you_sure">'; |
935 | + } |
|
906 | 936 | |
907 | 937 | echo ' |
908 | 938 | <input type="hidden" name="', $context['session_var'], '" value="', $context['session_id'], '"> |
@@ -946,9 +976,10 @@ discard block |
||
946 | 976 | |
947 | 977 | foreach ($context['clockicons'] as $t => $v) |
948 | 978 | { |
949 | - foreach ($v as $i) |
|
950 | - echo ' |
|
979 | + foreach ($v as $i) { |
|
980 | + echo ' |
|
951 | 981 | icons[\'', $t, '_', $i, '\'] = document.getElementById(\'', $t, '_', $i, '\');'; |
982 | + } |
|
952 | 983 | } |
953 | 984 | |
954 | 985 | echo ' |
@@ -973,13 +1004,14 @@ discard block |
||
973 | 1004 | |
974 | 1005 | foreach ($context['clockicons'] as $t => $v) |
975 | 1006 | { |
976 | - foreach ($v as $i) |
|
977 | - echo ' |
|
1007 | + foreach ($v as $i) { |
|
1008 | + echo ' |
|
978 | 1009 | if (', $t, ' >= ', $i, ') |
979 | 1010 | { |
980 | 1011 | turnon.push("', $t, '_', $i, '"); |
981 | 1012 | ', $t, ' -= ', $i, '; |
982 | 1013 | }'; |
1014 | + } |
|
983 | 1015 | } |
984 | 1016 | |
985 | 1017 | echo ' |
@@ -1043,9 +1075,10 @@ discard block |
||
1043 | 1075 | |
1044 | 1076 | foreach ($context['clockicons'] as $t => $v) |
1045 | 1077 | { |
1046 | - foreach ($v as $i) |
|
1047 | - echo ' |
|
1078 | + foreach ($v as $i) { |
|
1079 | + echo ' |
|
1048 | 1080 | icons[\'', $t, '_', $i, '\'] = document.getElementById(\'', $t, '_', $i, '\');'; |
1081 | + } |
|
1049 | 1082 | } |
1050 | 1083 | |
1051 | 1084 | echo ' |
@@ -1062,13 +1095,14 @@ discard block |
||
1062 | 1095 | |
1063 | 1096 | foreach ($context['clockicons'] as $t => $v) |
1064 | 1097 | { |
1065 | - foreach ($v as $i) |
|
1066 | - echo ' |
|
1098 | + foreach ($v as $i) { |
|
1099 | + echo ' |
|
1067 | 1100 | if (', $t, ' >= ', $i, ') |
1068 | 1101 | { |
1069 | 1102 | turnon.push("', $t, '_', $i, '"); |
1070 | 1103 | ', $t, ' -= ', $i, '; |
1071 | 1104 | }'; |
1105 | + } |
|
1072 | 1106 | } |
1073 | 1107 | |
1074 | 1108 | echo ' |
@@ -1127,9 +1161,10 @@ discard block |
||
1127 | 1161 | |
1128 | 1162 | foreach ($context['clockicons'] as $t => $v) |
1129 | 1163 | { |
1130 | - foreach ($v as $i) |
|
1131 | - echo ' |
|
1164 | + foreach ($v as $i) { |
|
1165 | + echo ' |
|
1132 | 1166 | icons[\'', $t, '_', $i, '\'] = document.getElementById(\'', $t, '_', $i, '\');'; |
1167 | + } |
|
1133 | 1168 | } |
1134 | 1169 | |
1135 | 1170 | echo ' |
@@ -1150,13 +1185,14 @@ discard block |
||
1150 | 1185 | |
1151 | 1186 | foreach ($context['clockicons'] as $t => $v) |
1152 | 1187 | { |
1153 | - foreach ($v as $i) |
|
1154 | - echo ' |
|
1188 | + foreach ($v as $i) { |
|
1189 | + echo ' |
|
1155 | 1190 | if (', $t, ' >= ', $i, ') |
1156 | 1191 | { |
1157 | 1192 | turnon.push("', $t, '_', $i, '"); |
1158 | 1193 | ', $t, ' -= ', $i, '; |
1159 | 1194 | }'; |
1195 | + } |
|
1160 | 1196 | } |
1161 | 1197 | |
1162 | 1198 | echo ' |
@@ -51,11 +51,13 @@ discard block |
||
51 | 51 | <p>'; |
52 | 52 | |
53 | 53 | // Show just numbers...? |
54 | - if ($settings['display_who_viewing'] == 1) |
|
55 | - echo count($context['view_members']), ' ', count($context['view_members']) == 1 ? $txt['who_member'] : $txt['members']; |
|
54 | + if ($settings['display_who_viewing'] == 1) { |
|
55 | + echo count($context['view_members']), ' ', count($context['view_members']) == 1 ? $txt['who_member'] : $txt['members']; |
|
56 | + } |
|
56 | 57 | // Or show the actual people viewing the topic? |
57 | - else |
|
58 | - echo empty($context['view_members_list']) ? '0 ' . $txt['members'] : implode(', ', $context['view_members_list']) . ((empty($context['view_num_hidden']) || $context['can_moderate_forum']) ? '' : ' (+ ' . $context['view_num_hidden'] . ' ' . $txt['hidden'] . ')'); |
|
58 | + else { |
|
59 | + echo empty($context['view_members_list']) ? '0 ' . $txt['members'] : implode(', ', $context['view_members_list']) . ((empty($context['view_num_hidden']) || $context['can_moderate_forum']) ? '' : ' (+ ' . $context['view_num_hidden'] . ' ' . $txt['hidden'] . ')'); |
|
60 | + } |
|
59 | 61 | |
60 | 62 | // Now show how many guests are here too. |
61 | 63 | echo $txt['who_and'], $context['view_num_guests'], ' ', $context['view_num_guests'] == 1 ? $txt['guest'] : $txt['guests'], $txt['who_viewing_topic'], ' |
@@ -93,10 +95,11 @@ discard block |
||
93 | 95 | <dt class="', $option['voted_this'] ? ' voted' : '', '">', $option['option'], '</dt> |
94 | 96 | <dd class="statsbar', $option['voted_this'] ? ' voted' : '', '">'; |
95 | 97 | |
96 | - if ($context['allow_results_view']) |
|
97 | - echo ' |
|
98 | + if ($context['allow_results_view']) { |
|
99 | + echo ' |
|
98 | 100 | ', $option['bar_ndt'], ' |
99 | 101 | <span class="percentage">', $option['votes'], ' (', $option['percent'], '%)</span>'; |
102 | + } |
|
100 | 103 | |
101 | 104 | echo ' |
102 | 105 | </dd>'; |
@@ -105,9 +108,10 @@ discard block |
||
105 | 108 | echo ' |
106 | 109 | </dl>'; |
107 | 110 | |
108 | - if ($context['allow_results_view']) |
|
109 | - echo ' |
|
111 | + if ($context['allow_results_view']) { |
|
112 | + echo ' |
|
110 | 113 | <p><strong>', $txt['poll_total_voters'], ':</strong> ', $context['poll']['total_votes'], '</p>'; |
114 | + } |
|
111 | 115 | } |
112 | 116 | // They are allowed to vote! Go to it! |
113 | 117 | else |
@@ -116,17 +120,19 @@ discard block |
||
116 | 120 | <form action="', $scripturl, '?action=vote;topic=', $context['current_topic'], '.', $context['start'], ';poll=', $context['poll']['id'], '" method="post" accept-charset="', $context['character_set'], '">'; |
117 | 121 | |
118 | 122 | // Show a warning if they are allowed more than one option. |
119 | - if ($context['poll']['allowed_warning']) |
|
120 | - echo ' |
|
123 | + if ($context['poll']['allowed_warning']) { |
|
124 | + echo ' |
|
121 | 125 | <p class="smallpadding">', $context['poll']['allowed_warning'], '</p>'; |
126 | + } |
|
122 | 127 | |
123 | 128 | echo ' |
124 | 129 | <ul class="options">'; |
125 | 130 | |
126 | 131 | // Show each option with its button - a radio likely. |
127 | - foreach ($context['poll']['options'] as $option) |
|
128 | - echo ' |
|
132 | + foreach ($context['poll']['options'] as $option) { |
|
133 | + echo ' |
|
129 | 134 | <li>', $option['vote_button'], ' <label for="', $option['id'], '">', $option['option'], '</label></li>'; |
135 | + } |
|
130 | 136 | |
131 | 137 | echo ' |
132 | 138 | </ul> |
@@ -138,9 +144,10 @@ discard block |
||
138 | 144 | } |
139 | 145 | |
140 | 146 | // Is the clock ticking? |
141 | - if (!empty($context['poll']['expire_time'])) |
|
142 | - echo ' |
|
147 | + if (!empty($context['poll']['expire_time'])) { |
|
148 | + echo ' |
|
143 | 149 | <p><strong>', ($context['poll']['is_expired'] ? $txt['poll_expired_on'] : $txt['poll_expires_on']), ':</strong> ', $context['poll']['expire_time'], '</p>'; |
150 | + } |
|
144 | 151 | |
145 | 152 | echo ' |
146 | 153 | </div> |
@@ -170,11 +177,13 @@ discard block |
||
170 | 177 | <li> |
171 | 178 | <strong class="event_title"><a href="', $scripturl, '?action=calendar;event=', $event['id'], '">', $event['title'], '</a></strong>'; |
172 | 179 | |
173 | - if ($event['can_edit']) |
|
174 | - echo ' <a href="' . $event['modify_href'] . '"><span class="generic_icons calendar_modify" title="', $txt['calendar_edit'], '"></span></a>'; |
|
180 | + if ($event['can_edit']) { |
|
181 | + echo ' <a href="' . $event['modify_href'] . '"><span class="generic_icons calendar_modify" title="', $txt['calendar_edit'], '"></span></a>'; |
|
182 | + } |
|
175 | 183 | |
176 | - if ($event['can_export']) |
|
177 | - echo ' <a href="' . $event['export_href'] . '"><span class="generic_icons calendar_export" title="', $txt['calendar_export'], '"></span></a>'; |
|
184 | + if ($event['can_export']) { |
|
185 | + echo ' <a href="' . $event['export_href'] . '"><span class="generic_icons calendar_export" title="', $txt['calendar_export'], '"></span></a>'; |
|
186 | + } |
|
178 | 187 | |
179 | 188 | echo ' |
180 | 189 | <br>'; |
@@ -182,14 +191,14 @@ discard block |
||
182 | 191 | if (!empty($event['allday'])) |
183 | 192 | { |
184 | 193 | echo '<time datetime="' . $event['start_iso_gmdate'] . '">', trim($event['start_date_local']), '</time>', ($event['start_date'] != $event['end_date']) ? ' – <time datetime="' . $event['end_iso_gmdate'] . '">' . trim($event['end_date_local']) . '</time>' : ''; |
185 | - } |
|
186 | - else |
|
194 | + } else |
|
187 | 195 | { |
188 | 196 | // Display event info relative to user's local timezone |
189 | 197 | echo '<time datetime="' . $event['start_iso_gmdate'] . '">', trim($event['start_date_local']), ', ', trim($event['start_time_local']), '</time> – <time datetime="' . $event['end_iso_gmdate'] . '">'; |
190 | 198 | |
191 | - if ($event['start_date_local'] != $event['end_date_local']) |
|
192 | - echo trim($event['end_date_local']) . ', '; |
|
199 | + if ($event['start_date_local'] != $event['end_date_local']) { |
|
200 | + echo trim($event['end_date_local']) . ', '; |
|
201 | + } |
|
193 | 202 | |
194 | 203 | echo trim($event['end_time_local']); |
195 | 204 | |
@@ -198,23 +207,27 @@ discard block |
||
198 | 207 | { |
199 | 208 | echo '</time> (<time datetime="' . $event['start_iso_gmdate'] . '">'; |
200 | 209 | |
201 | - if ($event['start_date_orig'] != $event['start_date_local'] || $event['end_date_orig'] != $event['end_date_local'] || $event['start_date_orig'] != $event['end_date_orig']) |
|
202 | - echo trim($event['start_date_orig']), ', '; |
|
210 | + if ($event['start_date_orig'] != $event['start_date_local'] || $event['end_date_orig'] != $event['end_date_local'] || $event['start_date_orig'] != $event['end_date_orig']) { |
|
211 | + echo trim($event['start_date_orig']), ', '; |
|
212 | + } |
|
203 | 213 | |
204 | 214 | echo trim($event['start_time_orig']), '</time> – <time datetime="' . $event['end_iso_gmdate'] . '">'; |
205 | 215 | |
206 | - if ($event['start_date_orig'] != $event['end_date_orig']) |
|
207 | - echo trim($event['end_date_orig']) . ', '; |
|
216 | + if ($event['start_date_orig'] != $event['end_date_orig']) { |
|
217 | + echo trim($event['end_date_orig']) . ', '; |
|
218 | + } |
|
208 | 219 | |
209 | 220 | echo trim($event['end_time_orig']), ' ', $event['tz_abbrev'], '</time>)'; |
210 | 221 | } |
211 | 222 | // Event is scheduled in the user's own timezone? Let 'em know, just to avoid confusion |
212 | - else |
|
213 | - echo ' ', $event['tz_abbrev'], '</time>'; |
|
223 | + else { |
|
224 | + echo ' ', $event['tz_abbrev'], '</time>'; |
|
225 | + } |
|
214 | 226 | } |
215 | 227 | |
216 | - if (!empty($event['location'])) |
|
217 | - echo '<br>', $event['location']; |
|
228 | + if (!empty($event['location'])) { |
|
229 | + echo '<br>', $event['location']; |
|
230 | + } |
|
218 | 231 | |
219 | 232 | echo ' |
220 | 233 | </li>'; |
@@ -253,8 +266,9 @@ discard block |
||
253 | 266 | $context['removableMessageIDs'] = array(); |
254 | 267 | |
255 | 268 | // Get all the messages... |
256 | - while ($message = $context['get_message']()) |
|
257 | - template_single_post($message); |
|
269 | + while ($message = $context['get_message']()) { |
|
270 | + template_single_post($message); |
|
271 | + } |
|
258 | 272 | |
259 | 273 | echo ' |
260 | 274 | </form> |
@@ -292,8 +306,9 @@ discard block |
||
292 | 306 | <div id="display_jump_to"> </div>'; |
293 | 307 | |
294 | 308 | // Show quickreply |
295 | - if ($context['can_reply']) |
|
296 | - template_quickreply(); |
|
309 | + if ($context['can_reply']) { |
|
310 | + template_quickreply(); |
|
311 | + } |
|
297 | 312 | |
298 | 313 | // User action pop on mobile screen (or actually small screen), this uses responsive css does not check mobile device. |
299 | 314 | echo ' |
@@ -306,8 +321,8 @@ discard block |
||
306 | 321 | </div>'; |
307 | 322 | |
308 | 323 | // Show the moderation button & pop only if user can moderate |
309 | - if ($context['can_moderate_forum'] || $context['user']['is_mod']) |
|
310 | - echo ' |
|
324 | + if ($context['can_moderate_forum'] || $context['user']['is_mod']) { |
|
325 | + echo ' |
|
311 | 326 | <div id="mobile_moderation" class="popup_container"> |
312 | 327 | <div class="popup_window description"> |
313 | 328 | <div class="popup_heading">', $txt['mobile_moderation'], ' |
@@ -317,6 +332,7 @@ discard block |
||
317 | 332 | </div> |
318 | 333 | </div> |
319 | 334 | </div>'; |
335 | + } |
|
320 | 336 | |
321 | 337 | echo ' |
322 | 338 | <script>'; |
@@ -440,9 +456,10 @@ discard block |
||
440 | 456 | }); |
441 | 457 | }'; |
442 | 458 | |
443 | - if (!empty($context['ignoredMsgs'])) |
|
444 | - echo ' |
|
459 | + if (!empty($context['ignoredMsgs'])) { |
|
460 | + echo ' |
|
445 | 461 | ignore_toggles([', implode(', ', $context['ignoredMsgs']), '], ', JavaScriptEscape($txt['show_ignore_user_post']), ');'; |
462 | + } |
|
446 | 463 | |
447 | 464 | echo ' |
448 | 465 | </script>'; |
@@ -459,8 +476,9 @@ discard block |
||
459 | 476 | |
460 | 477 | $ignoring = false; |
461 | 478 | |
462 | - if ($message['can_remove']) |
|
463 | - $context['removableMessageIDs'][] = $message['id']; |
|
479 | + if ($message['can_remove']) { |
|
480 | + $context['removableMessageIDs'][] = $message['id']; |
|
481 | + } |
|
464 | 482 | |
465 | 483 | // Are we ignoring this message? |
466 | 484 | if (!empty($message['is_ignored'])) |
@@ -486,9 +504,10 @@ discard block |
||
486 | 504 | <div class="custom_fields_above_member"> |
487 | 505 | <ul class="nolist">'; |
488 | 506 | |
489 | - foreach ($message['custom_fields']['above_member'] as $custom) |
|
490 | - echo ' |
|
507 | + foreach ($message['custom_fields']['above_member'] as $custom) { |
|
508 | + echo ' |
|
491 | 509 | <li class="custom ', $custom['col_name'], '">', $custom['value'], '</li>'; |
510 | + } |
|
492 | 511 | |
493 | 512 | echo ' |
494 | 513 | </ul> |
@@ -499,9 +518,10 @@ discard block |
||
499 | 518 | <h4>'; |
500 | 519 | |
501 | 520 | // Show online and offline buttons? |
502 | - if (!empty($modSettings['onlineEnable']) && !$message['member']['is_guest']) |
|
503 | - echo ' |
|
521 | + if (!empty($modSettings['onlineEnable']) && !$message['member']['is_guest']) { |
|
522 | + echo ' |
|
504 | 523 | ', $context['can_send_pm'] ? '<a href="' . $message['member']['online']['href'] . '" title="' . $message['member']['online']['label'] . '">' : '', '<span class="' . ($message['member']['online']['is_online'] == 1 ? 'on' : 'off') . '" title="' . $message['member']['online']['text'] . '"></span>', $context['can_send_pm'] ? '</a>' : ''; |
524 | + } |
|
505 | 525 | |
506 | 526 | |
507 | 527 | // Show a link to the member's profile. |
@@ -514,51 +534,59 @@ discard block |
||
514 | 534 | |
515 | 535 | |
516 | 536 | // Show the user's avatar. |
517 | - if (!empty($modSettings['show_user_images']) && empty($options['show_no_avatars']) && !empty($message['member']['avatar']['image'])) |
|
518 | - echo ' |
|
537 | + if (!empty($modSettings['show_user_images']) && empty($options['show_no_avatars']) && !empty($message['member']['avatar']['image'])) { |
|
538 | + echo ' |
|
519 | 539 | <li class="avatar"> |
520 | 540 | <a href="', $message['member']['href'], '">', $message['member']['avatar']['image'], '</a> |
521 | 541 | </li>'; |
542 | + } |
|
522 | 543 | |
523 | 544 | // Are there any custom fields below the avatar? |
524 | - if (!empty($message['custom_fields']['below_avatar'])) |
|
525 | - foreach ($message['custom_fields']['below_avatar'] as $custom) |
|
545 | + if (!empty($message['custom_fields']['below_avatar'])) { |
|
546 | + foreach ($message['custom_fields']['below_avatar'] as $custom) |
|
526 | 547 | echo ' |
527 | 548 | <li class="custom ', $custom['col_name'], '">', $custom['value'], '</li>'; |
549 | + } |
|
528 | 550 | |
529 | 551 | // Show the post group icons, but not for guests. |
530 | - if (!$message['member']['is_guest']) |
|
531 | - echo ' |
|
552 | + if (!$message['member']['is_guest']) { |
|
553 | + echo ' |
|
532 | 554 | <li class="icons">', $message['member']['group_icons'], '</li>'; |
555 | + } |
|
533 | 556 | |
534 | 557 | // Show the member's primary group (like 'Administrator') if they have one. |
535 | - if (!empty($message['member']['group'])) |
|
536 | - echo ' |
|
558 | + if (!empty($message['member']['group'])) { |
|
559 | + echo ' |
|
537 | 560 | <li class="membergroup">', $message['member']['group'], '</li>'; |
561 | + } |
|
538 | 562 | |
539 | 563 | // Show the member's custom title, if they have one. |
540 | - if (!empty($message['member']['title'])) |
|
541 | - echo ' |
|
564 | + if (!empty($message['member']['title'])) { |
|
565 | + echo ' |
|
542 | 566 | <li class="title">', $message['member']['title'], '</li>'; |
567 | + } |
|
543 | 568 | |
544 | 569 | // Don't show these things for guests. |
545 | 570 | if (!$message['member']['is_guest']) |
546 | 571 | { |
547 | 572 | |
548 | 573 | // Show the post group if and only if they have no other group or the option is on, and they are in a post group. |
549 | - if ((empty($modSettings['hide_post_group']) || empty($message['member']['group'])) && !empty($message['member']['post_group'])) |
|
550 | - echo ' |
|
574 | + if ((empty($modSettings['hide_post_group']) || empty($message['member']['group'])) && !empty($message['member']['post_group'])) { |
|
575 | + echo ' |
|
551 | 576 | <li class="postgroup">', $message['member']['post_group'], '</li>'; |
577 | + } |
|
552 | 578 | |
553 | 579 | // Show how many posts they have made. |
554 | - if (!isset($context['disabled_fields']['posts'])) |
|
555 | - echo ' |
|
580 | + if (!isset($context['disabled_fields']['posts'])) { |
|
581 | + echo ' |
|
556 | 582 | <li class="postcount">', $txt['member_postcount'], ': ', $message['member']['posts'], '</li>'; |
583 | + } |
|
557 | 584 | |
558 | 585 | // Show their personal text? |
559 | - if (!empty($modSettings['show_blurb']) && !empty($message['member']['blurb'])) |
|
560 | - echo ' |
|
586 | + if (!empty($modSettings['show_blurb']) && !empty($message['member']['blurb'])) { |
|
587 | + echo ' |
|
561 | 588 | <li class="blurb">', $message['member']['blurb'], '</li>'; |
589 | + } |
|
562 | 590 | |
563 | 591 | // Any custom fields to show as icons? |
564 | 592 | if (!empty($message['custom_fields']['icons'])) |
@@ -567,9 +595,10 @@ discard block |
||
567 | 595 | <li class="im_icons"> |
568 | 596 | <ol>'; |
569 | 597 | |
570 | - foreach ($message['custom_fields']['icons'] as $custom) |
|
571 | - echo ' |
|
598 | + foreach ($message['custom_fields']['icons'] as $custom) { |
|
599 | + echo ' |
|
572 | 600 | <li class="custom ', $custom['col_name'], '">', $custom['value'], '</li>'; |
601 | + } |
|
573 | 602 | |
574 | 603 | echo ' |
575 | 604 | </ol> |
@@ -584,19 +613,22 @@ discard block |
||
584 | 613 | <ol class="profile_icons">'; |
585 | 614 | |
586 | 615 | // Don't show an icon if they haven't specified a website. |
587 | - if (!empty($message['member']['website']['url']) && !isset($context['disabled_fields']['website'])) |
|
588 | - echo ' |
|
616 | + if (!empty($message['member']['website']['url']) && !isset($context['disabled_fields']['website'])) { |
|
617 | + echo ' |
|
589 | 618 | <li><a href="', $message['member']['website']['url'], '" title="' . $message['member']['website']['title'] . '" target="_blank">', ($settings['use_image_buttons'] ? '<span class="generic_icons www centericon" title="' . $message['member']['website']['title'] . '"></span>' : $txt['www']), '</a></li>'; |
619 | + } |
|
590 | 620 | |
591 | 621 | // Since we know this person isn't a guest, you *can* message them. |
592 | - if ($context['can_send_pm']) |
|
593 | - echo ' |
|
622 | + if ($context['can_send_pm']) { |
|
623 | + echo ' |
|
594 | 624 | <li><a href="', $scripturl, '?action=pm;sa=send;u=', $message['member']['id'], '" title="', $message['member']['online']['is_online'] ? $txt['pm_online'] : $txt['pm_offline'], '">', $settings['use_image_buttons'] ? '<span class="generic_icons im_' . ($message['member']['online']['is_online'] ? 'on' : 'off') . ' centericon" title="' . ($message['member']['online']['is_online'] ? $txt['pm_online'] : $txt['pm_offline']) . '"></span> ' : ($message['member']['online']['is_online'] ? $txt['pm_online'] : $txt['pm_offline']), '</a></li>'; |
625 | + } |
|
595 | 626 | |
596 | 627 | // Show the email if necessary |
597 | - if (!empty($message['member']['email']) && $message['member']['show_email']) |
|
598 | - echo ' |
|
628 | + if (!empty($message['member']['email']) && $message['member']['show_email']) { |
|
629 | + echo ' |
|
599 | 630 | <li class="email"><a href="mailto:' . $message['member']['email'] . '" rel="nofollow">', ($settings['use_image_buttons'] ? '<span class="generic_icons mail centericon" title="' . $txt['email'] . '"></span>' : $txt['email']), '</a></li>'; |
631 | + } |
|
600 | 632 | |
601 | 633 | echo ' |
602 | 634 | </ol> |
@@ -604,48 +636,56 @@ discard block |
||
604 | 636 | } |
605 | 637 | |
606 | 638 | // Any custom fields for standard placement? |
607 | - if (!empty($message['custom_fields']['standard'])) |
|
608 | - foreach ($message['custom_fields']['standard'] as $custom) |
|
639 | + if (!empty($message['custom_fields']['standard'])) { |
|
640 | + foreach ($message['custom_fields']['standard'] as $custom) |
|
609 | 641 | echo ' |
610 | 642 | <li class="custom ', $custom['col_name'], '">', $custom['title'], ': ', $custom['value'], '</li>'; |
643 | + } |
|
611 | 644 | |
612 | 645 | } |
613 | 646 | // Otherwise, show the guest's email. |
614 | - elseif (!empty($message['member']['email']) && $message['member']['show_email']) |
|
615 | - echo ' |
|
647 | + elseif (!empty($message['member']['email']) && $message['member']['show_email']) { |
|
648 | + echo ' |
|
616 | 649 | <li class="email"><a href="mailto:' . $message['member']['email'] . '" rel="nofollow">', ($settings['use_image_buttons'] ? '<span class="generic_icons mail centericon" title="' . $txt['email'] . '"></span>' : $txt['email']), '</a></li>'; |
650 | + } |
|
617 | 651 | |
618 | 652 | // Show the IP to this user for this post - because you can moderate? |
619 | - if (!empty($context['can_moderate_forum']) && !empty($message['member']['ip'])) |
|
620 | - echo ' |
|
653 | + if (!empty($context['can_moderate_forum']) && !empty($message['member']['ip'])) { |
|
654 | + echo ' |
|
621 | 655 | <li class="poster_ip"><a href="', $scripturl, '?action=', !empty($message['member']['is_guest']) ? 'trackip' : 'profile;area=tracking;sa=ip;u=' . $message['member']['id'], ';searchip=', $message['member']['ip'], '">', $message['member']['ip'], '</a> <a href="', $scripturl, '?action=helpadmin;help=see_admin_ip" onclick="return reqOverlayDiv(this.href);" class="help">(?)</a></li>'; |
656 | + } |
|
622 | 657 | |
623 | 658 | // Or, should we show it because this is you? |
624 | - elseif ($message['can_see_ip']) |
|
625 | - echo ' |
|
659 | + elseif ($message['can_see_ip']) { |
|
660 | + echo ' |
|
626 | 661 | <li class="poster_ip"><a href="', $scripturl, '?action=helpadmin;help=see_member_ip" onclick="return reqOverlayDiv(this.href);" class="help">', $message['member']['ip'], '</a></li>'; |
662 | + } |
|
627 | 663 | |
628 | 664 | // Okay, are you at least logged in? Then we can show something about why IPs are logged... |
629 | - elseif (!$context['user']['is_guest']) |
|
630 | - echo ' |
|
665 | + elseif (!$context['user']['is_guest']) { |
|
666 | + echo ' |
|
631 | 667 | <li class="poster_ip"><a href="', $scripturl, '?action=helpadmin;help=see_member_ip" onclick="return reqOverlayDiv(this.href);" class="help">', $txt['logged'], '</a></li>'; |
668 | + } |
|
632 | 669 | |
633 | 670 | // Otherwise, you see NOTHING! |
634 | - else |
|
635 | - echo ' |
|
671 | + else { |
|
672 | + echo ' |
|
636 | 673 | <li class="poster_ip">', $txt['logged'], '</li>'; |
674 | + } |
|
637 | 675 | |
638 | 676 | // Are we showing the warning status? |
639 | 677 | // Don't show these things for guests. |
640 | - if (!$message['member']['is_guest'] && $message['member']['can_see_warning']) |
|
641 | - echo ' |
|
678 | + if (!$message['member']['is_guest'] && $message['member']['can_see_warning']) { |
|
679 | + echo ' |
|
642 | 680 | <li class="warning">', $context['can_issue_warning'] ? '<a href="' . $scripturl . '?action=profile;area=issuewarning;u=' . $message['member']['id'] . '">' : '', '<span class="generic_icons warning_', $message['member']['warning_status'], '"></span> ', $context['can_issue_warning'] ? '</a>' : '', '<span class="warn_', $message['member']['warning_status'], '">', $txt['warn_' . $message['member']['warning_status']], '</span></li>'; |
681 | + } |
|
643 | 682 | |
644 | 683 | // Are there any custom fields to show at the bottom of the poster info? |
645 | - if (!empty($message['custom_fields']['bottom_poster'])) |
|
646 | - foreach ($message['custom_fields']['bottom_poster'] as $custom) |
|
684 | + if (!empty($message['custom_fields']['bottom_poster'])) { |
|
685 | + foreach ($message['custom_fields']['bottom_poster'] as $custom) |
|
647 | 686 | echo ' |
648 | 687 | <li class="custom ', $custom['col_name'], '">', $custom['value'], '</li>'; |
688 | + } |
|
649 | 689 | |
650 | 690 | // Poster info ends. |
651 | 691 | echo ' |
@@ -674,9 +714,10 @@ discard block |
||
674 | 714 | echo ' |
675 | 715 | <span class="smalltext modified floatright', !empty($modSettings['show_modify']) && !empty($message['modified']['name']) ? ' mvisible' : '','" id="modified_', $message['id'], '">'; |
676 | 716 | |
677 | - if (!empty($modSettings['show_modify']) && !empty($message['modified']['name'])) |
|
678 | - echo |
|
717 | + if (!empty($modSettings['show_modify']) && !empty($message['modified']['name'])) { |
|
718 | + echo |
|
679 | 719 | $message['modified']['last_edit_text']; |
720 | + } |
|
680 | 721 | |
681 | 722 | echo ' |
682 | 723 | </span> |
@@ -685,22 +726,24 @@ discard block |
||
685 | 726 | </div>'; |
686 | 727 | |
687 | 728 | // Ignoring this user? Hide the post. |
688 | - if ($ignoring) |
|
689 | - echo ' |
|
729 | + if ($ignoring) { |
|
730 | + echo ' |
|
690 | 731 | <div id="msg_', $message['id'], '_ignored_prompt"> |
691 | 732 | ', $txt['ignoring_user'], ' |
692 | 733 | <a href="#" id="msg_', $message['id'], '_ignored_link" style="display: none;">', $txt['show_ignore_user_post'], '</a> |
693 | 734 | </div>'; |
735 | + } |
|
694 | 736 | |
695 | 737 | // Show the post itself, finally! |
696 | 738 | echo ' |
697 | 739 | <div class="post">'; |
698 | 740 | |
699 | - if (!$message['approved'] && $message['member']['id'] != 0 && $message['member']['id'] == $context['user']['id']) |
|
700 | - echo ' |
|
741 | + if (!$message['approved'] && $message['member']['id'] != 0 && $message['member']['id'] == $context['user']['id']) { |
|
742 | + echo ' |
|
701 | 743 | <div class="approve_post"> |
702 | 744 | ', $txt['post_awaiting_approval'], ' |
703 | 745 | </div>'; |
746 | + } |
|
704 | 747 | echo ' |
705 | 748 | <div class="inner" data-msgid="', $message['id'], '" id="msg_', $message['id'], '"', $ignoring ? ' style="display:none;"' : '', '>', $message['body'], '</div> |
706 | 749 | </div>'; |
@@ -717,9 +760,9 @@ discard block |
||
717 | 760 | foreach ($message['attachment'] as $attachment) |
718 | 761 | { |
719 | 762 | // Do we want this attachment to not be showed here? |
720 | - if (!empty($modSettings['dont_show_attach_under_post']) && !empty($context['show_attach_under_post'][$attachment['id']])) |
|
721 | - continue; |
|
722 | - elseif (!$div_output) |
|
763 | + if (!empty($modSettings['dont_show_attach_under_post']) && !empty($context['show_attach_under_post'][$attachment['id']])) { |
|
764 | + continue; |
|
765 | + } elseif (!$div_output) |
|
723 | 766 | { |
724 | 767 | $div_output = true; |
725 | 768 | |
@@ -735,9 +778,10 @@ discard block |
||
735 | 778 | <fieldset> |
736 | 779 | <legend>', $txt['attach_awaiting_approve']; |
737 | 780 | |
738 | - if ($context['can_approve']) |
|
739 | - echo ' |
|
781 | + if ($context['can_approve']) { |
|
782 | + echo ' |
|
740 | 783 | [<a href="', $scripturl, '?action=attachapprove;sa=all;mid=', $message['id'], ';', $context['session_var'], '=', $context['session_id'], '">', $txt['approve_all'], '</a>]'; |
784 | + } |
|
741 | 785 | |
742 | 786 | echo ' |
743 | 787 | </legend>'; |
@@ -751,12 +795,13 @@ discard block |
||
751 | 795 | echo ' |
752 | 796 | <div class="attachments_top">'; |
753 | 797 | |
754 | - if ($attachment['thumbnail']['has_thumb']) |
|
755 | - echo ' |
|
798 | + if ($attachment['thumbnail']['has_thumb']) { |
|
799 | + echo ' |
|
756 | 800 | <a href="', $attachment['href'], ';image" id="link_', $attachment['id'], '" onclick="', $attachment['thumbnail']['javascript'], '"><img src="', $attachment['thumbnail']['href'], '" alt="" id="thumb_', $attachment['id'], '" class="atc_img"></a>'; |
757 | - else |
|
758 | - echo ' |
|
801 | + } else { |
|
802 | + echo ' |
|
759 | 803 | <img src="' . $attachment['href'] . ';image" alt="" width="' . $attachment['width'] . '" height="' . $attachment['height'] . '" class="atc_img">'; |
804 | + } |
|
760 | 805 | |
761 | 806 | echo ' |
762 | 807 | </div>'; |
@@ -766,9 +811,10 @@ discard block |
||
766 | 811 | <div class="attachments_bot"> |
767 | 812 | <a href="' . $attachment['href'] . '"><img src="' . $settings['images_url'] . '/icons/clip.png" class="centericon" alt="*"> ' . $attachment['name'] . '</a> '; |
768 | 813 | |
769 | - if (!$attachment['is_approved'] && $context['can_approve']) |
|
770 | - echo ' |
|
814 | + if (!$attachment['is_approved'] && $context['can_approve']) { |
|
815 | + echo ' |
|
771 | 816 | [<a href="', $scripturl, '?action=attachapprove;sa=approve;aid=', $attachment['id'], ';', $context['session_var'], '=', $context['session_id'], '">', $txt['approve'], '</a>] | [<a href="', $scripturl, '?action=attachapprove;sa=reject;aid=', $attachment['id'], ';', $context['session_var'], '=', $context['session_id'], '">', $txt['delete'], '</a>] '; |
817 | + } |
|
772 | 818 | echo ' |
773 | 819 | <br>', $attachment['size'], ($attachment['is_image'] ? ', ' . $attachment['real_width'] . 'x' . $attachment['real_height'] . '<br>' . sprintf($txt['attach_viewed'], $attachment['downloads']) : '<br>' . sprintf($txt['attach_downloaded'], $attachment['downloads'])), ' |
774 | 820 | </div>'; |
@@ -777,33 +823,38 @@ discard block |
||
777 | 823 | </div>'; |
778 | 824 | |
779 | 825 | // Next attachment line ? |
780 | - if (++$i % $attachments_per_line === 0) |
|
781 | - echo ' |
|
826 | + if (++$i % $attachments_per_line === 0) { |
|
827 | + echo ' |
|
782 | 828 | <br>'; |
829 | + } |
|
783 | 830 | } |
784 | 831 | |
785 | 832 | // If we had unapproved attachments clean up. |
786 | - if ($last_approved_state == 0) |
|
787 | - echo ' |
|
833 | + if ($last_approved_state == 0) { |
|
834 | + echo ' |
|
788 | 835 | </fieldset>'; |
836 | + } |
|
789 | 837 | |
790 | 838 | // Only do this if we output a div above - otherwise it'll break things |
791 | - if ($div_output) |
|
792 | - echo ' |
|
839 | + if ($div_output) { |
|
840 | + echo ' |
|
793 | 841 | </div>'; |
842 | + } |
|
794 | 843 | } |
795 | 844 | |
796 | 845 | // And stuff below the attachments. |
797 | - if ($context['can_report_moderator'] || !empty($modSettings['enable_likes']) || $message['can_approve'] || $message['can_unapprove'] || $context['can_reply'] || $message['can_modify'] || $message['can_remove'] || $context['can_split'] || $context['can_restore_msg'] || $context['can_quote']) |
|
798 | - echo ' |
|
846 | + if ($context['can_report_moderator'] || !empty($modSettings['enable_likes']) || $message['can_approve'] || $message['can_unapprove'] || $context['can_reply'] || $message['can_modify'] || $message['can_remove'] || $context['can_split'] || $context['can_restore_msg'] || $context['can_quote']) { |
|
847 | + echo ' |
|
799 | 848 | <div class="under_message">'; |
849 | + } |
|
800 | 850 | |
801 | 851 | // Maybe they want to report this post to the moderator(s)? |
802 | - if ($context['can_report_moderator']) |
|
803 | - echo ' |
|
852 | + if ($context['can_report_moderator']) { |
|
853 | + echo ' |
|
804 | 854 | <ul class="floatright smalltext"> |
805 | 855 | <li class="report_link"><a href="', $scripturl, '?action=reporttm;topic=', $context['current_topic'], '.', $message['counter'], ';msg=', $message['id'], '">', $txt['report_to_mod'], '</a></li> |
806 | 856 | </ul>'; |
857 | + } |
|
807 | 858 | |
808 | 859 | // What about likes? |
809 | 860 | if (!empty($modSettings['enable_likes'])) |
@@ -844,78 +895,91 @@ discard block |
||
844 | 895 | <ul class="quickbuttons">'; |
845 | 896 | |
846 | 897 | // Can they quote? if so they can select and quote as well! |
847 | - if ($context['can_quote']) |
|
848 | - echo ' |
|
898 | + if ($context['can_quote']) { |
|
899 | + echo ' |
|
849 | 900 | <li><a href="', $scripturl, '?action=post;quote=', $message['id'], ';topic=', $context['current_topic'], '.', $context['start'], ';last_msg=', $context['topic_last_message'], '" onclick="return oQuickReply.quote(', $message['id'], ');"><span class="generic_icons quote"></span>', $txt['quote_action'], '</a></li> |
850 | 901 | <li style="display:none;" id="quoteSelected_', $message['id'], '"><a href="javascript:void(0)"><span class="generic_icons quote_selected"></span>', $txt['quote_selected_action'], '</a></li>'; |
902 | + } |
|
851 | 903 | |
852 | 904 | // Can the user modify the contents of this post? Show the modify inline image. |
853 | - if ($message['can_modify']) |
|
854 | - echo ' |
|
905 | + if ($message['can_modify']) { |
|
906 | + echo ' |
|
855 | 907 | <li class="quick_edit"><a title="', $txt['modify_msg'], '" class="modifybutton" id="modify_button_', $message['id'], '" onclick="oQuickModify.modifyMsg(\'', $message['id'], '\', \'', !empty($modSettings['toggle_subject']), '\')"><span class="generic_icons quick_edit_button"></span>', $txt['quick_edit'], '</a></li>'; |
908 | + } |
|
856 | 909 | |
857 | - if ($message['can_approve'] || $message['can_unapprove'] || $message['can_modify'] || $message['can_remove'] || $context['can_split'] || $context['can_restore_msg']) |
|
858 | - echo ' |
|
910 | + if ($message['can_approve'] || $message['can_unapprove'] || $message['can_modify'] || $message['can_remove'] || $context['can_split'] || $context['can_restore_msg']) { |
|
911 | + echo ' |
|
859 | 912 | <li class="post_options">', $txt['post_options']; |
913 | + } |
|
860 | 914 | |
861 | 915 | echo ' |
862 | 916 | <ul>'; |
863 | 917 | |
864 | 918 | // Can the user modify the contents of this post? |
865 | - if ($message['can_modify']) |
|
866 | - echo ' |
|
919 | + if ($message['can_modify']) { |
|
920 | + echo ' |
|
867 | 921 | <li><a href="', $scripturl, '?action=post;msg=', $message['id'], ';topic=', $context['current_topic'], '.', $context['start'], '"><span class="generic_icons modify_button"></span>', $txt['modify'], '</a></li>'; |
922 | + } |
|
868 | 923 | |
869 | 924 | // How about... even... remove it entirely?! |
870 | - if ($context['can_delete'] && ($context['topic_first_message'] == $message['id'])) |
|
871 | - echo ' |
|
925 | + if ($context['can_delete'] && ($context['topic_first_message'] == $message['id'])) { |
|
926 | + echo ' |
|
872 | 927 | <li><a href="', $scripturl, '?action=removetopic2;topic=', $context['current_topic'], '.', $context['start'], ';', $context['session_var'], '=', $context['session_id'], '" data-confirm="', $txt['are_sure_remove_topic'], '" class="you_sure"><span class="generic_icons remove_button"></span>', $txt['remove_topic'], '</a></li>'; |
873 | - elseif ($message['can_remove'] && ($context['topic_first_message'] != $message['id'])) |
|
874 | - echo ' |
|
928 | + } elseif ($message['can_remove'] && ($context['topic_first_message'] != $message['id'])) { |
|
929 | + echo ' |
|
875 | 930 | <li><a href="', $scripturl, '?action=deletemsg;topic=', $context['current_topic'], '.', $context['start'], ';msg=', $message['id'], ';', $context['session_var'], '=', $context['session_id'], '" data-confirm="', $txt['remove_message_question'], '" class="you_sure"><span class="generic_icons remove_button"></span>', $txt['remove'], '</a></li>'; |
931 | + } |
|
876 | 932 | |
877 | 933 | // What about splitting it off the rest of the topic? |
878 | - if ($context['can_split'] && !empty($context['real_num_replies'])) |
|
879 | - echo ' |
|
934 | + if ($context['can_split'] && !empty($context['real_num_replies'])) { |
|
935 | + echo ' |
|
880 | 936 | <li><a href="', $scripturl, '?action=splittopics;topic=', $context['current_topic'], '.0;at=', $message['id'], '"><span class="generic_icons split_button"></span>', $txt['split'], '</a></li>'; |
937 | + } |
|
881 | 938 | |
882 | 939 | // Can we issue a warning because of this post? Remember, we can't give guests warnings. |
883 | - if ($context['can_issue_warning'] && !$message['is_message_author'] && !$message['member']['is_guest']) |
|
884 | - echo ' |
|
940 | + if ($context['can_issue_warning'] && !$message['is_message_author'] && !$message['member']['is_guest']) { |
|
941 | + echo ' |
|
885 | 942 | <li><a href="', $scripturl, '?action=profile;area=issuewarning;u=', $message['member']['id'], ';msg=', $message['id'], '"><span class="generic_icons warn_button"></span>', $txt['issue_warning'], '</a></li>'; |
943 | + } |
|
886 | 944 | |
887 | 945 | // Can we restore topics? |
888 | - if ($context['can_restore_msg']) |
|
889 | - echo ' |
|
946 | + if ($context['can_restore_msg']) { |
|
947 | + echo ' |
|
890 | 948 | <li><a href="', $scripturl, '?action=restoretopic;msgs=', $message['id'], ';', $context['session_var'], '=', $context['session_id'], '"><span class="generic_icons restore_button"></span>', $txt['restore_message'], '</a></li>'; |
949 | + } |
|
891 | 950 | |
892 | 951 | // Maybe we can approve it, maybe we should? |
893 | - if ($message['can_approve']) |
|
894 | - echo ' |
|
952 | + if ($message['can_approve']) { |
|
953 | + echo ' |
|
895 | 954 | <li><a href="', $scripturl, '?action=moderate;area=postmod;sa=approve;topic=', $context['current_topic'], '.', $context['start'], ';msg=', $message['id'], ';', $context['session_var'], '=', $context['session_id'], '"><span class="generic_icons approve_button"></span>', $txt['approve'], '</a></li>'; |
955 | + } |
|
896 | 956 | |
897 | 957 | // Maybe we can unapprove it? |
898 | - if ($message['can_unapprove']) |
|
899 | - echo ' |
|
958 | + if ($message['can_unapprove']) { |
|
959 | + echo ' |
|
900 | 960 | <li><a href="', $scripturl, '?action=moderate;area=postmod;sa=approve;topic=', $context['current_topic'], '.', $context['start'], ';msg=', $message['id'], ';', $context['session_var'], '=', $context['session_id'], '"><span class="generic_icons unapprove_button"></span>', $txt['unapprove'], '</a></li>'; |
961 | + } |
|
901 | 962 | |
902 | 963 | echo ' |
903 | 964 | </ul> |
904 | 965 | </li>'; |
905 | 966 | |
906 | 967 | // Show a checkbox for quick moderation? |
907 | - if (!empty($options['display_quick_mod']) && $options['display_quick_mod'] == 1 && $message['can_remove']) |
|
908 | - echo ' |
|
968 | + if (!empty($options['display_quick_mod']) && $options['display_quick_mod'] == 1 && $message['can_remove']) { |
|
969 | + echo ' |
|
909 | 970 | <li style="display: none;" id="in_topic_mod_check_', $message['id'], '"></li>'; |
971 | + } |
|
910 | 972 | |
911 | - if ($message['can_approve'] || $context['can_reply'] || $message['can_modify'] || $message['can_remove'] || $context['can_split'] || $context['can_restore_msg']) |
|
912 | - echo ' |
|
973 | + if ($message['can_approve'] || $context['can_reply'] || $message['can_modify'] || $message['can_remove'] || $context['can_split'] || $context['can_restore_msg']) { |
|
974 | + echo ' |
|
913 | 975 | </ul>'; |
976 | + } |
|
914 | 977 | } |
915 | 978 | |
916 | - if ($context['can_report_moderator'] || !empty($modSettings['enable_likes']) || $message['can_approve'] || $message['can_unapprove'] || $context['can_reply'] || $message['can_modify'] || $message['can_remove'] || $context['can_split'] || $context['can_restore_msg'] || $context['can_quote']) |
|
917 | - echo ' |
|
979 | + if ($context['can_report_moderator'] || !empty($modSettings['enable_likes']) || $message['can_approve'] || $message['can_unapprove'] || $context['can_reply'] || $message['can_modify'] || $message['can_remove'] || $context['can_split'] || $context['can_restore_msg'] || $context['can_quote']) { |
|
980 | + echo ' |
|
918 | 981 | </div>'; |
982 | + } |
|
919 | 983 | |
920 | 984 | echo ' |
921 | 985 | </div> |
@@ -928,9 +992,10 @@ discard block |
||
928 | 992 | <div class="custom_fields_above_signature"> |
929 | 993 | <ul class="nolist">'; |
930 | 994 | |
931 | - foreach ($message['custom_fields']['above_signature'] as $custom) |
|
932 | - echo ' |
|
995 | + foreach ($message['custom_fields']['above_signature'] as $custom) { |
|
996 | + echo ' |
|
933 | 997 | <li class="custom ', $custom['col_name'], '">', $custom['value'], '</li>'; |
998 | + } |
|
934 | 999 | |
935 | 1000 | echo ' |
936 | 1001 | </ul> |
@@ -938,9 +1003,10 @@ discard block |
||
938 | 1003 | } |
939 | 1004 | |
940 | 1005 | // Show the member's signature? |
941 | - if (!empty($message['member']['signature']) && empty($options['show_no_signatures']) && $context['signature_enabled']) |
|
942 | - echo ' |
|
1006 | + if (!empty($message['member']['signature']) && empty($options['show_no_signatures']) && $context['signature_enabled']) { |
|
1007 | + echo ' |
|
943 | 1008 | <div class="signature" id="msg_', $message['id'], '_signature"', $ignoring ? ' style="display:none;"' : '', '>', $message['member']['signature'], '</div>'; |
1009 | + } |
|
944 | 1010 | |
945 | 1011 | |
946 | 1012 | // Are there any custom profile fields for below the signature? |
@@ -950,9 +1016,10 @@ discard block |
||
950 | 1016 | <div class="custom_fields_below_signature"> |
951 | 1017 | <ul class="nolist">'; |
952 | 1018 | |
953 | - foreach ($message['custom_fields']['below_signature'] as $custom) |
|
954 | - echo ' |
|
1019 | + foreach ($message['custom_fields']['below_signature'] as $custom) { |
|
1020 | + echo ' |
|
955 | 1021 | <li class="custom ', $custom['col_name'], '">', $custom['value'], '</li>'; |
1022 | + } |
|
956 | 1023 | |
957 | 1024 | echo ' |
958 | 1025 | </ul> |
@@ -1000,8 +1067,8 @@ discard block |
||
1000 | 1067 | <input type="hidden" name="seqnum" value="', $context['form_sequence_number'], '">'; |
1001 | 1068 | |
1002 | 1069 | // Guests just need more. |
1003 | - if ($context['user']['is_guest']) |
|
1004 | - echo ' |
|
1070 | + if ($context['user']['is_guest']) { |
|
1071 | + echo ' |
|
1005 | 1072 | <dl id="post_header"> |
1006 | 1073 | <dt> |
1007 | 1074 | ', $txt['name'], ': |
@@ -1016,6 +1083,7 @@ discard block |
||
1016 | 1083 | <input type="email" name="email" size="25" value="', $context['email'], '" tabindex="', $context['tabindex']++, '" required> |
1017 | 1084 | </dd> |
1018 | 1085 | </dl>'; |
1086 | + } |
|
1019 | 1087 | |
1020 | 1088 | echo ' |
1021 | 1089 | ', template_control_richedit($context['post_box_name'], 'smileyBox_message', 'bbcBox_message'), ' |
@@ -1063,8 +1131,8 @@ discard block |
||
1063 | 1131 | <br class="clear">'; |
1064 | 1132 | |
1065 | 1133 | // draft autosave available and the user has it enabled? |
1066 | - if (!empty($context['drafts_autosave'])) |
|
1067 | - echo ' |
|
1134 | + if (!empty($context['drafts_autosave'])) { |
|
1135 | + echo ' |
|
1068 | 1136 | <script> |
1069 | 1137 | var oDraftAutoSave = new smf_DraftAutoSave({ |
1070 | 1138 | sSelf: \'oDraftAutoSave\', |
@@ -1076,10 +1144,12 @@ discard block |
||
1076 | 1144 | iFreq: ', (empty($modSettings['masterAutoSaveDraftsDelay']) ? 60000 : $modSettings['masterAutoSaveDraftsDelay'] * 1000), ' |
1077 | 1145 | }); |
1078 | 1146 | </script>'; |
1147 | + } |
|
1079 | 1148 | |
1080 | - if ($context['show_spellchecking']) |
|
1081 | - echo ' |
|
1149 | + if ($context['show_spellchecking']) { |
|
1150 | + echo ' |
|
1082 | 1151 | <form action="', $scripturl, '?action=spellcheck" method="post" accept-charset="', $context['character_set'], '" name="spell_form" id="spell_form" target="spellWindow"><input type="hidden" name="spellstring" value=""></form>'; |
1152 | + } |
|
1083 | 1153 | |
1084 | 1154 | echo ' |
1085 | 1155 | <script> |
@@ -15,8 +15,9 @@ discard block |
||
15 | 15 | * @version 2.1 Beta 4 |
16 | 16 | */ |
17 | 17 | |
18 | -if (!defined('SMF')) |
|
18 | +if (!defined('SMF')) { |
|
19 | 19 | die('No direct access...'); |
20 | +} |
|
20 | 21 | |
21 | 22 | /** |
22 | 23 | * Log an error, if the error logging is enabled. |
@@ -36,8 +37,9 @@ discard block |
||
36 | 37 | static $tried_hook = false; |
37 | 38 | |
38 | 39 | // Check if error logging is actually on. |
39 | - if (empty($modSettings['enableErrorLogging'])) |
|
40 | - return $error_message; |
|
40 | + if (empty($modSettings['enableErrorLogging'])) { |
|
41 | + return $error_message; |
|
42 | + } |
|
41 | 43 | |
42 | 44 | // Basically, htmlspecialchars it minus &. (for entities!) |
43 | 45 | $error_message = strtr($error_message, array('<' => '<', '>' => '>', '"' => '"')); |
@@ -45,33 +47,39 @@ discard block |
||
45 | 47 | |
46 | 48 | // Add a file and line to the error message? |
47 | 49 | // Don't use the actual txt entries for file and line but instead use %1$s for file and %2$s for line |
48 | - if ($file == null) |
|
49 | - $file = ''; |
|
50 | - else |
|
51 | - // Window style slashes don't play well, lets convert them to the unix style. |
|
50 | + if ($file == null) { |
|
51 | + $file = ''; |
|
52 | + } else { |
|
53 | + // Window style slashes don't play well, lets convert them to the unix style. |
|
52 | 54 | $file = str_replace('\\', '/', $file); |
55 | + } |
|
53 | 56 | |
54 | - if ($line == null) |
|
55 | - $line = 0; |
|
56 | - else |
|
57 | - $line = (int) $line; |
|
57 | + if ($line == null) { |
|
58 | + $line = 0; |
|
59 | + } else { |
|
60 | + $line = (int) $line; |
|
61 | + } |
|
58 | 62 | |
59 | 63 | // Just in case there's no id_member or IP set yet. |
60 | - if (empty($user_info['id'])) |
|
61 | - $user_info['id'] = 0; |
|
62 | - if (empty($user_info['ip'])) |
|
63 | - $user_info['ip'] = ''; |
|
64 | + if (empty($user_info['id'])) { |
|
65 | + $user_info['id'] = 0; |
|
66 | + } |
|
67 | + if (empty($user_info['ip'])) { |
|
68 | + $user_info['ip'] = ''; |
|
69 | + } |
|
64 | 70 | |
65 | 71 | // Find the best query string we can... |
66 | 72 | $query_string = empty($_SERVER['QUERY_STRING']) ? (empty($_SERVER['REQUEST_URL']) ? '' : str_replace($scripturl, '', $_SERVER['REQUEST_URL'])) : $_SERVER['QUERY_STRING']; |
67 | 73 | |
68 | 74 | // Don't log the session hash in the url twice, it's a waste. |
69 | - if (!empty($smcFunc['htmlspecialchars'])) |
|
70 | - $query_string = $smcFunc['htmlspecialchars']((SMF == 'SSI' || SMF == 'BACKGROUND' ? '' : '?') . preg_replace(array('~;sesc=[^&;]+~', '~' . session_name() . '=' . session_id() . '[&;]~'), array(';sesc', ''), $query_string)); |
|
75 | + if (!empty($smcFunc['htmlspecialchars'])) { |
|
76 | + $query_string = $smcFunc['htmlspecialchars']((SMF == 'SSI' || SMF == 'BACKGROUND' ? '' : '?') . preg_replace(array('~;sesc=[^&;]+~', '~' . session_name() . '=' . session_id() . '[&;]~'), array(';sesc', ''), $query_string)); |
|
77 | + } |
|
71 | 78 | |
72 | 79 | // Just so we know what board error messages are from. |
73 | - if (isset($_POST['board']) && !isset($_GET['board'])) |
|
74 | - $query_string .= ($query_string == '' ? 'board=' : ';board=') . $_POST['board']; |
|
80 | + if (isset($_POST['board']) && !isset($_GET['board'])) { |
|
81 | + $query_string .= ($query_string == '' ? 'board=' : ';board=') . $_POST['board']; |
|
82 | + } |
|
75 | 83 | |
76 | 84 | // What types of categories do we have? |
77 | 85 | $known_error_types = array( |
@@ -134,12 +142,14 @@ discard block |
||
134 | 142 | global $txt; |
135 | 143 | |
136 | 144 | // Send the appropriate HTTP status header - set this to 0 or false if you don't want to send one at all |
137 | - if (!empty($status)) |
|
138 | - send_http_status($status); |
|
145 | + if (!empty($status)) { |
|
146 | + send_http_status($status); |
|
147 | + } |
|
139 | 148 | |
140 | 149 | // We don't have $txt yet, but that's okay... |
141 | - if (empty($txt)) |
|
142 | - die($error); |
|
150 | + if (empty($txt)) { |
|
151 | + die($error); |
|
152 | + } |
|
143 | 153 | |
144 | 154 | log_error_online($error, false); |
145 | 155 | setup_fatal_error_context($log ? log_error($error, $log) : $error); |
@@ -166,8 +176,9 @@ discard block |
||
166 | 176 | static $fatal_error_called = false; |
167 | 177 | |
168 | 178 | // Send the status header - set this to 0 or false if you don't want to send one at all |
169 | - if (!empty($status)) |
|
170 | - send_http_status($status); |
|
179 | + if (!empty($status)) { |
|
180 | + send_http_status($status); |
|
181 | + } |
|
171 | 182 | |
172 | 183 | // Try to load a theme if we don't have one. |
173 | 184 | if (empty($context['theme_loaded']) && empty($fatal_error_called)) |
@@ -177,8 +188,9 @@ discard block |
||
177 | 188 | } |
178 | 189 | |
179 | 190 | // If we have no theme stuff we can't have the language file... |
180 | - if (empty($context['theme_loaded'])) |
|
181 | - die($error); |
|
191 | + if (empty($context['theme_loaded'])) { |
|
192 | + die($error); |
|
193 | + } |
|
182 | 194 | |
183 | 195 | $reload_lang_file = true; |
184 | 196 | // Log the error in the forum's language, but don't waste the time if we aren't logging |
@@ -214,8 +226,9 @@ discard block |
||
214 | 226 | global $settings, $modSettings, $db_show_debug; |
215 | 227 | |
216 | 228 | // Ignore errors if we're ignoring them or they are strict notices from PHP 5 (which cannot be solved without breaking PHP 4.) |
217 | - if (error_reporting() == 0 || (defined('E_STRICT') && $error_level == E_STRICT && !empty($modSettings['enableErrorLogging']))) |
|
218 | - return; |
|
229 | + if (error_reporting() == 0 || (defined('E_STRICT') && $error_level == E_STRICT && !empty($modSettings['enableErrorLogging']))) { |
|
230 | + return; |
|
231 | + } |
|
219 | 232 | |
220 | 233 | if (strpos($file, 'eval()') !== false && !empty($settings['current_include_filename'])) |
221 | 234 | { |
@@ -223,19 +236,22 @@ discard block |
||
223 | 236 | $count = count($array); |
224 | 237 | for ($i = 0; $i < $count; $i++) |
225 | 238 | { |
226 | - if ($array[$i]['function'] != 'loadSubTemplate') |
|
227 | - continue; |
|
239 | + if ($array[$i]['function'] != 'loadSubTemplate') { |
|
240 | + continue; |
|
241 | + } |
|
228 | 242 | |
229 | 243 | // This is a bug in PHP, with eval, it seems! |
230 | - if (empty($array[$i]['args'])) |
|
231 | - $i++; |
|
244 | + if (empty($array[$i]['args'])) { |
|
245 | + $i++; |
|
246 | + } |
|
232 | 247 | break; |
233 | 248 | } |
234 | 249 | |
235 | - if (isset($array[$i]) && !empty($array[$i]['args'])) |
|
236 | - $file = realpath($settings['current_include_filename']) . ' (' . $array[$i]['args'][0] . ' sub template - eval?)'; |
|
237 | - else |
|
238 | - $file = realpath($settings['current_include_filename']) . ' (eval?)'; |
|
250 | + if (isset($array[$i]) && !empty($array[$i]['args'])) { |
|
251 | + $file = realpath($settings['current_include_filename']) . ' (' . $array[$i]['args'][0] . ' sub template - eval?)'; |
|
252 | + } else { |
|
253 | + $file = realpath($settings['current_include_filename']) . ' (eval?)'; |
|
254 | + } |
|
239 | 255 | } |
240 | 256 | |
241 | 257 | if (isset($db_show_debug) && $db_show_debug === true) |
@@ -244,8 +260,9 @@ discard block |
||
244 | 260 | if ($error_level % 255 != E_ERROR) |
245 | 261 | { |
246 | 262 | $temporary = ob_get_contents(); |
247 | - if (substr($temporary, -2) == '="') |
|
248 | - echo '"'; |
|
263 | + if (substr($temporary, -2) == '="') { |
|
264 | + echo '"'; |
|
265 | + } |
|
249 | 266 | } |
250 | 267 | |
251 | 268 | // Debugging! This should look like a PHP error message. |
@@ -261,23 +278,27 @@ discard block |
||
261 | 278 | call_integration_hook('integrate_output_error', array($message, $error_type, $error_level, $file, $line)); |
262 | 279 | |
263 | 280 | // Dying on these errors only causes MORE problems (blank pages!) |
264 | - if ($file == 'Unknown') |
|
265 | - return; |
|
281 | + if ($file == 'Unknown') { |
|
282 | + return; |
|
283 | + } |
|
266 | 284 | |
267 | 285 | // If this is an E_ERROR or E_USER_ERROR.... die. Violently so. |
268 | - if ($error_level % 255 == E_ERROR) |
|
269 | - obExit(false); |
|
270 | - else |
|
271 | - return; |
|
286 | + if ($error_level % 255 == E_ERROR) { |
|
287 | + obExit(false); |
|
288 | + } else { |
|
289 | + return; |
|
290 | + } |
|
272 | 291 | |
273 | 292 | // If this is an E_ERROR, E_USER_ERROR, E_WARNING, or E_USER_WARNING.... die. Violently so. |
274 | - if ($error_level % 255 == E_ERROR || $error_level % 255 == E_WARNING) |
|
275 | - fatal_error(allowedTo('admin_forum') ? $message : $error_string, false); |
|
293 | + if ($error_level % 255 == E_ERROR || $error_level % 255 == E_WARNING) { |
|
294 | + fatal_error(allowedTo('admin_forum') ? $message : $error_string, false); |
|
295 | + } |
|
276 | 296 | |
277 | 297 | // We should NEVER get to this point. Any fatal error MUST quit, or very bad things can happen. |
278 | - if ($error_level % 255 == E_ERROR) |
|
279 | - die('No direct access...'); |
|
280 | -} |
|
298 | + if ($error_level % 255 == E_ERROR) { |
|
299 | + die('No direct access...'); |
|
300 | + } |
|
301 | + } |
|
281 | 302 | |
282 | 303 | /** |
283 | 304 | * It is called by {@link fatal_error()} and {@link fatal_lang_error()}. |
@@ -293,24 +314,28 @@ discard block |
||
293 | 314 | |
294 | 315 | // Attempt to prevent a recursive loop. |
295 | 316 | ++$level; |
296 | - if ($level > 1) |
|
297 | - return false; |
|
317 | + if ($level > 1) { |
|
318 | + return false; |
|
319 | + } |
|
298 | 320 | |
299 | 321 | // Maybe they came from dlattach or similar? |
300 | - if (SMF != 'SSI' && SMF != 'BACKGROUND' && empty($context['theme_loaded'])) |
|
301 | - loadTheme(); |
|
322 | + if (SMF != 'SSI' && SMF != 'BACKGROUND' && empty($context['theme_loaded'])) { |
|
323 | + loadTheme(); |
|
324 | + } |
|
302 | 325 | |
303 | 326 | // Don't bother indexing errors mate... |
304 | 327 | $context['robot_no_index'] = true; |
305 | 328 | |
306 | - if (!isset($context['error_title'])) |
|
307 | - $context['error_title'] = $txt['error_occured']; |
|
329 | + if (!isset($context['error_title'])) { |
|
330 | + $context['error_title'] = $txt['error_occured']; |
|
331 | + } |
|
308 | 332 | $context['error_message'] = isset($context['error_message']) ? $context['error_message'] : $error_message; |
309 | 333 | |
310 | 334 | $context['error_code'] = isset($error_code) ? 'id="' . $error_code . '" ' : ''; |
311 | 335 | |
312 | - if (empty($context['page_title'])) |
|
313 | - $context['page_title'] = $context['error_title']; |
|
336 | + if (empty($context['page_title'])) { |
|
337 | + $context['page_title'] = $context['error_title']; |
|
338 | + } |
|
314 | 339 | |
315 | 340 | loadTemplate('Errors'); |
316 | 341 | $context['sub_template'] = 'fatal_error'; |
@@ -318,23 +343,26 @@ discard block |
||
318 | 343 | // If this is SSI, what do they want us to do? |
319 | 344 | if (SMF == 'SSI') |
320 | 345 | { |
321 | - if (!empty($ssi_on_error_method) && $ssi_on_error_method !== true && is_callable($ssi_on_error_method)) |
|
322 | - $ssi_on_error_method(); |
|
323 | - elseif (empty($ssi_on_error_method) || $ssi_on_error_method !== true) |
|
324 | - loadSubTemplate('fatal_error'); |
|
346 | + if (!empty($ssi_on_error_method) && $ssi_on_error_method !== true && is_callable($ssi_on_error_method)) { |
|
347 | + $ssi_on_error_method(); |
|
348 | + } elseif (empty($ssi_on_error_method) || $ssi_on_error_method !== true) { |
|
349 | + loadSubTemplate('fatal_error'); |
|
350 | + } |
|
325 | 351 | |
326 | 352 | // No layers? |
327 | - if (empty($ssi_on_error_method) || $ssi_on_error_method !== true) |
|
328 | - exit; |
|
353 | + if (empty($ssi_on_error_method) || $ssi_on_error_method !== true) { |
|
354 | + exit; |
|
355 | + } |
|
329 | 356 | } |
330 | 357 | // Alternatively from the cron call? |
331 | 358 | elseif (SMF == 'BACKGROUND') |
332 | 359 | { |
333 | 360 | // We can't rely on even having language files available. |
334 | - if (defined('FROM_CLI') && FROM_CLI) |
|
335 | - echo 'cron error: ', $context['error_message']; |
|
336 | - else |
|
337 | - echo 'An error occurred. More information may be available in your logs.'; |
|
361 | + if (defined('FROM_CLI') && FROM_CLI) { |
|
362 | + echo 'cron error: ', $context['error_message']; |
|
363 | + } else { |
|
364 | + echo 'An error occurred. More information may be available in your logs.'; |
|
365 | + } |
|
338 | 366 | exit; |
339 | 367 | } |
340 | 368 | |
@@ -362,8 +390,8 @@ discard block |
||
362 | 390 | |
363 | 391 | set_fatal_error_headers(); |
364 | 392 | |
365 | - if (!empty($maintenance)) |
|
366 | - echo '<!DOCTYPE html> |
|
393 | + if (!empty($maintenance)) { |
|
394 | + echo '<!DOCTYPE html> |
|
367 | 395 | <html> |
368 | 396 | <head> |
369 | 397 | <meta name="robots" content="noindex"> |
@@ -374,6 +402,7 @@ discard block |
||
374 | 402 | ', $mmessage, ' |
375 | 403 | </body> |
376 | 404 | </html>'; |
405 | + } |
|
377 | 406 | |
378 | 407 | die(); |
379 | 408 | } |
@@ -395,15 +424,17 @@ discard block |
||
395 | 424 | // For our purposes, we're gonna want this on if at all possible. |
396 | 425 | $modSettings['cache_enable'] = '1'; |
397 | 426 | |
398 | - if (($temp = cache_get_data('db_last_error', 600)) !== null) |
|
399 | - $db_last_error = max($db_last_error, $temp); |
|
427 | + if (($temp = cache_get_data('db_last_error', 600)) !== null) { |
|
428 | + $db_last_error = max($db_last_error, $temp); |
|
429 | + } |
|
400 | 430 | |
401 | 431 | if ($db_last_error < time() - 3600 * 24 * 3 && empty($maintenance) && !empty($db_error_send)) |
402 | 432 | { |
403 | 433 | // Avoid writing to the Settings.php file if at all possible; use shared memory instead. |
404 | 434 | cache_put_data('db_last_error', time(), 600); |
405 | - if (($temp = cache_get_data('db_last_error', 600)) === null) |
|
406 | - logLastDatabaseError(); |
|
435 | + if (($temp = cache_get_data('db_last_error', 600)) === null) { |
|
436 | + logLastDatabaseError(); |
|
437 | + } |
|
407 | 438 | |
408 | 439 | // Language files aren't loaded yet :(. |
409 | 440 | $db_error = @$smcFunc['db_error']($db_connection); |
@@ -484,12 +515,14 @@ discard block |
||
484 | 515 | global $smcFunc, $user_info, $modSettings; |
485 | 516 | |
486 | 517 | // Don't bother if Who's Online is disabled. |
487 | - if (empty($modSettings['who_enabled'])) |
|
488 | - return; |
|
518 | + if (empty($modSettings['who_enabled'])) { |
|
519 | + return; |
|
520 | + } |
|
489 | 521 | |
490 | 522 | // Maybe they came from SSI or similar where sessions are not recorded? |
491 | - if (SMF == 'SSI' || SMF == 'BACKGROUND') |
|
492 | - return; |
|
523 | + if (SMF == 'SSI' || SMF == 'BACKGROUND') { |
|
524 | + return; |
|
525 | + } |
|
493 | 526 | |
494 | 527 | $session_id = !empty($user_info['is_guest']) ? 'ip' . $user_info['ip'] : session_id(); |
495 | 528 | |
@@ -515,8 +548,9 @@ discard block |
||
515 | 548 | $url = $smcFunc['json_decode']($url, true); |
516 | 549 | $url['error'] = $error; |
517 | 550 | |
518 | - if (!empty($sprintf)) |
|
519 | - $url['error_params'] = $sprintf; |
|
551 | + if (!empty($sprintf)) { |
|
552 | + $url['error_params'] = $sprintf; |
|
553 | + } |
|
520 | 554 | |
521 | 555 | $smcFunc['db_query']('', ' |
522 | 556 | UPDATE {db_prefix}log_online |
@@ -547,10 +581,11 @@ discard block |
||
547 | 581 | |
548 | 582 | $protocol = preg_match('~HTTP/1\.[01]~i', $_SERVER['SERVER_PROTOCOL']) ? $_SERVER['SERVER_PROTOCOL'] : 'HTTP/1.0'; |
549 | 583 | |
550 | - if (!isset($statuses[$code])) |
|
551 | - header($protocol . ' 500 Internal Server Error'); |
|
552 | - else |
|
553 | - header($protocol . ' ' . $code . ' ' . $statuses[$code]); |
|
554 | -} |
|
584 | + if (!isset($statuses[$code])) { |
|
585 | + header($protocol . ' 500 Internal Server Error'); |
|
586 | + } else { |
|
587 | + header($protocol . ' ' . $code . ' ' . $statuses[$code]); |
|
588 | + } |
|
589 | + } |
|
555 | 590 | |
556 | 591 | ?> |
557 | 592 | \ No newline at end of file |
@@ -13,8 +13,9 @@ discard block |
||
13 | 13 | * @version 2.1 Beta 4 |
14 | 14 | */ |
15 | 15 | |
16 | -if (!defined('SMF')) |
|
16 | +if (!defined('SMF')) { |
|
17 | 17 | die('No direct access...'); |
18 | +} |
|
18 | 19 | |
19 | 20 | /** |
20 | 21 | * Add the file functions to the $smcFunc array. |
@@ -53,8 +54,9 @@ discard block |
||
53 | 54 | 'messages', 'moderator_groups', 'moderators', 'package_servers', 'permission_profiles', 'permissions', 'personal_messages', |
54 | 55 | 'pm_labeled_messages', 'pm_labels', 'pm_recipients', 'pm_rules', 'poll_choices', 'polls', 'scheduled_tasks', 'sessions', 'settings', 'smileys', |
55 | 56 | 'spiders', 'subscriptions', 'themes', 'topics', 'user_alerts', 'user_alerts_prefs', 'user_drafts', 'user_likes'); |
56 | - foreach ($reservedTables as $k => $table_name) |
|
57 | - $reservedTables[$k] = strtolower($db_prefix . $table_name); |
|
57 | + foreach ($reservedTables as $k => $table_name) { |
|
58 | + $reservedTables[$k] = strtolower($db_prefix . $table_name); |
|
59 | + } |
|
58 | 60 | |
59 | 61 | // We in turn may need the extra stuff. |
60 | 62 | db_extend('extra'); |
@@ -109,8 +111,9 @@ discard block |
||
109 | 111 | $table_name = str_replace('{db_prefix}', $db_prefix, $table_name); |
110 | 112 | |
111 | 113 | // First - no way do we touch SMF tables. |
112 | - if (in_array(strtolower($table_name), $reservedTables)) |
|
113 | - return false; |
|
114 | + if (in_array(strtolower($table_name), $reservedTables)) { |
|
115 | + return false; |
|
116 | + } |
|
114 | 117 | |
115 | 118 | // Log that we'll want to remove this on uninstall. |
116 | 119 | $db_package_log[] = array('remove_table', $table_name); |
@@ -120,9 +123,9 @@ discard block |
||
120 | 123 | if (in_array($full_table_name, $tables)) |
121 | 124 | { |
122 | 125 | // This is a sad day... drop the table? If not, return false (error) by default. |
123 | - if ($if_exists == 'overwrite') |
|
124 | - $smcFunc['db_drop_table']($table_name); |
|
125 | - else if ($if_exists == 'update') |
|
126 | + if ($if_exists == 'overwrite') { |
|
127 | + $smcFunc['db_drop_table']($table_name); |
|
128 | + } else if ($if_exists == 'update') |
|
126 | 129 | { |
127 | 130 | $smcFunc['db_transaction']('begin'); |
128 | 131 | $db_trans = true; |
@@ -134,15 +137,16 @@ discard block |
||
134 | 137 | ) |
135 | 138 | ); |
136 | 139 | $old_table_exists = true; |
140 | + } else { |
|
141 | + return $if_exists == 'ignore'; |
|
137 | 142 | } |
138 | - else |
|
139 | - return $if_exists == 'ignore'; |
|
140 | 143 | } |
141 | 144 | |
142 | 145 | // Righty - let's do the damn thing! |
143 | 146 | $table_query = 'CREATE TABLE ' . $table_name . "\n" . '('; |
144 | - foreach ($columns as $column) |
|
145 | - $table_query .= "\n\t" . smf_db_create_query_column($column) . ','; |
|
147 | + foreach ($columns as $column) { |
|
148 | + $table_query .= "\n\t" . smf_db_create_query_column($column) . ','; |
|
149 | + } |
|
146 | 150 | |
147 | 151 | // Loop through the indexes next... |
148 | 152 | foreach ($indexes as $index) |
@@ -150,19 +154,21 @@ discard block |
||
150 | 154 | $columns = implode(',', $index['columns']); |
151 | 155 | |
152 | 156 | // Is it the primary? |
153 | - if (isset($index['type']) && $index['type'] == 'primary') |
|
154 | - $table_query .= "\n\t" . 'PRIMARY KEY (' . implode(',', $index['columns']) . '),'; |
|
155 | - else |
|
157 | + if (isset($index['type']) && $index['type'] == 'primary') { |
|
158 | + $table_query .= "\n\t" . 'PRIMARY KEY (' . implode(',', $index['columns']) . '),'; |
|
159 | + } else |
|
156 | 160 | { |
157 | - if (empty($index['name'])) |
|
158 | - $index['name'] = implode('_', $index['columns']); |
|
161 | + if (empty($index['name'])) { |
|
162 | + $index['name'] = implode('_', $index['columns']); |
|
163 | + } |
|
159 | 164 | $table_query .= "\n\t" . (isset($index['type']) && $index['type'] == 'unique' ? 'UNIQUE' : 'KEY') . ' ' . $index['name'] . ' (' . $columns . '),'; |
160 | 165 | } |
161 | 166 | } |
162 | 167 | |
163 | 168 | // No trailing commas! |
164 | - if (substr($table_query, -1) == ',') |
|
165 | - $table_query = substr($table_query, 0, -1); |
|
169 | + if (substr($table_query, -1) == ',') { |
|
170 | + $table_query = substr($table_query, 0, -1); |
|
171 | + } |
|
166 | 172 | |
167 | 173 | // Which engine do we want here? |
168 | 174 | if (empty($engines)) |
@@ -172,8 +178,9 @@ discard block |
||
172 | 178 | |
173 | 179 | while ($row = $smcFunc['db_fetch_assoc']($get_engines)) |
174 | 180 | { |
175 | - if ($row['Support'] == 'YES' || $row['Support'] == 'DEFAULT') |
|
176 | - $engines[] = $row['Engine']; |
|
181 | + if ($row['Support'] == 'YES' || $row['Support'] == 'DEFAULT') { |
|
182 | + $engines[] = $row['Engine']; |
|
183 | + } |
|
177 | 184 | } |
178 | 185 | |
179 | 186 | $smcFunc['db_free_result']($get_engines); |
@@ -187,8 +194,9 @@ discard block |
||
187 | 194 | } |
188 | 195 | |
189 | 196 | $table_query .= ') ENGINE=' . $parameters['engine']; |
190 | - if (!empty($db_character_set) && $db_character_set == 'utf8') |
|
191 | - $table_query .= ' DEFAULT CHARSET=utf8 COLLATE=utf8_general_ci'; |
|
197 | + if (!empty($db_character_set) && $db_character_set == 'utf8') { |
|
198 | + $table_query .= ' DEFAULT CHARSET=utf8 COLLATE=utf8_general_ci'; |
|
199 | + } |
|
192 | 200 | |
193 | 201 | // Create the table! |
194 | 202 | $smcFunc['db_query']('', $table_query, |
@@ -255,8 +263,9 @@ discard block |
||
255 | 263 | $table_name = str_replace('{db_prefix}', $db_prefix, $table_name); |
256 | 264 | |
257 | 265 | // God no - dropping one of these = bad. |
258 | - if (in_array(strtolower($table_name), $reservedTables)) |
|
259 | - return false; |
|
266 | + if (in_array(strtolower($table_name), $reservedTables)) { |
|
267 | + return false; |
|
268 | + } |
|
260 | 269 | |
261 | 270 | // Does it exist? |
262 | 271 | if (in_array($full_table_name, $smcFunc['db_list_tables']())) |
@@ -297,14 +306,16 @@ discard block |
||
297 | 306 | |
298 | 307 | // Does it exist - if so don't add it again! |
299 | 308 | $columns = $smcFunc['db_list_columns']($table_name, false); |
300 | - foreach ($columns as $column) |
|
301 | - if ($column == $column_info['name']) |
|
309 | + foreach ($columns as $column) { |
|
310 | + if ($column == $column_info['name']) |
|
302 | 311 | { |
303 | 312 | // If we're going to overwrite then use change column. |
304 | 313 | if ($if_exists == 'update') |
305 | 314 | return $smcFunc['db_change_column']($table_name, $column_info['name'], $column_info); |
306 | - else |
|
307 | - return false; |
|
315 | + } |
|
316 | + else { |
|
317 | + return false; |
|
318 | + } |
|
308 | 319 | } |
309 | 320 | |
310 | 321 | // Get the specifics... |
@@ -340,8 +351,8 @@ discard block |
||
340 | 351 | |
341 | 352 | // Does it exist? |
342 | 353 | $columns = $smcFunc['db_list_columns']($table_name, true); |
343 | - foreach ($columns as $column) |
|
344 | - if ($column['name'] == $column_name) |
|
354 | + foreach ($columns as $column) { |
|
355 | + if ($column['name'] == $column_name) |
|
345 | 356 | { |
346 | 357 | $smcFunc['db_query']('', ' |
347 | 358 | ALTER TABLE ' . $table_name . ' |
@@ -350,6 +361,7 @@ discard block |
||
350 | 361 | 'security_override' => true, |
351 | 362 | ) |
352 | 363 | ); |
364 | + } |
|
353 | 365 | |
354 | 366 | return true; |
355 | 367 | } |
@@ -375,37 +387,47 @@ discard block |
||
375 | 387 | // Check it does exist! |
376 | 388 | $columns = $smcFunc['db_list_columns']($table_name, true); |
377 | 389 | $old_info = null; |
378 | - foreach ($columns as $column) |
|
379 | - if ($column['name'] == $old_column) |
|
390 | + foreach ($columns as $column) { |
|
391 | + if ($column['name'] == $old_column) |
|
380 | 392 | $old_info = $column; |
393 | + } |
|
381 | 394 | |
382 | 395 | // Nothing? |
383 | - if ($old_info == null) |
|
384 | - return false; |
|
396 | + if ($old_info == null) { |
|
397 | + return false; |
|
398 | + } |
|
385 | 399 | |
386 | 400 | // Get the right bits. |
387 | - if (!isset($column_info['name'])) |
|
388 | - $column_info['name'] = $old_column; |
|
389 | - if (!isset($column_info['default'])) |
|
390 | - $column_info['default'] = $old_info['default']; |
|
391 | - if (!isset($column_info['null'])) |
|
392 | - $column_info['null'] = $old_info['null']; |
|
393 | - if (!isset($column_info['auto'])) |
|
394 | - $column_info['auto'] = $old_info['auto']; |
|
395 | - if (!isset($column_info['type'])) |
|
396 | - $column_info['type'] = $old_info['type']; |
|
397 | - if (!isset($column_info['size']) || !is_numeric($column_info['size'])) |
|
398 | - $column_info['size'] = $old_info['size']; |
|
399 | - if (!isset($column_info['unsigned']) || !in_array($column_info['type'], array('int', 'tinyint', 'smallint', 'mediumint', 'bigint'))) |
|
400 | - $column_info['unsigned'] = ''; |
|
401 | + if (!isset($column_info['name'])) { |
|
402 | + $column_info['name'] = $old_column; |
|
403 | + } |
|
404 | + if (!isset($column_info['default'])) { |
|
405 | + $column_info['default'] = $old_info['default']; |
|
406 | + } |
|
407 | + if (!isset($column_info['null'])) { |
|
408 | + $column_info['null'] = $old_info['null']; |
|
409 | + } |
|
410 | + if (!isset($column_info['auto'])) { |
|
411 | + $column_info['auto'] = $old_info['auto']; |
|
412 | + } |
|
413 | + if (!isset($column_info['type'])) { |
|
414 | + $column_info['type'] = $old_info['type']; |
|
415 | + } |
|
416 | + if (!isset($column_info['size']) || !is_numeric($column_info['size'])) { |
|
417 | + $column_info['size'] = $old_info['size']; |
|
418 | + } |
|
419 | + if (!isset($column_info['unsigned']) || !in_array($column_info['type'], array('int', 'tinyint', 'smallint', 'mediumint', 'bigint'))) { |
|
420 | + $column_info['unsigned'] = ''; |
|
421 | + } |
|
401 | 422 | |
402 | 423 | list ($type, $size) = $smcFunc['db_calculate_type']($column_info['type'], $column_info['size']); |
403 | 424 | |
404 | 425 | // Allow for unsigned integers (mysql only) |
405 | 426 | $unsigned = in_array($type, array('int', 'tinyint', 'smallint', 'mediumint', 'bigint')) && !empty($column_info['unsigned']) ? 'unsigned ' : ''; |
406 | 427 | |
407 | - if ($size !== null) |
|
408 | - $type = $type . '(' . $size . ')'; |
|
428 | + if ($size !== null) { |
|
429 | + $type = $type . '(' . $size . ')'; |
|
430 | + } |
|
409 | 431 | |
410 | 432 | $smcFunc['db_query']('', ' |
411 | 433 | ALTER TABLE ' . $table_name . ' |
@@ -435,18 +457,20 @@ discard block |
||
435 | 457 | $table_name = str_replace('{db_prefix}', $db_prefix, $table_name); |
436 | 458 | |
437 | 459 | // No columns = no index. |
438 | - if (empty($index_info['columns'])) |
|
439 | - return false; |
|
460 | + if (empty($index_info['columns'])) { |
|
461 | + return false; |
|
462 | + } |
|
440 | 463 | $columns = implode(',', $index_info['columns']); |
441 | 464 | |
442 | 465 | // No name - make it up! |
443 | 466 | if (empty($index_info['name'])) |
444 | 467 | { |
445 | 468 | // No need for primary. |
446 | - if (isset($index_info['type']) && $index_info['type'] == 'primary') |
|
447 | - $index_info['name'] = ''; |
|
448 | - else |
|
449 | - $index_info['name'] = implode('_', $index_info['columns']); |
|
469 | + if (isset($index_info['type']) && $index_info['type'] == 'primary') { |
|
470 | + $index_info['name'] = ''; |
|
471 | + } else { |
|
472 | + $index_info['name'] = implode('_', $index_info['columns']); |
|
473 | + } |
|
450 | 474 | } |
451 | 475 | |
452 | 476 | // Log that we are going to want to remove this! |
@@ -460,10 +484,11 @@ discard block |
||
460 | 484 | if ($index['name'] == $index_info['name'] || ($index['type'] == 'primary' && isset($index_info['type']) && $index_info['type'] == 'primary')) |
461 | 485 | { |
462 | 486 | // If we want to overwrite simply remove the current one then continue. |
463 | - if ($if_exists != 'update' || $index['type'] == 'primary') |
|
464 | - return false; |
|
465 | - else |
|
466 | - $smcFunc['db_remove_index']($table_name, $index_info['name']); |
|
487 | + if ($if_exists != 'update' || $index['type'] == 'primary') { |
|
488 | + return false; |
|
489 | + } else { |
|
490 | + $smcFunc['db_remove_index']($table_name, $index_info['name']); |
|
491 | + } |
|
467 | 492 | } |
468 | 493 | } |
469 | 494 | |
@@ -477,8 +502,7 @@ discard block |
||
477 | 502 | 'security_override' => true, |
478 | 503 | ) |
479 | 504 | ); |
480 | - } |
|
481 | - else |
|
505 | + } else |
|
482 | 506 | { |
483 | 507 | $smcFunc['db_query']('', ' |
484 | 508 | ALTER TABLE ' . $table_name . ' |
@@ -562,8 +586,7 @@ discard block |
||
562 | 586 | $types = array( |
563 | 587 | 'inet' => 'varbinary', |
564 | 588 | ); |
565 | - } |
|
566 | - else |
|
589 | + } else |
|
567 | 590 | { |
568 | 591 | $types = array( |
569 | 592 | 'varbinary' => 'inet', |
@@ -577,16 +600,15 @@ discard block |
||
577 | 600 | { |
578 | 601 | $type_size = 16; |
579 | 602 | $type_name = 'varbinary'; |
580 | - } |
|
581 | - elseif ($type_name == 'varbinary' && $reverse && $type_size == 16) |
|
603 | + } elseif ($type_name == 'varbinary' && $reverse && $type_size == 16) |
|
582 | 604 | { |
583 | 605 | $type_name = 'inet'; |
584 | 606 | $type_size = null; |
607 | + } elseif ($type_name == 'varbinary') { |
|
608 | + $type_name = 'varbinary'; |
|
609 | + } else { |
|
610 | + $type_name = $types[$type_name]; |
|
585 | 611 | } |
586 | - elseif ($type_name == 'varbinary') |
|
587 | - $type_name = 'varbinary'; |
|
588 | - else |
|
589 | - $type_name = $types[$type_name]; |
|
590 | 612 | } |
591 | 613 | |
592 | 614 | return array($type_name, $type_size); |
@@ -653,8 +675,7 @@ discard block |
||
653 | 675 | if (!$detail) |
654 | 676 | { |
655 | 677 | $columns[] = $row['Field']; |
656 | - } |
|
657 | - else |
|
678 | + } else |
|
658 | 679 | { |
659 | 680 | // Is there an auto_increment? |
660 | 681 | $auto = strpos($row['Extra'], 'auto_increment') !== false ? true : false; |
@@ -664,10 +685,10 @@ discard block |
||
664 | 685 | { |
665 | 686 | $type = $matches[1]; |
666 | 687 | $size = $matches[2]; |
667 | - if (!empty($matches[3]) && $matches[3] == 'unsigned') |
|
668 | - $unsigned = true; |
|
669 | - } |
|
670 | - else |
|
688 | + if (!empty($matches[3]) && $matches[3] == 'unsigned') { |
|
689 | + $unsigned = true; |
|
690 | + } |
|
691 | + } else |
|
671 | 692 | { |
672 | 693 | $type = $row['Type']; |
673 | 694 | $size = null; |
@@ -718,19 +739,20 @@ discard block |
||
718 | 739 | $indexes = array(); |
719 | 740 | while ($row = $smcFunc['db_fetch_assoc']($result)) |
720 | 741 | { |
721 | - if (!$detail) |
|
722 | - $indexes[] = $row['Key_name']; |
|
723 | - else |
|
742 | + if (!$detail) { |
|
743 | + $indexes[] = $row['Key_name']; |
|
744 | + } else |
|
724 | 745 | { |
725 | 746 | // What is the type? |
726 | - if ($row['Key_name'] == 'PRIMARY') |
|
727 | - $type = 'primary'; |
|
728 | - elseif (empty($row['Non_unique'])) |
|
729 | - $type = 'unique'; |
|
730 | - elseif (isset($row['Index_type']) && $row['Index_type'] == 'FULLTEXT') |
|
731 | - $type = 'fulltext'; |
|
732 | - else |
|
733 | - $type = 'index'; |
|
747 | + if ($row['Key_name'] == 'PRIMARY') { |
|
748 | + $type = 'primary'; |
|
749 | + } elseif (empty($row['Non_unique'])) { |
|
750 | + $type = 'unique'; |
|
751 | + } elseif (isset($row['Index_type']) && $row['Index_type'] == 'FULLTEXT') { |
|
752 | + $type = 'fulltext'; |
|
753 | + } else { |
|
754 | + $type = 'index'; |
|
755 | + } |
|
734 | 756 | |
735 | 757 | // This is the first column we've seen? |
736 | 758 | if (empty($indexes[$row['Key_name']])) |
@@ -743,10 +765,11 @@ discard block |
||
743 | 765 | } |
744 | 766 | |
745 | 767 | // Is it a partial index? |
746 | - if (!empty($row['Sub_part'])) |
|
747 | - $indexes[$row['Key_name']]['columns'][] = $row['Column_name'] . '(' . $row['Sub_part'] . ')'; |
|
748 | - else |
|
749 | - $indexes[$row['Key_name']]['columns'][] = $row['Column_name']; |
|
768 | + if (!empty($row['Sub_part'])) { |
|
769 | + $indexes[$row['Key_name']]['columns'][] = $row['Column_name'] . '(' . $row['Sub_part'] . ')'; |
|
770 | + } else { |
|
771 | + $indexes[$row['Key_name']]['columns'][] = $row['Column_name']; |
|
772 | + } |
|
750 | 773 | } |
751 | 774 | } |
752 | 775 | $smcFunc['db_free_result']($result); |
@@ -768,11 +791,11 @@ discard block |
||
768 | 791 | if (!empty($column['auto'])) |
769 | 792 | { |
770 | 793 | $default = 'auto_increment'; |
794 | + } elseif (isset($column['default']) && $column['default'] !== null) { |
|
795 | + $default = 'default \'' . $smcFunc['db_escape_string']($column['default']) . '\''; |
|
796 | + } else { |
|
797 | + $default = ''; |
|
771 | 798 | } |
772 | - elseif (isset($column['default']) && $column['default'] !== null) |
|
773 | - $default = 'default \'' . $smcFunc['db_escape_string']($column['default']) . '\''; |
|
774 | - else |
|
775 | - $default = ''; |
|
776 | 799 | |
777 | 800 | // Sort out the size... and stuff... |
778 | 801 | $column['size'] = isset($column['size']) && is_numeric($column['size']) ? $column['size'] : null; |
@@ -781,8 +804,9 @@ discard block |
||
781 | 804 | // Allow unsigned integers (mysql only) |
782 | 805 | $unsigned = in_array($type, array('int', 'tinyint', 'smallint', 'mediumint', 'bigint')) && !empty($column['unsigned']) ? 'unsigned ' : ''; |
783 | 806 | |
784 | - if ($size !== null) |
|
785 | - $type = $type . '(' . $size . ')'; |
|
807 | + if ($size !== null) { |
|
808 | + $type = $type . '(' . $size . ')'; |
|
809 | + } |
|
786 | 810 | |
787 | 811 | // Now just put it together! |
788 | 812 | return '`' . $column['name'] . '` ' . $type . ' ' . (!empty($unsigned) ? $unsigned : '') . (!empty($column['null']) ? '' : 'NOT NULL') . ' ' . $default; |
@@ -13,8 +13,9 @@ discard block |
||
13 | 13 | * @version 2.1 Beta 4 |
14 | 14 | */ |
15 | 15 | |
16 | -if (!defined('SMF')) |
|
16 | +if (!defined('SMF')) { |
|
17 | 17 | die('No direct access...'); |
18 | +} |
|
18 | 19 | |
19 | 20 | /** |
20 | 21 | * Add the file functions to the $smcFunc array. |
@@ -53,8 +54,9 @@ discard block |
||
53 | 54 | 'messages', 'moderator_groups', 'moderators', 'package_servers', 'permission_profiles', 'permissions', 'personal_messages', |
54 | 55 | 'pm_labeled_messages', 'pm_labels', 'pm_recipients', 'pm_rules', 'poll_choices', 'polls', 'scheduled_tasks', 'sessions', 'settings', 'smileys', |
55 | 56 | 'spiders', 'subscriptions', 'themes', 'topics', 'user_alerts', 'user_alerts_prefs', 'user_drafts', 'user_likes'); |
56 | - foreach ($reservedTables as $k => $table_name) |
|
57 | - $reservedTables[$k] = strtolower($db_prefix . $table_name); |
|
57 | + foreach ($reservedTables as $k => $table_name) { |
|
58 | + $reservedTables[$k] = strtolower($db_prefix . $table_name); |
|
59 | + } |
|
58 | 60 | |
59 | 61 | // We in turn may need the extra stuff. |
60 | 62 | db_extend('extra'); |
@@ -107,8 +109,9 @@ discard block |
||
107 | 109 | $table_name = str_replace('{db_prefix}', $db_prefix, $table_name); |
108 | 110 | |
109 | 111 | // First - no way do we touch SMF tables. |
110 | - if (in_array(strtolower($table_name), $reservedTables)) |
|
111 | - return false; |
|
112 | + if (in_array(strtolower($table_name), $reservedTables)) { |
|
113 | + return false; |
|
114 | + } |
|
112 | 115 | |
113 | 116 | // Log that we'll want to remove this on uninstall. |
114 | 117 | $db_package_log[] = array('remove_table', $table_name); |
@@ -118,9 +121,9 @@ discard block |
||
118 | 121 | if (in_array($full_table_name, $tables)) |
119 | 122 | { |
120 | 123 | // This is a sad day... drop the table? If not, return false (error) by default. |
121 | - if ($if_exists == 'overwrite') |
|
122 | - $smcFunc['db_drop_table']($table_name); |
|
123 | - else if ($if_exists == 'update') |
|
124 | + if ($if_exists == 'overwrite') { |
|
125 | + $smcFunc['db_drop_table']($table_name); |
|
126 | + } else if ($if_exists == 'update') |
|
124 | 127 | { |
125 | 128 | $smcFunc['db_drop_table']($table_name.'_old'); |
126 | 129 | $smcFunc['db_transaction']('begin'); |
@@ -132,47 +135,51 @@ discard block |
||
132 | 135 | ) |
133 | 136 | ); |
134 | 137 | $old_table_exists = true; |
138 | + } else { |
|
139 | + return $if_exists == 'ignore'; |
|
135 | 140 | } |
136 | - else |
|
137 | - return $if_exists == 'ignore'; |
|
138 | 141 | } |
139 | 142 | |
140 | 143 | // If we've got this far - good news - no table exists. We can build our own! |
141 | - if (!$db_trans) |
|
142 | - $smcFunc['db_transaction']('begin'); |
|
144 | + if (!$db_trans) { |
|
145 | + $smcFunc['db_transaction']('begin'); |
|
146 | + } |
|
143 | 147 | $table_query = 'CREATE TABLE ' . $table_name . "\n" . '('; |
144 | 148 | foreach ($columns as $column) |
145 | 149 | { |
146 | 150 | // If we have an auto increment do it! |
147 | 151 | if (!empty($column['auto'])) |
148 | 152 | { |
149 | - if (!$old_table_exists) |
|
150 | - $smcFunc['db_query']('', ' |
|
153 | + if (!$old_table_exists) { |
|
154 | + $smcFunc['db_query']('', ' |
|
151 | 155 | DROP SEQUENCE IF EXISTS ' . $table_name . '_seq', |
152 | 156 | array( |
153 | 157 | 'security_override' => true, |
154 | 158 | ) |
155 | 159 | ); |
160 | + } |
|
156 | 161 | |
157 | - if (!$old_table_exists) |
|
158 | - $smcFunc['db_query']('', ' |
|
162 | + if (!$old_table_exists) { |
|
163 | + $smcFunc['db_query']('', ' |
|
159 | 164 | CREATE SEQUENCE ' . $table_name . '_seq', |
160 | 165 | array( |
161 | 166 | 'security_override' => true, |
162 | 167 | ) |
163 | 168 | ); |
169 | + } |
|
164 | 170 | $default = 'default nextval(\'' . $table_name . '_seq\')'; |
171 | + } elseif (isset($column['default']) && $column['default'] !== null) { |
|
172 | + $default = 'default \'' . $smcFunc['db_escape_string']($column['default']) . '\''; |
|
173 | + } else { |
|
174 | + $default = ''; |
|
165 | 175 | } |
166 | - elseif (isset($column['default']) && $column['default'] !== null) |
|
167 | - $default = 'default \'' . $smcFunc['db_escape_string']($column['default']) . '\''; |
|
168 | - else |
|
169 | - $default = ''; |
|
170 | 176 | |
171 | 177 | // Sort out the size... |
172 | 178 | $column['size'] = isset($column['size']) && is_numeric($column['size']) ? $column['size'] : null; |
173 | 179 | list ($type, $size) = $smcFunc['db_calculate_type']($column['type'], $column['size']); |
174 | - if ($size !== null) |
|
175 | - $type = $type . '(' . $size . ')'; |
|
180 | + if ($size !== null) { |
|
181 | + $type = $type . '(' . $size . ')'; |
|
182 | + } |
|
176 | 183 | |
177 | 184 | // Now just put it together! |
178 | 185 | $table_query .= "\n\t\"" . $column['name'] . '" ' . $type . ' ' . (!empty($column['null']) ? '' : 'NOT NULL') . ' ' . $default . ','; |
@@ -185,19 +192,21 @@ discard block |
||
185 | 192 | $columns = implode(',', $index['columns']); |
186 | 193 | |
187 | 194 | // Primary goes in the table... |
188 | - if (isset($index['type']) && $index['type'] == 'primary') |
|
189 | - $table_query .= "\n\t" . 'PRIMARY KEY (' . implode(',', $index['columns']) . '),'; |
|
190 | - else |
|
195 | + if (isset($index['type']) && $index['type'] == 'primary') { |
|
196 | + $table_query .= "\n\t" . 'PRIMARY KEY (' . implode(',', $index['columns']) . '),'; |
|
197 | + } else |
|
191 | 198 | { |
192 | - if (empty($index['name'])) |
|
193 | - $index['name'] = implode('_', $index['columns']); |
|
199 | + if (empty($index['name'])) { |
|
200 | + $index['name'] = implode('_', $index['columns']); |
|
201 | + } |
|
194 | 202 | $index_queries[] = 'CREATE ' . (isset($index['type']) && $index['type'] == 'unique' ? 'UNIQUE' : '') . ' INDEX ' . $table_name . '_' . $index['name'] . ' ON ' . $table_name . ' (' . $columns . ')'; |
195 | 203 | } |
196 | 204 | } |
197 | 205 | |
198 | 206 | // No trailing commas! |
199 | - if (substr($table_query, -1) == ',') |
|
200 | - $table_query = substr($table_query, 0, -1); |
|
207 | + if (substr($table_query, -1) == ',') { |
|
208 | + $table_query = substr($table_query, 0, -1); |
|
209 | + } |
|
201 | 210 | |
202 | 211 | $table_query .= ')'; |
203 | 212 | |
@@ -242,18 +251,20 @@ discard block |
||
242 | 251 | } |
243 | 252 | |
244 | 253 | // And the indexes... |
245 | - foreach ($index_queries as $query) |
|
246 | - $smcFunc['db_query']('', $query, |
|
254 | + foreach ($index_queries as $query) { |
|
255 | + $smcFunc['db_query']('', $query, |
|
247 | 256 | array( |
248 | 257 | 'security_override' => true, |
249 | 258 | ) |
250 | 259 | ); |
260 | + } |
|
251 | 261 | |
252 | 262 | // Go, go power rangers! |
253 | 263 | $smcFunc['db_transaction']('commit'); |
254 | 264 | |
255 | - if ($old_table_exists) |
|
256 | - $smcFunc['db_drop_table']($table_name . '_old'); |
|
265 | + if ($old_table_exists) { |
|
266 | + $smcFunc['db_drop_table']($table_name . '_old'); |
|
267 | + } |
|
257 | 268 | |
258 | 269 | return true; |
259 | 270 | } |
@@ -278,8 +289,9 @@ discard block |
||
278 | 289 | $table_name = str_replace('{db_prefix}', $db_prefix, $table_name); |
279 | 290 | |
280 | 291 | // God no - dropping one of these = bad. |
281 | - if (in_array(strtolower($table_name), $reservedTables)) |
|
282 | - return false; |
|
292 | + if (in_array(strtolower($table_name), $reservedTables)) { |
|
293 | + return false; |
|
294 | + } |
|
283 | 295 | |
284 | 296 | // Does it exist? |
285 | 297 | if (in_array($full_table_name, $smcFunc['db_list_tables']())) |
@@ -337,21 +349,24 @@ discard block |
||
337 | 349 | |
338 | 350 | // Does it exist - if so don't add it again! |
339 | 351 | $columns = $smcFunc['db_list_columns']($table_name, false); |
340 | - foreach ($columns as $column) |
|
341 | - if ($column == $column_info['name']) |
|
352 | + foreach ($columns as $column) { |
|
353 | + if ($column == $column_info['name']) |
|
342 | 354 | { |
343 | 355 | // If we're going to overwrite then use change column. |
344 | 356 | if ($if_exists == 'update') |
345 | 357 | return $smcFunc['db_change_column']($table_name, $column_info['name'], $column_info); |
346 | - else |
|
347 | - return false; |
|
358 | + } |
|
359 | + else { |
|
360 | + return false; |
|
361 | + } |
|
348 | 362 | } |
349 | 363 | |
350 | 364 | // Get the specifics... |
351 | 365 | $column_info['size'] = isset($column_info['size']) && is_numeric($column_info['size']) ? $column_info['size'] : null; |
352 | 366 | list ($type, $size) = $smcFunc['db_calculate_type']($column_info['type'], $column_info['size']); |
353 | - if ($size !== null) |
|
354 | - $type = $type . '(' . $size . ')'; |
|
367 | + if ($size !== null) { |
|
368 | + $type = $type . '(' . $size . ')'; |
|
369 | + } |
|
355 | 370 | |
356 | 371 | // Now add the thing! |
357 | 372 | $query = ' |
@@ -366,11 +381,12 @@ discard block |
||
366 | 381 | // If there's more attributes they need to be done via a change on PostgreSQL. |
367 | 382 | unset($column_info['type'], $column_info['size']); |
368 | 383 | |
369 | - if (count($column_info) != 1) |
|
370 | - return $smcFunc['db_change_column']($table_name, $column_info['name'], $column_info); |
|
371 | - else |
|
372 | - return true; |
|
373 | -} |
|
384 | + if (count($column_info) != 1) { |
|
385 | + return $smcFunc['db_change_column']($table_name, $column_info['name'], $column_info); |
|
386 | + } else { |
|
387 | + return true; |
|
388 | + } |
|
389 | + } |
|
374 | 390 | |
375 | 391 | /** |
376 | 392 | * Removes a column. |
@@ -389,8 +405,8 @@ discard block |
||
389 | 405 | |
390 | 406 | // Does it exist? |
391 | 407 | $columns = $smcFunc['db_list_columns']($table_name, true); |
392 | - foreach ($columns as $column) |
|
393 | - if ($column['name'] == $column_name) |
|
408 | + foreach ($columns as $column) { |
|
409 | + if ($column['name'] == $column_name) |
|
394 | 410 | { |
395 | 411 | // If there is an auto we need remove it! |
396 | 412 | if ($column['auto']) |
@@ -400,6 +416,7 @@ discard block |
||
400 | 416 | 'security_override' => true, |
401 | 417 | ) |
402 | 418 | ); |
419 | + } |
|
403 | 420 | |
404 | 421 | $smcFunc['db_query']('', ' |
405 | 422 | ALTER TABLE ' . $table_name . ' |
@@ -433,13 +450,15 @@ discard block |
||
433 | 450 | // Check it does exist! |
434 | 451 | $columns = $smcFunc['db_list_columns']($table_name, true); |
435 | 452 | $old_info = null; |
436 | - foreach ($columns as $column) |
|
437 | - if ($column['name'] == $old_column) |
|
453 | + foreach ($columns as $column) { |
|
454 | + if ($column['name'] == $old_column) |
|
438 | 455 | $old_info = $column; |
456 | + } |
|
439 | 457 | |
440 | 458 | // Nothing? |
441 | - if ($old_info == null) |
|
442 | - return false; |
|
459 | + if ($old_info == null) { |
|
460 | + return false; |
|
461 | + } |
|
443 | 462 | |
444 | 463 | // Now we check each bit individually and ALTER as required. |
445 | 464 | if (isset($column_info['name']) && $column_info['name'] != $old_column) |
@@ -496,8 +515,9 @@ discard block |
||
496 | 515 | { |
497 | 516 | $column_info['size'] = isset($column_info['size']) && is_numeric($column_info['size']) ? $column_info['size'] : null; |
498 | 517 | list ($type, $size) = $smcFunc['db_calculate_type']($column_info['type'], $column_info['size']); |
499 | - if ($size !== null) |
|
500 | - $type = $type . '(' . $size . ')'; |
|
518 | + if ($size !== null) { |
|
519 | + $type = $type . '(' . $size . ')'; |
|
520 | + } |
|
501 | 521 | |
502 | 522 | // The alter is a pain. |
503 | 523 | $smcFunc['db_transaction']('begin'); |
@@ -598,21 +618,23 @@ discard block |
||
598 | 618 | $table_name = str_replace('{db_prefix}', $db_prefix, $table_name); |
599 | 619 | |
600 | 620 | // No columns = no index. |
601 | - if (empty($index_info['columns'])) |
|
602 | - return false; |
|
621 | + if (empty($index_info['columns'])) { |
|
622 | + return false; |
|
623 | + } |
|
603 | 624 | $columns = implode(',', $index_info['columns']); |
604 | 625 | |
605 | 626 | // No name - make it up! |
606 | 627 | if (empty($index_info['name'])) |
607 | 628 | { |
608 | 629 | // No need for primary. |
609 | - if (isset($index_info['type']) && $index_info['type'] == 'primary') |
|
610 | - $index_info['name'] = ''; |
|
611 | - else |
|
612 | - $index_info['name'] = $table_name . implode('_', $index_info['columns']); |
|
630 | + if (isset($index_info['type']) && $index_info['type'] == 'primary') { |
|
631 | + $index_info['name'] = ''; |
|
632 | + } else { |
|
633 | + $index_info['name'] = $table_name . implode('_', $index_info['columns']); |
|
634 | + } |
|
635 | + } else { |
|
636 | + $index_info['name'] = $table_name . $index_info['name']; |
|
613 | 637 | } |
614 | - else |
|
615 | - $index_info['name'] = $table_name . $index_info['name']; |
|
616 | 638 | |
617 | 639 | // Log that we are going to want to remove this! |
618 | 640 | $db_package_log[] = array('remove_index', $table_name, $index_info['name']); |
@@ -625,10 +647,11 @@ discard block |
||
625 | 647 | if ($index['name'] == $index_info['name'] || ($index['type'] == 'primary' && isset($index_info['type']) && $index_info['type'] == 'primary')) |
626 | 648 | { |
627 | 649 | // If we want to overwrite simply remove the current one then continue. |
628 | - if ($if_exists != 'update' || $index['type'] == 'primary') |
|
629 | - return false; |
|
630 | - else |
|
631 | - $smcFunc['db_remove_index']($table_name, $index_info['name']); |
|
650 | + if ($if_exists != 'update' || $index['type'] == 'primary') { |
|
651 | + return false; |
|
652 | + } else { |
|
653 | + $smcFunc['db_remove_index']($table_name, $index_info['name']); |
|
654 | + } |
|
632 | 655 | } |
633 | 656 | } |
634 | 657 | |
@@ -642,8 +665,7 @@ discard block |
||
642 | 665 | 'security_override' => true, |
643 | 666 | ) |
644 | 667 | ); |
645 | - } |
|
646 | - else |
|
668 | + } else |
|
647 | 669 | { |
648 | 670 | $smcFunc['db_query']('', ' |
649 | 671 | CREATE ' . (isset($index_info['type']) && $index_info['type'] == 'unique' ? 'UNIQUE' : '') . ' INDEX ' . $index_info['name'] . ' ON ' . $table_name . ' (' . $columns . ')', |
@@ -671,8 +693,9 @@ discard block |
||
671 | 693 | |
672 | 694 | // Better exist! |
673 | 695 | $indexes = $smcFunc['db_list_indexes']($table_name, true); |
674 | - if ($index_name != 'primary') |
|
675 | - $index_name = $table_name . '_' . $index_name; |
|
696 | + if ($index_name != 'primary') { |
|
697 | + $index_name = $table_name . '_' . $index_name; |
|
698 | + } |
|
676 | 699 | |
677 | 700 | foreach ($indexes as $index) |
678 | 701 | { |
@@ -736,8 +759,7 @@ discard block |
||
736 | 759 | 'datetime' => 'timestamp without time zone', |
737 | 760 | 'timestamp' => 'timestamp without time zone', |
738 | 761 | ); |
739 | - } |
|
740 | - else |
|
762 | + } else |
|
741 | 763 | { |
742 | 764 | $types = array( |
743 | 765 | 'character varying' => 'varchar', |
@@ -753,14 +775,16 @@ discard block |
||
753 | 775 | // Got it? Change it! |
754 | 776 | if (isset($types[$type_name])) |
755 | 777 | { |
756 | - if ($type_name == 'tinytext') |
|
757 | - $type_size = 255; |
|
778 | + if ($type_name == 'tinytext') { |
|
779 | + $type_size = 255; |
|
780 | + } |
|
758 | 781 | $type_name = $types[$type_name]; |
759 | 782 | } |
760 | 783 | |
761 | 784 | // Only char fields got size |
762 | - if (strpos($type_name, 'char') === false) |
|
763 | - $type_size = null; |
|
785 | + if (strpos($type_name, 'char') === false) { |
|
786 | + $type_size = null; |
|
787 | + } |
|
764 | 788 | |
765 | 789 | |
766 | 790 | return array($type_name, $type_size); |
@@ -816,8 +840,7 @@ discard block |
||
816 | 840 | if (!$detail) |
817 | 841 | { |
818 | 842 | $columns[] = $row['column_name']; |
819 | - } |
|
820 | - else |
|
843 | + } else |
|
821 | 844 | { |
822 | 845 | $auto = false; |
823 | 846 | // What is the default? |
@@ -825,11 +848,11 @@ discard block |
||
825 | 848 | { |
826 | 849 | $default = null; |
827 | 850 | $auto = true; |
851 | + } elseif (trim($row['column_default']) != '') { |
|
852 | + $default = strpos($row['column_default'], '::') === false ? $row['column_default'] : substr($row['column_default'], 0, strpos($row['column_default'], '::')); |
|
853 | + } else { |
|
854 | + $default = null; |
|
828 | 855 | } |
829 | - elseif (trim($row['column_default']) != '') |
|
830 | - $default = strpos($row['column_default'], '::') === false ? $row['column_default'] : substr($row['column_default'], 0, strpos($row['column_default'], '::')); |
|
831 | - else |
|
832 | - $default = null; |
|
833 | 856 | |
834 | 857 | // Make the type generic. |
835 | 858 | list ($type, $size) = $smcFunc['db_calculate_type']($row['data_type'], $row['character_maximum_length'], true); |
@@ -880,26 +903,30 @@ discard block |
||
880 | 903 | while ($row = $smcFunc['db_fetch_assoc']($result)) |
881 | 904 | { |
882 | 905 | // Try get the columns that make it up. |
883 | - if (preg_match('~\(([^\)]+?)\)~i', $row['inddef'], $matches) == 0) |
|
884 | - continue; |
|
906 | + if (preg_match('~\(([^\)]+?)\)~i', $row['inddef'], $matches) == 0) { |
|
907 | + continue; |
|
908 | + } |
|
885 | 909 | |
886 | 910 | $columns = explode(',', $matches[1]); |
887 | 911 | |
888 | - if (empty($columns)) |
|
889 | - continue; |
|
912 | + if (empty($columns)) { |
|
913 | + continue; |
|
914 | + } |
|
890 | 915 | |
891 | - foreach ($columns as $k => $v) |
|
892 | - $columns[$k] = trim($v); |
|
916 | + foreach ($columns as $k => $v) { |
|
917 | + $columns[$k] = trim($v); |
|
918 | + } |
|
893 | 919 | |
894 | 920 | // Fix up the name to be consistent cross databases |
895 | - if (substr($row['name'], -5) == '_pkey' && $row['is_primary'] == 1) |
|
896 | - $row['name'] = 'PRIMARY'; |
|
897 | - else |
|
898 | - $row['name'] = str_replace($table_name . '_', '', $row['name']); |
|
921 | + if (substr($row['name'], -5) == '_pkey' && $row['is_primary'] == 1) { |
|
922 | + $row['name'] = 'PRIMARY'; |
|
923 | + } else { |
|
924 | + $row['name'] = str_replace($table_name . '_', '', $row['name']); |
|
925 | + } |
|
899 | 926 | |
900 | - if (!$detail) |
|
901 | - $indexes[] = $row['name']; |
|
902 | - else |
|
927 | + if (!$detail) { |
|
928 | + $indexes[] = $row['name']; |
|
929 | + } else |
|
903 | 930 | { |
904 | 931 | $indexes[$row['name']] = array( |
905 | 932 | 'name' => $row['name'], |
@@ -67,8 +67,9 @@ discard block |
||
67 | 67 | foreach ($context['categories'] as $category) |
68 | 68 | { |
69 | 69 | // If theres no parent boards we can see, avoid showing an empty category (unless its collapsed) |
70 | - if (empty($category['boards']) && !$category['is_collapsed']) |
|
71 | - continue; |
|
70 | + if (empty($category['boards']) && !$category['is_collapsed']) { |
|
71 | + continue; |
|
72 | + } |
|
72 | 73 | |
73 | 74 | echo ' |
74 | 75 | <div class="main_container"> |
@@ -76,9 +77,10 @@ discard block |
||
76 | 77 | <h3 class="catbg">'; |
77 | 78 | |
78 | 79 | // If this category even can collapse, show a link to collapse it. |
79 | - if ($category['can_collapse']) |
|
80 | - echo ' |
|
80 | + if ($category['can_collapse']) { |
|
81 | + echo ' |
|
81 | 82 | <span id="category_', $category['id'], '_upshrink" class="', $category['is_collapsed'] ? 'toggle_down' : 'toggle_up', ' floatright" data-collapsed="', (int) $category['is_collapsed'], '" title="', !$category['is_collapsed'] ? $txt['hide_category'] : $txt['show_category'], '" style="display: none;"></span>'; |
83 | + } |
|
82 | 84 | |
83 | 85 | echo ' |
84 | 86 | ', $category['link'], ' |
@@ -108,10 +110,11 @@ discard block |
||
108 | 110 | </div>'; |
109 | 111 | |
110 | 112 | // Won't somebody think of the children! |
111 | - if (function_exists('template_bi_' . $board['type'] . '_children')) |
|
112 | - call_user_func('template_bi_' . $board['type'] . '_children', $board); |
|
113 | - else |
|
114 | - template_bi_board_children($board); |
|
113 | + if (function_exists('template_bi_' . $board['type'] . '_children')) { |
|
114 | + call_user_func('template_bi_' . $board['type'] . '_children', $board); |
|
115 | + } else { |
|
116 | + template_bi_board_children($board); |
|
117 | + } |
|
115 | 118 | |
116 | 119 | echo ' |
117 | 120 | </div>'; |
@@ -126,10 +129,11 @@ discard block |
||
126 | 129 | </div>'; |
127 | 130 | |
128 | 131 | // Show the mark all as read button? |
129 | - if ($context['user']['is_logged'] && !empty($context['categories'])) |
|
130 | - echo ' |
|
132 | + if ($context['user']['is_logged'] && !empty($context['categories'])) { |
|
133 | + echo ' |
|
131 | 134 | <div class="mark_read">', template_button_strip($context['mark_read_button'], 'right'), '</div>'; |
132 | -} |
|
135 | + } |
|
136 | + } |
|
133 | 137 | |
134 | 138 | /** |
135 | 139 | * Outputs the board icon for a standard board. |
@@ -173,18 +177,20 @@ discard block |
||
173 | 177 | </a>'; |
174 | 178 | |
175 | 179 | // Has it outstanding posts for approval? |
176 | - if ($board['can_approve_posts'] && ($board['unapproved_posts'] || $board['unapproved_topics'])) |
|
177 | - echo ' |
|
180 | + if ($board['can_approve_posts'] && ($board['unapproved_posts'] || $board['unapproved_topics'])) { |
|
181 | + echo ' |
|
178 | 182 | <a href="', $scripturl, '?action=moderate;area=postmod;sa=', ($board['unapproved_topics'] > 0 ? 'topics' : 'posts'), ';brd=', $board['id'], ';', $context['session_var'], '=', $context['session_id'], '" title="', sprintf($txt['unapproved_posts'], $board['unapproved_topics'], $board['unapproved_posts']), '" class="moderation_link">(!)</a>'; |
183 | + } |
|
179 | 184 | |
180 | 185 | echo ' |
181 | 186 | <p class="board_description">', $board['description'], '</p>'; |
182 | 187 | |
183 | 188 | // Show the "Moderators: ". Each has name, href, link, and id. (but we're gonna use link_moderators.) |
184 | - if (!empty($board['link_moderators'])) |
|
185 | - echo ' |
|
189 | + if (!empty($board['link_moderators'])) { |
|
190 | + echo ' |
|
186 | 191 | <p class="moderators">', count($board['link_moderators']) == 1 ? $txt['moderator'] : $txt['moderators'], ': ', implode(', ', $board['link_moderators']), '</p>'; |
187 | -} |
|
192 | + } |
|
193 | + } |
|
188 | 194 | |
189 | 195 | /** |
190 | 196 | * Outputs the board stats for a standard board. |
@@ -223,10 +229,11 @@ discard block |
||
223 | 229 | */ |
224 | 230 | function template_bi_board_lastpost($board) |
225 | 231 | { |
226 | - if (!empty($board['last_post']['id'])) |
|
227 | - echo ' |
|
232 | + if (!empty($board['last_post']['id'])) { |
|
233 | + echo ' |
|
228 | 234 | <p>', $board['last_post']['last_post_message'], '</p>'; |
229 | -} |
|
235 | + } |
|
236 | + } |
|
230 | 237 | |
231 | 238 | /** |
232 | 239 | * Outputs the board children for a standard board. |
@@ -246,14 +253,16 @@ discard block |
||
246 | 253 | id, name, description, new (is it new?), topics (#), posts (#), href, link, and last_post. */ |
247 | 254 | foreach ($board['children'] as $child) |
248 | 255 | { |
249 | - if (!$child['is_redirect']) |
|
250 | - $child['link'] = ''. ($child['new'] ? '<a href="' . $scripturl . '?action=unread;board=' . $child['id'] . '" title="' . $txt['new_posts'] . ' (' . $txt['board_topics'] . ': ' . comma_format($child['topics']) . ', ' . $txt['posts'] . ': ' . comma_format($child['posts']) . ')"><span class="new_posts">' . $txt['new'] . '</span></a>' : '') . '<a href="' . $child['href'] . '" ' . ($child['new'] ? 'class="board_new_posts" ' : '') . 'title="' . ($child['new'] ? $txt['new_posts'] : $txt['old_posts']) . ' (' . $txt['board_topics'] . ': ' . comma_format($child['topics']) . ', ' . $txt['posts'] . ': ' . comma_format($child['posts']) . ')">' . $child['name'] . '</a>'; |
|
251 | - else |
|
252 | - $child['link'] = '<a href="' . $child['href'] . '" title="' . comma_format($child['posts']) . ' ' . $txt['redirects'] . ' - ' . $child['short_description'] . '">' . $child['name'] . '</a>'; |
|
256 | + if (!$child['is_redirect']) { |
|
257 | + $child['link'] = ''. ($child['new'] ? '<a href="' . $scripturl . '?action=unread;board=' . $child['id'] . '" title="' . $txt['new_posts'] . ' (' . $txt['board_topics'] . ': ' . comma_format($child['topics']) . ', ' . $txt['posts'] . ': ' . comma_format($child['posts']) . ')"><span class="new_posts">' . $txt['new'] . '</span></a>' : '') . '<a href="' . $child['href'] . '" ' . ($child['new'] ? 'class="board_new_posts" ' : '') . 'title="' . ($child['new'] ? $txt['new_posts'] : $txt['old_posts']) . ' (' . $txt['board_topics'] . ': ' . comma_format($child['topics']) . ', ' . $txt['posts'] . ': ' . comma_format($child['posts']) . ')">' . $child['name'] . '</a>'; |
|
258 | + } else { |
|
259 | + $child['link'] = '<a href="' . $child['href'] . '" title="' . comma_format($child['posts']) . ' ' . $txt['redirects'] . ' - ' . $child['short_description'] . '">' . $child['name'] . '</a>'; |
|
260 | + } |
|
253 | 261 | |
254 | 262 | // Has it posts awaiting approval? |
255 | - if ($child['can_approve_posts'] && ($child['unapproved_posts'] || $child['unapproved_topics'])) |
|
256 | - $child['link'] .= ' <a href="' . $scripturl . '?action=moderate;area=postmod;sa=' . ($child['unapproved_topics'] > 0 ? 'topics' : 'posts') . ';brd=' . $child['id'] . ';' . $context['session_var'] . '=' . $context['session_id'] . '" title="' . sprintf($txt['unapproved_posts'], $child['unapproved_topics'], $child['unapproved_posts']) . '" class="moderation_link">(!)</a>'; |
|
263 | + if ($child['can_approve_posts'] && ($child['unapproved_posts'] || $child['unapproved_topics'])) { |
|
264 | + $child['link'] .= ' <a href="' . $scripturl . '?action=moderate;area=postmod;sa=' . ($child['unapproved_topics'] > 0 ? 'topics' : 'posts') . ';brd=' . $child['id'] . ';' . $context['session_var'] . '=' . $context['session_id'] . '" title="' . sprintf($txt['unapproved_posts'], $child['unapproved_topics'], $child['unapproved_posts']) . '" class="moderation_link">(!)</a>'; |
|
265 | + } |
|
257 | 266 | |
258 | 267 | $children[] = $child['new'] ? '<span class="strong">' . $child['link'] . '</span>' : '<span>' . $child['link'] . '</span>'; |
259 | 268 | } |
@@ -280,8 +289,9 @@ discard block |
||
280 | 289 | { |
281 | 290 | global $context, $options, $txt; |
282 | 291 | |
283 | - if (empty($context['info_center'])) |
|
284 | - return; |
|
292 | + if (empty($context['info_center'])) { |
|
293 | + return; |
|
294 | + } |
|
285 | 295 | |
286 | 296 | // Here's where the "Info Center" starts... |
287 | 297 | echo ' |
@@ -381,14 +391,15 @@ discard block |
||
381 | 391 | /* Each post in latest_posts has: |
382 | 392 | board (with an id, name, and link.), topic (the topic's id.), poster (with id, name, and link.), |
383 | 393 | subject, short_subject (shortened with...), time, link, and href. */ |
384 | - foreach ($context['latest_posts'] as $post) |
|
385 | - echo ' |
|
394 | + foreach ($context['latest_posts'] as $post) { |
|
395 | + echo ' |
|
386 | 396 | <tr class="windowbg"> |
387 | 397 | <td class="recentpost"><strong>', $post['link'], '</strong></td> |
388 | 398 | <td class="recentposter">', $post['poster']['link'], '</td> |
389 | 399 | <td class="recentboard">', $post['board']['link'], '</td> |
390 | 400 | <td class="recenttime">', $post['time'], '</td> |
391 | 401 | </tr>'; |
402 | + } |
|
392 | 403 | echo ' |
393 | 404 | </table>'; |
394 | 405 | } |
@@ -412,9 +423,10 @@ discard block |
||
412 | 423 | </div>'; |
413 | 424 | |
414 | 425 | // Holidays like "Christmas", "Chanukah", and "We Love [Unknown] Day" :P. |
415 | - if (!empty($context['calendar_holidays'])) |
|
416 | - echo ' |
|
426 | + if (!empty($context['calendar_holidays'])) { |
|
427 | + echo ' |
|
417 | 428 | <p class="inline holiday"><span>', $txt['calendar_prompt'], '</span> ', implode(', ', $context['calendar_holidays']), '</p>'; |
429 | + } |
|
418 | 430 | |
419 | 431 | // People's birthdays. Like mine. And yours, I guess. Kidding. |
420 | 432 | if (!empty($context['calendar_birthdays'])) |
@@ -423,9 +435,10 @@ discard block |
||
423 | 435 | <p class="inline"> |
424 | 436 | <span class="birthday">', $context['calendar_only_today'] ? $txt['birthdays'] : $txt['birthdays_upcoming'], '</span>'; |
425 | 437 | // Each member in calendar_birthdays has: id, name (person), age (if they have one set?), is_last. (last in list?), and is_today (birthday is today?) |
426 | - foreach ($context['calendar_birthdays'] as $member) |
|
427 | - echo ' |
|
438 | + foreach ($context['calendar_birthdays'] as $member) { |
|
439 | + echo ' |
|
428 | 440 | <a href="', $scripturl, '?action=profile;u=', $member['id'], '">', $member['is_today'] ? '<strong class="fix_rtl_names">' : '', $member['name'], $member['is_today'] ? '</strong>' : '', isset($member['age']) ? ' (' . $member['age'] . ')' : '', '</a>', $member['is_last'] ? '' : ', '; |
441 | + } |
|
429 | 442 | echo ' |
430 | 443 | </p>'; |
431 | 444 | } |
@@ -439,9 +452,10 @@ discard block |
||
439 | 452 | |
440 | 453 | // Each event in calendar_events should have: |
441 | 454 | // title, href, is_last, can_edit (are they allowed?), modify_href, and is_today. |
442 | - foreach ($context['calendar_events'] as $event) |
|
443 | - echo ' |
|
455 | + foreach ($context['calendar_events'] as $event) { |
|
456 | + echo ' |
|
444 | 457 | ', $event['can_edit'] ? '<a href="' . $event['modify_href'] . '" title="' . $txt['calendar_edit'] . '"><span class="generic_icons calendar_modify"></span></a> ' : '', $event['href'] == '' ? '' : '<a href="' . $event['href'] . '">', $event['is_today'] ? '<strong>' . $event['title'] . '</strong>' : $event['title'], $event['href'] == '' ? '' : '</a>', $event['is_last'] ? '<br>' : ', '; |
458 | + } |
|
445 | 459 | echo ' |
446 | 460 | </p>'; |
447 | 461 | } |
@@ -486,15 +500,19 @@ discard block |
||
486 | 500 | |
487 | 501 | // Handle hidden users and buddies. |
488 | 502 | $bracketList = array(); |
489 | - if ($context['show_buddies']) |
|
490 | - $bracketList[] = comma_format($context['num_buddies']) . ' ' . ($context['num_buddies'] == 1 ? $txt['buddy'] : $txt['buddies']); |
|
491 | - if (!empty($context['num_spiders'])) |
|
492 | - $bracketList[] = comma_format($context['num_spiders']) . ' ' . ($context['num_spiders'] == 1 ? $txt['spider'] : $txt['spiders']); |
|
493 | - if (!empty($context['num_users_hidden'])) |
|
494 | - $bracketList[] = comma_format($context['num_users_hidden']) . ' ' . ($context['num_spiders'] == 1 ? $txt['hidden'] : $txt['hidden_s']); |
|
503 | + if ($context['show_buddies']) { |
|
504 | + $bracketList[] = comma_format($context['num_buddies']) . ' ' . ($context['num_buddies'] == 1 ? $txt['buddy'] : $txt['buddies']); |
|
505 | + } |
|
506 | + if (!empty($context['num_spiders'])) { |
|
507 | + $bracketList[] = comma_format($context['num_spiders']) . ' ' . ($context['num_spiders'] == 1 ? $txt['spider'] : $txt['spiders']); |
|
508 | + } |
|
509 | + if (!empty($context['num_users_hidden'])) { |
|
510 | + $bracketList[] = comma_format($context['num_users_hidden']) . ' ' . ($context['num_spiders'] == 1 ? $txt['hidden'] : $txt['hidden_s']); |
|
511 | + } |
|
495 | 512 | |
496 | - if (!empty($bracketList)) |
|
497 | - echo ' (' . implode(', ', $bracketList) . ')'; |
|
513 | + if (!empty($bracketList)) { |
|
514 | + echo ' (' . implode(', ', $bracketList) . ')'; |
|
515 | + } |
|
498 | 516 | |
499 | 517 | echo $context['show_who'] ? '</a>' : '', ' |
500 | 518 | |
@@ -508,9 +526,10 @@ discard block |
||
508 | 526 | ', sprintf($txt['users_active'], $modSettings['lastActive']), ': ', implode(', ', $context['list_users_online']); |
509 | 527 | |
510 | 528 | // Showing membergroups? |
511 | - if (!empty($settings['show_group_key']) && !empty($context['membergroups'])) |
|
512 | - echo ' |
|
529 | + if (!empty($settings['show_group_key']) && !empty($context['membergroups'])) { |
|
530 | + echo ' |
|
513 | 531 | <span class="membergroups">' . implode(', ', $context['membergroups']) . '</span>'; |
532 | + } |
|
514 | 533 | } |
515 | 534 | |
516 | 535 | echo ' |
@@ -13,8 +13,9 @@ discard block |
||
13 | 13 | * @version 2.1 Beta 4 |
14 | 14 | */ |
15 | 15 | |
16 | -if (!defined('SMF')) |
|
16 | +if (!defined('SMF')) { |
|
17 | 17 | die('No direct access...'); |
18 | +} |
|
18 | 19 | |
19 | 20 | /** |
20 | 21 | * Update some basic statistics. |
@@ -122,10 +123,11 @@ discard block |
||
122 | 123 | $smcFunc['db_free_result']($result); |
123 | 124 | |
124 | 125 | // Add this to the number of unapproved members |
125 | - if (!empty($changes['unapprovedMembers'])) |
|
126 | - $changes['unapprovedMembers'] += $coppa_approvals; |
|
127 | - else |
|
128 | - $changes['unapprovedMembers'] = $coppa_approvals; |
|
126 | + if (!empty($changes['unapprovedMembers'])) { |
|
127 | + $changes['unapprovedMembers'] += $coppa_approvals; |
|
128 | + } else { |
|
129 | + $changes['unapprovedMembers'] = $coppa_approvals; |
|
130 | + } |
|
129 | 131 | } |
130 | 132 | } |
131 | 133 | } |
@@ -133,9 +135,9 @@ discard block |
||
133 | 135 | break; |
134 | 136 | |
135 | 137 | case 'message': |
136 | - if ($parameter1 === true && $parameter2 !== null) |
|
137 | - updateSettings(array('totalMessages' => true, 'maxMsgID' => $parameter2), true); |
|
138 | - else |
|
138 | + if ($parameter1 === true && $parameter2 !== null) { |
|
139 | + updateSettings(array('totalMessages' => true, 'maxMsgID' => $parameter2), true); |
|
140 | + } else |
|
139 | 141 | { |
140 | 142 | // SUM and MAX on a smaller table is better for InnoDB tables. |
141 | 143 | $result = $smcFunc['db_query']('', ' |
@@ -175,23 +177,25 @@ discard block |
||
175 | 177 | $parameter2 = text2words($parameter2); |
176 | 178 | |
177 | 179 | $inserts = array(); |
178 | - foreach ($parameter2 as $word) |
|
179 | - $inserts[] = array($word, $parameter1); |
|
180 | + foreach ($parameter2 as $word) { |
|
181 | + $inserts[] = array($word, $parameter1); |
|
182 | + } |
|
180 | 183 | |
181 | - if (!empty($inserts)) |
|
182 | - $smcFunc['db_insert']('ignore', |
|
184 | + if (!empty($inserts)) { |
|
185 | + $smcFunc['db_insert']('ignore', |
|
183 | 186 | '{db_prefix}log_search_subjects', |
184 | 187 | array('word' => 'string', 'id_topic' => 'int'), |
185 | 188 | $inserts, |
186 | 189 | array('word', 'id_topic') |
187 | 190 | ); |
191 | + } |
|
188 | 192 | } |
189 | 193 | break; |
190 | 194 | |
191 | 195 | case 'topic': |
192 | - if ($parameter1 === true) |
|
193 | - updateSettings(array('totalTopics' => true), true); |
|
194 | - else |
|
196 | + if ($parameter1 === true) { |
|
197 | + updateSettings(array('totalTopics' => true), true); |
|
198 | + } else |
|
195 | 199 | { |
196 | 200 | // Get the number of topics - a SUM is better for InnoDB tables. |
197 | 201 | // We also ignore the recycle bin here because there will probably be a bunch of one-post topics there. |
@@ -212,8 +216,9 @@ discard block |
||
212 | 216 | |
213 | 217 | case 'postgroups': |
214 | 218 | // Parameter two is the updated columns: we should check to see if we base groups off any of these. |
215 | - if ($parameter2 !== null && !in_array('posts', $parameter2)) |
|
216 | - return; |
|
219 | + if ($parameter2 !== null && !in_array('posts', $parameter2)) { |
|
220 | + return; |
|
221 | + } |
|
217 | 222 | |
218 | 223 | $postgroups = cache_get_data('updateStats:postgroups', 360); |
219 | 224 | if ($postgroups == null || $parameter1 == null) |
@@ -228,8 +233,9 @@ discard block |
||
228 | 233 | ) |
229 | 234 | ); |
230 | 235 | $postgroups = array(); |
231 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
232 | - $postgroups[$row['id_group']] = $row['min_posts']; |
|
236 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
237 | + $postgroups[$row['id_group']] = $row['min_posts']; |
|
238 | + } |
|
233 | 239 | $smcFunc['db_free_result']($request); |
234 | 240 | |
235 | 241 | // Sort them this way because if it's done with MySQL it causes a filesort :(. |
@@ -239,8 +245,9 @@ discard block |
||
239 | 245 | } |
240 | 246 | |
241 | 247 | // Oh great, they've screwed their post groups. |
242 | - if (empty($postgroups)) |
|
243 | - return; |
|
248 | + if (empty($postgroups)) { |
|
249 | + return; |
|
250 | + } |
|
244 | 251 | |
245 | 252 | // Set all membergroups from most posts to least posts. |
246 | 253 | $conditions = ''; |
@@ -298,10 +305,9 @@ discard block |
||
298 | 305 | { |
299 | 306 | $condition = 'id_member IN ({array_int:members})'; |
300 | 307 | $parameters['members'] = $members; |
301 | - } |
|
302 | - elseif ($members === null) |
|
303 | - $condition = '1=1'; |
|
304 | - else |
|
308 | + } elseif ($members === null) { |
|
309 | + $condition = '1=1'; |
|
310 | + } else |
|
305 | 311 | { |
306 | 312 | $condition = 'id_member = {int:member}'; |
307 | 313 | $parameters['member'] = $members; |
@@ -341,9 +347,9 @@ discard block |
||
341 | 347 | if (count($vars_to_integrate) != 0) |
342 | 348 | { |
343 | 349 | // Fetch a list of member_names if necessary |
344 | - if ((!is_array($members) && $members === $user_info['id']) || (is_array($members) && count($members) == 1 && in_array($user_info['id'], $members))) |
|
345 | - $member_names = array($user_info['username']); |
|
346 | - else |
|
350 | + if ((!is_array($members) && $members === $user_info['id']) || (is_array($members) && count($members) == 1 && in_array($user_info['id'], $members))) { |
|
351 | + $member_names = array($user_info['username']); |
|
352 | + } else |
|
347 | 353 | { |
348 | 354 | $member_names = array(); |
349 | 355 | $request = $smcFunc['db_query']('', ' |
@@ -352,14 +358,16 @@ discard block |
||
352 | 358 | WHERE ' . $condition, |
353 | 359 | $parameters |
354 | 360 | ); |
355 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
356 | - $member_names[] = $row['member_name']; |
|
361 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
362 | + $member_names[] = $row['member_name']; |
|
363 | + } |
|
357 | 364 | $smcFunc['db_free_result']($request); |
358 | 365 | } |
359 | 366 | |
360 | - if (!empty($member_names)) |
|
361 | - foreach ($vars_to_integrate as $var) |
|
367 | + if (!empty($member_names)) { |
|
368 | + foreach ($vars_to_integrate as $var) |
|
362 | 369 | call_integration_hook('integrate_change_member_data', array($member_names, $var, &$data[$var], &$knownInts, &$knownFloats)); |
370 | + } |
|
363 | 371 | } |
364 | 372 | } |
365 | 373 | |
@@ -367,16 +375,17 @@ discard block |
||
367 | 375 | foreach ($data as $var => $val) |
368 | 376 | { |
369 | 377 | $type = 'string'; |
370 | - if (in_array($var, $knownInts)) |
|
371 | - $type = 'int'; |
|
372 | - elseif (in_array($var, $knownFloats)) |
|
373 | - $type = 'float'; |
|
374 | - elseif ($var == 'birthdate') |
|
375 | - $type = 'date'; |
|
376 | - elseif ($var == 'member_ip') |
|
377 | - $type = 'inet'; |
|
378 | - elseif ($var == 'member_ip2') |
|
379 | - $type = 'inet'; |
|
378 | + if (in_array($var, $knownInts)) { |
|
379 | + $type = 'int'; |
|
380 | + } elseif (in_array($var, $knownFloats)) { |
|
381 | + $type = 'float'; |
|
382 | + } elseif ($var == 'birthdate') { |
|
383 | + $type = 'date'; |
|
384 | + } elseif ($var == 'member_ip') { |
|
385 | + $type = 'inet'; |
|
386 | + } elseif ($var == 'member_ip2') { |
|
387 | + $type = 'inet'; |
|
388 | + } |
|
380 | 389 | |
381 | 390 | // Doing an increment? |
382 | 391 | if ($var == 'alerts' && ($val === '+' || $val === '-')) |
@@ -385,18 +394,17 @@ discard block |
||
385 | 394 | if (is_array($members)) |
386 | 395 | { |
387 | 396 | $val = 'CASE '; |
388 | - foreach ($members as $k => $v) |
|
389 | - $val .= 'WHEN id_member = ' . $v . ' THEN '. count(fetch_alerts($v, false, 0, array(), false)) . ' '; |
|
397 | + foreach ($members as $k => $v) { |
|
398 | + $val .= 'WHEN id_member = ' . $v . ' THEN '. count(fetch_alerts($v, false, 0, array(), false)) . ' '; |
|
399 | + } |
|
390 | 400 | $val = $val . ' END'; |
391 | 401 | $type = 'raw'; |
392 | - } |
|
393 | - else |
|
402 | + } else |
|
394 | 403 | { |
395 | 404 | $blub = fetch_alerts($members, false, 0, array(), false); |
396 | 405 | $val = count($blub); |
397 | 406 | } |
398 | - } |
|
399 | - else if ($type == 'int' && ($val === '+' || $val === '-')) |
|
407 | + } else if ($type == 'int' && ($val === '+' || $val === '-')) |
|
400 | 408 | { |
401 | 409 | $val = $var . ' ' . $val . ' 1'; |
402 | 410 | $type = 'raw'; |
@@ -407,8 +415,9 @@ discard block |
||
407 | 415 | { |
408 | 416 | if (preg_match('~^' . $var . ' (\+ |- |\+ -)([\d]+)~', $val, $match)) |
409 | 417 | { |
410 | - if ($match[1] != '+ ') |
|
411 | - $val = 'CASE WHEN ' . $var . ' <= ' . abs($match[2]) . ' THEN 0 ELSE ' . $val . ' END'; |
|
418 | + if ($match[1] != '+ ') { |
|
419 | + $val = 'CASE WHEN ' . $var . ' <= ' . abs($match[2]) . ' THEN 0 ELSE ' . $val . ' END'; |
|
420 | + } |
|
412 | 421 | $type = 'raw'; |
413 | 422 | } |
414 | 423 | } |
@@ -429,8 +438,9 @@ discard block |
||
429 | 438 | // Clear any caching? |
430 | 439 | if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 2 && !empty($members)) |
431 | 440 | { |
432 | - if (!is_array($members)) |
|
433 | - $members = array($members); |
|
441 | + if (!is_array($members)) { |
|
442 | + $members = array($members); |
|
443 | + } |
|
434 | 444 | |
435 | 445 | foreach ($members as $member) |
436 | 446 | { |
@@ -463,29 +473,32 @@ discard block |
||
463 | 473 | { |
464 | 474 | global $modSettings, $smcFunc; |
465 | 475 | |
466 | - if (empty($changeArray) || !is_array($changeArray)) |
|
467 | - return; |
|
476 | + if (empty($changeArray) || !is_array($changeArray)) { |
|
477 | + return; |
|
478 | + } |
|
468 | 479 | |
469 | 480 | $toRemove = array(); |
470 | 481 | |
471 | 482 | // Go check if there is any setting to be removed. |
472 | - foreach ($changeArray as $k => $v) |
|
473 | - if ($v === null) |
|
483 | + foreach ($changeArray as $k => $v) { |
|
484 | + if ($v === null) |
|
474 | 485 | { |
475 | 486 | // Found some, remove them from the original array and add them to ours. |
476 | 487 | unset($changeArray[$k]); |
488 | + } |
|
477 | 489 | $toRemove[] = $k; |
478 | 490 | } |
479 | 491 | |
480 | 492 | // Proceed with the deletion. |
481 | - if (!empty($toRemove)) |
|
482 | - $smcFunc['db_query']('', ' |
|
493 | + if (!empty($toRemove)) { |
|
494 | + $smcFunc['db_query']('', ' |
|
483 | 495 | DELETE FROM {db_prefix}settings |
484 | 496 | WHERE variable IN ({array_string:remove})', |
485 | 497 | array( |
486 | 498 | 'remove' => $toRemove, |
487 | 499 | ) |
488 | 500 | ); |
501 | + } |
|
489 | 502 | |
490 | 503 | // In some cases, this may be better and faster, but for large sets we don't want so many UPDATEs. |
491 | 504 | if ($update) |
@@ -514,19 +527,22 @@ discard block |
||
514 | 527 | foreach ($changeArray as $variable => $value) |
515 | 528 | { |
516 | 529 | // Don't bother if it's already like that ;). |
517 | - if (isset($modSettings[$variable]) && $modSettings[$variable] == $value) |
|
518 | - continue; |
|
530 | + if (isset($modSettings[$variable]) && $modSettings[$variable] == $value) { |
|
531 | + continue; |
|
532 | + } |
|
519 | 533 | // If the variable isn't set, but would only be set to nothing'ness, then don't bother setting it. |
520 | - elseif (!isset($modSettings[$variable]) && empty($value)) |
|
521 | - continue; |
|
534 | + elseif (!isset($modSettings[$variable]) && empty($value)) { |
|
535 | + continue; |
|
536 | + } |
|
522 | 537 | |
523 | 538 | $replaceArray[] = array($variable, $value); |
524 | 539 | |
525 | 540 | $modSettings[$variable] = $value; |
526 | 541 | } |
527 | 542 | |
528 | - if (empty($replaceArray)) |
|
529 | - return; |
|
543 | + if (empty($replaceArray)) { |
|
544 | + return; |
|
545 | + } |
|
530 | 546 | |
531 | 547 | $smcFunc['db_insert']('replace', |
532 | 548 | '{db_prefix}settings', |
@@ -572,14 +588,17 @@ discard block |
||
572 | 588 | $start_invalid = $start < 0; |
573 | 589 | |
574 | 590 | // Make sure $start is a proper variable - not less than 0. |
575 | - if ($start_invalid) |
|
576 | - $start = 0; |
|
591 | + if ($start_invalid) { |
|
592 | + $start = 0; |
|
593 | + } |
|
577 | 594 | // Not greater than the upper bound. |
578 | - elseif ($start >= $max_value) |
|
579 | - $start = max(0, (int) $max_value - (((int) $max_value % (int) $num_per_page) == 0 ? $num_per_page : ((int) $max_value % (int) $num_per_page))); |
|
595 | + elseif ($start >= $max_value) { |
|
596 | + $start = max(0, (int) $max_value - (((int) $max_value % (int) $num_per_page) == 0 ? $num_per_page : ((int) $max_value % (int) $num_per_page))); |
|
597 | + } |
|
580 | 598 | // And it has to be a multiple of $num_per_page! |
581 | - else |
|
582 | - $start = max(0, (int) $start - ((int) $start % (int) $num_per_page)); |
|
599 | + else { |
|
600 | + $start = max(0, (int) $start - ((int) $start % (int) $num_per_page)); |
|
601 | + } |
|
583 | 602 | |
584 | 603 | $context['current_page'] = $start / $num_per_page; |
585 | 604 | |
@@ -609,77 +628,87 @@ discard block |
||
609 | 628 | |
610 | 629 | // Show all the pages. |
611 | 630 | $display_page = 1; |
612 | - for ($counter = 0; $counter < $max_value; $counter += $num_per_page) |
|
613 | - $pageindex .= $start == $counter && !$start_invalid ? sprintf($settings['page_index']['current_page'], $display_page++) : sprintf($base_link, $counter, $display_page++); |
|
631 | + for ($counter = 0; $counter < $max_value; $counter += $num_per_page) { |
|
632 | + $pageindex .= $start == $counter && !$start_invalid ? sprintf($settings['page_index']['current_page'], $display_page++) : sprintf($base_link, $counter, $display_page++); |
|
633 | + } |
|
614 | 634 | |
615 | 635 | // Show the right arrow. |
616 | 636 | $display_page = ($start + $num_per_page) > $max_value ? $max_value : ($start + $num_per_page); |
617 | - if ($start != $counter - $max_value && !$start_invalid) |
|
618 | - $pageindex .= $display_page > $counter - $num_per_page ? ' ' : sprintf($base_link, $display_page, $settings['page_index']['next_page']); |
|
619 | - } |
|
620 | - else |
|
637 | + if ($start != $counter - $max_value && !$start_invalid) { |
|
638 | + $pageindex .= $display_page > $counter - $num_per_page ? ' ' : sprintf($base_link, $display_page, $settings['page_index']['next_page']); |
|
639 | + } |
|
640 | + } else |
|
621 | 641 | { |
622 | 642 | // If they didn't enter an odd value, pretend they did. |
623 | 643 | $PageContiguous = (int) ($modSettings['compactTopicPagesContiguous'] - ($modSettings['compactTopicPagesContiguous'] % 2)) / 2; |
624 | 644 | |
625 | 645 | // Show the "prev page" link. (>prev page< 1 ... 6 7 [8] 9 10 ... 15 next page) |
626 | - if (!empty($start) && $show_prevnext) |
|
627 | - $pageindex .= sprintf($base_link, $start - $num_per_page, $settings['page_index']['previous_page']); |
|
628 | - else |
|
629 | - $pageindex .= ''; |
|
646 | + if (!empty($start) && $show_prevnext) { |
|
647 | + $pageindex .= sprintf($base_link, $start - $num_per_page, $settings['page_index']['previous_page']); |
|
648 | + } else { |
|
649 | + $pageindex .= ''; |
|
650 | + } |
|
630 | 651 | |
631 | 652 | // Show the first page. (prev page >1< ... 6 7 [8] 9 10 ... 15) |
632 | - if ($start > $num_per_page * $PageContiguous) |
|
633 | - $pageindex .= sprintf($base_link, 0, '1'); |
|
653 | + if ($start > $num_per_page * $PageContiguous) { |
|
654 | + $pageindex .= sprintf($base_link, 0, '1'); |
|
655 | + } |
|
634 | 656 | |
635 | 657 | // Show the ... after the first page. (prev page 1 >...< 6 7 [8] 9 10 ... 15 next page) |
636 | - if ($start > $num_per_page * ($PageContiguous + 1)) |
|
637 | - $pageindex .= strtr($settings['page_index']['expand_pages'], array( |
|
658 | + if ($start > $num_per_page * ($PageContiguous + 1)) { |
|
659 | + $pageindex .= strtr($settings['page_index']['expand_pages'], array( |
|
638 | 660 | '{LINK}' => JavaScriptEscape($smcFunc['htmlspecialchars']($base_link)), |
639 | 661 | '{FIRST_PAGE}' => $num_per_page, |
640 | 662 | '{LAST_PAGE}' => $start - $num_per_page * $PageContiguous, |
641 | 663 | '{PER_PAGE}' => $num_per_page, |
642 | 664 | )); |
665 | + } |
|
643 | 666 | |
644 | 667 | // Show the pages before the current one. (prev page 1 ... >6 7< [8] 9 10 ... 15 next page) |
645 | - for ($nCont = $PageContiguous; $nCont >= 1; $nCont--) |
|
646 | - if ($start >= $num_per_page * $nCont) |
|
668 | + for ($nCont = $PageContiguous; $nCont >= 1; $nCont--) { |
|
669 | + if ($start >= $num_per_page * $nCont) |
|
647 | 670 | { |
648 | 671 | $tmpStart = $start - $num_per_page * $nCont; |
672 | + } |
|
649 | 673 | $pageindex .= sprintf($base_link, $tmpStart, $tmpStart / $num_per_page + 1); |
650 | 674 | } |
651 | 675 | |
652 | 676 | // Show the current page. (prev page 1 ... 6 7 >[8]< 9 10 ... 15 next page) |
653 | - if (!$start_invalid) |
|
654 | - $pageindex .= sprintf($settings['page_index']['current_page'], $start / $num_per_page + 1); |
|
655 | - else |
|
656 | - $pageindex .= sprintf($base_link, $start, $start / $num_per_page + 1); |
|
677 | + if (!$start_invalid) { |
|
678 | + $pageindex .= sprintf($settings['page_index']['current_page'], $start / $num_per_page + 1); |
|
679 | + } else { |
|
680 | + $pageindex .= sprintf($base_link, $start, $start / $num_per_page + 1); |
|
681 | + } |
|
657 | 682 | |
658 | 683 | // Show the pages after the current one... (prev page 1 ... 6 7 [8] >9 10< ... 15 next page) |
659 | 684 | $tmpMaxPages = (int) (($max_value - 1) / $num_per_page) * $num_per_page; |
660 | - for ($nCont = 1; $nCont <= $PageContiguous; $nCont++) |
|
661 | - if ($start + $num_per_page * $nCont <= $tmpMaxPages) |
|
685 | + for ($nCont = 1; $nCont <= $PageContiguous; $nCont++) { |
|
686 | + if ($start + $num_per_page * $nCont <= $tmpMaxPages) |
|
662 | 687 | { |
663 | 688 | $tmpStart = $start + $num_per_page * $nCont; |
689 | + } |
|
664 | 690 | $pageindex .= sprintf($base_link, $tmpStart, $tmpStart / $num_per_page + 1); |
665 | 691 | } |
666 | 692 | |
667 | 693 | // Show the '...' part near the end. (prev page 1 ... 6 7 [8] 9 10 >...< 15 next page) |
668 | - if ($start + $num_per_page * ($PageContiguous + 1) < $tmpMaxPages) |
|
669 | - $pageindex .= strtr($settings['page_index']['expand_pages'], array( |
|
694 | + if ($start + $num_per_page * ($PageContiguous + 1) < $tmpMaxPages) { |
|
695 | + $pageindex .= strtr($settings['page_index']['expand_pages'], array( |
|
670 | 696 | '{LINK}' => JavaScriptEscape($smcFunc['htmlspecialchars']($base_link)), |
671 | 697 | '{FIRST_PAGE}' => $start + $num_per_page * ($PageContiguous + 1), |
672 | 698 | '{LAST_PAGE}' => $tmpMaxPages, |
673 | 699 | '{PER_PAGE}' => $num_per_page, |
674 | 700 | )); |
701 | + } |
|
675 | 702 | |
676 | 703 | // Show the last number in the list. (prev page 1 ... 6 7 [8] 9 10 ... >15< next page) |
677 | - if ($start + $num_per_page * $PageContiguous < $tmpMaxPages) |
|
678 | - $pageindex .= sprintf($base_link, $tmpMaxPages, $tmpMaxPages / $num_per_page + 1); |
|
704 | + if ($start + $num_per_page * $PageContiguous < $tmpMaxPages) { |
|
705 | + $pageindex .= sprintf($base_link, $tmpMaxPages, $tmpMaxPages / $num_per_page + 1); |
|
706 | + } |
|
679 | 707 | |
680 | 708 | // Show the "next page" link. (prev page 1 ... 6 7 [8] 9 10 ... 15 >next page<) |
681 | - if ($start != $tmpMaxPages && $show_prevnext) |
|
682 | - $pageindex .= sprintf($base_link, $start + $num_per_page, $settings['page_index']['next_page']); |
|
709 | + if ($start != $tmpMaxPages && $show_prevnext) { |
|
710 | + $pageindex .= sprintf($base_link, $start + $num_per_page, $settings['page_index']['next_page']); |
|
711 | + } |
|
683 | 712 | } |
684 | 713 | $pageindex .= $settings['page_index']['extra_after']; |
685 | 714 | |
@@ -705,8 +734,9 @@ discard block |
||
705 | 734 | if ($decimal_separator === null) |
706 | 735 | { |
707 | 736 | // Not set for whatever reason? |
708 | - if (empty($txt['number_format']) || preg_match('~^1([^\d]*)?234([^\d]*)(0*?)$~', $txt['number_format'], $matches) != 1) |
|
709 | - return $number; |
|
737 | + if (empty($txt['number_format']) || preg_match('~^1([^\d]*)?234([^\d]*)(0*?)$~', $txt['number_format'], $matches) != 1) { |
|
738 | + return $number; |
|
739 | + } |
|
710 | 740 | |
711 | 741 | // Cache these each load... |
712 | 742 | $thousands_separator = $matches[1]; |
@@ -740,17 +770,20 @@ discard block |
||
740 | 770 | static $unsupportedFormats, $finalizedFormats; |
741 | 771 | |
742 | 772 | // Offset the time. |
743 | - if (!$offset_type) |
|
744 | - $time = $log_time + ($user_info['time_offset'] + $modSettings['time_offset']) * 3600; |
|
773 | + if (!$offset_type) { |
|
774 | + $time = $log_time + ($user_info['time_offset'] + $modSettings['time_offset']) * 3600; |
|
775 | + } |
|
745 | 776 | // Just the forum offset? |
746 | - elseif ($offset_type == 'forum') |
|
747 | - $time = $log_time + $modSettings['time_offset'] * 3600; |
|
748 | - else |
|
749 | - $time = $log_time; |
|
777 | + elseif ($offset_type == 'forum') { |
|
778 | + $time = $log_time + $modSettings['time_offset'] * 3600; |
|
779 | + } else { |
|
780 | + $time = $log_time; |
|
781 | + } |
|
750 | 782 | |
751 | 783 | // We can't have a negative date (on Windows, at least.) |
752 | - if ($log_time < 0) |
|
753 | - $log_time = 0; |
|
784 | + if ($log_time < 0) { |
|
785 | + $log_time = 0; |
|
786 | + } |
|
754 | 787 | |
755 | 788 | // Today and Yesterday? |
756 | 789 | if ($modSettings['todayMod'] >= 1 && $show_today === true) |
@@ -767,24 +800,27 @@ discard block |
||
767 | 800 | { |
768 | 801 | $h = strpos($user_info['time_format'], '%l') === false ? '%I' : '%l'; |
769 | 802 | $today_fmt = $h . ':%M' . $s . ' %p'; |
803 | + } else { |
|
804 | + $today_fmt = '%H:%M' . $s; |
|
770 | 805 | } |
771 | - else |
|
772 | - $today_fmt = '%H:%M' . $s; |
|
773 | 806 | |
774 | 807 | // Same day of the year, same year.... Today! |
775 | - if ($then['yday'] == $now['yday'] && $then['year'] == $now['year']) |
|
776 | - return $txt['today'] . timeformat($log_time, $today_fmt, $offset_type); |
|
808 | + if ($then['yday'] == $now['yday'] && $then['year'] == $now['year']) { |
|
809 | + return $txt['today'] . timeformat($log_time, $today_fmt, $offset_type); |
|
810 | + } |
|
777 | 811 | |
778 | 812 | // Day-of-year is one less and same year, or it's the first of the year and that's the last of the year... |
779 | - if ($modSettings['todayMod'] == '2' && (($then['yday'] == $now['yday'] - 1 && $then['year'] == $now['year']) || ($now['yday'] == 0 && $then['year'] == $now['year'] - 1) && $then['mon'] == 12 && $then['mday'] == 31)) |
|
780 | - return $txt['yesterday'] . timeformat($log_time, $today_fmt, $offset_type); |
|
813 | + if ($modSettings['todayMod'] == '2' && (($then['yday'] == $now['yday'] - 1 && $then['year'] == $now['year']) || ($now['yday'] == 0 && $then['year'] == $now['year'] - 1) && $then['mon'] == 12 && $then['mday'] == 31)) { |
|
814 | + return $txt['yesterday'] . timeformat($log_time, $today_fmt, $offset_type); |
|
815 | + } |
|
781 | 816 | } |
782 | 817 | |
783 | 818 | $str = !is_bool($show_today) ? $show_today : $user_info['time_format']; |
784 | 819 | |
785 | 820 | // Use the cached formats if available |
786 | - if (is_null($finalizedFormats)) |
|
787 | - $finalizedFormats = (array) cache_get_data('timeformatstrings', 86400); |
|
821 | + if (is_null($finalizedFormats)) { |
|
822 | + $finalizedFormats = (array) cache_get_data('timeformatstrings', 86400); |
|
823 | + } |
|
788 | 824 | |
789 | 825 | // Make a supported version for this format if we don't already have one |
790 | 826 | if (empty($finalizedFormats[$str])) |
@@ -813,8 +849,9 @@ discard block |
||
813 | 849 | ); |
814 | 850 | |
815 | 851 | // No need to do this part again if we already did it once |
816 | - if (is_null($unsupportedFormats)) |
|
817 | - $unsupportedFormats = (array) cache_get_data('unsupportedtimeformats', 86400); |
|
852 | + if (is_null($unsupportedFormats)) { |
|
853 | + $unsupportedFormats = (array) cache_get_data('unsupportedtimeformats', 86400); |
|
854 | + } |
|
818 | 855 | if (empty($unsupportedFormats)) |
819 | 856 | { |
820 | 857 | foreach($strftimeFormatSubstitutions as $format => $substitution) |
@@ -823,20 +860,23 @@ discard block |
||
823 | 860 | |
824 | 861 | // Windows will return false for unsupported formats |
825 | 862 | // Other operating systems return the format string as a literal |
826 | - if ($value === false || $value === $format) |
|
827 | - $unsupportedFormats[] = $format; |
|
863 | + if ($value === false || $value === $format) { |
|
864 | + $unsupportedFormats[] = $format; |
|
865 | + } |
|
828 | 866 | } |
829 | 867 | cache_put_data('unsupportedtimeformats', $unsupportedFormats, 86400); |
830 | 868 | } |
831 | 869 | |
832 | 870 | // Windows needs extra help if $timeformat contains something completely invalid, e.g. '%Q' |
833 | - if (strtoupper(substr(PHP_OS, 0, 3)) == 'WIN') |
|
834 | - $timeformat = preg_replace('~%(?!' . implode('|', array_keys($strftimeFormatSubstitutions)) . ')~', '%', $timeformat); |
|
871 | + if (strtoupper(substr(PHP_OS, 0, 3)) == 'WIN') { |
|
872 | + $timeformat = preg_replace('~%(?!' . implode('|', array_keys($strftimeFormatSubstitutions)) . ')~', '%', $timeformat); |
|
873 | + } |
|
835 | 874 | |
836 | 875 | // Substitute unsupported formats with supported ones |
837 | - if (!empty($unsupportedFormats)) |
|
838 | - while (preg_match('~%(' . implode('|', $unsupportedFormats) . ')~', $timeformat, $matches)) |
|
876 | + if (!empty($unsupportedFormats)) { |
|
877 | + while (preg_match('~%(' . implode('|', $unsupportedFormats) . ')~', $timeformat, $matches)) |
|
839 | 878 | $timeformat = str_replace($matches[0], $strftimeFormatSubstitutions[$matches[1]], $timeformat); |
879 | + } |
|
840 | 880 | |
841 | 881 | // Remember this so we don't need to do it again |
842 | 882 | $finalizedFormats[$str] = $timeformat; |
@@ -845,33 +885,39 @@ discard block |
||
845 | 885 | |
846 | 886 | $str = $finalizedFormats[$str]; |
847 | 887 | |
848 | - if (!isset($locale_cache)) |
|
849 | - $locale_cache = setlocale(LC_TIME, $txt['lang_locale']); |
|
888 | + if (!isset($locale_cache)) { |
|
889 | + $locale_cache = setlocale(LC_TIME, $txt['lang_locale']); |
|
890 | + } |
|
850 | 891 | |
851 | 892 | if ($locale_cache !== false) |
852 | 893 | { |
853 | 894 | // Check if another process changed the locale |
854 | - if ($process_safe === true && setlocale(LC_TIME, '0') != $locale_cache) |
|
855 | - setlocale(LC_TIME, $txt['lang_locale']); |
|
895 | + if ($process_safe === true && setlocale(LC_TIME, '0') != $locale_cache) { |
|
896 | + setlocale(LC_TIME, $txt['lang_locale']); |
|
897 | + } |
|
856 | 898 | |
857 | - if (!isset($non_twelve_hour)) |
|
858 | - $non_twelve_hour = trim(strftime('%p')) === ''; |
|
859 | - if ($non_twelve_hour && strpos($str, '%p') !== false) |
|
860 | - $str = str_replace('%p', (strftime('%H', $time) < 12 ? $txt['time_am'] : $txt['time_pm']), $str); |
|
899 | + if (!isset($non_twelve_hour)) { |
|
900 | + $non_twelve_hour = trim(strftime('%p')) === ''; |
|
901 | + } |
|
902 | + if ($non_twelve_hour && strpos($str, '%p') !== false) { |
|
903 | + $str = str_replace('%p', (strftime('%H', $time) < 12 ? $txt['time_am'] : $txt['time_pm']), $str); |
|
904 | + } |
|
861 | 905 | |
862 | - foreach (array('%a', '%A', '%b', '%B') as $token) |
|
863 | - if (strpos($str, $token) !== false) |
|
906 | + foreach (array('%a', '%A', '%b', '%B') as $token) { |
|
907 | + if (strpos($str, $token) !== false) |
|
864 | 908 | $str = str_replace($token, strftime($token, $time), $str); |
865 | - } |
|
866 | - else |
|
909 | + } |
|
910 | + } else |
|
867 | 911 | { |
868 | 912 | // Do-it-yourself time localization. Fun. |
869 | - foreach (array('%a' => 'days_short', '%A' => 'days', '%b' => 'months_short', '%B' => 'months') as $token => $text_label) |
|
870 | - if (strpos($str, $token) !== false) |
|
913 | + foreach (array('%a' => 'days_short', '%A' => 'days', '%b' => 'months_short', '%B' => 'months') as $token => $text_label) { |
|
914 | + if (strpos($str, $token) !== false) |
|
871 | 915 | $str = str_replace($token, $txt[$text_label][(int) strftime($token === '%a' || $token === '%A' ? '%w' : '%m', $time)], $str); |
916 | + } |
|
872 | 917 | |
873 | - if (strpos($str, '%p') !== false) |
|
874 | - $str = str_replace('%p', (strftime('%H', $time) < 12 ? $txt['time_am'] : $txt['time_pm']), $str); |
|
918 | + if (strpos($str, '%p') !== false) { |
|
919 | + $str = str_replace('%p', (strftime('%H', $time) < 12 ? $txt['time_am'] : $txt['time_pm']), $str); |
|
920 | + } |
|
875 | 921 | } |
876 | 922 | |
877 | 923 | // Format the time and then restore any literal percent characters |
@@ -894,16 +940,19 @@ discard block |
||
894 | 940 | static $translation = array(); |
895 | 941 | |
896 | 942 | // Determine the character set... Default to UTF-8 |
897 | - if (empty($context['character_set'])) |
|
898 | - $charset = 'UTF-8'; |
|
943 | + if (empty($context['character_set'])) { |
|
944 | + $charset = 'UTF-8'; |
|
945 | + } |
|
899 | 946 | // Use ISO-8859-1 in place of non-supported ISO-8859 charsets... |
900 | - elseif (strpos($context['character_set'], 'ISO-8859-') !== false && !in_array($context['character_set'], array('ISO-8859-5', 'ISO-8859-15'))) |
|
901 | - $charset = 'ISO-8859-1'; |
|
902 | - else |
|
903 | - $charset = $context['character_set']; |
|
947 | + elseif (strpos($context['character_set'], 'ISO-8859-') !== false && !in_array($context['character_set'], array('ISO-8859-5', 'ISO-8859-15'))) { |
|
948 | + $charset = 'ISO-8859-1'; |
|
949 | + } else { |
|
950 | + $charset = $context['character_set']; |
|
951 | + } |
|
904 | 952 | |
905 | - if (empty($translation)) |
|
906 | - $translation = array_flip(get_html_translation_table(HTML_SPECIALCHARS, ENT_QUOTES, $charset)) + array(''' => '\'', ''' => '\'', ' ' => ' '); |
|
953 | + if (empty($translation)) { |
|
954 | + $translation = array_flip(get_html_translation_table(HTML_SPECIALCHARS, ENT_QUOTES, $charset)) + array(''' => '\'', ''' => '\'', ' ' => ' '); |
|
955 | + } |
|
907 | 956 | |
908 | 957 | return strtr($string, $translation); |
909 | 958 | } |
@@ -925,8 +974,9 @@ discard block |
||
925 | 974 | global $smcFunc; |
926 | 975 | |
927 | 976 | // It was already short enough! |
928 | - if ($smcFunc['strlen']($subject) <= $len) |
|
929 | - return $subject; |
|
977 | + if ($smcFunc['strlen']($subject) <= $len) { |
|
978 | + return $subject; |
|
979 | + } |
|
930 | 980 | |
931 | 981 | // Shorten it by the length it was too long, and strip off junk from the end. |
932 | 982 | return $smcFunc['substr']($subject, 0, $len) . '...'; |
@@ -945,10 +995,11 @@ discard block |
||
945 | 995 | { |
946 | 996 | global $user_info, $modSettings; |
947 | 997 | |
948 | - if ($timestamp === null) |
|
949 | - $timestamp = time(); |
|
950 | - elseif ($timestamp == 0) |
|
951 | - return 0; |
|
998 | + if ($timestamp === null) { |
|
999 | + $timestamp = time(); |
|
1000 | + } elseif ($timestamp == 0) { |
|
1001 | + return 0; |
|
1002 | + } |
|
952 | 1003 | |
953 | 1004 | return $timestamp + ($modSettings['time_offset'] + ($use_user_offset ? $user_info['time_offset'] : 0)) * 3600; |
954 | 1005 | } |
@@ -977,8 +1028,9 @@ discard block |
||
977 | 1028 | $array[$i] = $array[$j]; |
978 | 1029 | $array[$j] = $temp; |
979 | 1030 | |
980 | - for ($i = 1; $p[$i] == 0; $i++) |
|
981 | - $p[$i] = 1; |
|
1031 | + for ($i = 1; $p[$i] == 0; $i++) { |
|
1032 | + $p[$i] = 1; |
|
1033 | + } |
|
982 | 1034 | |
983 | 1035 | $orders[] = $array; |
984 | 1036 | } |
@@ -1010,12 +1062,14 @@ discard block |
||
1010 | 1062 | static $disabled; |
1011 | 1063 | |
1012 | 1064 | // Don't waste cycles |
1013 | - if ($message === '') |
|
1014 | - return ''; |
|
1065 | + if ($message === '') { |
|
1066 | + return ''; |
|
1067 | + } |
|
1015 | 1068 | |
1016 | 1069 | // Just in case it wasn't determined yet whether UTF-8 is enabled. |
1017 | - if (!isset($context['utf8'])) |
|
1018 | - $context['utf8'] = (empty($modSettings['global_character_set']) ? $txt['lang_character_set'] : $modSettings['global_character_set']) === 'UTF-8'; |
|
1070 | + if (!isset($context['utf8'])) { |
|
1071 | + $context['utf8'] = (empty($modSettings['global_character_set']) ? $txt['lang_character_set'] : $modSettings['global_character_set']) === 'UTF-8'; |
|
1072 | + } |
|
1019 | 1073 | |
1020 | 1074 | // Clean up any cut/paste issues we may have |
1021 | 1075 | $message = sanitizeMSCutPaste($message); |
@@ -1027,13 +1081,15 @@ discard block |
||
1027 | 1081 | return $message; |
1028 | 1082 | } |
1029 | 1083 | |
1030 | - if ($smileys !== null && ($smileys == '1' || $smileys == '0')) |
|
1031 | - $smileys = (bool) $smileys; |
|
1084 | + if ($smileys !== null && ($smileys == '1' || $smileys == '0')) { |
|
1085 | + $smileys = (bool) $smileys; |
|
1086 | + } |
|
1032 | 1087 | |
1033 | 1088 | if (empty($modSettings['enableBBC']) && $message !== false) |
1034 | 1089 | { |
1035 | - if ($smileys === true) |
|
1036 | - parsesmileys($message); |
|
1090 | + if ($smileys === true) { |
|
1091 | + parsesmileys($message); |
|
1092 | + } |
|
1037 | 1093 | |
1038 | 1094 | return $message; |
1039 | 1095 | } |
@@ -1046,8 +1102,9 @@ discard block |
||
1046 | 1102 | } |
1047 | 1103 | |
1048 | 1104 | // Ensure $modSettings['tld_regex'] contains a valid regex for the autolinker |
1049 | - if (!empty($modSettings['autoLinkUrls'])) |
|
1050 | - set_tld_regex(); |
|
1105 | + if (!empty($modSettings['autoLinkUrls'])) { |
|
1106 | + set_tld_regex(); |
|
1107 | + } |
|
1051 | 1108 | |
1052 | 1109 | // Allow mods access before entering the main parse_bbc loop |
1053 | 1110 | call_integration_hook('integrate_pre_parsebbc', array(&$message, &$smileys, &$cache_id, &$parse_tags)); |
@@ -1061,12 +1118,14 @@ discard block |
||
1061 | 1118 | |
1062 | 1119 | $temp = explode(',', strtolower($modSettings['disabledBBC'])); |
1063 | 1120 | |
1064 | - foreach ($temp as $tag) |
|
1065 | - $disabled[trim($tag)] = true; |
|
1121 | + foreach ($temp as $tag) { |
|
1122 | + $disabled[trim($tag)] = true; |
|
1123 | + } |
|
1066 | 1124 | } |
1067 | 1125 | |
1068 | - if (empty($modSettings['enableEmbeddedFlash'])) |
|
1069 | - $disabled['flash'] = true; |
|
1126 | + if (empty($modSettings['enableEmbeddedFlash'])) { |
|
1127 | + $disabled['flash'] = true; |
|
1128 | + } |
|
1070 | 1129 | |
1071 | 1130 | /* The following bbc are formatted as an array, with keys as follows: |
1072 | 1131 | |
@@ -1187,8 +1246,9 @@ discard block |
||
1187 | 1246 | $returnContext = ''; |
1188 | 1247 | |
1189 | 1248 | // BBC or the entire attachments feature is disabled |
1190 | - if (empty($modSettings['attachmentEnable']) || !empty($disabled['attach'])) |
|
1191 | - return $data; |
|
1249 | + if (empty($modSettings['attachmentEnable']) || !empty($disabled['attach'])) { |
|
1250 | + return $data; |
|
1251 | + } |
|
1192 | 1252 | |
1193 | 1253 | // Save the attach ID. |
1194 | 1254 | $attachID = $data; |
@@ -1199,8 +1259,9 @@ discard block |
||
1199 | 1259 | $currentAttachment = parseAttachBBC($attachID); |
1200 | 1260 | |
1201 | 1261 | // parseAttachBBC will return a string ($txt key) rather than diying with a fatal_error. Up to you to decide what to do. |
1202 | - if (is_string($currentAttachment)) |
|
1203 | - return $data = !empty($txt[$currentAttachment]) ? $txt[$currentAttachment] : $currentAttachment; |
|
1262 | + if (is_string($currentAttachment)) { |
|
1263 | + return $data = !empty($txt[$currentAttachment]) ? $txt[$currentAttachment] : $currentAttachment; |
|
1264 | + } |
|
1204 | 1265 | |
1205 | 1266 | if (!empty($currentAttachment['is_image'])) |
1206 | 1267 | { |
@@ -1216,15 +1277,17 @@ discard block |
||
1216 | 1277 | $height = ' height="' . $currentAttachment['height'] . '"'; |
1217 | 1278 | } |
1218 | 1279 | |
1219 | - if ($currentAttachment['thumbnail']['has_thumb'] && empty($params['{width}']) && empty($params['{height}'])) |
|
1220 | - $returnContext .= '<a href="'. $currentAttachment['href']. ';image" id="link_'. $currentAttachment['id']. '" onclick="'. $currentAttachment['thumbnail']['javascript']. '"><img src="'. $currentAttachment['thumbnail']['href']. '"' . $alt . $title . ' id="thumb_'. $currentAttachment['id']. '" class="atc_img"></a>'; |
|
1221 | - else |
|
1222 | - $returnContext .= '<img src="' . $currentAttachment['href'] . ';image"' . $alt . $title . $width . $height . ' class="bbc_img"/>'; |
|
1280 | + if ($currentAttachment['thumbnail']['has_thumb'] && empty($params['{width}']) && empty($params['{height}'])) { |
|
1281 | + $returnContext .= '<a href="'. $currentAttachment['href']. ';image" id="link_'. $currentAttachment['id']. '" onclick="'. $currentAttachment['thumbnail']['javascript']. '"><img src="'. $currentAttachment['thumbnail']['href']. '"' . $alt . $title . ' id="thumb_'. $currentAttachment['id']. '" class="atc_img"></a>'; |
|
1282 | + } else { |
|
1283 | + $returnContext .= '<img src="' . $currentAttachment['href'] . ';image"' . $alt . $title . $width . $height . ' class="bbc_img"/>'; |
|
1284 | + } |
|
1223 | 1285 | } |
1224 | 1286 | |
1225 | 1287 | // No image. Show a link. |
1226 | - else |
|
1227 | - $returnContext .= $currentAttachment['link']; |
|
1288 | + else { |
|
1289 | + $returnContext .= $currentAttachment['link']; |
|
1290 | + } |
|
1228 | 1291 | |
1229 | 1292 | // Gotta append what we just did. |
1230 | 1293 | $data = $returnContext; |
@@ -1255,8 +1318,9 @@ discard block |
||
1255 | 1318 | for ($php_i = 0, $php_n = count($php_parts); $php_i < $php_n; $php_i++) |
1256 | 1319 | { |
1257 | 1320 | // Do PHP code coloring? |
1258 | - if ($php_parts[$php_i] != '<?php') |
|
1259 | - continue; |
|
1321 | + if ($php_parts[$php_i] != '<?php') { |
|
1322 | + continue; |
|
1323 | + } |
|
1260 | 1324 | |
1261 | 1325 | $php_string = ''; |
1262 | 1326 | while ($php_i + 1 < count($php_parts) && $php_parts[$php_i] != '?>') |
@@ -1272,8 +1336,9 @@ discard block |
||
1272 | 1336 | $data = str_replace("\t", "<span style=\"white-space: pre;\">\t</span>", $data); |
1273 | 1337 | |
1274 | 1338 | // Recent Opera bug requiring temporary fix. &nsbp; is needed before </code> to avoid broken selection. |
1275 | - if ($context['browser']['is_opera']) |
|
1276 | - $data .= ' '; |
|
1339 | + if ($context['browser']['is_opera']) { |
|
1340 | + $data .= ' '; |
|
1341 | + } |
|
1277 | 1342 | } |
1278 | 1343 | }, |
1279 | 1344 | 'block_level' => true, |
@@ -1292,8 +1357,9 @@ discard block |
||
1292 | 1357 | for ($php_i = 0, $php_n = count($php_parts); $php_i < $php_n; $php_i++) |
1293 | 1358 | { |
1294 | 1359 | // Do PHP code coloring? |
1295 | - if ($php_parts[$php_i] != '<?php') |
|
1296 | - continue; |
|
1360 | + if ($php_parts[$php_i] != '<?php') { |
|
1361 | + continue; |
|
1362 | + } |
|
1297 | 1363 | |
1298 | 1364 | $php_string = ''; |
1299 | 1365 | while ($php_i + 1 < count($php_parts) && $php_parts[$php_i] != '?>') |
@@ -1309,8 +1375,9 @@ discard block |
||
1309 | 1375 | $data[0] = str_replace("\t", "<span style=\"white-space: pre;\">\t</span>", $data[0]); |
1310 | 1376 | |
1311 | 1377 | // Recent Opera bug requiring temporary fix. &nsbp; is needed before </code> to avoid broken selection. |
1312 | - if ($context['browser']['is_opera']) |
|
1313 | - $data[0] .= ' '; |
|
1378 | + if ($context['browser']['is_opera']) { |
|
1379 | + $data[0] .= ' '; |
|
1380 | + } |
|
1314 | 1381 | } |
1315 | 1382 | }, |
1316 | 1383 | 'block_level' => true, |
@@ -1348,11 +1415,13 @@ discard block |
||
1348 | 1415 | 'content' => '<embed type="application/x-shockwave-flash" src="$1" width="$2" height="$3" play="true" loop="true" quality="high" AllowScriptAccess="never">', |
1349 | 1416 | 'validate' => function (&$tag, &$data, $disabled) |
1350 | 1417 | { |
1351 | - if (isset($disabled['url'])) |
|
1352 | - $tag['content'] = '$1'; |
|
1418 | + if (isset($disabled['url'])) { |
|
1419 | + $tag['content'] = '$1'; |
|
1420 | + } |
|
1353 | 1421 | $scheme = parse_url($data[0], PHP_URL_SCHEME); |
1354 | - if (empty($scheme)) |
|
1355 | - $data[0] = '//' . ltrim($data[0], ':/'); |
|
1422 | + if (empty($scheme)) { |
|
1423 | + $data[0] = '//' . ltrim($data[0], ':/'); |
|
1424 | + } |
|
1356 | 1425 | }, |
1357 | 1426 | 'disabled_content' => '<a href="$1" target="_blank">$1</a>', |
1358 | 1427 | ), |
@@ -1366,10 +1435,11 @@ discard block |
||
1366 | 1435 | { |
1367 | 1436 | $class = 'class="bbc_float float' . (strpos($data, 'left') === 0 ? 'left' : 'right') . '"'; |
1368 | 1437 | |
1369 | - if (preg_match('~\bmax=(\d+(?:%|px|em|rem|ex|pt|pc|ch|vw|vh|vmin|vmax|cm|mm|in)?)~', $data, $matches)) |
|
1370 | - $css = ' style="max-width:' . $matches[1] . (is_numeric($matches[1]) ? 'px' : '') . '"'; |
|
1371 | - else |
|
1372 | - $css = ''; |
|
1438 | + if (preg_match('~\bmax=(\d+(?:%|px|em|rem|ex|pt|pc|ch|vw|vh|vmin|vmax|cm|mm|in)?)~', $data, $matches)) { |
|
1439 | + $css = ' style="max-width:' . $matches[1] . (is_numeric($matches[1]) ? 'px' : '') . '"'; |
|
1440 | + } else { |
|
1441 | + $css = ''; |
|
1442 | + } |
|
1373 | 1443 | |
1374 | 1444 | $data = $class . $css; |
1375 | 1445 | }, |
@@ -1419,14 +1489,16 @@ discard block |
||
1419 | 1489 | $scheme = parse_url($data, PHP_URL_SCHEME); |
1420 | 1490 | if ($image_proxy_enabled) |
1421 | 1491 | { |
1422 | - if (empty($scheme)) |
|
1423 | - $data = 'http://' . ltrim($data, ':/'); |
|
1492 | + if (empty($scheme)) { |
|
1493 | + $data = 'http://' . ltrim($data, ':/'); |
|
1494 | + } |
|
1424 | 1495 | |
1425 | - if ($scheme != 'https') |
|
1426 | - $data = $boardurl . '/proxy.php?request=' . urlencode($data) . '&hash=' . md5($data . $image_proxy_secret); |
|
1496 | + if ($scheme != 'https') { |
|
1497 | + $data = $boardurl . '/proxy.php?request=' . urlencode($data) . '&hash=' . md5($data . $image_proxy_secret); |
|
1498 | + } |
|
1499 | + } elseif (empty($scheme)) { |
|
1500 | + $data = '//' . ltrim($data, ':/'); |
|
1427 | 1501 | } |
1428 | - elseif (empty($scheme)) |
|
1429 | - $data = '//' . ltrim($data, ':/'); |
|
1430 | 1502 | }, |
1431 | 1503 | 'disabled_content' => '($1)', |
1432 | 1504 | ), |
@@ -1442,14 +1514,16 @@ discard block |
||
1442 | 1514 | $scheme = parse_url($data, PHP_URL_SCHEME); |
1443 | 1515 | if ($image_proxy_enabled) |
1444 | 1516 | { |
1445 | - if (empty($scheme)) |
|
1446 | - $data = 'http://' . ltrim($data, ':/'); |
|
1517 | + if (empty($scheme)) { |
|
1518 | + $data = 'http://' . ltrim($data, ':/'); |
|
1519 | + } |
|
1447 | 1520 | |
1448 | - if ($scheme != 'https') |
|
1449 | - $data = $boardurl . '/proxy.php?request=' . urlencode($data) . '&hash=' . md5($data . $image_proxy_secret); |
|
1521 | + if ($scheme != 'https') { |
|
1522 | + $data = $boardurl . '/proxy.php?request=' . urlencode($data) . '&hash=' . md5($data . $image_proxy_secret); |
|
1523 | + } |
|
1524 | + } elseif (empty($scheme)) { |
|
1525 | + $data = '//' . ltrim($data, ':/'); |
|
1450 | 1526 | } |
1451 | - elseif (empty($scheme)) |
|
1452 | - $data = '//' . ltrim($data, ':/'); |
|
1453 | 1527 | }, |
1454 | 1528 | 'disabled_content' => '($1)', |
1455 | 1529 | ), |
@@ -1461,8 +1535,9 @@ discard block |
||
1461 | 1535 | { |
1462 | 1536 | $data = strtr($data, array('<br>' => '')); |
1463 | 1537 | $scheme = parse_url($data, PHP_URL_SCHEME); |
1464 | - if (empty($scheme)) |
|
1465 | - $data = '//' . ltrim($data, ':/'); |
|
1538 | + if (empty($scheme)) { |
|
1539 | + $data = '//' . ltrim($data, ':/'); |
|
1540 | + } |
|
1466 | 1541 | }, |
1467 | 1542 | ), |
1468 | 1543 | array( |
@@ -1473,13 +1548,14 @@ discard block |
||
1473 | 1548 | 'after' => '</a>', |
1474 | 1549 | 'validate' => function (&$tag, &$data, $disabled) |
1475 | 1550 | { |
1476 | - if (substr($data, 0, 1) == '#') |
|
1477 | - $data = '#post_' . substr($data, 1); |
|
1478 | - else |
|
1551 | + if (substr($data, 0, 1) == '#') { |
|
1552 | + $data = '#post_' . substr($data, 1); |
|
1553 | + } else |
|
1479 | 1554 | { |
1480 | 1555 | $scheme = parse_url($data, PHP_URL_SCHEME); |
1481 | - if (empty($scheme)) |
|
1482 | - $data = '//' . ltrim($data, ':/'); |
|
1556 | + if (empty($scheme)) { |
|
1557 | + $data = '//' . ltrim($data, ':/'); |
|
1558 | + } |
|
1483 | 1559 | } |
1484 | 1560 | }, |
1485 | 1561 | 'disallow_children' => array('email', 'ftp', 'url', 'iurl'), |
@@ -1557,8 +1633,9 @@ discard block |
||
1557 | 1633 | { |
1558 | 1634 | $add_begin = substr(trim($data), 0, 5) != '<?'; |
1559 | 1635 | $data = highlight_php_code($add_begin ? '<?php ' . $data . '?>' : $data); |
1560 | - if ($add_begin) |
|
1561 | - $data = preg_replace(array('~^(.+?)<\?.{0,40}?php(?: |\s)~', '~\?>((?:</(font|span)>)*)$~'), '$1', $data, 2); |
|
1636 | + if ($add_begin) { |
|
1637 | + $data = preg_replace(array('~^(.+?)<\?.{0,40}?php(?: |\s)~', '~\?>((?:</(font|span)>)*)$~'), '$1', $data, 2); |
|
1638 | + } |
|
1562 | 1639 | } |
1563 | 1640 | }, |
1564 | 1641 | 'block_level' => false, |
@@ -1689,10 +1766,11 @@ discard block |
||
1689 | 1766 | 'content' => '$1', |
1690 | 1767 | 'validate' => function (&$tag, &$data, $disabled) |
1691 | 1768 | { |
1692 | - if (is_numeric($data)) |
|
1693 | - $data = timeformat($data); |
|
1694 | - else |
|
1695 | - $tag['content'] = '[time]$1[/time]'; |
|
1769 | + if (is_numeric($data)) { |
|
1770 | + $data = timeformat($data); |
|
1771 | + } else { |
|
1772 | + $tag['content'] = '[time]$1[/time]'; |
|
1773 | + } |
|
1696 | 1774 | }, |
1697 | 1775 | ), |
1698 | 1776 | array( |
@@ -1719,8 +1797,9 @@ discard block |
||
1719 | 1797 | { |
1720 | 1798 | $data = strtr($data, array('<br>' => '')); |
1721 | 1799 | $scheme = parse_url($data, PHP_URL_SCHEME); |
1722 | - if (empty($scheme)) |
|
1723 | - $data = '//' . ltrim($data, ':/'); |
|
1800 | + if (empty($scheme)) { |
|
1801 | + $data = '//' . ltrim($data, ':/'); |
|
1802 | + } |
|
1724 | 1803 | }, |
1725 | 1804 | ), |
1726 | 1805 | array( |
@@ -1732,8 +1811,9 @@ discard block |
||
1732 | 1811 | 'validate' => function (&$tag, &$data, $disabled) |
1733 | 1812 | { |
1734 | 1813 | $scheme = parse_url($data, PHP_URL_SCHEME); |
1735 | - if (empty($scheme)) |
|
1736 | - $data = '//' . ltrim($data, ':/'); |
|
1814 | + if (empty($scheme)) { |
|
1815 | + $data = '//' . ltrim($data, ':/'); |
|
1816 | + } |
|
1737 | 1817 | }, |
1738 | 1818 | 'disallow_children' => array('email', 'ftp', 'url', 'iurl'), |
1739 | 1819 | 'disabled_after' => ' ($1)', |
@@ -1753,8 +1833,9 @@ discard block |
||
1753 | 1833 | // This is mainly for the bbc manager, so it's easy to add tags above. Custom BBC should be added above this line. |
1754 | 1834 | if ($message === false) |
1755 | 1835 | { |
1756 | - if (isset($temp_bbc)) |
|
1757 | - $bbc_codes = $temp_bbc; |
|
1836 | + if (isset($temp_bbc)) { |
|
1837 | + $bbc_codes = $temp_bbc; |
|
1838 | + } |
|
1758 | 1839 | usort($codes, function ($a, $b) { |
1759 | 1840 | return strcmp($a['tag'], $b['tag']); |
1760 | 1841 | }); |
@@ -1774,8 +1855,9 @@ discard block |
||
1774 | 1855 | ); |
1775 | 1856 | if (!isset($disabled['li']) && !isset($disabled['list'])) |
1776 | 1857 | { |
1777 | - foreach ($itemcodes as $c => $dummy) |
|
1778 | - $bbc_codes[$c] = array(); |
|
1858 | + foreach ($itemcodes as $c => $dummy) { |
|
1859 | + $bbc_codes[$c] = array(); |
|
1860 | + } |
|
1779 | 1861 | } |
1780 | 1862 | |
1781 | 1863 | // Shhhh! |
@@ -1796,12 +1878,14 @@ discard block |
||
1796 | 1878 | foreach ($codes as $code) |
1797 | 1879 | { |
1798 | 1880 | // Make it easier to process parameters later |
1799 | - if (!empty($code['parameters'])) |
|
1800 | - ksort($code['parameters'], SORT_STRING); |
|
1881 | + if (!empty($code['parameters'])) { |
|
1882 | + ksort($code['parameters'], SORT_STRING); |
|
1883 | + } |
|
1801 | 1884 | |
1802 | 1885 | // If we are not doing every tag only do ones we are interested in. |
1803 | - if (empty($parse_tags) || in_array($code['tag'], $parse_tags)) |
|
1804 | - $bbc_codes[substr($code['tag'], 0, 1)][] = $code; |
|
1886 | + if (empty($parse_tags) || in_array($code['tag'], $parse_tags)) { |
|
1887 | + $bbc_codes[substr($code['tag'], 0, 1)][] = $code; |
|
1888 | + } |
|
1805 | 1889 | } |
1806 | 1890 | $codes = null; |
1807 | 1891 | } |
@@ -1812,8 +1896,9 @@ discard block |
||
1812 | 1896 | // It's likely this will change if the message is modified. |
1813 | 1897 | $cache_key = 'parse:' . $cache_id . '-' . md5(md5($message) . '-' . $smileys . (empty($disabled) ? '' : implode(',', array_keys($disabled))) . $smcFunc['json_encode']($context['browser']) . $txt['lang_locale'] . $user_info['time_offset'] . $user_info['time_format']); |
1814 | 1898 | |
1815 | - if (($temp = cache_get_data($cache_key, 240)) != null) |
|
1816 | - return $temp; |
|
1899 | + if (($temp = cache_get_data($cache_key, 240)) != null) { |
|
1900 | + return $temp; |
|
1901 | + } |
|
1817 | 1902 | |
1818 | 1903 | $cache_t = microtime(); |
1819 | 1904 | } |
@@ -1845,8 +1930,9 @@ discard block |
||
1845 | 1930 | $disabled['flash'] = true; |
1846 | 1931 | |
1847 | 1932 | // @todo Change maybe? |
1848 | - if (!isset($_GET['images'])) |
|
1849 | - $disabled['img'] = true; |
|
1933 | + if (!isset($_GET['images'])) { |
|
1934 | + $disabled['img'] = true; |
|
1935 | + } |
|
1850 | 1936 | |
1851 | 1937 | // @todo Interface/setting to add more? |
1852 | 1938 | } |
@@ -1870,8 +1956,9 @@ discard block |
||
1870 | 1956 | $pos = isset($matches[0][1]) ? $matches[0][1] : false; |
1871 | 1957 | |
1872 | 1958 | // Failsafe. |
1873 | - if ($pos === false || $last_pos > $pos) |
|
1874 | - $pos = strlen($message) + 1; |
|
1959 | + if ($pos === false || $last_pos > $pos) { |
|
1960 | + $pos = strlen($message) + 1; |
|
1961 | + } |
|
1875 | 1962 | |
1876 | 1963 | // Can't have a one letter smiley, URL, or email! (sorry.) |
1877 | 1964 | if ($last_pos < $pos - 1) |
@@ -1889,8 +1976,9 @@ discard block |
||
1889 | 1976 | |
1890 | 1977 | // <br> should be empty. |
1891 | 1978 | $empty_tags = array('br', 'hr'); |
1892 | - foreach ($empty_tags as $tag) |
|
1893 | - $data = str_replace(array('<' . $tag . '>', '<' . $tag . '/>', '<' . $tag . ' />'), '<' . $tag . '>', $data); |
|
1979 | + foreach ($empty_tags as $tag) { |
|
1980 | + $data = str_replace(array('<' . $tag . '>', '<' . $tag . '/>', '<' . $tag . ' />'), '<' . $tag . '>', $data); |
|
1981 | + } |
|
1894 | 1982 | |
1895 | 1983 | // b, u, i, s, pre... basic tags. |
1896 | 1984 | $closable_tags = array('b', 'u', 'i', 's', 'em', 'ins', 'del', 'pre', 'blockquote', 'strong'); |
@@ -1899,8 +1987,9 @@ discard block |
||
1899 | 1987 | $diff = substr_count($data, '<' . $tag . '>') - substr_count($data, '</' . $tag . '>'); |
1900 | 1988 | $data = strtr($data, array('<' . $tag . '>' => '<' . $tag . '>', '</' . $tag . '>' => '</' . $tag . '>')); |
1901 | 1989 | |
1902 | - if ($diff > 0) |
|
1903 | - $data = substr($data, 0, -1) . str_repeat('</' . $tag . '>', $diff) . substr($data, -1); |
|
1990 | + if ($diff > 0) { |
|
1991 | + $data = substr($data, 0, -1) . str_repeat('</' . $tag . '>', $diff) . substr($data, -1); |
|
1992 | + } |
|
1904 | 1993 | } |
1905 | 1994 | |
1906 | 1995 | // Do <img ...> - with security... action= -> action-. |
@@ -1913,8 +2002,9 @@ discard block |
||
1913 | 2002 | $alt = empty($matches[3][$match]) ? '' : ' alt=' . preg_replace('~^"|"$~', '', $matches[3][$match]); |
1914 | 2003 | |
1915 | 2004 | // Remove action= from the URL - no funny business, now. |
1916 | - if (preg_match('~action(=|%3d)(?!dlattach)~i', $imgtag) != 0) |
|
1917 | - $imgtag = preg_replace('~action(?:=|%3d)(?!dlattach)~i', 'action-', $imgtag); |
|
2005 | + if (preg_match('~action(=|%3d)(?!dlattach)~i', $imgtag) != 0) { |
|
2006 | + $imgtag = preg_replace('~action(?:=|%3d)(?!dlattach)~i', 'action-', $imgtag); |
|
2007 | + } |
|
1918 | 2008 | |
1919 | 2009 | // Check if the image is larger than allowed. |
1920 | 2010 | if (!empty($modSettings['max_image_width']) && !empty($modSettings['max_image_height'])) |
@@ -1935,9 +2025,9 @@ discard block |
||
1935 | 2025 | |
1936 | 2026 | // Set the new image tag. |
1937 | 2027 | $replaces[$matches[0][$match]] = '[img width=' . $width . ' height=' . $height . $alt . ']' . $imgtag . '[/img]'; |
2028 | + } else { |
|
2029 | + $replaces[$matches[0][$match]] = '[img' . $alt . ']' . $imgtag . '[/img]'; |
|
1938 | 2030 | } |
1939 | - else |
|
1940 | - $replaces[$matches[0][$match]] = '[img' . $alt . ']' . $imgtag . '[/img]'; |
|
1941 | 2031 | } |
1942 | 2032 | |
1943 | 2033 | $data = strtr($data, $replaces); |
@@ -1950,16 +2040,18 @@ discard block |
||
1950 | 2040 | $no_autolink_area = false; |
1951 | 2041 | if (!empty($open_tags)) |
1952 | 2042 | { |
1953 | - foreach ($open_tags as $open_tag) |
|
1954 | - if (in_array($open_tag['tag'], $no_autolink_tags)) |
|
2043 | + foreach ($open_tags as $open_tag) { |
|
2044 | + if (in_array($open_tag['tag'], $no_autolink_tags)) |
|
1955 | 2045 | $no_autolink_area = true; |
2046 | + } |
|
1956 | 2047 | } |
1957 | 2048 | |
1958 | 2049 | // Don't go backwards. |
1959 | 2050 | // @todo Don't think is the real solution.... |
1960 | 2051 | $lastAutoPos = isset($lastAutoPos) ? $lastAutoPos : 0; |
1961 | - if ($pos < $lastAutoPos) |
|
1962 | - $no_autolink_area = true; |
|
2052 | + if ($pos < $lastAutoPos) { |
|
2053 | + $no_autolink_area = true; |
|
2054 | + } |
|
1963 | 2055 | $lastAutoPos = $pos; |
1964 | 2056 | |
1965 | 2057 | if (!$no_autolink_area) |
@@ -2068,17 +2160,19 @@ discard block |
||
2068 | 2160 | if ($scheme == 'mailto') |
2069 | 2161 | { |
2070 | 2162 | $email_address = str_replace('mailto:', '', $url); |
2071 | - if (!isset($disabled['email']) && filter_var($email_address, FILTER_VALIDATE_EMAIL) !== false) |
|
2072 | - return '[email=' . $email_address . ']' . $url . '[/email]'; |
|
2073 | - else |
|
2074 | - return $url; |
|
2163 | + if (!isset($disabled['email']) && filter_var($email_address, FILTER_VALIDATE_EMAIL) !== false) { |
|
2164 | + return '[email=' . $email_address . ']' . $url . '[/email]'; |
|
2165 | + } else { |
|
2166 | + return $url; |
|
2167 | + } |
|
2075 | 2168 | } |
2076 | 2169 | |
2077 | 2170 | // Are we linking a schemeless URL or naked domain name (e.g. "example.com")? |
2078 | - if (empty($scheme)) |
|
2079 | - $fullUrl = '//' . ltrim($url, ':/'); |
|
2080 | - else |
|
2081 | - $fullUrl = $url; |
|
2171 | + if (empty($scheme)) { |
|
2172 | + $fullUrl = '//' . ltrim($url, ':/'); |
|
2173 | + } else { |
|
2174 | + $fullUrl = $url; |
|
2175 | + } |
|
2082 | 2176 | |
2083 | 2177 | return '[url="' . str_replace(array('[', ']'), array('[', ']'), $fullUrl) . '"]' . $url . '[/url]'; |
2084 | 2178 | }, $data); |
@@ -2127,16 +2221,18 @@ discard block |
||
2127 | 2221 | } |
2128 | 2222 | |
2129 | 2223 | // Are we there yet? Are we there yet? |
2130 | - if ($pos >= strlen($message) - 1) |
|
2131 | - break; |
|
2224 | + if ($pos >= strlen($message) - 1) { |
|
2225 | + break; |
|
2226 | + } |
|
2132 | 2227 | |
2133 | 2228 | $tags = strtolower($message[$pos + 1]); |
2134 | 2229 | |
2135 | 2230 | if ($tags == '/' && !empty($open_tags)) |
2136 | 2231 | { |
2137 | 2232 | $pos2 = strpos($message, ']', $pos + 1); |
2138 | - if ($pos2 == $pos + 2) |
|
2139 | - continue; |
|
2233 | + if ($pos2 == $pos + 2) { |
|
2234 | + continue; |
|
2235 | + } |
|
2140 | 2236 | |
2141 | 2237 | $look_for = strtolower(substr($message, $pos + 2, $pos2 - $pos - 2)); |
2142 | 2238 | |
@@ -2146,8 +2242,9 @@ discard block |
||
2146 | 2242 | do |
2147 | 2243 | { |
2148 | 2244 | $tag = array_pop($open_tags); |
2149 | - if (!$tag) |
|
2150 | - break; |
|
2245 | + if (!$tag) { |
|
2246 | + break; |
|
2247 | + } |
|
2151 | 2248 | |
2152 | 2249 | if (!empty($tag['block_level'])) |
2153 | 2250 | { |
@@ -2161,10 +2258,11 @@ discard block |
||
2161 | 2258 | // The idea is, if we are LOOKING for a block level tag, we can close them on the way. |
2162 | 2259 | if (strlen($look_for) > 0 && isset($bbc_codes[$look_for[0]])) |
2163 | 2260 | { |
2164 | - foreach ($bbc_codes[$look_for[0]] as $temp) |
|
2165 | - if ($temp['tag'] == $look_for) |
|
2261 | + foreach ($bbc_codes[$look_for[0]] as $temp) { |
|
2262 | + if ($temp['tag'] == $look_for) |
|
2166 | 2263 | { |
2167 | 2264 | $block_level = !empty($temp['block_level']); |
2265 | + } |
|
2168 | 2266 | break; |
2169 | 2267 | } |
2170 | 2268 | } |
@@ -2186,15 +2284,15 @@ discard block |
||
2186 | 2284 | { |
2187 | 2285 | $open_tags = $to_close; |
2188 | 2286 | continue; |
2189 | - } |
|
2190 | - elseif (!empty($to_close) && $tag['tag'] != $look_for) |
|
2287 | + } elseif (!empty($to_close) && $tag['tag'] != $look_for) |
|
2191 | 2288 | { |
2192 | 2289 | if ($block_level === null && isset($look_for[0], $bbc_codes[$look_for[0]])) |
2193 | 2290 | { |
2194 | - foreach ($bbc_codes[$look_for[0]] as $temp) |
|
2195 | - if ($temp['tag'] == $look_for) |
|
2291 | + foreach ($bbc_codes[$look_for[0]] as $temp) { |
|
2292 | + if ($temp['tag'] == $look_for) |
|
2196 | 2293 | { |
2197 | 2294 | $block_level = !empty($temp['block_level']); |
2295 | + } |
|
2198 | 2296 | break; |
2199 | 2297 | } |
2200 | 2298 | } |
@@ -2202,8 +2300,9 @@ discard block |
||
2202 | 2300 | // We're not looking for a block level tag (or maybe even a tag that exists...) |
2203 | 2301 | if (!$block_level) |
2204 | 2302 | { |
2205 | - foreach ($to_close as $tag) |
|
2206 | - array_push($open_tags, $tag); |
|
2303 | + foreach ($to_close as $tag) { |
|
2304 | + array_push($open_tags, $tag); |
|
2305 | + } |
|
2207 | 2306 | continue; |
2208 | 2307 | } |
2209 | 2308 | } |
@@ -2216,14 +2315,17 @@ discard block |
||
2216 | 2315 | |
2217 | 2316 | // See the comment at the end of the big loop - just eating whitespace ;). |
2218 | 2317 | $whitespace_regex = ''; |
2219 | - if (!empty($tag['block_level'])) |
|
2220 | - $whitespace_regex .= '( |\s)*(<br>)?'; |
|
2318 | + if (!empty($tag['block_level'])) { |
|
2319 | + $whitespace_regex .= '( |\s)*(<br>)?'; |
|
2320 | + } |
|
2221 | 2321 | // Trim one line of whitespace after unnested tags, but all of it after nested ones |
2222 | - if (!empty($tag['trim']) && $tag['trim'] != 'inside') |
|
2223 | - $whitespace_regex .= empty($tag['require_parents']) ? '( |\s)*' : '(<br>| |\s)*'; |
|
2322 | + if (!empty($tag['trim']) && $tag['trim'] != 'inside') { |
|
2323 | + $whitespace_regex .= empty($tag['require_parents']) ? '( |\s)*' : '(<br>| |\s)*'; |
|
2324 | + } |
|
2224 | 2325 | |
2225 | - if (!empty($whitespace_regex) && preg_match('~' . $whitespace_regex . '~', substr($message, $pos), $matches) != 0) |
|
2226 | - $message = substr($message, 0, $pos) . substr($message, $pos + strlen($matches[0])); |
|
2326 | + if (!empty($whitespace_regex) && preg_match('~' . $whitespace_regex . '~', substr($message, $pos), $matches) != 0) { |
|
2327 | + $message = substr($message, 0, $pos) . substr($message, $pos + strlen($matches[0])); |
|
2328 | + } |
|
2227 | 2329 | } |
2228 | 2330 | |
2229 | 2331 | if (!empty($to_close)) |
@@ -2236,8 +2338,9 @@ discard block |
||
2236 | 2338 | } |
2237 | 2339 | |
2238 | 2340 | // No tags for this character, so just keep going (fastest possible course.) |
2239 | - if (!isset($bbc_codes[$tags])) |
|
2240 | - continue; |
|
2341 | + if (!isset($bbc_codes[$tags])) { |
|
2342 | + continue; |
|
2343 | + } |
|
2241 | 2344 | |
2242 | 2345 | $inside = empty($open_tags) ? null : $open_tags[count($open_tags) - 1]; |
2243 | 2346 | $tag = null; |
@@ -2246,44 +2349,52 @@ discard block |
||
2246 | 2349 | $pt_strlen = strlen($possible['tag']); |
2247 | 2350 | |
2248 | 2351 | // Not a match? |
2249 | - if (strtolower(substr($message, $pos + 1, $pt_strlen)) != $possible['tag']) |
|
2250 | - continue; |
|
2352 | + if (strtolower(substr($message, $pos + 1, $pt_strlen)) != $possible['tag']) { |
|
2353 | + continue; |
|
2354 | + } |
|
2251 | 2355 | |
2252 | 2356 | $next_c = $message[$pos + 1 + $pt_strlen]; |
2253 | 2357 | |
2254 | 2358 | // A test validation? |
2255 | - if (isset($possible['test']) && preg_match('~^' . $possible['test'] . '~', substr($message, $pos + 1 + $pt_strlen + 1)) === 0) |
|
2256 | - continue; |
|
2359 | + if (isset($possible['test']) && preg_match('~^' . $possible['test'] . '~', substr($message, $pos + 1 + $pt_strlen + 1)) === 0) { |
|
2360 | + continue; |
|
2361 | + } |
|
2257 | 2362 | // Do we want parameters? |
2258 | 2363 | elseif (!empty($possible['parameters'])) |
2259 | 2364 | { |
2260 | - if ($next_c != ' ') |
|
2261 | - continue; |
|
2262 | - } |
|
2263 | - elseif (isset($possible['type'])) |
|
2365 | + if ($next_c != ' ') { |
|
2366 | + continue; |
|
2367 | + } |
|
2368 | + } elseif (isset($possible['type'])) |
|
2264 | 2369 | { |
2265 | 2370 | // Do we need an equal sign? |
2266 | - if (in_array($possible['type'], array('unparsed_equals', 'unparsed_commas', 'unparsed_commas_content', 'unparsed_equals_content', 'parsed_equals')) && $next_c != '=') |
|
2267 | - continue; |
|
2371 | + if (in_array($possible['type'], array('unparsed_equals', 'unparsed_commas', 'unparsed_commas_content', 'unparsed_equals_content', 'parsed_equals')) && $next_c != '=') { |
|
2372 | + continue; |
|
2373 | + } |
|
2268 | 2374 | // Maybe we just want a /... |
2269 | - if ($possible['type'] == 'closed' && $next_c != ']' && substr($message, $pos + 1 + $pt_strlen, 2) != '/]' && substr($message, $pos + 1 + $pt_strlen, 3) != ' /]') |
|
2270 | - continue; |
|
2375 | + if ($possible['type'] == 'closed' && $next_c != ']' && substr($message, $pos + 1 + $pt_strlen, 2) != '/]' && substr($message, $pos + 1 + $pt_strlen, 3) != ' /]') { |
|
2376 | + continue; |
|
2377 | + } |
|
2271 | 2378 | // An immediate ]? |
2272 | - if ($possible['type'] == 'unparsed_content' && $next_c != ']') |
|
2273 | - continue; |
|
2379 | + if ($possible['type'] == 'unparsed_content' && $next_c != ']') { |
|
2380 | + continue; |
|
2381 | + } |
|
2274 | 2382 | } |
2275 | 2383 | // No type means 'parsed_content', which demands an immediate ] without parameters! |
2276 | - elseif ($next_c != ']') |
|
2277 | - continue; |
|
2384 | + elseif ($next_c != ']') { |
|
2385 | + continue; |
|
2386 | + } |
|
2278 | 2387 | |
2279 | 2388 | // Check allowed tree? |
2280 | - if (isset($possible['require_parents']) && ($inside === null || !in_array($inside['tag'], $possible['require_parents']))) |
|
2281 | - continue; |
|
2282 | - elseif (isset($inside['require_children']) && !in_array($possible['tag'], $inside['require_children'])) |
|
2283 | - continue; |
|
2389 | + if (isset($possible['require_parents']) && ($inside === null || !in_array($inside['tag'], $possible['require_parents']))) { |
|
2390 | + continue; |
|
2391 | + } elseif (isset($inside['require_children']) && !in_array($possible['tag'], $inside['require_children'])) { |
|
2392 | + continue; |
|
2393 | + } |
|
2284 | 2394 | // If this is in the list of disallowed child tags, don't parse it. |
2285 | - elseif (isset($inside['disallow_children']) && in_array($possible['tag'], $inside['disallow_children'])) |
|
2286 | - continue; |
|
2395 | + elseif (isset($inside['disallow_children']) && in_array($possible['tag'], $inside['disallow_children'])) { |
|
2396 | + continue; |
|
2397 | + } |
|
2287 | 2398 | |
2288 | 2399 | $pos1 = $pos + 1 + $pt_strlen + 1; |
2289 | 2400 | |
@@ -2295,8 +2406,9 @@ discard block |
||
2295 | 2406 | foreach ($open_tags as $open_quote) |
2296 | 2407 | { |
2297 | 2408 | // Every parent quote this quote has flips the styling |
2298 | - if ($open_quote['tag'] == 'quote') |
|
2299 | - $quote_alt = !$quote_alt; |
|
2409 | + if ($open_quote['tag'] == 'quote') { |
|
2410 | + $quote_alt = !$quote_alt; |
|
2411 | + } |
|
2300 | 2412 | } |
2301 | 2413 | // Add a class to the quote to style alternating blockquotes |
2302 | 2414 | $possible['before'] = strtr($possible['before'], array('<blockquote>' => '<blockquote class="bbc_' . ($quote_alt ? 'alternate' : 'standard') . '_quote">')); |
@@ -2307,8 +2419,9 @@ discard block |
||
2307 | 2419 | { |
2308 | 2420 | // Build a regular expression for each parameter for the current tag. |
2309 | 2421 | $preg = array(); |
2310 | - foreach ($possible['parameters'] as $p => $info) |
|
2311 | - $preg[] = '(\s+' . $p . '=' . (empty($info['quoted']) ? '' : '"') . (isset($info['match']) ? $info['match'] : '(.+?)') . (empty($info['quoted']) ? '' : '"') . '\s*)' . (empty($info['optional']) ? '' : '?'); |
|
2422 | + foreach ($possible['parameters'] as $p => $info) { |
|
2423 | + $preg[] = '(\s+' . $p . '=' . (empty($info['quoted']) ? '' : '"') . (isset($info['match']) ? $info['match'] : '(.+?)') . (empty($info['quoted']) ? '' : '"') . '\s*)' . (empty($info['optional']) ? '' : '?'); |
|
2424 | + } |
|
2312 | 2425 | |
2313 | 2426 | // Extract the string that potentially holds our parameters. |
2314 | 2427 | $blob = preg_split('~\[/?(?:' . $alltags_regex . ')~i', substr($message, $pos)); |
@@ -2328,24 +2441,27 @@ discard block |
||
2328 | 2441 | |
2329 | 2442 | $match = preg_match('~^' . implode('', $preg) . '$~i', implode(' ', $given_params), $matches) !== 0; |
2330 | 2443 | |
2331 | - if ($match) |
|
2332 | - $blob_counter = count($blobs) + 1; |
|
2444 | + if ($match) { |
|
2445 | + $blob_counter = count($blobs) + 1; |
|
2446 | + } |
|
2333 | 2447 | } |
2334 | 2448 | |
2335 | 2449 | // Didn't match our parameter list, try the next possible. |
2336 | - if (!$match) |
|
2337 | - continue; |
|
2450 | + if (!$match) { |
|
2451 | + continue; |
|
2452 | + } |
|
2338 | 2453 | |
2339 | 2454 | $params = array(); |
2340 | 2455 | for ($i = 1, $n = count($matches); $i < $n; $i += 2) |
2341 | 2456 | { |
2342 | 2457 | $key = strtok(ltrim($matches[$i]), '='); |
2343 | - if (isset($possible['parameters'][$key]['value'])) |
|
2344 | - $params['{' . $key . '}'] = strtr($possible['parameters'][$key]['value'], array('$1' => $matches[$i + 1])); |
|
2345 | - elseif (isset($possible['parameters'][$key]['validate'])) |
|
2346 | - $params['{' . $key . '}'] = $possible['parameters'][$key]['validate']($matches[$i + 1]); |
|
2347 | - else |
|
2348 | - $params['{' . $key . '}'] = $matches[$i + 1]; |
|
2458 | + if (isset($possible['parameters'][$key]['value'])) { |
|
2459 | + $params['{' . $key . '}'] = strtr($possible['parameters'][$key]['value'], array('$1' => $matches[$i + 1])); |
|
2460 | + } elseif (isset($possible['parameters'][$key]['validate'])) { |
|
2461 | + $params['{' . $key . '}'] = $possible['parameters'][$key]['validate']($matches[$i + 1]); |
|
2462 | + } else { |
|
2463 | + $params['{' . $key . '}'] = $matches[$i + 1]; |
|
2464 | + } |
|
2349 | 2465 | |
2350 | 2466 | // Just to make sure: replace any $ or { so they can't interpolate wrongly. |
2351 | 2467 | $params['{' . $key . '}'] = strtr($params['{' . $key . '}'], array('$' => '$', '{' => '{')); |
@@ -2353,23 +2469,26 @@ discard block |
||
2353 | 2469 | |
2354 | 2470 | foreach ($possible['parameters'] as $p => $info) |
2355 | 2471 | { |
2356 | - if (!isset($params['{' . $p . '}'])) |
|
2357 | - $params['{' . $p . '}'] = ''; |
|
2472 | + if (!isset($params['{' . $p . '}'])) { |
|
2473 | + $params['{' . $p . '}'] = ''; |
|
2474 | + } |
|
2358 | 2475 | } |
2359 | 2476 | |
2360 | 2477 | $tag = $possible; |
2361 | 2478 | |
2362 | 2479 | // Put the parameters into the string. |
2363 | - if (isset($tag['before'])) |
|
2364 | - $tag['before'] = strtr($tag['before'], $params); |
|
2365 | - if (isset($tag['after'])) |
|
2366 | - $tag['after'] = strtr($tag['after'], $params); |
|
2367 | - if (isset($tag['content'])) |
|
2368 | - $tag['content'] = strtr($tag['content'], $params); |
|
2480 | + if (isset($tag['before'])) { |
|
2481 | + $tag['before'] = strtr($tag['before'], $params); |
|
2482 | + } |
|
2483 | + if (isset($tag['after'])) { |
|
2484 | + $tag['after'] = strtr($tag['after'], $params); |
|
2485 | + } |
|
2486 | + if (isset($tag['content'])) { |
|
2487 | + $tag['content'] = strtr($tag['content'], $params); |
|
2488 | + } |
|
2369 | 2489 | |
2370 | 2490 | $pos1 += strlen($given_param_string); |
2371 | - } |
|
2372 | - else |
|
2491 | + } else |
|
2373 | 2492 | { |
2374 | 2493 | $tag = $possible; |
2375 | 2494 | $params = array(); |
@@ -2380,8 +2499,9 @@ discard block |
||
2380 | 2499 | // Item codes are complicated buggers... they are implicit [li]s and can make [list]s! |
2381 | 2500 | if ($smileys !== false && $tag === null && isset($itemcodes[$message[$pos + 1]]) && $message[$pos + 2] == ']' && !isset($disabled['list']) && !isset($disabled['li'])) |
2382 | 2501 | { |
2383 | - if ($message[$pos + 1] == '0' && !in_array($message[$pos - 1], array(';', ' ', "\t", "\n", '>'))) |
|
2384 | - continue; |
|
2502 | + if ($message[$pos + 1] == '0' && !in_array($message[$pos - 1], array(';', ' ', "\t", "\n", '>'))) { |
|
2503 | + continue; |
|
2504 | + } |
|
2385 | 2505 | |
2386 | 2506 | $tag = $itemcodes[$message[$pos + 1]]; |
2387 | 2507 | |
@@ -2402,9 +2522,9 @@ discard block |
||
2402 | 2522 | { |
2403 | 2523 | array_pop($open_tags); |
2404 | 2524 | $code = '</li>'; |
2525 | + } else { |
|
2526 | + $code = ''; |
|
2405 | 2527 | } |
2406 | - else |
|
2407 | - $code = ''; |
|
2408 | 2528 | |
2409 | 2529 | // Now we open a new tag. |
2410 | 2530 | $open_tags[] = array( |
@@ -2451,12 +2571,14 @@ discard block |
||
2451 | 2571 | } |
2452 | 2572 | |
2453 | 2573 | // No tag? Keep looking, then. Silly people using brackets without actual tags. |
2454 | - if ($tag === null) |
|
2455 | - continue; |
|
2574 | + if ($tag === null) { |
|
2575 | + continue; |
|
2576 | + } |
|
2456 | 2577 | |
2457 | 2578 | // Propagate the list to the child (so wrapping the disallowed tag won't work either.) |
2458 | - if (isset($inside['disallow_children'])) |
|
2459 | - $tag['disallow_children'] = isset($tag['disallow_children']) ? array_unique(array_merge($tag['disallow_children'], $inside['disallow_children'])) : $inside['disallow_children']; |
|
2579 | + if (isset($inside['disallow_children'])) { |
|
2580 | + $tag['disallow_children'] = isset($tag['disallow_children']) ? array_unique(array_merge($tag['disallow_children'], $inside['disallow_children'])) : $inside['disallow_children']; |
|
2581 | + } |
|
2460 | 2582 | |
2461 | 2583 | // Is this tag disabled? |
2462 | 2584 | if (isset($disabled[$tag['tag']])) |
@@ -2466,14 +2588,13 @@ discard block |
||
2466 | 2588 | $tag['before'] = !empty($tag['block_level']) ? '<div>' : ''; |
2467 | 2589 | $tag['after'] = !empty($tag['block_level']) ? '</div>' : ''; |
2468 | 2590 | $tag['content'] = isset($tag['type']) && $tag['type'] == 'closed' ? '' : (!empty($tag['block_level']) ? '<div>$1</div>' : '$1'); |
2469 | - } |
|
2470 | - elseif (isset($tag['disabled_before']) || isset($tag['disabled_after'])) |
|
2591 | + } elseif (isset($tag['disabled_before']) || isset($tag['disabled_after'])) |
|
2471 | 2592 | { |
2472 | 2593 | $tag['before'] = isset($tag['disabled_before']) ? $tag['disabled_before'] : (!empty($tag['block_level']) ? '<div>' : ''); |
2473 | 2594 | $tag['after'] = isset($tag['disabled_after']) ? $tag['disabled_after'] : (!empty($tag['block_level']) ? '</div>' : ''); |
2595 | + } else { |
|
2596 | + $tag['content'] = $tag['disabled_content']; |
|
2474 | 2597 | } |
2475 | - else |
|
2476 | - $tag['content'] = $tag['disabled_content']; |
|
2477 | 2598 | } |
2478 | 2599 | |
2479 | 2600 | // we use this a lot |
@@ -2483,8 +2604,9 @@ discard block |
||
2483 | 2604 | if (!empty($tag['block_level']) && $tag['tag'] != 'html' && empty($inside['block_level'])) |
2484 | 2605 | { |
2485 | 2606 | $n = count($open_tags) - 1; |
2486 | - while (empty($open_tags[$n]['block_level']) && $n >= 0) |
|
2487 | - $n--; |
|
2607 | + while (empty($open_tags[$n]['block_level']) && $n >= 0) { |
|
2608 | + $n--; |
|
2609 | + } |
|
2488 | 2610 | |
2489 | 2611 | // Close all the non block level tags so this tag isn't surrounded by them. |
2490 | 2612 | for ($i = count($open_tags) - 1; $i > $n; $i--) |
@@ -2496,12 +2618,15 @@ discard block |
||
2496 | 2618 | |
2497 | 2619 | // Trim or eat trailing stuff... see comment at the end of the big loop. |
2498 | 2620 | $whitespace_regex = ''; |
2499 | - if (!empty($tag['block_level'])) |
|
2500 | - $whitespace_regex .= '( |\s)*(<br>)?'; |
|
2501 | - if (!empty($tag['trim']) && $tag['trim'] != 'inside') |
|
2502 | - $whitespace_regex .= empty($tag['require_parents']) ? '( |\s)*' : '(<br>| |\s)*'; |
|
2503 | - if (!empty($whitespace_regex) && preg_match('~' . $whitespace_regex . '~', substr($message, $pos), $matches) != 0) |
|
2504 | - $message = substr($message, 0, $pos) . substr($message, $pos + strlen($matches[0])); |
|
2621 | + if (!empty($tag['block_level'])) { |
|
2622 | + $whitespace_regex .= '( |\s)*(<br>)?'; |
|
2623 | + } |
|
2624 | + if (!empty($tag['trim']) && $tag['trim'] != 'inside') { |
|
2625 | + $whitespace_regex .= empty($tag['require_parents']) ? '( |\s)*' : '(<br>| |\s)*'; |
|
2626 | + } |
|
2627 | + if (!empty($whitespace_regex) && preg_match('~' . $whitespace_regex . '~', substr($message, $pos), $matches) != 0) { |
|
2628 | + $message = substr($message, 0, $pos) . substr($message, $pos + strlen($matches[0])); |
|
2629 | + } |
|
2505 | 2630 | |
2506 | 2631 | array_pop($open_tags); |
2507 | 2632 | } |
@@ -2522,16 +2647,19 @@ discard block |
||
2522 | 2647 | elseif ($tag['type'] == 'unparsed_content') |
2523 | 2648 | { |
2524 | 2649 | $pos2 = stripos($message, '[/' . substr($message, $pos + 1, $tag_strlen) . ']', $pos1); |
2525 | - if ($pos2 === false) |
|
2526 | - continue; |
|
2650 | + if ($pos2 === false) { |
|
2651 | + continue; |
|
2652 | + } |
|
2527 | 2653 | |
2528 | 2654 | $data = substr($message, $pos1, $pos2 - $pos1); |
2529 | 2655 | |
2530 | - if (!empty($tag['block_level']) && substr($data, 0, 4) == '<br>') |
|
2531 | - $data = substr($data, 4); |
|
2656 | + if (!empty($tag['block_level']) && substr($data, 0, 4) == '<br>') { |
|
2657 | + $data = substr($data, 4); |
|
2658 | + } |
|
2532 | 2659 | |
2533 | - if (isset($tag['validate'])) |
|
2534 | - $tag['validate']($tag, $data, $disabled, $params); |
|
2660 | + if (isset($tag['validate'])) { |
|
2661 | + $tag['validate']($tag, $data, $disabled, $params); |
|
2662 | + } |
|
2535 | 2663 | |
2536 | 2664 | $code = strtr($tag['content'], array('$1' => $data)); |
2537 | 2665 | $message = substr($message, 0, $pos) . "\n" . $code . "\n" . substr($message, $pos2 + 3 + $tag_strlen); |
@@ -2547,34 +2675,40 @@ discard block |
||
2547 | 2675 | if (isset($tag['quoted'])) |
2548 | 2676 | { |
2549 | 2677 | $quoted = substr($message, $pos1, 6) == '"'; |
2550 | - if ($tag['quoted'] != 'optional' && !$quoted) |
|
2551 | - continue; |
|
2678 | + if ($tag['quoted'] != 'optional' && !$quoted) { |
|
2679 | + continue; |
|
2680 | + } |
|
2552 | 2681 | |
2553 | - if ($quoted) |
|
2554 | - $pos1 += 6; |
|
2682 | + if ($quoted) { |
|
2683 | + $pos1 += 6; |
|
2684 | + } |
|
2685 | + } else { |
|
2686 | + $quoted = false; |
|
2555 | 2687 | } |
2556 | - else |
|
2557 | - $quoted = false; |
|
2558 | 2688 | |
2559 | 2689 | $pos2 = strpos($message, $quoted == false ? ']' : '"]', $pos1); |
2560 | - if ($pos2 === false) |
|
2561 | - continue; |
|
2690 | + if ($pos2 === false) { |
|
2691 | + continue; |
|
2692 | + } |
|
2562 | 2693 | |
2563 | 2694 | $pos3 = stripos($message, '[/' . substr($message, $pos + 1, $tag_strlen) . ']', $pos2); |
2564 | - if ($pos3 === false) |
|
2565 | - continue; |
|
2695 | + if ($pos3 === false) { |
|
2696 | + continue; |
|
2697 | + } |
|
2566 | 2698 | |
2567 | 2699 | $data = array( |
2568 | 2700 | substr($message, $pos2 + ($quoted == false ? 1 : 7), $pos3 - ($pos2 + ($quoted == false ? 1 : 7))), |
2569 | 2701 | substr($message, $pos1, $pos2 - $pos1) |
2570 | 2702 | ); |
2571 | 2703 | |
2572 | - if (!empty($tag['block_level']) && substr($data[0], 0, 4) == '<br>') |
|
2573 | - $data[0] = substr($data[0], 4); |
|
2704 | + if (!empty($tag['block_level']) && substr($data[0], 0, 4) == '<br>') { |
|
2705 | + $data[0] = substr($data[0], 4); |
|
2706 | + } |
|
2574 | 2707 | |
2575 | 2708 | // Validation for my parking, please! |
2576 | - if (isset($tag['validate'])) |
|
2577 | - $tag['validate']($tag, $data, $disabled, $params); |
|
2709 | + if (isset($tag['validate'])) { |
|
2710 | + $tag['validate']($tag, $data, $disabled, $params); |
|
2711 | + } |
|
2578 | 2712 | |
2579 | 2713 | $code = strtr($tag['content'], array('$1' => $data[0], '$2' => $data[1])); |
2580 | 2714 | $message = substr($message, 0, $pos) . "\n" . $code . "\n" . substr($message, $pos3 + 3 + $tag_strlen); |
@@ -2591,23 +2725,27 @@ discard block |
||
2591 | 2725 | elseif ($tag['type'] == 'unparsed_commas_content') |
2592 | 2726 | { |
2593 | 2727 | $pos2 = strpos($message, ']', $pos1); |
2594 | - if ($pos2 === false) |
|
2595 | - continue; |
|
2728 | + if ($pos2 === false) { |
|
2729 | + continue; |
|
2730 | + } |
|
2596 | 2731 | |
2597 | 2732 | $pos3 = stripos($message, '[/' . substr($message, $pos + 1, $tag_strlen) . ']', $pos2); |
2598 | - if ($pos3 === false) |
|
2599 | - continue; |
|
2733 | + if ($pos3 === false) { |
|
2734 | + continue; |
|
2735 | + } |
|
2600 | 2736 | |
2601 | 2737 | // We want $1 to be the content, and the rest to be csv. |
2602 | 2738 | $data = explode(',', ',' . substr($message, $pos1, $pos2 - $pos1)); |
2603 | 2739 | $data[0] = substr($message, $pos2 + 1, $pos3 - $pos2 - 1); |
2604 | 2740 | |
2605 | - if (isset($tag['validate'])) |
|
2606 | - $tag['validate']($tag, $data, $disabled, $params); |
|
2741 | + if (isset($tag['validate'])) { |
|
2742 | + $tag['validate']($tag, $data, $disabled, $params); |
|
2743 | + } |
|
2607 | 2744 | |
2608 | 2745 | $code = $tag['content']; |
2609 | - foreach ($data as $k => $d) |
|
2610 | - $code = strtr($code, array('$' . ($k + 1) => trim($d))); |
|
2746 | + foreach ($data as $k => $d) { |
|
2747 | + $code = strtr($code, array('$' . ($k + 1) => trim($d))); |
|
2748 | + } |
|
2611 | 2749 | $message = substr($message, 0, $pos) . "\n" . $code . "\n" . substr($message, $pos3 + 3 + $tag_strlen); |
2612 | 2750 | $pos += strlen($code) - 1 + 2; |
2613 | 2751 | } |
@@ -2615,24 +2753,28 @@ discard block |
||
2615 | 2753 | elseif ($tag['type'] == 'unparsed_commas') |
2616 | 2754 | { |
2617 | 2755 | $pos2 = strpos($message, ']', $pos1); |
2618 | - if ($pos2 === false) |
|
2619 | - continue; |
|
2756 | + if ($pos2 === false) { |
|
2757 | + continue; |
|
2758 | + } |
|
2620 | 2759 | |
2621 | 2760 | $data = explode(',', substr($message, $pos1, $pos2 - $pos1)); |
2622 | 2761 | |
2623 | - if (isset($tag['validate'])) |
|
2624 | - $tag['validate']($tag, $data, $disabled, $params); |
|
2762 | + if (isset($tag['validate'])) { |
|
2763 | + $tag['validate']($tag, $data, $disabled, $params); |
|
2764 | + } |
|
2625 | 2765 | |
2626 | 2766 | // Fix after, for disabled code mainly. |
2627 | - foreach ($data as $k => $d) |
|
2628 | - $tag['after'] = strtr($tag['after'], array('$' . ($k + 1) => trim($d))); |
|
2767 | + foreach ($data as $k => $d) { |
|
2768 | + $tag['after'] = strtr($tag['after'], array('$' . ($k + 1) => trim($d))); |
|
2769 | + } |
|
2629 | 2770 | |
2630 | 2771 | $open_tags[] = $tag; |
2631 | 2772 | |
2632 | 2773 | // Replace them out, $1, $2, $3, $4, etc. |
2633 | 2774 | $code = $tag['before']; |
2634 | - foreach ($data as $k => $d) |
|
2635 | - $code = strtr($code, array('$' . ($k + 1) => trim($d))); |
|
2775 | + foreach ($data as $k => $d) { |
|
2776 | + $code = strtr($code, array('$' . ($k + 1) => trim($d))); |
|
2777 | + } |
|
2636 | 2778 | $message = substr($message, 0, $pos) . "\n" . $code . "\n" . substr($message, $pos2 + 1); |
2637 | 2779 | $pos += strlen($code) - 1 + 2; |
2638 | 2780 | } |
@@ -2643,28 +2785,33 @@ discard block |
||
2643 | 2785 | if (isset($tag['quoted'])) |
2644 | 2786 | { |
2645 | 2787 | $quoted = substr($message, $pos1, 6) == '"'; |
2646 | - if ($tag['quoted'] != 'optional' && !$quoted) |
|
2647 | - continue; |
|
2788 | + if ($tag['quoted'] != 'optional' && !$quoted) { |
|
2789 | + continue; |
|
2790 | + } |
|
2648 | 2791 | |
2649 | - if ($quoted) |
|
2650 | - $pos1 += 6; |
|
2792 | + if ($quoted) { |
|
2793 | + $pos1 += 6; |
|
2794 | + } |
|
2795 | + } else { |
|
2796 | + $quoted = false; |
|
2651 | 2797 | } |
2652 | - else |
|
2653 | - $quoted = false; |
|
2654 | 2798 | |
2655 | 2799 | $pos2 = strpos($message, $quoted == false ? ']' : '"]', $pos1); |
2656 | - if ($pos2 === false) |
|
2657 | - continue; |
|
2800 | + if ($pos2 === false) { |
|
2801 | + continue; |
|
2802 | + } |
|
2658 | 2803 | |
2659 | 2804 | $data = substr($message, $pos1, $pos2 - $pos1); |
2660 | 2805 | |
2661 | 2806 | // Validation for my parking, please! |
2662 | - if (isset($tag['validate'])) |
|
2663 | - $tag['validate']($tag, $data, $disabled, $params); |
|
2807 | + if (isset($tag['validate'])) { |
|
2808 | + $tag['validate']($tag, $data, $disabled, $params); |
|
2809 | + } |
|
2664 | 2810 | |
2665 | 2811 | // For parsed content, we must recurse to avoid security problems. |
2666 | - if ($tag['type'] != 'unparsed_equals') |
|
2667 | - $data = parse_bbc($data, !empty($tag['parsed_tags_allowed']) ? false : true, '', !empty($tag['parsed_tags_allowed']) ? $tag['parsed_tags_allowed'] : array()); |
|
2812 | + if ($tag['type'] != 'unparsed_equals') { |
|
2813 | + $data = parse_bbc($data, !empty($tag['parsed_tags_allowed']) ? false : true, '', !empty($tag['parsed_tags_allowed']) ? $tag['parsed_tags_allowed'] : array()); |
|
2814 | + } |
|
2668 | 2815 | |
2669 | 2816 | $tag['after'] = strtr($tag['after'], array('$1' => $data)); |
2670 | 2817 | |
@@ -2676,34 +2823,40 @@ discard block |
||
2676 | 2823 | } |
2677 | 2824 | |
2678 | 2825 | // If this is block level, eat any breaks after it. |
2679 | - if (!empty($tag['block_level']) && substr($message, $pos + 1, 4) == '<br>') |
|
2680 | - $message = substr($message, 0, $pos + 1) . substr($message, $pos + 5); |
|
2826 | + if (!empty($tag['block_level']) && substr($message, $pos + 1, 4) == '<br>') { |
|
2827 | + $message = substr($message, 0, $pos + 1) . substr($message, $pos + 5); |
|
2828 | + } |
|
2681 | 2829 | |
2682 | 2830 | // Are we trimming outside this tag? |
2683 | - if (!empty($tag['trim']) && $tag['trim'] != 'outside' && preg_match('~(<br>| |\s)*~', substr($message, $pos + 1), $matches) != 0) |
|
2684 | - $message = substr($message, 0, $pos + 1) . substr($message, $pos + 1 + strlen($matches[0])); |
|
2831 | + if (!empty($tag['trim']) && $tag['trim'] != 'outside' && preg_match('~(<br>| |\s)*~', substr($message, $pos + 1), $matches) != 0) { |
|
2832 | + $message = substr($message, 0, $pos + 1) . substr($message, $pos + 1 + strlen($matches[0])); |
|
2833 | + } |
|
2685 | 2834 | } |
2686 | 2835 | |
2687 | 2836 | // Close any remaining tags. |
2688 | - while ($tag = array_pop($open_tags)) |
|
2689 | - $message .= "\n" . $tag['after'] . "\n"; |
|
2837 | + while ($tag = array_pop($open_tags)) { |
|
2838 | + $message .= "\n" . $tag['after'] . "\n"; |
|
2839 | + } |
|
2690 | 2840 | |
2691 | 2841 | // Parse the smileys within the parts where it can be done safely. |
2692 | 2842 | if ($smileys === true) |
2693 | 2843 | { |
2694 | 2844 | $message_parts = explode("\n", $message); |
2695 | - for ($i = 0, $n = count($message_parts); $i < $n; $i += 2) |
|
2696 | - parsesmileys($message_parts[$i]); |
|
2845 | + for ($i = 0, $n = count($message_parts); $i < $n; $i += 2) { |
|
2846 | + parsesmileys($message_parts[$i]); |
|
2847 | + } |
|
2697 | 2848 | |
2698 | 2849 | $message = implode('', $message_parts); |
2699 | 2850 | } |
2700 | 2851 | |
2701 | 2852 | // No smileys, just get rid of the markers. |
2702 | - else |
|
2703 | - $message = strtr($message, array("\n" => '')); |
|
2853 | + else { |
|
2854 | + $message = strtr($message, array("\n" => '')); |
|
2855 | + } |
|
2704 | 2856 | |
2705 | - if ($message !== '' && $message[0] === ' ') |
|
2706 | - $message = ' ' . substr($message, 1); |
|
2857 | + if ($message !== '' && $message[0] === ' ') { |
|
2858 | + $message = ' ' . substr($message, 1); |
|
2859 | + } |
|
2707 | 2860 | |
2708 | 2861 | // Cleanup whitespace. |
2709 | 2862 | $message = strtr($message, array(' ' => ' ', "\r" => '', "\n" => '<br>', '<br> ' => '<br> ', ' ' => "\n")); |
@@ -2712,15 +2865,16 @@ discard block |
||
2712 | 2865 | call_integration_hook('integrate_post_parsebbc', array(&$message, &$smileys, &$cache_id, &$parse_tags)); |
2713 | 2866 | |
2714 | 2867 | // Cache the output if it took some time... |
2715 | - if (isset($cache_key, $cache_t) && array_sum(explode(' ', microtime())) - array_sum(explode(' ', $cache_t)) > 0.05) |
|
2716 | - cache_put_data($cache_key, $message, 240); |
|
2868 | + if (isset($cache_key, $cache_t) && array_sum(explode(' ', microtime())) - array_sum(explode(' ', $cache_t)) > 0.05) { |
|
2869 | + cache_put_data($cache_key, $message, 240); |
|
2870 | + } |
|
2717 | 2871 | |
2718 | 2872 | // If this was a force parse revert if needed. |
2719 | 2873 | if (!empty($parse_tags)) |
2720 | 2874 | { |
2721 | - if (empty($temp_bbc)) |
|
2722 | - $bbc_codes = array(); |
|
2723 | - else |
|
2875 | + if (empty($temp_bbc)) { |
|
2876 | + $bbc_codes = array(); |
|
2877 | + } else |
|
2724 | 2878 | { |
2725 | 2879 | $bbc_codes = $temp_bbc; |
2726 | 2880 | unset($temp_bbc); |
@@ -2747,8 +2901,9 @@ discard block |
||
2747 | 2901 | static $smileyPregSearch = null, $smileyPregReplacements = array(); |
2748 | 2902 | |
2749 | 2903 | // No smiley set at all?! |
2750 | - if ($user_info['smiley_set'] == 'none' || trim($message) == '') |
|
2751 | - return; |
|
2904 | + if ($user_info['smiley_set'] == 'none' || trim($message) == '') { |
|
2905 | + return; |
|
2906 | + } |
|
2752 | 2907 | |
2753 | 2908 | // If smileyPregSearch hasn't been set, do it now. |
2754 | 2909 | if (empty($smileyPregSearch)) |
@@ -2759,8 +2914,7 @@ discard block |
||
2759 | 2914 | $smileysfrom = array('>:D', ':D', '::)', '>:(', ':))', ':)', ';)', ';D', ':(', ':o', '8)', ':P', '???', ':-[', ':-X', ':-*', ':\'(', ':-\\', '^-^', 'O0', 'C:-)', '0:)'); |
2760 | 2915 | $smileysto = array('evil.gif', 'cheesy.gif', 'rolleyes.gif', 'angry.gif', 'laugh.gif', 'smiley.gif', 'wink.gif', 'grin.gif', 'sad.gif', 'shocked.gif', 'cool.gif', 'tongue.gif', 'huh.gif', 'embarrassed.gif', 'lipsrsealed.gif', 'kiss.gif', 'cry.gif', 'undecided.gif', 'azn.gif', 'afro.gif', 'police.gif', 'angel.gif'); |
2761 | 2916 | $smileysdescs = array('', $txt['icon_cheesy'], $txt['icon_rolleyes'], $txt['icon_angry'], '', $txt['icon_smiley'], $txt['icon_wink'], $txt['icon_grin'], $txt['icon_sad'], $txt['icon_shocked'], $txt['icon_cool'], $txt['icon_tongue'], $txt['icon_huh'], $txt['icon_embarrassed'], $txt['icon_lips'], $txt['icon_kiss'], $txt['icon_cry'], $txt['icon_undecided'], '', '', '', ''); |
2762 | - } |
|
2763 | - else |
|
2917 | + } else |
|
2764 | 2918 | { |
2765 | 2919 | // Load the smileys in reverse order by length so they don't get parsed wrong. |
2766 | 2920 | if (($temp = cache_get_data('parsing_smileys', 480)) == null) |
@@ -2784,9 +2938,9 @@ discard block |
||
2784 | 2938 | $smcFunc['db_free_result']($result); |
2785 | 2939 | |
2786 | 2940 | cache_put_data('parsing_smileys', array($smileysfrom, $smileysto, $smileysdescs), 480); |
2941 | + } else { |
|
2942 | + list ($smileysfrom, $smileysto, $smileysdescs) = $temp; |
|
2787 | 2943 | } |
2788 | - else |
|
2789 | - list ($smileysfrom, $smileysto, $smileysdescs) = $temp; |
|
2790 | 2944 | } |
2791 | 2945 | |
2792 | 2946 | // The non-breaking-space is a complex thing... |
@@ -2863,35 +3017,41 @@ discard block |
||
2863 | 3017 | global $scripturl, $context, $modSettings, $db_show_debug, $db_cache; |
2864 | 3018 | |
2865 | 3019 | // In case we have mail to send, better do that - as obExit doesn't always quite make it... |
2866 | - if (!empty($context['flush_mail'])) |
|
2867 | - // @todo this relies on 'flush_mail' being only set in AddMailQueue itself... :\ |
|
3020 | + if (!empty($context['flush_mail'])) { |
|
3021 | + // @todo this relies on 'flush_mail' being only set in AddMailQueue itself... :\ |
|
2868 | 3022 | AddMailQueue(true); |
3023 | + } |
|
2869 | 3024 | |
2870 | 3025 | $add = preg_match('~^(ftp|http)[s]?://~', $setLocation) == 0 && substr($setLocation, 0, 6) != 'about:'; |
2871 | 3026 | |
2872 | - if ($add) |
|
2873 | - $setLocation = $scripturl . ($setLocation != '' ? '?' . $setLocation : ''); |
|
3027 | + if ($add) { |
|
3028 | + $setLocation = $scripturl . ($setLocation != '' ? '?' . $setLocation : ''); |
|
3029 | + } |
|
2874 | 3030 | |
2875 | 3031 | // Put the session ID in. |
2876 | - if (defined('SID') && SID != '') |
|
2877 | - $setLocation = preg_replace('/^' . preg_quote($scripturl, '/') . '(?!\?' . preg_quote(SID, '/') . ')\\??/', $scripturl . '?' . SID . ';', $setLocation); |
|
3032 | + if (defined('SID') && SID != '') { |
|
3033 | + $setLocation = preg_replace('/^' . preg_quote($scripturl, '/') . '(?!\?' . preg_quote(SID, '/') . ')\\??/', $scripturl . '?' . SID . ';', $setLocation); |
|
3034 | + } |
|
2878 | 3035 | // Keep that debug in their for template debugging! |
2879 | - elseif (isset($_GET['debug'])) |
|
2880 | - $setLocation = preg_replace('/^' . preg_quote($scripturl, '/') . '\\??/', $scripturl . '?debug;', $setLocation); |
|
3036 | + elseif (isset($_GET['debug'])) { |
|
3037 | + $setLocation = preg_replace('/^' . preg_quote($scripturl, '/') . '\\??/', $scripturl . '?debug;', $setLocation); |
|
3038 | + } |
|
2881 | 3039 | |
2882 | 3040 | if (!empty($modSettings['queryless_urls']) && (empty($context['server']['is_cgi']) || ini_get('cgi.fix_pathinfo') == 1 || @get_cfg_var('cgi.fix_pathinfo') == 1) && (!empty($context['server']['is_apache']) || !empty($context['server']['is_lighttpd']) || !empty($context['server']['is_litespeed']))) |
2883 | 3041 | { |
2884 | - if (defined('SID') && SID != '') |
|
2885 | - $setLocation = preg_replace_callback('~^' . preg_quote($scripturl, '/') . '\?(?:' . SID . '(?:;|&|&))((?:board|topic)=[^#]+?)(#[^"]*?)?$~', |
|
3042 | + if (defined('SID') && SID != '') { |
|
3043 | + $setLocation = preg_replace_callback('~^' . preg_quote($scripturl, '/') . '\?(?:' . SID . '(?:;|&|&))((?:board|topic)=[^#]+?)(#[^"]*?)?$~', |
|
2886 | 3044 | function ($m) use ($scripturl) |
2887 | 3045 | { |
2888 | 3046 | return $scripturl . '/' . strtr("$m[1]", '&;=', '//,') . '.html?' . SID. (isset($m[2]) ? "$m[2]" : ""); |
3047 | + } |
|
2889 | 3048 | }, $setLocation); |
2890 | - else |
|
2891 | - $setLocation = preg_replace_callback('~^' . preg_quote($scripturl, '/') . '\?((?:board|topic)=[^#"]+?)(#[^"]*?)?$~', |
|
3049 | + else { |
|
3050 | + $setLocation = preg_replace_callback('~^' . preg_quote($scripturl, '/') . '\?((?:board|topic)=[^#"]+?)(#[^"]*?)?$~', |
|
2892 | 3051 | function ($m) use ($scripturl) |
2893 | 3052 | { |
2894 | 3053 | return $scripturl . '/' . strtr("$m[1]", '&;=', '//,') . '.html' . (isset($m[2]) ? "$m[2]" : ""); |
3054 | + } |
|
2895 | 3055 | }, $setLocation); |
2896 | 3056 | } |
2897 | 3057 | |
@@ -2902,8 +3062,9 @@ discard block |
||
2902 | 3062 | header('Location: ' . str_replace(' ', '%20', $setLocation), true, $permanent ? 301 : 302); |
2903 | 3063 | |
2904 | 3064 | // Debugging. |
2905 | - if (isset($db_show_debug) && $db_show_debug === true) |
|
2906 | - $_SESSION['debug_redirect'] = $db_cache; |
|
3065 | + if (isset($db_show_debug) && $db_show_debug === true) { |
|
3066 | + $_SESSION['debug_redirect'] = $db_cache; |
|
3067 | + } |
|
2907 | 3068 | |
2908 | 3069 | obExit(false); |
2909 | 3070 | } |
@@ -2922,51 +3083,60 @@ discard block |
||
2922 | 3083 | |
2923 | 3084 | // Attempt to prevent a recursive loop. |
2924 | 3085 | ++$level; |
2925 | - if ($level > 1 && !$from_fatal_error && !$has_fatal_error) |
|
2926 | - exit; |
|
2927 | - if ($from_fatal_error) |
|
2928 | - $has_fatal_error = true; |
|
3086 | + if ($level > 1 && !$from_fatal_error && !$has_fatal_error) { |
|
3087 | + exit; |
|
3088 | + } |
|
3089 | + if ($from_fatal_error) { |
|
3090 | + $has_fatal_error = true; |
|
3091 | + } |
|
2929 | 3092 | |
2930 | 3093 | // Clear out the stat cache. |
2931 | 3094 | trackStats(); |
2932 | 3095 | |
2933 | 3096 | // If we have mail to send, send it. |
2934 | - if (!empty($context['flush_mail'])) |
|
2935 | - // @todo this relies on 'flush_mail' being only set in AddMailQueue itself... :\ |
|
3097 | + if (!empty($context['flush_mail'])) { |
|
3098 | + // @todo this relies on 'flush_mail' being only set in AddMailQueue itself... :\ |
|
2936 | 3099 | AddMailQueue(true); |
3100 | + } |
|
2937 | 3101 | |
2938 | 3102 | $do_header = $header === null ? !$header_done : $header; |
2939 | - if ($do_footer === null) |
|
2940 | - $do_footer = $do_header; |
|
3103 | + if ($do_footer === null) { |
|
3104 | + $do_footer = $do_header; |
|
3105 | + } |
|
2941 | 3106 | |
2942 | 3107 | // Has the template/header been done yet? |
2943 | 3108 | if ($do_header) |
2944 | 3109 | { |
2945 | 3110 | // Was the page title set last minute? Also update the HTML safe one. |
2946 | - if (!empty($context['page_title']) && empty($context['page_title_html_safe'])) |
|
2947 | - $context['page_title_html_safe'] = $smcFunc['htmlspecialchars'](un_htmlspecialchars($context['page_title'])) . (!empty($context['current_page']) ? ' - ' . $txt['page'] . ' ' . ($context['current_page'] + 1) : ''); |
|
3111 | + if (!empty($context['page_title']) && empty($context['page_title_html_safe'])) { |
|
3112 | + $context['page_title_html_safe'] = $smcFunc['htmlspecialchars'](un_htmlspecialchars($context['page_title'])) . (!empty($context['current_page']) ? ' - ' . $txt['page'] . ' ' . ($context['current_page'] + 1) : ''); |
|
3113 | + } |
|
2948 | 3114 | |
2949 | 3115 | // Start up the session URL fixer. |
2950 | 3116 | ob_start('ob_sessrewrite'); |
2951 | 3117 | |
2952 | - if (!empty($settings['output_buffers']) && is_string($settings['output_buffers'])) |
|
2953 | - $buffers = explode(',', $settings['output_buffers']); |
|
2954 | - elseif (!empty($settings['output_buffers'])) |
|
2955 | - $buffers = $settings['output_buffers']; |
|
2956 | - else |
|
2957 | - $buffers = array(); |
|
3118 | + if (!empty($settings['output_buffers']) && is_string($settings['output_buffers'])) { |
|
3119 | + $buffers = explode(',', $settings['output_buffers']); |
|
3120 | + } elseif (!empty($settings['output_buffers'])) { |
|
3121 | + $buffers = $settings['output_buffers']; |
|
3122 | + } else { |
|
3123 | + $buffers = array(); |
|
3124 | + } |
|
2958 | 3125 | |
2959 | - if (isset($modSettings['integrate_buffer'])) |
|
2960 | - $buffers = array_merge(explode(',', $modSettings['integrate_buffer']), $buffers); |
|
3126 | + if (isset($modSettings['integrate_buffer'])) { |
|
3127 | + $buffers = array_merge(explode(',', $modSettings['integrate_buffer']), $buffers); |
|
3128 | + } |
|
2961 | 3129 | |
2962 | - if (!empty($buffers)) |
|
2963 | - foreach ($buffers as $function) |
|
3130 | + if (!empty($buffers)) { |
|
3131 | + foreach ($buffers as $function) |
|
2964 | 3132 | { |
2965 | 3133 | $call = call_helper($function, true); |
3134 | + } |
|
2966 | 3135 | |
2967 | 3136 | // Is it valid? |
2968 | - if (!empty($call)) |
|
2969 | - ob_start($call); |
|
3137 | + if (!empty($call)) { |
|
3138 | + ob_start($call); |
|
3139 | + } |
|
2970 | 3140 | } |
2971 | 3141 | |
2972 | 3142 | // Display the screen in the logical order. |
@@ -2978,8 +3148,9 @@ discard block |
||
2978 | 3148 | loadSubTemplate(isset($context['sub_template']) ? $context['sub_template'] : 'main'); |
2979 | 3149 | |
2980 | 3150 | // Anything special to put out? |
2981 | - if (!empty($context['insert_after_template']) && !isset($_REQUEST['xml'])) |
|
2982 | - echo $context['insert_after_template']; |
|
3151 | + if (!empty($context['insert_after_template']) && !isset($_REQUEST['xml'])) { |
|
3152 | + echo $context['insert_after_template']; |
|
3153 | + } |
|
2983 | 3154 | |
2984 | 3155 | // Just so we don't get caught in an endless loop of errors from the footer... |
2985 | 3156 | if (!$footer_done) |
@@ -2988,14 +3159,16 @@ discard block |
||
2988 | 3159 | template_footer(); |
2989 | 3160 | |
2990 | 3161 | // (since this is just debugging... it's okay that it's after </html>.) |
2991 | - if (!isset($_REQUEST['xml'])) |
|
2992 | - displayDebug(); |
|
3162 | + if (!isset($_REQUEST['xml'])) { |
|
3163 | + displayDebug(); |
|
3164 | + } |
|
2993 | 3165 | } |
2994 | 3166 | } |
2995 | 3167 | |
2996 | 3168 | // Remember this URL in case someone doesn't like sending HTTP_REFERER. |
2997 | - if (strpos($_SERVER['REQUEST_URL'], 'action=dlattach') === false && strpos($_SERVER['REQUEST_URL'], 'action=viewsmfile') === false) |
|
2998 | - $_SESSION['old_url'] = $_SERVER['REQUEST_URL']; |
|
3169 | + if (strpos($_SERVER['REQUEST_URL'], 'action=dlattach') === false && strpos($_SERVER['REQUEST_URL'], 'action=viewsmfile') === false) { |
|
3170 | + $_SESSION['old_url'] = $_SERVER['REQUEST_URL']; |
|
3171 | + } |
|
2999 | 3172 | |
3000 | 3173 | // For session check verification.... don't switch browsers... |
3001 | 3174 | $_SESSION['USER_AGENT'] = empty($_SERVER['HTTP_USER_AGENT']) ? '' : $_SERVER['HTTP_USER_AGENT']; |
@@ -3004,9 +3177,10 @@ discard block |
||
3004 | 3177 | call_integration_hook('integrate_exit', array($do_footer)); |
3005 | 3178 | |
3006 | 3179 | // Don't exit if we're coming from index.php; that will pass through normally. |
3007 | - if (!$from_index) |
|
3008 | - exit; |
|
3009 | -} |
|
3180 | + if (!$from_index) { |
|
3181 | + exit; |
|
3182 | + } |
|
3183 | + } |
|
3010 | 3184 | |
3011 | 3185 | /** |
3012 | 3186 | * Get the size of a specified image with better error handling. |
@@ -3025,8 +3199,9 @@ discard block |
||
3025 | 3199 | $url = str_replace(' ', '%20', $url); |
3026 | 3200 | |
3027 | 3201 | // Can we pull this from the cache... please please? |
3028 | - if (($temp = cache_get_data('url_image_size-' . md5($url), 240)) !== null) |
|
3029 | - return $temp; |
|
3202 | + if (($temp = cache_get_data('url_image_size-' . md5($url), 240)) !== null) { |
|
3203 | + return $temp; |
|
3204 | + } |
|
3030 | 3205 | $t = microtime(); |
3031 | 3206 | |
3032 | 3207 | // Get the host to pester... |
@@ -3036,12 +3211,10 @@ discard block |
||
3036 | 3211 | if ($url == '' || $url == 'http://' || $url == 'https://') |
3037 | 3212 | { |
3038 | 3213 | return false; |
3039 | - } |
|
3040 | - elseif (!isset($match[1])) |
|
3214 | + } elseif (!isset($match[1])) |
|
3041 | 3215 | { |
3042 | 3216 | $size = @getimagesize($url); |
3043 | - } |
|
3044 | - else |
|
3217 | + } else |
|
3045 | 3218 | { |
3046 | 3219 | // Try to connect to the server... give it half a second. |
3047 | 3220 | $temp = 0; |
@@ -3080,12 +3253,14 @@ discard block |
||
3080 | 3253 | } |
3081 | 3254 | |
3082 | 3255 | // If we didn't get it, we failed. |
3083 | - if (!isset($size)) |
|
3084 | - $size = false; |
|
3256 | + if (!isset($size)) { |
|
3257 | + $size = false; |
|
3258 | + } |
|
3085 | 3259 | |
3086 | 3260 | // If this took a long time, we may never have to do it again, but then again we might... |
3087 | - if (array_sum(explode(' ', microtime())) - array_sum(explode(' ', $t)) > 0.8) |
|
3088 | - cache_put_data('url_image_size-' . md5($url), $size, 240); |
|
3261 | + if (array_sum(explode(' ', microtime())) - array_sum(explode(' ', $t)) > 0.8) { |
|
3262 | + cache_put_data('url_image_size-' . md5($url), $size, 240); |
|
3263 | + } |
|
3089 | 3264 | |
3090 | 3265 | // Didn't work. |
3091 | 3266 | return $size; |
@@ -3103,8 +3278,9 @@ discard block |
||
3103 | 3278 | |
3104 | 3279 | // Under SSI this function can be called more then once. That can cause some problems. |
3105 | 3280 | // So only run the function once unless we are forced to run it again. |
3106 | - if ($loaded && !$forceload) |
|
3107 | - return; |
|
3281 | + if ($loaded && !$forceload) { |
|
3282 | + return; |
|
3283 | + } |
|
3108 | 3284 | |
3109 | 3285 | $loaded = true; |
3110 | 3286 | |
@@ -3116,14 +3292,16 @@ discard block |
||
3116 | 3292 | $context['news_lines'] = array_filter(explode("\n", str_replace("\r", '', trim(addslashes($modSettings['news']))))); |
3117 | 3293 | for ($i = 0, $n = count($context['news_lines']); $i < $n; $i++) |
3118 | 3294 | { |
3119 | - if (trim($context['news_lines'][$i]) == '') |
|
3120 | - continue; |
|
3295 | + if (trim($context['news_lines'][$i]) == '') { |
|
3296 | + continue; |
|
3297 | + } |
|
3121 | 3298 | |
3122 | 3299 | // Clean it up for presentation ;). |
3123 | 3300 | $context['news_lines'][$i] = parse_bbc(stripslashes(trim($context['news_lines'][$i])), true, 'news' . $i); |
3124 | 3301 | } |
3125 | - if (!empty($context['news_lines'])) |
|
3126 | - $context['random_news_line'] = $context['news_lines'][mt_rand(0, count($context['news_lines']) - 1)]; |
|
3302 | + if (!empty($context['news_lines'])) { |
|
3303 | + $context['random_news_line'] = $context['news_lines'][mt_rand(0, count($context['news_lines']) - 1)]; |
|
3304 | + } |
|
3127 | 3305 | |
3128 | 3306 | if (!$user_info['is_guest']) |
3129 | 3307 | { |
@@ -3132,40 +3310,48 @@ discard block |
||
3132 | 3310 | $context['user']['alerts'] = &$user_info['alerts']; |
3133 | 3311 | |
3134 | 3312 | // Personal message popup... |
3135 | - if ($user_info['unread_messages'] > (isset($_SESSION['unread_messages']) ? $_SESSION['unread_messages'] : 0)) |
|
3136 | - $context['user']['popup_messages'] = true; |
|
3137 | - else |
|
3138 | - $context['user']['popup_messages'] = false; |
|
3313 | + if ($user_info['unread_messages'] > (isset($_SESSION['unread_messages']) ? $_SESSION['unread_messages'] : 0)) { |
|
3314 | + $context['user']['popup_messages'] = true; |
|
3315 | + } else { |
|
3316 | + $context['user']['popup_messages'] = false; |
|
3317 | + } |
|
3139 | 3318 | $_SESSION['unread_messages'] = $user_info['unread_messages']; |
3140 | 3319 | |
3141 | - if (allowedTo('moderate_forum')) |
|
3142 | - $context['unapproved_members'] = (!empty($modSettings['registration_method']) && ($modSettings['registration_method'] == 2 || (!empty($modSettings['coppaType']) && $modSettings['coppaType'] == 2))) || !empty($modSettings['approveAccountDeletion']) ? $modSettings['unapprovedMembers'] : 0; |
|
3320 | + if (allowedTo('moderate_forum')) { |
|
3321 | + $context['unapproved_members'] = (!empty($modSettings['registration_method']) && ($modSettings['registration_method'] == 2 || (!empty($modSettings['coppaType']) && $modSettings['coppaType'] == 2))) || !empty($modSettings['approveAccountDeletion']) ? $modSettings['unapprovedMembers'] : 0; |
|
3322 | + } |
|
3143 | 3323 | |
3144 | 3324 | $context['user']['avatar'] = array(); |
3145 | 3325 | |
3146 | 3326 | // Check for gravatar first since we might be forcing them... |
3147 | 3327 | if (($modSettings['gravatarEnabled'] && substr($user_info['avatar']['url'], 0, 11) == 'gravatar://') || !empty($modSettings['gravatarOverride'])) |
3148 | 3328 | { |
3149 | - if (!empty($modSettings['gravatarAllowExtraEmail']) && stristr($user_info['avatar']['url'], 'gravatar://') && strlen($user_info['avatar']['url']) > 11) |
|
3150 | - $context['user']['avatar']['href'] = get_gravatar_url($smcFunc['substr']($user_info['avatar']['url'], 11)); |
|
3151 | - else |
|
3152 | - $context['user']['avatar']['href'] = get_gravatar_url($user_info['email']); |
|
3329 | + if (!empty($modSettings['gravatarAllowExtraEmail']) && stristr($user_info['avatar']['url'], 'gravatar://') && strlen($user_info['avatar']['url']) > 11) { |
|
3330 | + $context['user']['avatar']['href'] = get_gravatar_url($smcFunc['substr']($user_info['avatar']['url'], 11)); |
|
3331 | + } else { |
|
3332 | + $context['user']['avatar']['href'] = get_gravatar_url($user_info['email']); |
|
3333 | + } |
|
3153 | 3334 | } |
3154 | 3335 | // Uploaded? |
3155 | - elseif ($user_info['avatar']['url'] == '' && !empty($user_info['avatar']['id_attach'])) |
|
3156 | - $context['user']['avatar']['href'] = $user_info['avatar']['custom_dir'] ? $modSettings['custom_avatar_url'] . '/' . $user_info['avatar']['filename'] : $scripturl . '?action=dlattach;attach=' . $user_info['avatar']['id_attach'] . ';type=avatar'; |
|
3336 | + elseif ($user_info['avatar']['url'] == '' && !empty($user_info['avatar']['id_attach'])) { |
|
3337 | + $context['user']['avatar']['href'] = $user_info['avatar']['custom_dir'] ? $modSettings['custom_avatar_url'] . '/' . $user_info['avatar']['filename'] : $scripturl . '?action=dlattach;attach=' . $user_info['avatar']['id_attach'] . ';type=avatar'; |
|
3338 | + } |
|
3157 | 3339 | // Full URL? |
3158 | - elseif (strpos($user_info['avatar']['url'], 'http://') === 0 || strpos($user_info['avatar']['url'], 'https://') === 0) |
|
3159 | - $context['user']['avatar']['href'] = $user_info['avatar']['url']; |
|
3340 | + elseif (strpos($user_info['avatar']['url'], 'http://') === 0 || strpos($user_info['avatar']['url'], 'https://') === 0) { |
|
3341 | + $context['user']['avatar']['href'] = $user_info['avatar']['url']; |
|
3342 | + } |
|
3160 | 3343 | // Otherwise we assume it's server stored. |
3161 | - elseif ($user_info['avatar']['url'] != '') |
|
3162 | - $context['user']['avatar']['href'] = $modSettings['avatar_url'] . '/' . $smcFunc['htmlspecialchars']($user_info['avatar']['url']); |
|
3344 | + elseif ($user_info['avatar']['url'] != '') { |
|
3345 | + $context['user']['avatar']['href'] = $modSettings['avatar_url'] . '/' . $smcFunc['htmlspecialchars']($user_info['avatar']['url']); |
|
3346 | + } |
|
3163 | 3347 | // No avatar at all? Fine, we have a big fat default avatar ;) |
3164 | - else |
|
3165 | - $context['user']['avatar']['href'] = $modSettings['avatar_url'] . '/default.png'; |
|
3348 | + else { |
|
3349 | + $context['user']['avatar']['href'] = $modSettings['avatar_url'] . '/default.png'; |
|
3350 | + } |
|
3166 | 3351 | |
3167 | - if (!empty($context['user']['avatar'])) |
|
3168 | - $context['user']['avatar']['image'] = '<img src="' . $context['user']['avatar']['href'] . '" alt="" class="avatar">'; |
|
3352 | + if (!empty($context['user']['avatar'])) { |
|
3353 | + $context['user']['avatar']['image'] = '<img src="' . $context['user']['avatar']['href'] . '" alt="" class="avatar">'; |
|
3354 | + } |
|
3169 | 3355 | |
3170 | 3356 | // Figure out how long they've been logged in. |
3171 | 3357 | $context['user']['total_time_logged_in'] = array( |
@@ -3173,8 +3359,7 @@ discard block |
||
3173 | 3359 | 'hours' => floor(($user_info['total_time_logged_in'] % 86400) / 3600), |
3174 | 3360 | 'minutes' => floor(($user_info['total_time_logged_in'] % 3600) / 60) |
3175 | 3361 | ); |
3176 | - } |
|
3177 | - else |
|
3362 | + } else |
|
3178 | 3363 | { |
3179 | 3364 | $context['user']['messages'] = 0; |
3180 | 3365 | $context['user']['unread_messages'] = 0; |
@@ -3182,12 +3367,14 @@ discard block |
||
3182 | 3367 | $context['user']['total_time_logged_in'] = array('days' => 0, 'hours' => 0, 'minutes' => 0); |
3183 | 3368 | $context['user']['popup_messages'] = false; |
3184 | 3369 | |
3185 | - if (!empty($modSettings['registration_method']) && $modSettings['registration_method'] == 1) |
|
3186 | - $txt['welcome_guest'] .= $txt['welcome_guest_activate']; |
|
3370 | + if (!empty($modSettings['registration_method']) && $modSettings['registration_method'] == 1) { |
|
3371 | + $txt['welcome_guest'] .= $txt['welcome_guest_activate']; |
|
3372 | + } |
|
3187 | 3373 | |
3188 | 3374 | // If we've upgraded recently, go easy on the passwords. |
3189 | - if (!empty($modSettings['disableHashTime']) && ($modSettings['disableHashTime'] == 1 || time() < $modSettings['disableHashTime'])) |
|
3190 | - $context['disable_login_hashing'] = true; |
|
3375 | + if (!empty($modSettings['disableHashTime']) && ($modSettings['disableHashTime'] == 1 || time() < $modSettings['disableHashTime'])) { |
|
3376 | + $context['disable_login_hashing'] = true; |
|
3377 | + } |
|
3191 | 3378 | } |
3192 | 3379 | |
3193 | 3380 | // Setup the main menu items. |
@@ -3200,8 +3387,8 @@ discard block |
||
3200 | 3387 | $context['show_pm_popup'] = $context['user']['popup_messages'] && !empty($options['popup_messages']) && (!isset($_REQUEST['action']) || $_REQUEST['action'] != 'pm'); |
3201 | 3388 | |
3202 | 3389 | // 2.1+: Add the PM popup here instead. Theme authors can still override it simply by editing/removing the 'fPmPopup' in the array. |
3203 | - if ($context['show_pm_popup']) |
|
3204 | - addInlineJavaScript(' |
|
3390 | + if ($context['show_pm_popup']) { |
|
3391 | + addInlineJavaScript(' |
|
3205 | 3392 | jQuery(document).ready(function($) { |
3206 | 3393 | new smc_Popup({ |
3207 | 3394 | heading: ' . JavaScriptEscape($txt['show_personal_messages_heading']) . ', |
@@ -3209,15 +3396,17 @@ discard block |
||
3209 | 3396 | icon_class: \'generic_icons mail_new\' |
3210 | 3397 | }); |
3211 | 3398 | });'); |
3399 | + } |
|
3212 | 3400 | |
3213 | 3401 | // Add a generic "Are you sure?" confirmation message. |
3214 | 3402 | addInlineJavaScript(' |
3215 | 3403 | var smf_you_sure =' . JavaScriptEscape($txt['quickmod_confirm']) .';'); |
3216 | 3404 | |
3217 | 3405 | // Now add the capping code for avatars. |
3218 | - if (!empty($modSettings['avatar_max_width_external']) && !empty($modSettings['avatar_max_height_external']) && !empty($modSettings['avatar_action_too_large']) && $modSettings['avatar_action_too_large'] == 'option_css_resize') |
|
3219 | - addInlineCss(' |
|
3406 | + if (!empty($modSettings['avatar_max_width_external']) && !empty($modSettings['avatar_max_height_external']) && !empty($modSettings['avatar_action_too_large']) && $modSettings['avatar_action_too_large'] == 'option_css_resize') { |
|
3407 | + addInlineCss(' |
|
3220 | 3408 | img.avatar { max-width: ' . $modSettings['avatar_max_width_external'] . 'px; max-height: ' . $modSettings['avatar_max_height_external'] . 'px; }'); |
3409 | + } |
|
3221 | 3410 | |
3222 | 3411 | // This looks weird, but it's because BoardIndex.php references the variable. |
3223 | 3412 | $context['common_stats']['latest_member'] = array( |
@@ -3234,11 +3423,13 @@ discard block |
||
3234 | 3423 | ); |
3235 | 3424 | $context['common_stats']['boardindex_total_posts'] = sprintf($txt['boardindex_total_posts'], $context['common_stats']['total_posts'], $context['common_stats']['total_topics'], $context['common_stats']['total_members']); |
3236 | 3425 | |
3237 | - if (empty($settings['theme_version'])) |
|
3238 | - addJavaScriptVar('smf_scripturl', $scripturl); |
|
3426 | + if (empty($settings['theme_version'])) { |
|
3427 | + addJavaScriptVar('smf_scripturl', $scripturl); |
|
3428 | + } |
|
3239 | 3429 | |
3240 | - if (!isset($context['page_title'])) |
|
3241 | - $context['page_title'] = ''; |
|
3430 | + if (!isset($context['page_title'])) { |
|
3431 | + $context['page_title'] = ''; |
|
3432 | + } |
|
3242 | 3433 | |
3243 | 3434 | // Set some specific vars. |
3244 | 3435 | $context['page_title_html_safe'] = $smcFunc['htmlspecialchars'](un_htmlspecialchars($context['page_title'])) . (!empty($context['current_page']) ? ' - ' . $txt['page'] . ' ' . ($context['current_page'] + 1) : ''); |
@@ -3248,21 +3439,23 @@ discard block |
||
3248 | 3439 | $context['meta_tags'][] = array('property' => 'og:site_name', 'content' => $context['forum_name']); |
3249 | 3440 | $context['meta_tags'][] = array('property' => 'og:title', 'content' => $context['page_title_html_safe']); |
3250 | 3441 | |
3251 | - if (!empty($context['meta_keywords'])) |
|
3252 | - $context['meta_tags'][] = array('name' => 'keywords', 'content' => $context['meta_keywords']); |
|
3442 | + if (!empty($context['meta_keywords'])) { |
|
3443 | + $context['meta_tags'][] = array('name' => 'keywords', 'content' => $context['meta_keywords']); |
|
3444 | + } |
|
3253 | 3445 | |
3254 | - if (!empty($context['canonical_url'])) |
|
3255 | - $context['meta_tags'][] = array('property' => 'og:url', 'content' => $context['canonical_url']); |
|
3446 | + if (!empty($context['canonical_url'])) { |
|
3447 | + $context['meta_tags'][] = array('property' => 'og:url', 'content' => $context['canonical_url']); |
|
3448 | + } |
|
3256 | 3449 | |
3257 | - if (!empty($settings['og_image'])) |
|
3258 | - $context['meta_tags'][] = array('property' => 'og:image', 'content' => $settings['og_image']); |
|
3450 | + if (!empty($settings['og_image'])) { |
|
3451 | + $context['meta_tags'][] = array('property' => 'og:image', 'content' => $settings['og_image']); |
|
3452 | + } |
|
3259 | 3453 | |
3260 | 3454 | if (!empty($context['meta_description'])) |
3261 | 3455 | { |
3262 | 3456 | $context['meta_tags'][] = array('property' => 'og:description', 'content' => $context['meta_description']); |
3263 | 3457 | $context['meta_tags'][] = array('name' => 'description', 'content' => $context['meta_description']); |
3264 | - } |
|
3265 | - else |
|
3458 | + } else |
|
3266 | 3459 | { |
3267 | 3460 | $context['meta_tags'][] = array('property' => 'og:description', 'content' => $context['page_title_html_safe']); |
3268 | 3461 | $context['meta_tags'][] = array('name' => 'description', 'content' => $context['page_title_html_safe']); |
@@ -3287,8 +3480,9 @@ discard block |
||
3287 | 3480 | $memory_needed = memoryReturnBytes($needed); |
3288 | 3481 | |
3289 | 3482 | // should we account for how much is currently being used? |
3290 | - if ($in_use) |
|
3291 | - $memory_needed += function_exists('memory_get_usage') ? memory_get_usage() : (2 * 1048576); |
|
3483 | + if ($in_use) { |
|
3484 | + $memory_needed += function_exists('memory_get_usage') ? memory_get_usage() : (2 * 1048576); |
|
3485 | + } |
|
3292 | 3486 | |
3293 | 3487 | // if more is needed, request it |
3294 | 3488 | if ($memory_current < $memory_needed) |
@@ -3311,8 +3505,9 @@ discard block |
||
3311 | 3505 | */ |
3312 | 3506 | function memoryReturnBytes($val) |
3313 | 3507 | { |
3314 | - if (is_integer($val)) |
|
3315 | - return $val; |
|
3508 | + if (is_integer($val)) { |
|
3509 | + return $val; |
|
3510 | + } |
|
3316 | 3511 | |
3317 | 3512 | // Separate the number from the designator |
3318 | 3513 | $val = trim($val); |
@@ -3348,10 +3543,11 @@ discard block |
||
3348 | 3543 | header('Last-Modified: ' . gmdate('D, d M Y H:i:s') . ' GMT'); |
3349 | 3544 | |
3350 | 3545 | // Are we debugging the template/html content? |
3351 | - if (!isset($_REQUEST['xml']) && isset($_GET['debug']) && !isBrowser('ie')) |
|
3352 | - header('Content-Type: application/xhtml+xml'); |
|
3353 | - elseif (!isset($_REQUEST['xml'])) |
|
3354 | - header('Content-Type: text/html; charset=' . (empty($context['character_set']) ? 'ISO-8859-1' : $context['character_set'])); |
|
3546 | + if (!isset($_REQUEST['xml']) && isset($_GET['debug']) && !isBrowser('ie')) { |
|
3547 | + header('Content-Type: application/xhtml+xml'); |
|
3548 | + } elseif (!isset($_REQUEST['xml'])) { |
|
3549 | + header('Content-Type: text/html; charset=' . (empty($context['character_set']) ? 'ISO-8859-1' : $context['character_set'])); |
|
3550 | + } |
|
3355 | 3551 | } |
3356 | 3552 | |
3357 | 3553 | header('Content-Type: text/' . (isset($_REQUEST['xml']) ? 'xml' : 'html') . '; charset=' . (empty($context['character_set']) ? 'ISO-8859-1' : $context['character_set'])); |
@@ -3360,8 +3556,9 @@ discard block |
||
3360 | 3556 | if ($context['in_maintenance'] && $context['user']['is_admin']) |
3361 | 3557 | { |
3362 | 3558 | $position = array_search('body', $context['template_layers']); |
3363 | - if ($position === false) |
|
3364 | - $position = array_search('main', $context['template_layers']); |
|
3559 | + if ($position === false) { |
|
3560 | + $position = array_search('main', $context['template_layers']); |
|
3561 | + } |
|
3365 | 3562 | |
3366 | 3563 | if ($position !== false) |
3367 | 3564 | { |
@@ -3389,23 +3586,25 @@ discard block |
||
3389 | 3586 | |
3390 | 3587 | foreach ($securityFiles as $i => $securityFile) |
3391 | 3588 | { |
3392 | - if (!file_exists($boarddir . '/' . $securityFile)) |
|
3393 | - unset($securityFiles[$i]); |
|
3589 | + if (!file_exists($boarddir . '/' . $securityFile)) { |
|
3590 | + unset($securityFiles[$i]); |
|
3591 | + } |
|
3394 | 3592 | } |
3395 | 3593 | |
3396 | 3594 | // We are already checking so many files...just few more doesn't make any difference! :P |
3397 | - if (!empty($modSettings['currentAttachmentUploadDir'])) |
|
3398 | - $path = $modSettings['attachmentUploadDir'][$modSettings['currentAttachmentUploadDir']]; |
|
3399 | - |
|
3400 | - else |
|
3401 | - $path = $modSettings['attachmentUploadDir']; |
|
3595 | + if (!empty($modSettings['currentAttachmentUploadDir'])) { |
|
3596 | + $path = $modSettings['attachmentUploadDir'][$modSettings['currentAttachmentUploadDir']]; |
|
3597 | + } else { |
|
3598 | + $path = $modSettings['attachmentUploadDir']; |
|
3599 | + } |
|
3402 | 3600 | |
3403 | 3601 | secureDirectory($path, true); |
3404 | 3602 | secureDirectory($cachedir); |
3405 | 3603 | |
3406 | 3604 | // If agreement is enabled, at least the english version shall exists |
3407 | - if ($modSettings['requireAgreement']) |
|
3408 | - $agreement = !file_exists($boarddir . '/agreement.txt'); |
|
3605 | + if ($modSettings['requireAgreement']) { |
|
3606 | + $agreement = !file_exists($boarddir . '/agreement.txt'); |
|
3607 | + } |
|
3409 | 3608 | |
3410 | 3609 | if (!empty($securityFiles) || (!empty($modSettings['cache_enable']) && !is_writable($cachedir)) || !empty($agreement)) |
3411 | 3610 | { |
@@ -3420,18 +3619,21 @@ discard block |
||
3420 | 3619 | echo ' |
3421 | 3620 | ', $txt['not_removed'], '<strong>', $securityFile, '</strong>!<br>'; |
3422 | 3621 | |
3423 | - if ($securityFile == 'Settings.php~' || $securityFile == 'Settings_bak.php~') |
|
3424 | - echo ' |
|
3622 | + if ($securityFile == 'Settings.php~' || $securityFile == 'Settings_bak.php~') { |
|
3623 | + echo ' |
|
3425 | 3624 | ', sprintf($txt['not_removed_extra'], $securityFile, substr($securityFile, 0, -1)), '<br>'; |
3625 | + } |
|
3426 | 3626 | } |
3427 | 3627 | |
3428 | - if (!empty($modSettings['cache_enable']) && !is_writable($cachedir)) |
|
3429 | - echo ' |
|
3628 | + if (!empty($modSettings['cache_enable']) && !is_writable($cachedir)) { |
|
3629 | + echo ' |
|
3430 | 3630 | <strong>', $txt['cache_writable'], '</strong><br>'; |
3631 | + } |
|
3431 | 3632 | |
3432 | - if (!empty($agreement)) |
|
3433 | - echo ' |
|
3633 | + if (!empty($agreement)) { |
|
3634 | + echo ' |
|
3434 | 3635 | <strong>', $txt['agreement_missing'], '</strong><br>'; |
3636 | + } |
|
3435 | 3637 | |
3436 | 3638 | echo ' |
3437 | 3639 | </p> |
@@ -3446,16 +3648,18 @@ discard block |
||
3446 | 3648 | <div class="windowbg alert" style="margin: 2ex; padding: 2ex; border: 2px dashed red;"> |
3447 | 3649 | ', sprintf($txt['you_are_post_banned'], $user_info['is_guest'] ? $txt['guest_title'] : $user_info['name']); |
3448 | 3650 | |
3449 | - if (!empty($_SESSION['ban']['cannot_post']['reason'])) |
|
3450 | - echo ' |
|
3651 | + if (!empty($_SESSION['ban']['cannot_post']['reason'])) { |
|
3652 | + echo ' |
|
3451 | 3653 | <div style="padding-left: 4ex; padding-top: 1ex;">', $_SESSION['ban']['cannot_post']['reason'], '</div>'; |
3654 | + } |
|
3452 | 3655 | |
3453 | - if (!empty($_SESSION['ban']['expire_time'])) |
|
3454 | - echo ' |
|
3656 | + if (!empty($_SESSION['ban']['expire_time'])) { |
|
3657 | + echo ' |
|
3455 | 3658 | <div>', sprintf($txt['your_ban_expires'], timeformat($_SESSION['ban']['expire_time'], false)), '</div>'; |
3456 | - else |
|
3457 | - echo ' |
|
3659 | + } else { |
|
3660 | + echo ' |
|
3458 | 3661 | <div>', $txt['your_ban_expires_never'], '</div>'; |
3662 | + } |
|
3459 | 3663 | |
3460 | 3664 | echo ' |
3461 | 3665 | </div>'; |
@@ -3471,8 +3675,9 @@ discard block |
||
3471 | 3675 | global $forum_copyright, $software_year, $forum_version; |
3472 | 3676 | |
3473 | 3677 | // Don't display copyright for things like SSI. |
3474 | - if (!isset($forum_version) || !isset($software_year)) |
|
3475 | - return; |
|
3678 | + if (!isset($forum_version) || !isset($software_year)) { |
|
3679 | + return; |
|
3680 | + } |
|
3476 | 3681 | |
3477 | 3682 | // Put in the version... |
3478 | 3683 | printf($forum_copyright, $forum_version, $software_year); |
@@ -3490,9 +3695,10 @@ discard block |
||
3490 | 3695 | $context['load_time'] = round(microtime(true) - $time_start, 3); |
3491 | 3696 | $context['load_queries'] = $db_count; |
3492 | 3697 | |
3493 | - foreach (array_reverse($context['template_layers']) as $layer) |
|
3494 | - loadSubTemplate($layer . '_below', true); |
|
3495 | -} |
|
3698 | + foreach (array_reverse($context['template_layers']) as $layer) { |
|
3699 | + loadSubTemplate($layer . '_below', true); |
|
3700 | + } |
|
3701 | + } |
|
3496 | 3702 | |
3497 | 3703 | /** |
3498 | 3704 | * Output the Javascript files |
@@ -3523,8 +3729,7 @@ discard block |
||
3523 | 3729 | { |
3524 | 3730 | echo ' |
3525 | 3731 | var ', $key, ';'; |
3526 | - } |
|
3527 | - else |
|
3732 | + } else |
|
3528 | 3733 | { |
3529 | 3734 | echo ' |
3530 | 3735 | var ', $key, ' = ', $value, ';'; |
@@ -3539,26 +3744,27 @@ discard block |
||
3539 | 3744 | foreach ($context['javascript_files'] as $id => $js_file) |
3540 | 3745 | { |
3541 | 3746 | // Last minute call! allow theme authors to disable single files. |
3542 | - if (!empty($settings['disable_files']) && in_array($id, $settings['disable_files'])) |
|
3543 | - continue; |
|
3747 | + if (!empty($settings['disable_files']) && in_array($id, $settings['disable_files'])) { |
|
3748 | + continue; |
|
3749 | + } |
|
3544 | 3750 | |
3545 | 3751 | // By default all files don't get minimized unless the file explicitly says so! |
3546 | 3752 | if (!empty($js_file['options']['minimize']) && !empty($modSettings['minimize_files'])) |
3547 | 3753 | { |
3548 | - if ($do_deferred && !empty($js_file['options']['defer'])) |
|
3549 | - $toMinifyDefer[] = $js_file; |
|
3550 | - |
|
3551 | - elseif (!$do_deferred && empty($js_file['options']['defer'])) |
|
3552 | - $toMinify[] = $js_file; |
|
3754 | + if ($do_deferred && !empty($js_file['options']['defer'])) { |
|
3755 | + $toMinifyDefer[] = $js_file; |
|
3756 | + } elseif (!$do_deferred && empty($js_file['options']['defer'])) { |
|
3757 | + $toMinify[] = $js_file; |
|
3758 | + } |
|
3553 | 3759 | |
3554 | 3760 | // Grab a random seed. |
3555 | - if (!isset($minSeed)) |
|
3556 | - $minSeed = $js_file['options']['seed']; |
|
3557 | - } |
|
3558 | - |
|
3559 | - elseif ((!$do_deferred && empty($js_file['options']['defer'])) || ($do_deferred && !empty($js_file['options']['defer']))) |
|
3560 | - echo ' |
|
3761 | + if (!isset($minSeed)) { |
|
3762 | + $minSeed = $js_file['options']['seed']; |
|
3763 | + } |
|
3764 | + } elseif ((!$do_deferred && empty($js_file['options']['defer'])) || ($do_deferred && !empty($js_file['options']['defer']))) { |
|
3765 | + echo ' |
|
3561 | 3766 | <script src="', $js_file['fileUrl'], '"', !empty($js_file['options']['async']) ? ' async="async"' : '', '></script>'; |
3767 | + } |
|
3562 | 3768 | } |
3563 | 3769 | |
3564 | 3770 | if ((!$do_deferred && !empty($toMinify)) || ($do_deferred && !empty($toMinifyDefer))) |
@@ -3566,14 +3772,14 @@ discard block |
||
3566 | 3772 | $result = custMinify(($do_deferred ? $toMinifyDefer : $toMinify), 'js', $do_deferred); |
3567 | 3773 | |
3568 | 3774 | // Minify process couldn't work, print each individual files. |
3569 | - if (!empty($result) && is_array($result)) |
|
3570 | - foreach ($result as $minFailedFile) |
|
3775 | + if (!empty($result) && is_array($result)) { |
|
3776 | + foreach ($result as $minFailedFile) |
|
3571 | 3777 | echo ' |
3572 | 3778 | <script src="', $minFailedFile['fileUrl'], '"', !empty($minFailedFile['options']['async']) ? ' async="async"' : '', '></script>'; |
3573 | - |
|
3574 | - else |
|
3575 | - echo ' |
|
3779 | + } else { |
|
3780 | + echo ' |
|
3576 | 3781 | <script src="', $settings['theme_url'] ,'/scripts/minified', ($do_deferred ? '_deferred' : '') ,'.js', $minSeed ,'"></script>'; |
3782 | + } |
|
3577 | 3783 | } |
3578 | 3784 | |
3579 | 3785 | // Inline JavaScript - Actually useful some times! |
@@ -3584,8 +3790,9 @@ discard block |
||
3584 | 3790 | echo ' |
3585 | 3791 | <script>'; |
3586 | 3792 | |
3587 | - foreach ($context['javascript_inline']['defer'] as $js_code) |
|
3588 | - echo $js_code; |
|
3793 | + foreach ($context['javascript_inline']['defer'] as $js_code) { |
|
3794 | + echo $js_code; |
|
3795 | + } |
|
3589 | 3796 | |
3590 | 3797 | echo ' |
3591 | 3798 | </script>'; |
@@ -3596,8 +3803,9 @@ discard block |
||
3596 | 3803 | echo ' |
3597 | 3804 | <script>'; |
3598 | 3805 | |
3599 | - foreach ($context['javascript_inline']['standard'] as $js_code) |
|
3600 | - echo $js_code; |
|
3806 | + foreach ($context['javascript_inline']['standard'] as $js_code) { |
|
3807 | + echo $js_code; |
|
3808 | + } |
|
3601 | 3809 | |
3602 | 3810 | echo ' |
3603 | 3811 | </script>'; |
@@ -3622,8 +3830,9 @@ discard block |
||
3622 | 3830 | foreach ($context['css_files'] as $id => $file) |
3623 | 3831 | { |
3624 | 3832 | // Last minute call! allow theme authors to disable single files. |
3625 | - if (!empty($settings['disable_files']) && in_array($id, $settings['disable_files'])) |
|
3626 | - continue; |
|
3833 | + if (!empty($settings['disable_files']) && in_array($id, $settings['disable_files'])) { |
|
3834 | + continue; |
|
3835 | + } |
|
3627 | 3836 | |
3628 | 3837 | // By default all files don't get minimized unless the file explicitly says so! |
3629 | 3838 | if (!empty($file['options']['minimize']) && !empty($modSettings['minimize_files'])) |
@@ -3631,12 +3840,12 @@ discard block |
||
3631 | 3840 | $toMinify[] = $file; |
3632 | 3841 | |
3633 | 3842 | // Grab a random seed. |
3634 | - if (!isset($minSeed)) |
|
3635 | - $minSeed = $file['options']['seed']; |
|
3843 | + if (!isset($minSeed)) { |
|
3844 | + $minSeed = $file['options']['seed']; |
|
3845 | + } |
|
3846 | + } else { |
|
3847 | + $normal[] = $file['fileUrl']; |
|
3636 | 3848 | } |
3637 | - |
|
3638 | - else |
|
3639 | - $normal[] = $file['fileUrl']; |
|
3640 | 3849 | } |
3641 | 3850 | |
3642 | 3851 | if (!empty($toMinify)) |
@@ -3644,28 +3853,30 @@ discard block |
||
3644 | 3853 | $result = custMinify($toMinify, 'css'); |
3645 | 3854 | |
3646 | 3855 | // Minify process couldn't work, print each individual files. |
3647 | - if (!empty($result) && is_array($result)) |
|
3648 | - foreach ($result as $minFailedFile) |
|
3856 | + if (!empty($result) && is_array($result)) { |
|
3857 | + foreach ($result as $minFailedFile) |
|
3649 | 3858 | echo ' |
3650 | 3859 | <link rel="stylesheet" href="', $minFailedFile['fileUrl'], '">'; |
3651 | - |
|
3652 | - else |
|
3653 | - echo ' |
|
3860 | + } else { |
|
3861 | + echo ' |
|
3654 | 3862 | <link rel="stylesheet" href="', $settings['theme_url'] ,'/css/minified.css', $minSeed ,'">'; |
3863 | + } |
|
3655 | 3864 | } |
3656 | 3865 | |
3657 | 3866 | // Print the rest after the minified files. |
3658 | - if (!empty($normal)) |
|
3659 | - foreach ($normal as $nf) |
|
3867 | + if (!empty($normal)) { |
|
3868 | + foreach ($normal as $nf) |
|
3660 | 3869 | echo ' |
3661 | 3870 | <link rel="stylesheet" href="', $nf ,'">'; |
3871 | + } |
|
3662 | 3872 | |
3663 | 3873 | if ($db_show_debug === true) |
3664 | 3874 | { |
3665 | 3875 | // Try to keep only what's useful. |
3666 | 3876 | $repl = array($boardurl . '/Themes/' => '', $boardurl . '/' => ''); |
3667 | - foreach ($context['css_files'] as $file) |
|
3668 | - $context['debug']['sheets'][] = strtr($file['fileName'], $repl); |
|
3877 | + foreach ($context['css_files'] as $file) { |
|
3878 | + $context['debug']['sheets'][] = strtr($file['fileName'], $repl); |
|
3879 | + } |
|
3669 | 3880 | } |
3670 | 3881 | |
3671 | 3882 | if (!empty($context['css_header'])) |
@@ -3673,9 +3884,10 @@ discard block |
||
3673 | 3884 | echo ' |
3674 | 3885 | <style>'; |
3675 | 3886 | |
3676 | - foreach ($context['css_header'] as $css) |
|
3677 | - echo $css .' |
|
3887 | + foreach ($context['css_header'] as $css) { |
|
3888 | + echo $css .' |
|
3678 | 3889 | '; |
3890 | + } |
|
3679 | 3891 | |
3680 | 3892 | echo' |
3681 | 3893 | </style>'; |
@@ -3699,15 +3911,17 @@ discard block |
||
3699 | 3911 | $type = !empty($type) && in_array($type, $types) ? $type : false; |
3700 | 3912 | $data = !empty($data) ? $data : false; |
3701 | 3913 | |
3702 | - if (empty($type) || empty($data)) |
|
3703 | - return false; |
|
3914 | + if (empty($type) || empty($data)) { |
|
3915 | + return false; |
|
3916 | + } |
|
3704 | 3917 | |
3705 | 3918 | // Did we already did this? |
3706 | 3919 | $toCache = cache_get_data('minimized_'. $settings['theme_id'] .'_'. $type, 86400); |
3707 | 3920 | |
3708 | 3921 | // Already done? |
3709 | - if (!empty($toCache)) |
|
3710 | - return true; |
|
3922 | + if (!empty($toCache)) { |
|
3923 | + return true; |
|
3924 | + } |
|
3711 | 3925 | |
3712 | 3926 | // No namespaces, sorry! |
3713 | 3927 | $classType = 'MatthiasMullie\\Minify\\'. strtoupper($type); |
@@ -3789,8 +4003,9 @@ discard block |
||
3789 | 4003 | global $modSettings, $smcFunc; |
3790 | 4004 | |
3791 | 4005 | // Just make up a nice hash... |
3792 | - if ($new) |
|
3793 | - return sha1(md5($filename . time()) . mt_rand()); |
|
4006 | + if ($new) { |
|
4007 | + return sha1(md5($filename . time()) . mt_rand()); |
|
4008 | + } |
|
3794 | 4009 | |
3795 | 4010 | // Just make sure that attachment id is only a int |
3796 | 4011 | $attachment_id = (int) $attachment_id; |
@@ -3807,23 +4022,25 @@ discard block |
||
3807 | 4022 | 'id_attach' => $attachment_id, |
3808 | 4023 | )); |
3809 | 4024 | |
3810 | - if ($smcFunc['db_num_rows']($request) === 0) |
|
3811 | - return false; |
|
4025 | + if ($smcFunc['db_num_rows']($request) === 0) { |
|
4026 | + return false; |
|
4027 | + } |
|
3812 | 4028 | |
3813 | 4029 | list ($file_hash) = $smcFunc['db_fetch_row']($request); |
3814 | 4030 | $smcFunc['db_free_result']($request); |
3815 | 4031 | } |
3816 | 4032 | |
3817 | 4033 | // Still no hash? mmm... |
3818 | - if (empty($file_hash)) |
|
3819 | - $file_hash = sha1(md5($filename . time()) . mt_rand()); |
|
4034 | + if (empty($file_hash)) { |
|
4035 | + $file_hash = sha1(md5($filename . time()) . mt_rand()); |
|
4036 | + } |
|
3820 | 4037 | |
3821 | 4038 | // Are we using multiple directories? |
3822 | - if (is_array($modSettings['attachmentUploadDir'])) |
|
3823 | - $path = $modSettings['attachmentUploadDir'][$dir]; |
|
3824 | - |
|
3825 | - else |
|
3826 | - $path = $modSettings['attachmentUploadDir']; |
|
4039 | + if (is_array($modSettings['attachmentUploadDir'])) { |
|
4040 | + $path = $modSettings['attachmentUploadDir'][$dir]; |
|
4041 | + } else { |
|
4042 | + $path = $modSettings['attachmentUploadDir']; |
|
4043 | + } |
|
3827 | 4044 | |
3828 | 4045 | return $path . '/' . $attachment_id . '_' . $file_hash .'.dat'; |
3829 | 4046 | } |
@@ -3838,8 +4055,9 @@ discard block |
||
3838 | 4055 | function ip2range($fullip) |
3839 | 4056 | { |
3840 | 4057 | // Pretend that 'unknown' is 255.255.255.255. (since that can't be an IP anyway.) |
3841 | - if ($fullip == 'unknown') |
|
3842 | - $fullip = '255.255.255.255'; |
|
4058 | + if ($fullip == 'unknown') { |
|
4059 | + $fullip = '255.255.255.255'; |
|
4060 | + } |
|
3843 | 4061 | |
3844 | 4062 | $ip_parts = explode('-', $fullip); |
3845 | 4063 | $ip_array = array(); |
@@ -3863,10 +4081,11 @@ discard block |
||
3863 | 4081 | $ip_array['low'] = $ip_parts[0]; |
3864 | 4082 | $ip_array['high'] = $ip_parts[1]; |
3865 | 4083 | return $ip_array; |
3866 | - } |
|
3867 | - elseif (count($ip_parts) == 2) // if ip 22.22.*-22.22.* |
|
4084 | + } elseif (count($ip_parts) == 2) { |
|
4085 | + // if ip 22.22.*-22.22.* |
|
3868 | 4086 | { |
3869 | 4087 | $valid_low = isValidIP($ip_parts[0]); |
4088 | + } |
|
3870 | 4089 | $valid_high = isValidIP($ip_parts[1]); |
3871 | 4090 | $count = 0; |
3872 | 4091 | $mode = (preg_match('/:/',$ip_parts[0]) > 0 ? ':' : '.'); |
@@ -3881,7 +4100,9 @@ discard block |
||
3881 | 4100 | $ip_parts[0] .= $mode . $min; |
3882 | 4101 | $valid_low = isValidIP($ip_parts[0]); |
3883 | 4102 | $count++; |
3884 | - if ($count > 9) break; |
|
4103 | + if ($count > 9) { |
|
4104 | + break; |
|
4105 | + } |
|
3885 | 4106 | } |
3886 | 4107 | } |
3887 | 4108 | |
@@ -3895,7 +4116,9 @@ discard block |
||
3895 | 4116 | $ip_parts[1] .= $mode . $max; |
3896 | 4117 | $valid_high = isValidIP($ip_parts[1]); |
3897 | 4118 | $count++; |
3898 | - if ($count > 9) break; |
|
4119 | + if ($count > 9) { |
|
4120 | + break; |
|
4121 | + } |
|
3899 | 4122 | } |
3900 | 4123 | } |
3901 | 4124 | |
@@ -3920,46 +4143,54 @@ discard block |
||
3920 | 4143 | { |
3921 | 4144 | global $modSettings; |
3922 | 4145 | |
3923 | - if (($host = cache_get_data('hostlookup-' . $ip, 600)) !== null) |
|
3924 | - return $host; |
|
4146 | + if (($host = cache_get_data('hostlookup-' . $ip, 600)) !== null) { |
|
4147 | + return $host; |
|
4148 | + } |
|
3925 | 4149 | $t = microtime(); |
3926 | 4150 | |
3927 | 4151 | // Try the Linux host command, perhaps? |
3928 | 4152 | if (!isset($host) && (strpos(strtolower(PHP_OS), 'win') === false || strpos(strtolower(PHP_OS), 'darwin') !== false) && mt_rand(0, 1) == 1) |
3929 | 4153 | { |
3930 | - if (!isset($modSettings['host_to_dis'])) |
|
3931 | - $test = @shell_exec('host -W 1 ' . @escapeshellarg($ip)); |
|
3932 | - else |
|
3933 | - $test = @shell_exec('host ' . @escapeshellarg($ip)); |
|
4154 | + if (!isset($modSettings['host_to_dis'])) { |
|
4155 | + $test = @shell_exec('host -W 1 ' . @escapeshellarg($ip)); |
|
4156 | + } else { |
|
4157 | + $test = @shell_exec('host ' . @escapeshellarg($ip)); |
|
4158 | + } |
|
3934 | 4159 | |
3935 | 4160 | // Did host say it didn't find anything? |
3936 | - if (strpos($test, 'not found') !== false) |
|
3937 | - $host = ''; |
|
4161 | + if (strpos($test, 'not found') !== false) { |
|
4162 | + $host = ''; |
|
4163 | + } |
|
3938 | 4164 | // Invalid server option? |
3939 | - elseif ((strpos($test, 'invalid option') || strpos($test, 'Invalid query name 1')) && !isset($modSettings['host_to_dis'])) |
|
3940 | - updateSettings(array('host_to_dis' => 1)); |
|
4165 | + elseif ((strpos($test, 'invalid option') || strpos($test, 'Invalid query name 1')) && !isset($modSettings['host_to_dis'])) { |
|
4166 | + updateSettings(array('host_to_dis' => 1)); |
|
4167 | + } |
|
3941 | 4168 | // Maybe it found something, after all? |
3942 | - elseif (preg_match('~\s([^\s]+?)\.\s~', $test, $match) == 1) |
|
3943 | - $host = $match[1]; |
|
4169 | + elseif (preg_match('~\s([^\s]+?)\.\s~', $test, $match) == 1) { |
|
4170 | + $host = $match[1]; |
|
4171 | + } |
|
3944 | 4172 | } |
3945 | 4173 | |
3946 | 4174 | // This is nslookup; usually only Windows, but possibly some Unix? |
3947 | 4175 | if (!isset($host) && stripos(PHP_OS, 'win') !== false && strpos(strtolower(PHP_OS), 'darwin') === false && mt_rand(0, 1) == 1) |
3948 | 4176 | { |
3949 | 4177 | $test = @shell_exec('nslookup -timeout=1 ' . @escapeshellarg($ip)); |
3950 | - if (strpos($test, 'Non-existent domain') !== false) |
|
3951 | - $host = ''; |
|
3952 | - elseif (preg_match('~Name:\s+([^\s]+)~', $test, $match) == 1) |
|
3953 | - $host = $match[1]; |
|
4178 | + if (strpos($test, 'Non-existent domain') !== false) { |
|
4179 | + $host = ''; |
|
4180 | + } elseif (preg_match('~Name:\s+([^\s]+)~', $test, $match) == 1) { |
|
4181 | + $host = $match[1]; |
|
4182 | + } |
|
3954 | 4183 | } |
3955 | 4184 | |
3956 | 4185 | // This is the last try :/. |
3957 | - if (!isset($host) || $host === false) |
|
3958 | - $host = @gethostbyaddr($ip); |
|
4186 | + if (!isset($host) || $host === false) { |
|
4187 | + $host = @gethostbyaddr($ip); |
|
4188 | + } |
|
3959 | 4189 | |
3960 | 4190 | // It took a long time, so let's cache it! |
3961 | - if (array_sum(explode(' ', microtime())) - array_sum(explode(' ', $t)) > 0.5) |
|
3962 | - cache_put_data('hostlookup-' . $ip, $host, 600); |
|
4191 | + if (array_sum(explode(' ', microtime())) - array_sum(explode(' ', $t)) > 0.5) { |
|
4192 | + cache_put_data('hostlookup-' . $ip, $host, 600); |
|
4193 | + } |
|
3963 | 4194 | |
3964 | 4195 | return $host; |
3965 | 4196 | } |
@@ -3995,20 +4226,21 @@ discard block |
||
3995 | 4226 | { |
3996 | 4227 | $encrypted = substr(crypt($word, 'uk'), 2, $max_chars); |
3997 | 4228 | $total = 0; |
3998 | - for ($i = 0; $i < $max_chars; $i++) |
|
3999 | - $total += $possible_chars[ord($encrypted{$i})] * pow(63, $i); |
|
4229 | + for ($i = 0; $i < $max_chars; $i++) { |
|
4230 | + $total += $possible_chars[ord($encrypted{$i})] * pow(63, $i); |
|
4231 | + } |
|
4000 | 4232 | $returned_ints[] = $max_chars == 4 ? min($total, 16777215) : $total; |
4001 | 4233 | } |
4002 | 4234 | } |
4003 | 4235 | return array_unique($returned_ints); |
4004 | - } |
|
4005 | - else |
|
4236 | + } else |
|
4006 | 4237 | { |
4007 | 4238 | // Trim characters before and after and add slashes for database insertion. |
4008 | 4239 | $returned_words = array(); |
4009 | - foreach ($words as $word) |
|
4010 | - if (($word = trim($word, '-_\'')) !== '') |
|
4240 | + foreach ($words as $word) { |
|
4241 | + if (($word = trim($word, '-_\'')) !== '') |
|
4011 | 4242 | $returned_words[] = $max_chars === null ? $word : substr($word, 0, $max_chars); |
4243 | + } |
|
4012 | 4244 | |
4013 | 4245 | // Filter out all words that occur more than once. |
4014 | 4246 | return array_unique($returned_words); |
@@ -4030,16 +4262,18 @@ discard block |
||
4030 | 4262 | global $settings, $txt; |
4031 | 4263 | |
4032 | 4264 | // Does the current loaded theme have this and we are not forcing the usage of this function? |
4033 | - if (function_exists('template_create_button') && !$force_use) |
|
4034 | - return template_create_button($name, $alt, $label = '', $custom = ''); |
|
4265 | + if (function_exists('template_create_button') && !$force_use) { |
|
4266 | + return template_create_button($name, $alt, $label = '', $custom = ''); |
|
4267 | + } |
|
4035 | 4268 | |
4036 | - if (!$settings['use_image_buttons']) |
|
4037 | - return $txt[$alt]; |
|
4038 | - elseif (!empty($settings['use_buttons'])) |
|
4039 | - return '<span class="generic_icons ' . $name . '" alt="' . $txt[$alt] . '"></span>' . ($label != '' ? ' <strong>' . $txt[$label] . '</strong>' : ''); |
|
4040 | - else |
|
4041 | - return '<img src="' . $settings['lang_images_url'] . '/' . $name . '" alt="' . $txt[$alt] . '" ' . $custom . '>'; |
|
4042 | -} |
|
4269 | + if (!$settings['use_image_buttons']) { |
|
4270 | + return $txt[$alt]; |
|
4271 | + } elseif (!empty($settings['use_buttons'])) { |
|
4272 | + return '<span class="generic_icons ' . $name . '" alt="' . $txt[$alt] . '"></span>' . ($label != '' ? ' <strong>' . $txt[$label] . '</strong>' : ''); |
|
4273 | + } else { |
|
4274 | + return '<img src="' . $settings['lang_images_url'] . '/' . $name . '" alt="' . $txt[$alt] . '" ' . $custom . '>'; |
|
4275 | + } |
|
4276 | + } |
|
4043 | 4277 | |
4044 | 4278 | /** |
4045 | 4279 | * Sets up all of the top menu buttons |
@@ -4082,9 +4316,10 @@ discard block |
||
4082 | 4316 | var user_menus = new smc_PopupMenu(); |
4083 | 4317 | user_menus.add("profile", "' . $scripturl . '?action=profile;area=popup"); |
4084 | 4318 | user_menus.add("alerts", "' . $scripturl . '?action=profile;area=alerts_popup;u='. $context['user']['id'] .'");', true); |
4085 | - if ($context['allow_pm']) |
|
4086 | - addInlineJavaScript(' |
|
4319 | + if ($context['allow_pm']) { |
|
4320 | + addInlineJavaScript(' |
|
4087 | 4321 | user_menus.add("pm", "' . $scripturl . '?action=pm;sa=popup");', true); |
4322 | + } |
|
4088 | 4323 | |
4089 | 4324 | if (!empty($modSettings['enable_ajax_alerts'])) |
4090 | 4325 | { |
@@ -4244,88 +4479,96 @@ discard block |
||
4244 | 4479 | |
4245 | 4480 | // Now we put the buttons in the context so the theme can use them. |
4246 | 4481 | $menu_buttons = array(); |
4247 | - foreach ($buttons as $act => $button) |
|
4248 | - if (!empty($button['show'])) |
|
4482 | + foreach ($buttons as $act => $button) { |
|
4483 | + if (!empty($button['show'])) |
|
4249 | 4484 | { |
4250 | 4485 | $button['active_button'] = false; |
4486 | + } |
|
4251 | 4487 | |
4252 | 4488 | // This button needs some action. |
4253 | - if (isset($button['action_hook'])) |
|
4254 | - $needs_action_hook = true; |
|
4489 | + if (isset($button['action_hook'])) { |
|
4490 | + $needs_action_hook = true; |
|
4491 | + } |
|
4255 | 4492 | |
4256 | 4493 | // Make sure the last button truly is the last button. |
4257 | 4494 | if (!empty($button['is_last'])) |
4258 | 4495 | { |
4259 | - if (isset($last_button)) |
|
4260 | - unset($menu_buttons[$last_button]['is_last']); |
|
4496 | + if (isset($last_button)) { |
|
4497 | + unset($menu_buttons[$last_button]['is_last']); |
|
4498 | + } |
|
4261 | 4499 | $last_button = $act; |
4262 | 4500 | } |
4263 | 4501 | |
4264 | 4502 | // Go through the sub buttons if there are any. |
4265 | - if (!empty($button['sub_buttons'])) |
|
4266 | - foreach ($button['sub_buttons'] as $key => $subbutton) |
|
4503 | + if (!empty($button['sub_buttons'])) { |
|
4504 | + foreach ($button['sub_buttons'] as $key => $subbutton) |
|
4267 | 4505 | { |
4268 | 4506 | if (empty($subbutton['show'])) |
4269 | 4507 | unset($button['sub_buttons'][$key]); |
4508 | + } |
|
4270 | 4509 | |
4271 | 4510 | // 2nd level sub buttons next... |
4272 | 4511 | if (!empty($subbutton['sub_buttons'])) |
4273 | 4512 | { |
4274 | 4513 | foreach ($subbutton['sub_buttons'] as $key2 => $sub_button2) |
4275 | 4514 | { |
4276 | - if (empty($sub_button2['show'])) |
|
4277 | - unset($button['sub_buttons'][$key]['sub_buttons'][$key2]); |
|
4515 | + if (empty($sub_button2['show'])) { |
|
4516 | + unset($button['sub_buttons'][$key]['sub_buttons'][$key2]); |
|
4517 | + } |
|
4278 | 4518 | } |
4279 | 4519 | } |
4280 | 4520 | } |
4281 | 4521 | |
4282 | 4522 | // Does this button have its own icon? |
4283 | - if (isset($button['icon']) && file_exists($settings['theme_dir'] . '/images/' . $button['icon'])) |
|
4284 | - $button['icon'] = '<img src="' . $settings['images_url'] . '/' . $button['icon'] . '" alt="">'; |
|
4285 | - elseif (isset($button['icon']) && file_exists($settings['default_theme_dir'] . '/images/' . $button['icon'])) |
|
4286 | - $button['icon'] = '<img src="' . $settings['default_images_url'] . '/' . $button['icon'] . '" alt="">'; |
|
4287 | - elseif (isset($button['icon'])) |
|
4288 | - $button['icon'] = '<span class="generic_icons ' . $button['icon'] . '"></span>'; |
|
4289 | - else |
|
4290 | - $button['icon'] = '<span class="generic_icons ' . $act . '"></span>'; |
|
4523 | + if (isset($button['icon']) && file_exists($settings['theme_dir'] . '/images/' . $button['icon'])) { |
|
4524 | + $button['icon'] = '<img src="' . $settings['images_url'] . '/' . $button['icon'] . '" alt="">'; |
|
4525 | + } elseif (isset($button['icon']) && file_exists($settings['default_theme_dir'] . '/images/' . $button['icon'])) { |
|
4526 | + $button['icon'] = '<img src="' . $settings['default_images_url'] . '/' . $button['icon'] . '" alt="">'; |
|
4527 | + } elseif (isset($button['icon'])) { |
|
4528 | + $button['icon'] = '<span class="generic_icons ' . $button['icon'] . '"></span>'; |
|
4529 | + } else { |
|
4530 | + $button['icon'] = '<span class="generic_icons ' . $act . '"></span>'; |
|
4531 | + } |
|
4291 | 4532 | |
4292 | 4533 | $menu_buttons[$act] = $button; |
4293 | 4534 | } |
4294 | 4535 | |
4295 | - if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 2) |
|
4296 | - cache_put_data('menu_buttons-' . implode('_', $user_info['groups']) . '-' . $user_info['language'], $menu_buttons, $cacheTime); |
|
4536 | + if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 2) { |
|
4537 | + cache_put_data('menu_buttons-' . implode('_', $user_info['groups']) . '-' . $user_info['language'], $menu_buttons, $cacheTime); |
|
4538 | + } |
|
4297 | 4539 | } |
4298 | 4540 | |
4299 | 4541 | $context['menu_buttons'] = $menu_buttons; |
4300 | 4542 | |
4301 | 4543 | // Logging out requires the session id in the url. |
4302 | - if (isset($context['menu_buttons']['logout'])) |
|
4303 | - $context['menu_buttons']['logout']['href'] = sprintf($context['menu_buttons']['logout']['href'], $context['session_var'], $context['session_id']); |
|
4544 | + if (isset($context['menu_buttons']['logout'])) { |
|
4545 | + $context['menu_buttons']['logout']['href'] = sprintf($context['menu_buttons']['logout']['href'], $context['session_var'], $context['session_id']); |
|
4546 | + } |
|
4304 | 4547 | |
4305 | 4548 | // Figure out which action we are doing so we can set the active tab. |
4306 | 4549 | // Default to home. |
4307 | 4550 | $current_action = 'home'; |
4308 | 4551 | |
4309 | - if (isset($context['menu_buttons'][$context['current_action']])) |
|
4310 | - $current_action = $context['current_action']; |
|
4311 | - elseif ($context['current_action'] == 'search2') |
|
4312 | - $current_action = 'search'; |
|
4313 | - elseif ($context['current_action'] == 'theme') |
|
4314 | - $current_action = isset($_REQUEST['sa']) && $_REQUEST['sa'] == 'pick' ? 'profile' : 'admin'; |
|
4315 | - elseif ($context['current_action'] == 'register2') |
|
4316 | - $current_action = 'register'; |
|
4317 | - elseif ($context['current_action'] == 'login2' || ($user_info['is_guest'] && $context['current_action'] == 'reminder')) |
|
4318 | - $current_action = 'login'; |
|
4319 | - elseif ($context['current_action'] == 'groups' && $context['allow_moderation_center']) |
|
4320 | - $current_action = 'moderate'; |
|
4552 | + if (isset($context['menu_buttons'][$context['current_action']])) { |
|
4553 | + $current_action = $context['current_action']; |
|
4554 | + } elseif ($context['current_action'] == 'search2') { |
|
4555 | + $current_action = 'search'; |
|
4556 | + } elseif ($context['current_action'] == 'theme') { |
|
4557 | + $current_action = isset($_REQUEST['sa']) && $_REQUEST['sa'] == 'pick' ? 'profile' : 'admin'; |
|
4558 | + } elseif ($context['current_action'] == 'register2') { |
|
4559 | + $current_action = 'register'; |
|
4560 | + } elseif ($context['current_action'] == 'login2' || ($user_info['is_guest'] && $context['current_action'] == 'reminder')) { |
|
4561 | + $current_action = 'login'; |
|
4562 | + } elseif ($context['current_action'] == 'groups' && $context['allow_moderation_center']) { |
|
4563 | + $current_action = 'moderate'; |
|
4564 | + } |
|
4321 | 4565 | |
4322 | 4566 | // There are certain exceptions to the above where we don't want anything on the menu highlighted. |
4323 | 4567 | if ($context['current_action'] == 'profile' && !empty($context['user']['is_owner'])) |
4324 | 4568 | { |
4325 | 4569 | $current_action = !empty($_GET['area']) && $_GET['area'] == 'showalerts' ? 'self_alerts' : 'self_profile'; |
4326 | 4570 | $context[$current_action] = true; |
4327 | - } |
|
4328 | - elseif ($context['current_action'] == 'pm') |
|
4571 | + } elseif ($context['current_action'] == 'pm') |
|
4329 | 4572 | { |
4330 | 4573 | $current_action = 'self_pm'; |
4331 | 4574 | $context['self_pm'] = true; |
@@ -4366,12 +4609,14 @@ discard block |
||
4366 | 4609 | } |
4367 | 4610 | |
4368 | 4611 | // Not all actions are simple. |
4369 | - if (!empty($needs_action_hook)) |
|
4370 | - call_integration_hook('integrate_current_action', array(&$current_action)); |
|
4612 | + if (!empty($needs_action_hook)) { |
|
4613 | + call_integration_hook('integrate_current_action', array(&$current_action)); |
|
4614 | + } |
|
4371 | 4615 | |
4372 | - if (isset($context['menu_buttons'][$current_action])) |
|
4373 | - $context['menu_buttons'][$current_action]['active_button'] = true; |
|
4374 | -} |
|
4616 | + if (isset($context['menu_buttons'][$current_action])) { |
|
4617 | + $context['menu_buttons'][$current_action]['active_button'] = true; |
|
4618 | + } |
|
4619 | + } |
|
4375 | 4620 | |
4376 | 4621 | /** |
4377 | 4622 | * Generate a random seed and ensure it's stored in settings. |
@@ -4395,30 +4640,35 @@ discard block |
||
4395 | 4640 | global $modSettings, $settings, $boarddir, $sourcedir, $db_show_debug; |
4396 | 4641 | global $context, $txt; |
4397 | 4642 | |
4398 | - if ($db_show_debug === true) |
|
4399 | - $context['debug']['hooks'][] = $hook; |
|
4643 | + if ($db_show_debug === true) { |
|
4644 | + $context['debug']['hooks'][] = $hook; |
|
4645 | + } |
|
4400 | 4646 | |
4401 | 4647 | // Need to have some control. |
4402 | - if (!isset($context['instances'])) |
|
4403 | - $context['instances'] = array(); |
|
4648 | + if (!isset($context['instances'])) { |
|
4649 | + $context['instances'] = array(); |
|
4650 | + } |
|
4404 | 4651 | |
4405 | 4652 | $results = array(); |
4406 | - if (empty($modSettings[$hook])) |
|
4407 | - return $results; |
|
4653 | + if (empty($modSettings[$hook])) { |
|
4654 | + return $results; |
|
4655 | + } |
|
4408 | 4656 | |
4409 | 4657 | $functions = explode(',', $modSettings[$hook]); |
4410 | 4658 | // Loop through each function. |
4411 | 4659 | foreach ($functions as $function) |
4412 | 4660 | { |
4413 | 4661 | // Hook has been marked as "disabled". Skip it! |
4414 | - if (strpos($function, '!') !== false) |
|
4415 | - continue; |
|
4662 | + if (strpos($function, '!') !== false) { |
|
4663 | + continue; |
|
4664 | + } |
|
4416 | 4665 | |
4417 | 4666 | $call = call_helper($function, true); |
4418 | 4667 | |
4419 | 4668 | // Is it valid? |
4420 | - if (!empty($call)) |
|
4421 | - $results[$function] = call_user_func_array($call, $parameters); |
|
4669 | + if (!empty($call)) { |
|
4670 | + $results[$function] = call_user_func_array($call, $parameters); |
|
4671 | + } |
|
4422 | 4672 | |
4423 | 4673 | // Whatever it was suppose to call, it failed :( |
4424 | 4674 | elseif (!empty($function)) |
@@ -4434,8 +4684,9 @@ discard block |
||
4434 | 4684 | } |
4435 | 4685 | |
4436 | 4686 | // "Assume" the file resides on $boarddir somewhere... |
4437 | - else |
|
4438 | - log_error(sprintf($txt['hook_fail_call_to'], $function, $boarddir), 'general'); |
|
4687 | + else { |
|
4688 | + log_error(sprintf($txt['hook_fail_call_to'], $function, $boarddir), 'general'); |
|
4689 | + } |
|
4439 | 4690 | } |
4440 | 4691 | } |
4441 | 4692 | |
@@ -4457,12 +4708,14 @@ discard block |
||
4457 | 4708 | global $smcFunc, $modSettings; |
4458 | 4709 | |
4459 | 4710 | // Any objects? |
4460 | - if ($object) |
|
4461 | - $function = $function . '#'; |
|
4711 | + if ($object) { |
|
4712 | + $function = $function . '#'; |
|
4713 | + } |
|
4462 | 4714 | |
4463 | 4715 | // Any files to load? |
4464 | - if (!empty($file) && is_string($file)) |
|
4465 | - $function = $file . (!empty($function) ? '|' . $function : ''); |
|
4716 | + if (!empty($file) && is_string($file)) { |
|
4717 | + $function = $file . (!empty($function) ? '|' . $function : ''); |
|
4718 | + } |
|
4466 | 4719 | |
4467 | 4720 | // Get the correct string. |
4468 | 4721 | $integration_call = $function; |
@@ -4484,13 +4737,14 @@ discard block |
||
4484 | 4737 | if (!empty($current_functions)) |
4485 | 4738 | { |
4486 | 4739 | $current_functions = explode(',', $current_functions); |
4487 | - if (in_array($integration_call, $current_functions)) |
|
4488 | - return; |
|
4740 | + if (in_array($integration_call, $current_functions)) { |
|
4741 | + return; |
|
4742 | + } |
|
4489 | 4743 | |
4490 | 4744 | $permanent_functions = array_merge($current_functions, array($integration_call)); |
4745 | + } else { |
|
4746 | + $permanent_functions = array($integration_call); |
|
4491 | 4747 | } |
4492 | - else |
|
4493 | - $permanent_functions = array($integration_call); |
|
4494 | 4748 | |
4495 | 4749 | updateSettings(array($hook => implode(',', $permanent_functions))); |
4496 | 4750 | } |
@@ -4499,8 +4753,9 @@ discard block |
||
4499 | 4753 | $functions = empty($modSettings[$hook]) ? array() : explode(',', $modSettings[$hook]); |
4500 | 4754 | |
4501 | 4755 | // Do nothing, if it's already there. |
4502 | - if (in_array($integration_call, $functions)) |
|
4503 | - return; |
|
4756 | + if (in_array($integration_call, $functions)) { |
|
4757 | + return; |
|
4758 | + } |
|
4504 | 4759 | |
4505 | 4760 | $functions[] = $integration_call; |
4506 | 4761 | $modSettings[$hook] = implode(',', $functions); |
@@ -4523,12 +4778,14 @@ discard block |
||
4523 | 4778 | global $smcFunc, $modSettings; |
4524 | 4779 | |
4525 | 4780 | // Any objects? |
4526 | - if ($object) |
|
4527 | - $function = $function . '#'; |
|
4781 | + if ($object) { |
|
4782 | + $function = $function . '#'; |
|
4783 | + } |
|
4528 | 4784 | |
4529 | 4785 | // Any files to load? |
4530 | - if (!empty($file) && is_string($file)) |
|
4531 | - $function = $file . '|' . $function; |
|
4786 | + if (!empty($file) && is_string($file)) { |
|
4787 | + $function = $file . '|' . $function; |
|
4788 | + } |
|
4532 | 4789 | |
4533 | 4790 | // Get the correct string. |
4534 | 4791 | $integration_call = $function; |
@@ -4549,16 +4806,18 @@ discard block |
||
4549 | 4806 | { |
4550 | 4807 | $current_functions = explode(',', $current_functions); |
4551 | 4808 | |
4552 | - if (in_array($integration_call, $current_functions)) |
|
4553 | - updateSettings(array($hook => implode(',', array_diff($current_functions, array($integration_call))))); |
|
4809 | + if (in_array($integration_call, $current_functions)) { |
|
4810 | + updateSettings(array($hook => implode(',', array_diff($current_functions, array($integration_call))))); |
|
4811 | + } |
|
4554 | 4812 | } |
4555 | 4813 | |
4556 | 4814 | // Turn the function list into something usable. |
4557 | 4815 | $functions = empty($modSettings[$hook]) ? array() : explode(',', $modSettings[$hook]); |
4558 | 4816 | |
4559 | 4817 | // You can only remove it if it's available. |
4560 | - if (!in_array($integration_call, $functions)) |
|
4561 | - return; |
|
4818 | + if (!in_array($integration_call, $functions)) { |
|
4819 | + return; |
|
4820 | + } |
|
4562 | 4821 | |
4563 | 4822 | $functions = array_diff($functions, array($integration_call)); |
4564 | 4823 | $modSettings[$hook] = implode(',', $functions); |
@@ -4579,17 +4838,20 @@ discard block |
||
4579 | 4838 | global $context, $smcFunc, $txt, $db_show_debug; |
4580 | 4839 | |
4581 | 4840 | // Really? |
4582 | - if (empty($string)) |
|
4583 | - return false; |
|
4841 | + if (empty($string)) { |
|
4842 | + return false; |
|
4843 | + } |
|
4584 | 4844 | |
4585 | 4845 | // An array? should be a "callable" array IE array(object/class, valid_callable). |
4586 | 4846 | // A closure? should be a callable one. |
4587 | - if (is_array($string) || $string instanceof Closure) |
|
4588 | - return $return ? $string : (is_callable($string) ? call_user_func($string) : false); |
|
4847 | + if (is_array($string) || $string instanceof Closure) { |
|
4848 | + return $return ? $string : (is_callable($string) ? call_user_func($string) : false); |
|
4849 | + } |
|
4589 | 4850 | |
4590 | 4851 | // No full objects, sorry! pass a method or a property instead! |
4591 | - if (is_object($string)) |
|
4592 | - return false; |
|
4852 | + if (is_object($string)) { |
|
4853 | + return false; |
|
4854 | + } |
|
4593 | 4855 | |
4594 | 4856 | // Stay vitaminized my friends... |
4595 | 4857 | $string = $smcFunc['htmlspecialchars']($smcFunc['htmltrim']($string)); |
@@ -4598,8 +4860,9 @@ discard block |
||
4598 | 4860 | $string = load_file($string); |
4599 | 4861 | |
4600 | 4862 | // Loaded file failed |
4601 | - if (empty($string)) |
|
4602 | - return false; |
|
4863 | + if (empty($string)) { |
|
4864 | + return false; |
|
4865 | + } |
|
4603 | 4866 | |
4604 | 4867 | // Found a method. |
4605 | 4868 | if (strpos($string, '::') !== false) |
@@ -4620,8 +4883,9 @@ discard block |
||
4620 | 4883 | // Add another one to the list. |
4621 | 4884 | if ($db_show_debug === true) |
4622 | 4885 | { |
4623 | - if (!isset($context['debug']['instances'])) |
|
4624 | - $context['debug']['instances'] = array(); |
|
4886 | + if (!isset($context['debug']['instances'])) { |
|
4887 | + $context['debug']['instances'] = array(); |
|
4888 | + } |
|
4625 | 4889 | |
4626 | 4890 | $context['debug']['instances'][$class] = $class; |
4627 | 4891 | } |
@@ -4631,13 +4895,15 @@ discard block |
||
4631 | 4895 | } |
4632 | 4896 | |
4633 | 4897 | // Right then. This is a call to a static method. |
4634 | - else |
|
4635 | - $func = array($class, $method); |
|
4898 | + else { |
|
4899 | + $func = array($class, $method); |
|
4900 | + } |
|
4636 | 4901 | } |
4637 | 4902 | |
4638 | 4903 | // Nope! just a plain regular function. |
4639 | - else |
|
4640 | - $func = $string; |
|
4904 | + else { |
|
4905 | + $func = $string; |
|
4906 | + } |
|
4641 | 4907 | |
4642 | 4908 | // Right, we got what we need, time to do some checks. |
4643 | 4909 | if (!is_callable($func, false, $callable_name)) |
@@ -4653,17 +4919,18 @@ discard block |
||
4653 | 4919 | else |
4654 | 4920 | { |
4655 | 4921 | // What are we gonna do about it? |
4656 | - if ($return) |
|
4657 | - return $func; |
|
4922 | + if ($return) { |
|
4923 | + return $func; |
|
4924 | + } |
|
4658 | 4925 | |
4659 | 4926 | // If this is a plain function, avoid the heat of calling call_user_func(). |
4660 | 4927 | else |
4661 | 4928 | { |
4662 | - if (is_array($func)) |
|
4663 | - call_user_func($func); |
|
4664 | - |
|
4665 | - else |
|
4666 | - $func(); |
|
4929 | + if (is_array($func)) { |
|
4930 | + call_user_func($func); |
|
4931 | + } else { |
|
4932 | + $func(); |
|
4933 | + } |
|
4667 | 4934 | } |
4668 | 4935 | } |
4669 | 4936 | } |
@@ -4680,31 +4947,34 @@ discard block |
||
4680 | 4947 | { |
4681 | 4948 | global $sourcedir, $txt, $boarddir, $settings; |
4682 | 4949 | |
4683 | - if (empty($string)) |
|
4684 | - return false; |
|
4950 | + if (empty($string)) { |
|
4951 | + return false; |
|
4952 | + } |
|
4685 | 4953 | |
4686 | 4954 | if (strpos($string, '|') !== false) |
4687 | 4955 | { |
4688 | 4956 | list ($file, $string) = explode('|', $string); |
4689 | 4957 | |
4690 | 4958 | // Match the wildcards to their regular vars. |
4691 | - if (empty($settings['theme_dir'])) |
|
4692 | - $absPath = strtr(trim($file), array('$boarddir' => $boarddir, '$sourcedir' => $sourcedir)); |
|
4693 | - |
|
4694 | - else |
|
4695 | - $absPath = strtr(trim($file), array('$boarddir' => $boarddir, '$sourcedir' => $sourcedir, '$themedir' => $settings['theme_dir'])); |
|
4959 | + if (empty($settings['theme_dir'])) { |
|
4960 | + $absPath = strtr(trim($file), array('$boarddir' => $boarddir, '$sourcedir' => $sourcedir)); |
|
4961 | + } else { |
|
4962 | + $absPath = strtr(trim($file), array('$boarddir' => $boarddir, '$sourcedir' => $sourcedir, '$themedir' => $settings['theme_dir'])); |
|
4963 | + } |
|
4696 | 4964 | |
4697 | 4965 | // Load the file if it can be loaded. |
4698 | - if (file_exists($absPath)) |
|
4699 | - require_once($absPath); |
|
4966 | + if (file_exists($absPath)) { |
|
4967 | + require_once($absPath); |
|
4968 | + } |
|
4700 | 4969 | |
4701 | 4970 | // No? try a fallback to $sourcedir |
4702 | 4971 | else |
4703 | 4972 | { |
4704 | 4973 | $absPath = $sourcedir .'/'. $file; |
4705 | 4974 | |
4706 | - if (file_exists($absPath)) |
|
4707 | - require_once($absPath); |
|
4975 | + if (file_exists($absPath)) { |
|
4976 | + require_once($absPath); |
|
4977 | + } |
|
4708 | 4978 | |
4709 | 4979 | // Sorry, can't do much for you at this point. |
4710 | 4980 | else |
@@ -4731,8 +5001,9 @@ discard block |
||
4731 | 5001 | global $user_info, $smcFunc; |
4732 | 5002 | |
4733 | 5003 | // Make sure we have something to work with. |
4734 | - if (empty($topic)) |
|
4735 | - return array(); |
|
5004 | + if (empty($topic)) { |
|
5005 | + return array(); |
|
5006 | + } |
|
4736 | 5007 | |
4737 | 5008 | |
4738 | 5009 | // We already know the number of likes per message, we just want to know whether the current user liked it or not. |
@@ -4755,8 +5026,9 @@ discard block |
||
4755 | 5026 | 'topic' => $topic, |
4756 | 5027 | ) |
4757 | 5028 | ); |
4758 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
4759 | - $temp[] = (int) $row['content_id']; |
|
5029 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
5030 | + $temp[] = (int) $row['content_id']; |
|
5031 | + } |
|
4760 | 5032 | |
4761 | 5033 | cache_put_data($cache_key, $temp, $ttl); |
4762 | 5034 | } |
@@ -4777,8 +5049,9 @@ discard block |
||
4777 | 5049 | { |
4778 | 5050 | global $context; |
4779 | 5051 | |
4780 | - if (empty($string)) |
|
4781 | - return $string; |
|
5052 | + if (empty($string)) { |
|
5053 | + return $string; |
|
5054 | + } |
|
4782 | 5055 | |
4783 | 5056 | // UTF-8 occurences of MS special characters |
4784 | 5057 | $findchars_utf8 = array( |
@@ -4819,10 +5092,11 @@ discard block |
||
4819 | 5092 | '--', // — |
4820 | 5093 | ); |
4821 | 5094 | |
4822 | - if ($context['utf8']) |
|
4823 | - $string = str_replace($findchars_utf8, $replacechars, $string); |
|
4824 | - else |
|
4825 | - $string = str_replace($findchars_iso, $replacechars, $string); |
|
5095 | + if ($context['utf8']) { |
|
5096 | + $string = str_replace($findchars_utf8, $replacechars, $string); |
|
5097 | + } else { |
|
5098 | + $string = str_replace($findchars_iso, $replacechars, $string); |
|
5099 | + } |
|
4826 | 5100 | |
4827 | 5101 | return $string; |
4828 | 5102 | } |
@@ -4841,49 +5115,59 @@ discard block |
||
4841 | 5115 | { |
4842 | 5116 | global $context; |
4843 | 5117 | |
4844 | - if (!isset($matches[2])) |
|
4845 | - return ''; |
|
5118 | + if (!isset($matches[2])) { |
|
5119 | + return ''; |
|
5120 | + } |
|
4846 | 5121 | |
4847 | 5122 | $num = $matches[2][0] === 'x' ? hexdec(substr($matches[2], 1)) : (int) $matches[2]; |
4848 | 5123 | |
4849 | 5124 | // remove left to right / right to left overrides |
4850 | - if ($num === 0x202D || $num === 0x202E) |
|
4851 | - return ''; |
|
5125 | + if ($num === 0x202D || $num === 0x202E) { |
|
5126 | + return ''; |
|
5127 | + } |
|
4852 | 5128 | |
4853 | 5129 | // Quote, Ampersand, Apostrophe, Less/Greater Than get html replaced |
4854 | - if (in_array($num, array(0x22, 0x26, 0x27, 0x3C, 0x3E))) |
|
4855 | - return '&#' . $num . ';'; |
|
5130 | + if (in_array($num, array(0x22, 0x26, 0x27, 0x3C, 0x3E))) { |
|
5131 | + return '&#' . $num . ';'; |
|
5132 | + } |
|
4856 | 5133 | |
4857 | 5134 | if (empty($context['utf8'])) |
4858 | 5135 | { |
4859 | 5136 | // no control characters |
4860 | - if ($num < 0x20) |
|
4861 | - return ''; |
|
5137 | + if ($num < 0x20) { |
|
5138 | + return ''; |
|
5139 | + } |
|
4862 | 5140 | // text is text |
4863 | - elseif ($num < 0x80) |
|
4864 | - return chr($num); |
|
5141 | + elseif ($num < 0x80) { |
|
5142 | + return chr($num); |
|
5143 | + } |
|
4865 | 5144 | // all others get html-ised |
4866 | - else |
|
4867 | - return '&#' . $matches[2] . ';'; |
|
4868 | - } |
|
4869 | - else |
|
5145 | + else { |
|
5146 | + return '&#' . $matches[2] . ';'; |
|
5147 | + } |
|
5148 | + } else |
|
4870 | 5149 | { |
4871 | 5150 | // <0x20 are control characters, 0x20 is a space, > 0x10FFFF is past the end of the utf8 character set |
4872 | 5151 | // 0xD800 >= $num <= 0xDFFF are surrogate markers (not valid for utf8 text) |
4873 | - if ($num < 0x20 || $num > 0x10FFFF || ($num >= 0xD800 && $num <= 0xDFFF)) |
|
4874 | - return ''; |
|
5152 | + if ($num < 0x20 || $num > 0x10FFFF || ($num >= 0xD800 && $num <= 0xDFFF)) { |
|
5153 | + return ''; |
|
5154 | + } |
|
4875 | 5155 | // <0x80 (or less than 128) are standard ascii characters a-z A-Z 0-9 and punctuation |
4876 | - elseif ($num < 0x80) |
|
4877 | - return chr($num); |
|
5156 | + elseif ($num < 0x80) { |
|
5157 | + return chr($num); |
|
5158 | + } |
|
4878 | 5159 | // <0x800 (2048) |
4879 | - elseif ($num < 0x800) |
|
4880 | - return chr(($num >> 6) + 192) . chr(($num & 63) + 128); |
|
5160 | + elseif ($num < 0x800) { |
|
5161 | + return chr(($num >> 6) + 192) . chr(($num & 63) + 128); |
|
5162 | + } |
|
4881 | 5163 | // < 0x10000 (65536) |
4882 | - elseif ($num < 0x10000) |
|
4883 | - return chr(($num >> 12) + 224) . chr((($num >> 6) & 63) + 128) . chr(($num & 63) + 128); |
|
5164 | + elseif ($num < 0x10000) { |
|
5165 | + return chr(($num >> 12) + 224) . chr((($num >> 6) & 63) + 128) . chr(($num & 63) + 128); |
|
5166 | + } |
|
4884 | 5167 | // <= 0x10FFFF (1114111) |
4885 | - else |
|
4886 | - return chr(($num >> 18) + 240) . chr((($num >> 12) & 63) + 128) . chr((($num >> 6) & 63) + 128) . chr(($num & 63) + 128); |
|
5168 | + else { |
|
5169 | + return chr(($num >> 18) + 240) . chr((($num >> 12) & 63) + 128) . chr((($num >> 6) & 63) + 128) . chr(($num & 63) + 128); |
|
5170 | + } |
|
4887 | 5171 | } |
4888 | 5172 | } |
4889 | 5173 | |
@@ -4899,28 +5183,34 @@ discard block |
||
4899 | 5183 | */ |
4900 | 5184 | function fixchar__callback($matches) |
4901 | 5185 | { |
4902 | - if (!isset($matches[1])) |
|
4903 | - return ''; |
|
5186 | + if (!isset($matches[1])) { |
|
5187 | + return ''; |
|
5188 | + } |
|
4904 | 5189 | |
4905 | 5190 | $num = $matches[1][0] === 'x' ? hexdec(substr($matches[1], 1)) : (int) $matches[1]; |
4906 | 5191 | |
4907 | 5192 | // <0x20 are control characters, > 0x10FFFF is past the end of the utf8 character set |
4908 | 5193 | // 0xD800 >= $num <= 0xDFFF are surrogate markers (not valid for utf8 text), 0x202D-E are left to right overrides |
4909 | - if ($num < 0x20 || $num > 0x10FFFF || ($num >= 0xD800 && $num <= 0xDFFF) || $num === 0x202D || $num === 0x202E) |
|
4910 | - return ''; |
|
5194 | + if ($num < 0x20 || $num > 0x10FFFF || ($num >= 0xD800 && $num <= 0xDFFF) || $num === 0x202D || $num === 0x202E) { |
|
5195 | + return ''; |
|
5196 | + } |
|
4911 | 5197 | // <0x80 (or less than 128) are standard ascii characters a-z A-Z 0-9 and punctuation |
4912 | - elseif ($num < 0x80) |
|
4913 | - return chr($num); |
|
5198 | + elseif ($num < 0x80) { |
|
5199 | + return chr($num); |
|
5200 | + } |
|
4914 | 5201 | // <0x800 (2048) |
4915 | - elseif ($num < 0x800) |
|
4916 | - return chr(($num >> 6) + 192) . chr(($num & 63) + 128); |
|
5202 | + elseif ($num < 0x800) { |
|
5203 | + return chr(($num >> 6) + 192) . chr(($num & 63) + 128); |
|
5204 | + } |
|
4917 | 5205 | // < 0x10000 (65536) |
4918 | - elseif ($num < 0x10000) |
|
4919 | - return chr(($num >> 12) + 224) . chr((($num >> 6) & 63) + 128) . chr(($num & 63) + 128); |
|
5206 | + elseif ($num < 0x10000) { |
|
5207 | + return chr(($num >> 12) + 224) . chr((($num >> 6) & 63) + 128) . chr(($num & 63) + 128); |
|
5208 | + } |
|
4920 | 5209 | // <= 0x10FFFF (1114111) |
4921 | - else |
|
4922 | - return chr(($num >> 18) + 240) . chr((($num >> 12) & 63) + 128) . chr((($num >> 6) & 63) + 128) . chr(($num & 63) + 128); |
|
4923 | -} |
|
5210 | + else { |
|
5211 | + return chr(($num >> 18) + 240) . chr((($num >> 12) & 63) + 128) . chr((($num >> 6) & 63) + 128) . chr(($num & 63) + 128); |
|
5212 | + } |
|
5213 | + } |
|
4924 | 5214 | |
4925 | 5215 | /** |
4926 | 5216 | * Strips out invalid html entities, replaces others with html style { codes |
@@ -4933,17 +5223,19 @@ discard block |
||
4933 | 5223 | */ |
4934 | 5224 | function entity_fix__callback($matches) |
4935 | 5225 | { |
4936 | - if (!isset($matches[2])) |
|
4937 | - return ''; |
|
5226 | + if (!isset($matches[2])) { |
|
5227 | + return ''; |
|
5228 | + } |
|
4938 | 5229 | |
4939 | 5230 | $num = $matches[2][0] === 'x' ? hexdec(substr($matches[2], 1)) : (int) $matches[2]; |
4940 | 5231 | |
4941 | 5232 | // we don't allow control characters, characters out of range, byte markers, etc |
4942 | - if ($num < 0x20 || $num > 0x10FFFF || ($num >= 0xD800 && $num <= 0xDFFF) || $num == 0x202D || $num == 0x202E) |
|
4943 | - return ''; |
|
4944 | - else |
|
4945 | - return '&#' . $num . ';'; |
|
4946 | -} |
|
5233 | + if ($num < 0x20 || $num > 0x10FFFF || ($num >= 0xD800 && $num <= 0xDFFF) || $num == 0x202D || $num == 0x202E) { |
|
5234 | + return ''; |
|
5235 | + } else { |
|
5236 | + return '&#' . $num . ';'; |
|
5237 | + } |
|
5238 | + } |
|
4947 | 5239 | |
4948 | 5240 | /** |
4949 | 5241 | * Return a Gravatar URL based on |
@@ -4967,18 +5259,23 @@ discard block |
||
4967 | 5259 | $ratings = array('G', 'PG', 'R', 'X'); |
4968 | 5260 | $defaults = array('mm', 'identicon', 'monsterid', 'wavatar', 'retro', 'blank'); |
4969 | 5261 | $url_params = array(); |
4970 | - if (!empty($modSettings['gravatarMaxRating']) && in_array($modSettings['gravatarMaxRating'], $ratings)) |
|
4971 | - $url_params[] = 'rating=' . $modSettings['gravatarMaxRating']; |
|
4972 | - if (!empty($modSettings['gravatarDefault']) && in_array($modSettings['gravatarDefault'], $defaults)) |
|
4973 | - $url_params[] = 'default=' . $modSettings['gravatarDefault']; |
|
4974 | - if (!empty($modSettings['avatar_max_width_external'])) |
|
4975 | - $size_string = (int) $modSettings['avatar_max_width_external']; |
|
4976 | - if (!empty($modSettings['avatar_max_height_external']) && !empty($size_string)) |
|
4977 | - if ((int) $modSettings['avatar_max_height_external'] < $size_string) |
|
5262 | + if (!empty($modSettings['gravatarMaxRating']) && in_array($modSettings['gravatarMaxRating'], $ratings)) { |
|
5263 | + $url_params[] = 'rating=' . $modSettings['gravatarMaxRating']; |
|
5264 | + } |
|
5265 | + if (!empty($modSettings['gravatarDefault']) && in_array($modSettings['gravatarDefault'], $defaults)) { |
|
5266 | + $url_params[] = 'default=' . $modSettings['gravatarDefault']; |
|
5267 | + } |
|
5268 | + if (!empty($modSettings['avatar_max_width_external'])) { |
|
5269 | + $size_string = (int) $modSettings['avatar_max_width_external']; |
|
5270 | + } |
|
5271 | + if (!empty($modSettings['avatar_max_height_external']) && !empty($size_string)) { |
|
5272 | + if ((int) $modSettings['avatar_max_height_external'] < $size_string) |
|
4978 | 5273 | $size_string = $modSettings['avatar_max_height_external']; |
5274 | + } |
|
4979 | 5275 | |
4980 | - if (!empty($size_string)) |
|
4981 | - $url_params[] = 's=' . $size_string; |
|
5276 | + if (!empty($size_string)) { |
|
5277 | + $url_params[] = 's=' . $size_string; |
|
5278 | + } |
|
4982 | 5279 | } |
4983 | 5280 | $http_method = !empty($modSettings['force_ssl']) && $modSettings['force_ssl'] == 2 ? 'https://secure' : 'http://www'; |
4984 | 5281 | |
@@ -4997,22 +5294,26 @@ discard block |
||
4997 | 5294 | static $timezones = null, $lastwhen = null; |
4998 | 5295 | |
4999 | 5296 | // No point doing this over if we already did it once |
5000 | - if (!empty($timezones) && $when == $lastwhen) |
|
5001 | - return $timezones; |
|
5002 | - else |
|
5003 | - $lastwhen = $when; |
|
5297 | + if (!empty($timezones) && $when == $lastwhen) { |
|
5298 | + return $timezones; |
|
5299 | + } else { |
|
5300 | + $lastwhen = $when; |
|
5301 | + } |
|
5004 | 5302 | |
5005 | 5303 | // Parseable datetime string? |
5006 | - if (is_int($timestamp = strtotime($when))) |
|
5007 | - $when = $timestamp; |
|
5304 | + if (is_int($timestamp = strtotime($when))) { |
|
5305 | + $when = $timestamp; |
|
5306 | + } |
|
5008 | 5307 | |
5009 | 5308 | // A Unix timestamp? |
5010 | - elseif (is_numeric($when)) |
|
5011 | - $when = intval($when); |
|
5309 | + elseif (is_numeric($when)) { |
|
5310 | + $when = intval($when); |
|
5311 | + } |
|
5012 | 5312 | |
5013 | 5313 | // Invalid value? Just get current Unix timestamp. |
5014 | - else |
|
5015 | - $when = time(); |
|
5314 | + else { |
|
5315 | + $when = time(); |
|
5316 | + } |
|
5016 | 5317 | |
5017 | 5318 | // We'll need these too |
5018 | 5319 | $date_when = date_create('@' . $when); |
@@ -5076,8 +5377,9 @@ discard block |
||
5076 | 5377 | foreach ($priority_countries as $country) |
5077 | 5378 | { |
5078 | 5379 | $country_tzids = @timezone_identifiers_list(DateTimeZone::PER_COUNTRY, strtoupper(trim($country))); |
5079 | - if (!empty($country_tzids)) |
|
5080 | - $priority_tzids = array_merge($priority_tzids, $country_tzids); |
|
5380 | + if (!empty($country_tzids)) { |
|
5381 | + $priority_tzids = array_merge($priority_tzids, $country_tzids); |
|
5382 | + } |
|
5081 | 5383 | } |
5082 | 5384 | |
5083 | 5385 | // Process the preferred timezones first, then the rest. |
@@ -5087,8 +5389,9 @@ discard block |
||
5087 | 5389 | foreach ($tzids as $tzid) |
5088 | 5390 | { |
5089 | 5391 | // We don't want UTC right now |
5090 | - if ($tzid == 'UTC') |
|
5091 | - continue; |
|
5392 | + if ($tzid == 'UTC') { |
|
5393 | + continue; |
|
5394 | + } |
|
5092 | 5395 | |
5093 | 5396 | $tz = timezone_open($tzid); |
5094 | 5397 | |
@@ -5109,8 +5412,9 @@ discard block |
||
5109 | 5412 | } |
5110 | 5413 | |
5111 | 5414 | // A time zone from a prioritized country? |
5112 | - if (in_array($tzid, $priority_tzids)) |
|
5113 | - $priority_zones[$tzkey] = true; |
|
5415 | + if (in_array($tzid, $priority_tzids)) { |
|
5416 | + $priority_zones[$tzkey] = true; |
|
5417 | + } |
|
5114 | 5418 | |
5115 | 5419 | // Keep track of the location and offset for this tzid |
5116 | 5420 | $tzid_parts = explode('/', $tzid); |
@@ -5129,15 +5433,17 @@ discard block |
||
5129 | 5433 | { |
5130 | 5434 | date_timezone_set($date_when, timezone_open($tzvalue['tzid'])); |
5131 | 5435 | |
5132 | - if (!empty($timezone_descriptions[$tzvalue['tzid']])) |
|
5133 | - $desc = $timezone_descriptions[$tzvalue['tzid']]; |
|
5134 | - else |
|
5135 | - $desc = implode(', ', array_unique($tzvalue['locations'])); |
|
5436 | + if (!empty($timezone_descriptions[$tzvalue['tzid']])) { |
|
5437 | + $desc = $timezone_descriptions[$tzvalue['tzid']]; |
|
5438 | + } else { |
|
5439 | + $desc = implode(', ', array_unique($tzvalue['locations'])); |
|
5440 | + } |
|
5136 | 5441 | |
5137 | - if (isset($priority_zones[$tzkey])) |
|
5138 | - $priority_timezones[$tzvalue['tzid']] = $tzvalue['abbr'] . ' - ' . $desc . ' [UTC' . date_format($date_when, 'P') . ']'; |
|
5139 | - else |
|
5140 | - $timezones[$tzvalue['tzid']] = $tzvalue['abbr'] . ' - ' . $desc . ' [UTC' . date_format($date_when, 'P') . ']'; |
|
5442 | + if (isset($priority_zones[$tzkey])) { |
|
5443 | + $priority_timezones[$tzvalue['tzid']] = $tzvalue['abbr'] . ' - ' . $desc . ' [UTC' . date_format($date_when, 'P') . ']'; |
|
5444 | + } else { |
|
5445 | + $timezones[$tzvalue['tzid']] = $tzvalue['abbr'] . ' - ' . $desc . ' [UTC' . date_format($date_when, 'P') . ']'; |
|
5446 | + } |
|
5141 | 5447 | } |
5142 | 5448 | |
5143 | 5449 | $timezones = array_merge( |
@@ -5191,9 +5497,9 @@ discard block |
||
5191 | 5497 | 'Indian/Kerguelen' => 'TFT', |
5192 | 5498 | ); |
5193 | 5499 | |
5194 | - if (!empty($missing_tz_abbrs[$tzid])) |
|
5195 | - $tz_abbrev = $missing_tz_abbrs[$tzid]; |
|
5196 | - else |
|
5500 | + if (!empty($missing_tz_abbrs[$tzid])) { |
|
5501 | + $tz_abbrev = $missing_tz_abbrs[$tzid]; |
|
5502 | + } else |
|
5197 | 5503 | { |
5198 | 5504 | // Russia likes to experiment with time zones often, and names them as offsets from Moscow |
5199 | 5505 | $tz_location = timezone_location_get(timezone_open($tzid)); |
@@ -5221,8 +5527,9 @@ discard block |
||
5221 | 5527 | */ |
5222 | 5528 | function inet_ptod($ip_address) |
5223 | 5529 | { |
5224 | - if (!isValidIP($ip_address)) |
|
5225 | - return $ip_address; |
|
5530 | + if (!isValidIP($ip_address)) { |
|
5531 | + return $ip_address; |
|
5532 | + } |
|
5226 | 5533 | |
5227 | 5534 | $bin = inet_pton($ip_address); |
5228 | 5535 | return $bin; |
@@ -5234,13 +5541,15 @@ discard block |
||
5234 | 5541 | */ |
5235 | 5542 | function inet_dtop($bin) |
5236 | 5543 | { |
5237 | - if(empty($bin)) |
|
5238 | - return ''; |
|
5544 | + if(empty($bin)) { |
|
5545 | + return ''; |
|
5546 | + } |
|
5239 | 5547 | |
5240 | 5548 | global $db_type; |
5241 | 5549 | |
5242 | - if ($db_type == 'postgresql') |
|
5243 | - return $bin; |
|
5550 | + if ($db_type == 'postgresql') { |
|
5551 | + return $bin; |
|
5552 | + } |
|
5244 | 5553 | |
5245 | 5554 | $ip_address = inet_ntop($bin); |
5246 | 5555 | |
@@ -5265,26 +5574,32 @@ discard block |
||
5265 | 5574 | */ |
5266 | 5575 | function _safe_serialize($value) |
5267 | 5576 | { |
5268 | - if(is_null($value)) |
|
5269 | - return 'N;'; |
|
5577 | + if(is_null($value)) { |
|
5578 | + return 'N;'; |
|
5579 | + } |
|
5270 | 5580 | |
5271 | - if(is_bool($value)) |
|
5272 | - return 'b:'. (int) $value .';'; |
|
5581 | + if(is_bool($value)) { |
|
5582 | + return 'b:'. (int) $value .';'; |
|
5583 | + } |
|
5273 | 5584 | |
5274 | - if(is_int($value)) |
|
5275 | - return 'i:'. $value .';'; |
|
5585 | + if(is_int($value)) { |
|
5586 | + return 'i:'. $value .';'; |
|
5587 | + } |
|
5276 | 5588 | |
5277 | - if(is_float($value)) |
|
5278 | - return 'd:'. str_replace(',', '.', $value) .';'; |
|
5589 | + if(is_float($value)) { |
|
5590 | + return 'd:'. str_replace(',', '.', $value) .';'; |
|
5591 | + } |
|
5279 | 5592 | |
5280 | - if(is_string($value)) |
|
5281 | - return 's:'. strlen($value) .':"'. $value .'";'; |
|
5593 | + if(is_string($value)) { |
|
5594 | + return 's:'. strlen($value) .':"'. $value .'";'; |
|
5595 | + } |
|
5282 | 5596 | |
5283 | 5597 | if(is_array($value)) |
5284 | 5598 | { |
5285 | 5599 | $out = ''; |
5286 | - foreach($value as $k => $v) |
|
5287 | - $out .= _safe_serialize($k) . _safe_serialize($v); |
|
5600 | + foreach($value as $k => $v) { |
|
5601 | + $out .= _safe_serialize($k) . _safe_serialize($v); |
|
5602 | + } |
|
5288 | 5603 | |
5289 | 5604 | return 'a:'. count($value) .':{'. $out .'}'; |
5290 | 5605 | } |
@@ -5310,8 +5625,9 @@ discard block |
||
5310 | 5625 | |
5311 | 5626 | $out = _safe_serialize($value); |
5312 | 5627 | |
5313 | - if (isset($mbIntEnc)) |
|
5314 | - mb_internal_encoding($mbIntEnc); |
|
5628 | + if (isset($mbIntEnc)) { |
|
5629 | + mb_internal_encoding($mbIntEnc); |
|
5630 | + } |
|
5315 | 5631 | |
5316 | 5632 | return $out; |
5317 | 5633 | } |
@@ -5328,8 +5644,9 @@ discard block |
||
5328 | 5644 | function _safe_unserialize($str) |
5329 | 5645 | { |
5330 | 5646 | // Input is not a string. |
5331 | - if(empty($str) || !is_string($str)) |
|
5332 | - return false; |
|
5647 | + if(empty($str) || !is_string($str)) { |
|
5648 | + return false; |
|
5649 | + } |
|
5333 | 5650 | |
5334 | 5651 | $stack = array(); |
5335 | 5652 | $expected = array(); |
@@ -5345,43 +5662,38 @@ discard block |
||
5345 | 5662 | while($state != 1) |
5346 | 5663 | { |
5347 | 5664 | $type = isset($str[0]) ? $str[0] : ''; |
5348 | - if($type == '}') |
|
5349 | - $str = substr($str, 1); |
|
5350 | - |
|
5351 | - else if($type == 'N' && $str[1] == ';') |
|
5665 | + if($type == '}') { |
|
5666 | + $str = substr($str, 1); |
|
5667 | + } else if($type == 'N' && $str[1] == ';') |
|
5352 | 5668 | { |
5353 | 5669 | $value = null; |
5354 | 5670 | $str = substr($str, 2); |
5355 | - } |
|
5356 | - else if($type == 'b' && preg_match('/^b:([01]);/', $str, $matches)) |
|
5671 | + } else if($type == 'b' && preg_match('/^b:([01]);/', $str, $matches)) |
|
5357 | 5672 | { |
5358 | 5673 | $value = $matches[1] == '1' ? true : false; |
5359 | 5674 | $str = substr($str, 4); |
5360 | - } |
|
5361 | - else if($type == 'i' && preg_match('/^i:(-?[0-9]+);(.*)/s', $str, $matches)) |
|
5675 | + } else if($type == 'i' && preg_match('/^i:(-?[0-9]+);(.*)/s', $str, $matches)) |
|
5362 | 5676 | { |
5363 | 5677 | $value = (int)$matches[1]; |
5364 | 5678 | $str = $matches[2]; |
5365 | - } |
|
5366 | - else if($type == 'd' && preg_match('/^d:(-?[0-9]+\.?[0-9]*(E[+-][0-9]+)?);(.*)/s', $str, $matches)) |
|
5679 | + } else if($type == 'd' && preg_match('/^d:(-?[0-9]+\.?[0-9]*(E[+-][0-9]+)?);(.*)/s', $str, $matches)) |
|
5367 | 5680 | { |
5368 | 5681 | $value = (float)$matches[1]; |
5369 | 5682 | $str = $matches[3]; |
5370 | - } |
|
5371 | - else if($type == 's' && preg_match('/^s:([0-9]+):"(.*)/s', $str, $matches) && substr($matches[2], (int)$matches[1], 2) == '";') |
|
5683 | + } else if($type == 's' && preg_match('/^s:([0-9]+):"(.*)/s', $str, $matches) && substr($matches[2], (int)$matches[1], 2) == '";') |
|
5372 | 5684 | { |
5373 | 5685 | $value = substr($matches[2], 0, (int)$matches[1]); |
5374 | 5686 | $str = substr($matches[2], (int)$matches[1] + 2); |
5375 | - } |
|
5376 | - else if($type == 'a' && preg_match('/^a:([0-9]+):{(.*)/s', $str, $matches)) |
|
5687 | + } else if($type == 'a' && preg_match('/^a:([0-9]+):{(.*)/s', $str, $matches)) |
|
5377 | 5688 | { |
5378 | 5689 | $expectedLength = (int)$matches[1]; |
5379 | 5690 | $str = $matches[2]; |
5380 | 5691 | } |
5381 | 5692 | |
5382 | 5693 | // Object or unknown/malformed type. |
5383 | - else |
|
5384 | - return false; |
|
5694 | + else { |
|
5695 | + return false; |
|
5696 | + } |
|
5385 | 5697 | |
5386 | 5698 | switch($state) |
5387 | 5699 | { |
@@ -5409,8 +5721,9 @@ discard block |
||
5409 | 5721 | if($type == '}') |
5410 | 5722 | { |
5411 | 5723 | // Array size is less than expected. |
5412 | - if(count($list) < end($expected)) |
|
5413 | - return false; |
|
5724 | + if(count($list) < end($expected)) { |
|
5725 | + return false; |
|
5726 | + } |
|
5414 | 5727 | |
5415 | 5728 | unset($list); |
5416 | 5729 | $list = &$stack[count($stack)-1]; |
@@ -5419,8 +5732,9 @@ discard block |
||
5419 | 5732 | // Go to terminal state if we're at the end of the root array. |
5420 | 5733 | array_pop($expected); |
5421 | 5734 | |
5422 | - if(count($expected) == 0) |
|
5423 | - $state = 1; |
|
5735 | + if(count($expected) == 0) { |
|
5736 | + $state = 1; |
|
5737 | + } |
|
5424 | 5738 | |
5425 | 5739 | break; |
5426 | 5740 | } |
@@ -5428,8 +5742,9 @@ discard block |
||
5428 | 5742 | if($type == 'i' || $type == 's') |
5429 | 5743 | { |
5430 | 5744 | // Array size exceeds expected length. |
5431 | - if(count($list) >= end($expected)) |
|
5432 | - return false; |
|
5745 | + if(count($list) >= end($expected)) { |
|
5746 | + return false; |
|
5747 | + } |
|
5433 | 5748 | |
5434 | 5749 | $key = $value; |
5435 | 5750 | $state = 3; |
@@ -5463,8 +5778,9 @@ discard block |
||
5463 | 5778 | } |
5464 | 5779 | |
5465 | 5780 | // Trailing data in input. |
5466 | - if(!empty($str)) |
|
5467 | - return false; |
|
5781 | + if(!empty($str)) { |
|
5782 | + return false; |
|
5783 | + } |
|
5468 | 5784 | |
5469 | 5785 | return $data; |
5470 | 5786 | } |
@@ -5487,8 +5803,9 @@ discard block |
||
5487 | 5803 | |
5488 | 5804 | $out = _safe_unserialize($str); |
5489 | 5805 | |
5490 | - if (isset($mbIntEnc)) |
|
5491 | - mb_internal_encoding($mbIntEnc); |
|
5806 | + if (isset($mbIntEnc)) { |
|
5807 | + mb_internal_encoding($mbIntEnc); |
|
5808 | + } |
|
5492 | 5809 | |
5493 | 5810 | return $out; |
5494 | 5811 | } |
@@ -5503,12 +5820,14 @@ discard block |
||
5503 | 5820 | function smf_chmod($file, $value = 0) |
5504 | 5821 | { |
5505 | 5822 | // No file? no checks! |
5506 | - if (empty($file)) |
|
5507 | - return false; |
|
5823 | + if (empty($file)) { |
|
5824 | + return false; |
|
5825 | + } |
|
5508 | 5826 | |
5509 | 5827 | // Already writable? |
5510 | - if (is_writable($file)) |
|
5511 | - return true; |
|
5828 | + if (is_writable($file)) { |
|
5829 | + return true; |
|
5830 | + } |
|
5512 | 5831 | |
5513 | 5832 | // Do we have a file or a dir? |
5514 | 5833 | $isDir = is_dir($file); |
@@ -5524,10 +5843,9 @@ discard block |
||
5524 | 5843 | { |
5525 | 5844 | $isWritable = true; |
5526 | 5845 | break; |
5846 | + } else { |
|
5847 | + @chmod($file, $val); |
|
5527 | 5848 | } |
5528 | - |
|
5529 | - else |
|
5530 | - @chmod($file, $val); |
|
5531 | 5849 | } |
5532 | 5850 | |
5533 | 5851 | return $isWritable; |
@@ -5546,8 +5864,9 @@ discard block |
||
5546 | 5864 | global $txt; |
5547 | 5865 | |
5548 | 5866 | // Come on... |
5549 | - if (empty($json) || !is_string($json)) |
|
5550 | - return array(); |
|
5867 | + if (empty($json) || !is_string($json)) { |
|
5868 | + return array(); |
|
5869 | + } |
|
5551 | 5870 | |
5552 | 5871 | $returnArray = @json_decode($json, $returnAsArray); |
5553 | 5872 | |
@@ -5585,11 +5904,11 @@ discard block |
||
5585 | 5904 | $jsonDebug = $jsonDebug[0]; |
5586 | 5905 | loadLanguage('Errors'); |
5587 | 5906 | |
5588 | - if (!empty($jsonDebug)) |
|
5589 | - log_error($txt['json_'. $jsonError], 'critical', $jsonDebug['file'], $jsonDebug['line']); |
|
5590 | - |
|
5591 | - else |
|
5592 | - log_error($txt['json_'. $jsonError], 'critical'); |
|
5907 | + if (!empty($jsonDebug)) { |
|
5908 | + log_error($txt['json_'. $jsonError], 'critical', $jsonDebug['file'], $jsonDebug['line']); |
|
5909 | + } else { |
|
5910 | + log_error($txt['json_'. $jsonError], 'critical'); |
|
5911 | + } |
|
5593 | 5912 | |
5594 | 5913 | // Everyone expects an array. |
5595 | 5914 | return array(); |
@@ -5623,8 +5942,9 @@ discard block |
||
5623 | 5942 | global $db_show_debug, $modSettings; |
5624 | 5943 | |
5625 | 5944 | // Defensive programming anyone? |
5626 | - if (empty($data)) |
|
5627 | - return false; |
|
5945 | + if (empty($data)) { |
|
5946 | + return false; |
|
5947 | + } |
|
5628 | 5948 | |
5629 | 5949 | // Don't need extra stuff... |
5630 | 5950 | $db_show_debug = false; |
@@ -5632,11 +5952,11 @@ discard block |
||
5632 | 5952 | // Kill anything else. |
5633 | 5953 | ob_end_clean(); |
5634 | 5954 | |
5635 | - if (!empty($modSettings['CompressedOutput'])) |
|
5636 | - @ob_start('ob_gzhandler'); |
|
5637 | - |
|
5638 | - else |
|
5639 | - ob_start(); |
|
5955 | + if (!empty($modSettings['CompressedOutput'])) { |
|
5956 | + @ob_start('ob_gzhandler'); |
|
5957 | + } else { |
|
5958 | + ob_start(); |
|
5959 | + } |
|
5640 | 5960 | |
5641 | 5961 | // Set the header. |
5642 | 5962 | header($type); |
@@ -5668,8 +5988,9 @@ discard block |
||
5668 | 5988 | static $done = false; |
5669 | 5989 | |
5670 | 5990 | // If we don't need to do anything, don't |
5671 | - if (!$update && $done) |
|
5672 | - return; |
|
5991 | + if (!$update && $done) { |
|
5992 | + return; |
|
5993 | + } |
|
5673 | 5994 | |
5674 | 5995 | // Should we get a new copy of the official list of TLDs? |
5675 | 5996 | if ($update) |
@@ -5678,8 +5999,9 @@ discard block |
||
5678 | 5999 | $tlds = fetch_web_data('https://data.iana.org/TLD/tlds-alpha-by-domain.txt'); |
5679 | 6000 | |
5680 | 6001 | // If the Internet Assigned Numbers Authority can't be reached, the Internet is gone. We're probably running on a server hidden in a bunker deep underground to protect it from marauding bandits roaming on the surface. We don't want to waste precious electricity on pointlessly repeating background tasks, so we'll wait until the next regularly scheduled update to see if civilization has been restored. |
5681 | - if ($tlds === false) |
|
5682 | - $postapocalypticNightmare = true; |
|
6002 | + if ($tlds === false) { |
|
6003 | + $postapocalypticNightmare = true; |
|
6004 | + } |
|
5683 | 6005 | } |
5684 | 6006 | // If we aren't updating and the regex is valid, we're done |
5685 | 6007 | elseif (!empty($modSettings['tld_regex']) && @preg_match('~' . $modSettings['tld_regex'] . '~', null) !== false) |
@@ -5694,10 +6016,11 @@ discard block |
||
5694 | 6016 | // Clean $tlds and convert it to an array |
5695 | 6017 | $tlds = array_filter(explode("\n", strtolower($tlds)), function($line) { |
5696 | 6018 | $line = trim($line); |
5697 | - if (empty($line) || strpos($line, '#') !== false || strpos($line, ' ') !== false) |
|
5698 | - return false; |
|
5699 | - else |
|
5700 | - return true; |
|
6019 | + if (empty($line) || strpos($line, '#') !== false || strpos($line, ' ') !== false) { |
|
6020 | + return false; |
|
6021 | + } else { |
|
6022 | + return true; |
|
6023 | + } |
|
5701 | 6024 | }); |
5702 | 6025 | |
5703 | 6026 | // Convert Punycode to Unicode |
@@ -5751,8 +6074,9 @@ discard block |
||
5751 | 6074 | $idx += $digit * $w; |
5752 | 6075 | $t = ($k <= $bias) ? $tmin : (($k >= $bias + $tmax) ? $tmax : ($k - $bias)); |
5753 | 6076 | |
5754 | - if ($digit < $t) |
|
5755 | - break; |
|
6077 | + if ($digit < $t) { |
|
6078 | + break; |
|
6079 | + } |
|
5756 | 6080 | |
5757 | 6081 | $w = (int) ($w * ($base - $t)); |
5758 | 6082 | } |
@@ -5761,8 +6085,9 @@ discard block |
||
5761 | 6085 | $delta = intval($is_first ? ($delta / $damp) : ($delta / 2)); |
5762 | 6086 | $delta += intval($delta / ($deco_len + 1)); |
5763 | 6087 | |
5764 | - for ($k = 0; $delta > (($base - $tmin) * $tmax) / 2; $k += $base) |
|
5765 | - $delta = intval($delta / ($base - $tmin)); |
|
6088 | + for ($k = 0; $delta > (($base - $tmin) * $tmax) / 2; $k += $base) { |
|
6089 | + $delta = intval($delta / ($base - $tmin)); |
|
6090 | + } |
|
5766 | 6091 | |
5767 | 6092 | $bias = intval($k + ($base - $tmin + 1) * $delta / ($delta + $skew)); |
5768 | 6093 | $is_first = false; |
@@ -5771,8 +6096,9 @@ discard block |
||
5771 | 6096 | |
5772 | 6097 | if ($deco_len > 0) |
5773 | 6098 | { |
5774 | - for ($i = $deco_len; $i > $idx; $i--) |
|
5775 | - $decoded[$i] = $decoded[($i - 1)]; |
|
6099 | + for ($i = $deco_len; $i > $idx; $i--) { |
|
6100 | + $decoded[$i] = $decoded[($i - 1)]; |
|
6101 | + } |
|
5776 | 6102 | } |
5777 | 6103 | $decoded[$idx++] = $char; |
5778 | 6104 | } |
@@ -5780,24 +6106,29 @@ discard block |
||
5780 | 6106 | foreach ($decoded as $k => $v) |
5781 | 6107 | { |
5782 | 6108 | // 7bit are transferred literally |
5783 | - if ($v < 128) |
|
5784 | - $output .= chr($v); |
|
6109 | + if ($v < 128) { |
|
6110 | + $output .= chr($v); |
|
6111 | + } |
|
5785 | 6112 | |
5786 | 6113 | // 2 bytes |
5787 | - elseif ($v < (1 << 11)) |
|
5788 | - $output .= chr(192+($v >> 6)) . chr(128+($v & 63)); |
|
6114 | + elseif ($v < (1 << 11)) { |
|
6115 | + $output .= chr(192+($v >> 6)) . chr(128+($v & 63)); |
|
6116 | + } |
|
5789 | 6117 | |
5790 | 6118 | // 3 bytes |
5791 | - elseif ($v < (1 << 16)) |
|
5792 | - $output .= chr(224+($v >> 12)) . chr(128+(($v >> 6) & 63)) . chr(128+($v & 63)); |
|
6119 | + elseif ($v < (1 << 16)) { |
|
6120 | + $output .= chr(224+($v >> 12)) . chr(128+(($v >> 6) & 63)) . chr(128+($v & 63)); |
|
6121 | + } |
|
5793 | 6122 | |
5794 | 6123 | // 4 bytes |
5795 | - elseif ($v < (1 << 21)) |
|
5796 | - $output .= chr(240+($v >> 18)) . chr(128+(($v >> 12) & 63)) . chr(128+(($v >> 6) & 63)) . chr(128+($v & 63)); |
|
6124 | + elseif ($v < (1 << 21)) { |
|
6125 | + $output .= chr(240+($v >> 18)) . chr(128+(($v >> 12) & 63)) . chr(128+(($v >> 6) & 63)) . chr(128+($v & 63)); |
|
6126 | + } |
|
5797 | 6127 | |
5798 | 6128 | // 'Conversion from UCS-4 to UTF-8 failed: malformed input at byte '.$k |
5799 | - else |
|
5800 | - $output .= $safe_char; |
|
6129 | + else { |
|
6130 | + $output .= $safe_char; |
|
6131 | + } |
|
5801 | 6132 | } |
5802 | 6133 | |
5803 | 6134 | $output_parts[] = $output; |
@@ -5890,8 +6221,7 @@ discard block |
||
5890 | 6221 | |
5891 | 6222 | $strlen = 'mb_strlen'; |
5892 | 6223 | $substr = 'mb_substr'; |
5893 | - } |
|
5894 | - else |
|
6224 | + } else |
|
5895 | 6225 | { |
5896 | 6226 | $strlen = $smcFunc['strlen']; |
5897 | 6227 | $substr = $smcFunc['substr']; |
@@ -5905,20 +6235,21 @@ discard block |
||
5905 | 6235 | |
5906 | 6236 | $first = $substr($string, 0, 1); |
5907 | 6237 | |
5908 | - if (empty($index[$first])) |
|
5909 | - $index[$first] = array(); |
|
6238 | + if (empty($index[$first])) { |
|
6239 | + $index[$first] = array(); |
|
6240 | + } |
|
5910 | 6241 | |
5911 | 6242 | if ($strlen($string) > 1) |
5912 | 6243 | { |
5913 | 6244 | // Sanity check on recursion |
5914 | - if ($depth > 99) |
|
5915 | - $index[$first][$substr($string, 1)] = ''; |
|
5916 | - |
|
5917 | - else |
|
5918 | - $index[$first] = $add_string_to_index($substr($string, 1), $index[$first]); |
|
6245 | + if ($depth > 99) { |
|
6246 | + $index[$first][$substr($string, 1)] = ''; |
|
6247 | + } else { |
|
6248 | + $index[$first] = $add_string_to_index($substr($string, 1), $index[$first]); |
|
6249 | + } |
|
6250 | + } else { |
|
6251 | + $index[$first][''] = ''; |
|
5919 | 6252 | } |
5920 | - else |
|
5921 | - $index[$first][''] = ''; |
|
5922 | 6253 | |
5923 | 6254 | $depth--; |
5924 | 6255 | return $index; |
@@ -5941,9 +6272,9 @@ discard block |
||
5941 | 6272 | $key_regex = preg_quote($key, $delim); |
5942 | 6273 | $new_key = $key; |
5943 | 6274 | |
5944 | - if (empty($value)) |
|
5945 | - $sub_regex = ''; |
|
5946 | - else |
|
6275 | + if (empty($value)) { |
|
6276 | + $sub_regex = ''; |
|
6277 | + } else |
|
5947 | 6278 | { |
5948 | 6279 | $sub_regex = $index_to_regex($value, $delim); |
5949 | 6280 | |
@@ -5951,22 +6282,22 @@ discard block |
||
5951 | 6282 | { |
5952 | 6283 | $new_key_array = explode('(?'.'>', $sub_regex); |
5953 | 6284 | $new_key .= $new_key_array[0]; |
6285 | + } else { |
|
6286 | + $sub_regex = '(?'.'>' . $sub_regex . ')'; |
|
5954 | 6287 | } |
5955 | - else |
|
5956 | - $sub_regex = '(?'.'>' . $sub_regex . ')'; |
|
5957 | 6288 | } |
5958 | 6289 | |
5959 | - if ($depth > 1) |
|
5960 | - $regex[$new_key] = $key_regex . $sub_regex; |
|
5961 | - else |
|
6290 | + if ($depth > 1) { |
|
6291 | + $regex[$new_key] = $key_regex . $sub_regex; |
|
6292 | + } else |
|
5962 | 6293 | { |
5963 | 6294 | if (($length += strlen($key_regex) + 1) < $max_length || empty($regex)) |
5964 | 6295 | { |
5965 | 6296 | $regex[$new_key] = $key_regex . $sub_regex; |
5966 | 6297 | unset($index[$key]); |
6298 | + } else { |
|
6299 | + break; |
|
5967 | 6300 | } |
5968 | - else |
|
5969 | - break; |
|
5970 | 6301 | } |
5971 | 6302 | } |
5972 | 6303 | |
@@ -5975,10 +6306,11 @@ discard block |
||
5975 | 6306 | $l1 = $strlen($k1); |
5976 | 6307 | $l2 = $strlen($k2); |
5977 | 6308 | |
5978 | - if ($l1 == $l2) |
|
5979 | - return strcmp($k1, $k2) > 0 ? 1 : -1; |
|
5980 | - else |
|
5981 | - return $l1 > $l2 ? -1 : 1; |
|
6309 | + if ($l1 == $l2) { |
|
6310 | + return strcmp($k1, $k2) > 0 ? 1 : -1; |
|
6311 | + } else { |
|
6312 | + return $l1 > $l2 ? -1 : 1; |
|
6313 | + } |
|
5982 | 6314 | }); |
5983 | 6315 | |
5984 | 6316 | $depth--; |
@@ -5989,21 +6321,24 @@ discard block |
||
5989 | 6321 | $index = array(); |
5990 | 6322 | $regex = ''; |
5991 | 6323 | |
5992 | - foreach ($strings as $string) |
|
5993 | - $index = $add_string_to_index($string, $index); |
|
6324 | + foreach ($strings as $string) { |
|
6325 | + $index = $add_string_to_index($string, $index); |
|
6326 | + } |
|
5994 | 6327 | |
5995 | 6328 | if ($returnArray === true) |
5996 | 6329 | { |
5997 | 6330 | $regex = array(); |
5998 | - while (!empty($index)) |
|
5999 | - $regex[] = '(?'.'>' . $index_to_regex($index, $delim) . ')'; |
|
6331 | + while (!empty($index)) { |
|
6332 | + $regex[] = '(?'.'>' . $index_to_regex($index, $delim) . ')'; |
|
6333 | + } |
|
6334 | + } else { |
|
6335 | + $regex = '(?'.'>' . $index_to_regex($index, $delim) . ')'; |
|
6000 | 6336 | } |
6001 | - else |
|
6002 | - $regex = '(?'.'>' . $index_to_regex($index, $delim) . ')'; |
|
6003 | 6337 | |
6004 | 6338 | // Restore PHP's internal character encoding to whatever it was originally |
6005 | - if (!empty($current_encoding)) |
|
6006 | - mb_internal_encoding($current_encoding); |
|
6339 | + if (!empty($current_encoding)) { |
|
6340 | + mb_internal_encoding($current_encoding); |
|
6341 | + } |
|
6007 | 6342 | |
6008 | 6343 | return $regex; |
6009 | 6344 | } |
@@ -6043,13 +6378,15 @@ discard block |
||
6043 | 6378 | // Need to add the trailing slash, or it puts it there & thinks there's a redirect when there isn't... |
6044 | 6379 | $url = str_ireplace('https://', 'http://', $url) . '/'; |
6045 | 6380 | $headers = @get_headers($url); |
6046 | - if ($headers === false) |
|
6047 | - return false; |
|
6381 | + if ($headers === false) { |
|
6382 | + return false; |
|
6383 | + } |
|
6048 | 6384 | |
6049 | 6385 | // Now to see if it came back https... |
6050 | 6386 | // First check for a redirect status code in first row (301, 302, 307) |
6051 | - if (strstr($headers[0], '301') === false && strstr($headers[0], '302') === false && strstr($headers[0], '307') === false) |
|
6052 | - return false; |
|
6387 | + if (strstr($headers[0], '301') === false && strstr($headers[0], '302') === false && strstr($headers[0], '307') === false) { |
|
6388 | + return false; |
|
6389 | + } |
|
6053 | 6390 | |
6054 | 6391 | // Search for the location entry to confirm https |
6055 | 6392 | $result = false; |
@@ -6085,8 +6422,7 @@ discard block |
||
6085 | 6422 | $is_admin = $user_info['is_admin']; |
6086 | 6423 | $mod_cache = !empty($user_info['mod_cache']) ? $user_info['mod_cache'] : null; |
6087 | 6424 | $ignoreboards = !empty($user_info['ignoreboards']) ? $user_info['ignoreboards'] : null; |
6088 | - } |
|
6089 | - else |
|
6425 | + } else |
|
6090 | 6426 | { |
6091 | 6427 | $request = $smcFunc['db_query']('', ' |
6092 | 6428 | SELECT mem.ignore_boards, mem.id_group, mem.additional_groups, mem.id_post_group |
@@ -6100,17 +6436,19 @@ discard block |
||
6100 | 6436 | |
6101 | 6437 | $row = $smcFunc['db_fetch_assoc']($request); |
6102 | 6438 | |
6103 | - if (empty($row['additional_groups'])) |
|
6104 | - $groups = array($row['id_group'], $user_settings['id_post_group']); |
|
6105 | - else |
|
6106 | - $groups = array_merge( |
|
6439 | + if (empty($row['additional_groups'])) { |
|
6440 | + $groups = array($row['id_group'], $user_settings['id_post_group']); |
|
6441 | + } else { |
|
6442 | + $groups = array_merge( |
|
6107 | 6443 | array($row['id_group'], $user_settings['id_post_group']), |
6108 | 6444 | explode(',', $row['additional_groups']) |
6109 | 6445 | ); |
6446 | + } |
|
6110 | 6447 | |
6111 | 6448 | // Because history has proven that it is possible for groups to go bad - clean up in case. |
6112 | - foreach ($groups as $k => $v) |
|
6113 | - $groups[$k] = (int) $v; |
|
6449 | + foreach ($groups as $k => $v) { |
|
6450 | + $groups[$k] = (int) $v; |
|
6451 | + } |
|
6114 | 6452 | |
6115 | 6453 | $is_admin = in_array(1, $groups); |
6116 | 6454 | |
@@ -6127,8 +6465,9 @@ discard block |
||
6127 | 6465 | 'current_member' => $userid, |
6128 | 6466 | ) |
6129 | 6467 | ); |
6130 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
6131 | - $boards_mod[] = $row['id_board']; |
|
6468 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
6469 | + $boards_mod[] = $row['id_board']; |
|
6470 | + } |
|
6132 | 6471 | $smcFunc['db_free_result']($request); |
6133 | 6472 | |
6134 | 6473 | // Can any of the groups they're in moderate any of the boards? |
@@ -6140,8 +6479,9 @@ discard block |
||
6140 | 6479 | 'groups' => $groups, |
6141 | 6480 | ) |
6142 | 6481 | ); |
6143 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
6144 | - $boards_mod[] = $row['id_board']; |
|
6482 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
6483 | + $boards_mod[] = $row['id_board']; |
|
6484 | + } |
|
6145 | 6485 | $smcFunc['db_free_result']($request); |
6146 | 6486 | |
6147 | 6487 | // Just in case we've got duplicates here... |
@@ -6151,21 +6491,25 @@ discard block |
||
6151 | 6491 | } |
6152 | 6492 | |
6153 | 6493 | // Just build this here, it makes it easier to change/use - administrators can see all boards. |
6154 | - if ($is_admin) |
|
6155 | - $query_part['query_see_board'] = '1=1'; |
|
6494 | + if ($is_admin) { |
|
6495 | + $query_part['query_see_board'] = '1=1'; |
|
6496 | + } |
|
6156 | 6497 | // Otherwise just the groups in $user_info['groups']. |
6157 | - else |
|
6158 | - $query_part['query_see_board'] = '((FIND_IN_SET(' . implode(', b.member_groups) != 0 OR FIND_IN_SET(', $groups) . ', b.member_groups) != 0)' . (!empty($deny_boards_access) ? ' AND (FIND_IN_SET(' . implode(', b.deny_member_groups) = 0 AND FIND_IN_SET(', $groups) . ', b.deny_member_groups) = 0)' : '') . (isset($mod_cache) ? ' OR ' . $mod_cache['mq'] : '') . ')'; |
|
6498 | + else { |
|
6499 | + $query_part['query_see_board'] = '((FIND_IN_SET(' . implode(', b.member_groups) != 0 OR FIND_IN_SET(', $groups) . ', b.member_groups) != 0)' . (!empty($deny_boards_access) ? ' AND (FIND_IN_SET(' . implode(', b.deny_member_groups) = 0 AND FIND_IN_SET(', $groups) . ', b.deny_member_groups) = 0)' : '') . (isset($mod_cache) ? ' OR ' . $mod_cache['mq'] : '') . ')'; |
|
6500 | + } |
|
6159 | 6501 | |
6160 | 6502 | // Build the list of boards they WANT to see. |
6161 | 6503 | // This will take the place of query_see_boards in certain spots, so it better include the boards they can see also |
6162 | 6504 | |
6163 | 6505 | // If they aren't ignoring any boards then they want to see all the boards they can see |
6164 | - if (empty($ignoreboards)) |
|
6165 | - $query_part['query_wanna_see_board'] = $query_part['query_see_board']; |
|
6506 | + if (empty($ignoreboards)) { |
|
6507 | + $query_part['query_wanna_see_board'] = $query_part['query_see_board']; |
|
6508 | + } |
|
6166 | 6509 | // Ok I guess they don't want to see all the boards |
6167 | - else |
|
6168 | - $query_part['query_wanna_see_board'] = '(' . $query_part['query_see_board'] . ' AND b.id_board NOT IN (' . implode(',', $ignoreboards) . '))'; |
|
6510 | + else { |
|
6511 | + $query_part['query_wanna_see_board'] = '(' . $query_part['query_see_board'] . ' AND b.id_board NOT IN (' . implode(',', $ignoreboards) . '))'; |
|
6512 | + } |
|
6169 | 6513 | |
6170 | 6514 | return $query_part; |
6171 | 6515 | } |