Passed
Pull Request — release-2.1 (#6272)
by Mathias
03:55
created
Sources/random_compat/error_polyfill.php 1 patch
Braces   +9 added lines, -4 removed lines patch added patch discarded remove patch
@@ -26,7 +26,8 @@  discard block
 block discarded – undo
26 26
  * SOFTWARE.
27 27
  */
28 28
 
29
-if (!class_exists('Error', false)) {
29
+if (!class_exists('Error', false))
30
+{
30 31
     // We can't really avoid making this extend Exception in PHP 5.
31 32
     class Error extends Exception
32 33
     {
@@ -34,13 +35,17 @@  discard block
 block discarded – undo
34 35
     }
35 36
 }
36 37
 
37
-if (!class_exists('TypeError', false)) {
38
-    if (is_subclass_of('Error', 'Exception')) {
38
+if (!class_exists('TypeError', false))
39
+{
40
+    if (is_subclass_of('Error', 'Exception'))
41
+    {
39 42
         class TypeError extends Error
40 43
         {
41 44
             
42 45
         }
43
-    } else {
46
+    }
47
+    else
48
+    {
44 49
         class TypeError extends Exception
45 50
         {
46 51
             
Please login to merge, or discard this patch.
Sources/random_compat/random.php 1 patch
Braces   +35 added lines, -16 removed lines patch added patch discarded remove patch
@@ -29,7 +29,8 @@  discard block
 block discarded – undo
29 29
  * SOFTWARE.
30 30
  */
31 31
 
32
-if (!defined('PHP_VERSION_ID')) {
32
+if (!defined('PHP_VERSION_ID'))
33
+{
33 34
     // This constant was introduced in PHP 5.2.7
34 35
     $RandomCompatversion = array_map('intval', explode('.', PHP_VERSION));
35 36
     define(
@@ -44,11 +45,13 @@  discard block
 block discarded – undo
44 45
 /**
45 46
  * PHP 7.0.0 and newer have these functions natively.
46 47
  */
47
-if (PHP_VERSION_ID >= 70000) {
48
+if (PHP_VERSION_ID >= 70000)
49
+{
48 50
     return;
49 51
 }
50 52
 
51
-if (!defined('RANDOM_COMPAT_READ_BUFFER')) {
53
+if (!defined('RANDOM_COMPAT_READ_BUFFER'))
54
+{
52 55
     define('RANDOM_COMPAT_READ_BUFFER', 8);
53 56
 }
54 57
 
@@ -58,7 +61,8 @@  discard block
 block discarded – undo
58 61
 require_once $RandomCompatDIR . DIRECTORY_SEPARATOR . 'cast_to_int.php';
59 62
 require_once $RandomCompatDIR . DIRECTORY_SEPARATOR . 'error_polyfill.php';
60 63
 
61
-if (!is_callable('random_bytes')) {
64
+if (!is_callable('random_bytes'))
65
+{
62 66
     /**
63 67
      * PHP 5.2.0 - 5.6.x way to implement random_bytes()
64 68
      *
@@ -73,11 +77,15 @@  discard block
 block discarded – undo
73 77
      *
74 78
      * See RATIONALE.md for our reasoning behind this particular order
75 79
      */
76
-    if (extension_loaded('libsodium')) {
80
+    if (extension_loaded('libsodium'))
81
+    {
77 82
         // See random_bytes_libsodium.php
78
-        if (PHP_VERSION_ID >= 50300 && is_callable('\\Sodium\\randombytes_buf')) {
83
+        if (PHP_VERSION_ID >= 50300 && is_callable('\\Sodium\\randombytes_buf'))
84
+        {
79 85
             require_once $RandomCompatDIR . DIRECTORY_SEPARATOR . 'random_bytes_libsodium.php';
80
-        } elseif (method_exists('Sodium', 'randombytes_buf')) {
86
+        }
87
+        elseif (method_exists('Sodium', 'randombytes_buf'))
88
+        {
81 89
             require_once $RandomCompatDIR . DIRECTORY_SEPARATOR . 'random_bytes_libsodium_legacy.php';
82 90
         }
83 91
     }
@@ -85,13 +93,15 @@  discard block
 block discarded – undo
85 93
     /**
86 94
      * Reading directly from /dev/urandom:
87 95
      */
88
-    if (DIRECTORY_SEPARATOR === '/') {
96
+    if (DIRECTORY_SEPARATOR === '/')
97
+    {
89 98
         // DIRECTORY_SEPARATOR === '/' on Unix-like OSes -- this is a fast
90 99
         // way to exclude Windows.
91 100
         $RandomCompatUrandom = true;
92 101
         $RandomCompat_basedir = ini_get('open_basedir');
93 102
 
94
-        if (!empty($RandomCompat_basedir)) {
103
+        if (!empty($RandomCompat_basedir))
104
+        {
95 105
             $RandomCompat_open_basedir = explode(
96 106
                 PATH_SEPARATOR,
97 107
                 strtolower($RandomCompat_basedir)
@@ -121,7 +131,9 @@  discard block
 block discarded – undo
121 131
         }
122 132
         // Unset variables after use
123 133
         $RandomCompat_basedir = null;
124
-    } else {
134
+    }
135
+    else
136
+    {
125 137
         $RandomCompatUrandom = false;
126 138
     }
127 139
 
@@ -179,14 +191,19 @@  discard block
 block discarded – undo
179 191
             strtolower(ini_get('disable_classes'))
180 192
         );
181 193
 
182
-        if (!in_array('com', $RandomCompat_disabled_classes)) {
183
-            try {
194
+        if (!in_array('com', $RandomCompat_disabled_classes))
195
+        {
196
+            try
197
+            {
184 198
                 $RandomCompatCOMtest = new COM('CAPICOM.Utilities.1');
185
-                if (method_exists($RandomCompatCOMtest, 'GetRandom')) {
199
+                if (method_exists($RandomCompatCOMtest, 'GetRandom'))
200
+                {
186 201
                     // See random_bytes_com_dotnet.php
187 202
                     require_once $RandomCompatDIR . DIRECTORY_SEPARATOR . 'random_bytes_com_dotnet.php';
188 203
                 }
189
-            } catch (com_exception $e) {
204
+            }
205
+            catch (com_exception $e)
206
+            {
190 207
                 // Don't try to use it.
191 208
             }
192 209
         }
@@ -197,7 +214,8 @@  discard block
 block discarded – undo
197 214
     /**
198 215
      * throw new Exception
199 216
      */
200
-    if (!is_callable('random_bytes')) {
217
+    if (!is_callable('random_bytes'))
218
+    {
201 219
         /**
202 220
          * We don't have any more options, so let's throw an exception right now
203 221
          * and hope the developer won't let it fail silently.
@@ -218,7 +236,8 @@  discard block
 block discarded – undo
218 236
     }
219 237
 }
220 238
 
221
-if (!is_callable('random_int')) {
239
+if (!is_callable('random_int'))
240
+{
222 241
     require_once $RandomCompatDIR . DIRECTORY_SEPARATOR . 'random_int.php';
223 242
 }
224 243
 
Please login to merge, or discard this patch.
Sources/random_compat/cast_to_int.php 1 patch
Braces   +12 added lines, -5 removed lines patch added patch discarded remove patch
@@ -26,7 +26,8 @@  discard block
 block discarded – undo
26 26
  * SOFTWARE.
27 27
  */
28 28
 
29
-if (!is_callable('RandomCompat_intval')) {
29
+if (!is_callable('RandomCompat_intval'))
30
+{
30 31
     
31 32
     /**
32 33
      * Cast to an integer if we can, safely.
@@ -47,9 +48,12 @@  discard block
 block discarded – undo
47 48
      */
48 49
     function RandomCompat_intval($number, $fail_open = false)
49 50
     {
50
-        if (is_int($number) || is_float($number)) {
51
+        if (is_int($number) || is_float($number))
52
+        {
51 53
             $number += 0;
52
-        } elseif (is_numeric($number)) {
54
+        }
55
+        elseif (is_numeric($number))
56
+        {
53 57
             /** @psalm-suppress InvalidOperand */
54 58
             $number += 0;
55 59
         }
@@ -65,9 +69,12 @@  discard block
 block discarded – undo
65 69
             $number = (int) $number;
66 70
         }
67 71
 
68
-        if (is_int($number)) {
72
+        if (is_int($number))
73
+        {
69 74
             return (int) $number;
70
-        } elseif (!$fail_open) {
75
+        }
76
+        elseif (!$fail_open)
77
+        {
71 78
             throw new TypeError(
72 79
                 'Expected an integer.'
73 80
             );
Please login to merge, or discard this patch.
Sources/random_compat/random_bytes_libsodium_legacy.php 1 patch
Braces   +20 added lines, -9 removed lines patch added patch discarded remove patch
@@ -26,7 +26,8 @@  discard block
 block discarded – undo
26 26
  * SOFTWARE.
27 27
  */
28 28
 
29
-if (!is_callable('random_bytes')) {
29
+if (!is_callable('random_bytes'))
30
+{
30 31
     /**
31 32
      * If the libsodium PHP extension is loaded, we'll use it above any other
32 33
      * solution.
@@ -42,16 +43,20 @@  discard block
 block discarded – undo
42 43
      */
43 44
     function random_bytes($bytes)
44 45
     {
45
-        try {
46
+        try
47
+        {
46 48
             /** @var int $bytes */
47 49
             $bytes = RandomCompat_intval($bytes);
48
-        } catch (TypeError $ex) {
50
+        }
51
+        catch (TypeError $ex)
52
+        {
49 53
             throw new TypeError(
50 54
                 'random_bytes(): $bytes must be an integer'
51 55
             );
52 56
         }
53 57
 
54
-        if ($bytes < 1) {
58
+        if ($bytes < 1)
59
+        {
55 60
             throw new Error(
56 61
                 'Length must be greater than 0'
57 62
             );
@@ -66,19 +71,25 @@  discard block
 block discarded – undo
66 71
          * \Sodium\randombytes_buf() doesn't allow more than 2147483647 bytes to be
67 72
          * generated in one invocation.
68 73
          */
69
-        if ($bytes > 2147483647) {
70
-            for ($i = 0; $i < $bytes; $i += 1073741824) {
74
+        if ($bytes > 2147483647)
75
+        {
76
+            for ($i = 0; $i < $bytes; $i += 1073741824)
77
+            {
71 78
                 $n = ($bytes - $i) > 1073741824
72 79
                     ? 1073741824
73 80
                     : $bytes - $i;
74 81
                 $buf .= Sodium::randombytes_buf((int) $n);
75 82
             }
76
-        } else {
83
+        }
84
+        else
85
+        {
77 86
             $buf .= Sodium::randombytes_buf((int) $bytes);
78 87
         }
79 88
 
80
-        if (is_string($buf)) {
81
-            if (RandomCompat_strlen($buf) === $bytes) {
89
+        if (is_string($buf))
90
+        {
91
+            if (RandomCompat_strlen($buf) === $bytes)
92
+            {
82 93
                 return $buf;
83 94
             }
84 95
         }
Please login to merge, or discard this patch.
Sources/random_compat/random_bytes_libsodium.php 1 patch
Braces   +20 added lines, -9 removed lines patch added patch discarded remove patch
@@ -26,7 +26,8 @@  discard block
 block discarded – undo
26 26
  * SOFTWARE.
27 27
  */
28 28
 
29
-if (!is_callable('random_bytes')) {
29
+if (!is_callable('random_bytes'))
30
+{
30 31
     /**
31 32
      * If the libsodium PHP extension is loaded, we'll use it above any other
32 33
      * solution.
@@ -42,16 +43,20 @@  discard block
 block discarded – undo
42 43
      */
43 44
     function random_bytes($bytes)
44 45
     {
45
-        try {
46
+        try
47
+        {
46 48
             /** @var int $bytes */
47 49
             $bytes = RandomCompat_intval($bytes);
48
-        } catch (TypeError $ex) {
50
+        }
51
+        catch (TypeError $ex)
52
+        {
49 53
             throw new TypeError(
50 54
                 'random_bytes(): $bytes must be an integer'
51 55
             );
52 56
         }
53 57
 
54
-        if ($bytes < 1) {
58
+        if ($bytes < 1)
59
+        {
55 60
             throw new Error(
56 61
                 'Length must be greater than 0'
57 62
             );
@@ -62,21 +67,27 @@  discard block
 block discarded – undo
62 67
          * generated in one invocation.
63 68
          */
64 69
         /** @var string|bool $buf */
65
-        if ($bytes > 2147483647) {
70
+        if ($bytes > 2147483647)
71
+        {
66 72
             $buf = '';
67
-            for ($i = 0; $i < $bytes; $i += 1073741824) {
73
+            for ($i = 0; $i < $bytes; $i += 1073741824)
74
+            {
68 75
                 $n = ($bytes - $i) > 1073741824
69 76
                     ? 1073741824
70 77
                     : $bytes - $i;
71 78
                 $buf .= \Sodium\randombytes_buf($n);
72 79
             }
73
-        } else {
80
+        }
81
+        else
82
+        {
74 83
             /** @var string|bool $buf */
75 84
             $buf = \Sodium\randombytes_buf($bytes);
76 85
         }
77 86
 
78
-        if (is_string($buf)) {
79
-            if (RandomCompat_strlen($buf) === $bytes) {
87
+        if (is_string($buf))
88
+        {
89
+            if (RandomCompat_strlen($buf) === $bytes)
90
+            {
80 91
                 return $buf;
81 92
             }
82 93
         }
Please login to merge, or discard this patch.
Themes/default/Admin.template.php 1 patch
Braces   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -742,7 +742,7 @@
 block discarded – undo
742 742
 
743 743
 	// Filter out any redundant separators before we start the loop
744 744
 	$context['config_vars'] = array_filter($context['config_vars'], function ($v) use ($context)
745
-		{
745
+	{
746 746
 			static $config_vars, $prev;
747 747
 
748 748
 			$at_start = is_null($config_vars);
Please login to merge, or discard this patch.
Sources/ManageSmileys.php 1 patch
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1965,7 +1965,9 @@
 block discarded – undo
1965 1965
 	// Remove anything that isn't actually new from our list of files
1966 1966
 	foreach ($to_unset as $key => $ids)
1967 1967
 	{
1968
-		if (array_reduce($ids, function ($carry, $item) { return $carry * $item; }, true) == true)
1968
+		if (array_reduce($ids, function ($carry, $item)
1969
+		{
1970
+return $carry * $item; }, true) == true)
1969 1971
 			unset($smiley_files[$key]);
1970 1972
 	}
1971 1973
 
Please login to merge, or discard this patch.
Sources/Subs-Post.php 1 patch
Braces   -1 removed lines patch added patch discarded remove patch
@@ -1254,7 +1254,6 @@
 block discarded – undo
1254 1254
 
1255 1255
 		return array($charset, $string, 'base64');
1256 1256
 	}
1257
-
1258 1257
 	else
1259 1258
 		return array($charset, $string, '7bit');
1260 1259
 }
Please login to merge, or discard this patch.
other/upgrade.php 1 patch
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -3205,7 +3205,9 @@
 block discarded – undo
3205 3205
 		return $string;
3206 3206
 
3207 3207
 	// This bit fixes incorrect string lengths, which can happen if the character encoding was changed (e.g. conversion to UTF-8)
3208
-	$new_string = preg_replace_callback('~\bs:(\d+):"(.*?)";(?=$|[bidsa]:|[{}]|N;)~s', function ($matches) {return 's:' . strlen($matches[2]) . ':"' . $matches[2] . '";';}, $string);
3208
+	$new_string = preg_replace_callback('~\bs:(\d+):"(.*?)";(?=$|[bidsa]:|[{}]|N;)~s', function ($matches)
3209
+	{
3210
+return 's:' . strlen($matches[2]) . ':"' . $matches[2] . '";';}, $string);
3209 3211
 
3210 3212
 	// @todo Add more possible fixes here. For example, fix incorrect array lengths, try to handle truncated strings gracefully, etc.
3211 3213
 
Please login to merge, or discard this patch.